[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay updated this revision to Diff 476360. MaskRay marked an inline comment as done. MaskRay added a comment. add a comment about the zlib header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885 Files:

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

mgorny added inline comments. Comment at: clang/CMakeLists.txt:97 # Seek installed Lit. -find_program(LLVM_LIT - NAMES llvm-lit lit.py lit - PATHS "${LLVM_MAIN_SRC_DIR}/utils/lit" - DOC "Path to lit.py") +if (NOT

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138258/new/ https://reviews.llvm.org/D138258

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

akuegel added a comment. Fixed it in https://reviews.llvm.org/D138266 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 ___ cfe-commits mailing list

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, then wouldn't it be better to do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7a1d9e4aec: [Driver] move FreeBSD header search path management to the driver (authored by mhjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ba7a1d9 - [Driver] move FreeBSD header search path management to the driver

Author: Matt Jacobson Date: 2022-11-18T02:29:49-05:00 New Revision: ba7a1d9e4aec5399e9cd45e47c7a548b1514b8ba URL: https://github.com/llvm/llvm-project/commit/ba7a1d9e4aec5399e9cd45e47c7a548b1514b8ba DIFF: https://github.com/llvm/llvm-project/commit/ba7a1d9e4aec5399e9cd45e47c7a548b1514b8ba.diff

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3935856 , @goldstein.w.n wrote: > In D137181#3935752 , @owenpan wrote: > >> Please mark review comments as done if you have addressed them. Can you also >> clean up the test

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

akuegel added a comment. This introduced a dependency cycle: .-> @llvm-project//llvm:Analysis (2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767) | @llvm-project//llvm:ProfileData (2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767) | |

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false);

[PATCH] D138234: [clang-format] Support new file formatting with vim

owenpan added inline comments. Comment at: clang/tools/clang-format/clang-format.py:48 import vim +import os.path Can you move it up to keep the module names sorted? Comment at: clang/tools/clang-format/clang-format.py:80 lines =

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3935752 , @owenpan wrote: > Please mark review comments as done if you have addressed them. Can you also > clean up the test cases, removing overlapping/redundant ones, making sure a > test case doesn't end

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:69-75 + if (Line.InMacroBody) { +Indent = (Line.PPLevel + 1) * PPIndentWidth; +Indent += (Line.Level - Line.PPLevel - 1) * Style.IndentWidth; +Indent +=

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476337. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

MaskRay added a comment. > This matches OpenBSD, and it supports Swift's use of clang for its C interop > functionality. Recent changes to Swift use AddClangSystemIncludeArgs() to > inspect the cc1 args; this doesn't work for platforms where cc1 adds standard > include paths implicitly. Use a

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476336. mhjacobson added a comment. Make the tests play nice with Windows path separators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files:

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 476334. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 14 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749-751 + const Descriptor::MetadataSize MDSize{sizeof(InlineDescriptor)}; + Descriptor *D = + P.createDescriptor(Src, Ty, MDSize, IsConst,

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. This fixes a bug where tests would be disabled when LLVM_EXTERNAL_LIT was set if lit couldn't be found in

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:838 + // If this changes PPLevel needs to be used for get correct indentation. + assert(!(Line.InMacroBody && InPPDirective)); return Line.Level * Style.IndentWidth + Length <= ColumnLimit;

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. Yeah quite complex: https://godbolt.org/z/8T5Pqadro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/ https://reviews.llvm.org/D131295 ___ cfe-commits mailing list

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. Please mark review comments as done if you have addressed them. Can you also clean up the test cases, removing overlapping/redundant ones, making sure a test case doesn't end with a newline (e.g., line 5380), etc? Comment at:

[clang] 34ab474 - [opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm

Author: Alexander Shaposhnikov Date: 2022-11-18T05:04:07Z New Revision: 34ab474348e2623cc67abddb7bb662385297ac65 URL: https://github.com/llvm/llvm-project/commit/34ab474348e2623cc67abddb7bb662385297ac65 DIFF:

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

This revision was automatically updated to reflect the committed changes. Closed by commit rGab9eac762c35: [OpenMP] Initial parsing/sema for strict modifier with grainsize clause (authored by mdfazlay, committed by mikerice). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ab9eac7 - [OpenMP] Initial parsing/sema for 'strict' modifier with 'grainsize' clause

Author: Fazlay Rabbi Date: 2022-11-17T20:59:07-08:00 New Revision: ab9eac762c35068e77f57795e660d06f578c9614 URL: https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614 DIFF: https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614.diff

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

rjmccall added a comment. I'm too often slow to actually apply edits to the ABI document. There's been plenty of time for feedback on this one; go ahead and act like it's accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126818/new/ https://reviews.llvm.org/D126818

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

sammccall added a comment. (please update the commit message too since the design changed) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137909/new/ https://reviews.llvm.org/D137909 ___ cfe-commits

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Fantastic, thanks! Comment at: clang-tools-extra/clangd/unittests/Annotations.h:29 - Position point(llvm::StringRef Name = "") const; + clangd::Position

[clang] 9f61479 - [clang][Parser][NFC] Simplify ParseParenExprOrCondition

Author: Timm Bäder Date: 2022-11-18T04:53:59+01:00 New Revision: 9f614790073999c2da69101c77b783a90c1af5ca URL: https://github.com/llvm/llvm-project/commit/9f614790073999c2da69101c77b783a90c1af5ca DIFF: https://github.com/llvm/llvm-project/commit/9f614790073999c2da69101c77b783a90c1af5ca.diff

[clang] e78a43d - [clang][Parse][NFC] Remove unused CommaLocs parameters

Author: Timm Bäder Date: 2022-11-18T04:54:00+01:00 New Revision: e78a43dacafb8b97fc377a52f8f206e37d94d5d6 URL: https://github.com/llvm/llvm-project/commit/e78a43dacafb8b97fc377a52f8f206e37d94d5d6 DIFF: https://github.com/llvm/llvm-project/commit/e78a43dacafb8b97fc377a52f8f206e37d94d5d6.diff

[PATCH] D138194: [clang][Parser][NFC] Simplify ParseParenExprOrCondition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6147900739: [clang][Parser][NFC] Simplify ParseParenExprOrCondition (authored by tbaeder). Changed prior to commit:

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:236 + using UseSetTy = SmallSet; + using DefMapTy = DenseMap; + NoQ wrote: > This extra payload wasn't advertised but it's very useful because it's hard > to jump from `VarDecl`

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

NoQ added a comment. > My biggest request is: please try to keep this document in sync with reality > so that we don't introduce confusion to the reviews. Yes, so we'll need the code to incrementally catch up to the document, but I'm absolutely updating this document every time the vision

[clang] 1614d63 - [NFC] Remove unused codes after 4a7be42d922af

Author: Chuanqi Xu Date: 2022-11-18T11:52:44+08:00 New Revision: 1614d6340597d29ca8214acc2eff80df50392d36 URL: https://github.com/llvm/llvm-project/commit/1614d6340597d29ca8214acc2eff80df50392d36 DIFF: https://github.com/llvm/llvm-project/commit/1614d6340597d29ca8214acc2eff80df50392d36.diff

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476320. mhjacobson added a comment. Herald added a subscriber: mstorsjo. Style fixes. Ensure include paths are sequential. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

MaskRay added a comment. In D137753#3935617 , @francii wrote: > In D137753#3935391 , @MaskRay wrote: > >> In D137753#3935305 , @francii >> wrote: >> >>> Recall that the

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

MaskRay created this revision. MaskRay added reviewers: francii, hubert.reinterpretcast, cebowleratibm, thesamesam, brad. Herald added subscribers: StephenFan, krytarowski, arichardson, emaste. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:236 + using UseSetTy = SmallSet; + using DefMapTy = DenseMap; + This extra payload wasn't advertised but it's very useful because it's hard to jump from `VarDecl` to `DeclStmt`

[PATCH] D138254: [llvm] Remove LLVM_VERSION_SUFFIX from created shared library names

brad created this revision. brad added reviewers: thieta, tstellar, beanz. brad added a project: LLVM. Herald added a subscriber: krytarowski. Herald added a project: All. brad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. In D137753#3935391 , @MaskRay wrote: > In D137753#3935305 , @francii wrote: > >> Recall that the goal with `-p` is to create parity with GCC (at least with >> Linux and AIX), as per the

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ created this revision. NoQ added reviewers: aaron.ballman, gribozavr2, xazax.hun, jkorous, t-rasmud, ziqingluo-90, malavikasamak. Herald added subscribers: steakhal, martong, rnkovacs. Herald added a project: All. NoQ requested review of this revision. This patch adds more abstractions that

[clang] d584468 - [C++20] [Modules] Don't emit macro definitions with named module

Author: Chuanqi Xu Date: 2022-11-18T11:11:17+08:00 New Revision: d5844685810980399397a4310b943532361790ef URL: https://github.com/llvm/llvm-project/commit/d5844685810980399397a4310b943532361790ef DIFF: https://github.com/llvm/llvm-project/commit/d5844685810980399397a4310b943532361790ef.diff

[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

inclyc added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137839/new/ https://reviews.llvm.org/D137839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7be42d922a: [C++20] [Modules] Remove unmaintained Header Module (authored by ChuanqiXu). Herald added a subscriber: MaskRay. Changed prior to commit:

[PATCH] D131295: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D131295#3935027 , @Trass3r wrote: > Thanks, it seems to fix the base case, but I still see multiple lenses when I > add > > template > int Foo::foo() > { > return 0; > } Interesting, I see the same issue

[clang] 4a7be42 - [C++20] [Modules] Remove unmaintained Header Module

Author: Chuanqi Xu Date: 2022-11-18T10:39:33+08:00 New Revision: 4a7be42d922af0e2a60e08cbac062f57666c0003 URL: https://github.com/llvm/llvm-project/commit/4a7be42d922af0e2a60e08cbac062f57666c0003 DIFF: https://github.com/llvm/llvm-project/commit/4a7be42d922af0e2a60e08cbac062f57666c0003.diff

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab9c02bd97f: [Clang] Fix behavior of -ffp-model option when overriden (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D137618?vs=475981=476309#toc Repository: rG LLVM Github

[clang] cab9c02 - [Clang] Fix behavior of -ffp-model option when overriden

Author: Qiu Chaofan Date: 2022-11-18T10:34:41+08:00 New Revision: cab9c02bd97f520cb8a01a9197505438581f7de8 URL: https://github.com/llvm/llvm-project/commit/cab9c02bd97f520cb8a01a9197505438581f7de8 DIFF: https://github.com/llvm/llvm-project/commit/cab9c02bd97f520cb8a01a9197505438581f7de8.diff

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai added a comment. Thanks for reviews! It was a long journey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 ___ cfe-commits mailing list

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa65d5309d5b7: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing. (authored by vsapsai). Repository: rG LLVM Github

[clang] a65d530 - [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

Author: Volodymyr Sapsai Date: 2022-11-17T18:31:32-08:00 New Revision: a65d5309d5b73527efcbdec49a3ba9bba0fd873d URL: https://github.com/llvm/llvm-project/commit/a65d5309d5b73527efcbdec49a3ba9bba0fd873d DIFF:

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak added inline comments. Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:251 + FileID MainID = SM.getMainFileID(); + std::string MainFilename; + jansvoboda11 wrote: > This can be `StringRef` I think. I simplified this part by removing the code that

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak updated this revision to Diff 476306. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Also, change check string in test case to fix pre-merge checks that were failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf marked an inline comment as done. qiucf added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137618/new/ https://reviews.llvm.org/D137618 ___ cfe-commits mailing list

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

vsapsai added a comment. Should admit that approach with `DiagOpts.IgnoreWarnings` is pretty blunt but I'm not aware of any reasons to use something more elaborate, like stripping away all `-Werror=...` flags. So going with a simple change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

vsapsai created this revision. vsapsai added reviewers: jansvoboda11, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before the fix the scanning would

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. In D137043#3935129 , @aaronpuchert wrote: > This include-if-exists mechanism seems brittle to me. Do you mean the way that we used to test a file and include it (inserting `#if __has_include`) is brittle or compilation

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 476303. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 476302. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu added a comment. Thanks for every one to review this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. In D138179#3934543 , @MaskRay wrote: > Rubber stamp. I try to find some mips folks who can verify, so maybe wait a > day or so. > >> When we use llc or lld to compiler IR files, the features +nan2008 and >> +fpxx/+fp64 are not

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7059a6c32cfa: [IR] Split out IR printing passes into IRPrinter (authored by alexander-shaposhnikov). Changed prior to commit:

[clang] 7059a6c - [IR] Split out IR printing passes into IRPrinter

Author: Alexander Shaposhnikov Date: 2022-11-18T01:47:56Z New Revision: 7059a6c32cfad8f272fad47265e3890cd7a1a7e1 URL: https://github.com/llvm/llvm-project/commit/7059a6c32cfad8f272fad47265e3890cd7a1a7e1 DIFF:

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130326/new/ https://reviews.llvm.org/D130326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] dcb71b5 - [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-11-17T17:22:03-08:00 New Revision: dcb71b5e1d1311c41f409c8dab26e04b084875be URL: https://github.com/llvm/llvm-project/commit/dcb71b5e1d1311c41f409c8dab26e04b084875be DIFF:

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb71b5e1d13: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches. (authored by vsapsai). Repository: rG LLVM Github Monorepo

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

tlively created this revision. tlively added reviewers: aheejin, maratyszcza. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/KCFI.h:24 +public: + KCFIPass() {} + static bool isRequired() { return true; } remove default constructor? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

MaskRay added a comment. In D137753#3935305 , @francii wrote: > Recall that the goal with `-p` is to create parity with GCC (at least with > Linux and AIX), as per the RFC discussion. > > In D137753#3935138 ,

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie created this revision. dblaikie added reviewers: clang-vendors, rsmith, probinson, rjmccall. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://llvm.org/pr58819 - clang is giving an

[clang-tools-extra] 4620254 - [CMake] Remove a duplicate clangLex entry

Author: Fangrui Song Date: 2022-11-18T00:58:04Z New Revision: 46202543c9ba4dd2aca355b3b553ce9caeed9a80 URL: https://github.com/llvm/llvm-project/commit/46202543c9ba4dd2aca355b3b553ce9caeed9a80 DIFF: https://github.com/llvm/llvm-project/commit/46202543c9ba4dd2aca355b3b553ce9caeed9a80.diff LOG:

[clang-tools-extra] f962daf - [include-cleaner] Fix -DBUILD_SHARED_LIBS=on build

Author: Fangrui Song Date: 2022-11-18T00:56:04Z New Revision: f962dafbbdf61234bfa51bde95e2e5c52a02e9b9 URL: https://github.com/llvm/llvm-project/commit/f962dafbbdf61234bfa51bde95e2e5c52a02e9b9 DIFF: https://github.com/llvm/llvm-project/commit/f962dafbbdf61234bfa51bde95e2e5c52a02e9b9.diff LOG:

[clang-tools-extra] 2483a7f - [include-cleaner] Fix the build of include-cleaner with LLVM_BUILD_LLVM_DYLIB=ON

Author: Alexander Shaposhnikov Date: 2022-11-18T00:54:45Z New Revision: 2483a7fffbdf8e04addfbbf9f333155edc2c0346 URL: https://github.com/llvm/llvm-project/commit/2483a7fffbdf8e04addfbbf9f333155edc2c0346 DIFF:

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt created this revision. Herald added a project: All. davidtgoldblatt updated this revision to Diff 476281. davidtgoldblatt added a comment. davidtgoldblatt updated this revision to Diff 476283. davidtgoldblatt retitled this revision from "[builtins] add separate storage builtin

[clang] 6536a67 - [Linux] Revert 1e56821bac02a5d3c6249bbf3ef43b8b569d2551

Author: Brad Smith Date: 2022-11-17T19:48:01-05:00 New Revision: 6536a67338fceece914746d3f654e5f2e881f73b URL: https://github.com/llvm/llvm-project/commit/6536a67338fceece914746d3f654e5f2e881f73b DIFF: https://github.com/llvm/llvm-project/commit/6536a67338fceece914746d3f654e5f2e881f73b.diff

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. Recall that the goal with `-p` is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion. In D137753#3935138 , @MaskRay wrote: > In D137753#3935126 ,

[clang] a72d8d7 - Update lambda mangling test to C++17

Author: David Blaikie Date: 2022-11-18T00:24:40Z New Revision: a72d8d704178118b254d9ff84a78afb18813b888 URL: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888 DIFF: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888.diff

[PATCH] D138227: [OPENMP]Initial support for severity clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e054e6b522b: [OPENMP5.1] Initial support for severity clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1e054e6 - [OPENMP5.1] Initial support for severity clause

Author: Jennifer Yu Date: 2022-11-17T16:05:02-08:00 New Revision: 1e054e6b522b3f7e13c30caebfa63aafc7173220 URL: https://github.com/llvm/llvm-project/commit/1e054e6b522b3f7e13c30caebfa63aafc7173220 DIFF: https://github.com/llvm/llvm-project/commit/1e054e6b522b3f7e13c30caebfa63aafc7173220.diff

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138217/new/ https://reviews.llvm.org/D138217 ___ cfe-commits mailing list

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 476260. samitolvanen added a comment. Dropped the CodeGen dependency. Note that Clang already only adds KCFIPass for targets that don't support back-end lowering, so the check in the pass itself was a bit redundant. The existing CodeGen/kcfi.c test

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands updated this revision to Diff 476261. anderslanglands added a comment. Added release note, incorporated other review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137818/new/ https://reviews.llvm.org/D137818 Files:

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3926404 , @stella.stamenova wrote: > In D135128#3921902 , @jansvoboda11 > wrote: > >> @stella.stamenova Any updates? > > We haven't had time to come up with a proper

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay updated this revision to Diff 476259. mdfazlay added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added corresponding definitions in// llvm/include/llvm/Frontend/OpenMP/OMP.td// file. CHANGES SINCE LAST ACTION

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. In D138157#3935173 , @phosek wrote: > Is the plan to eventually rename `scudo_standalone` to `scudo` once the > santiizer-based Scudo implementation is deleted? Ideally, yes (as well as make scudo_standalone not be in a

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

phosek added a comment. Is the plan to eventually rename `scudo_standalone` to `scudo` once the santiizer-based Scudo implementation is deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

doru1004 closed this revision. doru1004 added a comment. Commit: 98bfd7f976f166e2eb7b444f3ee86843815ca73c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/

[clang] 98bfd7f - Fix declare target implementation to support enter.

Author: Doru Bercea Date: 2022-11-17T17:35:53-06:00 New Revision: 98bfd7f976f166e2eb7b444f3ee86843815ca73c URL: https://github.com/llvm/llvm-project/commit/98bfd7f976f166e2eb7b444f3ee86843815ca73c DIFF: https://github.com/llvm/llvm-project/commit/98bfd7f976f166e2eb7b444f3ee86843815ca73c.diff

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

MaskRay added a comment. In D137753#3935126 , @francii wrote: > In D137753#3934932 , @MaskRay wrote: > >> Please make `-p` accepted for AIX only and don't change the semantics for >> other targets in this patch.

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

aaronpuchert added a comment. This include-if-exists mechanism seems brittle to me. Can we not make it dependent on the triple, i.e. include the file if we're using a libc implementation that's known to provide (and require) this file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. In D137753#3934932 , @MaskRay wrote: > Please make `-p` accepted for AIX only and don't change the semantics for > other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try > rejecting `-p`. If OpenBSD wants

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG8003c1d61e69: [clang-tidy] Fix misc-unused-using-decls for user-defined literals (authored by v1nh1shungry, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8003c1d - [clang-tidy] Fix misc-unused-using-decls for user-defined literals

Author: v1nh1shungry Date: 2022-11-17T22:47:15Z New Revision: 8003c1d61e69142cb6e87df719c17f3c4ad86c98 URL: https://github.com/llvm/llvm-project/commit/8003c1d61e69142cb6e87df719c17f3c4ad86c98 DIFF: https://github.com/llvm/llvm-project/commit/8003c1d61e69142cb6e87df719c17f3c4ad86c98.diff LOG:

[clang] fc91c70 - Revert D135411 "Add generic KCFI operand bundle lowering"

Author: Fangrui Song Date: 2022-11-17T22:45:30Z New Revision: fc91c705937d7ba3b92da38f3a883dde720c41f2 URL: https://github.com/llvm/llvm-project/commit/fc91c705937d7ba3b92da38f3a883dde720c41f2 DIFF: https://github.com/llvm/llvm-project/commit/fc91c705937d7ba3b92da38f3a883dde720c41f2.diff LOG:

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:16 +#include "llvm/ADT/Statistic.h" +#include "llvm/CodeGen/TargetLowering.h" +#include "llvm/CodeGen/TargetSubtargetInfo.h" Sorry, I just noticed this include.

[clang] c9320bc - [X86] Use correctly sized floating point literals in *zero_ps/pd.

Author: Craig Topper Date: 2022-11-17T14:28:52-08:00 New Revision: c9320bc87121af2a198f174c8d58f75295efbbd7 URL: https://github.com/llvm/llvm-project/commit/c9320bc87121af2a198f174c8d58f75295efbbd7 DIFF: https://github.com/llvm/llvm-project/commit/c9320bc87121af2a198f174c8d58f75295efbbd7.diff

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added inline comments. Comment at: llvm/docs/GwpAsan.rst:174 ++-++ -| PerfectlyRightAlign| false | When allocations are right-aligned, should we

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 476241. hctim marked 2 inline comments as done. hctim added a comment. Remove unrelated diff from doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 Files:

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. Thanks, it seems to be that simple case, but I still see multiple lenses when I add template int Foo::foo() { return 0; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/

  1   2   3   >