[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3941201 , @erichkeane wrote: > [...] particularly since the suggested wording says the opposite of what I > THOUGHT the discussion was doing at the end? > [...] We might find ourselves wanting to hold off until CWG

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } owenpan wrote: > HazardyKnusperkeks wrote: > > owenpan wrote: > > > ```

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } HazardyKnusperkeks wrote: > owenpan wrote: > > ``` > > error: reference

[PATCH] D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation.

steakhal added a comment. As I was reading I'll highlighted some typos. `compile time` -> `compile-time` /g By the looks of it, this document is not referenced anywhere. I believe `clang/docs/index.rst` should refer to this document in some place. Thanks for the huge effort driving this you

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands updated this revision to Diff 477085. anderslanglands added a comment. Now tested by adding a -print-qualified-type-names flag to c-index-test and creating a (small) dedicated test in print-qualified-type.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } owenpan

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

pcwang-thead added a comment. The test `clang/test/Driver/pic.c` failed when we compiled Clang/LLVM with `-DCLANG_DEFAULT_PIE_ON_LINUX=False`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137044/new/ https://reviews.llvm.org/D137044

<    1   2   3