[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:192 +"p1689-targeted-directory", llvm::cl::Optional, +llvm::cl::desc("Only supported for P1689, the targeted directory of which " +

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ChuanqiXu updated this revision to Diff 477687. ChuanqiXu added a comment. Use `--` instead `-` for parameters in tests to avoid confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 Files: clang/test/ClangScanDeps/P1689.cppm

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[clang] e690a34 - AST: Internalize functions after D111283

Author: Fangrui Song Date: 2022-11-23T22:53:23-08:00 New Revision: e690a346454958372de0ec1c762544864e9f5406 URL: https://github.com/llvm/llvm-project/commit/e690a346454958372de0ec1c762544864e9f5406 DIFF: https://github.com/llvm/llvm-project/commit/e690a346454958372de0ec1c762544864e9f5406.diff

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:269 val = FIRST_32_SECOND_64(1152, 1776); +#elif SANITIZER_LOONGARCH64 + val = 1936; MaskRay wrote: > We should add new code in this fallback

[PATCH] D138547: [X86][AMX] Fix typo of the headerfile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG55fceef61e0d: [X86][AMX] Fix typo of the headerfile. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138547/new/

[clang] 55fceef - [X86][AMX] Fix typo of the headerfile.

Author: Luo, Yuanke Date: 2022-11-24T10:33:44+08:00 New Revision: 55fceef61e0d244f2bbfc01c41eab43a77437aec URL: https://github.com/llvm/llvm-project/commit/55fceef61e0d244f2bbfc01c41eab43a77437aec DIFF: https://github.com/llvm/llvm-project/commit/55fceef61e0d244f2bbfc01c41eab43a77437aec.diff

[PATCH] D138630: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there a no overrides.

vsapsai created this revision. vsapsai added reviewers: egorzhdan, akyrtzi. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Incorrect `isOverriding` flag triggers the assertion `!Overridden.empty()` in

[PATCH] D138628: [clang-fuzzer] Use new pass manager for optimizing IR

aeubanks updated this revision to Diff 477658. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138628/new/ https://reviews.llvm.org/D138628 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp Index:

[PATCH] D138628: [clang-fuzzer] Use new pass manager for optimizing IR

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138628 Files:

[PATCH] D138547: [X86][AMX] Fix typo of the headerfile.

xiangzhangllvm accepted this revision. xiangzhangllvm added a comment. This revision is now accepted and ready to land. LGTM， thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138547/new/ https://reviews.llvm.org/D138547

[PATCH] D138463: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG437ccf5af9c2: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables (authored by Ben Dunbobbin ben.dunbob...@sony.com). Herald added a project: clang. Repository: rG LLVM

[clang] 437ccf5 - [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

Author: Ben Dunbobbin Date: 2022-11-24T00:23:17Z New Revision: 437ccf5af9c2aec915a68a164a95d506fbac2324 URL: https://github.com/llvm/llvm-project/commit/437ccf5af9c2aec915a68a164a95d506fbac2324 DIFF: https://github.com/llvm/llvm-project/commit/437ccf5af9c2aec915a68a164a95d506fbac2324.diff

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

MaskRay added a comment. This looks very interesting and I wish that I can help as well (but I'll likely spend very little time in December due to holidays:) ). Hmm, I can't find it in an email archive. Perhaps there hasn't been a discussion so people are unaware of this work... Repository:

[PATCH] D138626: [Vectorize] Remove legacy passes

aeubanks created this revision. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, ormris, foad, kerbowa, hiraditya, jvesely, arsenm. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision.

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 477634. Prabhuk marked an inline comment as done. Prabhuk added a comment. Herald added a subscriber: wenlei. Added tests to the new UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 477622. Prabhuk marked an inline comment as done. Prabhuk added a comment. Herald added a subscriber: pengfei. Introducing a new toolchain for UEFI COFF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477620. hctim marked 2 inline comments as done. hctim added a comment. Move isMemtag below assert(Sym) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files:

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 created this revision. doru1004 added reviewers: carlo.bertolli, ronl, ABataev, jhuber6. doru1004 added a project: OpenMP. Herald added subscribers: kosarev, jeroen.dobbelaere, guansong, tpr, dstuttard, yaxunl, kzhuravl. Herald added a project: All. doru1004 requested review of this

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

fmayer added inline comments. Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); Is the story here that on

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34bcadc38c22: Use std::nullopt_t instead of NoneType (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477600. hctim added a comment. Use new MemtagABI section types, now that it's merged upstream: https://github.com/ARM-software/abi-aa/blob/main/memtagabielf64/memtagabielf64.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134177: Add MC support of RISCV Zcd Extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dbc52a0ab3c: Add MC support of RISCV Zcd Extension (authored by VincentWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/

[clang] 0dbc52a - Add MC support of RISCV Zcd Extension

Author: WuXinlong Date: 2022-11-24T05:48:06+08:00 New Revision: 0dbc52a0ab3c2b32f729e985d62401ce9bd9853e URL: https://github.com/llvm/llvm-project/commit/0dbc52a0ab3c2b32f729e985d62401ce9bd9853e DIFF: https://github.com/llvm/llvm-project/commit/0dbc52a0ab3c2b32f729e985d62401ce9bd9853e.diff

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay added a comment. In D137885#3947532 , @dyung wrote: > @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. > Most of the errors look similar to this: > > error: 'error' diagnostics seen but not expected: >

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LWG3823 says that arrays of incomplete types are aggregates. Fix the clang builtin to match that. Repository:

[clang] 8f43b84 - [ASTReader] Fix zlib header detection 0x78 after D137885

Author: Fangrui Song Date: 2022-11-23T13:22:44-08:00 New Revision: 8f43b84322cc255414ad996834dff09e90dc19af URL: https://github.com/llvm/llvm-project/commit/8f43b84322cc255414ad996834dff09e90dc19af DIFF: https://github.com/llvm/llvm-project/commit/8f43b84322cc255414ad996834dff09e90dc19af.diff

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

steakhal added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:90 + /// returns an empty list if no fixes are necessary. + virtual Optional getFixits(const Strategy &) const { +return None; steakhal wrote: > I wonder if we should

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. Thanks for the detailed information folks. I'll probably fix it up and re-submit next week (after the US holidays) given that the blast radius seems to be bigger than I expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. In D137885#3947532 , @dyung wrote: > @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. > Most of the errors look similar to this: > > error: 'error' diagnostics seen but not expected: >

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. Most of the errors look similar to this: error: 'error' diagnostics seen but not expected: (frontend): malformed or corrupted AST file: 'LLVM was not built with LLVM_ENABLE_ZSTD or did

[PATCH] D138598: [OpenMP] Do not add wrapper headers if using '-nogpuinc'

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138598/new/ https://reviews.llvm.org/D138598

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

MaskRay added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:218 + explicit NameLookup(std::nullopt_t) : Data(nullptr, true) {} explicit NameLookup(std::nullptr_t) : Data(nullptr, false) {} NameLookup() : NameLookup(nullptr) {}

[PATCH] D138552: [docs] Document that the modules can improve the linking time

MaskRay added a comment. This seems comparing different things... As mentioned, header files can be refactored to reduce the number of symbols as well. I'd be curious to learn how linking time can be reduced significantly by deploying modules. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138598: [OpenMP] Do not add wrapper headers if using '-nogpuinc'

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield, ye-luo. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald

[clang] fa7bc38 - [modules] Support zstd in .pcm file

Author: Fangrui Song Date: 2022-11-23T11:27:49-08:00 New Revision: fa7bc386ec7565ccfdfa75b272079ee03604e3ba URL: https://github.com/llvm/llvm-project/commit/fa7bc386ec7565ccfdfa75b272079ee03604e3ba DIFF: https://github.com/llvm/llvm-project/commit/fa7bc386ec7565ccfdfa75b272079ee03604e3ba.diff

[PATCH] D137885: [modules] Support zstd in .pcm file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa7bc386ec75: [modules] Support zstd in .pcm file (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie created this revision. dblaikie added reviewers: aprantl, probinson. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. dblaikie requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders updated this revision to Diff 477566. tom-anders added a comment. Add end-to-end test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137894/new/ https://reviews.llvm.org/D137894 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375

[clang] 2cea4c2 - Do not suggest taking the address of a const pointer to get void*

Author: Alexey Kreshchuk Date: 2022-11-23T18:43:06Z New Revision: 2cea4c239570c37f46ad0003b3d41d9473aca60f URL: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f DIFF: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f.diff

[PATCH] D138426: Fix #58958 on github

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cea4c239570: Do not suggest taking the address of a const pointer to get void* (authored by krsch, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539

[PATCH] D138552: [docs] Document that the modules can improve the linking time

dblaikie added a comment. I'm not sure I follow this - the comparison doesn't seem equal. If you wanted the modules-like code in non-modules, you could get it by having `notDirectlyUsed` declared-but-not-defined in the header file, and defined in the corresponding .cpp file, yeah?

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477554. VitaNuo added a comment. Make explicit RefType default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files:

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson marked an inline comment as done. royjacobson added a comment. In D138387#3944211 , @cor3ntin wrote: > Beside the formatting nitpick this looks good Thanks! I'll wait until next week to let other people have a chance to take a look.

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson marked 3 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14462-14467 + RLoc, CurFPFeatureOverrides()); +else + TheCall = + CallExpr::Create(Context, FnExpr.get(),

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477551. VitaNuo added a comment. Remove the extra test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson updated this revision to Diff 477550. royjacobson added a comment. Add a missing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138387/new/ https://reviews.llvm.org/D138387 Files: clang/docs/ReleaseNotes.rst

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477549. VitaNuo added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ben.boeckel added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:192 +"p1689-targeted-directory", llvm::cl::Optional, +llvm::cl::desc("Only supported for P1689, the targeted directory of which " + "the dependencies are to be

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

steakhal added a comment. Are you sure about the speedup? When I looked at the implementation of the `StringSwitch`, it boiled down to an `if-else` chain under the hood. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137258/new/

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. the precommit bot is still complaining that flang/lib/Frontend/FrontendActions.cpp needs to be updated lgtm if the precommit bot doesn't show anything related to this patch Repository:

[PATCH] D138426: Fix #58958 on github

dblaikie added a comment. In D138426#3947044 , @aeubanks wrote: > In D138426#3946202 , @krsch wrote: > >> Should I change the title myself or you can change it during commit? If it's >> on me, how do I change

[PATCH] D138426: Fix #58958 on github

aeubanks added a comment. In D138426#3946202 , @krsch wrote: > Should I change the title myself or you can change it during commit? If it's > on me, how do I change it? `git commit --amend; arc diff`? phabricator isn't very elegant, locally changing

[PATCH] D138577: Use proper triple in CmdArgsSansAnalyses for html info files

angroyer added a reviewer: honggyu.kim. angroyer added a comment. Please review this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138577/new/ https://reviews.llvm.org/D138577 ___ cfe-commits

[PATCH] D138583: Create unused non-trivially-destructible check in clang-tidy

ankineri created this revision. ankineri added a reviewer: sammccall. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ankineri requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

tmatheson created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. tmatheson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements assembly support for the

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[PATCH] D138577: Use proper triple in CmdArgsSansAnalyses for html info files

angroyer created this revision. angroyer added a reviewer: LLVM. angroyer added a project: LLVM. Herald added a reviewer: NoQ. Herald added a project: All. angroyer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The CmdArgsSansAnalyses

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

steakhal added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:54-55 + bool TraverseDecl(Decl *Node) { +if (!Node) + return true; +if (!match(*Node)) Can `Node` be ever null if the visitor is initiated only be `AST_MATCHER_P`?

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hans added a comment. Reverted in 907baeec49bfbe9e76498634a9418e1dc6c973d9 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 ___ cfe-commits mailing

[PATCH] D138319: [analyzer] Prepare structures for integral cast feature introducing

steakhal added a comment. I spent some time on this patch. But I'm left thinking about why we need the extra indirection? Couldn't we just use a `std::pair` pair as a key instead? You mention //effective// bitwidths in your summary, but the code does not mention this concept. Maybe you could

[PATCH] D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready

Joe_Nash accepted this revision. Joe_Nash added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138216/new/ https://reviews.llvm.org/D138216

[PATCH] D136603: [analyzer] getBinding should auto-detect type only if it was not given

This revision was automatically updated to reflect the committed changes. Closed by commit rG93b98eb399a1: [analyzer] getBinding should auto-detect type only if it was not given (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D136603?vs=471112=477493#toc Repository:

[clang] 93b98eb - [analyzer] getBinding should auto-detect type only if it was not given

Author: Balazs Benics Date: 2022-11-23T15:52:11+01:00 New Revision: 93b98eb399a14f2c626ed82eaaa70997f8323406 URL: https://github.com/llvm/llvm-project/commit/93b98eb399a14f2c626ed82eaaa70997f8323406 DIFF: https://github.com/llvm/llvm-project/commit/93b98eb399a14f2c626ed82eaaa70997f8323406.diff

Re: [clang] 5cfc22c - Revert "[SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes"

Thank you! On Wed, Nov 23, 2022 at 3:11 PM Benjamin Kramer via cfe-commits wrote: > > > Author: Benjamin Kramer > Date: 2022-11-23T13:11:16+01:00 > New Revision: 5cfc22cafe3f2465e0bb324f8daba82ffcabd0df > > URL: >

[PATCH] D138559: Record macro references in #ifdef clause.

hokein added a comment. Thanks, this code looks good to me overall. I think we can extend it to handle the `Defined`, `Elifdef`, `Elifndef` cases. And please add a `[include-cleaner]` prefix in the commit title. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:95

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

ismaelJimenez updated this revision to Diff 477488. ismaelJimenez added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138571/new/ https://reviews.llvm.org/D138571 Files: clang/docs/LibASTMatchersTutorial.rst Index:

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

ismaelJimenez created this revision. Herald added a project: All. ismaelJimenez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138571 Files:

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 updated this revision to Diff 477482. Origami404 added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134177: Add MC support of RISCV Zcd Extension

VincentWu updated this revision to Diff 477475. VincentWu added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://reviews.llvm.org/D134177 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 477471. sgraenitz added a comment. Handle potential multi-color basic blocks in addOpBundleForFunclet() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944 Files:

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 477470. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rebase and update check-lines after D137939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 updated this revision to Diff 477467. njames93 added a comment. Hopefully fixed line endings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 Files: clang/include/clang/AST/Decl.h

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hans added a comment. Chromium is broken too CMake Error at /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/cmake/modules/AddLLVM.cmake:1915 (add_dependencies): The dependency target "ScudoUnitTests" of target "check-runtimes" does not exist. Call Stack (most recent call first):

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477461. VitaNuo added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG19ab2a671eb3: [include-cleaner] Show includes matched by refs in HTML report. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 19ab2a6 - [include-cleaner] Show includes matched by refs in HTML report.

Author: Sam McCall Date: 2022-11-23T13:41:24+01:00 New Revision: 19ab2a671eb32bede5a0bf686aebf3c6838848e3 URL: https://github.com/llvm/llvm-project/commit/19ab2a671eb32bede5a0bf686aebf3c6838848e3 DIFF: https://github.com/llvm/llvm-project/commit/19ab2a671eb32bede5a0bf686aebf3c6838848e3.diff

[PATCH] D138566: [clang-tidy][NFC] Make CheckFactories::CreateChecks* const

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D138564: Format changes with clang-format

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138564 Files:

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 updated this revision to Diff 477453. Origami404 added a comment. Change implements according reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https://reviews.llvm.org/D137043 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137399: [clang][Interp] Emit negated integers directly as constants

tbaeder abandoned this revision. tbaeder added a comment. This was just to make the byte code a little more readable, but given the amount of pending patches I already have, I'll abandon this and maybe revisit at a later point, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137386/new/ https://reviews.llvm.org/D137386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5cfc22c - Revert "[SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes"

Author: Benjamin Kramer Date: 2022-11-23T13:11:16+01:00 New Revision: 5cfc22cafe3f2465e0bb324f8daba82ffcabd0df URL: https://github.com/llvm/llvm-project/commit/5cfc22cafe3f2465e0bb324f8daba82ffcabd0df DIFF:

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

DavidSpickett added a comment. We (Linaro) also have an issue with a bot that uses `-DCOMPILER_RT_BUILD_SANITIZERS=OFF`. https://lab.llvm.org/buildbot/#/builders/178/builds/3318 CMake Error at cmake/modules/AddLLVM.cmake:1915 (add_dependencies): The dependency target "ScudoUnitTests" of

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

ebrevnov updated this revision to Diff 477446. ebrevnov marked an inline comment as done. ebrevnov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138491: [clangd] Add script to maintain list of fast clang-tidy checks

sammccall updated this revision to Diff 477443. sammccall added a comment. Script reads/writes from file rather than redirecting output. Update .inc file to show "no-op" changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138491/new/

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Records macro references in #ifdef clauses as ambiguous. Repository: rG LLVM Github Monorepo

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall planned changes to this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:518 + +if (F.SlowChecks.has_value()) + Out.Apply.push_back([V = **F.SlowChecks](const Params &, Config ) { kadircet

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 477437. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 10 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.h:141-145 unsigned getAllocSize() const { return AllocSize; } /// returns the size of an element when the structure is viewed as an array. unsigned

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

kadircet added a comment. i can't think of a proper way to test this out either. unless we somehow let slow-tidy-check list to be configurable, so probably fine to make sure it works locally and hope that new people introducing tidy checks do complain. Comment at:

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:487 + } + CTFactories = std::move(FastFactories); +} njames93 wrote: > Not exactly related but surely both check factories could be made into static > variables

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. lldb parts LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539 ___ cfe-commits

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

sgraenitz updated this revision to Diff 477433. sgraenitz added a comment. clang-format includes and sort clang-formatted-files.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138122/new/ https://reviews.llvm.org/D138122 Files:

  1   2   >