[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:197 +llvm::cl::opt P1689TargetedCommand( +"p1689-targeted-command", llvm::cl::Optional, +llvm::cl::desc("Only supported for P1689, the

[PATCH] D138552: [docs] Document that the modules can improve the linking time

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. In D138552#3951462 , @dblaikie wrote: >> And another problem here is, without LTO, the function definitions in other >> TU can't be inlined. But now, the function definitions in the module

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling updated this revision to Diff 478124. tangyouling added a comment. Add the missing $t0-$t8 in internal_clone(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138489/new/ https://reviews.llvm.org/D138489 Files:

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 478113. to268 marked 5 inline comments as done. to268 added a comment. Added test cases and added an explicit `auto*` diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

arsenm added inline comments. Herald added subscribers: kosarev, ormris. Herald added a project: All. Comment at: llvm/lib/Transforms/IPO/Annotation2Metadata.cpp:51 +auto *StrGEP = dyn_cast(OpC->getOperand(1)); +if (!StrGEP || StrGEP->getNumOperands() < 2) +

[PATCH] D138681: [AVR] Fix broken bitcast for aliases in non-zero address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG131cddcba2c4: [AVR] Fix broken bitcast for aliases in non-zero address space (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138681/new/

[clang] 131cddc - [AVR] Fix broken bitcast for aliases in non-zero address space

Author: Ayke van Laethem Date: 2022-11-27T15:27:42+01:00 New Revision: 131cddcba2c4c953a8a49d7adbf656cab9e9f1c7 URL: https://github.com/llvm/llvm-project/commit/131cddcba2c4c953a8a49d7adbf656cab9e9f1c7 DIFF:

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1324 +if ((NewRC != nullptr) != (OldRC != nullptr)) + // RC are most certainly different - these are overloads. + return true; I know it's preexisting but, I'm not sure

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito added a reviewer: yaxunl. ManuelJBrito added a comment. Couldn't find documentation for this intrinsic, can you shed a light on whether or not this change is OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138755/new/

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito created this revision. ManuelJBrito added a project: AMDGPU. Herald added subscribers: kosarev, jvesely. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use poison instead of undef

[PATCH] D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature

tmatheson created this revision. tmatheson added reviewers: lenary, pratlucas, dmgreen, tschuett, DavidSpickett. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. tmatheson requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,