[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

nridge added a comment. In D138546#4017356 , @ArcsinX wrote: > In other words, with this patch we preserve `--target=...`, but this option > can appear from >

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e added a comment. Also, could you add "Fixes #58974" in the commit message so that the item will be closed automatically upon commiting ? Thtanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 485457. ChuanqiXu added a comment. Address comments: Reject the command line if it specifies -fmodule-output and multiple arch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files:

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e added a comment. The pre-merge checks seem to have some issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___ cfe-commits mailing list

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a subscriber: nridge. cpsauer added a comment. Ooh interesting. Thanks for your careful look, @ArcsinX. To check my understanding: Sounds like, more generally, commands get massaged into clang argument form before they're passed into the query-driver machinery, which can break

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rG5a3a527f8ae2: [OpenMP] Introduce basic JIT support to OpenMP target offloading (authored by

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 485451. tianshilei1992 added a comment. fix compile error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/CMakeLists.txt

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. In D139287#4018071 , @ronlieb wrote: > seems like this broke the amdgpu buildbot , plz resolve > https://lab.llvm.org/buildbot/#/builders/193/builds/24122 Reverted. Will fix it soon. Repository: rG LLVM Github

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

ronlieb added a comment. seems like this broke the amdgpu buildbot , plz resolve https://lab.llvm.org/buildbot/#/builders/193/builds/24122 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287

[PATCH] D140692: [RISCV] Add Svpbmt extension support.

fakepaper56 updated this revision to Diff 485447. fakepaper56 added a comment. Suppress lint warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140692/new/ https://reviews.llvm.org/D140692 Files:

[PATCH] D140692: [RISCV] Add Svpbmt extension support.

fakepaper56 updated this revision to Diff 485446. fakepaper56 added a comment. Fix typoes and add svpbmt into llvm/docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140692/new/ https://reviews.llvm.org/D140692 Files:

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

SixWeining added a comment. In D140690#4017693 , @browneee wrote: > Who will use DFSan on loongarch64? > > Who will maintain DFSan on loongarch64? > > Is there a loongarch64 buildbot? Hi @browneee, I'm the co-author of this patch. Thanks for your

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

vctr created this revision. Herald added a project: All. vctr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140711 Files: clang/lib/Sema/SemaConcept.cpp Index:

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rG58906e4901ec: [OpenMP] Introduce basic JIT support to OpenMP target offloading (authored by

[PATCH] D140707: Use a long-established error code instead of a newfangled one which causes portability problems

he32 created this revision. Herald added a subscriber: krytarowski. Herald added a project: All. he32 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the long-established `operation_not_supported` instead of the rather newfangled

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140434/new/ https://reviews.llvm.org/D140434

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

glaubitz accepted this revision. glaubitz added a comment. Tested and works as expected. Thanks a lot for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat updated this revision to Diff 485407. merrymeerkat added a comment. Change TODO to FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140696/new/ https://reviews.llvm.org/D140696 Files:

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:276-277 + + StringRef RawData(CGOutputBuffer.begin(), CGOutputBuffer.size()); + return

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 485406. tianshilei1992 added a comment. rebase and fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/CMakeLists.txt

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140703: [clang][dataflow] Unify `TransferOptions` and `DataflowAnalysisContext::Options`.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Merges `TransferOptions` into the

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp added a comment. I'm happy with the check now, feel free to review! I have run it on the LLVM repo and it seems to do what it's supposed to (including fix-its). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp updated this revision to Diff 485396. carlosgalvezp added a comment. Narrow warnings further, and provide fix-its. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/ https://reviews.llvm.org/D140290 Files:

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

browneee added a comment. Who will use DFSan on loongarch64? Who will maintain DFSan on loongarch64? Is there a loongarch64 buildbot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140690/new/ https://reviews.llvm.org/D140690

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

craig.topper added a comment. This doesn't seem correct What's the priority among those options for now(w/o this patch)? Pipeline model: Take from -mtune if present. Take from -mcpu if present Use the default pipeline model: generic-rv32 or generic-rv64 Architecture extension:

[PATCH] D140307: Match derived types in in modernize-loop-convert

ccotter added a comment. @njames93 would you mind taking a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 ___ cfe-commits mailing list

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 485393. ymandel added a comment. address comments; fix lifetime bug in new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files:

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

craig.topper added a comment. So if I read this correctly, the effect of this is that we never pass `-target-cpu` to the backend after this patch and will only pass `-target-feature` and `-tune-cpu`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added subscribers: erichkeane, ldionne, aaron.ballman. Mordante added a comment. In D139986#4017467 , @dblaikie wrote: > In D139986#4008169 , @Mordante > wrote: > >> In D139986#4005997

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:147-148 + // Returns the subset of fields of `Type` that are referenced in

[PATCH] D140678: [RISCV][WIP] Use SmallVector::append to replace some for loops in intrinsic creation. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d323e7e51c6: [RISCV] Use SmallVector::append to replace some for loops in intrinsic creation. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6d323e7 - [RISCV] Use SmallVector::append to replace some for loops in intrinsic creation. NFC

Author: Craig Topper Date: 2022-12-27T09:57:05-08:00 New Revision: 6d323e7e51c6a58b44b6b1a982bbda7edfd962fb URL: https://github.com/llvm/llvm-project/commit/6d323e7e51c6a58b44b6b1a982bbda7edfd962fb DIFF: https://github.com/llvm/llvm-project/commit/6d323e7e51c6a58b44b6b1a982bbda7edfd962fb.diff

[PATCH] D140699: [clang] Make ValuesCode initialisation of Options constexpr

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, nikic. Herald added a subscriber: hiraditya. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

myhsu accepted this revision. myhsu added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:276-277 + + StringRef RawData(CGOutputBuffer.begin(), CGOutputBuffer.size()); + return MemoryBuffer::getMemBufferCopy(RawData); +} tianshilei1992

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a straightfoward way to

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: 0x59616e, myhsu, efriedma, glaubitz. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros Repository: rG LLVM Github Monorepo

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, the model for structs

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:276-277 + + StringRef RawData(CGOutputBuffer.begin(), CGOutputBuffer.size()); + return MemoryBuffer::getMemBufferCopy(RawData); +} jhuber6

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 485375. tianshilei1992 marked 10 inline comments as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

dblaikie added a comment. Oh, and I meant to mention https://buildkite.com/llvm-project/libcxx-ci/builds/16118#01851abb-f13e-4977-91df-b4274402b65a doesn't seem, at least to my cursory reading, to show diagnostic checking failures, but crashes? Is there something broken in the UI that's meant

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

dblaikie added a comment. In D139986#4008169 , @Mordante wrote: > In D139986#4005997 , @dblaikie > wrote: > >> In D139986#4003873 , @Mordante >> wrote: >> >>> In

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added a comment. (pulling this out from an inline comment, because it's hard to quote/smaller than it needs to be for more complex discussions): > Oh, thanks for finding this. It is pretty bad that I didn't image we can > specify multiple input module units in one command line. > >>

[PATCH] D140692: [RISCV] Add Svbmpt extension support.

kito-cheng added a comment. You are typo on title and commit log, it should be `Svpbmt` not `Svbmpt`, but the code changes are right, and you need to update `llvm/docs/RISCVUsage.rst` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140692/new/

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng created this revision. kito-cheng added reviewers: craig.topper, asb, reames. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D140692: [RISCV] Add Svbmpt extension support.

fakepaper56 created this revision. fakepaper56 added reviewers: kito-cheng, craig.topper, asb, reames. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D140687: [Clang][RISCV] Use poison instead of undef

eopXD updated this revision to Diff 485371. eopXD added a comment. Update leftout test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140687/new/ https://reviews.llvm.org/D140687 Files: clang/test/CodeGen/RISCV/riscv-attr-builtin-alias.c

[PATCH] D140687: [Clang][RISCV] Use poison instead of undef

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM, thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140687/new/ https://reviews.llvm.org/D140687

[PATCH] D140685: [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions

xen0n added a comment. > MOVGR2FCSR modifies the value of the software writable field > corresponding to the FCSR (floating-point control and status > register) fcsr according to the value of the lower 32 bits of > the GR (general purpose register) rj. The description of `movgr2fcsr` is

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

tangyouling created this revision. tangyouling added reviewers: Sanitizers, browneee, kcc, SixWeining, xen0n, xry111, MaskRay, XiaodongLoong. Herald added subscribers: Enna1, StephenFan, dberris. Herald added a project: All. tangyouling requested review of this revision. Herald added projects:

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

ArcsinX added a comment. It seems this patch can break GCC toolchains support This patch expects that we never get target-related options in `CommandLine` passed to `extractSystemIncludesAndTarget()` for **GCC** toolchain. But seems this is not always true because of

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vcompress.c:514 // CHECK-RV64-NEXT: entry: -// CHECK-RV64-NEXT:[[TMP0:%.*]] = call @llvm.riscv.vcompress.nxv1i32.i64( poison, [[SRC:%.*]], [[MASK:%.*]], i64 [[VL:%.*]]) -//

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 485363. eopXD added a comment. Update code, recovered ManualCodeGen for vcompress and vmerge. Deleted the `std::rotate` since it is not needed now due to the operand order change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140678: [RISCV][WIP] Use SmallVector::append to replace some for loops in intrinsic creation. NFC

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. Thank you for the patch. We can land this and then I have D140662 rebase upon it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140687: [Clang][RISCV] Use poison instead of undef

eopXD created this revision. eopXD added reviewers: kito-cheng, nlopes, craig.topper, khchen. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD added a comment. This patch is not ready yet since currently we don't have a pull request under rvv-intrinsic-doc to match to this. The pull request will be created in the near future. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vcompress.c:514 //

[PATCH] D136817: [RISCV] Add H extension

kito-cheng updated this revision to Diff 485360. kito-cheng added a comment. Changes: - Rebase to main - Add negative test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 Files:

[PATCH] D140686: [Clang][RISCV] Update operand order for vmerge and vcompress

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D140685: [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions

XiaodongLoong created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. XiaodongLoong requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Instruction formats: `movgr2fcsr fcsr, rj` `movfcsr2gr

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

chriselrod added inline comments. Comment at: clang/test/SemaCXX/GH59624.cpp:10-12 +struct CFoo{ +const int x{0}; +}; This isn't needed for the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140664/new/