[PATCH] D141310: [clang] add -Wcompare-function-pointers

dblaikie added a comment. @adriandole do you plan to deploy this in a codebase? Have you tried it on a codebase already? I'd worry this would just be too noisy, and there's probably enough benign pointer comparisons that'll never hit the ICF false-equality situation (eg: putting some

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4052031 , @erichkeane wrote: > In D131858#4052026 , @v.g.vassilev > wrote: > >> Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and >>

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:73 + +if(WIN32 OR (LINUX AND WINDOWS_SDK_DIR)) +#if(WINDOWS_SDK_DIR) I'd drop this part altogether, let's build these anytime when `WINDOWS_SDK_DIR` is set.

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

alexander-shaposhnikov updated this revision to Diff 489322. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141744/new/ https://reviews.llvm.org/D141744 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaCXX/attr-lifetimebound.cpp

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 489317. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/clangd/GlobalCompilationDatabase.cpp

[clang-tools-extra] 91682b2 - Remove redundant initialization of std::optional (NFC)

Author: Kazu Hirata Date: 2023-01-14T14:06:18-08:00 New Revision: 91682b2631b224a9f6dca9512b5e0951cc4a7762 URL: https://github.com/llvm/llvm-project/commit/91682b2631b224a9f6dca9512b5e0951cc4a7762 DIFF: https://github.com/llvm/llvm-project/commit/91682b2631b224a9f6dca9512b5e0951cc4a7762.diff

[clang] b53e0d1 - Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2023-01-14T13:53:40-08:00 New Revision: b53e0d1b341f142e6d27e53058141d283837fbbd URL: https://github.com/llvm/llvm-project/commit/b53e0d1b341f142e6d27e53058141d283837fbbd DIFF: https://github.com/llvm/llvm-project/commit/b53e0d1b341f142e6d27e53058141d283837fbbd.diff

[clang] 2d86143 - [clang] Remove remaining uses of llvm::Optional (NFC)

Author: Kazu Hirata Date: 2023-01-14T13:37:25-08:00 New Revision: 2d861436a9eb789bb70a3644393b21e548240ac6 URL: https://github.com/llvm/llvm-project/commit/2d861436a9eb789bb70a3644393b21e548240ac6 DIFF: https://github.com/llvm/llvm-project/commit/2d861436a9eb789bb70a3644393b21e548240ac6.diff

[PATCH] D140775: [clangd] Hover: show CalleeArgInfo for literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG343b1ae3622a: [clangd] Hover: show CalleeArgInfo for literals and expressions (authored by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 343b1ae - [clangd] Hover: show CalleeArgInfo for literals and expressions

Author: Tom Praschan Date: 2023-01-14T23:20:42+01:00 New Revision: 343b1ae3622afed50c9734a8f40b368d8afef5c5 URL: https://github.com/llvm/llvm-project/commit/343b1ae3622afed50c9734a8f40b368d8afef5c5 DIFF: https://github.com/llvm/llvm-project/commit/343b1ae3622afed50c9734a8f40b368d8afef5c5.diff

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson created this revision. royjacobson added reviewers: erichkeane, aaron.ballman. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working on D140664

[PATCH] D141768: [WIP][11/N][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

eopXD updated this revision to Diff 489306. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141768/new/ https://reviews.llvm.org/D141768 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D141767: [WIP][10/N][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy` and `isTUPolicy`

eopXD updated this revision to Diff 489305. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141767/new/ https://reviews.llvm.org/D141767 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h Index:

[PATCH] D141764: [WIP][9/N][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

eopXD updated this revision to Diff 489304. eopXD added a comment. Dump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141764/new/ https://reviews.llvm.org/D141764 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D141762: [WIP][8/N][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

eopXD updated this revision to Diff 489303. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141762/new/ https://reviews.llvm.org/D141762 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D141759: [WIP][7/N][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

eopXD updated this revision to Diff 489302. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h Index:

[PATCH] D141756: [WIP][6/N][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

eopXD updated this revision to Diff 489301. eopXD added a comment. I was mistaken. Nothing was mistakenly fused. Recover the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141756/new/ https://reviews.llvm.org/D141756 Files:

[PATCH] D141768: [WIP][11/N][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

eopXD updated this revision to Diff 489298. eopXD added a comment. Rebase to latset main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141768/new/ https://reviews.llvm.org/D141768 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D141767: [WIP][10/N][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy` and `isTUPolicy`

eopXD updated this revision to Diff 489297. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141767/new/ https://reviews.llvm.org/D141767 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D141764: [WIP][9/N][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

eopXD updated this revision to Diff 489296. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141764/new/ https://reviews.llvm.org/D141764 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D141762: [WIP][8/N][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

eopXD updated this revision to Diff 489295. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141762/new/ https://reviews.llvm.org/D141762 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:674 +else if (const auto *ND = dyn_cast(Context)) { + if (ND->isInlineNamespace()) +Scopes.AccessibleScopes.push_back(printQualifiedName(*ND) + "::");

[PATCH] D141759: [WIP][7/N][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

eopXD updated this revision to Diff 489294. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D141756: [WIP][6/N][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

eopXD updated this revision to Diff 489293. eopXD added a comment. Rebase upon latest main. Also [10/N] was mistakenly fused into this patch. Removed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141756/new/ https://reviews.llvm.org/D141756

[PATCH] D141754: [WIP][5/N][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD updated this revision to Diff 489292. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 489291. carlosgalvezp added a comment. Remove buggy empty extension for ImplementationFilesExtension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000 Files:

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 489289. carlosgalvezp added a comment. Add missing empty header extension to the default list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000 Files:

[PATCH] D141577: [WIP][4/N][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

eopXD updated this revision to Diff 489288. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141577/new/ https://reviews.llvm.org/D141577 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp Index:

[PATCH] D141575: [WIP][3/N][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

eopXD updated this revision to Diff 489287. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141575/new/ https://reviews.llvm.org/D141575 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp Index:

[PATCH] D141574: [WIP][2/N][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

eopXD updated this revision to Diff 489286. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141574/new/ https://reviews.llvm.org/D141574 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D141573: [WIP][1/N][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

eopXD updated this revision to Diff 489285. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141573/new/ https://reviews.llvm.org/D141573 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders updated this revision to Diff 489284. tom-anders added a comment. Address review comment: Introduce new AccessibleScopes variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140915/new/ https://reviews.llvm.org/D140915 Files:

[PATCH] D140954: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 489283. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D141772: [clang][Interp] Fix record initialization via CallExpr subclasses

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can't just use VisitCallExpr() here, as that

[PATCH] D140947: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

eopXD updated this revision to Diff 489281. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140947/new/ https://reviews.llvm.org/D140947 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

tbaeder added a comment. > This diff is motivated by https://github.com/llvm/llvm-project/issues/59900 Not https://github.com/llvm/llvm-project/issues/60020 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141744/new/

[PATCH] D140942: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

eopXD updated this revision to Diff 489279. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140942/new/ https://reviews.llvm.org/D140942 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:151-152 Options.WarningsAsErrors = ""; + Options.HeaderFileExtensions = {"h", "hh", "hpp", "hxx"}; + Options.ImplementationFileExtensions = {"c", "cc", "cpp", "cxx"};

[PATCH] D141770: [clang-tidy][NFC] Use C++17 nested namespaces in the clang-tidy folder

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Assuming the pre-merge is happy, this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141770/new/ https://reviews.llvm.org/D141770

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

njames93 added a comment. On the topic of Objective-C, they use `.m` and `.M` extensions, it may be worth pointing out that this list is case sensitive (I'm assuming that's going to be the case.) Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:151-152

[PATCH] D141741: Add some subdirectories to the list of Abseil paths.

njames93 added a comment. Can you update some of the tests to make use of these new directories as well as update the release notes to mention these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141741/new/

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:172 +void TypeTraitsCheck::registerMatchers(MatchFinder *Finder) { + static const

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

carlosgalvezp abandoned this revision. carlosgalvezp added a comment. Merged into https://reviews.llvm.org/D141770 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141769/new/ https://reviews.llvm.org/D141769

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:311-314 + # TODO: remove below replacement when all clang-tidy checks have been + # updated with C++17 nested namespaces. replaceInFileRegex(filename, 'namespace ' +

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:109-110 +- Use C++17 nested namespaces in `add_new_check.py` and `rename_check.py`. + New checks njames93 wrote: > Such a trivial change like this probably doesn't need

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:311 filename = fileRename(filename, old_module_path, new_module_path) + # TODO: remove below replacement when all clang-tidy checks have been + # updated with C++17

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:311-314 + # TODO: remove below replacement when all clang-tidy checks have been + # updated with C++17 nested namespaces. replaceInFileRegex(filename, 'namespace ' +

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

njames93 accepted this revision. njames93 added a comment. LGTM, just a couple points Comment at: clang-tools-extra/clang-tidy/rename_check.py:311-314 + # TODO: remove below replacement when all clang-tidy checks have been + # updated with C++17 nested namespaces.

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. But will be good idea if other eyes will look too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141769/new/

[PATCH] D141760: [clangd] fix extract function tweak signature spelling out lambda types

5chmidti abandoned this revision. 5chmidti added a comment. Nvmd, `Wrapped` won't work. I'll look into this some more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141760/new/ https://reviews.llvm.org/D141760

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

carlosgalvezp updated this revision to Diff 489271. carlosgalvezp added a comment. Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141769/new/ https://reviews.llvm.org/D141769 Files:

[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D140941: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

eopXD updated this revision to Diff 489268. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140941/new/ https://reviews.llvm.org/D140941 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D140936: [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics

eopXD updated this revision to Diff 489265. eopXD added a comment. Rebase to latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140936/new/ https://reviews.llvm.org/D140936 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

eopXD updated this revision to Diff 489264. eopXD added a comment. Rebase to latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140895/new/ https://reviews.llvm.org/D140895 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 489263. carlosgalvezp added a comment. Merge release notes into one line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000 Files:

[PATCH] D141762: [WIP][8/N][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

eopXD updated this revision to Diff 489260. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141762/new/ https://reviews.llvm.org/D141762 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D141768: [WIP][11/N][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D141767: [WIP][10/N][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy` and `isTUPolicy`

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

nathanchance added a comment. > In D139114#4053166 , @nathanchance > wrote: > >> For what it’s worth, this triggers a LOT in the Linux kernel for the pattern >> that @MaskRay pointed out: > > Out of curiosity, has it found any true positives that you

[PATCH] D141764: [WIP][9/N][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

eopXD updated this revision to Diff 489255. eopXD added a comment. Bump CI upon update of preceeding patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141764/new/ https://reviews.llvm.org/D141764 Files: clang/utils/TableGen/RISCVVEmitter.cpp

[PATCH] D141762: [WIP][8/N][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

eopXD updated this revision to Diff 489254. eopXD added a comment. Bump CI upon update of preceeding patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141762/new/ https://reviews.llvm.org/D141762 Files: clang/utils/TableGen/RISCVVEmitter.cpp

[PATCH] D141759: [WIP][7/N][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

eopXD updated this revision to Diff 489252. eopXD added a comment. Update code: default is TAMU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759 Files:

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff created this revision. sepavloff added reviewers: rjmccall, kpn, aaron.ballman. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Operations on floating-point complex data had incorrect FP attributes in strictfp mode, because

[PATCH] D141764: [WIP][9/N][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D141762: [WIP][8/N][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

eopXD updated this revision to Diff 489245. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141762/new/ https://reviews.llvm.org/D141762 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D141762: [WIP][8/N][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me, but please improve Release Notes. Will be good idea to wait for developers approval. Comment at:

[PATCH] D141760: [clangd] fix extract function tweak signature spelling out lambda types

5chmidti created this revision. 5chmidti added reviewers: sammccall, nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. 5chmidti requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141759: [WIP][7/N][Clang][RISCV][NFC] Correct the default value for Policy to undisturbed

eopXD updated this revision to Diff 489234. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h Index:

[PATCH] D141759: [WIP][7/N][Clang][RISCV][NFC] Correct the default value for Policy to undisturbed

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Marking as changes requested so it's clear this isn't ready to re-land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

aaron.ballman added a comment. In D139114#4053022 , @chapuni wrote: > Excuse me, I have reverted this. > > Before landing this, could you please fix new warnings in the current > codebase, please? Thank you for the revert (and good to see you again!).

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

5chmidti updated this revision to Diff 489232. 5chmidti added a comment. Add change to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 Files:

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

5chmidti created this revision. 5chmidti added reviewers: sammccall, nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. 5chmidti requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. I'll take care of fixing this up on Tuesday (Mon is a holiday here), but if anyone wants to get to it sooner, what I plan to do is: - Add a new `Extension` diagnostic about allowing you to define a type in `__builtin_offsetof` - Replace the error in C with the

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I can see why you have the desire for something that takes 22 seconds and not 16 mins! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141756: [WIP][6/N][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun accepted this revision. alvinhochun added a comment. Also lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141206/new/ https://reviews.llvm.org/D141206 ___ cfe-commits mailing list

[PATCH] D141754: [WIP][5/N][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 489217. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/clangd/GlobalCompilationDatabase.cpp

[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

SixWeining added a comment. In D141750#4053473 , @MaskRay wrote: > pip3 install --user recommonmark sphinx # sphinx-automodapi for lldb > > cmake ... > > ninja ... docs-llvm-html Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 489216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/clangd/GlobalCompilationDatabase.cpp

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 489215. dzhidzhoev added a comment. Clang-format'ted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

HazardyKnusperkeks added a comment. In D141654#4053470 , @rymiel wrote: > This also made me wonder, is there an actual policy on deprecated options? As > in, when they are actually removed. Is there even prior precedent for doing > this? (I wouldn't

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 489214. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/clangd/GlobalCompilationDatabase.cpp

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. @Eugene.Zelenko @njames93 I believe I have addressed all the outstanding comments, is there anything else you think needs fix? Otherwise I would like to land the patch before January 24th when they will start a new release. Repository: rG LLVM Github Monorepo

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 489213. carlosgalvezp added a comment. Rebase and fix formatting of "clang-tidy" in the docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000 Files:

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 489208. cpsauer added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. @nridge, I took a shot at the change you suggested. Confirming that this what you were thinking of, removing `inferTargetAndDriverMode` from database load

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. Yes, this is correct: The JITLink backend for RISC-V doesn't (yet) register the eh frames into libunwind, so throwing and catching exceptions through JITted code doesn't work (yet). I

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:172 +void TypeTraitsCheck::registerMatchers(MatchFinder *Finder) { + static const ast_matchers::internal::VariadicDynCastAllOfMatcher< + Stmt,

[PATCH] D133574: [C2x] reject type definitions in offsetof

mstorsjo added a comment. +1 on this being disruptive. Also, not only GCC, but also MSVC seem to handle the existing constructs in the wild. I ran into this at https://github.com/FFmpeg/FFmpeg/blob/n5.1.2/libavutil/video_enc_params.c#L30-L34 (where it probably would be trivial to fix, but

[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

SixWeining updated this revision to Diff 489204. SixWeining added a comment. Fix the issue "Title underline too short" reported by sphinx-build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141750/new/ https://reviews.llvm.org/D141750 Files: