[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske planned changes to this revision. balazske added a comment. I plan to improve the fix and change the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

nridge added a subscriber: adamcz. nridge added a comment. Thanks for the patch! I had a look at the code history, and it looks like the original reason for not using the param decl's type to determine the passing mode was (based on this comment )

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder updated this revision to Diff 491238. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142328/new/ https://reviews.llvm.org/D142328 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

nridge added a comment. LGTM, thanks! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:81 +- The extract variable tweak gained support for extracting complete lambda expressions to a variable. + Maybe add a "Code Actions" section for this? Repository:

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141858/new/ https://reviews.llvm.org/D141858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141591/new/ https://reviews.llvm.org/D141591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140723: [clang][Interp] Only check constructors for global variables

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140723/new/ https://reviews.llvm.org/D140723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138802/new/ https://reviews.llvm.org/D138802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb updated this revision to Diff 491237. asb added a comment. Removed FIXME missed in initial version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142327/new/ https://reviews.llvm.org/D142327 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/RISCV/abi-empty-structs.c

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder added a comment. The casts emitted are similar to https://reviews.llvm.org/D140377 now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142328/new/ https://reviews.llvm.org/D142328 ___ cfe-commits

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just like we do (or will do) for floating types,

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb created this revision. asb added reviewers: kito-cheng, jrtc27, reames, craig.topper, uweigand, luke. Herald added subscribers: wingo, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

asb created this revision. asb added reviewers: kito-cheng, reames, jrtc27, craig.topper, luke. Herald added subscribers: wingo, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142268/new/ https://reviews.llvm.org/D142268

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

dblaikie added a comment. So @Michael137 and I talked about this offline, and a few extra details: - Generally it's important that types have identical names. Templates try to do this, but get it wrong in a bunch of ways (& certainly between GCC and Clang we get it different in a bunch of ways

[PATCH] D142296: [clang-format] Fix bugs in parsing C++20 module import statements

owenpan updated this revision to Diff 491221. owenpan added a comment. Put back the inadvertently removed line `nextToken();`, which was just before the outer `while` loop in `parseModuleImport()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142296/new/

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam updated this revision to Diff 491220. thesamesam added a comment. Switch to setting CLANG_NO_DEFAULT_CONFIG via CMake instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141248/new/ https://reviews.llvm.org/D141248 Files:

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam added inline comments. Comment at: clang/bindings/python/tests/cindex/util.py:82 +# our tests. +os.environ["CLANG_NO_DEFAULT_CONFIG"] = "1" xen0n wrote: > This is essentially an import-time side effect, IMO it could be better to > instead put the

[PATCH] D142246: [HIP] Change default offload arch to gfx906

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc487b84d7552: [HIP] Change default offload arch to gfx906 (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] c487b84 - [HIP] Change default offload arch to gfx906

Author: Yaxun (Sam) Liu Date: 2023-01-22T20:26:30-05:00 New Revision: c487b84d755298b6451a823447612fda84db9522 URL: https://github.com/llvm/llvm-project/commit/c487b84d755298b6451a823447612fda84db9522 DIFF:

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

eddyz87 added a comment. Hi Yonghong, Thank you for taking care of this issue. This was sloppy on my side as the parameter name was completely irrelevant for the test. Best regards, Eduard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142046/new/

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 491204. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

dyung added a comment. In D142046#4071594 , @yonghong-song wrote: > @dyung I just pushed the fix to the 'main' branch > (https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b). > Please check it out. Thanks for

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 491201. ccotter added a comment. - Use nested namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[clang] caa99a0 - Use llvm::popcount instead of llvm::countPopulation(NFC)

Author: Kazu Hirata Date: 2023-01-22T12:48:51-08:00 New Revision: caa99a01f5dd2f865df318a2f93abc811273a25d URL: https://github.com/llvm/llvm-project/commit/caa99a01f5dd2f865df318a2f93abc811273a25d DIFF: https://github.com/llvm/llvm-project/commit/caa99a01f5dd2f865df318a2f93abc811273a25d.diff

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491197. ccotter added a comment. - Allow move of any expr containing the parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D142316: [clang] Add test for CWG2396

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also mark CWG1291 and CWG2385 as "na". P1787 :

[PATCH] D142315: [clang] Add test for CWG1111

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142315 Files:

[PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. Thanks for your contribution, I just landed this patch on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142007/new/ https://reviews.llvm.org/D142007 ___

[PATCH] D142007: [NFC] Fix "form/from" typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG898b5c9f5e77: [NFC] Fix form/from typos (authored by pfusik, committed by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 898b5c9 - [NFC] Fix "form/from" typos

Author: Piotr Fusik Date: 2023-01-22T20:05:51+01:00 New Revision: 898b5c9f5e7715f3ea4bb0ca2a8f23c301efa9c2 URL: https://github.com/llvm/llvm-project/commit/898b5c9f5e7715f3ea4bb0ca2a8f23c301efa9c2 DIFF: https://github.com/llvm/llvm-project/commit/898b5c9f5e7715f3ea4bb0ca2a8f23c301efa9c2.diff

[PATCH] D142307: [clang-tidy][NFC] Use C++17 nested namespaces in clang-tidy headers

carlosgalvezp added a comment. In D142307#4071952 , @Eugene.Zelenko wrote: > Looks OK for me, but please fix small formatting issues. Will be good idea to > await for other eyes. Thanks for the quick review! I applied clang-format to the patch; any

[PATCH] D142007: [NFC] Fix "form/from" typos

pfusik added a comment. In D142007#4072036 , @Mordante wrote: > Can you provide your name and email address to we can attribute the patch to > you? Piotr Fusik Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. In D142007#4071765 , @pfusik wrote: > @ldionne Can you check it in? Can you provide your name and email address to we can attribute the patch to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491186. ccotter added a comment. - Properly handle forwarding references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D142307: [clang-tidy][NFC] Use C++17 nested namespaces in clang-tidy headers

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me, but please fix small formatting issues. Will be good idea to await for other eyes. Comment at:

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry added a comment. Ping? @njames93 Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173 +namespace n48 { +// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1: warning: nested namespaces can be concatenated

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 491171. ccotter marked an inline comment as done. ccotter added a comment. - Use nested namespace in header too; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:19 + +namespace clang { +namespace tidy { ccotter wrote: > carlosgalvezp wrote: > > We recently switched to using C++17

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.h:41-43 +} // namespace cppcoreguidelines +} // namespace tidy +} // namespace clang Forgot to comment but you'll need it

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:19 + +namespace clang { +namespace tidy { carlosgalvezp wrote: > We recently

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 491165. ccotter added a comment. - Use nested namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files:

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

carlosgalvezp added a comment. Please note, `HeaderFileExtensions` is becoming a global option in this patch to avoid duplication, which will land in the next 2 days. https://reviews.llvm.org/D141000 Therefore you'll need to update the patch based on that. CHANGES SINCE LAST ACTION

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp requested changes to this revision. carlosgalvezp added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:19 + +namespace clang { +namespace tidy

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

carlosgalvezp added a comment. In D140434#4053053 , @suertreus wrote: > Thanks for reviewing. > > I don't have commit access; can someone who does please do the thing? @suertreus I can help you land the patch, what user name and email should I use for

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. In D141000#4071793 , @Eugene.Zelenko wrote: > D142123 also cries for it :-) Somehow I > was not able to make comments there :-( Yep, one more reason to get this in asap :) Repository:

[clang] c8d16bf - [clang][doc] Fixes formatting of a text block.

Author: Mark de Wever Date: 2023-01-22T16:21:11+01:00 New Revision: c8d16bf3048305876fe600a598a610dfedcab1ee URL: https://github.com/llvm/llvm-project/commit/c8d16bf3048305876fe600a598a610dfedcab1ee DIFF: https://github.com/llvm/llvm-project/commit/c8d16bf3048305876fe600a598a610dfedcab1ee.diff

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Eugene.Zelenko added a comment. D142123 also cries for it :-) Somehow I was not able to make comments there :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000

[PATCH] D142007: [NFC] Fix "form/from" typos

pfusik added a comment. @ldionne Can you check it in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142007/new/ https://reviews.llvm.org/D142007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

ABataev added inline comments. Comment at: clang/test/OpenMP/target_uses_allocators.c:108 // CHECK-NEXT: store i32 %[[#R1]], ptr %.x..void.addr, align 4 -// CHECK-NEXT: call void @__kmpc_free(i32 %[[#R0]], ptr %.x..void.addr, ptr inttoptr (i64 8 to ptr)) \ No newline at end of

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

xgupta created this revision. xgupta added reviewers: aaron.ballman, fahadnayyar. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compiling clang/Lex/DirectoryLookup.h with option

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. @njames93 Let me know if you are happy with the patch, I'd like to land before 24th of January :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000

[clang] a0dab49 - [clang-format][NFC] Add .clang-format to clang/tools/clang-format/

Author: Owen Pan Date: 2023-01-22T02:59:23-08:00 New Revision: a0dab49508e377bdf1ad7af314e16a8a037bc589 URL: https://github.com/llvm/llvm-project/commit/a0dab49508e377bdf1ad7af314e16a8a037bc589 DIFF: https://github.com/llvm/llvm-project/commit/a0dab49508e377bdf1ad7af314e16a8a037bc589.diff

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

This revision was automatically updated to reflect the committed changes. Closed by commit rGdadfc6b38b00: [clang-format][NFC] Set LineEnding to LF in config files (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D141098?vs=486708=491142#toc Repository: rG LLVM

[clang] dadfc6b - [clang-format][NFC] Set LineEnding to LF in config files

Author: Owen Pan Date: 2023-01-22T02:53:06-08:00 New Revision: dadfc6b38b00ff6e7c243ccc834f06d794a32b59 URL: https://github.com/llvm/llvm-project/commit/dadfc6b38b00ff6e7c243ccc834f06d794a32b59 DIFF: https://github.com/llvm/llvm-project/commit/dadfc6b38b00ff6e7c243ccc834f06d794a32b59.diff

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53a1314ed1b5: [C++20][Modules] Fix named module import diagnostics. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 53a1314 - [C++20][Modules] Fix named module import diagnostics.

Author: Iain Sandoe Date: 2023-01-22T10:22:36Z New Revision: 53a1314ed1b5021822071d3c7a751a5ec52619b7 URL: https://github.com/llvm/llvm-project/commit/53a1314ed1b5021822071d3c7a751a5ec52619b7 DIFF: https://github.com/llvm/llvm-project/commit/53a1314ed1b5021822071d3c7a751a5ec52619b7.diff LOG:

[PATCH] D142296: [clang-format] Fix bugs in parsing C++20 module import statements

owenpan updated this revision to Diff 491138. owenpan added a comment. Added test cases with `import` followed by comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142296/new/ https://reviews.llvm.org/D142296 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D142296: [clang-format] Fix bugs in parsing C++20 module import statements

owenpan updated this revision to Diff 491137. owenpan added a comment. Simplified `parseModuleImport()` a little bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142296/new/ https://reviews.llvm.org/D142296 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

xen0n added inline comments. Comment at: clang/bindings/python/tests/cindex/util.py:82 +# our tests. +os.environ["CLANG_NO_DEFAULT_CONFIG"] = "1" This is essentially an import-time side effect, IMO it could be better to instead put the envvar provision in

[PATCH] D142296: [clang-format] Fix bugs in parsing C++20 module import statements

owenpan updated this revision to Diff 491135. owenpan retitled this revision from "[clang-format] Fix a bug in parsing C++20 import statements" to "[clang-format] Fix bugs in parsing C++20 module import statements". owenpan edited the summary of this revision. owenpan added a comment. Also