[clang] 759dec2 - [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

Author: Joseph Huber Date: 2023-01-25T13:58:00-06:00 New Revision: 759dec253695f38a101c74905c819ea47392e515 URL: https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515 DIFF: https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515.diff

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder updated this revision to Diff 492205. scott.linder added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3479-3486 + /// Return the IdentTy (ident_ty) corresponding to the associated kernel. + Constant *getKernelIdent(ConstantStruct *StructC) { +GlobalVariable *KernelEnvGV =

[PATCH] D142570: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142570/new/ https://reviews.llvm.org/D142570

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

arsenm added a comment. Description not clear Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3912-3914 + Constant *KernelEnvironmentCasted = + ConstantExpr::getPointerBitCastOrAddrSpaceCast(KernelEnvironment, +

[PATCH] D142565: [clang-tidy] Fix warning in portability-simd-intrinsics

ClockMan created this revision. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ClockMan updated this revision to Diff 492167. ClockMan added a comment. ClockMan updated this revision to Diff 492169.

[PATCH] D142570: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

jhuber6 created this revision. jhuber6 added reviewers: tra, jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: mattd, gchakrabarti, asavonic, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 created this revision. Herald added subscribers: kosarev, ormris, kerbowa, guansong, hiraditya, yaxunl, jvesely. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay Could you please commit this for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing list

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:274 -if (Args.hasArg(options::OPT_pg)) { +if (Args.hasArg(options::OPT_p, options::OPT_pg)) { CmdArgs.push_back(Args.MakeArgString((llvm::Twine("-L") + D.SysRoot) +

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. Latest diff now sets the `IsDefaulted` flag from `Sema::CheckTemplateArgumentList`, which is the best point I could find for creation of `TemplateArgument` which are fed into the various specialization decls (and later on the `TypePrinter`). The review description

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 492189. francii added a comment. Remove cc1 option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492187. Michael137 added a comment. - Don't need to pass flag to NewArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[clang] cd61d2a - [clang][CodeGen][NFC] Fix `llvm-else-after-return`

Author: Michael Liao Date: 2023-01-25T13:53:35-05:00 New Revision: cd61d2abe0fdfcee52e16998f7f3fda82572cd6f URL: https://github.com/llvm/llvm-project/commit/cd61d2abe0fdfcee52e16998f7f3fda82572cd6f DIFF: https://github.com/llvm/llvm-project/commit/cd61d2abe0fdfcee52e16998f7f3fda82572cd6f.diff

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492184. Michael137 added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/PropertiesBase.td

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec446ddcee3: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr… (authored by shafik). Herald added a project: clang. Changed

[clang] 6ec446d - [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

Author: Shafik Yaghmour Date: 2023-01-25T10:49:04-08:00 New Revision: 6ec446ddcee33777a8420c227374f7b422a7df1b URL: https://github.com/llvm/llvm-project/commit/6ec446ddcee33777a8420c227374f7b422a7df1b DIFF:

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492182. Michael137 added a comment. - Set `IsDefaulted` when checking template arguments in `clang::Sema` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. ah, sorry, I think I might be conflating "kcfi-seal" with "ibt-seal?" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138337/new/ https://reviews.llvm.org/D138337 ___

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492181. danakj added a comment. Add tests for enums inside a macro, other than NS_ENUM and NS_OPTIONS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 Files:

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#4080628 , @nickdesaulniers wrote: >> If you're referring to ibt-seal, I assume a similar optimization could be >> added for BTI too. > > Yes, please. Does it make sense to add to this patch, or a follow up on

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. > If you're referring to ibt-seal, I assume a similar optimization could be > added for BTI too. Yes, please. Does it make sense to add to this patch, or a follow up on top? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 492179. iana added a comment. Revert the unnecessary changes to unspecified-var-size.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files:

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#4080615 , @nickdesaulniers wrote: > The test is for x86, does this also work for aarch64 with BTI? IBT/BTI doesn't affect this specific optimization, it's only about KCFI. If you're referring to ibt-seal, I

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. The test is for x86, does this also work for aarch64 with BTI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138337/new/ https://reviews.llvm.org/D138337 ___ cfe-commits

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492176. danakj added a comment. Improve the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added inline comments. Comment at: clang/test/Index/annotate-comments-objc.m:121 // CHECK: annotate-comments-objc.m:32:9: ObjCInstanceMethodDecl=method1_isdoxy4:{{.*}} method1_isdoxy4 IS_DOXYGEN_SINGLE -// CHECK: annotate-comments-objc.m:43:22:

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492172. danakj added a comment. Ensure the comment outside the macro is attached to enums defined inside NS_ENUM() and NS_OPTIONS() macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp:370 + const auto StorageAlignment = getAlignment(StorageType); + if (LayoutSize % StorageAlignment || Layout.getDataSize() % StorageAlignment) Packed = true; Should

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added a comment. Just a couple more I'm concerned about after thinking about it, otherwise this looks about right. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492160. VitaNuo added a comment. Refine C parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138472/new/ https://reviews.llvm.org/D138472 ___ cfe-commits mailing list

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142564 Files:

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

efriedma added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the +branches are taken or not. Maybe put a note about earlier releases, so people don't get confused if

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1);

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492151. Fznamznon added a comment. Add a case with vector of length 33 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4080317 , @erichkeane wrote: > In D142500#4080302 , @erichkeane > wrote: > >> In D142500#4080279 , @Mordante >> wrote: >> >>> In

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

erichkeane added a subscriber: mstorsjo. erichkeane added a comment. In D142500#4080302 , @erichkeane wrote: > In D142500#4080279 , @Mordante > wrote: > >> In D142500#4079669

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added inline comments. Comment at: clang/test/Index/annotate-comments-objc.m:121 // CHECK: annotate-comments-objc.m:32:9: ObjCInstanceMethodDecl=method1_isdoxy4:{{.*}} method1_isdoxy4 IS_DOXYGEN_SINGLE -// CHECK: annotate-comments-objc.m:43:22:

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

erichkeane added a comment. In D142500#4080279 , @Mordante wrote: > In D142500#4079669 , @erichkeane > wrote: > >> In D142500#4079135 , @Mordante >> wrote: >> >>> FYI I

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492141. danakj added a comment. Adding back a period that was removed from a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 Files:

[PATCH] D140250: Define NULL in its own header

dblaikie added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line:

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. How the multilib system matches user arguments is the main problem I've been struggling with. These are the options I see: 1. Grant the multilib system full access to all cc1 arguments, as demonstrated by the current code. However declare the multilib system

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj created this revision. Herald added a subscriber: arphaman. Herald added a project: All. danakj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The key part of getRawCommentForDecl() required to find a comment is determining where

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4079669 , @erichkeane wrote: > In D142500#4079135 , @Mordante > wrote: > >> FYI I tested this patch with libc++ and as expected it does not fix the >> libc++ modular build

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm added a comment. Ping. If this approach is acceptable, I think we could use it for future ACLE features too (rather than the GNU attributes that we've used previously). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139028/new/

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. Working for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138472/new/ https://reviews.llvm.org/D138472

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} kadircet wrote: > sorry for showing up late to the

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

Jake-Egan added a comment. In D142484#4079909 , @jhuber6 wrote: > In D142484#4079869 , @Jake-Egan > wrote: > >> Hi, this new test fails on AIX. Could you take a look? >>

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492130. VitaNuo added a comment. Refactor the symbol parsing loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files:

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. In D140415#4080080 , @jdoerfert wrote: > Thanks for taking a look, see my responses inline. For more information, the RFC is at https://reviews.llvm.org/D139617 > Quick questions, and they might not apply here since you seem to

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); How

[PATCH] D142555: Refactor symbol page parsing.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142555 Files:

[clang] 93aa412 - [clang][Interp][NFC] Refector OffsetHelper

Author: Timm Bäder Date: 2023-01-25T17:22:59+01:00 New Revision: 93aa4123066fb32a8e3c757ff0a280cfd93ec9f3 URL: https://github.com/llvm/llvm-project/commit/93aa4123066fb32a8e3c757ff0a280cfd93ec9f3 DIFF: https://github.com/llvm/llvm-project/commit/93aa4123066fb32a8e3c757ff0a280cfd93ec9f3.diff

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); Fznamznon wrote: > erichkeane wrote: > > tbaeder wrote: >

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492125. Fznamznon added a comment. Adjust the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/test/SemaCXX/vector-bool.cpp Index:

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

arsenm added a comment. In D142506#4078532 , @scchan wrote: > In D142506#4078402 , @arsenm wrote: > >> The resource directory should be strictly controlled. why would lib64 ever >> be used here? > > The

[clang-tools-extra] c4c5e79 - Fix warnings

Author: Kazu Hirata Date: 2023-01-25T08:21:29-08:00 New Revision: c4c5e79dd4b4c78eee7cffd9b0d7394b5bedcf12 URL: https://github.com/llvm/llvm-project/commit/c4c5e79dd4b4c78eee7cffd9b0d7394b5bedcf12 DIFF: https://github.com/llvm/llvm-project/commit/c4c5e79dd4b4c78eee7cffd9b0d7394b5bedcf12.diff

[PATCH] D140415: [flang] stack arrays pass

jdoerfert added a comment. Quick questions, and they might not apply here since you seem to only look at explicit Flang generated values, right? Are you handling unwinding/exceptions, especially in-between the allocation and deallocation? Are you handling non-accessible stacks (e.g., on GPUs)

[clang] c68af56 - [clang][Interp][NFC] Cast in InterpFrame::localBlock

Author: Timm Bäder Date: 2023-01-25T17:09:34+01:00 New Revision: c68af565ff0c2fdc5537e9ac0c2d7c75df44b035 URL: https://github.com/llvm/llvm-project/commit/c68af565ff0c2fdc5537e9ac0c2d7c75df44b035 DIFF: https://github.com/llvm/llvm-project/commit/c68af565ff0c2fdc5537e9ac0c2d7c75df44b035.diff

[clang] eee8075 - [clang][Interp][NFCI] Remove an unnecessary DupPtr op

Author: Timm Bäder Date: 2023-01-25T17:09:33+01:00 New Revision: eee8075f57f018e047b5bc8923b0284a6f62ea3e URL: https://github.com/llvm/llvm-project/commit/eee8075f57f018e047b5bc8923b0284a6f62ea3e DIFF: https://github.com/llvm/llvm-project/commit/eee8075f57f018e047b5bc8923b0284a6f62ea3e.diff

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); erichkeane wrote: > tbaeder wrote: > > Fznamznon wrote: >

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); tbaeder wrote: > Fznamznon wrote: > > This is not four

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); This is not four bools. Repository: rG LLVM Github

[PATCH] D142550: Fix sizeof of boolean vector

tbaeder added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); Should be 4 instead of 8, shouldn't it? Repository: rG

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb added a comment. Thanks Luis for the quick review. As an important part of this is trying to align with gcc/g++ I'd really appreciate a review from @kito-cheng too if you have the time (thanks in advance!). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142327/new/

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 492115. isuckatcs added a comment. - Reverted the changes related to clang itself - Added more checks for exception handling - `isQualificationConvertiblePointer` is now iterative, not recursive - Added more test cases CHANGES SINCE LAST ACTION

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure it is at least 8 bits. Fixes #59801 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142550

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added a comment. This patch got a little bit out of control at the last revision, so I decided to remove every change from clang and add everything to the `ExceptionAnalyzer` only. The reason for that is with exceptions we have less conversions to check than we have inside the

[PATCH] D140724: [clang][Interp] Add back Run() call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb703434cbdc: [clang][Interp] Add back Run() call (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cb70343 - [clang][Interp] Add back Run() call

Author: Timm Bäder Date: 2023-01-25T17:01:55+01:00 New Revision: cb703434cbdc71beb02a7b555083f3e160a13363 URL: https://github.com/llvm/llvm-project/commit/cb703434cbdc71beb02a7b555083f3e160a13363 DIFF: https://github.com/llvm/llvm-project/commit/cb703434cbdc71beb02a7b555083f3e160a13363.diff

[clang] 8b70d97 - [clang][Interp][NFC] Use InitThisField in initializers

Author: Timm Bäder Date: 2023-01-25T16:59:19+01:00 New Revision: 8b70d97c39174e1547447e8d33b228384987a152 URL: https://github.com/llvm/llvm-project/commit/8b70d97c39174e1547447e8d33b228384987a152 DIFF: https://github.com/llvm/llvm-project/commit/8b70d97c39174e1547447e8d33b228384987a152.diff

[clang] 0a6c8c1 - [clang][Interp][NFC] Add a helper function for local variables

Author: Timm Bäder Date: 2023-01-25T16:57:59+01:00 New Revision: 0a6c8c1b2570e3fc9c652989afed5de1aee0c0be URL: https://github.com/llvm/llvm-project/commit/0a6c8c1b2570e3fc9c652989afed5de1aee0c0be DIFF: https://github.com/llvm/llvm-project/commit/0a6c8c1b2570e3fc9c652989afed5de1aee0c0be.diff

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. In D142534#4079958 , @shafik wrote: > I think having a link to the github issue in the summary allows for the issue > be closed automatically when you commit. Is this correct @aaron.ballman I > have been doing this for a

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#4078843 , @nickdesaulniers wrote: > Is https://reviews.llvm.org/D142163 a blocker for this? Yes, and this patch needs to be updated to take `VisibleToRegularObj` into account. I'll update this patch once we

[PATCH] D142534: Fix emission of consteval constructor of derived type

shafik added a comment. I think having a link to the github issue in the summary allows for the issue be closed automatically when you commit. Is this correct @aaron.ballman I have been doing this for a while and they get closed when I commit but maybe there is another mechanism involved.

[PATCH] D142534: Fix emission of consteval constructor of derived type

shafik added a comment. Makes sense to me but I am not familiar with this area so I will let someone else who has more knowledge approve. Comment at: clang/test/CodeGenCXX/cxx20-consteval-crash.cpp:95 +namespace Issue60166 { + nitpick: I have been using

[clang] 5de6b94 - [clang][Interp][NFC] Replace remaining dyn_cast_or_null uses

Author: Timm Bäder Date: 2023-01-25T16:39:26+01:00 New Revision: 5de6b94f856f696832ce7df167e1dbc096fbe598 URL: https://github.com/llvm/llvm-project/commit/5de6b94f856f696832ce7df167e1dbc096fbe598 DIFF: https://github.com/llvm/llvm-project/commit/5de6b94f856f696832ce7df167e1dbc096fbe598.diff

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske updated this revision to Diff 492106. balazske added a comment. New patch after more thorough debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

ABataev added a comment. In D129008#4079914 , @tianshilei1992 wrote: > In D129008#4079892 , @ABataev wrote: > >> In D129008#4079872 , >> @tianshilei1992 wrote: >> >>>

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. In D129008#4079892 , @ABataev wrote: > In D129008#4079872 , > @tianshilei1992 wrote: > >> In D129008#4079660 , >> @aaron.ballman wrote:

[clang] d5fe78d - [Clang] Make the linker wrapper test require Linux

Author: Joseph Huber Date: 2023-01-25T09:31:59-06:00 New Revision: d5fe78d939d25e5508ae57a2dc0c587c79ad16b1 URL: https://github.com/llvm/llvm-project/commit/d5fe78d939d25e5508ae57a2dc0c587c79ad16b1 DIFF: https://github.com/llvm/llvm-project/commit/d5fe78d939d25e5508ae57a2dc0c587c79ad16b1.diff

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 added a comment. In D142484#4079869 , @Jake-Egan wrote: > Hi, this new test fails on AIX. Could you take a look? > https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c I might just put that

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} sorry for showing up late to the party but instead of

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 added a comment. In D142484#4079869 , @Jake-Egan wrote: > Hi, this new test fails on AIX. Could you take a look? > https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c I'm actually not sure why

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

ABataev added a comment. In D129008#4079872 , @tianshilei1992 wrote: > In D129008#4079660 , @aaron.ballman > wrote: > >> In D129008#3640194 , >> @tianshilei1992 wrote:

[PATCH] D140377: [clang][Interp] Compound assign operators for FP values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf3a171dcffd: [clang][Interp] Compound assign operators for FP values (authored by tbaeder). Changed prior to commit:

[clang] af3a171 - [clang][Interp] Compound assign operators for FP values

Author: Timm Bäder Date: 2023-01-25T16:25:04+01:00 New Revision: af3a171dcffd73837d1debdd81399d51f0a0054a URL: https://github.com/llvm/llvm-project/commit/af3a171dcffd73837d1debdd81399d51f0a0054a DIFF: https://github.com/llvm/llvm-project/commit/af3a171dcffd73837d1debdd81399d51f0a0054a.diff

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. In D129008#4079660 , @aaron.ballman wrote: > In D129008#3640194 , > @tianshilei1992 wrote: > >> `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. > >

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

Jake-Egan added a comment. Hi, this new test fails on AIX. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142484/new/

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. Unit tests fail seems unrelated. I'm seeing the same test fail for a commit that is already in main https://github.com/llvm/llvm-project/commit/f1f583347d00aad378eb0128e72d3d2e8be5174b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c61fe18 - [clang][Interp][NFC] Get rid of InterpSize

Author: Timm Bäder Date: 2023-01-25T16:03:33+01:00 New Revision: c61fe188a7e8e8c4b3098998f3dfa194e4842ebc URL: https://github.com/llvm/llvm-project/commit/c61fe188a7e8e8c4b3098998f3dfa194e4842ebc DIFF: https://github.com/llvm/llvm-project/commit/c61fe188a7e8e8c4b3098998f3dfa194e4842ebc.diff

[clang] df33d17 - [clang][Interp][NFC] Remove an unused function

Author: Timm Bäder Date: 2023-01-25T16:03:33+01:00 New Revision: df33d17b38a179fb3f811d1983a48f160220d699 URL: https://github.com/llvm/llvm-project/commit/df33d17b38a179fb3f811d1983a48f160220d699 DIFF: https://github.com/llvm/llvm-project/commit/df33d17b38a179fb3f811d1983a48f160220d699.diff

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56184bb3ad3f: [AMDGCN] Fix device lib test to work with lib64 (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 56184bb - [AMDGCN] Fix device lib test to work with lib64

Author: Siu Chi Chan Date: 2023-01-25T09:55:35-05:00 New Revision: 56184bb3ad3ff4f7ca00667ec4759648ce112269 URL: https://github.com/llvm/llvm-project/commit/56184bb3ad3ff4f7ca00667ec4759648ce112269 DIFF: https://github.com/llvm/llvm-project/commit/56184bb3ad3ff4f7ca00667ec4759648ce112269.diff

[PATCH] D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This updates the AArch64's Target Parser

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This updates the parsing methods in

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

steakhal added a comment. I would be interested in some of the free-functions dealing with variants, such as `std::visit()`. https://godbolt.org/z/bbocrz4dG I hope that's also on the radar. In D142354#4079643 , @Szelethus wrote: > In D142354#4078450

<    1   2   3   >