[PATCH] D142717: [clang] Mark CWG2165 as N/A

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142717/new/ https://reviews.llvm.org/D142717

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM except the duplicated comment Comment at: clang/lib/Lex/Lexer.cpp:493-494 /// Returns the pointer that points to the beginning of line that contains /// the

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

cor3ntin added a comment. In D143109#4097850 , @ahatanak wrote: > Doesn't `Sema::FunctionScopeRAII` pop the lambda scope when it goes out of > scope? No, sadly lambdas are handled differently >

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 added a comment. In D142384#4096935 , @ilya-biryukov wrote: > @usaxena95 could you give an example of the code that fails the assertion? Is > it some of the tests? `assert(getDefinition())` fails about 3.6k tests. `assert(!isa(this) ||

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. https://llvm-compile-time-tracker.com/compare.php?from=1a17739d3aa78599c32f6106e05dcfa7f3f9e823=9c1adc5fcca177d6628bdb22c72e7546c7b691aa=instructions:u looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

nridge added a comment. Also filed https://github.com/llvm/llvm-project/issues/60469 for the seemingly missing RecursiveASTVisitor methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142871/new/ https://reviews.llvm.org/D142871

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

nridge updated this revision to Diff 494172. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142871/new/ https://reviews.llvm.org/D142871 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. All comments have been addressed, I intend to land the patch by February 9th unless more feedback is received. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a8f77c1b849: [clang-tidy] Implement CppCoreGuideline F.54 (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8a8f77c - [clang-tidy] Implement CppCoreGuideline F.54

Author: Chris Cotter Date: 2023-02-02T07:20:59Z New Revision: 8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa URL: https://github.com/llvm/llvm-project/commit/8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa DIFF: https://github.com/llvm/llvm-project/commit/8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa.diff LOG:

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

carlosgalvezp added a comment. @Sockke ping, can you land this or should we do it for you? If so, please let us know what name and email we should use for attribution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655

[clang] 0e2400a - [clang] Fix warning about unused variable [NFC]

Author: Mikael Holmen Date: 2023-02-02T08:02:11+01:00 New Revision: 0e2400ae025d33dd3dbe9f9da52ab2da776e92fd URL: https://github.com/llvm/llvm-project/commit/0e2400ae025d33dd3dbe9f9da52ab2da776e92fd DIFF: https://github.com/llvm/llvm-project/commit/0e2400ae025d33dd3dbe9f9da52ab2da776e92fd.diff

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

ChuanqiXu added a reviewer: cor3ntin. ChuanqiXu added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1415 +// +// FIXME: It looks not easy to balance PushExpressionEvaluationContext() +// and PopExpressionEvaluationContext(). cor3ntin wrote:

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added a comment. In D142862#4089860 , @serge-sans-paille wrote: > Can you take a shot against https://llvm-compile-time-tracker.com/ so that > we get an hint of the practical speedup? I ran rustc perf tests using a patched LLVM in

[PATCH] D143123: [NFC] Add split-file as runtime test dependency

yozhu updated this revision to Diff 494156. yozhu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `split-file` as compiler-rt test dependency under clang/runtime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins updated this revision to Diff 494155. erikdesjardins added a comment. rebase over landed D142861 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862 Files:

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added a comment. This revision now requires changes to proceed. Waiting on changes to fix the visitation to locate the appropriate temporaries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:894 +if (VD->getType()->isPointerType()) + return fixVariableWithSpan(VD, Tracker, Ctx, Handler); +return {}; I believe we should add another condition here:

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[*]` to `DRE.data() + *`

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: t-rasmud, NoQ, jkorous, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Work in progress. So far, there is some

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

rsmith added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4094748 , @MaskRay wrote: > The CMake part of this patch improves the matter. Manually constructed > resource dir (many duplicates) string is replace with a library function call. > > However, the introduced

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5a7439e220c: [HLSL] [Dirver] add dxv as a VerifyDebug Job (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d5a7439 - [HLSL] [Dirver] add dxv as a VerifyDebug Job

Author: Xiang Li Date: 2023-02-01T20:07:25-05:00 New Revision: d5a7439e220c79ca9aad323f38cd115a1a34a13f URL: https://github.com/llvm/llvm-project/commit/d5a7439e220c79ca9aad323f38cd115a1a34a13f DIFF: https://github.com/llvm/llvm-project/commit/d5a7439e220c79ca9aad323f38cd115a1a34a13f.diff

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143094/new/ https://reviews.llvm.org/D143094

[PATCH] D140415: [flang] stack arrays pass

kiranchandramohan added a comment. Looks OK. I have a few questions and some minor comments inline. It might be good to pull in a bit of info from the RFC into the Summary, particularly saying why a dataflow analysis is necessary, what operations are involved in the analysis etc. Could we

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta added a comment. In D142826#4098076 , @hctim wrote: > Hey, looks like this broke the x86_64-linux sanitizer buildbot: > https://lab.llvm.org/buildbot/#/builders/37/builds/19910 > > You can reproduce the bot using the instructions at >

[clang] 897e345 - Revert "[Clang] Add -Wtype-limits to -Wextra for GCC compatibility"

Author: Shivam Gupta Date: 2023-02-02T05:59:27+05:30 New Revision: 897e345042cdf2b3c1dffd234d1b593205f69a32 URL: https://github.com/llvm/llvm-project/commit/897e345042cdf2b3c1dffd234d1b593205f69a32 DIFF: https://github.com/llvm/llvm-project/commit/897e345042cdf2b3c1dffd234d1b593205f69a32.diff

[PATCH] D143050: [Driver][Fuchsia] Remove relative vtable multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bdc9c9cf70a: [Driver][Fuchsia] Remove relative vtable multilib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143050/new/

[clang] 9bdc9c9 - [Driver][Fuchsia] Remove relative vtable multilib

Author: Petr Hosek Date: 2023-02-02T00:29:00Z New Revision: 9bdc9c9cf70a054711eaaec81da833ad7936379e URL: https://github.com/llvm/llvm-project/commit/9bdc9c9cf70a054711eaaec81da833ad7936379e DIFF: https://github.com/llvm/llvm-project/commit/9bdc9c9cf70a054711eaaec81da833ad7936379e.diff LOG:

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

hctim added a comment. Hey, looks like this broke the x86_64-linux sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/19910 You can reproduce the bot using the instructions at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (substitute

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

chapuni added a comment. This discovers a warning in https://reviews.llvm.org/rGa68d4b11465f5b3326be1dd820f59fac275b7581 I think its checking is valid if size_t is uint32_t (eg. -m32) Could you guys teach me what the right fix for it? I don't know canonical fixes for it. Repository: rG

[PATCH] D143040: [Clang][DependencyScanner] Remove secondary actions from -cc1

This revision was automatically updated to reflect the committed changes. Bigcheese marked an inline comment as done. Closed by commit rGffa2a647c6a9: [Clang][DependencyScanner] Remove secondary actions from -cc1 (authored by Bigcheese). Changed prior to commit:

[clang] ffa2a64 - [Clang][DependencyScanner] Remove secondary actions from -cc1

Author: Michael Spencer Date: 2023-02-01T15:17:32-08:00 New Revision: ffa2a647c6a9dd2fab13a5e1bd4832b5b200d908 URL: https://github.com/llvm/llvm-project/commit/ffa2a647c6a9dd2fab13a5e1bd4832b5b200d908 DIFF:

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added a comment. I got a test failure in `SemaCXX/warn-unsafe-buffer-usage-fixits-local-var-span.cpp` which I believe is caused solely by the fact that we emit the diagnostics in different order. I am not sure it matters and since the Fix-Its clearly specify what source lines they

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak added a comment. Doesn't `Sema::FunctionScopeRAII` pop the lambda scope when it goes out of scope? https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Sema/Sema.h#L5042 I also tried instantiating the default arguments after the call to `BuildLambdaExpr` using `LSICopy`

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:159 + /// Parse the \p Comment, storing the result in \p Allocator + static comments::FullComment *parse(llvm::StringRef Comment, +

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders created this revision. tom-anders added a reviewer: kadircet. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This is in preparation for implementing doxygen parsing, see

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 494075. ziqingluo-90 added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1709 + +// The enclosing namespace must be first, it gets a quality boost. +if (auto Enclosing = SpecifiedScopes.EnclosingNamespace) { kadircet wrote: > i was

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders updated this revision to Diff 494074. tom-anders marked 4 inline comments as done. tom-anders added a comment. Move EnclosingNamespace logic to scopesForIndexQuery, add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140915/new/

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

cor3ntin added a comment. In D143109#4097775 , @erichkeane wrote: > @cor3ntin : Mind taking a look here? You're my lambda expert these days :) I did something similar to check the requires clause of a lambda and it does technically fix the issue, i

[PATCH] D143111: [HIP] Support ASAN with malloc/free

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added a project: All. yaxunl requested review of this revision. Device side malloc/free needs special implementation for ASAN. https://reviews.llvm.org/D143111 Files: clang/lib/Headers/__clang_hip_runtime_wrapper.h

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

rsmith added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated

[PATCH] D143040: [Clang][DependencyScanner] Remove secondary actions from -cc1

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/ClangScanDeps/strip-input-args.m:21 +// CHECK: } +// CHECK-NOT: "name" +// CHECK:"translation-units"

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

erichkeane added a subscriber: cor3ntin. erichkeane added a comment. @cor3ntin : Mind taking a look here? You're my lambda expert these days :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143109/new/ https://reviews.llvm.org/D143109

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak created this revision. ahatanak added reviewers: tahonermann, erichkeane, aaron.ballman, shafik, Bigcheese, arphaman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This is needed to fix

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06be346311b9: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer… (authored by erikdesjardins, committed by

[clang] 06be346 - [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

Author: Erik Desjardins Date: 2023-02-01T13:54:09-08:00 New Revision: 06be346311b9341d3d11120a631263de863f937c URL: https://github.com/llvm/llvm-project/commit/06be346311b9341d3d11120a631263de863f937c DIFF:

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added a comment. @rsmith Ping. This is blocking some patches I'd like to submit afterwards. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https://reviews.llvm.org/D140584 ___

[PATCH] D140177: [clang][deps] Give the fake file a unique name in by-module-name scans

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e9f62e5f833: [clang][deps] Give the fake file a unique name in by-module-name scans (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D140177?vs=483567=494063#toc

[clang] 8e9f62e - [clang][deps] Give the fake file a unique name in by-module-name scans

Author: Jan Svoboda Date: 2023-02-01T13:46:26-08:00 New Revision: 8e9f62e5f833cb89b57bf4c9e80e850bcac7e15e URL: https://github.com/llvm/llvm-project/commit/8e9f62e5f833cb89b57bf4c9e80e850bcac7e15e DIFF: https://github.com/llvm/llvm-project/commit/8e9f62e5f833cb89b57bf4c9e80e850bcac7e15e.diff

[PATCH] D140176: [clang][deps] NFC: Split out the module-based API from the TU-based API

This revision was automatically updated to reflect the committed changes. Closed by commit rGba556660fe52: [clang][deps] NFC: Split out the module-based API from the TU-based API (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D140176?vs=483383=494062#toc

[PATCH] D140175: [clang][deps] Remove support for the deprecated driver API

This revision was automatically updated to reflect the committed changes. Closed by commit rGe60fcfd6e568: [clang][deps] Remove support for the deprecated driver API (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D140175?vs=483380=494061#toc Repository: rG

[clang] ba55666 - [clang][deps] NFC: Split out the module-based API from the TU-based API

Author: Jan Svoboda Date: 2023-02-01T13:46:26-08:00 New Revision: ba556660fe52a558c34556866aba4a0bb8bbbd23 URL: https://github.com/llvm/llvm-project/commit/ba556660fe52a558c34556866aba4a0bb8bbbd23 DIFF: https://github.com/llvm/llvm-project/commit/ba556660fe52a558c34556866aba4a0bb8bbbd23.diff

[clang] e60fcfd - [clang][deps] Remove support for the deprecated driver API

Author: Jan Svoboda Date: 2023-02-01T13:46:26-08:00 New Revision: e60fcfd6e568d1471e40e6e8a14070ef126cdf4a URL: https://github.com/llvm/llvm-project/commit/e60fcfd6e568d1471e40e6e8a14070ef126cdf4a DIFF: https://github.com/llvm/llvm-project/commit/e60fcfd6e568d1471e40e6e8a14070ef126cdf4a.diff

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 updated this revision to Diff 494059. dkt01 added a comment. Updates recommended by owenpan in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/TokenAnnotator.h

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 marked 8 inline comments as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1195-1198 + // Handle unbalanced braces. + if (!Scopes.empty()) +Scopes.pop_back(); // Lines can start with '}'. owenpan

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 494053. ziqingluo-90 marked 2 inline comments as done. ziqingluo-90 added a comment. To attach fix-its to notes instead of warnings. Fix the ending '\0' issue raised by @jkorous CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 494051. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[clang] 25e2d0f - [clang-format] Support clang-format on/off line comments as prefix

Author: Owen Pan Date: 2023-02-01T13:07:09-08:00 New Revision: 25e2d0f3c803e4d71f7ef4893b5d023d252b283f URL: https://github.com/llvm/llvm-project/commit/25e2d0f3c803e4d71f7ef4893b5d023d252b283f DIFF: https://github.com/llvm/llvm-project/commit/25e2d0f3c803e4d71f7ef4893b5d023d252b283f.diff

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25e2d0f3c803: [clang-format] Support clang-format on/off line comments as prefix (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:123-125 + bool braceTokenMatchesScope(FormatToken ) { +if (!Token.is(tok::l_brace) || Scopes.empty()) + return false; Comment at:

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

HazardyKnusperkeks added a comment. An entry in the changelog would be nice. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1406-1408 + CurrentState.BreakBeforeParameter = !( + Style.PackConstructorInitializers == FormatStyle::PCIS_NextLine || +

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware updated this revision to Diff 494036. KyleFromKitware added a comment. Fixed formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143099/new/ https://reviews.llvm.org/D143099 Files: clang/include/clang/Lex/Lexer.h clang/lib/Lex/Lexer.cpp

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added a comment. > The main trouble I had was at that point we don't have a reference to the > ToolChain, so calling `getMultiSelectionFlags` was not possible. [...] I'm > not sure what the solution here is. I see two options: 1. Split getMultiSelectionFlags into

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware updated this revision to Diff 494031. KyleFromKitware added a comment. Rebased onto D143099 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/ https://reviews.llvm.org/D142991 Files:

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang. KyleFromKitware added a project: clang. Herald added a project: All. KyleFromKitware requested review of this revision. Herald added a subscriber: cfe-commits. And fix a few corner cases in which it returns the wrong

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. Wow, this fixed a lot of tests, down to only 17 lsan standalone tests failing :) (26 already passing) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 ___ cfe-commits

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @aganea Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115103: Leak Sanitizer port to Windows

aganea added a comment. In D115103#4097460 , @clemenswasser wrote: > Do you have a suggestion how I could fix this on MSVC @clemenswasser The bug is there for years, I'm surprised it hasn't been fixed yet. MSVC doesn't support different types with

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @vitalybuka There seems to be a bug in MSVCs bit-field implementation, which causes the `disable.c` test to fail. This reproducer (assert) passes with gcc and fails with MSVC (`m.tag` is `0x`): cpp #include #include enum ChunkTag {

[clang] 3c1d025 - [Clang] Fix test after changing the order of input files

Author: Joseph Huber Date: 2023-02-01T13:52:22-06:00 New Revision: 3c1d0255d1788c607abb74ea0e775f1f753a9b94 URL: https://github.com/llvm/llvm-project/commit/3c1d0255d1788c607abb74ea0e775f1f753a9b94 DIFF: https://github.com/llvm/llvm-project/commit/3c1d0255d1788c607abb74ea0e775f1f753a9b94.diff

[clang] fa5209c - [LinkerWrapper] Adjust placement of input files for the linker

Author: Joseph Huber Date: 2023-02-01T13:49:17-06:00 New Revision: fa5209ce4060f659aeb9c0e70ca4cf908c788fff URL: https://github.com/llvm/llvm-project/commit/fa5209ce4060f659aeb9c0e70ca4cf908c788fff DIFF: https://github.com/llvm/llvm-project/commit/fa5209ce4060f659aeb9c0e70ca4cf908c788fff.diff

[PATCH] D143092: [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5be69cd6af5: [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[clang] b5be69c - [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver

Author: Petr Hosek Date: 2023-02-01T19:42:31Z New Revision: b5be69cd6af5acacb3ddea4011c05e8e25334067 URL: https://github.com/llvm/llvm-project/commit/b5be69cd6af5acacb3ddea4011c05e8e25334067 DIFF: https://github.com/llvm/llvm-project/commit/b5be69cd6af5acacb3ddea4011c05e8e25334067.diff LOG:

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

kpn added inline comments. Comment at: llvm/test/Transforms/Inline/AMDGPU/inline-denormal-fp-math.ll:78 +; CHECK-NEXT:[[CALL:%.*]] = call i32 @func_default() +; CHECK-NEXT:ret i32 [[CALL]] ; arsenm wrote: > kpn wrote: > > Are we changing the behavior in

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Last set of comments, docs and release notes look fine to me. feel free to fix the last comments while committing. Comment at: clang/lib/Sema/SemaChecking.cpp:17816

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 494024. ManuelJBrito added a comment. - set Invalid in type checking - add builtin documentation - add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/test/Transforms/Inline/AMDGPU/inline-denormal-fp-math.ll:78 +; CHECK-NEXT:[[CALL:%.*]] = call i32 @func_default() +; CHECK-NEXT:ret i32 [[CALL]] ; kpn wrote: > Are

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

kpn added a comment. We use "dynamic" for the constrained intrinsics. I'd stay consistent with our terminology and stick with "dynamic" here. I like the amount of testing. You may have gotten every single combination of cases, but I didn't go far enough to check. Comment

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. > Generally we use prefer `llvm::ArrayRef` over `const std::vector &` I will keep this in mind. Or should this be fixed in this revision? Anyway, if this gets merged, my username/mail are GitHub username: BigPeet GitHub email: pwolf2...@gmail.com Thanks for the fast

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57690a8ece9e: [Sanitizers] fix -fno-sanitize-link-runtime for darwin (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 57690a8 - [Sanitizers] fix -fno-sanitize-link-runtime for darwin

Author: usama hameed Date: 2023-02-01T11:06:19-08:00 New Revision: 57690a8ece9e5d3b749c66a226a4c79f3d7588aa URL: https://github.com/llvm/llvm-project/commit/57690a8ece9e5d3b749c66a226a4c79f3d7588aa DIFF: https://github.com/llvm/llvm-project/commit/57690a8ece9e5d3b749c66a226a4c79f3d7588aa.diff

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:243 +/// - Strict +std::optional> Mode; + sammccall wrote: > I think "Diagnostics.Mode" is too vague a name. > > I expect this to be a rollout flag that we remove in

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel added a comment. In D142710#4097032 , @xazax.hun wrote: > In D142710#4096325 , @ymandel wrote: > >> In D142710#4094934 , @xazax.hun >> wrote: >> >>> This change

[PATCH] D142892: [clangd] Publish diagnostics from stale preambles

kadircet abandoned this revision. kadircet added a comment. split into D143093 , D143095 and D143096 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

jloser updated this revision to Diff 494008. jloser added a comment. Update commit message to properly display the #define Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143094/new/ https://reviews.llvm.org/D143094 Files:

[PATCH] D143095: [clangd] Respect preamble-patch when handling diags

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Depends on

[clang] 5cff68f - [Module] Respect `-fno-pch-timestamps` when building modules

Author: Steven Wu Date: 2023-02-01T10:34:35-08:00 New Revision: 5cff68fca0bc21ccad20cc7c8fb9845e32b4c925 URL: https://github.com/llvm/llvm-project/commit/5cff68fca0bc21ccad20cc7c8fb9845e32b4c925 DIFF: https://github.com/llvm/llvm-project/commit/5cff68fca0bc21ccad20cc7c8fb9845e32b4c925.diff

[PATCH] D141632: [Module] Respect `-fno-pch-timestamps` when building modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cff68fca0bc: [Module] Respect `-fno-pch-timestamps` when building modules (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

jloser created this revision. jloser added reviewers: yubing, LuoYuanke, pengfei, craig.topper. Herald added a project: All. jloser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current behavior for AMX macros is: gcc

[PATCH] D143093: [clangd] #undef macros inside preamble patch

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. That way we

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 494003. kadircet added a comment. Wire up the feature and add some test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142890/new/ https://reviews.llvm.org/D142890 Files:

[PATCH] D143092: [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver

phosek created this revision. phosek added a reviewer: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This allows building static libraries with Clang driver. Repository: rG LLVM

[clang] f84d30e - Reland "[codegen] Store address of indirect arguments on the stack"

Author: Felipe de Azevedo Piovezan Date: 2023-02-01T13:07:47-05:00 New Revision: f84d30e172b1f2365b1437b931d99156a76ed8f2 URL: https://github.com/llvm/llvm-project/commit/f84d30e172b1f2365b1437b931d99156a76ed8f2 DIFF:

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D124351#4097224 , @aaron.ballman wrote: > In D124351#4097192 , @dblaikie > wrote: > >> In D124351#4097110 , @cor3ntin >> wrote: >> >>> In

[clang] 51ff548 - [LinkerWrapper] Fix passing `-rpath` directly to clang

Author: Joseph Huber Date: 2023-02-01T12:03:03-06:00 New Revision: 51ff5481146475afc869cf54ebc0b46d9da15a14 URL: https://github.com/llvm/llvm-project/commit/51ff5481146475afc869cf54ebc0b46d9da15a14 DIFF: https://github.com/llvm/llvm-project/commit/51ff5481146475afc869cf54ebc0b46d9da15a14.diff

  1   2   3   >