[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D124351#4101611 , @rupprecht wrote: > Hi, me again :) > > I ran into an interesting build breakage from this, I can't tell if it's a > legitimate breakage based on reading P2036R3 and P2579R0 (mostly I'm not a > language

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder updated this revision to Diff 494517. tbaeder marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138802/new/ https://reviews.llvm.org/D138802 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[clang] 9b7e574 - [NFC] [Serialization] Add static assert for Num*Declbits

Author: Chuanqi Xu Date: 2023-02-03T14:35:44+08:00 New Revision: 9b7e574701554fd496dc0fafe567b60767783b4b URL: https://github.com/llvm/llvm-project/commit/9b7e574701554fd496dc0fafe567b60767783b4b DIFF: https://github.com/llvm/llvm-project/commit/9b7e574701554fd496dc0fafe567b60767783b4b.diff

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu updated this revision to Diff 494511. ChuanqiXu added a comment. This is only part of the original revision, which contains platform independent assertion only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 Files:

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Previously function template instantiations occurred with FP options that were in effect

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff abandoned this revision. sepavloff added a comment. The alternative solution in D136354 was implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133325/new/ https://reviews.llvm.org/D133325

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. In D127082#4101322 , @daiyousei-qz wrote: > In D127082#4089377 , @nridge wrote: > >> @daiyousei-qz what is the current status of this patch? Is it ready to be >> merged again? (If so, I

[PATCH] D142448: [clang][Interp] Handle TypeTraitExprs

tbaeder updated this revision to Diff 494504. tbaeder marked an inline comment as done. tbaeder added a comment. Nope, no surprises. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142448/new/ https://reviews.llvm.org/D142448 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

pengfei accepted this revision. pengfei added a comment. The change makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143094/new/ https://reviews.llvm.org/D143094 ___ cfe-commits mailing

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

shiva0217 added a comment. Herald added a project: All. Hi, I have a question for the delete function call sinking in -Oz. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3690.pdf. According to 3.7.4.2/3 ` The value of the first argument supplied to a deallocation function may be a

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

rupprecht added a comment. Hi, me again :) I ran into an interesting build breakage from this, I can't tell if it's a legitimate breakage based on reading P2036R3 and P2579R0 (mostly I'm not a language lawyer). struct StringLiteral { template StringLiteral(const char ()[N])

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. This is more or less ready for review (not planning on making any further changes; there are more features to be added, but I was thinking of handling those in follow up changesets). I know it's a relatively large review, but let me know if anyone can take a first

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay added a comment. > `For posterity, the tests that fail on main are:` > > `Skipped : 43` > [...] You can remove these from the description. They are flaky tests unrelated to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: mlir/test/Transforms/print-op-graph.mlir:1 // RUN: mlir-opt -allow-unregistered-dialect -mlir-elide-elementsattrs-if-larger=2 -view-op-graph %s -o %t

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added inline comments. Comment at: mlir/test/Transforms/print-op-graph.mlir:9 // DFG: subgraph {{.*}} { -// DFG: v[[ARG0:.*]] [label = "arg0" -// DFG: v[[CONST10:.*]] [label ={{.*}}10 : i32 +// DFG:

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:703 + case Strategy::Kind::Span: +return FixItList{}; + case Strategy::Kind::Wontfix: I am afraid I might have found one more problem :( I believe that for

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

arsenm added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:271 LANGOPT(GPUAllowDeviceInit, 1, 0, "allowing device side global init functions for HIP") -LANGOPT(GPUMaxThreadsPerBlock, 32, 1024, "default max threads per block for kernel launch bounds

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10d85dc75468: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body… (authored by ChuanqiXu). Repository: rG LLVM Github

[clang] 10d85dc - [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

Author: Chuanqi Xu Date: 2023-02-03T10:27:02+08:00 New Revision: 10d85dc75468074d2aceb1a648125167128d6f25 URL: https://github.com/llvm/llvm-project/commit/10d85dc75468074d2aceb1a648125167128d6f25 DIFF: https://github.com/llvm/llvm-project/commit/10d85dc75468074d2aceb1a648125167128d6f25.diff

[PATCH] D142384: [C++20] Fix a crash with modules.

ChuanqiXu added a comment. It should be good to prevent crashes. But it looks not good that it doesn't have a test. Do you have plans to add a test case for this soon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:638 - EXPECT_THAT(Storage.keys(), ElementsAre(testPath("A.cc"), testPath("A.h"))); + EXPECT_THAT(Storage.keys(), ElementsAre(testPath("A.h"), testPath("A.cc"))); // Make

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 updated this revision to Diff 494477. bob80905 added a comment. - add log2 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143207/new/ https://reviews.llvm.org/D143207 Files: clang/docs/LanguageExtensions.rst

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly created this revision. Herald added a project: All. jacobly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the Microsoft ABI, some destructors need to offset a parameter to get the derived this pointer, in which case the type

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. In D127082#4089377 , @nridge wrote: > @daiyousei-qz what is the current status of this patch? Is it ready to be > merged again? (If so, I can do that for you.) Honestly, I don't know. I looked at TOT llvm repo in github

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

python3kgae added a comment. Add log2 together? They're in same category. Comment at: clang/test/Sema/aarch64-sve-vector-log-ops.c:19 +} \ No newline at end of file newline. Comment at: clang/test/SemaCXX/builtins-elementwise-math.cpp:90 +}

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 updated this revision to Diff 494471. bob80905 added a comment. include first commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143207/new/ https://reviews.llvm.org/D143207 Files: clang/docs/LanguageExtensions.rst

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 updated this revision to Diff 494470. bob80905 added a comment. add release note line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143207/new/ https://reviews.llvm.org/D143207 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D143231: add release note line

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143231 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm updated this revision to Diff 494465. arsenm marked 2 inline comments as done. arsenm added a comment. Documentation fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

LuoYuanke added a comment. @pengfei, would you take a look to double confirm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143094/new/ https://reviews.llvm.org/D143094 ___ cfe-commits mailing list

[clang] b88ebb3 - Revert "Add CFI integer types normalization"

Author: Mitch Phillips Date: 2023-02-02T15:48:50-08:00 New Revision: b88ebb3d94cbd2bdf6ffd17fa7c5559579a249a2 URL: https://github.com/llvm/llvm-project/commit/b88ebb3d94cbd2bdf6ffd17fa7c5559579a249a2 DIFF:

[PATCH] D139395: Add CFI integer types normalization

hctim added a comment. Hey folks, looks like this caused a failure on the msan buildbot: https://lab.llvm.org/buildbot/#/builders/237/builds/785 It's been had a long-running bug that I'm still tracking down but seems like this is a new failure caused by this patch. The track-origins log is

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

jcranmer-intel added a comment. Looking at the attribute logic here, there is conceptual room for both a `dynamic` and an `unknown` mode (i.e., you get a top and a bottom value), but I don't think there is value in distinguishing between them, so I'm fine with keeping just a `dynamic`. I

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

This revision was automatically updated to reflect the committed changes. Closed by commit rG0480748ea672: [DeclContext] Sort the Decls before adding into DeclContext (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/

[clang] 0480748 - [DeclContext] Sort the Decls before adding into DeclContext

Author: Steven Wu Date: 2023-02-02T15:16:20-08:00 New Revision: 0480748ea6728392886931b8470969ae17aaa91f URL: https://github.com/llvm/llvm-project/commit/0480748ea6728392886931b8470969ae17aaa91f DIFF: https://github.com/llvm/llvm-project/commit/0480748ea6728392886931b8470969ae17aaa91f.diff

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4100790 , @dblaikie wrote: > In D141625#4100762 , @steven_wu > wrote: > >> I don't think it is feasible with current tool to write a test that check >> semantically the

[PATCH] D143111: [HIP] Support ASAN with malloc/free

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Headers/hip-header.hip:142 +// MALLOC-ASAN-LABEL: define weak {{.*}}i8* @malloc(i64 +// MALLOC-ASAN: call i8* @llvm.returnaddress(i32 0) +// MALLOC-ASAN: call i64

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

tahonermann added a comment. > I'm still don't understand what the problem is about cleaning up the lambda > scope. Me either. It looks to me like the pushed lambda scope will get properly cleaned up. Incidentally, it looks like that LSI copy

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aemerson added a comment. Gentle ping on this discussion. @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.llvm.org/D127762 ___ cfe-commits mailing list

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder added a comment. Are there any thoughts on whether this is too ugly to live? It will be awkward to teach users the current default behavior without this change, but if we can accept it as a historical quirk that may be OK. The primary driver for wanting the 1:1 mapping is an odd

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder updated this revision to Diff 494435. scott.linder added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added a comment. In D141672#4100940 , @reames wrote: > This was brought up in today's RISCV sync call; I want to summarize the major > points of discussion. > > This patch is now behind the current most recent revision on the >

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

reames added a comment. This was brought up in today's RISCV sync call; I want to summarize the major points of discussion. This patch is now behind the current most recent revision on the vector-crypto spec.

[PATCH] D143111: [HIP] Support ASAN with malloc/free

arsenm added inline comments. Comment at: clang/test/Headers/hip-header.hip:142 +// MALLOC-ASAN-LABEL: define weak {{.*}}i8* @malloc(i64 +// MALLOC-ASAN: call i8* @llvm.returnaddress(i32 0) +// MALLOC-ASAN: call i64 @__asan_malloc_impl(i64 {{.*}}, i64 {{.*}})

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1374 +: Error<"expected '%0' clause with an argument on '#pragma omp %1' " +"construct since OpenMP %2">; def err_expected_end_declare_target_or_variant : Error<

[clang-tools-extra] 506621f - [modularize] StringMap=>map to make iteration order deterministic

Author: Fangrui Song Date: 2023-02-02T13:46:52-08:00 New Revision: 506621fac467496202f2aff5ce9425994560d9eb URL: https://github.com/llvm/llvm-project/commit/506621fac467496202f2aff5ce9425994560d9eb DIFF: https://github.com/llvm/llvm-project/commit/506621fac467496202f2aff5ce9425994560d9eb.diff

[clang-tools-extra] 16c8709 - [unittest] Use UnorderedElementsAre for StringMap keys

Author: Fangrui Song Date: 2023-02-02T13:39:47-08:00 New Revision: 16c8709cf61b0787cb3e4e283e158d9f86d8d6d5 URL: https://github.com/llvm/llvm-project/commit/16c8709cf61b0787cb3e4e283e158d9f86d8d6d5 DIFF: https://github.com/llvm/llvm-project/commit/16c8709cf61b0787cb3e4e283e158d9f86d8d6d5.diff

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. Extending the python generator: - to generate

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2213 + if (C.getArgs().hasArg(options::OPT_print_multi_selection_flags)) { +for (StringRef Attr : TC.getMultiSelectionFlags(C.getArgs())) +

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 494420. michaelplatings added a comment. Print flags expanded by any regular expression matchers in multilib.yaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a comment. In D141625#4100762 , @steven_wu wrote: > I don't think it is feasible with current tool to write a test that check > semantically the order of decls in clang module. (Let me know if that was > wrong). The current test already

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm updated this revision to Diff 494417. arsenm edited the summary of this revision. arsenm added a comment. Herald added a subscriber: tpr. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 Files:

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 494416. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a comment. In D141625#4100660 , @akyrtzi wrote: >> would be great to test it more in a semantic way if possible > > Keep in mind that the specific order of the decls doesn't matter for the > purposes of this test, what matters is that the

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay added a comment. Updated the diff. Please take a look. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:496 +def err_destroy_clause_without_argument +: Error<"'destroy' clause without argument on '#pragma omp depobj' " ABataev

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay updated this revision to Diff 494415. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143021/new/ https://reviews.llvm.org/D143021 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/depobj_messages.cpp Index:

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. I don't think it is feasible with current tool to write a test that check semantically the order of decls in clang module. (Let me know if that was wrong). The current test already unfortunately relies on the module layout assuming `op13` is the field for anonymous

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 494414. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D143210: PowerPC] Include vector bool and pixel when emitting lax warning

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to fix some missing lax-vector-conversion warnings including

[PATCH] D143208: Repair sphinx doc generation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa11a6752c15b: Repair sphinx doc generation (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a11a675 - Repair sphinx doc generation

Author: Joshua Batista Date: 2023-02-02T12:33:53-08:00 New Revision: a11a6752c15b76f165bcb9c733c6c7dce9bcec6b URL: https://github.com/llvm/llvm-project/commit/a11a6752c15b76f165bcb9c733c6c7dce9bcec6b DIFF:

[PATCH] D143208: Repair sphinx doc generation

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143208/new/ https://reviews.llvm.org/D143208 ___

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 494406. michaelplatings added a comment. Move the regular expression flag matching functionality into MutlilibSet. This (a) simplifies the code for loading from multilib.yaml; and (b) makes the flag matching functionality easier to access.

[PATCH] D143208: Repair sphinx doc generation

bob80905 created this revision. bob80905 added reviewers: beanz, python3kgae. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. mistake in the log commit neglected to place a space after the `` literal,

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

akyrtzi added a comment. > would be great to test it more in a semantic way if possible Keep in mind that the specific order of the decls doesn't matter for the purposes of this test, what matters is that the order is the same every time for the same input. I personally think that the

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz, craig.topper, fhahn. Herald added subscribers: luke, Anastasia, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

This revision was automatically updated to reflect the committed changes. Closed by commit rGecd0be100bed: [clang] Warn by default that implicit capture of this is deprecated in C++20… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ecd0be1 - [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

Author: Tom Honermann Date: 2023-02-02T15:10:47-05:00 New Revision: ecd0be100bed5bae1f22d3da28bfcca89934af8c URL: https://github.com/llvm/llvm-project/commit/ecd0be100bed5bae1f22d3da28bfcca89934af8c DIFF: https://github.com/llvm/llvm-project/commit/ecd0be100bed5bae1f22d3da28bfcca89934af8c.diff

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated

[PATCH] D142534: Fix emission of consteval constructor of derived type

aaron.ballman added reviewers: efriedma, rjmccall, erichkeane. aaron.ballman added a comment. In D142534#4080007 , @Fznamznon wrote: > In D142534#4079958 , @shafik wrote: > >> I think having a link to the github

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4098695 , @vedgy wrote: > Another disadvantage of using `CINDEX_VERSION_MINOR` instead of the `sizeof` > is that an older libclang version won't know about compatibility of newer > versions with itself. But

[PATCH] D140489: Add builtin_elementwise_log

This revision was automatically updated to reflect the committed changes. Closed by commit rG26eb70820fb8: Add builtin_elementwise_log (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D140489?vs=492581=494389#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 26eb708 - Add builtin_elementwise_log

Author: Joshua Batista Date: 2023-02-02T11:36:22-08:00 New Revision: 26eb70820fb860ccf97c57ee26502ff621cf4ed2 URL: https://github.com/llvm/llvm-project/commit/26eb70820fb860ccf97c57ee26502ff621cf4ed2 DIFF:

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

nickdesaulniers added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1588 + +Prior to clang-16, the output may only be used safely when the indirect +branches are not taken. Query for this difference with err...clang-17 Repository: rG LLVM

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the +branches are taken or not. void wrote: >

[PATCH] D143123: [NFC] Add split-file as runtime test dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d757177df47: [NFC] Add split-file as runtime test dependency (authored by yozhu, committed by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4d75717 - [NFC] Add split-file as runtime test dependency

Author: YongKang Zhu Date: 2023-02-02T11:22:26-08:00 New Revision: 4d757177df473691640095ea8b0e2104a97af83f URL: https://github.com/llvm/llvm-project/commit/4d757177df473691640095ea8b0e2104a97af83f DIFF: https://github.com/llvm/llvm-project/commit/4d757177df473691640095ea8b0e2104a97af83f.diff

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also move the line about __has_extension(gnu_asm_goto_with_outputs) so that it is more generally about asm

[PATCH] D142448: [clang][Interp] Handle TypeTraitExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming there are no surprises from the additional test request. Comment at: clang/test/AST/Interp/literals.cpp:762 + }; +

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 494371. michaelplatings added a comment. Put "experimental" in the argument name. The intention is to include the new multilib as an experimental feature in LLVM 17 and stabilise it in LLVM 18. Also remove support for

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added a comment. In D142933#4099043 , @Joe wrote: > I did briefly try to pass a ToolChain to Gnu.cpp functions, but it became > intrusive and had to add it in 5+ places, so unless I'm missing a trick to > get the ToolChain from the

[PATCH] D137070: [clang][Interp] Support destructors

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1915-1916 + +if (const CXXDestructorDecl *Dtor = ElemRecord->getDestructor(); +Dtor && !Dtor->isTrivial()) { + for (size_t I = 0, E = Desc->getNumElems(); I != E; ++I) {

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. Should be fixed by https://github.com/llvm/llvm-project/commit/108fa70cd213e63a591adb87ce444fb74afc6786 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757

[clang] 108fa70 - [clang][driver] Fix test fail on Mac after fe082124

Author: Mariya Podchishchaeva Date: 2023-02-02T13:44:53-05:00 New Revision: 108fa70cd213e63a591adb87ce444fb74afc6786 URL: https://github.com/llvm/llvm-project/commit/108fa70cd213e63a591adb87ce444fb74afc6786 DIFF:

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei updated this revision to Diff 494364. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143025/new/ https://reviews.llvm.org/D143025 Files: clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake ===

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG089bfedfb828: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits= (authored by craig.topper). Changed prior to commit:

[clang] 089bfed - [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

Author: Craig Topper Date: 2023-02-02T10:32:14-08:00 New Revision: 089bfedfb828c2675f3cc57d6ecac1a87ca243a1 URL: https://github.com/llvm/llvm-project/commit/089bfedfb828c2675f3cc57d6ecac1a87ca243a1 DIFF: https://github.com/llvm/llvm-project/commit/089bfedfb828c2675f3cc57d6ecac1a87ca243a1.diff

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. In D141451#4095303 , @nickdesaulniers wrote: > In D141451#4064298 , @dblaikie > wrote: > >> Right - I was thinking more, as above, about directly using the existing >> metadata

[PATCH] D142277: [clang][Interp] Clear metadata when destroying locals

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:260-261 +// local variable is used after being destroyed. +InlineDescriptor = *reinterpret_cast(B->rawData()); +std::memset(, 0, sizeof(InlineDescriptor)); }

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. In D142757#4100167 , @thakis wrote: > This breaks tests on Mac: http://45.33.8.238/macm1/54097/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for reporting. It seems I should have added

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a comment. In D141625#4095197 , @steven_wu wrote: >> Sorry, I'm still not really following - OK, sounds like you're saying this >> test does fail at HEAD/without this patch in reverse iteration mode, and is >> a bit larger than would be

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. @diseraluca -- do you need this cherry picked into Clang 16 or are you fine if this goes into Clang 17 instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756

[PATCH] D143123: [NFC] Add split-file as runtime test dependency

yozhu updated this revision to Diff 494354. yozhu added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143123/new/ https://reviews.llvm.org/D143123 Files: clang/runtime/CMakeLists.txt llvm/runtimes/CMakeLists.txt Index:

[PATCH] D143197: [clangd] Patch includes even without any changes

kadircet updated this revision to Diff 494347. kadircet added a comment. - Also populate additional fields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143197/new/ https://reviews.llvm.org/D143197 Files: clang-tools-extra/clangd/Preamble.cpp

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak added a comment. I'm still don't understand what the problem is about cleaning up the lambda scope. `PushLambdaScope` creates a new `LambdaScopeInfo` and pushes onto `FunctionScopes`. https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/Sema.cpp#L2137 When

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

erichkeane added a comment. Other than the newline, the test change is acceptable to me. Commit when ready :) Comment at: clang/test/CodeGen/builtins-nondeterministic-value.c:61 +} \ No newline at end of file We do need a newline here. Repository: rG

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 494338. ManuelJBrito added a comment. Fix vector tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/docs/LanguageExtensions.rst

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

thakis added a comment. This breaks tests on Mac: http://45.33.8.238/macm1/54097/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/

  1   2   3   >