[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka updated this revision to Diff 494999. vitalybuka added a comment. as reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h

[clang] bccf599 - Revert "[clang][WebAssembly] Initial support for reference type externref in clang"

Author: Vitaly Buka Date: 2023-02-05T21:41:48-08:00 New Revision: bccf5999d38f14552f449618c1d72d18613f4285 URL: https://github.com/llvm/llvm-project/commit/bccf5999d38f14552f449618c1d72d18613f4285 DIFF: https://github.com/llvm/llvm-project/commit/bccf5999d38f14552f449618c1d72d18613f4285.diff

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

ccotter added inline comments. Herald added a subscriber: ChuanqiXu. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/unnecessary-copy-on-last-use.cpp:77 + +Movable testReturn2(Movable && Mov, bool F) { + return F? Mov: Movable{}; Could you

[PATCH] D139122: Generalize clang-tidy modernize-pass-by-value

ccotter added a comment. https://reviews.llvm.org/D137205 looks to be similar in part, as it applies a FixIt to a any last use of an object if the use a copy, including parameters and local objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

sameerds added a comment. LGTM, to the extent that I can see that the change does what is advertised, and the ultimately emitted HSA metadata preserves the current contract with the runtime. A couple of tests can use a little more explanatory comments as noted. Comment at:

[PATCH] D139122: Generalize clang-tidy modernize-pass-by-value

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:11 +#include "../utils/Aliasing.h" +#include "../utils/ExprSequence.h" #include "clang/AST/ASTContext.h" I think you need to add `clangAnalysis` (for

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

shiva0217 added a comment. In D79378#4103366 , @rjmccall wrote: > In D79378#4101935 , @shiva0217 wrote: > >> In D79378#4101829 , @rjmccall wrote: >> >>> In D79378#4101613

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

toddcarmay added a comment. Herald added a project: All. I've been trying to find anything like this for a while now. Thanks for posting this, I've been hunting for it for a while. https://drift-boss.co/ drift boss Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf08d86fc7f44: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES

[clang] f08d86f - [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia

Author: Roland McGrath Date: 2023-02-05T18:58:59-08:00 New Revision: f08d86fc7f4479d5f44d75c720201334682075b8 URL: https://github.com/llvm/llvm-project/commit/f08d86fc7f4479d5f44d75c720201334682075b8 DIFF:

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03ff435da540: [RISCV] Default to -ffixed-x18 for Fuchsia (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 03ff435 - [RISCV] Default to -ffixed-x18 for Fuchsia

Author: Roland McGrath Date: 2023-02-05T18:51:18-08:00 New Revision: 03ff435da540b0feb8272784e05ce742831d5bc2 URL: https://github.com/llvm/llvm-project/commit/03ff435da540b0feb8272784e05ce742831d5bc2 DIFF:

[PATCH] D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia

mcgrathr updated this revision to Diff 494973. mcgrathr marked an inline comment as done. mcgrathr added a comment. remove TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143357/new/ https://reviews.llvm.org/D143357 Files:

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

mcgrathr updated this revision to Diff 494972. mcgrathr added a comment. rebased, added clang driver test vs -fsanitize=shadow-call-stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143355/new/ https://reviews.llvm.org/D143355 Files:

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:16 +#include "GISel/RISCVLegalizerInfo.h" +#include "GISel/RISCVRegisterBankInfo.h" #include "RISCV.h" mcgrathr wrote: > jrtc27 wrote: > > Unrelated change > arcanist requested

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

mcgrathr updated this revision to Diff 494970. mcgrathr added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143355/new/ https://reviews.llvm.org/D143355 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

mcgrathr added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:16 +#include "GISel/RISCVLegalizerInfo.h" +#include "GISel/RISCVRegisterBankInfo.h" #include "RISCV.h" jrtc27 wrote: > Unrelated change arcanist requested it via clang-format

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. From a first glance looks ok but ideally the clang changes would be a separate review. Particularly the ASTImporter change could use a unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

MaskRay added a comment. LGTM Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:36 +} +return (); + } tbaeder wrote: > Is the `.value()` here permitted? AFAIK the convention is to always use > `operator*`. > > And I think @aaron.ballman would

[PATCH] D143325: [Driver] Add -mllvm= as an alias for -mllvm

MaskRay added a comment. In D143325#4105356 , @Meinersbur wrote: > This patch broke the Flang buildbot, e.g. > https://lab.llvm.org/buildbot/#/builders/172/builds/23305 > > The tests >

[PATCH] D143325: [Driver] Add -mllvm= as an alias for -mllvm

Meinersbur added a comment. This patch broke the Flang buildbot, e.g. https://lab.llvm.org/buildbot/#/builders/172/builds/23305 The tests https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/driver-help.f90

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcad708b9a1ec: [clang-format] Recognize Verilog non-blocking assignment (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] cad708b - [clang-format] Recognize Verilog non-blocking assignment

Author: sstwcw Date: 2023-02-06T00:58:11Z New Revision: cad708b9a1ecbf5645706056bb7c4fc0ea4721b6 URL: https://github.com/llvm/llvm-project/commit/cad708b9a1ecbf5645706056bb7c4fc0ea4721b6 DIFF: https://github.com/llvm/llvm-project/commit/cad708b9a1ecbf5645706056bb7c4fc0ea4721b6.diff LOG:

[clang] 26182df - [docs] Replace deprecated -target with --target=

Author: Fangrui Song Date: 2023-02-05T16:34:22-08:00 New Revision: 26182dfa3600f33995c20214a226eb482331fb01 URL: https://github.com/llvm/llvm-project/commit/26182dfa3600f33995c20214a226eb482331fb01 DIFF: https://github.com/llvm/llvm-project/commit/26182dfa3600f33995c20214a226eb482331fb01.diff

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:16 +#include "GISel/RISCVLegalizerInfo.h" +#include "GISel/RISCVRegisterBankInfo.h" #include "RISCV.h" Unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143355/new/ https://reviews.llvm.org/D143355

[PATCH] D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:476 default: // TODO: Enable SafeStack on RISC-V once tested. break; Can you remove

[PATCH] D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia

mcgrathr created this revision. mcgrathr added reviewers: phosek, paulkirth, leonardchan. Herald added subscribers: VincentWu, abrachet, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project:

[PATCH] D143355: [RISCV] Default to -ffixed-x18 for Fuchsia

mcgrathr created this revision. mcgrathr added reviewers: phosek, paulkirth, leonardchan. Herald added subscribers: luke, VincentWu, abrachet, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

DHowett-MSFT added a comment. In D138453#4105209 , @shafik wrote: > It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting > your added `llvm_unreachable("missing serialization code for annotation > token");` is this expected. I

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

shafik added a comment. It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting your added `llvm_unreachable("missing serialization code for annotation token");` is this expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35f2ac1763ad: [clang-format] Fix inconsistent annotation of operator (authored by dkt01, committed by owenpan). Repository: rG LLVM Github

[clang] 35f2ac1 - [clang-format] Fix inconsistent annotation of operator

Author: David Turner Date: 2023-02-05T13:33:33-08:00 New Revision: 35f2ac1763adcbd5ee9b49a98de24c0c420c323e URL: https://github.com/llvm/llvm-project/commit/35f2ac1763adcbd5ee9b49a98de24c0c420c323e DIFF: https://github.com/llvm/llvm-project/commit/35f2ac1763adcbd5ee9b49a98de24c0c420c323e.diff

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: Naghasan, ebevhan, yaxunl. Herald added a project: All. Anastasia requested review of this revision. Documented major OpenCL features in release 16. https://reviews.llvm.org/D143348 Files:

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe updated this revision to Diff 494937. mikecrowe added a comment. carlosgalvezp wrote: > Please document change in Release Notes, as well as in the check > documentation, together with its limitations (can only handle 1 argument at a > time). Hopefully I've done those things.

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, davide, clayborg, k8stone. kpdev42 added projects: LLVM, LLDB. Herald added subscribers: Michael137, JDevlieghere, martong. Herald added a reviewer: shafik. Herald added a reviewer: shafik. Herald added a project: All. kpdev42

[clang] 90094ab - [Driver] Add -mllvm= as an alias for -mllvm

Author: Fangrui Song Date: 2023-02-05T10:29:58-08:00 New Revision: 90094ab8850ec435574fbd393d886a54a6dd2531 URL: https://github.com/llvm/llvm-project/commit/90094ab8850ec435574fbd393d886a54a6dd2531 DIFF: https://github.com/llvm/llvm-project/commit/90094ab8850ec435574fbd393d886a54a6dd2531.diff

[PATCH] D143325: [Driver] Add -mllvm= as an alias for -mllvm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90094ab8850e: [Driver] Add -mllvm= as an alias for -mllvm (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

carlosgalvezp added a comment. Please document change in Release Notes, as well as in the check documentation, together with its limitations (can only handle 1 argument at a time). Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:182 + +

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp updated this revision to Diff 494929. carlosgalvezp added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/ https://reviews.llvm.org/D140290 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me, but please wait for other opinion(s). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:31 +: ClangTidyCheck(Name, Context) { + std::optional HeaderFileExtensionsOption = + Options.get("HeaderFileExtensions");

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 updated this revision to Diff 494928. dkt01 marked an inline comment as done. dkt01 added a comment. Changes requested in owenpan's review. Rebased changes onto latest main branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files:

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 marked 4 inline comments as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:123 private: + ScopeType getScopeType(FormatToken ) { +switch (Token.getType()) { owenpan wrote: > As suggested before. Oops... missed the

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille updated this revision to Diff 494927. serge-sans-paille added a comment. Address @tbader's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142606/new/ https://reviews.llvm.org/D142606 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon updated this revision to Diff 494925. RKSimon added a comment. fix the git diff lost renames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 494921. zyounan added a comment. Fix test on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon updated this revision to Diff 494917. RKSimon added a comment. Add bazel build fix for llvm-cxxmap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 Files:

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added a comment. This check can also work trivially for fmt::format and fmt::print[1] too (in fact, that's what I'm actually using), if the project would allow them to be added too. [1] https://fmt.dev/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

aaronmondal added a comment. Porting to bazel in https://reviews.llvm.org/D143344 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits mailing list

[PATCH] D143343: Broken link to SourceWeb (aka CxxCodeBrowser) project in "External Clang Examples" #60142

s-pratik created this revision. s-pratik added a reviewer: aaron.ballman. Herald added a project: All. s-pratik requested review of this revision. Herald added a project: clang. Replaced the dead link with the correct link in ExternalClangExamples.rst Repository: rG LLVM Github Monorepo

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

chapuni added a comment. @RKSimon Could you cherry-pick it? https://github.com/chapuni/llvm-project/commit/2c09237d8759bb6b1e99940e78901bde5b2bb98f As a position to reduce overhead in tblgen, I don't agree to move this to LLVMDemangle. LLVMSupport depends on LLVMDemangle. llvm-tblgen depends on

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 494911. zyounan added a comment. Herald added a subscriber: ormris. Update tests && Use Preprocessor.LookupFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe created this revision. mikecrowe added a reviewer: njames93. mikecrowe added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a subscriber: cfe-commits. std::format

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:31 +: ClangTidyCheck(Name, Context) { + std::optional HeaderFileExtensionsOption = + Options.get("HeaderFileExtensions"); Will

[PATCH] D143325: [Driver] Add -mllvm= as an alias for -mllvm

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143325/new/ https://reviews.llvm.org/D143325 ___ cfe-commits mailing list

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly

Backl1ght updated this revision to Diff 494903. Backl1ght added a comment. fix typo and add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091/new/ https://reviews.llvm.org/D143091 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D141939: [SVE][Builtins] Lower X forms of binop arithmetic builtins to dedicated intrinsics.

paulwalker-arm added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:762 -multiclass SInstZPZZ flags=[]> { - def _M : SInst; - def _X : SInst; - def _Z : SInst; - - def _N_M : SInst; - def _N_X : SInst; - def _N_Z : SInst; -} - -defm SVABD_S :

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon added a comment. In D143318#4104410 , @phosek wrote: > Another alternative would be to move these classes to the Demangle library. I'm happy to move this to LLVMDemangle instead if everyone agrees. Repository: rG LLVM Github Monorepo

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 494894. carlosgalvezp added a comment. Fix release notes, ImplementationFileExtensions only applies to one check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 494893. carlosgalvezp edited the summary of this revision. carlosgalvezp added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/ https://reviews.llvm.org/D142655

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 494892. carlosgalvezp added a comment. Remove unneeded newlines and braces in single-line if/else statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/ https://reviews.llvm.org/D142655

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 494889. carlosgalvezp edited the summary of this revision. carlosgalvezp added a comment. Update commit message to clarify the difference between the first attempt and this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 494888. carlosgalvezp added a comment. Use get functions from ClangTidyCheck instead of Context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/ https://reviews.llvm.org/D142655 Files:

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 494886. carlosgalvezp retitled this revision from "[WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options" to "[clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options". carlosgalvezp

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 494885. carlosgalvezp added a comment. Herald added a subscriber: arphaman. - Apply fix to remaining checks. - Fix documentation and release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. No idea why I used `isa(ElemType.getTypePtr())`

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:36 +} +return (); + } Is the `.value()` here permitted? AFAIK the convention is to always use `operator*`. And I think @aaron.ballman would tell you to drop the `{}`

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + zero9178 wrote: > serge-sans-paille wrote: > > zero9178 wrote: > > > Any reason this is `mutable`? I don't see it being used

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille updated this revision to Diff 494877. serge-sans-paille added a comment. remove mutable qualifier CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142606/new/ https://reviews.llvm.org/D142606 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

nridge added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15186 + if (ChildExpr == CSE->getOperand()) +// Do not recurse over a CoroutineSuspendExpr's operand. +// The operand is also a subexpression of getCommonExpr(), and

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3891 + * ``PCIS_OnlyNextLine`` (in configuration: ``OnlyNextLine``) +Put all constructor initializers on the next line if they fit. owenpan wrote: > Backl1ght