[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf created this revision. qiucf added reviewers: nemanjai, sfertile, amyk, shchenz, lkail, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang has

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the contribution! Please wait a few days for other reviewers to have a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the given test case, we were trying to

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp:150 + .getAsInteger(10, Num)) +return false; + AP.emitNops(Num); SixWeining wrote: > Seems should return `true`? Consider when verifier is

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void added a comment. In D143300#4108500 , @haowei wrote: > FYI, this patch looks like was pushed into a new "Main" branch instead of the > actual "main" branch.: > > commit f85a9a6452e8f49f9768d66a86434a88a5891614 (origin/Main) > Author: Bill

[clang] 84bf4ab - [C++20] [Modules] Allow ADL in dependent context for modules

Author: Chuanqi Xu Date: 2023-02-07T14:09:46+08:00 New Revision: 84bf4ab087b105e0c72da9ec26ad45e9468fa7be URL: https://github.com/llvm/llvm-project/commit/84bf4ab087b105e0c72da9ec26ad45e9468fa7be DIFF: https://github.com/llvm/llvm-project/commit/84bf4ab087b105e0c72da9ec26ad45e9468fa7be.diff

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found using TSan. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143461 Files:

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta marked 5 inline comments as done. xgupta added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13635 + if (ECDHS && ECDHS->getInitVal() != 0 && ECDHS->getInitVal() != 1) +EnumConstantInBoolContext = true; +} nickdesaulniers

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 495375. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy updated this revision to Diff 495372. vedgy edited the summary of this revision. vedgy added a comment. Address an old inline review comment https://reviews.llvm.org/D139774#inline-1360634 and add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. The added, then reverted release note was lost when this revision landed the second time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya added a comment. thanks for reverting it. i'll take care of the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/ https://reviews.llvm.org/D131230 ___ cfe-commits mailing

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

shafik added a comment. In D142867#4108079 , @eaeltsin wrote: > The warning now fires even if overflow is prevented with `if constexpr`: > > if constexpr (width <= 64) { > if constexpr (width == 64) { > return 1; > } > return

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b95dee3140: MIPS: fix build from IR files, nan2008 and FpAbi (authored by wzssyqa, committed by MaskRay). Repository: rG LLVM Github Monorepo

[clang] b4b95de - MIPS: fix build from IR files, nan2008 and FpAbi

Author: YunQiang Su Date: 2023-02-06T20:36:11-08:00 New Revision: b4b95dee3140e7302d6889173386083978611a12 URL: https://github.com/llvm/llvm-project/commit/b4b95dee3140e7302d6889173386083978611a12 DIFF: https://github.com/llvm/llvm-project/commit/b4b95dee3140e7302d6889173386083978611a12.diff

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added a comment. @efriedma do you have any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 ___ cfe-commits mailing list

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. @MaskRay can you help to submit this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 ___ cfe-commits mailing list

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

pcwang-thead added a comment. I have reverted it in 3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8 . Please update `CodeGen/RISCV/rvv-intrinsics-handcrafted/vlenb.c` and reland this patch again. Repository: rG LLVM Github

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

shafik added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2405 + QualType Ty = + CGF.getContext().getIntTypeForBitwidth(Size, /*Signed*/ false); + if (Ty.isNull()) { To be consistent with

[clang] 3df16e6 - Revert "[RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values"

Author: wangpc Date: 2023-02-07T11:00:25+08:00 New Revision: 3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8 URL: https://github.com/llvm/llvm-project/commit/3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8 DIFF: https://github.com/llvm/llvm-project/commit/3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8.diff LOG:

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

shafik added reviewers: aaron.ballman, cor3ntin, tahonermann. shafik added a comment. WG21 is meeting all this week, so a bunch of folks who should take a look at this may not get around to it right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

shafik added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1203 if (L && !L->isLexingRawMode()) - L->Diag(CP-2, diag::trigraph_ignored); + L->Diag(CP - 2 - L->getBuffer().data(), diag::trigraph_ignored); return 0; I wonder do we really

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

dyung added a comment. @joshua-arch1 and @hiraditya this change is causing a test failure on many bots. Can you take a look and revert if you need time to investigate? Failing bots: - https://lab.llvm.org/buildbot/#/builders/183/builds/10688 -

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `(DRE.data() + any)`

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:162 + InnerMatcher)), + unless(callee(functionDecl(hasAttr(attr::UnsafeBufferUsage); + auto CastOperandMatcher = ziqingluo-90 wrote: >

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT added a comment. Test failures seem related to recent driver changes. There's a commit 6a8a423c1864ced060a7041bf6ada7574f35ad4d that purports to fix them. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:624 + // file entry. + if (Value->V.dyn_cast()) +Entries.push_back(FileEntryRef(Entry)); Nit: I think `dyn_cast()` could be replaced by `is()`. Repository: rG

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:316 + void getSeenFileEntries( + SmallVectorImpl ) + const; rmaz wrote: > jansvoboda11 wrote: > > Since we're already modifying the two only users of this

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#4108588 , @stella.stamenova wrote: > In D135128#4107816 , @jansvoboda11 > wrote: > >> @stella.stamenova ping > > Thanks for the reminder! > > I spent some time looking

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#4107816 , @jansvoboda11 wrote: > @stella.stamenova ping Thanks for the reminder! I spent some time looking for a combination of VS + Win 10 SDK that would work with the new flag, and I believe I've found

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `(DRE.data() + any)`

ziqingluo-90 updated this revision to Diff 495325. ziqingluo-90 retitled this revision from "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`" to "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `(DRE.data() + any)`". ziqingluo-90 added a comment.

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When reseting modular options, propagate the values from

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`

ziqingluo-90 added a comment. In D143128#4108375 , @NoQ wrote: > Why do we prefer `DRE.data() + any` to `()[any]`? It could be much > less intrusive this way, and the safety guarantees are the same. It is actually `(DRE.data() + any)` versus `()[any]`.

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

haowei added a comment. FYI, this patch looks like was pushed into a new "Main" branch instead of the actual "main" branch. It causes git checkout failures on Windows, see error message: warning: encountered old-style '/ssl/certs/ca-bundle.crt' that should be

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT updated this revision to Diff 495314. DHowett-MSFT added a comment. - Use .copy() like the other nearby code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://reviews.llvm.org/D143410 Files:

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`

NoQ added a comment. Why do we prefer `DRE.data() + any` to `()[any]`? It could be much less intrusive this way, and the safety guarantees are the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143128/new/ https://reviews.llvm.org/D143128

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4132 +def DisableADL : InheritableAttr { + let Spellings = [Keyword<"__disable_adl">]; + let Subjects = SubjectList<[Function]>; rsmith wrote: > Has this syntax been discussed already?

[PATCH] D142473: [UTC] Add --version argument

bogner added a comment. Multiple people had concerns with the added complexity of having to maintain historical versions of behaviour here (a concern which I share), and absolutely none of them accepted the revision or commented after the comment that you don’t think it’ll be too bad in

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

This revision was automatically updated to reflect the committed changes. Closed by commit rG28bd84f55fc0: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values (authored by AdityaK 1894981+hiradi...@users.noreply.github.com). Herald added a project: clang. Herald added a

[clang] 28bd84f - [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

Author: AdityaK Date: 2023-02-06T15:32:45-08:00 New Revision: 28bd84f55fc087d4aefd3fe5360f8648d1d50980 URL: https://github.com/llvm/llvm-project/commit/28bd84f55fc087d4aefd3fe5360f8648d1d50980 DIFF: https://github.com/llvm/llvm-project/commit/28bd84f55fc087d4aefd3fe5360f8648d1d50980.diff LOG:

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich added a comment. Thanks for spotting this. Fixed in our local git-tree as well, so it doesn't sneak back in during the merge. I am blind to the difference between Ba, Bb, and Bs by now -- with Ba and Bs being too close to each other on the keyboard for comfort!. Repository:

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. I think buildbot is "formatting" the patch using clang-format-15. The tests of clang-format would be done with latest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

craig.topper added a comment. Description says "XTHeadBs" instead of "XTHeadBb" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143439/new/ https://reviews.llvm.org/D143439 ___ cfe-commits mailing list

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:162 + InnerMatcher)), + unless(callee(functionDecl(hasAttr(attr::UnsafeBufferUsage); + auto CastOperandMatcher = jkorous wrote: > I am

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT marked 2 inline comments as done. DHowett-MSFT added a comment. The new test checks how tightly things were packed across a stack of packs, pushed and popped. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT updated this revision to Diff 495285. DHowett-MSFT added a comment. @mikerice Alright, it turns out that PragmaPackAlignStorage isn't suitable for this (actually, I'm not sure what it _is_ suitable for) because it's deleted by the time the template gets parsed again. The `push,

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:508 + hasUnaryOperand(arraySubscriptExpr( + hasBase(ignoringParenImpCasts(declRefExpr()) +

[clang] 14ca2e6 - Revert "[Fuchsia] Simplify Fuchsia stage2 toolchain setup"

Author: Haowei Wu Date: 2023-02-06T15:00:59-08:00 New Revision: 14ca2e68ff4c8cb03bd8f937ef792a2b638d0258 URL: https://github.com/llvm/llvm-project/commit/14ca2e68ff4c8cb03bd8f937ef792a2b638d0258 DIFF: https://github.com/llvm/llvm-project/commit/14ca2e68ff4c8cb03bd8f937ef792a2b638d0258.diff

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fcdab04c250: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D141738?vs=493766=495281#toc Repository: rG

[clang] 5fcdab0 - [Fuchsia] Build windows runtimes using cross compilation on Linux

Author: Haowei Wu Date: 2023-02-06T14:58:53-08:00 New Revision: 5fcdab04c25039b5acb988568e08da9fc65c40fc URL: https://github.com/llvm/llvm-project/commit/5fcdab04c25039b5acb988568e08da9fc65c40fc DIFF: https://github.com/llvm/llvm-project/commit/5fcdab04c25039b5acb988568e08da9fc65c40fc.diff

[clang] f9ff498 - [Fuchsia] Simplify Fuchsia stage2 toolchain setup

Author: Haowei Wu Date: 2023-02-06T14:58:53-08:00 New Revision: f9ff49882a65ab26ab347f4df8f2a58368d37185 URL: https://github.com/llvm/llvm-project/commit/f9ff49882a65ab26ab347f4df8f2a58368d37185 DIFF: https://github.com/llvm/llvm-project/commit/f9ff49882a65ab26ab347f4df8f2a58368d37185.diff

[PATCH] D129951: adds `__disable_adl` attribute

rsmith added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4132 +def DisableADL : InheritableAttr { + let Spellings = [Keyword<"__disable_adl">]; + let Subjects = SubjectList<[Function]>; Has this syntax been discussed already? If not, why did

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: sammccall, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: s.egerton, kadircet, arphaman, simoncook. Herald added a project: All. DmitryPolukhin requested review of this

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

clayborg added a comment. Changes look fine to me. I would like someone that specializes in the expression parser to give the final ok though. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp:551 const

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

craig.topper added a comment. In D143287#4107439 , @ManuelJBrito wrote: > In D143287#4103597 , @craig.topper > wrote: > >> We have a couple bugs that show (freeze (poison)) doesn't work past >> SelectionDAG.

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf85a9a6452e8: [randstruct] Dont allow implicit forward decl to stop struct randomization (authored by void). Repository: rG LLVM Github Monorepo

[clang] f85a9a6 - [randstruct] Don't allow implicit forward decl to stop struct randomization

Author: Bill Wendling Date: 2023-02-06T14:26:32-08:00 New Revision: f85a9a6452e8f49f9768d66a86434a88a5891614 URL: https://github.com/llvm/llvm-project/commit/f85a9a6452e8f49f9768d66a86434a88a5891614 DIFF: https://github.com/llvm/llvm-project/commit/f85a9a6452e8f49f9768d66a86434a88a5891614.diff

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous accepted this revision. jkorous added a comment. LGTM Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. Why don't we fix the buildbot instead? Why does it use a pre-16 version to test 16 source? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 495268. tkuchta added a comment. Please find the patch for strsep only attached Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files:

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

eaeltsin added a comment. The warning now fires even if it is prevent with `if constexpr`: if constexpr (width <= 64) { if constexpr (width == 64) { return 1; } return -static_cast(uint64_t{1} << (width - 1)); } https://godbolt.org/z/M3xdcKd3M Repository: rG LLVM

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495267. francii added a comment. Rebase and test case update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice added a comment. In D143410#4107862 , @DHowett-MSFT wrote: > While this fixes the assertion failure and the immediate issue of whether > packing _works_ inside delay-parsed templates in a PCH, it does reveal a > follow-on issue that I can't

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra updated this revision to Diff 495265. sivachandra marked 14 inline comments as done. sivachandra added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592 Files:

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:703 + case Strategy::Kind::Span: +return FixItList{}; + case Strategy::Kind::Wontfix: jkorous wrote: > jkorous wrote: > > jkorous wrote: > > > I am afraid

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 495263. ziqingluo-90 added a comment. To avoid emitting incorrect fix-its for array subscripts on `span` objects: - For unsafe operations of the form `s[e]` where `s` is being transformed to be a `span`, we only emit fix-its for `s[e]` when `e` is a

[PATCH] D143412: [HIP] Update test hip-header.hip

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f01266954b1: [HIP] Update test hip-header.hip (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4f01266 - [HIP] Update test hip-header.hip

Author: Yaxun (Sam) Liu Date: 2023-02-06T16:30:47-05:00 New Revision: 4f01266954b12395add2a6a87ef589126cb147fa URL: https://github.com/llvm/llvm-project/commit/4f01266954b12395add2a6a87ef589126cb147fa DIFF:

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/Driver/zos-profiling-error.c:1 +// Check failed cases + Delete this comment. It does not help reading the test.

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz updated this revision to Diff 495259. rmaz added a comment. Don't return virtual file entries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143414/new/ https://reviews.llvm.org/D143414 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

MaskRay added a comment. (The first line of 0ffaffcaac97de31e1b0e7e80c4f7cab724eda20 should have mentioned `Lazyly initialize uncommon toolchain detector`. You can add `Reland` prefix or add the message in the body of the

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8fe9658236: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from… (authored by RKSimon). Changed prior to commit:

[clang] 6ab9f1e - [Driver] Fix -fsanitize-address-stack-use-after-scope after D142606

Author: Fangrui Song Date: 2023-02-06T12:54:34-08:00 New Revision: 6ab9f1e59371fe96ca3fda1a26a28ae0b7caf637 URL: https://github.com/llvm/llvm-project/commit/6ab9f1e59371fe96ca3fda1a26a28ae0b7caf637 DIFF: https://github.com/llvm/llvm-project/commit/6ab9f1e59371fe96ca3fda1a26a28ae0b7caf637.diff

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/ https://reviews.llvm.org/D143300 ___ cfe-commits

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 495250. ziqingluo-90 added a comment. Fixed a bug in manipulating source locations: Using `SourceLocation::getLocWithOffset` to get a new source location `L` with a relative offset is convenient. But it requires extra care to make sure that `L` has

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void updated this revision to Diff 495237. void added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/ https://reviews.llvm.org/D143300 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:162 + InnerMatcher)), + unless(callee(functionDecl(hasAttr(attr::UnsafeBufferUsage); + auto CastOperandMatcher = I am just wondering how does

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT added a comment. While this fixes the assertion failure and the immediate issue of whether packing _works_ inside delay-parsed templates in a PCH, it does reveal a follow-on issue that I can't quite trace out. c++ template void foo() { #pragma pack(push, 1) #pragma

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

MaskRay added inline comments. Comment at: clang/test/CodeGen/init-randomized-struct-fwd-decl.c:2 +// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm -frandomize-layout-seed=1234567890abcdef < %s | FileCheck %s +// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d93da701b1: [Clang] Fix __ptr32 arguments passed to builtins (authored by Ariel-Burton, committed by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d1d93da - [Clang] Fix __ptr32 arguments passed to builtins

Author: Ariel Burton Date: 2023-02-06T19:53:13Z New Revision: d1d93da701b1609bdd992e57be60bb58c6d080cc URL: https://github.com/llvm/llvm-project/commit/d1d93da701b1609bdd992e57be60bb58c6d080cc DIFF: https://github.com/llvm/llvm-project/commit/d1d93da701b1609bdd992e57be60bb58c6d080cc.diff LOG:

[PATCH] D143430: [C2x] Implement the `unreachable` macro for WG14 N2826

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, clang-language-wg, efriedma. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This exposes `__builtin_unreachable` as the expansion for the `unreachable`

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. @stella.stamenova ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142933: Add -print-multi-selection-flags argument

peter.smith added inline comments. Comment at: clang/include/clang/Driver/Options.td:4162 def print_multi_lib : Flag<["-", "--"], "print-multi-lib">; +def print_multi_selection_flags : Flag<["-", "--"], "print-multi-selection-flags-experimental">, + HelpText<"Print the flags

[PATCH] D143428: [clang][deps] Fix race condition

jansvoboda11 created this revision. jansvoboda11 added a reviewer: steven_wu. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D140176

[PATCH] D143427: [clang] NFC: Remove GCC 5.1 workaround in FileEntry

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We no longer support GCC 5.1

[PATCH] D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc1c8917afd3: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES

[clang] dc1c891 - [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

Author: Haowei Wu Date: 2023-02-06T11:36:27-08:00 New Revision: dc1c8917afd3f2b306797890a56be66087feb832 URL: https://github.com/llvm/llvm-project/commit/dc1c8917afd3f2b306797890a56be66087feb832 DIFF: https://github.com/llvm/llvm-project/commit/dc1c8917afd3f2b306797890a56be66087feb832.diff

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18891 +// incomplete definition. +if (const auto *RD = dyn_cast(D)) + return !RD->isCompleteDefinition(); nickdesaulniers wrote: > nickdesaulniers wrote: > > void wrote:

[PATCH] D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

haowei updated this revision to Diff 495221. haowei marked an inline comment as done. haowei retitled this revision from "[Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency" to "[Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency". haowei edited the summary of this

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:625-627 +Entries.push_back( +FileEntryRef(*reinterpret_cast( +Value->V.get(; rmaz wrote: > jansvoboda11 wrote: > > Why is this necessary?

[PATCH] D143288: [Fuchsia] Simplified the stage2 build setup

This revision was automatically updated to reflect the committed changes. Closed by commit rG630266aed342: [Fuchsia] Simplified the stage2 build setup (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D143288?vs=494694=495216#toc Repository: rG LLVM Github Monorepo

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice added inline comments. Comment at: clang/test/PCH/delayed-template-with-pragma-pack.cpp:14 +int func() { +#pragma pack(push, 1) + struct s { short a; T b; }; Your test should include testing of the slot string too, so we are sure all fields are

[clang] 630266a - [Fuchsia] Simplified the stage2 build setup

Author: Haowei Wu Date: 2023-02-06T10:46:31-08:00 New Revision: 630266aed342797d6413a69b8792567fc6263501 URL: https://github.com/llvm/llvm-project/commit/630266aed342797d6413a69b8792567fc6263501 DIFF: https://github.com/llvm/llvm-project/commit/630266aed342797d6413a69b8792567fc6263501.diff

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/init-randomized-struct-fwd-decl.c:2 +// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm -frandomize-layout-seed=1234567890abcdef < %s | FileCheck %s +// RUN: %clang_cc1 -triple=x86_64-unknown-linux

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:316 + void getSeenFileEntries( + SmallVectorImpl ) + const; jansvoboda11 wrote: > Since we're already modifying the two only users of this function, maybe we > could use

[clang] 3f33e6b - [LinkerWrapper] Output a temp file with the wrapper bitcode

Author: Joseph Huber Date: 2023-02-06T12:34:00-06:00 New Revision: 3f33e6b1f4d08dd3e4dec91ae4d8e4cf292f0acc URL: https://github.com/llvm/llvm-project/commit/3f33e6b1f4d08dd3e4dec91ae4d8e4cf292f0acc DIFF: https://github.com/llvm/llvm-project/commit/3f33e6b1f4d08dd3e4dec91ae4d8e4cf292f0acc.diff

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143021/new/ https://reviews.llvm.org/D143021 ___ cfe-commits mailing list

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

void accepted this revision. void added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205/new/ https://reviews.llvm.org/D143205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/init-randomized-struct-fwd-decl.c:23 + +// CHECK-LABEL: define {{.*}}@t1 +// CHECK-NOT: getelementptr inbounds %struct.foo, ptr %3, i32

  1   2   3   >