[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 496346. carlosgalvezp added a comment. Document options now that the documentation improvement patch is merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/ https://reviews.llvm.org/D142655

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a subscriber: dblaikie. vedgy added a comment. In D143418#4116290 , @aaron.ballman wrote: >> So how about a more sincere general solution: setPreferredTempDirPath()? The >> documentation would say that libclang tries its best to place

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

dvyukov accepted this revision. dvyukov added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/fsanitize-metadata-ignorelist.c:6 +// RUN: %clang -target aarch64-linux-gnu -fexperimental-sanitize-metadata=all

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1082 + MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false)); + aeubanks wrote: > aeubanks wrote: > > I think we want to insert lifetime intrinsics when

[clang] 2db83b1 - [CMake] Fix -DBUILD_SHARED_LIBS=on builds after D137534

Author: Kai Luo Date: 2023-02-10T04:58:20Z New Revision: 2db83b1b311bae3d14067970edf15c6a1d37 URL: https://github.com/llvm/llvm-project/commit/2db83b1b311bae3d14067970edf15c6a1d37 DIFF: https://github.com/llvm/llvm-project/commit/2db83b1b311bae3d14067970edf15c6a1d37.diff LOG:

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan added a comment. In D143319#4115186 , @kadircet wrote: > thanks a lot for the patch! > > we're migrating IWYU related functionality in clangd to make use of > include-cleaner library nowadays. so can you actually move the IWYU > no_include

[clang] e135476 - [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

Author: Chuanqi Xu Date: 2023-02-10T11:23:36+08:00 New Revision: e1354763b6e641e45cc2371270883fcd26edf705 URL: https://github.com/llvm/llvm-project/commit/e1354763b6e641e45cc2371270883fcd26edf705 DIFF: https://github.com/llvm/llvm-project/commit/e1354763b6e641e45cc2371270883fcd26edf705.diff

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1354763b6e6: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file… (authored by ChuanqiXu). Changed prior to commit:

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496311. eopXD added a comment. Update code based on comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files: clang/include/clang/AST/Type.h

[clang] 35537ae - [Modules][Test][NFC] Fix -Wsign-compare in clang/unittests/Lex/ModuleDeclStateTest.cpp

Author: Jie Fu Date: 2023-02-10T10:51:21+08:00 New Revision: 35537aea1228df29c4e32049e4750029c5f0693b URL: https://github.com/llvm/llvm-project/commit/35537aea1228df29c4e32049e4750029c5f0693b DIFF: https://github.com/llvm/llvm-project/commit/35537aea1228df29c4e32049e4750029c5f0693b.diff LOG:

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. (my latest comments didn't get addressed in the land) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143624/new/ https://reviews.llvm.org/D143624 ___ cfe-commits mailing list

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG591fdcde9213: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified… (authored by ChuanqiXu). Changed prior to commit:

[clang] 591fdcd - [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

Author: Chuanqi Xu Date: 2023-02-10T10:42:04+08:00 New Revision: 591fdcde921334b2d502779006d7c168307a2106 URL: https://github.com/llvm/llvm-project/commit/591fdcde921334b2d502779006d7c168307a2106 DIFF: https://github.com/llvm/llvm-project/commit/591fdcde921334b2d502779006d7c168307a2106.diff

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added a comment. I think it may be an option to use the `gnu++*` modes to do deliberately non-conforming things, but I believe there should be an RFC for that first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143670/new/

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1723 + Addr = + Addr.withPointer(Builder.CreateThreadLocalAddress(GV), KnownNonNull); ahatanak wrote: > `KnownNonNull` is being passed here because the address of a load

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde17c665e3f9: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps

[clang] de17c66 - [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

Author: Chuanqi Xu Date: 2023-02-10T10:26:43+08:00 New Revision: de17c665e3f995c7f5a0e453461ce3a1b8aec196 URL: https://github.com/llvm/llvm-project/commit/de17c665e3f995c7f5a0e453461ce3a1b8aec196 DIFF: https://github.com/llvm/llvm-project/commit/de17c665e3f995c7f5a0e453461ce3a1b8aec196.diff

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak updated this revision to Diff 496305. ahatanak added a comment. - Set the `KnownNonNull` bit correctly when `Address::withAlignment` is called. - Pass `NotKnownNonNull` to the call to `Addr.withPointer` when the address of thread local storage is created. Repository: rG LLVM Github

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:51 // FIXME(201806L) CHECK: assert: 0 -// CHECK: carries_dependency: 200809L +// CHECK: carries_dependency: 0 //

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6470706bc0ed: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for… (authored by ChuanqiXu). Herald added a project: clang.

[clang] 6470706 - [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

Author: Chuanqi Xu Date: 2023-02-10T10:11:36+08:00 New Revision: 6470706bc0ed2425704bc8c9e121a72e2d272616 URL: https://github.com/llvm/llvm-project/commit/6470706bc0ed2425704bc8c9e121a72e2d272616 DIFF: https://github.com/llvm/llvm-project/commit/6470706bc0ed2425704bc8c9e121a72e2d272616.diff

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

tahonermann added a comment. > The guidance from EWG this week and in the past was that we are always > required to 'parse and diagnose appertainment' of standard attributes, but > not to enable __has_cpp_attribute unless we actually 'do' something with it. > I intend/suggest we add a

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

hiraditya accepted this revision. hiraditya added a comment. LGTM, thanks for putting this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/new/ https://reviews.llvm.org/D143692 ___

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2049 -if (Ty->isVectorFloat16Type() && -!Context.getTargetInfo().hasVectorFloat16Support()) { +if ((Ty->isVectorInt64Type() && + !Context.getTargetInfo().hasVectorInt64Support()) ||

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:668 + /// Determine whether vector int64 type is supported on this target. + virtual bool hasVectorInt64Support() const { return false; } + craig.topper wrote: > Having a different

[PATCH] D143455: [-Wunsafe-buffer-usage] Emit Fix-Its only for C++20 and later standards

jkorous added a comment. We actually have only commits with warnings in `release/16.x` - no Fix-Its. So no need to cherry-pick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143455/new/ https://reviews.llvm.org/D143455

[clang] 8b6ae9b - [-Wunsafe-buffer-usage] Emit Fix-Its only for C++20 and later standards

Author: Jan Korous Date: 2023-02-09T17:28:27-08:00 New Revision: 8b6ae9bd7466bd3ceefcd8bd0262b9b085481697 URL: https://github.com/llvm/llvm-project/commit/8b6ae9bd7466bd3ceefcd8bd0262b9b085481697 DIFF: https://github.com/llvm/llvm-project/commit/8b6ae9bd7466bd3ceefcd8bd0262b9b085481697.diff

[PATCH] D143455: [-Wunsafe-buffer-usage] Emit Fix-Its only for C++20 and later standards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b6ae9bd7466: [-Wunsafe-buffer-usage] Emit Fix-Its only for C++20 and later standards (authored by jkorous). Herald added a project: clang. Herald

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth updated this revision to Diff 496290. paulkirth added a comment. Address comments. - use render and remove redundant/incorrect call to `AddLastArg`. - add test to make sure we don't issue an error when emulated TLS is disabled on unsupported platforms Repository: rG LLVM Github

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:16 #include namespace clang { `` is used, but not included. Currently, it works, since another header already included it. Repository: rG LLVM Github Monorepo

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. The guidance from EWG this week and in the past was that we are always required to 'parse and diagnose appertainment' of standard attributes, but not to enable

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe added a comment. Still some issues with: SortPriorities The following settings (note the SortPriority of '^<.*' == 1) which will produce an extra group for the attached includes: IncludeCategories: - Regex: '^' Priority:2 SortPriority:2 - Regex:

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1082 + MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false)); + aeubanks wrote: > I think we want to insert lifetime intrinsics when optimizing this will never

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6170 + + if (Arg *A = Args.getLastArg(options::OPT_femulated_tls)) { +// LLVM does not support Emulated TLS for

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth created this revision. paulkirth added reviewers: arichardson, hiraditya, jrtc27, phosek. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead,

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe created this revision. Herald added a project: All. Febbe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Main Include Files have now always prio (0,0) - They can't be matched by negative matchers anymore. - `SortPriority` now

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496276. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143472: [clang] Cast the pointer to right type with different address space

cdai2 updated this revision to Diff 496275. cdai2 added a comment. Update cases to cover both opaque pointer and typed pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143472/new/ https://reviews.llvm.org/D143472 Files:

[PATCH] D49723: [OpenCL] Check for invalid kernel arguments in array types

asavonic added a comment. In D49723#4116435 , @Ayal wrote: > This is admittedly a couple of years old by now, but wonder about that other > intended patch - Clang still seems to consider pointers in struct arguments > to be illegal in CL2.0 (and CL3.0)

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir updated this revision to Diff 496274. Amir edited the summary of this revision. Amir added a comment. Remove sysroot_flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files:

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496273. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496272. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496271. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

mtrofin added a comment. In D143624#4116546 , @aeubanks wrote: > Had a chat offline with @mtrofin, wanted to be clear for future purposes that > we do need the separate AlwaysInliner pass because it's used in -O0 and > constructing a call graph there

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

mtrofin accepted this revision. mtrofin added a comment. This revision is now accepted and ready to land. lgtm. Like @aeubanks was saying, let's just give a bit of time (1 month or so?) between when this lands and until we clean up the "mandatory" notion from the advisor, just to make sure

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan marked an inline comment as done. owenpan added a comment. In D143546#4116354 , @MyDeveloperDay wrote: > In D143546#4114341 , @owenpan wrote: > >> In D143546#4113721

[PATCH] D143684: Add missing cases to clang switch after D141863

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8da5a208e6: Add missing cases to clang switch after D141863

[clang] 5d8da5a - Add missing cases to clang switch after D141863

Author: Krzysztof Drewniak Date: 2023-02-09T23:17:55Z New Revision: 5d8da5a208e6501baff7a8fd8de76ea143e49646 URL: https://github.com/llvm/llvm-project/commit/5d8da5a208e6501baff7a8fd8de76ea143e49646 DIFF: https://github.com/llvm/llvm-project/commit/5d8da5a208e6501baff7a8fd8de76ea143e49646.diff

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496253. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4116546 , @aeubanks wrote: > Had a chat offline with @mtrofin, wanted to be clear for future purposes that > we do need the separate AlwaysInliner pass because it's used in -O0 and > constructing a call graph there

[PATCH] D143559: [Tooling/Inclusion] Use the StdSpecialSymbolMap.inc in the stdlib

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG11dcd88577f4: [Tooling/Inclusion] Use the StdSpecialSymbolMap.inc in the stdlib (authored by hokein).

[clang] 11dcd88 - [Tooling/Inclusion] Use the StdSpecialSymbolMap.inc in the stdlib

Author: Haojian Wu Date: 2023-02-10T00:04:23+01:00 New Revision: 11dcd88577f4cba30db9c0d0d899008bbf57616d URL: https://github.com/llvm/llvm-project/commit/11dcd88577f4cba30db9c0d0d899008bbf57616d DIFF: https://github.com/llvm/llvm-project/commit/11dcd88577f4cba30db9c0d0d899008bbf57616d.diff

[PATCH] D143617: [Clang][CMake] Break out Instrument from CLANG_BOLT option

Amir updated this revision to Diff 496249. Amir added a comment. Add perf and perf+LBR support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt

[PATCH] D143684: Add missing cases to clang switch after D141863

krzysz00 created this revision. Herald added a project: All. krzysz00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Turns out there's a switch on APFloat semantics in clang I wasn't aware of, fix the build error here. Repository: rG

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. Had a chat offline with @mtrofin, wanted to be clear for future purposes that we do need the separate AlwaysInliner pass because it's used in -O0 and constructing a call graph there is non-trivial in terms of compile time. Originally the mandatory mode of the normal

[PATCH] D143680: [WIP][-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For a local pointer declaration of the form

[PATCH] D49723: [OpenCL] Check for invalid kernel arguments in array types

Ayal added a comment. Herald added a subscriber: Naghasan. Herald added a project: All. In D49723#1178186 , @asavonic wrote: > In D49723#1178127 , @Anastasia wrote: > >> In D49723#1174837

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

craig.topper added inline comments. Comment at: clang/include/clang/AST/Type.h:7209 +inline bool Type::isVectorFloat32Type() const { +#define RVV_TYPE(Name, Id, SingletonId) false || This function is RVV specific so it's name is misleading. It's also identical

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan marked an inline comment as done. owenpan added a comment. In D143546#4116196 , @HazardyKnusperkeks wrote: > In D143546#4114341 , @owenpan wrote: > >> In D143546#4113721

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4e35c63711b: [clang-format] Insert a space between a numeric UDL and a dot (authored by owenpan). Changed prior to commit:

[clang] b4e35c6 - [clang-format] Insert a space between a numeric UDL and a dot

Author: Owen Pan Date: 2023-02-09T13:34:57-08:00 New Revision: b4e35c63711b4bde10b83607d04dab4bfdb86482 URL: https://github.com/llvm/llvm-project/commit/b4e35c63711b4bde10b83607d04dab4bfdb86482 DIFF: https://github.com/llvm/llvm-project/commit/b4e35c63711b4bde10b83607d04dab4bfdb86482.diff

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

MyDeveloperDay added a comment. In D143546#4114341 , @owenpan wrote: > In D143546#4113721 , @rymiel wrote: > >> In D143546#4112077 , @owenpan >> wrote: >> >>> As this

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143546/new/ https://reviews.llvm.org/D143546 ___ cfe-commits mailing list

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116318 , @aemerson wrote: > Sure, the exponential compile time case is actually just a side benefit here. > The motivating reason for this change is actually to improve code size when > building codebases that make

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116171 , @mtrofin wrote: > In D143624#4115986 , @aeubanks > wrote: > >> __clang_hip_math.hip is annoying... >> >> We'll need to remove the `MandatoryFirst` inliner in >>

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4116114 , @aeubanks wrote: > In D143624#4116080 , @aemerson > wrote: > >> In D143624#4115986 , @aeubanks >> wrote: >> >>>

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a subscriber: jkorous. aaron.ballman added a comment. In D143418#4111990 , @vedgy wrote: > I hoped to avoid applying an unrelated `git clang-format`'s include > reordering, but the CI fails because of that. Will apply it along with

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional updated this revision to Diff 496213. everythingfunctional added a comment. rebase to get fix for build/test failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143592/new/ https://reviews.llvm.org/D143592 Files: clang/include/clang/Driver/Options.td

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. > I'd recommend a possible long-term solution would be simplified template > names (so we don't have to worry about encoding this in the `DW_AT_name` > anyway) and a "DW_AT_LLVM_preferred_name" or similar attribute on a type that > refers to the typedef that is the

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

HazardyKnusperkeks added a comment. In D143546#4114341 , @owenpan wrote: > In D143546#4113721 , @rymiel wrote: > >> In D143546#4112077 , @owenpan >> wrote: >> >>> As

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

mtrofin added a comment. In D143624#4115986 , @aeubanks wrote: > __clang_hip_math.hip is annoying... > > We'll need to remove the `MandatoryFirst` inliner in > `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with > that or not

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

dblaikie added a comment. In D143501#4110302 , @Michael137 wrote: > The alternative would be attaching the preferred name as a new attribute or > an existing attribute like `DW_AT_description`. I'd recommend a possible long-term solution would be

[clang] 8711120 - [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

Author: Ben Langmuir Date: 2023-02-09T11:42:03-08:00 New Revision: 8711120e8bcf891f3c316e20869493e93472f200 URL: https://github.com/llvm/llvm-project/commit/8711120e8bcf891f3c316e20869493e93472f200 DIFF: https://github.com/llvm/llvm-project/commit/8711120e8bcf891f3c316e20869493e93472f200.diff

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG8711120e8bcf: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

philnik added a comment. In D143670#4116118 , @cor3ntin wrote: > Thanks for doing this Aaron. > Did you look in libc++ if they used it anywhere? (I assume they don't) I'm not aware of any uses, and I would be quite surprised if it was used anywhere

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks for doing this Aaron. Did you look in libc++ if they used it anywhere? (I assume they don't) Comment at: clang/docs/ReleaseNotes.rst:131 +- Clang no longer claims

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116080 , @aemerson wrote: > In D143624#4115986 , @aeubanks > wrote: > >> __clang_hip_math.hip is annoying... >> >> We'll need to remove the `MandatoryFirst` inliner in >>

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, erichkeane, rsmith, hubert.reinterpretcast. Herald added a subscriber: jdoerfert. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The

[PATCH] D143634: [ModuleUtils] Assert correct linkage and visibility of structors' COMDAT key

pcc added a comment. I've always considered that this should be fixed by extending the resolution-based LTO API to also include resolutions for comdats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143634/new/ https://reviews.llvm.org/D143634

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4115986 , @aeubanks wrote: > __clang_hip_math.hip is annoying... > > We'll need to remove the `MandatoryFirst` inliner in > `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with > that or not

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115979 , @aaron.ballman wrote: > In D140756#4115963 , @vedgy wrote: > >> In D140756#4115381 , >> @aaron.ballman wrote: >> >>>

[clang] 4c84c13 - [libclang] Add "global:" to the module map explicitly; NFC intended

Author: Aaron Ballman Date: 2023-02-09T14:01:54-05:00 New Revision: 4c84c1314716392061215aac7f299493bdf3cc93 URL: https://github.com/llvm/llvm-project/commit/4c84c1314716392061215aac7f299493bdf3cc93 DIFF: https://github.com/llvm/llvm-project/commit/4c84c1314716392061215aac7f299493bdf3cc93.diff

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:318 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } philipp.tomsich wrote: > craig.topper wrote: > >

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD updated this revision to Diff 496185. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143665/new/ https://reviews.llvm.org/D143665 Files: clang/include/clang/AST/Type.h

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496183. eopXD added a comment. Update code: check for `experimental-zvfh` instead of `zvfh`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files:

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce87b0314370: [clangd] Fix getQueryScopes for using-directive with inline namespace (authored by tom-anders). Changed prior to commit:

[clang-tools-extra] ce87b03 - [clangd] Fix getQueryScopes for using-directive with inline namespace

Author: Tom Praschan Date: 2023-02-09T20:53:33+01:00 New Revision: ce87b031437071f011026bb850a2fb2e5f9a72b4 URL: https://github.com/llvm/llvm-project/commit/ce87b031437071f011026bb850a2fb2e5f9a72b4 DIFF: https://github.com/llvm/llvm-project/commit/ce87b031437071f011026bb850a2fb2e5f9a72b4.diff

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. __clang_hip_math.hip is annoying... We'll need to remove the `MandatoryFirst` inliner in `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with that or not This isn't quite what I had initially thought, but this might be better. (I was

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

jansvoboda11 added a comment. In D143613#4115935 , @benlangmuir wrote: > In D143613#4115857 , @jansvoboda11 > wrote: > >> LGTM, but would be nice to have a test for this. > > Oh, I didn't realize we didn't have

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115963 , @vedgy wrote: > In D140756#4115381 , @aaron.ballman > wrote: > >> The spare moment came sooner than expected, I've made the changes in >>

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders added a comment. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140915/new/ https://reviews.llvm.org/D140915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. In D140756#4115381 , @aaron.ballman wrote: > The spare moment came sooner than expected, I've made the changes in > de4321cf2cf28f2bae7fc0f1897957e73b726f89 >

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

benlangmuir added a comment. In D143613#4115857 , @jansvoboda11 wrote: > LGTM, but would be nice to have a test for this. Oh, I didn't realize we didn't have one already. Added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143613/new/

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

benlangmuir updated this revision to Diff 496173. benlangmuir added a comment. Add a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143613/new/ https://reviews.llvm.org/D143613 Files: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If clang is part of a toolchain that can locate clang_rt

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD created this revision. eopXD added reviewers: craig.topper, aaron.ballman, kito-cheng, asb. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

melver created this revision. melver added reviewers: dvyukov, vitalybuka. Herald added subscribers: Enna1, ormris, hiraditya. Herald added a project: All. melver requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM.

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, but would be nice to have a test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143613/new/

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496160. eopXD added a comment. Update code: rename error for vector support, remove dead code under SemaRISCVVectorLoopup.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD added a comment. Forward declaration (snippet below) is still allowed after this commit. #include vfloat16m1_t foo(); I see the same behavior under https://github.com/llvm/llvm-project/blob/main/clang/test/Sema/x86_64-no-x87.cpp. If I add type check under

  1   2   >