[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime added inline comments. Comment at: clang/lib/AST/CXXInheritance.cpp:84 [BaseDecl](const CXXBaseSpecifier *Specifier, CXXBasePath ) { return Specifier->getType()->getAsRecordDecl() && FindBaseClass(Specifier, Path, BaseDecl);

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 496742. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime created this revision. lime added reviewers: aaron.ballman, erichkeane, cor3ntin, clang-language-wg. Herald added a subscriber: yaxunl. Herald added a project: All. lime requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[clang] 6a75aec - [Clang][perf-training] Remove trailing whitespace in perf-helper

Author: Amir Ayupov Date: 2023-02-11T21:10:27-08:00 New Revision: 6a75aec090986d3c897af7cfed8836ff36b38181 URL: https://github.com/llvm/llvm-project/commit/6a75aec090986d3c897af7cfed8836ff36b38181 DIFF: https://github.com/llvm/llvm-project/commit/6a75aec090986d3c897af7cfed8836ff36b38181.diff

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added a comment. Note that D138546 is removing the call to `inferTargetAndDriverMode()` from `GlobalCompilationDatabase.cpp`. It adds equivalent logic too `CommandMangler` which is used for CDBs pushed from LSP as well, so it accomplishes objective of

[PATCH] D143301: Emit warning for unsupported gfortran flags

elmcdonough updated this revision to Diff 496730. elmcdonough retitled this revision from "Emit warning for `-Wextra` instead of error" to "Emit warning for unsupported gfortran flags". elmcdonough added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D143831: [clang-format] Don't rewrite the input file if already formatted

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. New: module mh1 (input var

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

dyung added a comment. I'm still seeing random crashes today on a linux buildbot in the test you added P1689 .cppm. Can you either fix or revert? - https://lab.llvm.org/buildbot/#/builders/139/builds/35899 -

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

tianshilei1992 added a comment. FWIW, there are methods in CMake to check if features (such as if a struct contains specific data member, or if a library contains APIs). I think that would be the right way to fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

jhuber6 added a comment. Actually, I might want to optionally link this stuff in the `libc` project in the future as well. That would be a dependency only required for tests but it might be compelling then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496680. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files: clang/include/clang/AST/Type.h

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan added a comment. In D143755#4118802 , @vedgy wrote: > Hi @owenpan. Thank you for fixing this bug! > Have you noticed this paragraph in my bug report? > >> I believe `clang_getTypeSpelling()`, or more likely `QualType::print()` used >> by it,

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan updated this revision to Diff 496670. owenpan added a comment. Added `tryMergeGreaterGreater()` to and fixed `tryMergerLessLess()` of `FormatTokenLexer`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143755/new/ https://reviews.llvm.org/D143755 Files: