[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf added a comment. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143479/new/ https://reviews.llvm.org/D143479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. In D143467#4182457 , @nemanjai wrote: > Another note regarding the motivating test case: > Use of `vector double` should require VSX. We don't really seem to have the > ability to turn this off early enough to catch this though.

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 504945. dhruvachak added a comment. Fixed LIT test failure, added new clang test OpenMP/bug60602.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 Files:

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

yrouban added a comment. Looks good in general, but it would be better to have this patch split into several smaller patches: renaming NFC, InstructionCounter intro, one for each particular pass fix. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1057 + struct

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145725/new/ https://reviews.llvm.org/D145725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

abrachet added a comment. Both comments addressed in commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145725/new/ https://reviews.llvm.org/D145725 ___ cfe-commits mailing list

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rGdf405dbfd316: [Driver] Make -X default for baremetal riscv (authored by abrachet). Herald added a

[clang] df405db - [Driver] Make -X default for baremetal riscv

Author: Alex Brachet Date: 2023-03-14T05:17:54Z New Revision: df405dbfd316a598474b73f8c57f0d1051b4b51e URL: https://github.com/llvm/llvm-project/commit/df405dbfd316a598474b73f8c57f0d1051b4b51e DIFF: https://github.com/llvm/llvm-project/commit/df405dbfd316a598474b73f8c57f0d1051b4b51e.diff LOG:

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/XRay/xray-instrument-macos.c:1 +// RUN: %clang -o /dev/null -v -fxray-instrument -target aarch64-apple-darwin20 -c %s // RUN: %clang -o

[PATCH] D145941: [Clang] Always use -zdefs when linking AMDGPU images

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. While `--no-undefined` is an alias for `-z defs`, be consistent in the subject and the body. > Always use -zdefs `--no-undefined` Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/CodeGen/xray-function-index.cpp:1 +// RUN: %clang_cc1 -fxray-instrument -x c++ -std=c++11 -triple

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. @kadircet, could I get your review on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184 + SmallString<128> MultilibPath(SysRootDir); + llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME); + Rather than hardcoding the filename and the location, which

[PATCH] D142933: Add -print-multi-selection-tags-experimental option

phosek added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:237-245 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos, Neg; +

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

shafik added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889 +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; aaron.ballman wrote: > I think there's one more test to add: > ``` > struct UnnamedEmptyBitfieldSplit { > short

[PATCH] D142932: Multilib YAML parsing

phosek added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:137 +struct MultilibSetSerialization { + std::string ClangMinimumVersion; + std::vector Multilibs; Can we use a separate versioning scheme rather than tying the version to Clang? That is

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

hazohelet updated this revision to Diff 504933. hazohelet added a comment. Address comments from @aaron.ballman - NFC stylistic changes Thanks for the review! Since I don't have commit access, would you please land this patch for me? Please use "Takuya Shimizu " for the patch attribution.

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added a comment. I have just one comment related to efficiency, but if it turns out to be too difficult to address, I'd be also fine landing this change as is and addressing that issue in a follow up change. Comment at: clang/lib/Driver/MultilibBuilder.cpp:94-100 +

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

shafik added a comment. LGTM, I wlll let @royjacobson give the final approval after reviewing codegen tests. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9161-9162 +if (CSM == Sema::CXXDefaultConstructor) { + // Default constructor of a union can also be valid if one

[PATCH] D145794: [clang-format] Recognize Verilog always blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f8bab9bad7: [clang-format] Recognize Verilog always blocks (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a1f8bab - [clang-format] Recognize Verilog always blocks

Author: sstwcw Date: 2023-03-14T03:49:56Z New Revision: a1f8bab9bad7dc7ef5bae518bc3289f4111846f3 URL: https://github.com/llvm/llvm-project/commit/a1f8bab9bad7dc7ef5bae518bc3289f4111846f3 DIFF: https://github.com/llvm/llvm-project/commit/a1f8bab9bad7dc7ef5bae518bc3289f4111846f3.diff LOG:

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 ___ cfe-commits mailing list

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. Herald added a subscriber: jobnoorman. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145088/new/ https://reviews.llvm.org/D145088 ___ cfe-commits mailing list

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

ChuanqiXu added a comment. @iains @dblaikie gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144844/new/ https://reviews.llvm.org/D144844 ___ cfe-commits mailing list

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

jyu2 updated this revision to Diff 504907. jyu2 added a comment. Fix clang format problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146000/new/ https://reviews.llvm.org/D146000 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D145987: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9db89fbcfda: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/ (authored by kuhar). Repository: rG LLVM Github Monorepo

[clang] b9db89f - [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

Author: Jakub Kuderski Date: 2023-03-13T20:59:06-04:00 New Revision: b9db89fbcfdaece8656159a2a0f0a2f09cdd7db7 URL: https://github.com/llvm/llvm-project/commit/b9db89fbcfdaece8656159a2a0f0a2f09cdd7db7 DIFF:

[PATCH] D145987: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

kuhar updated this revision to Diff 504901. kuhar marked an inline comment as done. kuhar added a comment. Update lambda signature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145987/new/ https://reviews.llvm.org/D145987 Files:

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG148dc8a2a80f: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream (authored by ziqingluo-90). Changed prior to commit:

[clang] 148dc8a - [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

Author: ziqingluo-90 Date: 2023-03-13T17:22:22-07:00 New Revision: 148dc8a2a80f6b4ab80914c153279205a78315ed URL: https://github.com/llvm/llvm-project/commit/148dc8a2a80f6b4ab80914c153279205a78315ed DIFF: https://github.com/llvm/llvm-project/commit/148dc8a2a80f6b4ab80914c153279205a78315ed.diff

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

ziqingluo-90 updated this revision to Diff 504896. ziqingluo-90 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145993/new/ https://reviews.llvm.org/D145993 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

aeubanks created this revision. Herald added subscribers: ormris, ChuanqiXu, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. CoroCleanup was running

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

yln added a comment. Mentioned removal of flag in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715 ___ cfe-commits mailing list

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

samitolvanen accepted this revision. samitolvanen added a comment. LGTM. Folding D145979 into this one might also make sense. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4190901 , @scott.linder wrote: > Is there a corresponding document update to go along with this? If consumers > of the bundles will begin to rely on this it should be documented that it is > guaranteed by the

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 504893. lamb-j added a comment. Adding note to documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770 Files: clang/docs/ClangOffloadBundler.rst

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

yln updated this revision to Diff 504890. yln marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. I cannot find an example that throw `error: expression contains unexpanded parameter pack 'T'` in fold expression because code like ` (foo(10 + (static_cast(1))) + ...);` can be unpack both `T` and `U` in same `...` operator But this code can be diagnosed

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish updated this revision to Diff 504887. snehasish added a comment. Update the unittest in compiler-rt which was caught by the build bot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish reopened this revision. snehasish added a comment. This revision is now accepted and ready to land. Reopening since I missed the updates to the memprof unit tests in compiler-rt. This was caught by the buildbots. As part of the changes I modified the `SerializeToRawProfile` API

[PATCH] D145833: Switch ABI references to env/environment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb47d4df25c69: Switch ABI references to env/environment (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145833/new/

[clang] b47d4df - Switch ABI references to env/environment

Author: Jacob Lambert Date: 2023-03-13T16:19:31-07:00 New Revision: b47d4df25c696739dbbb9e373ffd8a501eabcfef URL: https://github.com/llvm/llvm-project/commit/b47d4df25c696739dbbb9e373ffd8a501eabcfef DIFF: https://github.com/llvm/llvm-project/commit/b47d4df25c696739dbbb9e373ffd8a501eabcfef.diff

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504884. francii added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, ormris. Update check in AIX.cpp, add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

hiraditya created this revision. hiraditya added reviewers: enh, asb. Herald added subscribers: jobnoorman, luke, VincentWu, abrachet, danielkiss, vkmr, frasercrmck, evandro, phosek, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D145859: [Clang][CodeGen] Fix linkage of template parameter objects

rsmith added a comment. Looks good. If you want to look at the visibility side of this separately I think that's fine (I only called it out here because we often consider them at the same time). Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3241-3246 +

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticOptions.h:110 + /// The file to serialise text diagnostics to (non-appending). + std::string FilePath; + erichkeane wrote: > I'm a touch

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Herald added a subscriber: jobnoorman. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:820 +errc::invalid_argument, +"zvk* requires v or zve* extension to also be specified"); + Put single quotes around extension

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. eddyz87 updated this revision to Diff 497835. eddyz87 added a comment. eddyz87 retitled this revision from "[DebugInfo][BPF] 'annotations' on a target type to represent btf_type_tag" to

[PATCH] D145838: [clang][deps] Handle response files in dep scanner

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcab930cd32e: [clang][deps] Handle response files in dep scanner (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145838/new/

[clang] fcab930 - [clang][deps] Handle response files in dep scanner

Author: Ben Langmuir Date: 2023-03-13T15:47:35-07:00 New Revision: fcab930cd32e6d977816fa7094a0de0bc0d7dd1f URL: https://github.com/llvm/llvm-project/commit/fcab930cd32e6d977816fa7094a0de0bc0d7dd1f DIFF: https://github.com/llvm/llvm-project/commit/fcab930cd32e6d977816fa7094a0de0bc0d7dd1f.diff

[PATCH] D145838: [clang][deps] Handle response files in dep scanner

Bigcheese accepted this revision. Bigcheese added a comment. LTGM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145838/new/ https://reviews.llvm.org/D145838 ___ cfe-commits mailing list

[PATCH] D145987: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright - thanks! :) Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3962 int InitialOffset = std::get<1>(Vec[0]); - AnyConsecutive |=

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

xazax.hun added a comment. Do you plan to selectively enable warnings coming from the STL to catch misuses of certain STL types? I think we should probably discuss this direction first. It is, in general, a fragile approach. Users might use Clang with GCC's, LLVM's, or MSVC's standard

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

jkorous accepted this revision. jkorous added a comment. +1 to moving the comparator to the .cpp file; otherwise LGTM! Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145993/new/ https://reviews.llvm.org/D145993

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bolshakov-a wrote: > bnbarham wrote: > > bolshakov-a wrote: > > > bnbarham wrote: > > > > akyrtzi

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM, let's land asap! Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:65-71 +// Compares AST nodes by source locations. +template struct CompareNode { +

[PATCH] D145994: WIP

nickdesaulniers updated this revision to Diff 504867. nickdesaulniers added a comment. - redrop hunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145994/new/ https://reviews.llvm.org/D145994 Files:

[PATCH] D145994: WIP

nickdesaulniers updated this revision to Diff 504866. nickdesaulniers added a comment. - drop hunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145994/new/ https://reviews.llvm.org/D145994 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bnbarham wrote: > bolshakov-a wrote: > > bnbarham wrote: > > > akyrtzi wrote: > > > >

[PATCH] D145994: WIP

nickdesaulniers updated this revision to Diff 504865. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - add link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145994/new/ https://reviews.llvm.org/D145994

[PATCH] D145994: WIP

nickdesaulniers created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Rather than have a "srcloc" associated with each

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1073 : FixItList{}); for (const auto : WarningGadgets) { Handler.handleUnsafeOperation(G->getBaseStmt(), /*IsRelatedToDecl=*/true);

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, malavikasamak, t-rasmud, xazax.hun, ymandel, gribozavr, aaron.ballman. Herald added subscribers: mgrang, rnkovacs. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

abidh accepted this revision. abidh added a comment. The BareMetal.cpp part looks ok to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 ___ cfe-commits

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bolshakov-a wrote: > bnbarham wrote: > > akyrtzi wrote: > > > erichkeane wrote: > > > >

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

scott.linder added a comment. Is there a corresponding document update to go along with this? If consumers of the bundles will begin to rely on this it should be documented that it is guaranteed by the producer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. Hi Yonghong, Left a few nitpicks and one comment in `BPFMIPreEmitPeephole::adjustBranch()` that I think points to a bug. Overall `adjustBranch()` algorithm looks good. It would be great to have some test cases for it, e.g. preprocess test .ll by replacing some template

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. Please wait for and OK from @jrtc27. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:112-114 + case llvm::Triple::riscv64: +getTargetFeatures(D, Triple, Args, CmdArgs, /*ForAs*/ false); +

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski added inline comments. Comment at: flang/test/Driver/target-cpu-features-invalid.f90:13 +! CHECK-INVALID-CPU: 'supercpu' is not a recognized processor for this target (ignoring processor) +! CHECK-INVALID-FEATURE: '+superspeed' is not a recognized feature for this

[PATCH] D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a733e8a2c58: [clang][driver] accept maix32/maix64 gcc compat options (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 9a733e8 - [clang][driver] accept maix32/maix64 gcc compat options

Author: David Tenty Date: 2023-03-13T17:05:52-04:00 New Revision: 9a733e8a2c58957591e4dc0a02f9cfa6a06603de URL: https://github.com/llvm/llvm-project/commit/9a733e8a2c58957591e4dc0a02f9cfa6a06603de DIFF: https://github.com/llvm/llvm-project/commit/9a733e8a2c58957591e4dc0a02f9cfa6a06603de.diff

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bnbarham wrote: > akyrtzi wrote: > > erichkeane wrote: > > > bolshakov-a wrote: > > > >

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; akyrtzi wrote: > erichkeane wrote: > > bolshakov-a wrote: > > > aaron.ballman wrote: > > > > Any

[PATCH] D145987: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

kuhar updated this revision to Diff 504837. kuhar added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also include clang/ since there's only one function to update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. Recent update was to simplify the omp-frontend-forwarding.f90 test Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1 +! REQUIRES: amdgpu-registered-target + awarzynski wrote: > Given that you use `-###`, I think that this

[PATCH] D145435: Choose style (file) from within code for use in IDEs

owenpan added a comment. In D145435#4187575 , @bersbersbers wrote: > In D145435#4179662 , @owenpan wrote: > >> Are the settings above hypothetical or are they real-world use cases? > > Real-world - actually, all

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon updated this revision to Diff 504829. agozillon added a comment. - [Flang][Driver] Simplify omp-frontend-forwarding.f90 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/ https://reviews.llvm.org/D145815 Files:

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

akyrtzi added a subscriber: bnbarham. akyrtzi added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; erichkeane wrote: > bolshakov-a wrote: > > aaron.ballman

[clang] debe80c - Revert "[memprof] Record BuildIDs in the raw profile."

Author: Snehasish Kumar Date: 2023-03-13T20:09:46Z New Revision: debe80cb8d50275849d8d0b9357321eb7985b854 URL: https://github.com/llvm/llvm-project/commit/debe80cb8d50275849d8d0b9357321eb7985b854 DIFF: https://github.com/llvm/llvm-project/commit/debe80cb8d50275849d8d0b9357321eb7985b854.diff

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

jrtc27 added inline comments. Comment at: flang/test/Driver/target-cpu-features-invalid.f90:13 +! CHECK-INVALID-CPU: 'supercpu' is not a recognized processor for this target (ignoring processor) +! CHECK-INVALID-FEATURE: '+superspeed' is not a recognized feature for this

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks for contributing! Please wait for the other reviewers to confirm that they are happy with these changes. Comment at:

[PATCH] D145941: [Clang] Always use -zdefs when linking AMDGPU images

jhuber6 updated this revision to Diff 504818. jhuber6 added a comment. Use `--no-undefined` to be consistent with HIP and check for OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145941/new/ https://reviews.llvm.org/D145941 Files:

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:7 +! RUN: %flang_fc1 -triple riscv64-unknown-linux-gnu \ +! RUN: -target-feature +d -target-feature +c -emit-obj %s -o %t.o +! RUN: llvm-readelf -h %t.o | FileCheck %s awarzynski

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

aaron.ballman added a comment. Thank you, I think this is heading in the right direction! Can you also add a release note to `clang/docs/ReleaseNotes.rst` about the fix? Comment at: clang/lib/Analysis/ReachableCode.cpp:633-635 + const AttributedStmt *AS = dyn_cast(S); +

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG287177a47a39: [memprof] Record BuildIDs in the raw profile. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/

[clang] 287177a - [memprof] Record BuildIDs in the raw profile.

Author: Snehasish Kumar Date: 2023-03-13T19:28:38Z New Revision: 287177a47a396ca6cc0bef7696108cdaa0c68e5f URL: https://github.com/llvm/llvm-project/commit/287177a47a396ca6cc0bef7696108cdaa0c68e5f DIFF: https://github.com/llvm/llvm-project/commit/287177a47a396ca6cc0bef7696108cdaa0c68e5f.diff

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

aaron.ballman added a comment. It looks like there's still relevant precommit CI failures: `clang-tidy/checkers/readability/identifier-naming-case-violation.cpp` looked related to this patch. Comment at: clang/lib/Lex/PPDirectives.cpp:3189-3192 +if ((MI->isBuiltinMacro()

[PATCH] D145974: [libclang] Add index option to store preambles in memory

vedgy added a comment. I have implemented the setter for the new option locally and tested it in KDevelop. void clang_CXIndex_setStorePreamblesInMemory(CXIndex CIdx, int storePreamblesInMemory) { if (CIdx)

[PATCH] D144611: [PowerPC] Adding test coverage for vector compatibility warning

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. thx for the added coverage. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144611/new/ https://reviews.llvm.org/D144611

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

efriedma added a comment. In D145726#4190341 , @garvitgupta08 wrote: > In D145726#4190316 , > @nickdesaulniers wrote: > >> Isn't this only an issue with ancient versions of GNU as? Older than 2.16? > > I am

[PATCH] D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145506/new/ https://reviews.llvm.org/D145506

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added a comment. Just created the follow-up `StorePreamblesInMemory` revision: D145974 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143418/new/ https://reviews.llvm.org/D143418

[PATCH] D145974: [libclang] Add index option to store preambles in memory

vedgy created this revision. Herald added a subscriber: arphaman. Herald added a project: All. vedgy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit allows libclang API users to opt into storing PCH in memory instead of

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added a comment. In D145726#4190341 , @garvitgupta08 wrote: > In D145726#4190316 , > @nickdesaulniers wrote: > >> Isn't this only an issue with ancient versions of GNU as? Older than 2.16? > > I

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. In D145726#4190316 , @nickdesaulniers wrote: > Isn't this only an issue with ancient versions of GNU as? Older than 2.16? I am able to reproduce this issue with 4.9.0 GNU as. Repository: rG LLVM Github Monorepo

[PATCH] D145951: [docs] Add more complete documentation for -f[no]split-lto-unit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb3b392264a0: [docs] Add more complete documentation for -f[no]split-lto-unit (authored by tejohnson). Repository: rG LLVM Github Monorepo

  1   2   3   4   >