[PATCH] D147422: [clang-format] NFC Document the other space before colon option

owenpan added a comment. In D147422#4242115 , @sstwcw wrote: > It looks like a line break gets inserted in arrays. Does that mean the > option doesn't affect arrays? It matters only if `BreakArrays` is set to false. Repository: rG LLVM Github

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

owenpan added a comment. In D147422#4240024 , @MyDeveloperDay wrote: > In D147422#4240021 , @owenpan wrote: > >> Should we extend `SpacesInContainerLiterals` so that it controls JSON colons >> too? If yes, then

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2211 + std::optional> ValuePrintingTransformer; + Instead of doing this, we could implement an ASTConsumer which the Interpreter can attach to Sema and listen for

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `()[any]`

emgullufsen added a comment. Just a heads up it seems like a lot of premerge checks builds are now showing this test as failing on Windows x64: Failed Tests (1): Clang :: SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp Here are some links from

[PATCH] D147525: [X86] Add AMX_COMPLEX to Graniterapids

xiangzhangllvm accepted this revision. xiangzhangllvm added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147525/new/ https://reviews.llvm.org/D147525 ___ cfe-commits mailing list

[PATCH] D147551: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion

ccotter accepted this revision. ccotter added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147551/new/ https://reviews.llvm.org/D147551

[clang] e5144d9 - Fix a few clang-tidy warnings (container empty checks, function decl/def param naming)

Author: David Blaikie Date: 2023-04-05T01:06:41Z New Revision: e5144d9d2dd26a67f576d2f5772b3cf0486245f4 URL: https://github.com/llvm/llvm-project/commit/e5144d9d2dd26a67f576d2f5772b3cf0486245f4 DIFF: https://github.com/llvm/llvm-project/commit/e5144d9d2dd26a67f576d2f5772b3cf0486245f4.diff

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

hubert.reinterpretcast added a comment. In D146399#4244479 , @francii wrote: > Do we need a test case for the diagnostic? If we are only supporting one > target, which triple would be used for the test? I think we do need a test case for the

[PATCH] D147579: [nvptx-arch] Dynamically load `libcuda.so.1` directly instead

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad6a7d7dc9a2: [nvptx-arch] Dynamically load `libcuda.so.1` directly instead (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[clang] ad6a7d7 - [nvptx-arch] Dynamically load `libcuda.so.1` directly instead

Author: Joseph Huber Date: 2023-04-04T19:50:31-05:00 New Revision: ad6a7d7dc9a2055ac3a4658d90ec86d78c3199b5 URL: https://github.com/llvm/llvm-project/commit/ad6a7d7dc9a2055ac3a4658d90ec86d78c3199b5 DIFF: https://github.com/llvm/llvm-project/commit/ad6a7d7dc9a2055ac3a4658d90ec86d78c3199b5.diff

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 510976. python3kgae added a comment. skip warning on field for compound assignment when isImplicitCXXThis matches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

rjmccall added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2118 + if (Packed) +UnadjustedAlignment = std::max(UnadjustedAlignment, UnpackedFieldAlign); UpdateAlignment(FieldAlign, UnpackedFieldAlign, PreferredAlign); I've always

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings added a comment. It looks like the failing tests already go to some effort to set each of TMP, TEMP & TMPDIR so perhaps they should be simplified to just set CLANG_CRASH_DIAGNOSTICS_DIR instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147580: [Clang] Refactor "Designators" to be more similar [NFC]

void created this revision. void added reviewers: aaron.ballman, rjmccall, rsmith, dblaikie, shafik. Herald added a subscriber: martong. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes the two

[PATCH] D147579: [nvptx-arch] Dynamically load `libcuda.so.1` directly instead

jhuber6 created this revision. jhuber6 added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. This patch

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. Hi. I think this led to some test failures on our builder at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview: Script: -- : 'RUN: at line 4'; rm -rf

[PATCH] D144304: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp:19 bool a = (bool) [5]; - // CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:19-[[@LINE-1]]:24}:"(p.data() +

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147577/new/ https://reviews.llvm.org/D147577

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

benhamilton created this revision. benhamilton added reviewers: sammccall, MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. benhamilton requested review of this revision. Apple

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 510943. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_team_variable_codegen.cpp

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:303 +if (GV->hasInitializer() && !(isa(GV->getInitializer()) || + isa(GV->getInitializer( { OutContext.reportError({}, arsenm

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:303 +if (GV->hasInitializer() && !(isa(GV->getInitializer()) || + isa(GV->getInitializer( { OutContext.reportError({}, Isa

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

This revision was automatically updated to reflect the committed changes. Closed by commit rG029212617ca8: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0292126 - [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

Author: Francesco Petrogalli Date: 2023-04-05T00:08:14+02:00 New Revision: 029212617ca8bdedd949d17bf2d33750605ea607 URL: https://github.com/llvm/llvm-project/commit/029212617ca8bdedd949d17bf2d33750605ea607 DIFF:

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 510938. zequanwu added a comment. Split to another patch: D147569 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files:

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 marked an inline comment as done. doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3355 +llvm::GlobalValue::InternalLinkage, +CGM.getTriple().isAMDGCN() ? llvm::UndefValue::get(VarTy) +

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 510934. Herald added subscribers: llvm-commits, kosarev, foad, kerbowa, hiraditya, jvesely, arsenm. Herald added a project: LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ updated this revision to Diff 510933. NoQ added a comment. - Rebase! (I'll update related revisions soon but not immediately, need to make sense out of them first.) - Eliminate the `EmitFixits` mode as discussed above. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146669/new/

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii added a comment. In D146399#4243803 , @hubert.reinterpretcast wrote: > @francii, what happens when `-K` is used on a pure-compile (`-c`) invocation? > Do we get an "unused" message? Should we be testing that? > I think we should be testing the

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

wolfgangp added a comment. > @probinson Sounds like Sony's solution also changes the `DW_AT_type` to a > non-canonical form. Do you still have concerns with the direction of this > patch? Would it cause any problems for you downstream? Sorry for the late reply. Looking at the patch I don't

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. Looks useful, and matches the behaviour I would have expected anyway. The buildkite libcxx tests already rely on being able to pass this variable through, so the same seems

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3355 +llvm::GlobalValue::InternalLinkage, +CGM.getTriple().isAMDGCN() ? llvm::UndefValue::get(VarTy) + : llvm::Constant::getNullValue(VarTy),

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 created this revision. doru1004 added reviewers: ronl, carlo.bertolli, jhuber6, jdoerfert, dhruvachak, gregrodgers. doru1004 added a project: OpenMP. Herald added subscribers: sunshaoce, nlopes, guansong, arichardson, yaxunl. Herald added a project: All. doru1004 requested review of this

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

PiotrZSL added a comment. " clang-tidy already warns with bugprone-exception-escape on the destructor of Evil even when it is marked noexcept(false)" https://reviews.llvm.org/D145865 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

zequanwu updated this revision to Diff 510918. zequanwu added a comment. Add the crash repro as test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147569/new/ https://reviews.llvm.org/D147569 Files:

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

zequanwu created this revision. zequanwu added reviewers: aaron.ballman, gulfem, hans. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a split of D147073 .

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 510909. Krishna-13-cyber added a comment. - Updated with release note - I had tried adding more text to the `expected-error` but it already gives a diagnostic of `static assertion failed due to requirement` currently. If I try additions to

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `()[any]`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87b5807d3802: [-Wunsafe-buffer-usage] Fix-Its transforming `DRE[any]` to `DRE.data()[any]` (authored by ziqingluo-90). Changed prior to commit:

[clang] 87b5807 - [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `()[any]`

Author: ziqingluo-90 Date: 2023-04-04T13:26:45-07:00 New Revision: 87b5807d3802b932c06d83c4287014872aa2caab URL: https://github.com/llvm/llvm-project/commit/87b5807d3802b932c06d83c4287014872aa2caab DIFF: https://github.com/llvm/llvm-project/commit/87b5807d3802b932c06d83c4287014872aa2caab.diff

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions +

[PATCH] D144304: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp:19 bool a = (bool) [5]; - // CHECK:

[PATCH] D147564: [clang] Mark CWG536 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG536 (long partially resolved) is resolved by

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15656 case BO_XorAssign: -DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); CheckIdentityFieldAssignment(LHS, RHS, OpLoc, S); break; python3kgae wrote: > rsmith wrote: > >

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 marked 2 inline comments as done. jp4a50 added a comment. In D146042#4239182 , @owenpan wrote: > In D146042#4204651 , @jp4a50 wrote: > >> I'm confident that the patch will indent all those examples

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147531/new/ https://reviews.llvm.org/D147531 ___

[PATCH] D147563: [clang-tidy] Deprecate cert-dcl21-cpp

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. I think will be good idea to track deprecated features on GitHub issues with something like `deprecate in XYZ` label(s). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 updated this revision to Diff 510901. jp4a50 added a comment. Tidy up docs and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D147563: [clang-tidy] Deprecate cert-dcl21-cpp

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It is no longer

[PATCH] D147561: [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

keith accepted this revision. keith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Modules/module-file-home-is-cwd.m:7-8 // RUN: -o %t/mod.pcm // RUN: llvm-bcanalyzer --dump --disable-histogram %t/mod.pcm | FileCheck %s +//

[PATCH] D147561: [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a bug in the MODULE_DIRECTORY serialization logic that would cause MODULE_DIRECTORY to be serialized when

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 510887. philnik added a comment. Remove formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/LanguageExtensions.rst

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak owenpan wrote: > HazardyKnusperkeks wrote: > > jp4a50 wrote: > > >

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 510886. jp4a50 added a comment. Minor review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D147556: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 abandoned this revision. jp4a50 added a comment. Sorry - this is a duplicate of https://reviews.llvm.org/D146101 created by accident. Closing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147556/new/ https://reviews.llvm.org/D147556

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510885. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

SimeonEhrig added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:135 +std::move(CI), std::move(DeviceCI), OffloadArch, +"/tmp/clang-repl.fatbin")); + v.g.vassilev wrote: > To cover the case where platforms have no `/tmp` we

[PATCH] D147556: [clang-format] Add BracedInitializerIndentWidth option.

HazardyKnusperkeks added a comment. Um, was this a mistake? What is with D146101 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147556/new/ https://reviews.llvm.org/D147556

[PATCH] D147556: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jp4a50 requested review of this revision. The option allows users to specify how many columns to use

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15656 case BO_XorAssign: -DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); CheckIdentityFieldAssignment(LHS, RHS, OpLoc, S); break; rsmith wrote: > This is the same

[PATCH] D147530: [clang] Add test for CWG191

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147530/new/ https://reviews.llvm.org/D147530

[PATCH] D147554: [clang] Mark CWG562 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG562 is resolved by defining lookup as

[PATCH] D147551: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Adds support for

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 510865. philnik marked 5 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files:

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4240572 , @aaron.ballman wrote: > Hmmm, is this effectively `std::has_unique_object_representations` (ensuring > that all bits of the object representation contribute to the value)? These two traits are indeed very

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:137 + +ExitOnErr(Interp->LoadDynamicLibrary("libcudart.so")); + } else tra wrote: > v.g.vassilev wrote: > > tra wrote: > > > Is there any doc describing the big picture

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

tra added a comment. > Initial interactive CUDA support for clang-repl What should a user expect to be supported, functionality wise? I assume it should cover parsing and compilation. I'm not so sure about the execution. Should it be expected to actually launch kernels, or will that come in a

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15656 case BO_XorAssign: -DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); CheckIdentityFieldAssignment(LHS, RHS, OpLoc, S); break; This is the same thing, but for `this->x

[PATCH] D147549: [clang] Add test for CWG255

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG255 (partially resolved by N3778 is resolved

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a subscriber: SimeonEhrig. v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:137 + +ExitOnErr(Interp->LoadDynamicLibrary("libcudart.so")); + } else tra wrote: > Is there any doc describing the big

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

tra added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:27 +static llvm::cl::opt CudaEnabled("cuda", llvm::cl::Hidden); +static llvm::cl::opt OffloadArch("offload-arch", llvm::cl::Hidden); + Where will clang-repl find CUDA headers? Generally

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#4243260 , @jhuber6 wrote: > Fixed the Clang tests. Haven't touched the LLVM ones because this breaks > SPMDzation and state machine rewrites completely in those tests. Someone who > knows what this patch changes

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

hubert.reinterpretcast added a comment. @francii, what happens when `-K` is used on a pure-compile (`-c`) invocation? Do we get an "unused" message? Should we be testing that? I think we should be testing the diagnostic for the "wrong target" usage as well? Repository: rG LLVM Github

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 510848. krzysz00 added a comment. Rebase data layout changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D146759: [ExtractAPI] Remove extra attributes in property declaration fragments

This revision was automatically updated to reflect the committed changes. Closed by commit rG32b53cf9d0c8: [ExtractAPI] Remove extra attributes in property declaration fragments (authored by Unique_Usman, committed by zixuw). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 32b53cf - [ExtractAPI] Remove extra attributes in property declaration fragments

Author: Usman Akinyemi Date: 2023-04-04T10:00:34-07:00 New Revision: 32b53cf9d0c8c0e01ce5b0e7d5c717202a98cdf5 URL: https://github.com/llvm/llvm-project/commit/32b53cf9d0c8c0e01ce5b0e7d5c717202a98cdf5 DIFF:

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15186 + // different handling. + ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); + cor3ntin wrote: > shafik wrote: > >

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon updated this revision to Diff 510843. Fznamznon added a comment. Fix grammar, add checks to the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147531/new/ https://reviews.llvm.org/D147531 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15186 + // different handling. + ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); + shafik wrote: > I am a bit concerned that we are updating

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

shafik added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15186 + // different handling. + ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); + I am a bit concerned that we are updating `InImmediateFunctionContext` outside of

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:273-274 - Fix incorrect merging of lambdas across modules. (`#60985 `_) +- Fix assertion hit when template consteval function appears in nested +

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Thanks for working on this! Comment at: clang/lib/Interpreter/Offload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// How about `DeviceOffload.cpp`? Comment at:

[PATCH] D147497: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0109f8d1e3bf: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of… (authored by craig.topper). Repository: rG LLVM Github Monorepo

[clang] 0109f8d - [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

Author: Craig Topper Date: 2023-04-04T09:01:24-07:00 New Revision: 0109f8d1e3bf64e4b23db6e2f284185207e46541 URL: https://github.com/llvm/llvm-project/commit/0109f8d1e3bf64e4b23db6e2f284185207e46541 DIFF: https://github.com/llvm/llvm-project/commit/0109f8d1e3bf64e4b23db6e2f284185207e46541.diff

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:288 + } + for (auto : LazySpecializations) { +Record.push_back(SpecInfo.DeclID); We should not store the lazy specialization information as an array of

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

ChuanqiXu added a reviewer: ChuanqiXu. ChuanqiXu added a comment. Add me as a reviewer to add this to my stack. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41416/new/ https://reviews.llvm.org/D41416 ___ cfe-commits mailing list

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 510816. balazske marked 3 inline comments as done. balazske added a comment. I decided to add back `DescriptionKind` and make possible to use a message like "should not be NULL". Now all generated strings in functions `describe` and `describeArgumentValue`

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299 + + Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func); } kzhuravl wrote: > Do we really need/want to update code object v2? as long as the code is here

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

kzhuravl added a comment. Overall looks good. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299 + + Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func); } Do we really need/want to update code object v2? CHANGES SINCE LAST ACTION

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I reworked the comment a bit otherwise LGTM. Comment at: clang/lib/Sema/SemaDecl.cpp:15178-15185 + // Each ExpressionEvaluationContextRecord also keeps track on whether

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ec36e6956cb: [clang][modules] Handle explicit modules when checking for .Private - _Private (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8ec36e6 - [clang][modules] Handle explicit modules when checking for .Private -> _Private

Author: Ben Langmuir Date: 2023-04-04T08:12:10-07:00 New Revision: 8ec36e6956cb03d80f3fee8e593808c43a8a1ec3 URL: https://github.com/llvm/llvm-project/commit/8ec36e6956cb03d80f3fee8e593808c43a8a1ec3 DIFF: https://github.com/llvm/llvm-project/commit/8ec36e6956cb03d80f3fee8e593808c43a8a1ec3.diff

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite created this revision. Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. argentite updated this revision to Diff 507049. argentite added a comment. argentite updated this revision to Diff 510808. argentite edited the summary of this revision. argentite

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15177 : ExprEvalContexts.back().Context); +ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); cor3ntin wrote: > I think it might be

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon updated this revision to Diff 510807. Fznamznon added a comment. Add a comment, rebase, fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147531/new/ https://reviews.llvm.org/D147531 Files: clang/docs/ReleaseNotes.rst

[clang] 74cc438 - [clang-format] Add option for having one port per line in Verilog

Author: sstwcw Date: 2023-04-04T14:51:22Z New Revision: 74cc4389f37d753bf07f1b4a4a4c5e09433d9231 URL: https://github.com/llvm/llvm-project/commit/74cc4389f37d753bf07f1b4a4a4c5e09433d9231 DIFF: https://github.com/llvm/llvm-project/commit/74cc4389f37d753bf07f1b4a4a4c5e09433d9231.diff LOG:

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74cc4389f37d: [clang-format] Add option for having one port per line in Verilog (authored by sstwcw). Repository: rG LLVM Github Monorepo

[PATCH] D147535: [clang][Interp] Don't create global variables more than once

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. just because we're being told to evaluate it

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise, we run into an assertion when trying

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 updated this revision to Diff 510797. jhuber6 added a comment. Herald added subscribers: kbarton, nemanjai. Fixed the Clang tests. Haven't touched the LLVM ones because this breaks SPMDzation and state machine rewrites completely in those tests. Someone who knows what this patch changes

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

cor3ntin added a comment. Thanks, for working on this Congrats on finding the underlying issue, it must not have been easy! Comment at: clang/lib/Sema/SemaDecl.cpp:15177 : ExprEvalContexts.back().Context); +

  1   2   >