[PATCH] D147909: [clang] Implement CWG 2397

zyounan added a comment. Thank you for the suggestion and I've updated my patch. :) Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.array/cwg2397.cpp:11 +} + +void g() { aaron.ballman wrote: > I think it'd be good to also show a constexpr test, like: > ```

[PATCH] D147909: [clang] Implement CWG 2397

zyounan updated this revision to Diff 512656. zyounan marked an inline comment as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147909/new/ https://reviews.llvm.org/D147909 Files:

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat updated this revision to Diff 512655. 4vtomat added a comment. Resolved Kito's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

kito-cheng added a comment. You need to update `llvm/docs/RISCVUsage.rst` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 ___ cfe-commits mailing list

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4236 + +// Use the -march=help flag as the dummy input to cc1. +Actions.clear(); craig.topper wrote: > MaskRay wrote: > > Why is the code needed? Can --print-supported-extensions

[PATCH] D147935: [RISCV] Add SiFive extension support

craig.topper added a comment. Is there a different patch with the .td for these intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 ___ cfe-commits

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 ___ cfe-commits mailing list

[PATCH] D147867: [Windows SEH] Fix ehcleanup crash for Windows -EHa

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/windows-seh-EHa-CppCatchReturn.cpp:27 + +// FIXME: We may need to generate llvm.seh.scope.end or remove llvm.seh.scope.begin. +void

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2262 + /// Return true if the given vector types are lax-compatible RVV vector types, + /// false otherwise. + bool areLaxCompatibleRVVTypes(QualType FirstType, QualType SecondType);

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88f7f018e23b: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or… (authored by ziqingluo-90). Changed prior to commit:

[clang] 88f7f01 - [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

Author: Ziqing Luo Date: 2023-04-11T15:09:51-07:00 New Revision: 88f7f018e23b24d3c31dd2b4f3cd68481d1739c1 URL: https://github.com/llvm/llvm-project/commit/88f7f018e23b24d3c31dd2b4f3cd68481d1739c1 DIFF: https://github.com/llvm/llvm-project/commit/88f7f018e23b24d3c31dd2b4f3cd68481d1739c1.diff

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added a comment. What if we attached the domain as a separate RISC-V specific metadata and didn't change the nontemporal format? If optimizations drop the RISC-V specific part it would still be nontemporal, but get the default domain? Repository: rG LLVM Github Monorepo

[PATCH] D148024: [clang-format] Don't modify template arguments on the LHS of assignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dc94b3356bd: [clang-format] Dont modify template arguments on the LHS of assignment (authored by rymiel). Repository: rG LLVM Github Monorepo

[clang] 5dc94b3 - [clang-format] Don't modify template arguments on the LHS of assignment

Author: Emilia Dreamer Date: 2023-04-12T00:33:17+03:00 New Revision: 5dc94b3356bd861d304e1ab61f7bb9ef33bf46b3 URL: https://github.com/llvm/llvm-project/commit/5dc94b3356bd861d304e1ab61f7bb9ef33bf46b3 DIFF:

[clang] 8af5756 - Revert (4) "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-11T22:25:16+01:00 New Revision: 8af575657b1dc1113640286b3649842c2473c2cf URL: https://github.com/llvm/llvm-project/commit/8af575657b1dc1113640286b3649842c2473c2cf DIFF: https://github.com/llvm/llvm-project/commit/8af575657b1dc1113640286b3649842c2473c2cf.diff LOG:

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4258856 , @erichkeane wrote: > So I don't see any handling of the dependent version of this, we probably > need tests for those at minimum. Does SVE handle the dependent version? Repository: rG LLVM Github

[PATCH] D147969: Add InsertBraces to ChromiumStyle

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) owenpan wrote: > aaron.ballman wrote: > >

[PATCH] D147263: Fix an assertion failure in unwrapSugar

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147263/new/ https://reviews.llvm.org/D147263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added a comment. In D145088#4259209 , @craig.topper wrote: > In D145088#4259197 , @erichkeane > wrote: > >> has this had an RFC btw? I don't believe I've seen one, and this looks like >> we

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4259197 , @erichkeane wrote: > has this had an RFC btw? I don't believe I've seen one, and this looks like > we probably need one. It has not had an RFC. It's almost a direct copy of AArch64's implementation,

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:11390 +ResType = llvm::ScalableVectorType::get( +llvm::Type::getIntNTy(getVMContext(), XLen), 64 / XLen); +break; erichkeane wrote: > craig.topper wrote: > > erichkeane

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added a comment. has this had an RFC btw? I don't believe I've seen one, and this looks like we probably need one. Comment at: clang/include/clang/AST/ASTContext.h:2262 + /// Return true if the given vector types are lax-compatible RVV vector types, + /// false

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2262 + /// Return true if the given vector types are lax-compatible RVV vector types, + /// false otherwise. + bool areLaxCompatibleRVVTypes(QualType FirstType, QualType SecondType);

[PATCH] D147969: Add InsertBraces to ChromiumStyle

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) aaron.ballman wrote: > HazardyKnusperkeks wrote: > >

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Sorry, we cannot do this. See https://reviews.llvm.org/D147983#4259132 I added --[no-]relax-gp to GNU ld master branch recently, which isn't in a released binutils version yet.

[clang] a0525f0 - Reapply (3) "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-11T21:15:03+01:00 New Revision: a0525f09ac1eda3fbb74e8708b3aa5b7379df0c2 URL: https://github.com/llvm/llvm-project/commit/a0525f09ac1eda3fbb74e8708b3aa5b7379df0c2 DIFF: https://github.com/llvm/llvm-project/commit/a0525f09ac1eda3fbb74e8708b3aa5b7379df0c2.diff LOG:

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Fix pointers, Add more tests, consider free standing value extraction functions like boost::get Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 512559. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Add fixes, add suport for std:move, fixed operator*() calls, added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon updated this revision to Diff 512554. agozillon added a comment. Adding missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148038/new/ https://reviews.llvm.org/D148038 Files: clang/include/clang/Driver/Options.td

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes seem reasonable to me. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() <

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon created this revision. Herald added subscribers: bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D147969: Add InsertBraces to ChromiumStyle

aaron.ballman added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) HazardyKnusperkeks wrote: > MyDeveloperDay

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG32aaacc609e7: [clang-tidy] support nested inline namespace in c++20 for modernize-concat… (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 32aaacc - [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

Author: Congcong Cai Date: 2023-04-11T21:28:11+02:00 New Revision: 32aaacc609e7a0523d498b244e081ac6f3df532b URL: https://github.com/llvm/llvm-project/commit/32aaacc609e7a0523d498b244e081ac6f3df532b DIFF: https://github.com/llvm/llvm-project/commit/32aaacc609e7a0523d498b244e081ac6f3df532b.diff

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() < 6 || Text[0] != '/') + return false; aaron.ballman wrote: > Just to double-check, we don't have to

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added a comment. Code like `llvm::combineMetadataForCSE` assumes that the !nontemporal metadata can be copied from one node if both nodes have it. If the 2 nodes have different values we need a rule of which one to pick. We can't just pick arbitrarily. Repository: rG LLVM

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() < 6 || Text[0] != '/') + return false; Just to double-check, we don't have to worry about there

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:844 "};"); - ASSERT_EQ(Tokens.size(), 44u); + ASSERT_EQ(Tokens.size(), 44u) << Tokens; EXPECT_TOKEN(Tokens[13], tok::kw_requires, TT_RequiresClause);

[PATCH] D147969: Add InsertBraces to ChromiumStyle

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) MyDeveloperDay wrote: > This is an code

[PATCH] D148035: [clang] Add test for CWG1837

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7aedd8ea3f: [clang] Add test for CWG1837 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] aa7aedd - [clang] Add test for CWG1837

Author: Vlad Serebrennikov Date: 2023-04-11T22:15:11+03:00 New Revision: aa7aedd8ea3f75ddfb3004b81f09c5f653bc8fec URL: https://github.com/llvm/llvm-project/commit/aa7aedd8ea3f75ddfb3004b81f09c5f653bc8fec DIFF:

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4258664 , @zequanwu wrote: > In D147073#4258529 , @aaron.ballman > wrote: > >> In D147073#4258426 , @zequanwu >> wrote: >> >>>

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:19975 +llvm::Type *ResTy = ConvertType(E->getType()); +ConstantInt *Mode = llvm::cast(Ops[1]); + Is `llvm::` needed on the `cast`? I think cast is imported into the clang

[PATCH] D147839: [clang] Add test for CWG2007

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4beecef8f40: [clang] Add test for CWG2007 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a4beece - [clang] Add test for CWG2007

Author: Vlad Serebrennikov Date: 2023-04-11T22:13:43+03:00 New Revision: a4beecef8f40ad0d42f61e7c495acb2d2d819b10 URL: https://github.com/llvm/llvm-project/commit/a4beecef8f40ad0d42f61e7c495acb2d2d819b10 DIFF:

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512543. Endill added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147839/new/ https://reviews.llvm.org/D147839 Files: clang/test/CXX/drs/dr20xx.cpp clang/www/cxx_dr_status.html Index:

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512541. HerrCai0907 added a comment. update acc. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files:

[PATCH] D147848: [clang] Add test for CWG2370

This revision was automatically updated to reflect the committed changes. Closed by commit rGfeb93d28b02c: [clang] Add test for CWG2370 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147848/new/ https://reviews.llvm.org/D147848

[clang] feb93d2 - [clang] Add test for CWG2370

Author: Vlad Serebrennikov Date: 2023-04-11T22:04:02+03:00 New Revision: feb93d28b02c41ca6b069ec1f9e62fdfbb4c8b6c URL: https://github.com/llvm/llvm-project/commit/feb93d28b02c41ca6b069ec1f9e62fdfbb4c8b6c DIFF:

[PATCH] D148035: [clang] Add test for CWG1837

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems right based on the paper listed/standardeeze. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148035/new/

[PATCH] D148035: [clang] Add test for CWG1837

Endill updated this revision to Diff 512538. Endill added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148035/new/ https://reviews.llvm.org/D148035 Files: clang/test/CXX/drs/dr18xx.cpp clang/www/cxx_dr_status.html

[PATCH] D148035: [clang] Add test for CWG1837

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1837 is resolved by restricting this to

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4258419 , @zequanwu wrote: > In D147256#4257797 , @hans wrote: > >> In D147256#4249527 , @zequanwu >> wrote: >> >>> - Add a

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 512532. Leporacanthicus added a comment. Rebase only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

jrtc27 added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:51 // CHECK-NOT: __riscv_zcf {{.*$}} +// CHECK-NOT: __riscv_zcmp // CHECK-NOT: __riscv_h {{.*$}} Does this really belong in an MC patch? Comment at:

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin added a comment. In D148029#4258800 , @shafik wrote: > Do we have a test that covers valid doxygen comments? I was looking and I > don't see an obvious one. AFAICT, some in `CommentTextTest.cpp` - not that many though.

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added a comment. So I don't see any handling of the dependent version of this, we probably need tests for those at minimum. Comment at: clang/docs/ReleaseNotes.rst:355 +- Added ``attribute(riscv_rvv_vector_bits(__RISCV_RVV_VLEN_BITS))`` to allow + the size of a

[PATCH] D147920: [clang] Add test for CWG399

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test shafik wrote: > Endill wrote: > > Despite a couple of FIXME in CWG244 test (out of dozens of examples), it

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145088/new/ https://reviews.llvm.org/D145088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

paulkirth created this revision. paulkirth added reviewers: phosek, mcgrathr, jrtc27, craig.topper, aaron.ballman. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project:

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2404 break; +case RawComment::RCK_Invalid: + // FIXME: are there other scenarios that could produce an invalid I don't get why we don't have to handle the other `RawComment` cases

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL updated this revision to Diff 512529. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Introduce option IgnoreTemplateInstantiations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147924/new/

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik added a comment. Do we have a test that covers valid doxygen comments? I was looking and I don't see an obvious one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. In D147920#4258680 , @shafik wrote: > In D147920#4257369 , @Endill wrote: > >> I think I haven't stressed it enough, but this whole test is copied from >> dr244, which is written by

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite added inline comments. Comment at: clang/lib/Interpreter/Offload.cpp:90-91 + PTXCode += '\0'; + while (PTXCode.size() % 8) +PTXCode += '\0'; + return PTXCode.str(); Hahnfeld wrote: > Is padding to 8 bytes a requirement for PTX? Maybe add a

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 512521. argentite marked 3 inline comments as done. argentite added a comment. Combined IncrementalCompilerBuilder and IncrementalCudaCompilerBuilder Added --cuda-path support Use sys::fs::createTemporaryFile() instead of hardcoding the path Other minor

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

ahatanak added a comment. In D143813#4257943 , @jonpa wrote: > I don't understand the first argument - I thought it was supposed to be just > an address... It's a statement expression. https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html The value

[PATCH] D147986: [RISCV] Print a better error message when a rv32 CPU is used on rv64 and vice versa.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88d631198255: [RISCV] Print a better error message when a rv32 CPU is used on rv64 and vice… (authored by craig.topper). Repository: rG LLVM

[PATCH] D147978: [RISCV] Remove getCPUFeaturesExceptStdExt.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e2d8a352888: [RISCV] Remove getCPUFeaturesExceptStdExt. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147978/new/

[clang] 88d6311 - [RISCV] Print a better error message when a rv32 CPU is used on rv64 and vice versa.

Author: Craig Topper Date: 2023-04-11T10:41:50-07:00 New Revision: 88d6311982557acf2dd04ce101aca077ac311012 URL: https://github.com/llvm/llvm-project/commit/88d6311982557acf2dd04ce101aca077ac311012 DIFF: https://github.com/llvm/llvm-project/commit/88d6311982557acf2dd04ce101aca077ac311012.diff

[clang] 5e2d8a3 - [RISCV] Remove getCPUFeaturesExceptStdExt.

Author: Craig Topper Date: 2023-04-11T10:41:46-07:00 New Revision: 5e2d8a35288802f94df8c60513e7a835b27e621d URL: https://github.com/llvm/llvm-project/commit/5e2d8a35288802f94df8c60513e7a835b27e621d DIFF: https://github.com/llvm/llvm-project/commit/5e2d8a35288802f94df8c60513e7a835b27e621d.diff

[PATCH] D147660: [PS4][clang] Pass -flto-jobs argument to orbis-ld

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147660/new/ https://reviews.llvm.org/D147660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147660: [PS4][clang] Pass -flto-jobs argument to orbis-ld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393a1c3b4fcd: [PS4][clang] Pass -flto-jobs argument to orbis-ld (authored by ormris). Herald added a project: clang. Herald added a subscriber:

[clang] 393a1c3 - [PS4][clang] Pass -flto-jobs argument to orbis-ld

Author: Matthew Voss Date: 2023-04-11T10:33:16-07:00 New Revision: 393a1c3b4fcded56a1078d2c01c69af2f2ec05cf URL: https://github.com/llvm/llvm-project/commit/393a1c3b4fcded56a1078d2c01c69af2f2ec05cf DIFF: https://github.com/llvm/llvm-project/commit/393a1c3b4fcded56a1078d2c01c69af2f2ec05cf.diff

[PATCH] D147839: [clang] Add test for CWG2007

Endill added a comment. In D147839#4258681 , @shafik wrote: > In D147839#4257394 , @Endill wrote: > >> Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary >> template instantiation

[PATCH] D147839: [clang] Add test for CWG2007

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, thank you again for all the effort in documenting these and adding tests, it is much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147839: [clang] Add test for CWG2007

shafik added a comment. In D147839#4257394 , @Endill wrote: > Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary > template instantiation (presumably to find overloaded unary `&`), and make > Clang compliant since 3.4 Nice

[PATCH] D147920: [clang] Add test for CWG399

shafik added a comment. In D147920#4257369 , @Endill wrote: > I think I haven't stressed it enough, but this whole test is copied from > dr244, which is written by Richard. Understood, I appreciate the patience in explaining what I am missing.

[PATCH] D147920: [clang] Add test for CWG399

shafik added a subscriber: aaron.ballman. shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Endill wrote: > Despite a couple of FIXME in CWG244 test (out of

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258529 , @aaron.ballman wrote: > In D147073#4258426 , @zequanwu > wrote: > >> In D147073#4258396 , >> @aaron.ballman wrote: >>

[PATCH] D147848: [clang] Add test for CWG2370

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CXX/drs/dr23xx.cpp:182 + typedef N::type N_type; + // FIXME: `type` should be searched for in N + // friend void N::g(type);

[PATCH] D148031: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

paulkirth created this revision. paulkirth added reviewers: phosek, abrachet, dvyukov, vitalybuka, aaron.ballman. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, we can't check if

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin updated this revision to Diff 512505. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 Files: clang/docs/ReleaseNotes.rst

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

efriedma added a comment. I think the issue is that you're calling EmitPointerWithAlignment() on the argument, then calling EmitScalarExpr on the same argument. Essentially, emitting the argument twice. If emitting the argument has side-effects, that will cause an issue. Sorry, should have

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because the comment parser does not support slices, we emit a warning for comments that do contain a splice within their

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4258426 , @zequanwu wrote: > In D147073#4258396 , @aaron.ballman > wrote: > >> In D147073#4258384 , @hans wrote: >> >>> Again

[PATCH] D148024: [clang-format] Don't modify template arguments on the LHS of assignment

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. After clang-format has determined that an

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

SimeonEhrig added a comment. Except using an in-memory solution for generated fatbin code, the code looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512489. paulkirth marked 2 inline comments as done. paulkirth added a comment. Add spaces to parantheticals. Shorten link to discussion on psABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 512488. krzysz00 added a comment. Rebase, since we have addrspace 128 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258396 , @aaron.ballman wrote: > In D147073#4258384 , @hans wrote: > >> Again not an expert here, but lgtm. >> >> (Nit: the >>

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4257797 , @hans wrote: > In D147256#4249527 , @zequanwu > wrote: > >> - Add a `-use-target-path-separator` flag for llc. >> - Add test for llc with that flag. > > But where

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp:91 + ExceptionType, ExceptionReferenceType))); + auto BadAllocCatchingTryBlock

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4258384 , @hans wrote: > Again not an expert here, but lgtm. > > (Nit: the > https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaExprCXX.cpp#L1528-L1530 > link in the description seems to point to

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Again not an expert here, but lgtm. (Nit: the https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaExprCXX.cpp#L1528-L1530 link in the description seems to point to the wrong code

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub requested changes to this revision. kamaub added a comment. This revision now requires changes to proceed. Sorry I should have requested changes before for this comment below, but I do want these test moved to codegen and expanded, please let me know if anything is unclear. In

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp added a comment. > When the `.clang-tidy` file is checked into the source control(git). It means > that anyone who contributes to the project will need to ensure that they have > a version of clang-tidy that will be able to read the file. > This can cause problems as binaries of

  1   2   >