[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. https://github.com/llvm/llvm-project/issues/62110 (in addition to the self-friendship case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[PATCH] D147920: [clang] Add test for CWG399

shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Endill wrote: > shafik wrote: > > Endill wrote: > > > Despite a couple of

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. F27125556: a.tgz this is the original repro that crashed but maybe differently (you'll need to remove the plugin arguments since our clang has some custom plugins) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

owenpan added a comment. Herald added a reviewer: rymiel. @MyDeveloperDay We keep getting "spammed" by [libc++][format] patches. Can you delete the rule in H987 : "field": "differential.revision.title", "condition": "contains", "value": "[Format]" or change

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

MaskRay added a comment. Herald added subscribers: bviyer, ekilmer, jplehr, thopre. @Ericson2314 @phosek What's the state of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

MaskRay added a comment. Unfortunately we cannot do this. `LLVMSupport` depends on `LLVMDemangle`. Due to library layering `LLVMDemangle` cannot depend on `LLVMSupport`. The layering may look weird, but that's what we have. Using `std::string_view` may possibly be fine. Repository: rG LLVM

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 513024. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D147263: Fix an assertion failure in unwrapSugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ba88443b31a: Fix an assertion failure in unwrapSugar (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2ba8844 - Fix an assertion failure in unwrapSugar

Author: Akira Hatanaka Date: 2023-04-12T16:45:56-07:00 New Revision: 2ba88443b31a437a3e80ac4bb6d8ca1675828d1b URL: https://github.com/llvm/llvm-project/commit/2ba88443b31a437a3e80ac4bb6d8ca1675828d1b DIFF:

[PATCH] D140315: [AMDGCN] Update search path for device libraries

hvdijk added a comment. In D140315#4077611 , @scchan wrote: > In D140315#4076614 , @mgorny wrote: > >> I'm sorry for reporting it this late (clang's been broken for over two >> weeks, so we couldn't periodically

[PATCH] D147263: Fix an assertion failure in unwrapSugar

ahatanak updated this revision to Diff 513010. ahatanak marked an inline comment as done. ahatanak added a comment. Simplify test case and move it to clang/test/SemaCXX/sugar-common-types.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. I have opened a bug at issuetracker.google.com/issues/277967395 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 ___ cfe-commits

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Just a heads up, with this change, we are hitting issues in building gdb. Appreciate any ideas on what is wrong. aarch64-cros-linux-gnu-clang++ -x c++-I. -I. -I./config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I../bfd

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

sbc100 added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:29 -std::string llvm::demangle(const std::string ) { +std::string llvm::demangle(const StringRef MangledName) { std::string Result; Should `const` be removed? (i.e. is StringRef not

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added a comment. There's a few more callsites I'd like to clean up, tomorrow: - llvm/tools/llvm-objdump/llvm-objdump.cpp - llvm/tools/llvm-objdump/XCOFFDump.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148181/new/

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers created this revision. nickdesaulniers added reviewers: erichkeane, MaskRay. Herald added subscribers: pmatos, asb, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: jhenderson. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho.

[PATCH] D146987: [Assignment Tracking] Enable by default

rupprecht added a comment. In D146987#4263048 , @MaskRay wrote: > The latest reland 3820e9a2b29a2e268319ed6635da0d59e18d736d > still > caused some issues to our internal workloads.

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

rsandifo-arm updated this revision to Diff 512993. rsandifo-arm added a comment. Tweak initializer to avoid an MSVC error: https://godbolt.org/z/sMxsW8G8j Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/6]

barannikov88 updated this revision to Diff 512991. barannikov88 added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: w2yehia, qiongsiwu1, hubert.reinterpretcast. ZarkoCA added a project: PowerPC. Herald added subscribers: wlei, wenlei. Herald added a project: All. ZarkoCA requested review of this revision. Herald added subscribers: cfe-commits, MaskRay.

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik added a comment. @erichkeane let me know if the test I added is sufficient CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146329/new/ https://reviews.llvm.org/D146329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik updated this revision to Diff 512983. shafik added a comment. - Added codegen test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146329/new/ https://reviews.llvm.org/D146329 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

benlangmuir created this revision. benlangmuir added reviewers: akyrtzi, jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We only want to make PCH imports visible once for

[clang] efc8b52 - Revert D146987 "[Assignment Tracking] Enable by default"

Author: Fangrui Song Date: 2023-04-12T15:01:04-07:00 New Revision: efc8b52cbd942f4bd5ffe8f64da5fb8a3b7adc32 URL: https://github.com/llvm/llvm-project/commit/efc8b52cbd942f4bd5ffe8f64da5fb8a3b7adc32 DIFF: https://github.com/llvm/llvm-project/commit/efc8b52cbd942f4bd5ffe8f64da5fb8a3b7adc32.diff

[PATCH] D144304: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG762af11d4c5d: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment (authored by ziqingluo-90). Changed prior to commit:

[clang] 762af11 - [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

Author: Ziqing Luo Date: 2023-04-12T14:51:46-07:00 New Revision: 762af11d4c5d0bd1e76f23a07087773db09ef17d URL: https://github.com/llvm/llvm-project/commit/762af11d4c5d0bd1e76f23a07087773db09ef17d DIFF: https://github.com/llvm/llvm-project/commit/762af11d4c5d0bd1e76f23a07087773db09ef17d.diff

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. I'm seeing llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst &, unsigned int): Assertion `AssignmentTrackingEnabled && "expected assignment tracking to be enabled"' failed.

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4258031 , @aaron.ballman wrote: > Have you checked to see how the diagnostics work in practice on deep inlining > stacks? If it's usually only 1-2 extra notes, that's probably not going to > overwhelm

[PATCH] D146987: [Assignment Tracking] Enable by default

MaskRay added a comment. The latest reland 3820e9a2b29a2e268319ed6635da0d59e18d736d still caused some issues to our internal workloads. Stay tuned... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] aa1d269 - [CodeGen][RISCV] Change Shadow Call Stack Register to X3

Author: Paul Kirth Date: 2023-04-12T21:06:22Z New Revision: aa1d2693c25622ea4a8ee2b622ba2a617e18ef88 URL: https://github.com/llvm/llvm-project/commit/aa1d2693c25622ea4a8ee2b622ba2a617e18ef88 DIFF: https://github.com/llvm/llvm-project/commit/aa1d2693c25622ea4a8ee2b622ba2a617e18ef88.diff LOG:

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa1d2693c256: [CodeGen][RISCV] Change Shadow Call Stack Register to X3 (authored by paulkirth). Changed prior to commit: https://reviews.llvm.org/D146463?vs=512489=512972#toc Repository: rG LLVM

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 512971. zequanwu edited the summary of this revision. zequanwu added a comment. - Filed an github issue: - Added release note. - Updated commit message and summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

MaskRay added a comment. In D148034#4260376 , @asb wrote: > Will `--[no-]relax-gp` make its way into a minor gcc point release or do we > need to wait for the next major release? > > In terms of this breaking GNU users - isn't it the case that without

[PATCH] D145435: [clang-format] Choose style (file) from within code for use in IDEs

bersbersbers added a comment. Alright, thanks for your opinions. I will probably maintain this feature in a private working copy and continue to advertise it (compare, e.g., https://github.com/llvm/llvm-project/issues/60917 and https://stackoverflow.com/q/20540017), hoping to convince more

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:860 + + Diags.Report(diag::note_fe_backend_in) << llvm::demangle(D.getCaller().str()); + erichkeane wrote: > Could we

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

craig.topper added a comment. In D148034#4262938 , @jrtc27 wrote: > In D148034#4262934 , @craig.topper > wrote: > >> I'm not sure I want to suggest this, but could we disable the emission of >> the relocations

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

jrtc27 added a comment. In D148034#4262934 , @craig.topper wrote: > I'm not sure I want to suggest this, but could we disable the emission of the > relocations that can be GP relaxed? That would also lose the ability to do x0-relative and LUI -> C.LUI

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

craig.topper added a comment. I'm not sure I want to suggest this, but could we disable the emission of the relocations that can be GP relaxed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148034/new/ https://reviews.llvm.org/D148034

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed 1 blocking reviewer(s): eugenis. vitalybuka added a comment. This revision is now accepted and ready to land. Feel free to land. It works on my arm linux setup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147121/new/

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ?

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 512945. kpdev42 added a comment. Thanks for pointing out the bug @Michael137 . It seems that clang assigns arbitrary offsets for non_unique_address so analyzing them brings me nowhere. In this patch I tried assigning no_unique_address to every empty

[PATCH] D148148: [clang] Bump AS_GNU to 1

rsandifo-arm updated this revision to Diff 512947. rsandifo-arm added a comment. Gah, sorry. Due to a botched git operation, I posted a first cut with a stupid typo, rather than the version that passed testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148158: [include-cleaner] Handle incomplete template specializations

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Instantiation pattern is null for incomplete template types and using

[PATCH] D147121: [hwasan] remove requirment for PIE

eugenis added a comment. Sorry, I do not remember why this requirement is there. Must be related to shadow / allocator placement and kernel mapping conflicts, but hwasan is using dynamic shadow so that should not be an issue... LGTM as long as it works. Repository: rG LLVM Github Monorepo

[PATCH] D141307: Add -f[no-]loop-versioning option

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 ___ cfe-commits mailing list

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

aganea added subscribers: thieta, saudi. aganea added a comment. + @saudi @thieta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 ___ cfe-commits mailing list

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG144562e678d9: [clangd] Treat preamble patch as main file for include-cleaner analysis (authored by

[clang-tools-extra] 144562e - [clangd] Treat preamble patch as main file for include-cleaner analysis

Author: Kadir Cetinkaya Date: 2023-04-12T21:03:21+02:00 New Revision: 144562e678d932dc2685f8a83aeb2229bc96d71a URL: https://github.com/llvm/llvm-project/commit/144562e678d932dc2685f8a83aeb2229bc96d71a DIFF:

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. Thank you! I think there's only a few small things left then: - Add a release note about the fact that we worked around this issue in non-asserts builds but that assert builds may see new assertions triggered from this and to file an issue with a reproducer if

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 512929. Leporacanthicus marked 3 inline comments as done. Leporacanthicus added a comment. - Add new function to help clarify the purpose of the options being used. - Add descriptive comment to make function use clearer. - Update tests to make them a

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > erichkeane wrote: > > > >

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. In D147256#4262002 , @zequanwu wrote: > In D147256#4261949 , @hans wrote: > >>> Well, MSVC cl removes redundant dots so we shouldn't remove >>> llvm::sys::path::remove_dots. >> >> Could we

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. In D148066#4262379 , @reames wrote: > I would be fine landing this as experimental before ratification. I see no > real downside to doing that My concern would be that as we don't gate CSR names on enabling the relevant

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ?

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet added a comment. caea93cc4478cca28321cba4fa2871d5e6090299 should fix the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148112/new/

[clang-tools-extra] caea93c - [icnlude-cleaner] Fix dandling pointers in tests

Author: Kadir Cetinkaya Date: 2023-04-12T20:30:33+02:00 New Revision: caea93cc4478cca28321cba4fa2871d5e6090299 URL: https://github.com/llvm/llvm-project/commit/caea93cc4478cca28321cba4fa2871d5e6090299 DIFF:

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.h:144 + /// any. + static const FileEntry *getPatchEntry(llvm::StringRef MainFilePath, +

Re: [PATCH] D148112: [include-cleaner] Improve handling for templates

figured out the issue, preparing a fix On Wed, Apr 12, 2023 at 7:46 PM Douglas Yung via Phabricator < revi...@reviews.llvm.org> wrote: > dyung added a comment. > > @kadircet, your change is causing 3 test failures on Windows bots, can you > take a look and revert if you need time to investigate?

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill updated this revision to Diff 512910. Endill edited the summary of this revision. Endill added a comment. Remove parts of CWG1894 and CWG2199 tests that are resolved by CWG407 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148136/new/

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 erichkeane wrote: > Endill wrote: > > cor3ntin wrote: > > > I would just say "Yes", i think clang 3.8 predates these issues > >

[PATCH] D148031: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG723f7d3a0891: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES

[clang] 723f7d3 - [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

Author: Paul Kirth Date: 2023-04-12T18:01:47Z New Revision: 723f7d3a0891d341b635f31086ae268aadd6d3d6 URL: https://github.com/llvm/llvm-project/commit/723f7d3a0891d341b635f31086ae268aadd6d3d6 DIFF: https://github.com/llvm/llvm-project/commit/723f7d3a0891d341b635f31086ae268aadd6d3d6.diff LOG:

[PATCH] D148148: [clang] Bump AS_GNU to 1

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135 AttributeCommonInfo(const IdentifierInfo *AttrName, const IdentifierInfo *ScopeName, SourceRange AttrRange, rsandifo-arm wrote: >

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

reames added a comment. I would be fine landing this as experimental before ratification. I see no real downside to doing that, and would essentially leave it the judgement of the patch author as to whether just waiting until ratification or doing the extra work for staging as experimental is

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

erichkeane added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 Endill wrote: > cor3ntin wrote: > > I would just say "Yes", i think clang 3.8 predates these issues > It's not the case: 2199

[PATCH] D148148: [clang] Bump AS_GNU to 1

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135 AttributeCommonInfo(const IdentifierInfo *AttrName, const IdentifierInfo *ScopeName, SourceRange AttrRange, erichkeane wrote: > Did

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 cor3ntin wrote: > I would just say "Yes", i think clang 3.8 predates these issues It's not the case: 2199 was filed 12.11.2015,

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

aaron.ballman added a comment. Aside from the commenting issue pointed out by @shafik, I think we should move the test case into its own test file in SemaCXX and that `RUN` line should *not* use `-verify`. This way, we can test that we don't crash but we don't have to worry about spurious test

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:55 + +/// The attibute has no source code manifestation and is only created +/// implicitly. rsandifo-arm wrote: > erichkeane wrote: > > If I recall, there was

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9792 + "construct">; +def error_loop_reduction_clause : Error< + "reduction clause not handled with '#pragma omp loop bind(teams)'">; err_omp_...

[PATCH] D148148: [clang] Bump AS_GNU to 1

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:28 /// __attribute__((...)) -AS_GNU, +AS_GNU = 1, Note for others: we're now at 11 items (10 items + starting at 1), stored in 4 bits. So this doesn't

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:55 + +/// The attibute has no source code manifestation and is only created +/// implicitly. erichkeane wrote: > If I recall, there was some pretty awful

[PATCH] D148148: [clang] Bump AS_GNU to 1

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This LGTM, though curious about the re-ordering. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135 AttributeCommonInfo(const IdentifierInfo

[PATCH] D148148: [clang] Bump AS_GNU to 1

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following a suggestion from Erich in

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing list

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd945b6496ec6: [clang] Make make_cxx_dr_status script runnable from anywhere (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES

[clang] d945b64 - [clang] Make make_cxx_dr_status script runnable from anywhere

Author: Vlad Serebrennikov Date: 2023-04-12T20:46:05+03:00 New Revision: d945b6496ec6604f692804d501fc96583069d432 URL: https://github.com/llvm/llvm-project/commit/d945b6496ec6604f692804d501fc96583069d432 DIFF:

[PATCH] D148112: [include-cleaner] Improve handling for templates

dyung added a comment. @kadircet, your change is causing 3 test failures on Windows bots, can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/19740 https://lab.llvm.org/buildbot/#/builders/123/builds/18332 Repository: rG LLVM

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

kadircet updated this revision to Diff 512898. kadircet added a comment. - Expose helper to get preamble patch entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148143/new/ https://reviews.llvm.org/D148143 Files:

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 I would just say "Yes", i think clang 3.8 predates these issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ Endill wrote: > cor3ntin

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added a comment. Thank you for taking a look at this. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:19 +typedef signed short v8ss __attribute__((vector_size(16))); +typedef signed char v16sc __attribute__((vector_size(16))); +v4si v4si1, v4si2; What

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Great idea, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148146/new/ https://reviews.llvm.org/D148146

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

Endill created this revision. Endill added reviewers: clang-language-wg, cor3ntin. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This script has hardcoded relative paths to `clang/test/CXX/drs`,

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + aaron.ballman wrote: > erichkeane wrote: > > craig.topper wrote: > > > erichkeane wrote: > > > > craig.topper wrote: > > > > >

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ I think i would prefer

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added a comment. I've not done a complete review yet, but I got started on it and have a handful of comments. Comment at: clang/include/clang/Basic/TokenKinds.def:945 +// Annotation for end of input in clang-repl. +ANNOTATION(input_end) + Should

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > @erichkeane does this cover

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/test/OpenMP/loop_bind_codegen.cpp:51-56 +void thread_loop2() { + #pragma omp loop bind(thread) + for (int j = 0 ; j < NNN ; j++) { +aaa[j] = j*NNN; + } +} ABataev wrote: > I think it should trigger the assert

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > erichkeane wrote: > > craig.topper wrote: > > > @erichkeane does this cover the dependent case or were you

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:379 + (H.physical() == MainFile || + H.physical()->getName().endswith(PreamblePatch::HeaderName))) { Satisfied = true; Comparing

[clang] 3704752 - [clang][NFC] Use range-for loop in TextDiagnostic.cpp

Author: Timm Bäder Date: 2023-04-12T18:50:37+02:00 New Revision: 37047523a9fb5ffa74eaf94d9d52db831f99c062 URL: https://github.com/llvm/llvm-project/commit/37047523a9fb5ffa74eaf94d9d52db831f99c062 DIFF: https://github.com/llvm/llvm-project/commit/37047523a9fb5ffa74eaf94d9d52db831f99c062.diff

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > @erichkeane does this cover the dependent case or were you looking for > >

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Since we

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4261949 , @hans wrote: >> Well, MSVC cl removes redundant dots so we shouldn't remove >> llvm::sys::path::remove_dots. > > Could we do the `remove_dots` on the Clang side, where we can decide based on > the

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512869. junaire added a comment. fix ci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 512868. zequanwu added a comment. Add assertion on source locations in `pushRegion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files:

  1   2   >