[PATCH] D149828: [clang][Interp] Evaluate Base when discarding a MemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149828/new/ https://reviews.llvm.org/D149828

[PATCH] D149824: [clang][Interp] Don't call getSource() on functions without a body

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/Function.cpp:35 assert(PC <= getCodeEnd() && "PC Does not belong to this function"); + assert(hasBody()); unsigned

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 519555. shafik marked 4 inline comments as done. shafik added a comment. - Removed diagnostic group - fixed cxx_status indentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 Files:

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d6880554c2c: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file (authored by davidstone, committed by aaron.ballman).

[clang] 6d68805 - [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

Author: David Stone Date: 2023-05-04T13:06:53-04:00 New Revision: 6d6880554c2cd8d4d83db56c74eda24c22e6323a URL: https://github.com/llvm/llvm-project/commit/6d6880554c2cd8d4d83db56c74eda24c22e6323a DIFF: https://github.com/llvm/llvm-project/commit/6d6880554c2cd8d4d83db56c74eda24c22e6323a.diff

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. tbaeder

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis created this revision. TIFitis added reviewers: jdoerfert, jsjodin. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 519544. Ris-Bali marked 5 inline comments as done. Ris-Bali added a comment. Requested Changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

davidstone added a comment. In D149796#4319183 , @aaron.ballman wrote: > LGTM! Do you need me to commit this on your behalf? If so, what name and > email address would you like me to use for patch attribution? Yes please. David Stone,

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:849 +static_assert(strings_match(__func__, "foo")); +static_assert(strings_match(__PRETTY_FUNCTION__, "void PredefinedExprs::foo()")); + } tbaeder wrote: > tbaeder

[PATCH] D149869: [clang][dataflow] Remove deprecated pass-through APIs for DataflowAnalysisContext.

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. These were recently deprecated in

[PATCH] D149695: MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG053bf8640aa8: MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr) (authored by MaskRay). Repository: rG LLVM Github

[clang] 053bf86 - MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

Author: Fangrui Song Date: 2023-05-04T09:42:25-07:00 New Revision: 053bf8640aa85911823c2fc98538474c42d33b7a URL: https://github.com/llvm/llvm-project/commit/053bf8640aa85911823c2fc98538474c42d33b7a DIFF: https://github.com/llvm/llvm-project/commit/053bf8640aa85911823c2fc98538474c42d33b7a.diff

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit this on your behalf? If so, what name and email address would you like me to use for patch attribution? Repository: rG LLVM Github Monorepo

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu created this revision. myhsu added reviewers: 0x59616e, RKSimon, craig.topper. Herald added a subscriber: pengfei. Herald added a project: All. myhsu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We basically piggyback most of

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

aeubanks added a comment. In D149800#4317275 , @mtrofin wrote: > high level question, why not have it as a pass that runs after profiles (of > whatever kind - instrumented or sample-based) are ingested. The pass would > attribute functions as

[PATCH] D149862: Remove `Sema::getFloat128Identifier`

davidstone created this revision. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This function was added prior to clang supporting `__float128` to ensure clang could compile a libstdc++ header.

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

davidstone updated this revision to Diff 519514. davidstone added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149796/new/ https://reviews.llvm.org/D149796 Files:

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

This revision was automatically updated to reflect the committed changes. TIFitis marked 2 inline comments as done. Closed by commit rG35309db7dcef: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo

[clang] 35309db - [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

Author: Akash Banerjee Date: 2023-05-04T16:51:06+01:00 New Revision: 35309db7dcefde20180e924df303f65a14d97d68 URL: https://github.com/llvm/llvm-project/commit/35309db7dcefde20180e924df303f65a14d97d68 DIFF:

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > hnrklssn wrote: > >

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

kadircet added a comment. I agree with Ilya's concerns here. We deliberately don't mess with compile flags pushed over LSP. These are "overrides" to whatever information we have from other sources, turning on interpolation at this override layer implies we'll never fallback to other sources

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148423/new/ https://reviews.llvm.org/D148423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:849 +static_assert(strings_match(__func__, "foo")); +static_assert(strings_match(__PRETTY_FUNCTION__, "void PredefinedExprs::foo()")); + } aaron.ballman wrote: > You should

[PATCH] D147808: [clangd] Support non-trivial defaulted special member functions in Define Outline tweak

njames93 updated this revision to Diff 519496. njames93 added a comment. Fix clang-format issues. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147808/new/ https://reviews.llvm.org/D147808 Files:

[PATCH] D149816: [clang][Interp] Implement __builtin_strcmp

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Function.h:166-168 llvm::SmallVector &, llvm::DenseMap &, + llvm::SmallVector &, bool HasThisPointer, Nit: this interface should be taking

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. aaron.ballman

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. tbaeder

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:849 +static_assert(strings_match(__func__, "foo")); +static_assert(strings_match(__PRETTY_FUNCTION__, "void PredefinedExprs::foo()")); + } You should add coverage for

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519483. ldionne added a comment. Make sure we run the Clang pipeline always Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149752/new/ https://reviews.llvm.org/D149752 Files: clang/foo

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

egorzhdan created this revision. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds the support for `requires cplusplus20` directive for a module declared in a Clang modulemap,

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder updated this revision to Diff 519479. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148689/new/ https://reviews.llvm.org/D148689 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp Index:

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:783 + +namespace PredefinedExprs { + constexpr char heh(unsigned index) { aaron.ballman wrote: > tbaeder wrote: > > shafik wrote: > > > Can we add tests for each predefined

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

aaron.ballman added a comment. In D149514#4317734 , @tbaeder wrote: > This patch was submitted by a beginner, because > https://github.com/llvm/llvm-project/issues/62305 has the "good first issue" > label. From the last few comments, I'm not sure they

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519476. ldionne added a comment. Herald added subscribers: libcxx-commits, arichardson. Herald added a project: libc++. Herald added a reviewer: libc++. Check file type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:783 + +namespace PredefinedExprs { + constexpr char heh(unsigned index) { tbaeder wrote: > shafik wrote: > > Can we add tests for each predefined expressions, it does not look

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

aaron.ballman added a comment. > Sema.h is huge. Understatement of the year. :-D Thank you for working on this, I think it's a nice little cleanup. Just some minor nits. Comment at: clang/include/clang/Sema/EnterExpressionEvaluationContext.h:1 +//===--- Sema.h - Semantic

[PATCH] D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149737/new/ https://reviews.llvm.org/D149737 ___

[clang] 3984032 - Add the experiemental interpreter to the open project page

Author: Aaron Ballman Date: 2023-05-04T09:41:25-04:00 New Revision: 398403259a5a42624d382517f05b21f106f591b8 URL: https://github.com/llvm/llvm-project/commit/398403259a5a42624d382517f05b21f106f591b8 DIFF: https://github.com/llvm/llvm-project/commit/398403259a5a42624d382517f05b21f106f591b8.diff

[PATCH] D149846: [clang][Interp] Check inc/dec family of ops for initialization

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a few of the leftover FIXME comments from

[PATCH] D149744: [clang][dataflow][NFC] Eliminate unnecessary helper `stripReference()`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc849843c3ef7: [clang][dataflow][NFC] Eliminate unnecessary helper `stripReference()`. (authored by mboehme). Repository: rG LLVM Github Monorepo

[clang] c849843 - [clang][dataflow][NFC] Eliminate unnecessary helper `stripReference()`.

Author: Martin Braenne Date: 2023-05-04T13:14:04Z New Revision: c849843c3ef73a1cae9040620c4b37e2240f86af URL: https://github.com/llvm/llvm-project/commit/c849843c3ef73a1cae9040620c4b37e2240f86af DIFF: https://github.com/llvm/llvm-project/commit/c849843c3ef73a1cae9040620c4b37e2240f86af.diff

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

ymandel added a comment. In D145581#4223656 , @mboehme wrote: > In D145581#4223185 , @PiotrZSL > wrote: > >> And actually there is issue for this: >> https://github.com/llvm/llvm-project/issues/57758 > > Thanks

[PATCH] D149695: MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149695/new/ https://reviews.llvm.org/D149695 ___

[PATCH] D149744: [clang][dataflow][NFC] Eliminate unnecessary helper `stripReference()`.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks equivalent to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149744/new/ https://reviews.llvm.org/D149744

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

This revision was automatically updated to reflect the committed changes. Closed by commit rGf05ce9045af4: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D149451?vs=518604=519448#toc Repository:

[clang] f05ce90 - [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

Author: Joseph Huber Date: 2023-05-04T07:13:00-05:00 New Revision: f05ce9045af4a40232c08451cb0aef64b0e673b2 URL: https://github.com/llvm/llvm-project/commit/f05ce9045af4a40232c08451cb0aef64b0e673b2 DIFF: https://github.com/llvm/llvm-project/commit/f05ce9045af4a40232c08451cb0aef64b0e673b2.diff

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8f81ee1da32: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c8f81ee - [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

Author: Martin Braenne Date: 2023-05-04T12:05:39Z New Revision: c8f81ee1da325760a4bbd83c8c54ecc9645f8e20 URL: https://github.com/llvm/llvm-project/commit/c8f81ee1da325760a4bbd83c8c54ecc9645f8e20 DIFF: https://github.com/llvm/llvm-project/commit/c8f81ee1da325760a4bbd83c8c54ecc9645f8e20.diff

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added a comment. > Any indication we're going to hit something similar with GCC compatibility in > a glibc (or other system) header? I haven't seen non-Windows problems. Though I agree that if we somehow are going to support this for MSVC compatibility, there is no harm in allowing

[clang] c3f1faf - [clang][Interp][NFC] Fix allocateLocalPrimitive parameter name

Author: Timm Bäder Date: 2023-05-04T13:45:14+02:00 New Revision: c3f1faf96f18ca2162aff96b0adaf4cd22689ad4 URL: https://github.com/llvm/llvm-project/commit/c3f1faf96f18ca2162aff96b0adaf4cd22689ad4 DIFF: https://github.com/llvm/llvm-project/commit/c3f1faf96f18ca2162aff96b0adaf4cd22689ad4.diff

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

mboehme marked an inline comment as done. mboehme added a comment. Sorry, missed your LGTM. Will wait for pre-merge checks to complete and will then land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148110/new/ https://reviews.llvm.org/D148110

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

mboehme updated this revision to Diff 519437. mboehme added a comment. Fix typo and rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148110/new/ https://reviews.llvm.org/D148110 Files:

[PATCH] D147621: [clang][Interp] Start handling mutable record members

tbaeder updated this revision to Diff 519434. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147621/new/ https://reviews.llvm.org/D147621 Files: clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/records.cpp Index:

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg added a comment. I have checked the paper P2002R1 and as far as I can tell it is fully implemented when this patch has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 519432. massberg added a comment. Fix test that broke after last change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov added a comment. Friendly ping for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148802/new/ https://reviews.llvm.org/D148802 ___ cfe-commits mailing list

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:313-315 +} else if (const auto *SRegion = dyn_cast(Region)) { + // NOTE: The dyn_cast<>() is expected to succeed, it'd be very surprising + // to see a

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder updated this revision to Diff 519428. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149550/new/ https://reviews.llvm.org/D149550 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/floats.cpp clang/test/AST/Interp/literals.cpp Index:

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb88023c25729: [analyzer][NFC] Use std::optional instead of custom empty state (authored by donat.nagy). Repository: rG LLVM Github Monorepo

[clang] b88023c - [analyzer][NFC] Use std::optional instead of custom "empty" state

Author: Donát Nagy Date: 2023-05-04T12:56:15+02:00 New Revision: b88023c25729f4dd4548a25e5e12d6624e2adbaf URL: https://github.com/llvm/llvm-project/commit/b88023c25729f4dd4548a25e5e12d6624e2adbaf DIFF: https://github.com/llvm/llvm-project/commit/b88023c25729f4dd4548a25e5e12d6624e2adbaf.diff

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:272 + parent one. +SystemHeaders- Same as '--system-headers'. +UseColor - Same as '--use-color'.

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. In D149809#4317763 , @aidengrossman wrote: > In D149809#4317610 , @tstellar > wrote: > >> I think we could remove some of the duplication by making the docs_target >> parameter into a

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 519423. VincentWu marked 4 inline comments as done. VincentWu added a comment. address comments. A Decoding Conflict error of zcmt was reported when I rebase to upstream. F27326236: 8f57240fe7bfaeef5a7f2816ca1dfed.png

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeadf6db585e1: [docs] Hide collaboration and include graphs in doxygen docs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[clang] eadf6db - [docs] Hide collaboration and include graphs in doxygen docs

Author: Timm Bäder Date: 2023-05-04T12:26:51+02:00 New Revision: eadf6db585e1f018e30d9c8de4b32c5d78468e19 URL: https://github.com/llvm/llvm-project/commit/eadf6db585e1f018e30d9c8de4b32c5d78468e19 DIFF: https://github.com/llvm/llvm-project/commit/eadf6db585e1f018e30d9c8de4b32c5d78468e19.diff

[PATCH] D149838: [clang][dataflow] Eliminate `SkipPast::ReferenceThenPointer`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a replacement, we provide the accessors

[PATCH] D149837: [clang][Interp] Fix ignoring CompoundLiteralExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:537 +} } return true; Obviously, this patch also fixes ignoring `InitListExpr`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149837: [clang][Interp] Fix ignoring CompoundLiteralExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3dcd3ad992c: [clang-format] Correctly limit formatted ranges when specifying qualifier… (authored by cogilvie, committed by owenpan). Repository:

[clang] f3dcd3a - [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

Author: Colin Ogilvie Date: 2023-05-04T02:59:05-07:00 New Revision: f3dcd3ad992c82be4f652fd2aac6b0ef414566a2 URL: https://github.com/llvm/llvm-project/commit/f3dcd3ad992c82be4f652fd2aac6b0ef414566a2 DIFF: https://github.com/llvm/llvm-project/commit/f3dcd3ad992c82be4f652fd2aac6b0ef414566a2.diff

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski added a comment. In D134821#4317371 , @peixin wrote: >> @peixin , wdyt? > > @awarzynski Hi Andrzej, sorry for the late reply. I am distracted by several > internal projects and other things in my life recently (just came back from >

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

steakhal added a comment. In D149259#4317788 , @steakhal wrote: > We only had a single new issue after this patch. This is well within what I > would be comfortable with. I'll investigate the case anyway. It's likely > something flaky. It did not

[PATCH] D149831: [clang][Interp] Fix ignoring SubstNonTypeTemplateParmExpr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a subscriber: kristof.beyls. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ignore

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

kwk accepted this revision. kwk added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149828: [clang][Interp] Evaluate Base when discarding a MemberExpr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Base expression might cause side-effects, so

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie added a comment. In D149643#4316128 , @MyDeveloperDay wrote: > Thanks for the patch...this tells me people are starting to use this feature > in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) > which means you have

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie marked 2 inline comments as done. cogilvie added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie updated this revision to Diff 519389. cogilvie marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp

[PATCH] D149824: [clang][Interp] Don't call getSource() on functions without a body

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For builtin functions, we create a Function

[clang] d3c0165 - [clang][Interp][NFC] Remove unnecessary include from State.h

Author: Timm Bäder Date: 2023-05-04T10:21:01+02:00 New Revision: d3c01652448231ad24eb9abfc6af95f58f865f07 URL: https://github.com/llvm/llvm-project/commit/d3c01652448231ad24eb9abfc6af95f58f865f07 DIFF: https://github.com/llvm/llvm-project/commit/d3c01652448231ad24eb9abfc6af95f58f865f07.diff

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM, only the inheritance graph is useful, which this preserves if I understand correctly (CLASS_GRAPH is still YES). Repository: rG LLVM Github

[clang] 5c9a849 - [clang][Interp][NFC] Use const references to Floating

Author: Timm Bäder Date: 2023-05-04T10:03:40+02:00 New Revision: 5c9a84960de2260f149ee15313998593255a78df URL: https://github.com/llvm/llvm-project/commit/5c9a84960de2260f149ee15313998593255a78df DIFF: https://github.com/llvm/llvm-project/commit/5c9a84960de2260f149ee15313998593255a78df.diff

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 617fc0b - [clangd] Remove unused variable [NFC]

Author: Mikael Holmen Date: 2023-05-04T09:58:05+02:00 New Revision: 617fc0b9fe55a54c7a7f655d992a470d42032a91 URL: https://github.com/llvm/llvm-project/commit/617fc0b9fe55a54c7a7f655d992a470d42032a91 DIFF: https://github.com/llvm/llvm-project/commit/617fc0b9fe55a54c7a7f655d992a470d42032a91.diff

[clang] 0354f31 - [clang][Interp][NFC] Don't cast primitive types to the same type

Author: Timm Bäder Date: 2023-05-04T09:53:15+02:00 New Revision: 0354f31b513991d936e8a9af0a50890c48ea01b0 URL: https://github.com/llvm/llvm-project/commit/0354f31b513991d936e8a9af0a50890c48ea01b0 DIFF: https://github.com/llvm/llvm-project/commit/0354f31b513991d936e8a9af0a50890c48ea01b0.diff

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:550 std::optional FixAll; if (RemoveAllUnused && AddAllMissing) FixAll = fixAll(*RemoveAllUnused, *AddAllMissing); kadircet wrote: > sorry for missing it during last

[PATCH] D149822: [clangd] Fix fixAll not shown when there is only one unused-include and missing-include diagnostics.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Discovered during the review in

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:329 +static void +builtinTransferScopeEnd(const CFGScopeEnd , +TypeErasedDataflowAnalysisState ) { mboehme wrote: > xazax.hun

[clang] 67c9fd7 - [clang][Interp][NFC] Make Pointer::block() const

Author: Timm Bäder Date: 2023-05-04T09:36:40+02:00 New Revision: 67c9fd7a184a138a690cae1bef4073fddba07151 URL: https://github.com/llvm/llvm-project/commit/67c9fd7a184a138a690cae1bef4073fddba07151 DIFF: https://github.com/llvm/llvm-project/commit/67c9fd7a184a138a690cae1bef4073fddba07151.diff

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme updated this revision to Diff 519373. mboehme marked 3 inline comments as done. mboehme added a comment. - Removed usage of `CFGScopeEnd` - Removed the assertion that two `DeclToLoc` to be joined don't contain conflicting entries Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:783 + +namespace PredefinedExprs { + constexpr char heh(unsigned index) { shafik wrote: > Can we add tests for each predefined expressions, it does not look like there > are a lot of

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder updated this revision to Diff 519370. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149550/new/ https://reviews.llvm.org/D149550 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/floats.cpp clang/test/AST/Interp/literals.cpp Index:

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. tbaeder wrote: >

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. aaron.ballman

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

jobnoorman added a comment. In D148767#4316464 , @chapuni wrote: > In D148767#4315667 , @jobnoorman > wrote: > >> Hi, this seems to have broken my bolt+debug+shared build. I don't think >> there are build bots

[clang] 6ccf330 - [clang][Interp] Add missing static_assert messages

Author: Timm Bäder Date: 2023-05-04T09:10:21+02:00 New Revision: 6ccf3307f49fe8265802320be837a9b4210ebf05 URL: https://github.com/llvm/llvm-project/commit/6ccf3307f49fe8265802320be837a9b4210ebf05 DIFF: https://github.com/llvm/llvm-project/commit/6ccf3307f49fe8265802320be837a9b4210ebf05.diff

[PATCH] D149634: [clang][Interp] Implement inc/dec operators for floats

This revision was automatically updated to reflect the committed changes. Closed by commit rG338c2489f63e: [clang][Interp] Implement inc/dec operators for floats (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D149634?vs=518642=519365#toc Repository: rG LLVM Github

[clang] 338c248 - [clang][Interp] Implement inc/dec operators for floats

Author: Timm Bäder Date: 2023-05-04T08:52:53+02:00 New Revision: 338c2489f63e1c34db047ac8e45efeeb88c8a067 URL: https://github.com/llvm/llvm-project/commit/338c2489f63e1c34db047ac8e45efeeb88c8a067 DIFF: https://github.com/llvm/llvm-project/commit/338c2489f63e1c34db047ac8e45efeeb88c8a067.diff

<    1   2   3   >