[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 524072. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D151040: [NFC][CLANG] Fix static analyzer concerns

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Dereference null return value Inside "ExprConstant.cpp"

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. In D150931#4358903 , @aaronpuchert wrote: > Changes to `ThreadSafetyTIL.h` look good to me, thanks! Thank you @aaronpuchert for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/

[PATCH] D51057: [analyzer][UninitializedObjectChecker] Fixed dereferencing

isuckatcs added inline comments. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, baloghadamsoftware. Herald added a project: All. Comment at:

[PATCH] D148573: Allow -fsanitize=function on all targets

MaskRay added a comment. In D148573#4358899 , @vitalybuka wrote: > These bots are broken after the patch > https://lab.llvm.org/buildbot/#/builders/77/builds/26834 > https://lab.llvm.org/buildbot/#/builders/18/builds/9073 The ppc64le has other

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

aaronpuchert added a comment. Changes to `ThreadSafetyTIL.h` look good to me, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148573: Allow -fsanitize=function on all targets

vitalybuka added a comment. These bots are broken after the patch https://lab.llvm.org/buildbot/#/builders/77/builds/26834 https://lab.llvm.org/buildbot/#/builders/18/builds/9073 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148573/new/

[clang] e8cc0d3 - [NFC] improment release note word for #62447

Author: Congcong Cai Date: 2023-05-20T23:29:20+02:00 New Revision: e8cc0d310c4060b605dc293bff5d2bca95ff528b URL: https://github.com/llvm/llvm-project/commit/e8cc0d310c4060b605dc293bff5d2bca95ff528b DIFF: https://github.com/llvm/llvm-project/commit/e8cc0d310c4060b605dc293bff5d2bca95ff528b.diff

[PATCH] D46415: [analyzer] pr36458: Fix retrieved value cast for symbolic void pointers.

isuckatcs added inline comments. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho. Herald added a project: All. Comment at: test/Analysis/casts.c:166 + *x = 1; + clang_analyzer_eval(u == 1); //

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

owenpan added a comment. In D150403#4350325 , @galenelias wrote: > In D150403#4347323 , > @HazardyKnusperkeks wrote: > >> We'll wait a bit, if someone might have a comment. And (at least I) need >> name and

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

delcypher added a comment. @ahatanak Thanks for working on this. I think that annotating these particular tests so that's clear that they are supposed to crash (and therefore symbolication is of no use) is a good change. If we want to make a more global change for tests I think that should be

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. Awesome, this makes a lot of sense and is a great pattern to make these more modular. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997

[PATCH] D151034: [clang] Add test for CWG1397

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Resolution of this CWG breaks potential dependency loop between

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 524045. ychen added a comment. - fix - Address comments - fix - - adjust test check for Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 524044. Manna marked 2 inline comments as done. Manna added a comment. I have updated patch to resolve build errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 Files:

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. In D146389#4358358 , @argentite wrote: > Added some std::move fixes for Error -> Expected conversions > > We need to figure out a solution when NVPTX backend is not enabled. > clang-repl probably should not depends on that.

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4357276 , @erichkeane wrote: > In D146358#4357106 , @hazohelet > wrote: > >> Thanks for the revert! >> >> It seems that the problem is around the list initializer in

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna abandoned this revision. Manna added a comment. This is False Positive. We are correctly checking type mismatch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 ___ cfe-commits mailing list

[PATCH] D151033: [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable template definition

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, erichkeane, tbaeder. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. `TextNodeDumper` enabed through `-ast-dump` flag should not evlauate the initializer when it

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524041. IncludeGuardian added a comment. Add missing specialization for clang-include-cleaner/Types.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files:

[PATCH] D151032: [clang] Add test for CWG2213

Endill added a comment. If reviewers would prefer this to be simply marked N/A, I'm not going to oppose. I wrote a test for this because it was simple enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151032/new/

[PATCH] D151032: [clang] Add test for CWG2213

Endill created this revision. Endill added reviewers: clang-language-wg, shafik, cor3ntin. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2213 is resolved by allowing

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

nikic added a comment. The pre-merge checks have a build failure in clang-tools-extra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 ___ cfe-commits mailing

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46f366494f3c: -fsanitize=function: use type hashes instead of RTTI objects (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[clang] 46f3664 - -fsanitize=function: use type hashes instead of RTTI objects

Author: Fangrui Song Date: 2023-05-20T08:24:20-07:00 New Revision: 46f366494f3ca8cc98daa6fb4f29c7c446c176b6 URL: https://github.com/llvm/llvm-project/commit/46f366494f3ca8cc98daa6fb4f29c7c446c176b6 DIFF: https://github.com/llvm/llvm-project/commit/46f366494f3ca8cc98daa6fb4f29c7c446c176b6.diff

[PATCH] D150139: [clang-repl] Enable basic multiline support.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in c96c5edb58ed29e0fd936bc082ec6cae7082854e Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150139/new/

[clang] c96c5ed - [clang-repl] Enable basic multiline support.

Author: Vassil Vassilev Date: 2023-05-20T14:40:58Z New Revision: c96c5edb58ed29e0fd936bc082ec6cae7082854e URL: https://github.com/llvm/llvm-project/commit/c96c5edb58ed29e0fd936bc082ec6cae7082854e DIFF: https://github.com/llvm/llvm-project/commit/c96c5edb58ed29e0fd936bc082ec6cae7082854e.diff

[PATCH] D150579: [*]: fix syntax errors in HTML files

VoltrexMaster updated this revision to Diff 524033. VoltrexMaster added a comment. Fix merge conflict with upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150579/new/ https://reviews.llvm.org/D150579 Files:

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst:79 + +.. option:: StrictMode + It turns out that absl::PrintF and absl::FPrintF work like std::format, fmt::printf, etc. and use the signedness of

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

rymiel added a comment. This patch also fixes https://github.com/llvm/llvm-project/issues/52911 (which is probably a duplicate anyway) Comment at: clang/lib/Format/UnwrappedLineParser.cpp:583-584 + ProbablyBracedList || + NextTok->is(tok::l_brace) &&

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian added inline comments. Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:321 - static bool isEqual(const Variant , const Variant ) { -return LHS == RHS; - } Regardless of this change, I think the equality here needs to be fixed in the

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524024. IncludeGuardian added a comment. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix one missing `` include in tools and add `DenseMapInfoVariant.h`, which I forgot previously Repository: rG LLVM Github

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0ba1c12fcc: [Clang] Fix parsing of `(auto(x))`. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1b0ba1c - [Clang] Fix parsing of `(auto(x))`.

Author: Corentin Jabot Date: 2023-05-20T13:22:58+02:00 New Revision: 1b0ba1c12fcc86dcf4097b3b8941260e8c6361fa URL: https://github.com/llvm/llvm-project/commit/1b0ba1c12fcc86dcf4097b3b8941260e8c6361fa DIFF:

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

Endill added a comment. Thank you for working on this feature! I can't review this properly, so here's my little help for the feature I'm looking forward to very much. Comment at: clang/test/CXX/drs/dr25xx.cpp:1 -// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. Should be fixed by https://github.com/llvm/llvm-project/commit/abbb22cc0c9c33dedb8d53c2bd3e703f92baace7. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920

[clang] abbb22c - [clang][NFC] Fix CWG399 test

Author: Vlad Serebrennikov Date: 2023-05-20T12:56:52+03:00 New Revision: abbb22cc0c9c33dedb8d53c2bd3e703f92baace7 URL: https://github.com/llvm/llvm-project/commit/abbb22cc0c9c33dedb8d53c2bd3e703f92baace7 DIFF:

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 524006. argentite added a comment. Added some std::move fixes for Error -> Expected conversions We need to figure out a solution when NVPTX backend is not enabled. clang-repl probably should not depends on that. Example:

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. Thank you! I'm going to fix this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits mailing list

[PATCH] D149612: [Sema] avoid merge error type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef107afd48a9: [Sema] avoid merge error type (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ef107af - [Sema] avoid merge error type

Author: Congcong Cai Date: 2023-05-20T11:18:42+02:00 New Revision: ef107afd48a920e74167874a55e2afb6decb52c7 URL: https://github.com/llvm/llvm-project/commit/ef107afd48a920e74167874a55e2afb6decb52c7 DIFF: https://github.com/llvm/llvm-project/commit/ef107afd48a920e74167874a55e2afb6decb52c7.diff

[clang] 0929f5b - Revert "[clang-repl][CUDA] Initial interactive CUDA support for clang-repl"

Author: Anubhab Ghosh Date: 2023-05-20T14:40:04+05:30 New Revision: 0929f5b90350aa2f9175d7e1094b1750535c0e44 URL: https://github.com/llvm/llvm-project/commit/0929f5b90350aa2f9175d7e1094b1750535c0e44 DIFF: https://github.com/llvm/llvm-project/commit/0929f5b90350aa2f9175d7e1094b1750535c0e44.diff

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. @rsmith could you review it again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 524001. HerrCai0907 added a comment. simplify test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80e7eed6a610: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl (authored by argentite). Changed prior to commit:

[clang] 80e7eed - [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Author: Anubhab Ghosh Date: 2023-05-20T14:00:48+05:30 New Revision: 80e7eed6a610ab3c7289e6f9b7ec006bc7d7ae31 URL: https://github.com/llvm/llvm-project/commit/80e7eed6a610ab3c7289e6f9b7ec006bc7d7ae31 DIFF: https://github.com/llvm/llvm-project/commit/80e7eed6a610ab3c7289e6f9b7ec006bc7d7ae31.diff

[PATCH] D147920: [clang] Add test for CWG399

cor3ntin added a comment. I'm seeing test failures on main error: 'error' diagnostics expected but not seen: File /home/cor3ntin/dev/compilers/LLVM/llvm-project/clang/test/CXX/drs/dr3xx.cpp Line 1456: refers to a member in namespace File

[PATCH] D147920: [clang] Add test for CWG399

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Endill marked an inline comment as not done. Closed by commit rG14f245d01a1e: [clang] Add test for CWG399 (authored by Endill). Changed prior to commit:

[clang] 14f245d - [clang] Add test for CWG399

Author: Vlad Serebrennikov Date: 2023-05-20T11:17:44+03:00 New Revision: 14f245d01a1ee489a13e843e9c77cecf5c7183a9 URL: https://github.com/llvm/llvm-project/commit/14f245d01a1ee489a13e843e9c77cecf5c7183a9 DIFF:

[PATCH] D150645: [Driver] Support multi /guard: options

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f366dcd85c: Reland [Driver] Support multi /guard: options (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/

[clang] a4f366d - Reland "[Driver] Support multi /guard: options"

Author: Phoebe Wang Date: 2023-05-20T14:44:05+08:00 New Revision: a4f366dcd85c440a611bbc82f1d24c2d9a735251 URL: https://github.com/llvm/llvm-project/commit/a4f366dcd85c440a611bbc82f1d24c2d9a735251 DIFF: https://github.com/llvm/llvm-project/commit/a4f366dcd85c440a611bbc82f1d24c2d9a735251.diff

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:381 HasBFloat16 = SSELevel >= SSE2; codemzs wrote: > rjmccall wrote: > > pengfei wrote: > > > I'm not sure if I understand the meaning of `HasFullBFloat16`. If it is > > > used

[PATCH] D149612: [Sema] avoid merge error type

hokein accepted this revision. hokein added a comment. thanks, looks good to me. Comment at: clang/test/Sema/merge-decls.c:96 +char d; +char x[sizeof(d.data) == 8]; // expected-error {{member reference base type 'char' is not a structure or union}} +char x[sizeof(d.data) ==