[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe62175736551: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and… (authored by codemzs, committed by pengfei). Changed prior

[clang] e621757 - [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support

Author: M. Zeeshan Siddiqui Date: 2023-05-27T13:33:50+08:00 New Revision: e62175736551abf40a3410bc246f58e650eb8158 URL: https://github.com/llvm/llvm-project/commit/e62175736551abf40a3410bc246f58e650eb8158 DIFF:

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The last use was removed by: commit 6625680a581c5e29c53d9f58d864cc6cd3cd05f6 Author: Hans Wennborg Date: Tue

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit bb1ea2d6139a72340b426e114510c46d938645a6 Author: Nemanja Ivanovic Date: Mon May 9

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 0eb06cb3aa2700508c20da28f22ff91e7b82a436 Author: Roy Jacobson Date: Tue Mar 14

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

shafik added a comment. This PR seems related to this crash: https://github.com/llvm/llvm-project/issues/62958 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: mattd, gchakrabarti, asavonic, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a

[clang] 273303a - [Sema] Remove unused declaration startLambdaDefinition

Author: Kazu Hirata Date: 2023-05-26T20:19:23-07:00 New Revision: 273303ad66a32e5e599bef5ee18c3a9f589e530d URL: https://github.com/llvm/llvm-project/commit/273303ad66a32e5e599bef5ee18c3a9f589e530d DIFF: https://github.com/llvm/llvm-project/commit/273303ad66a32e5e599bef5ee18c3a9f589e530d.diff

[clang-tools-extra] 7961848 - [clangd] Remove unused declaration onCallHierarchyOutgoingCalls

Author: Kazu Hirata Date: 2023-05-26T20:19:22-07:00 New Revision: 796184854c4db285bef503a4e57cd6c5aa54fa5d URL: https://github.com/llvm/llvm-project/commit/796184854c4db285bef503a4e57cd6c5aa54fa5d DIFF: https://github.com/llvm/llvm-project/commit/796184854c4db285bef503a4e57cd6c5aa54fa5d.diff

[clang] 54ab4b3 - [CodeGen] Remove unused declarations emitNonSPMDParallelCall and emitSPMDParallelCall

Author: Kazu Hirata Date: 2023-05-26T20:07:52-07:00 New Revision: 54ab4b3a2847127590cebdf17bc83288b7f03158 URL: https://github.com/llvm/llvm-project/commit/54ab4b3a2847127590cebdf17bc83288b7f03158 DIFF: https://github.com/llvm/llvm-project/commit/54ab4b3a2847127590cebdf17bc83288b7f03158.diff

[clang] 8078e77 - [AST] Remove unused declaration enumerateVFPtrs

Author: Kazu Hirata Date: 2023-05-26T20:07:51-07:00 New Revision: 8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e URL: https://github.com/llvm/llvm-project/commit/8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e DIFF: https://github.com/llvm/llvm-project/commit/8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e.diff

[clang] ee15c1f - [Sema] Remove unused declaration ConvertIntegerToTypeWarnOnOverflow

Author: Kazu Hirata Date: 2023-05-26T20:07:49-07:00 New Revision: ee15c1fa84c2245866b0a202e896928621401f71 URL: https://github.com/llvm/llvm-project/commit/ee15c1fa84c2245866b0a202e896928621401f71 DIFF: https://github.com/llvm/llvm-project/commit/ee15c1fa84c2245866b0a202e896928621401f71.diff

[clang] 0286b47 - [Driver] Remove redundant -z special case. NFC

Author: Fangrui Song Date: 2023-05-26T19:39:19-07:00 New Revision: 0286b47ae03356853736986f91f85c67115611ae URL: https://github.com/llvm/llvm-project/commit/0286b47ae03356853736986f91f85c67115611ae DIFF: https://github.com/llvm/llvm-project/commit/0286b47ae03356853736986f91f85c67115611ae.diff

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

MaskRay accepted this revision as: MaskRay. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1356 +Arg *tools::getLastCSProfileGenerateArg(const ArgList ) { + auto *CSPGOGenerateArg =

[clang] af7aea3 - [Driver][test] Replace legacy -target with --target=

Author: Fangrui Song Date: 2023-05-26T19:01:39-07:00 New Revision: af7aea365a2ae8dc51938a614353e1586072ef83 URL: https://github.com/llvm/llvm-project/commit/af7aea365a2ae8dc51938a614353e1586072ef83 DIFF: https://github.com/llvm/llvm-project/commit/af7aea365a2ae8dc51938a614353e1586072ef83.diff

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > qiongsiwu1 wrote: > > tra wrote: > > > qiongsiwu1 wrote: > > > > Do we need an install target for

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra updated this revision to Diff 526227. tra added a comment. Verified that install works correctly with individual component installations: cmake -DCOMPONENT=cuda-resource-headers -P ./cmake_install.cmake cmake -DCOMPONENT=clang-resource-headers -P ./cmake_install.cmake Repository: rG

[clang] f354e97 - [MemProf] Clean up MemProf instrumentation pass invocation

Author: Teresa Johnson Date: 2023-05-26T17:38:49-07:00 New Revision: f354e971b09c244147ff59eb65b34487755598c0 URL: https://github.com/llvm/llvm-project/commit/f354e971b09c244147ff59eb65b34487755598c0 DIFF:

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf354e971b09c: [MemProf] Clean up MemProf instrumentation pass invocation (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. Here's a rough proof-of-concept patch coalescing i16/f16/bf16 to use the same Int16Regs register class: https://reviews.llvm.org/D151601 The changes are largely mechanical, replacing `%h` -> `%rs` in the tests and eliminating special cases we previously had for

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. apologies, i just realized its a new test that you xfailed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576 ___ cfe-commits mailing

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. i think the extra two failures are not related to you patch. so ignore comment about these libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl1.c libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl2.c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > tra wrote: > > qiongsiwu1 wrote: > > > Do we need an install target for `${cuda_wrapper_bits_files}` for the >

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > Do we need an install target for `${cuda_wrapper_bits_files}` for the > >

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. observing failure in our amdgpu buildbot , 3 tests see: https://lab.llvm.org/staging/#/builders/247/builds/947 7: __tgt_target_table *__tgt_rtl_load_binary(int32_t, __tgt_device_image *): Assertion `Table != nullptr && "Invalid table"' failed. if you have a quick fix,

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://reviews.llvm.org/D151578

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

snehasish accepted this revision. snehasish added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151593/new/ https://reviews.llvm.org/D151593 ___ cfe-commits mailing list

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:604 def int_nvvm_f # operation # variant : ClangBuiltin, DefaultAttrsIntrinsic<[llvm_i16_ty], [llvm_i16_ty, llvm_i16_ty], tra wrote: > Availability of these

[clang] a419ec4 - Fix runtime crash inside __kmpc_init_allocator

Author: Jennifer Yu Date: 2023-05-26T16:03:01-07:00 New Revision: a419ec4f256d279c91746a3962dd6dd2da45c304 URL: https://github.com/llvm/llvm-project/commit/a419ec4f256d279c91746a3962dd6dd2da45c304 DIFF: https://github.com/llvm/llvm-project/commit/a419ec4f256d279c91746a3962dd6dd2da45c304.diff

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa419ec4f256d: Fix runtime crash inside __kmpc_init_allocator (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. vitalybuka wrote: > tejohnson wrote: > > vitalybuka

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? +

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6e617c8efab: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory (authored by jansvoboda11). Changed prior to commit:

[clang] d6e617c - [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

Author: Jan Svoboda Date: 2023-05-26T15:30:28-07:00 New Revision: d6e617c8efab582121e0a0a9d539652bdfd544da URL: https://github.com/llvm/llvm-project/commit/d6e617c8efab582121e0a0a9d539652bdfd544da DIFF: https://github.com/llvm/llvm-project/commit/d6e617c8efab582121e0a0a9d539652bdfd544da.diff

[clang] 89d71c1 - [Driver] Reject AIX-specific link options on non-AIX targets

Author: Fangrui Song Date: 2023-05-26T15:30:23-07:00 New Revision: 89d71c1efa85656b54bcd79b4278bc67690480e1 URL: https://github.com/llvm/llvm-project/commit/89d71c1efa85656b54bcd79b4278bc67690480e1 DIFF: https://github.com/llvm/llvm-project/commit/89d71c1efa85656b54bcd79b4278bc67690480e1.diff

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Either way is fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151593/new/ https://reviews.llvm.org/D151593

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. tejohnson wrote: > vitalybuka wrote: > > if this

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526210. nickdesaulniers added a comment. - fix string literals; still WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 Files:

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. vitalybuka wrote: > if this is

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. if this is registerOptimizerLastEPCallback, it can

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/Module.h:160 + llvm::PointerUnion Umbrella; benlangmuir wrote: > Would it make sense to implement `PointerLikeTypeTraits` for > FileEntryRef/DirectoryEntryRef so you don't need to

[PATCH] D151581: [clang][modules] NFCI: Distinguish as-written and effective umbrella directories

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG924912956ed5: [clang][modules] NFCI: Distinguish as-written and effective umbrella directories (authored by jansvoboda11). Herald added a project:

[clang] 9249129 - [clang][modules] NFCI: Distinguish as-written and effective umbrella directories

Author: Jan Svoboda Date: 2023-05-26T15:14:16-07:00 New Revision: 924912956ed570e433440108cc50bd0ee65605b5 URL: https://github.com/llvm/llvm-project/commit/924912956ed570e433440108cc50bd0ee65605b5 DIFF: https://github.com/llvm/llvm-project/commit/924912956ed570e433440108cc50bd0ee65605b5.diff

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL created this revision. PiotrZSL added reviewers: serge-sans-paille, carlosgalvezp, njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

tejohnson created this revision. tejohnson added a reviewer: snehasish. Herald added subscribers: ormris, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. First, removes the invocation of the memprof instrumentation passes

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis created this revision. Herald added subscribers: wlei, ormris, wenlei, steven_wu, hiraditya. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho. ellis added reviewers: int3, tejohnson, xur. ellis updated this revision to Diff 526199. ellis added a comment. ellis edited

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

kadircet added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:42 + +struct MissingIncludeInfo { + SourceLocation SymRefLocation; let's put this struct into anon namespace Comment at:

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2684acfb61d: [HWASan] use hwasan linker for Android 14+ (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a2684ac - [HWASan] use hwasan linker for Android 14+

Author: Florian Mayer Date: 2023-05-26T14:25:46-07:00 New Revision: a2684acfb61d40f441e240035d7f1ba50da637c8 URL: https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8 DIFF: https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8.diff

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151388/new/ https://reviews.llvm.org/D151388 ___

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > Do we need an install target for `${cuda_wrapper_bits_files}` for the > `cuda-resource-headers` component as well? It

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Module.h:160 + llvm::PointerUnion Umbrella; Would it make sense to implement

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526195. nickdesaulniers added a comment. Herald added subscribers: kerbowa, jvesely. - one more test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587

[PATCH] D151586: [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Module.cpp:486 - if (Header H = getWrittenUmbrellaHeader()) { + if (auto H = getWrittenUmbrellaHeader()) {

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG785b30b8a33a: [clang-tidy] Check for specific return types on all functions (authored by chaitanyav). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 785b30b - [clang-tidy] Check for specific return types on all functions

Author: NagaChaitanya Vellanki Date: 2023-05-26T13:59:18-07:00 New Revision: 785b30b8a33a394a677b1b8ce35c66ba482db169 URL: https://github.com/llvm/llvm-project/commit/785b30b8a33a394a677b1b8ce35c66ba482db169 DIFF:

[PATCH] D151581: [clang][modules] NFCI: Distinguish written/effective umbrella directories

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Module.h:655 + /// Retrieve the explicitly written umbrella directory for this module. + DirectoryName

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526192. nickdesaulniers added a comment. - also remove VisitExprWithCleanups, down to two outstanding test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, jansvoboda11, pengfei, power-llvm-team. Herald added subscribers: jrtc27, fedor.sergeev, nemanjai, jyknight. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by @efriedma in: https://reviews.llvm.org/D76096#4370369 Signed-off-by: Nick Desaulniers

[PATCH] D151586: [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most users of

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

jyu2 added a comment. In D148723#4376946 , @serge-sans-paille wrote: > @jyu2 : could you test that patch in your setup ? Also I can't find the bug > id associated with your original bug anymore... I just submit bug in

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. In D151383#4377043 , @PiotrZSL wrote: > LGTM, you may consider reducing commit message (aka review description by > removing example and error from it, and leaving just plain description of a > change). got it, will make

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM, you may consider reducing commit message (aka review description by removing example and error from it, and leaving just plain description of a change). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner added a comment. @steakhal did you get a chance to look at my comment? I would really love to see this merged upstream if you think this could be a beneficial change :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes some

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526173. chaitanyav marked an inline comment as done. chaitanyav added a comment. use fully qualified name in code and documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( Do we need an install target for `${cuda_wrapper_bits_files}` for the `cuda-resource-headers` component as well? It seems to be

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille added a comment. @jyu2 : could you test that patch in your setup ? Also I can't find the bug id associated with your original bug anymore... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 526163. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL accepted this revision. PiotrZSL added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:129 + CheckedReturnTypes(utils::options::parseStringList( +

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526159. chaitanyav marked 4 inline comments as done. chaitanyav added a comment. Make changes as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D151581: [clang][modules] NFCI: Distinguish written/effective umbrella directories

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For modules with

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton updated this revision to Diff 526154. benhamilton added a comment. Add `FOUNDATION_EXTERN` alias for `FOUNDATION_EXPORT` (Apple `#define`s the former to the latter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton updated this revision to Diff 526151. benhamilton added a comment. Fix auto-complete-o. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://reviews.llvm.org/D151578 Files: clang/lib/Format/Format.cpp

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton created this revision. benhamilton added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. benhamilton requested review of this revision. This adds to the

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rG9346dc6f675e: Add fastmath attributes to llvm.call_intrinsic (authored by electriclilies, committed by Mogball). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 526148. evelez7 added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151477/new/ https://reviews.llvm.org/D151477 Files:

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 526144. SlaterLatiao added a comment. - Add newline to end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files:

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers added a comment. In D151572#4376697 , @efriedma wrote: > Did you intentionally skip moving the ConstExprEmitter call in > tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant > evaluator.) Yes, I'll do that in a follow

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, jplehr, sstefan1. It seems load of traits.addr should be passed in

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. @NoQ **Re: ElementRegion hacks:** Your suggestion is very convincing, and I agree that while my idea would bring some clarity to some particular issues, overall it would just worsen the "chaotic heap of classes" situation. The only advantage of my solution is that

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes PR#62001. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151575 Files:

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

efriedma added a comment. Did you intentionally skip moving the ConstExprEmitter call in tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant evaluator.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151572/new/

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526131. nickdesaulniers added a comment. - one more style update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151572/new/ https://reviews.llvm.org/D151572 Files:

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D150985#4369279 , @tra wrote: > As I said, I'm OK with the patch in principle, I just don't know what other > factors I may be missing. > > Tests seem to be missing for c11 variants of

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

li.zhe.hua added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1570 + if (Policy.IgnoreElaboratedQualifiers) { +printBefore(T->getNamedType(), OS); aaron.ballman wrote: > So, effectively, the idea here is: you want the ability to skip

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

li.zhe.hua updated this revision to Diff 526128. li.zhe.hua added a comment. Switch option name to SuppressElaboration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149677/new/ https://reviews.llvm.org/D149677 Files:

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

rjmccall added a comment. Yeah, I agree with Eli, there should be a cast here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 ___ cfe-commits mailing list

[PATCH] D151051: [clang-tidy] Optimize misc-confusable-identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a84c635f2a1: [clang-tidy] Optimize misc-confusable-identifiers (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151051/new/

[clang-tools-extra] 2a84c63 - [clang-tidy] Optimize misc-confusable-identifiers

Author: Piotr Zegar Date: 2023-05-26T17:46:13Z New Revision: 2a84c635f2a1dcb4546a5d751a32eac24103c7e6 URL: https://github.com/llvm/llvm-project/commit/2a84c635f2a1dcb4546a5d751a32eac24103c7e6 DIFF: https://github.com/llvm/llvm-project/commit/2a84c635f2a1dcb4546a5d751a32eac24103c7e6.diff LOG:

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by @efriedma in: https://reviews.llvm.org/D76096#4370369 Some minor code style fixes as well

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

efriedma added a comment. Relevant bit of the AST: `-ExprWithCleanups 0xd16a780 'void':'void' `-CXXOperatorCallExpr 0xd16a678 'void':'void' '()' |-ImplicitCastExpr 0xd16a5a8 'void (*)(int (&&)[]) const' | `-DeclRefExpr 0xd16a528 'void (int (&&)[]) const' lvalue CXXMethod

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 526117. electriclilies added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

[PATCH] D151517: Fix wrong error message when compiling C souce code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacb1b4fbb793: Fix wrong error message when compiling C souce code: (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] acb1b4f - Fix wrong error message when compiling C souce code:

Author: Jennifer Yu Date: 2023-05-26T10:14:52-07:00 New Revision: acb1b4fbb7939faa369337b9b26b960fdc91e4b8 URL: https://github.com/llvm/llvm-project/commit/acb1b4fbb7939faa369337b9b26b960fdc91e4b8 DIFF: https://github.com/llvm/llvm-project/commit/acb1b4fbb7939faa369337b9b26b960fdc91e4b8.diff

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 526115. electriclilies added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

rnk added subscribers: efriedma, rjmccall, rnk. rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4376 +.getTypePtr() +->getPointeeOrArrayElementType(); + const Type *CanonicalArgTy =

  1   2   >