[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

2023-05-27 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik added a comment. If anybody has a better name for this I'm all ears. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ https://reviews.llvm.org/D151625 ___ cfe-commits mailing list

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

2023-05-27 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added a subscriber: dschuff. Herald added a project: All. philnik requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This attribute is

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

2023-05-27 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows types to be considered trivially equality comparable if a

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

2023-05-27 Thread SR_team via Phabricator via cfe-commits
SR_team added a comment. @sammccall review my code please CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151128/new/ https://reviews.llvm.org/D151128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

2023-05-27 Thread R4444 via Phabricator via cfe-commits
Ruturaj4 updated this revision to Diff 526296. Ruturaj4 added a comment. 1. Updating D151048 : [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset. # 2. Enter a brief description of the changes included in this

[PATCH] D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

2023-05-27 Thread R4444 via Phabricator via cfe-commits
Ruturaj4 marked 3 inline comments as done. Ruturaj4 added a comment. Daniel, I made all the changes as you desired, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151048/new/ https://reviews.llvm.org/D151048

[PATCH] D151620: [clang-repl] Fix REPL_EXTERNAL_VISIBILITY and building libclang-cpp.dll for MinGW configurations

2023-05-27 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: junaire, alvinhochun, mati865. Herald added a project: All. mstorsjo requested review of this revision. Herald added a subscriber: bd1976llvm. Herald added a project: clang. This fixes two issues that are observed after

[clang] bdc2771 - [StaticAnalyzer] Remove unused declaration handleLVectorSplat

2023-05-27 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-27T14:53:54-07:00 New Revision: bdc2771911cb181fe014480b4c19d94ff52e URL: https://github.com/llvm/llvm-project/commit/bdc2771911cb181fe014480b4c19d94ff52e DIFF: https://github.com/llvm/llvm-project/commit/bdc2771911cb181fe014480b4c19d94ff52e.diff

[clang] 156aafd - [StaticAnalyzer] Remove unused declaration findDirectConstructorForCurrentCFGElement

2023-05-27 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-27T14:53:53-07:00 New Revision: 156aafd0ed12792a4abef8f3f5374f195fe3387d URL: https://github.com/llvm/llvm-project/commit/156aafd0ed12792a4abef8f3f5374f195fe3387d DIFF: https://github.com/llvm/llvm-project/commit/156aafd0ed12792a4abef8f3f5374f195fe3387d.diff

[clang] 78b72d6 - [StaticAnalyzer] Remove unused declaration evalLoadCommon

2023-05-27 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-27T14:53:51-07:00 New Revision: 78b72d695ff8b61edfaec82a7d3ac8d5d52bc3bd URL: https://github.com/llvm/llvm-project/commit/78b72d695ff8b61edfaec82a7d3ac8d5d52bc3bd DIFF: https://github.com/llvm/llvm-project/commit/78b72d695ff8b61edfaec82a7d3ac8d5d52bc3bd.diff

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny accepted this revision. jdenny added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) {

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { jdenny wrote: >

[clang] fffb389 - [Analysis] Remove unused declaration getCurrentLVarDefinition

2023-05-27 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-27T10:45:18-07:00 New Revision: fffb389c8b2ff29a7a05fd17addf23a50005b057 URL: https://github.com/llvm/llvm-project/commit/fffb389c8b2ff29a7a05fd17addf23a50005b057 DIFF: https://github.com/llvm/llvm-project/commit/fffb389c8b2ff29a7a05fd17addf23a50005b057.diff

[clang] 7954368 - [Serialization] Remove unused declaration SLocCursorForID

2023-05-27 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-27T10:45:17-07:00 New Revision: 795436889dce9a314dc7e18476d0f5f2fc68482c URL: https://github.com/llvm/llvm-project/commit/795436889dce9a314dc7e18476d0f5f2fc68482c DIFF: https://github.com/llvm/llvm-project/commit/795436889dce9a314dc7e18476d0f5f2fc68482c.diff

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 526277. Endill added a comment. Replace A2 test with E1-E3 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files:

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

2023-05-27 Thread Kazu Hirata via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe396c375a108: [AST] Remove unused function removeLocalCVRQualifiers (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e396c37 - [AST] Remove unused function removeLocalCVRQualifiers

2023-05-27 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-27T10:29:23-07:00 New Revision: e396c375a108f9be491488b876ac57e889f5c752 URL: https://github.com/llvm/llvm-project/commit/e396c375a108f9be491488b876ac57e889f5c752 DIFF: https://github.com/llvm/llvm-project/commit/e396c375a108f9be491488b876ac57e889f5c752.diff

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { Endill wrote: >

[PATCH] D151480: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::​GetConstantArrayFromStringLiteral()

2023-05-27 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf59795b2b703: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151480/new/

[clang] f59795b - [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::GetConstantArrayFromStringLiteral()

2023-05-27 Thread via cfe-commits
Author: Manna, Soumi Date: 2023-05-27T07:16:31-07:00 New Revision: f59795b2b703d5a782e4c29c0e786ee01942f16a URL: https://github.com/llvm/llvm-project/commit/f59795b2b703d5a782e4c29c0e786ee01942f16a DIFF: https://github.com/llvm/llvm-project/commit/f59795b2b703d5a782e4c29c0e786ee01942f16a.diff

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

2023-05-27 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 526264. Manna added a comment. Fix clang-format error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/ https://reviews.llvm.org/D151469 Files: clang/lib/AST/ExprConstant.cpp Index: clang/lib/AST/ExprConstant.cpp

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

2023-05-27 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 526263. yaxunl added a comment. using ISA version to determine whether image is supported CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151349/new/ https://reviews.llvm.org/D151349 Files: clang/include/clang/Basic/TargetInfo.h

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

2023-05-27 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 526258. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150985/new/ https://reviews.llvm.org/D150985 Files:

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

2023-05-27 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 526259. Manna added a comment. I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151606/new/ https://reviews.llvm.org/D151606 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp Index: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D146809: [clang-repl] Implement Value pretty printing

2023-05-27 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 526256. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

2023-05-27 Thread Mark de Wever via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGcbaa3597aaf6: Reland [CMake] Bumps minimum version to 3.20.0. (authored by

[libclc] cbaa359 - Reland "[CMake] Bumps minimum version to 3.20.0.

2023-05-27 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2023-05-27T12:51:21+02:00 New Revision: cbaa3597aaf6273e66b3f445ed36a6458143fe6a URL: https://github.com/llvm/llvm-project/commit/cbaa3597aaf6273e66b3f445ed36a6458143fe6a DIFF: https://github.com/llvm/llvm-project/commit/cbaa3597aaf6273e66b3f445ed36a6458143fe6a.diff

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

2023-05-27 Thread Mark de Wever via Phabricator via cfe-commits
Mordante accepted this revision. Mordante marked 3 inline comments as done. Mordante added a comment. In D151344#4368926 , @MaskRay wrote: > Thank you for making another try for the treewide change (which is admittedly > very painful and not many people

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

2023-05-27 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151607/new/ https://reviews.llvm.org/D151607

[PATCH] D151610: [Docs] Fix Sphinx documentation formatting issues in LanguageExtensions.rst

2023-05-27 Thread Phoebe Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd2e681612f1: [Docs] Fix Sphinx documentation formatting issues in LanguageExtensions.rst (authored by codemzs, committed by pengfei). Changed

[clang] dd2e681 - [Docs] Fix Sphinx documentation formatting issues in LanguageExtensions.rst

2023-05-27 Thread Phoebe Wang via cfe-commits
Author: M. Zeeshan Siddiqui Date: 2023-05-27T16:45:21+08:00 New Revision: dd2e681612f1f09d92abc9e16f5f65293e3fe725 URL: https://github.com/llvm/llvm-project/commit/dd2e681612f1f09d92abc9e16f5f65293e3fe725 DIFF:

[PATCH] D151610: [Docs] Fix Sphinx documentation formatting issues in LanguageExtensions.rst

2023-05-27 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151610/new/ https://reviews.llvm.org/D151610 ___ cfe-commits mailing list

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

2023-05-27 Thread Anubhab Ghosh via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGddeab07ca632: [clang-repl][CUDA] Re-land: Initial interactive CUDA support for clang-repl (authored by argentite). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ddeab07 - [clang-repl][CUDA] Re-land: Initial interactive CUDA support for clang-repl

2023-05-27 Thread Anubhab Ghosh via cfe-commits
Author: Anubhab Ghosh Date: 2023-05-27T13:54:42+05:30 New Revision: ddeab07ca63235f8d952e1171b56fdb0f2d761c9 URL: https://github.com/llvm/llvm-project/commit/ddeab07ca63235f8d952e1171b56fdb0f2d761c9 DIFF: https://github.com/llvm/llvm-project/commit/ddeab07ca63235f8d952e1171b56fdb0f2d761c9.diff

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2023-05-27 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. Herald added subscribers: bviyer, asb. @nhaehnle, I wanted to check in briefly if you are getting the same error messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.org/D138278

[PATCH] D151610: [Docs] Fix Sphinx documentation formatting issues in LanguageExtensions.rst

2023-05-27 Thread M. Zeeshan Siddiqui via Phabricator via cfe-commits
codemzs updated this revision to Diff 526246. codemzs retitled this revision from "[Docs] Fix formatting issues in LanguageExtensions.rst" to "[Docs] Fix Sphinx documentation formatting issues in LanguageExtensions.rst". codemzs edited the summary of this revision. codemzs added a reviewer:

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

2023-05-27 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 526245. HerrCai0907 added a comment. add cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D151610: [Docs] Fix formatting issues in LanguageExtensions.rst

2023-05-27 Thread M. Zeeshan Siddiqui via Phabricator via cfe-commits
codemzs created this revision. codemzs added a reviewer: pengfei. Herald added a project: All. codemzs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Missing indentation. Repository: rG LLVM Github Monorepo

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. Thank you for your time! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) {