[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. lgtm with nit Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:280 +} else { + auto AllocSize = M->getDataLayout().getTypeAllocSize(Args[i]->getType()); +

[PATCH] D152548: [Clang][Interp] Diagnose uninitialized ctor of global record arrays

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch adds a check for uninitialized subobjects of global variables that are record arrays.

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

ManuelJBrito created this revision. ManuelJBrito added reviewers: zixuan-wu, erichkeane. Herald added a subscriber: mgrang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Drop alignment to allow

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dblaikie added a comment. When we migrated to github we gained higher fidelity for attributing authors (we can now commit on someone's behalf but have the commit author properly recorded as the real author - we couldn't do that back on Subversion) - but I think it's meant that fail-mail from

[PATCH] D152447: [Clang] Remove -no-opaque-pointers cc1 flag

dblaikie added subscribers: t.p.northover, dblaikie. dblaikie added a comment. (I hope this doesn't come off as condescending/patronizing, I mean it quite genuinely) A deep thanks to everyone who worked on this, especially @aeubanks and @nikic, and @t.p.northover - it's been a long project and

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added inline comments. Comment at: clang/test/CodeGen/builtins-nondeterministic-value.c:26 +// CHECK-LABEL: entry +// CHECK: [[A:%.*]] = alloca double, align 8 +// CHECK: store double [[X:%.*]], ptr [[A]], align 8 zixuan-wu wrote: > hi,

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

MyDeveloperDay added a comment. In D152443#4407438 , @KitsuneAlex wrote: > I had some issues with Git there because i messed up a merge, so the diff was > bad. Here's the proper diff. > NOTE: Clang-Format Team Automated Review Comment keep you

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4709 + +**SpaceAfterOperatorKeyword** (``Boolean``) :versionbadge:`clang-format 17` :ref:`¶ ` + If ``true``, a space will be inserted after the 'operator' keyword. could

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. In D150226#4408563 , @erichkeane wrote: > In D150226#4408381 , @aaron.ballman > wrote: > >> In D150226#4404808 , @rupprecht >> wrote: >> >>>

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(),

[PATCH] D152473: [clang-format] Add test case for issue 63170

MyDeveloperDay added a comment. I presume the test fail, we don't check in tests that just fail without a fix, or the build would be stale. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152473/new/ https://reviews.llvm.org/D152473

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 529976. JOE1994 added a comment. - Update uses of `PointerType::get(Ty)` & `PointerType::getUnqual` to be in overloaded form of `PointerType::get` that takes LLVMContext& - Remove more unnecessary bitcasts which were previously overlooked. - Remove pointee

[PATCH] D150358: [clang][Interp] Remove args from called functions in more cases

tbaeder added a subscriber: MaskRay. tbaeder added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:262 +namespace CallWithArgs { + /// This used to call problems during checkPotentialConstantExpression() runs. + constexpr void g(int a) {}

[PATCH] D152522: [NFC][SetVector] Update some usages of SetVector to SmallSetVector

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152522/new/ https://reviews.llvm.org/D152522 ___

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

tbaeder added a comment. As far as the fixit goes, I guess the previous version was better, since it didn't leave an empty line behind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152525/new/ https://reviews.llvm.org/D152525

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Yes, FWIW I looked into this again last week and noticed a few unsolved problems as well. I'll post a comment once I consider it ready for actual review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo updated this revision to Diff 529974. VitaNuo added a comment. Remove unrelated formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152542/new/ https://reviews.llvm.org/D152542 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

MaskRay added a comment. I'll make `-munaligned-access` `TargetSpecific` (D151590 ) to report errors for unsupported targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. In D152473#4407832 , @owenpan wrote: > Can you add the test to clang/unittests/Format/FormatTest.cpp instead? Please > also include the full diff. See >

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

MaskRay added a comment. > [1]: > https://github.com/torvalds/linux/blob/master/arch/loongarch/include/asm/cpu.h#L77 > [2]: > https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/proc.c#L75 `master` will point to different commits. It'd be better to use a specific commit for

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. In D152436#4408301 , @steakhal wrote: > In D152436#4405558 , @balazske > wrote: > >> These are reports that could be improved: >> link >>

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4407934 , @t.p.northover wrote: > I don't think this handles the no-personality case properly. For example this > code leads to a DWARF entry now: > > void bar(int *) noexcept; > void foo() { > int arr; >

[PATCH] D150661: [clang][Interp] Allow evaluating standalone composite expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should change the summary to `Allow evaluating standalone complex expressions` when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150661/new/

[PATCH] D149133: [clang][Interp] BaseToDerived casts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149133/new/ https://reviews.llvm.org/D149133 ___ cfe-commits mailing

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Making it clear that there's more work here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

aaron.ballman added a comment. There's still quite a few unaddressed comments, FWIW. Comment at: clang/lib/AST/Interp/Boolean.h:113 + + void bitcastToMemory(std::byte *Buff) { std::memcpy(Buff, , sizeof(V)); } + CHANGES SINCE LAST ACTION

[PATCH] D150358: [clang][Interp] Remove args from called functions in more cases

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/functions.cpp:262 +namespace CallWithArgs { + /// This used to call problems during checkPotentialConstantExpression()

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7fbc9de45536: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (authored by MineGame159, committed by aaron.ballman). Repository: rG

[clang] 7fbc9de - [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind

Author: MineGame159 Date: 2023-06-09T10:01:43-04:00 New Revision: 7fbc9de4553666a189b0529ca04e1d9966c0d4f8 URL: https://github.com/llvm/llvm-project/commit/7fbc9de4553666a189b0529ca04e1d9966c0d4f8 DIFF: https://github.com/llvm/llvm-project/commit/7fbc9de4553666a189b0529ca04e1d9966c0d4f8.diff

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 added a comment. In D150910#4408585 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like me to use for patch attribution? Yeah, this is my first contribution, thanks.

[clang] 644917b - Remove unnecessary metadata check in test

Author: Akira Hatanaka Date: 2023-06-09T06:41:22-07:00 New Revision: 644917bb7c05d330b3dfa75ccd50414f9b9cd8ee URL: https://github.com/llvm/llvm-project/commit/644917bb7c05d330b3dfa75ccd50414f9b9cd8ee DIFF:

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

sebastian-ne added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:15 + else() +string(REGEX MATCH "^[0-9]+" CLANG_VERSION_MAJOR ${PACKAGE_VERSION}) +set(ret_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION_MAJOR}) This fails in

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D150226#4408381 , @aaron.ballman wrote: > In D150226#4404808 , @rupprecht > wrote: > >> I suppose including this warning in `ShowInSystemHeader` with your diff >> above would be

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 updated this revision to Diff 529938. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150910/new/ https://reviews.llvm.org/D150910 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h clang/include/clang/AST/OperationKinds.def

[PATCH] D152207: [HIP] Instruct lld to go through all archives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1aee32f1c85: [HIP] Instruct lld to go through all archives (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f1aee32 - [HIP] Instruct lld to go through all archives

Author: Siu Chi Chan Date: 2023-06-09T08:50:44-04:00 New Revision: f1aee32f1c85aa476bce70ec110284011c6df354 URL: https://github.com/llvm/llvm-project/commit/f1aee32f1c85aa476bce70ec110284011c6df354 DIFF: https://github.com/llvm/llvm-project/commit/f1aee32f1c85aa476bce70ec110284011c6df354.diff

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

hassnaa-arm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9633-9635 +bool IsSVCount = isa(Ops[0]->getType()); +assert(((!IsSVCount || cast(Ops[0]->getType())->getName() == + "aarch64.svcount")) &&

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, cjdb. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that we print >1 line of code snippet, we printed another line of

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

aaron.ballman added a comment. In D150910#4406296 , @MineGame159 wrote: > I have added the new functions into the file and now it successfully compiles > the test. (but fails when running it - EDIT: guess I broke my dev env somehow) > > Also checked

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D150226#4404808 , @rupprecht wrote: > I suppose including this warning in `ShowInSystemHeader` with your diff above > would be a good first step anyway, right? If we're about to make it a hard > error anyway, then

[PATCH] D152522: [NFC][SetVector] Update some usages of SetVector to SmallSetVector

0xdc03 created this revision. 0xdc03 added a reviewer: nikic. Herald added subscribers: ChuanqiXu, StephenFan, haicheng, hiraditya, MatzeB. Herald added a project: All. 0xdc03 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D152520: [clangd] Unify printing policy for type hints

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. (This

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

steakhal added a comment. In D152436#4405558 , @balazske wrote: > These are reports that could be improved: > link >

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 529906. BeMg added a comment. 1. Update testcase 2. Remove supportsMultiVersioning for RISCV Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files:

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. Looks like the latest reland of this patch broke some debug-info `cross-project-tests` on the Arm64 macOS buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-as/263/execution/node/54/log/ Failed Tests (2): cross-project-tests ::

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

Szelethus added a comment. > I am not sure about the exact requirements, this review can be a place for > discussion about what should be fixed (if any). D52984 added the "Making your checker better" section to the dev manual:

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

kadircet added a comment. thanks, mostly LG. I think we need to be a little careful when generating insertions for all the missing includes though. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:169 -std::vector generateMissingIncludeDiagnostics( +using

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

tbaeder added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2852 - "Should not use decl without marking it used!"); - if (ND->hasAttr()) { Question for other reviewers: If we want to keep this assertion, would it instead make sense to

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b0ea4874093: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8b0ea48 - [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

Author: Alexander Shaposhnikov Date: 2023-06-09T09:27:01Z New Revision: 8b0ea48740935d819618d8254fc45d98179b672c URL: https://github.com/llvm/llvm-project/commit/8b0ea48740935d819618d8254fc45d98179b672c DIFF:

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 529865. vikramRH added a comment. Handled last set of review comments from @arsenm, would be willing to handle any new findings/concerns via additional patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] dcbbdbe - [NFC] remove duplciated unittests for modules

Author: Chuanqi Xu Date: 2023-06-09T17:19:32+08:00 New Revision: dcbbdbe3e50214b550383510ba05d059dc38496a URL: https://github.com/llvm/llvm-project/commit/dcbbdbe3e50214b550383510ba05d059dc38496a DIFF: https://github.com/llvm/llvm-project/commit/dcbbdbe3e50214b550383510ba05d059dc38496a.diff

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains added a comment. about the comments that the patch seems to do multiple things; I do not think we can fix the lookup without touching the typo-fixes since it uses the same underlying machinery - if we do not adjust the typo fixes, we will regress diagnostics. Repository: rG LLVM

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

t.p.northover added a comment. I don't think this handles the no-personality case properly. For example this code leads to a DWARF entry now: void bar(int *) noexcept; void foo() { int arr; bar(); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143587: [Docs] Multilib design

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/docs/Multilib.rst:231 + +However, an exception is the normalization of -march. +-march for Arm architectures contains a list of enabled and disabled extensions Use backticks to

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains updated this revision to Diff 529852. iains marked 2 inline comments as done. iains added a comment. rebased and adjusted for upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 Files:

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder created this revision. tbaeder added reviewers: NoQ, aaron.ballman, krememek, dergachev.a, MikeStump. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a declaration has a cleanup function

[PATCH] D152418: [clang] set python3 as required build dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG96962d5512fb: [clang] set python3 as required build dependency (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152418/new/

[clang] 96962d5 - [clang] set python3 as required build dependency

Author: Petr Hosek Date: 2023-06-09T07:52:48Z New Revision: 96962d5512fbc6af0ada0f13e6be332c026529cb URL: https://github.com/llvm/llvm-project/commit/96962d5512fbc6af0ada0f13e6be332c026529cb DIFF: https://github.com/llvm/llvm-project/commit/96962d5512fbc6af0ada0f13e6be332c026529cb.diff LOG:

[clang] 2c44168 - [Clang] Remove typed pointer consistency assertions (NFC)

Author: Nikita Popov Date: 2023-06-09T09:45:43+02:00 New Revision: 2c44168381f0b06eb629cd093510a9fca6913066 URL: https://github.com/llvm/llvm-project/commit/2c44168381f0b06eb629cd093510a9fca6913066 DIFF: https://github.com/llvm/llvm-project/commit/2c44168381f0b06eb629cd093510a9fca6913066.diff

[PATCH] D152473: [clang-format] Add test case for issue 63170

owenpan added a comment. Can you add the test to clang/unittests/Format/FormatTest.cpp instead? Please also include the full diff. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder updated this revision to Diff 529832. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

<    1   2