[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 added a comment. In D152882#4421138 , @yaxunl wrote: > The design of target ID put constraints on target ID's that can be embedded > into one executable > https://clang.llvm.org/docs/ClangOffloadBundler.html#bundle-entry-id . For > example, gfx

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 531435. akhuang added a comment. Call GenerateCode to emit __impl function body Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/clang/CodeGen/C

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:3097 + FD->getLocation(), FD->getLocation()); +CGF.EmitFunctionBody(FD->getBody()); +CGF.FinishFunction(); efriedma wrote: > Is there any way we can use Generate

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge added a comment. Thank you Sam for the suggested performance improvements, and outlining a way forward. @qchateau, are you interested in updating the patch to implement some of the described optimizations / address other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2479-2486 +template struct Bitfield { + static constexpr T max = static_cast((1 << size) - 1); +}; + +void testValueInRangeOfEnumerationValuesViaTemplate() { + Bitfield good; + Bitfield bad

[PATCH] D152500: [clangd] Unwrap type sugar in HeuristicResolver::resolveTypeToRecordDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rG19c9af81b1c5: [clangd] Unwrap type sugar in HeuristicResolver::resolveTypeToRecordDecl() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 19c9af8 - [clangd] Unwrap type sugar in HeuristicResolver::resolveTypeToRecordDecl()

Author: Nathan Ridge Date: 2023-06-14T13:51:00-04:00 New Revision: 19c9af81b1c5dd7b3d11d235a77b7181b9368a28 URL: https://github.com/llvm/llvm-project/commit/19c9af81b1c5dd7b3d11d235a77b7181b9368a28 DIFF: https://github.com/llvm/llvm-project/commit/19c9af81b1c5dd7b3d11d235a77b7181b9368a28.diff

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

rnk added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:3727 +SmallVector Bases; +for (auto Base: Info.CXXInfo->BaseOffsets) { + Bases.push_back(Base.second.getQuantity()); Rather than iterating the map and sorting afterwards, IM

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4421624 , @steven_wu wrote: > `lld` does not use LTOCodeGenerator. > > I am also not sure how disable integrated assembler suppose to work? Do you > have an end to end design for how to invoke assembler during linki

[PATCH] D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

rZhBoYao added a comment. > Looks like this breaks check-clang on Mac: > http://45.33.8.238/macm1/62779/step_7.txt Same here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150023/new/ https://reviews.llvm.org/D150023

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:33 static constexpr Builtin::Info BuiltinInfo[] = { -{"not a builtin function", nullptr, nullptr, nullptr, HeaderDesc::NO_HEADER, +#define INTERESTING_IDENTIFIER(ID)

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 531401. TIFitis added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenM

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 531395. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. In D148697#4421643 , @PiotrZSL wrote: > @Dinistro It compiles & links with clang 16 also (shared libs). So I'm unable > to reproduce. I used the following command to build: cmake -S/home/christianu/repos/llvm-project/llvm -

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl updated this revision to Diff 531390. brendandahl marked an inline comment as done. brendandahl added a comment. Review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: clang

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl marked 4 inline comments as done. brendandahl added inline comments. Comment at: lld/test/wasm/custom-undefine.s:17 +.type bar,@function +bar: +.functype bar () -> () dschuff wrote: > I don't fully understand how this test is d

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

jdoerfert added a comment. I think this is now style wise pretty good, I still found some potential problems below. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1487 + // possible, or else at the end of the function. + void emitBlock(BasicBlock *BB, Function

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

ellis planned changes to this revision. ellis added a comment. In D152762#4421630 , @phosek wrote: > This is unrelated to this change but related to the issue this change is > addressing. The use of regular expressions for special case list with the > s

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2479-2486 +template struct Bitfield { + static constexpr T max = static_cast((1 << size) - 1

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. In D148697#4421420 , @PiotrZSL wrote: > In D148697#4421339 , @Dinistro > wrote: > >> In D148697#4421268 , @PiotrZSL >> wrote: >> >>> In D148697

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. @Dinistro It compiles & links with clang 16 also (shared libs). So I'm unable to reproduce. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148697 _

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

phosek added a comment. This is unrelated to this change but related to the issue this change is addressing. The use of regular expressions for special case list with the special handling of `*` is error-prone, I've seen many people having issues it. Furthermore, regular expression for matching

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as`

steven_wu added a comment. `lld` does not use LTOCodeGenerator. I am also not sure how disable integrated assembler suppose to work? Do you have an end to end design for how to invoke assembler during linking? For current libLTO API, this is probably going to produce assembler file buffer to l

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152433/new/ https://reviews.llvm.org/D152433

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. > I don't think it's worth blocking this patch on it, though. What do you think? Agreed, I don't think this is making it worse. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152932: [ARM] Adding precommit tests for D146242

JiruiWu updated this revision to Diff 531373. JiruiWu retitled this revision from "[ARM] Adding precommit tests for D146242." to "[ARM] Adding precommit tests for D146242". JiruiWu added a comment. Updating the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D152932: [ARM] Adding precommit tests for D146242.

JiruiWu created this revision. JiruiWu added reviewers: olista01, simon_tatham, rjmccall, tmatheson, pratlucas. Herald added a subscriber: kristof.beyls. Herald added a project: All. JiruiWu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4421339 , @Dinistro wrote: > In D148697#4421268 , @PiotrZSL > wrote: > >> In D148697#4420359 , @Dinistro >> wrote: >> >>> I'm gettin

[PATCH] D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

thakis added a comment. Looks like this breaks check-clang on Mac: http://45.33.8.238/macm1/62779/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150023/new/ https://revie

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. In D148697#4421268 , @PiotrZSL wrote: > In D148697#4420359 , @Dinistro > wrote: > >> I'm getting a linking error by some of the files changed in this revision. > > You shouldn't because

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4420359 , @Dinistro wrote: > I'm getting a linking error by some of the files changed in this revision. You shouldn't because this library got dependency on clangTidyPerformanceModule. Is this a blocker for you, or yo

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as`

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, shchenz, Esme. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: l

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

bryanpkc updated this revision to Diff 531330. bryanpkc added a comment. Addressed @sdesmalen's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files: clang/include/clang/Basic/arm_sme.td cl

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

yaxunl added a comment. The design of target ID put constraints on target ID's that can be embedded into one executable https://clang.llvm.org/docs/ClangOffloadBundler.html#bundle-entry-id . For example, gfx90a and gfx90a:xnack+ cannot be embedded into one executable since this will cause diff

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

arsenm updated this revision to Diff 531315. arsenm added a comment. Release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152901/new/ https://reviews.llvm.org/D152901 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGenOpen

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h:463 + // exp2, no denormal handling for f32. + EXP, + foad wrote: > Is this used anywhere? Will be in the next patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D152913: [clangd] Use include_cleaner spelling strategies in clangd.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6c7ed5cd8d: [clangd] Use include_cleaner spelling strategies in clangd. (authored by VitaNuo). Repository: rG LLVM Gi

[clang-tools-extra] 6a6c7ed - [clangd] Use include_cleaner spelling strategies in clangd.

Author: Viktoriia Bakalova Date: 2023-06-14T14:06:35Z New Revision: 6a6c7ed5cd8d1a7e0991128e46abfd2b7d95f8e8 URL: https://github.com/llvm/llvm-project/commit/6a6c7ed5cd8d1a7e0991128e46abfd2b7d95f8e8 DIFF: https://github.com/llvm/llvm-project/commit/6a6c7ed5cd8d1a7e0991128e46abfd2b7d95f8e8.diff

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

yaxunl accepted this revision as: yaxunl. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137524/new/ https://reviews.llvm.org/D137524 ___ cfe-commits mailing

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

tejohnson added a comment. In D152741#4419366 , @modimo wrote: > In D152741#4419324 , @tejohnson > wrote: > >> In D152741#4419265 , @modimo wrote: >> >>> In D152741#44188

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

nicolerabjohn added a comment. I've opened an issue (https://github.com/llvm/llvm-project/issues/63063) where we hit the same assertion. There's a smaller test case, and we've done enough investigation that we understand the problem. I'd be happy to discuss over on the issue as well. Reposito

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152707/new/ https://reviews.llvm.org/D152707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

foad added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h:463 + // exp2, no denormal handling for f32. + EXP, + Is this used anywhere? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152901/new/ https://reviews.llvm.org/D15290

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

DavidSpickett added a comment. FYI after this change: Building CXX object tools/lldb/sou...luginTypeSystemClang.dir/TypeSystemClang.cpp.o /home/david.spickett/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4843:13: warning: 225 enumeration values not handled in switc

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1785 + if (static_cast(TM).hasGlibcHWCAPAccess()) +OutStreamer->emitSymbolValue( This probably deserves a comment along the lines of: ``` // Emit a reference to a symbol

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

nemanjai created this revision. nemanjai added reviewers: PowerPC, RKSimon, pengfei, arsenm, t.p.northover. Herald added subscribers: steven.zhang, kbarton, hiraditya. Herald added a project: All. nemanjai requested review of this revision. Herald added subscribers: jdoerfert, wdng. Herald added pr

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:33 static constexpr Builtin::Info BuiltinInfo[] = { -{"not a builtin function", nullptr, nullptr, nullptr, HeaderDesc::NO_HEADER, +#define INTERESTING_IDENTIF

[PATCH] D152913: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

arsenm updated this revision to Diff 531301. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152901/new/ https://reviews.llvm.org/D152901 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGenOpenCL/builtins-amdgcn.cl llvm/docs/AMDGPU

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam accepted this revision. saiislam added a comment. Thank you @animeshk-amd! LGTM! As discussed in the multi-company OpenMP LLVM meeting, this is the right time to upgrade the default OpenMP spec version to 5.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

arsenm updated this revision to Diff 531300. arsenm added a comment. Fix patch split CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152901/new/ https://reviews.llvm.org/D152901 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGenOp

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

aaron.ballman added a comment. In D148700#4418767 , @rsandifo-arm wrote: > Hi @jyknight , @rsmith > > Do you have any more thoughts on the above? Quick version is: > > 1. Is it OK to have `[[…]]` attributes in the `arm` namespace that affect > semantic

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the extra documentation, that is a surprising behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152880/new

[PATCH] D152274: [clang] Don't create import decls without -fmodules

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. The internal state when modules are off but layering check is on is really counterintuitive, and clearly not all configurations have been tested :-( I'm pretty sure this is the right beha

[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8c08f7ae86d: [clang][Sema] Fix diagnostic message for unused constant variable templates (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D152796?vs=530844&id=531293#toc Repo

[clang] b8c08f7 - [clang][Sema] Fix diagnostic message for unused constant variable templates

Author: Takuya Shimizu Date: 2023-06-14T21:43:03+09:00 New Revision: b8c08f7ae86da4723f9e125d5defa5404518d87d URL: https://github.com/llvm/llvm-project/commit/b8c08f7ae86da4723f9e125d5defa5404518d87d DIFF: https://github.com/llvm/llvm-project/commit/b8c08f7ae86da4723f9e125d5defa5404518d87d.diff

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the issue with the release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 __

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo updated this revision to Diff 531275. VitaNuo added a comment. VitaNuo updated this revision to Diff 531278. VitaNuo added a reviewer: kadircet. VitaNuo published this revision for revi

[PATCH] D152856: [Driver] Allow warning for unclaimed TargetSpecific options

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Looks great to me, thanks! (Didn't test it myself yet though.) Just one small nit. Comment at: llvm/include/llvm/Option/Arg.h:53 + /// This is used for generating an "a

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

arsenm created this revision. arsenm added reviewers: AMDGPU, foad, rampitec, yaxunl, Pierre-vh, cdevadas. Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber:

[clang] 20e81a8 - Update with warning message for comparison to NULL pointer

Author: Krishna Narayanan Date: 2023-06-14T08:28:35-04:00 New Revision: 20e81a80e9cb6403f850ab981438f3d9d88b5a4b URL: https://github.com/llvm/llvm-project/commit/20e81a80e9cb6403f850ab981438f3d9d88b5a4b DIFF: https://github.com/llvm/llvm-project/commit/20e81a80e9cb6403f850ab981438f3d9d88b5a4b.d

[PATCH] D149000: Update with warning message for comparison to NULL pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG20e81a80e9cb: Update with warning message for comparison to NULL pointer (authored by Krishna-13-cyber, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D149000?vs=531243&i

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 marked an inline comment as done. AMS21 added a comment. If there are no more problems, I would kindly ask for someone to push this on my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152852/new/ https://reviews.llvm.org/D152852 _

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 updated this revision to Diff 531274. AMS21 added a comment. Use dyn_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152852/new/ https://reviews.llvm.org/D152852 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp clang

[clang] 7e20e13 - [docs] Add missing label

Author: Simon Pilgrim Date: 2023-06-14T13:08:07+01:00 New Revision: 7e20e13dd88bb9f2d7665186d97632846e566304 URL: https://github.com/llvm/llvm-project/commit/7e20e13dd88bb9f2d7665186d97632846e566304 DIFF: https://github.com/llvm/llvm-project/commit/7e20e13dd88bb9f2d7665186d97632846e566304.diff

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet updated this revision to Diff 531266. hazohelet added a comment. Added an additional null check that I mentioned earlier CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152707/new/ https://reviews.llvm.org/D152707 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaDecl.cpp

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber added a comment. In D149000#4420607 , @aaron.ballman wrote: > LGTM! There's still a formatting issue in warn-tautological-compare.c but I > can fix that up when landing, assuming you still need me to land this on your > behalf. (If you

[clang] 00b1dd8 - [docs] Add missing empty line at start of code-block

Author: Simon Pilgrim Date: 2023-06-14T12:49:07+01:00 New Revision: 00b1dd82d72f4000c26c28e1471128569255dadc URL: https://github.com/llvm/llvm-project/commit/00b1dd82d72f4000c26c28e1471128569255dadc DIFF: https://github.com/llvm/llvm-project/commit/00b1dd82d72f4000c26c28e1471128569255dadc.diff

[clang-tools-extra] ffd7a20 - [clang-tidy] Fix build bot break after 474a2b9367ad

Author: Nemanja Ivanovic Date: 2023-06-14T06:47:34-05:00 New Revision: ffd7a200fdfbd01ef296101647d2f2da91ddfd41 URL: https://github.com/llvm/llvm-project/commit/ffd7a200fdfbd01ef296101647d2f2da91ddfd41 DIFF: https://github.com/llvm/llvm-project/commit/ffd7a200fdfbd01ef296101647d2f2da91ddfd41.di

[PATCH] D149000: Update with warning message for comparison to NULL pointer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! There's still a formatting issue in warn-tautological-compare.c but I can fix that up when landing, assuming you still need me to land this on your behalf. (If you can land

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1386 +if (const auto *VTSD = dyn_cast(DiagD)) + DiagRange.setEnd(VTSD->getTemplateArgsInfo()->RAngleLoc); if (DiagD->isReferenced()) { It looks like `VarTemplateSpecial

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. In D152813#4420471 , @gribozavr2 wrote: > In D152813#4420448 , @mboehme wrote: > >> We would expect analysis of this code to converge too -- right? > > Yes - but we might need universal t

[clang] bf449be - [docs] Add missing empty line before lists

Author: Simon Pilgrim Date: 2023-06-14T11:42:09+01:00 New Revision: bf449be9677bf9fd8c591512cfba152250170432 URL: https://github.com/llvm/llvm-project/commit/bf449be9677bf9fd8c591512cfba152250170432 DIFF: https://github.com/llvm/llvm-project/commit/bf449be9677bf9fd8c591512cfba152250170432.diff

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. @nikic Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

gribozavr2 added a comment. In D152813#4420448 , @mboehme wrote: > We would expect analysis of this code to converge too -- right? Yes - but we might need universal top values for that? maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added inline comments. Comment at: clang/test/Modules/crash-vfs-umbrella-frameworks.m:13 // RUN: env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \ -// RUN: not %clang -nostdinc -fsyntax-only %s \ +// RUN: not --crash %clang -nostdinc -fsyntax-only %s \

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 updated this revision to Diff 531245. jansvoboda11 marked 3 inline comments as done. jansvoboda11 added a comment. Remove accidental diff with `--crash` in test, add file header, continue being defensive in `CXLoadedDiagnostic.cpp`. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. In D152813#4420445 , @gribozavr2 wrote: > In D152813#4420399 , @mboehme wrote: > >> It looks to me as if the values we're now newly producing for integer >> literals are causing non-conv

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

gribozavr2 added a comment. In D152813#4420399 , @mboehme wrote: > It looks to me as if the values we're now newly producing for integer > literals are causing non-convergence of the analysis on the for-loop. For integer literals specifically, we should

[PATCH] D149248: [RISCV][MC] MC layer support for the experimental zacas extension

asb updated this revision to Diff 531244. asb added a comment. Rebase and ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149248/new/ https://reviews.llvm.org/D149248 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 531243. Krishna-13-cyber removed a reviewer: Quuxplusone. Krishna-13-cyber added a comment. - Update with the given suggestion - Add release notes Thanks a lot @aaron.ballman for the instant assistance. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152747: [include-cleaner] Traverse implicit template instantations if the templates are inside the main file.

ilya-biryukov added a comment. Though I'm not a reviewer, I was looking through the emails and found this change interesting. This is not intended to block the review in any way, just trying to get a picture of the direction include-cleaner is taking. Is this a digression from the initial idea

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 added a comment. In D151855#4403934 , @jansvoboda11 wrote: > In D151855#4403879 , @benlangmuir > wrote: > >>> I think it should be fine to allow dropping the >>> A.framework/Frameworks/B.framework

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. Pre-merge check failures are in a test for the unchecked-optional-access check clang-tidy. The test that's failing is the following from unchecked-optional-access.cpp: c++ void multiple_unchecked_accesses(absl::optional opt1, absl:

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks fine. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:545-547 +if (isa(AliasDecl->getSingleDecl())) { + const auto *AliasDe

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1764 + if (ICA.processFunction(F)) +Changed.insert(F); + } Do we actually need to add the function to the changed list here? We aren't modifying the function

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. I'm getting a linking error by some of the files changed in this revision. ld.lld: error: undefined symbol: vtable for clang::tidy::performance::NoexceptDestructorCheck >>> referenced by NoexceptDestructorCheck.h:26 (/home/christianu/repos/llvm-project/clang-tools-

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: llvm/lib/Transforms/Utils/InferCallsiteAttrs.cpp:597 + // callsite violating the constraint. + if (checkCallerDoesNotAccessMemory() && !CB->doesNotAccessMemory()) { +// Wait until we know we actually need it to do potentially

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 531233. goldstein.w.n added a comment. Remove unused check count. Use memory effects directly instead of function/callbase attribute API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://r

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

owenpan added a comment. I got something that looks promising: diff --git a/clang/lib/Format/FormatToken.h b/clang/lib/Format/FormatToken.h index dd23bd35411d..bba030238338 100644 --- a/clang/lib/Format/FormatToken.h +++ b/clang/lib/Format/FormatToken.h @@ -418,6 +418,12 @@ public:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1686 -/// [C++17] Only used by CXXDeductionGuideDecl. Indicates that -/// the Deduction Guide is the implicitly generated 'copy -/// deduction candidate' (is used during overload resoluti

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

asb added a comment. In D152279#4415974 , @MaskRay wrote: > However, RISC-V `-msmall-data-limit=` is probably a case warranting a > difference. > The global pointer relaxation has a very limited value (benchmarked by > multiple parties, including a part

[PATCH] D152867: OpenMP: Add a new test for constantexpr evaluation of math headers

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152867/new/ https://reviews.llvm.org/D152867 ___ cfe-commits maili

[clang] 0211a75 - [Clang] Rename getElementBitCast() -> withElementType() (NFC)

Author: Nikita Popov Date: 2023-06-14T09:58:52+02:00 New Revision: 0211a75ed8b80848af7c87d2f925467448ae4f34 URL: https://github.com/llvm/llvm-project/commit/0211a75ed8b80848af7c87d2f925467448ae4f34 DIFF: https://github.com/llvm/llvm-project/commit/0211a75ed8b80848af7c87d2f925467448ae4f34.diff

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 531219. HaohaiWen added a comment. Fix sections binding check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

MyDeveloperDay added a comment. So whilst this solves the unit tests (and the golden.h issue) that were added it DOESN'T solve the overlapping replacements that was the original bug. struct foo { void test() { #if 1 #else #endif } #if 1 private: #endif }; T

[clang] 01b6f06 - Fix test Driver/mips-mti-linux.c

Author: Michael Platings Date: 2023-06-14T08:30:03+01:00 New Revision: 01b6f06263dd0a3db61c1bf0e6a3464c7cbd7ea2 URL: https://github.com/llvm/llvm-project/commit/01b6f06263dd0a3db61c1bf0e6a3464c7cbd7ea2 DIFF: https://github.com/llvm/llvm-project/commit/01b6f06263dd0a3db61c1bf0e6a3464c7cbd7ea2.di

[PATCH] D152079: [11/11][Clang][RISCV] Expand all variants for vset on tuple types

This revision was automatically updated to reflect the committed changes. Closed by commit rG804306b38215: [11/11][Clang][RISCV] Expand all variants for vset on tuple types (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152079/new

[PATCH] D152078: [10/11][Clang][RISCV] Expand all variants for vget on tuple types

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1b6b893ed57: [10/11][Clang][RISCV] Expand all variants for vget on tuple types (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152078/new

[PATCH] D152076: [8/11][Clang][RISCV] Expand all variants for indexed strided segment load

This revision was automatically updated to reflect the committed changes. Closed by commit rG9588b18969a2: [8/11][Clang][RISCV] Expand all variants for indexed strided segment load (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

<    1   2   3   >