[PATCH] D152879: [1/2][RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 531690. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

2023-06-15 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. 28f3edd2be2a27b9dc7739d137147007c5fd9e41 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152901/new/ https://reviews.llvm.org/D152901

[clang] 28f3edd - AMDGPU: Add llvm.amdgcn.exp2 intrinsic

2023-06-15 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2023-06-15T07:00:07-04:00 New Revision: 28f3edd2be2a27b9dc7739d137147007c5fd9e41 URL: https://github.com/llvm/llvm-project/commit/28f3edd2be2a27b9dc7739d137147007c5fd9e41 DIFF:

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 531689. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

2023-06-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Is the comment here relevant? https://discourse.llvm.org/t/interleaving-several-c-style-comments-in-the-same-inline-assembly-line/71353/8 Does this patch do that already? Also is it a problem that the ignored

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 531687. eopXD added a comment. Recover, the previous update should happen under D151396 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 531686. eopXD added a comment. Remove `let hasSideEffects = 0;` under VPseudoBinaryNoMaskRoundingMode, VPseudoBinaryNoMaskTURoundingMode, and VPseudoBinaryMaskPolicyRoundingMode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

2023-06-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D153003#4424004 , @Hahnfeld wrote: > In D153003#4423926 , @ChuanqiXu > wrote: > >> This looks not so good. In this way, we can't disambiguate other template >> types. At least we

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

2023-06-15 Thread Abel Bernabeu via Phabricator via cfe-commits
abel-bernabeu created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

2023-06-15 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5788ff8dc1: [clang][index] NFCI: Make `CXFile` a `FileEntryRef` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] fa5788f - [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T12:34:54+02:00 New Revision: fa5788ff8dc10f36e0947757e335cd180a1a63c9 URL: https://github.com/llvm/llvm-project/commit/fa5788ff8dc10f36e0947757e335cd180a1a63c9 DIFF: https://github.com/llvm/llvm-project/commit/fa5788ff8dc10f36e0947757e335cd180a1a63c9.diff

[PATCH] D152879: [1/2][RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 531681. eopXD edited the summary of this revision. eopXD added a comment. Edit codegen test case for llvm/test/CodeGen/RISCV/rvv/{vnclip.ll/vnclipu.ll} correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

2023-06-15 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This serves two purposes: - Because, today, we

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 531676. eopXD added a comment. Bump CI due to update of parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files:

[PATCH] D151927: [clang] Deprecate `DirectoryEntry::getName()`

2023-06-15 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG462bda1d562a: [clang] Deprecate `DirectoryEntry::getName()` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 462bda1 - [clang] Deprecate `DirectoryEntry::getName()`

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T12:14:41+02:00 New Revision: 462bda1d562acc5a907eafe0afeb79556101c65d URL: https://github.com/llvm/llvm-project/commit/462bda1d562acc5a907eafe0afeb79556101c65d DIFF: https://github.com/llvm/llvm-project/commit/462bda1d562acc5a907eafe0afeb79556101c65d.diff

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

2023-06-15 Thread Kan Shengchen via Phabricator via cfe-commits
skan added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa() && Section.relocations().empty()) + continue; Should we merge the check into

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

2023-06-15 Thread Kan Shengchen via Phabricator via cfe-commits
skan added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1895 + if (RelocatedSection != Obj.section_end() && Name.contains(".dwo")) { +// Each section in COFF can directly contain relocations. +if (isa() &&

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

2023-06-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In D153003#4423926 , @ChuanqiXu wrote: > This looks not so good. In this way, we can't disambiguate other template > types. At least we added the kind and a TODO here. Which template name types would we need to disambiguate?

[PATCH] D152275: Use memory region declaration intrinsic when generating code for array subscripts

2023-06-15 Thread Jeroen Dobbelaere via Phabricator via cfe-commits
jeroen.dobbelaere added a comment. In D152275#4418363 , @efriedma wrote: > - Not sure how this interacts with full restrict and related proposals. the full restrict PropagateAndConvertNoAlias pass will need to learn about it, but that should be

[PATCH] D151922: [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()`

2023-06-15 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1dee56aed735: [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()` (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D151922?vs=527582=531660#toc

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

2023-06-15 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bca6f452f53: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2) (authored by jansvoboda11). Repository: rG LLVM Github

[clang] 7bca6f4 - [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T11:22:31+02:00 New Revision: 7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb URL: https://github.com/llvm/llvm-project/commit/7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb DIFF: https://github.com/llvm/llvm-project/commit/7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb.diff

[clang] 1dee56a - [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()`

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T11:22:31+02:00 New Revision: 1dee56aed7357ad87e7b30316554b760c75d5779 URL: https://github.com/llvm/llvm-project/commit/1dee56aed7357ad87e7b30316554b760c75d5779 DIFF: https://github.com/llvm/llvm-project/commit/1dee56aed7357ad87e7b30316554b760c75d5779.diff

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

2023-06-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. This looks not so good. In this way, we can't disambiguate other template types. At least we added the kind and a TODO here. BTW, the attached test case is in fact in correct. See https://eel.is/c++draft/basic.def.odr#14.3, such mergeable declarations shouldn't be

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 531654. eopXD added a comment. Bump CI due to rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

2023-06-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: rtrieu, vsapsai, ChuanqiXu, Bigcheese. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For hashing, we should not differentiate between

[PATCH] D152275: Use memory region declaration intrinsic when generating code for array subscripts

2023-06-15 Thread Simeon Krastnikov via Phabricator via cfe-commits
simeon added a comment. > - The compile-time overhead of creating a bunch of extra intrinsics might be > significant. Maybe we can mitigate to some extent by avoiding emitting the > intrinsic in simple cases where it doesn't actually help (constant indexes?). Yes, that would make sense. > -

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

2023-06-15 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG10e42281144e: [ARM,AArch64] Add a full set of -mtp= options. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152433/new/

[clang] 10e4228 - [ARM,AArch64] Add a full set of -mtp= options.

2023-06-15 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2023-06-15T09:27:41+01:00 New Revision: 10e42281144ecca019764b554f3f0f709bba0f71 URL: https://github.com/llvm/llvm-project/commit/10e42281144ecca019764b554f3f0f709bba0f71 DIFF: https://github.com/llvm/llvm-project/commit/10e42281144ecca019764b554f3f0f709bba0f71.diff

[PATCH] D153001: [clang][ThreadSafety] Add __builtin_instance_member (WIP)

2023-06-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaronpuchert, NoQ, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

2023-06-15 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. Looks reasonable. Main note I have is that I think the use of getUnqual() over passing AddrSpace=0 would be preferred. Comment at: clang/lib/CodeGen/CGAtomic.cpp:91 auto Addr = CGF.Builder.CreatePointerBitCastOrAddrSpaceCast( -

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

2023-06-15 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/HeuristicResolver.cpp:33 +const Type *HeuristicResolver::resolveDeclsToType( +const std::vector ) const { the reason to promote this utility function to a class method seems to be able to

[clang] b92ccc3 - [CGCall] Directly create opaque pointers (NFCI)

2023-06-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2023-06-15T10:06:40+02:00 New Revision: b92ccc355acb8a329918ceb2837df1b351675ece URL: https://github.com/llvm/llvm-project/commit/b92ccc355acb8a329918ceb2837df1b351675ece DIFF: https://github.com/llvm/llvm-project/commit/b92ccc355acb8a329918ceb2837df1b351675ece.diff

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D152995: Remove clang/ModuleInfo.txt

2023-06-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Just checking to be sure there is no other use case that the file is used for, but I doubt it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152995/new/ https://reviews.llvm.org/D152995

[PATCH] D152995: Remove clang/ModuleInfo.txt

2023-06-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The script `build-for-llvm-top.sh` and LLVM's `ModuleInfo.txt` are gone

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

2023-06-15 Thread Animesh Kumar via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c6f2f629cc0: [OpenMP] Update the default version of OpenMP to 5.1 (authored by animeshk-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152505: [Clang] Directly create opaque pointers

2023-06-15 Thread Nikita Popov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09d6ee765780: [Clang] Directly create opaque pointers (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 09d6ee7 - [Clang] Directly create opaque pointers

2023-06-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2023-06-15T09:09:33+02:00 New Revision: 09d6ee765780837d5156ac81f968465bdcec73ba URL: https://github.com/llvm/llvm-project/commit/09d6ee765780837d5156ac81f968465bdcec73ba DIFF: https://github.com/llvm/llvm-project/commit/09d6ee765780837d5156ac81f968465bdcec73ba.diff

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD added a comment. In D152135#4423640 , @rogfer01 wrote: > Just to confirm, though: seeing those `COERCE`, I assume the underlying > calling convention (which unfortunately it not 100% transparent to `clang` at > this point) is the same as passing

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

2023-06-15 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 added a comment. Just to confirm, though: seeing those `COERCE`, I assume the underlying calling convention (which unfortunately it not 100% transparent to `clang` at this point) is the same as passing in order the components of the tuple, right? (Apologies if this was already

[PATCH] D152136: [3/6][Clang][RISCV] Replace strided segment load with tuple type interfaces

2023-06-15 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152136/new/ https://reviews.llvm.org/D152136

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

2023-06-15 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152135/new/ https://reviews.llvm.org/D152135

[PATCH] D152134: [1/6][Clang][RISCV] Replace unit-stride (fault-first) segment load with tuple type interfaces

2023-06-15 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152134/new/ https://reviews.llvm.org/D152134

[PATCH] D151512: Remove small data limit for riscv64.*android triples

2023-06-15 Thread Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG280930816fe0: Remove small data limit for riscv64.*android triples (authored by AdityaK

[clang] 2809308 - Remove small data limit for riscv64.*android triples

2023-06-15 Thread via cfe-commits
Author: AdityaK Date: 2023-06-14T23:14:03-07:00 New Revision: 280930816fe0ddbf183a077296e32a87be1f8a8a URL: https://github.com/llvm/llvm-project/commit/280930816fe0ddbf183a077296e32a87be1f8a8a DIFF: https://github.com/llvm/llvm-project/commit/280930816fe0ddbf183a077296e32a87be1f8a8a.diff LOG:

<    1   2   3