[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; aaron.ballman wrote: > hokein wrote: > > hokein wrote: > > > hokein wrote: > > > > yronglin wrote: > > > > > yronglin wrote: > > > > >

[PATCH] D154580: Add missing semantic highlighing for concepts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gith

[PATCH] D153579: [clang-format] Fix RAS reference alignment when PAS is left or middle

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b8a9ff7e74f: [clang-format] Fix RAS reference alignment when PAS is left or middle (authored by gedare, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 6b8a9ff - [clang-format] Fix RAS reference alignment when PAS is left or middle

Author: Gedare Bloom Date: 2023-07-06T01:41:16-07:00 New Revision: 6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2 URL: https://github.com/llvm/llvm-project/commit/6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2 DIFF: https://github.com/llvm/llvm-project/commit/6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2.diff

[PATCH] D154578: [ARM][Driver] Change float-abi warning

michaelplatings created this revision. michaelplatings added a reviewer: simon_tatham. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously the war

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat added a comment. In D154576#4476291 , @craig.topper wrote: > Does this only change the calling convention when > `__attribute__((riscv_vector_cc))` is used? The attribute should be mentioned > in the patch description. Yes it only changes when

[PATCH] D154572: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac03e3f51c27: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] ac03e3f - [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC

Author: Craig Topper Date: 2023-07-06T01:14:02-07:00 New Revision: ac03e3f51c271b985efeb0fe6b9782cd6928be33 URL: https://github.com/llvm/llvm-project/commit/ac03e3f51c271b985efeb0fe6b9782cd6928be33 DIFF: https://github.com/llvm/llvm-project/commit/ac03e3f51c271b985efeb0fe6b9782cd6928be33.diff

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

craig.topper added a comment. Does this only change the calling convention when `__attribute__((riscv_vector_cc))` is used? The attribute should be mentioned in the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154576/new/ http

[PATCH] D154577: [RISCV] Use 'long' in sha512 builtin tests. NFC

craig.topper created this revision. craig.topper added reviewers: kito-cheng, asb, VincentWu. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D154572: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154572/new/ https://reviews.llvm.org/D154572 ___

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, ormris, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, edward-jones, zzheng, jrtc27, shiva0217, kito

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

glandium added a comment. In the realm of unintended consequences, this broke ODR violation detection when linking a rust static library with asan enabled because, while __asan_globals_registered is COMDAT in clang, for some reason, it's not in rust... So you end up with two asan.module_ctor th

[clang] 7c9230c - [RISCV] Add trunc instruction to the __builtin_riscv_ctz_64/__builtin_riscv_clz_64 IR.

Author: Craig Topper Date: 2023-07-06T00:55:16-07:00 New Revision: 7c9230c4f2ad267c716520fb25c4037acd2204fd URL: https://github.com/llvm/llvm-project/commit/7c9230c4f2ad267c716520fb25c4037acd2204fd DIFF: https://github.com/llvm/llvm-project/commit/7c9230c4f2ad267c716520fb25c4037acd2204fd.diff

[clang] 51feb1a - [RISCV] Use 'int' for return type for clz_64/clo_64 tests in riscv64-xtheadbb.c. NFC

Author: Craig Topper Date: 2023-07-06T00:25:20-07:00 New Revision: 51feb1a72c5beb8f46d2f5569f3c3398f8902272 URL: https://github.com/llvm/llvm-project/commit/51feb1a72c5beb8f46d2f5569f3c3398f8902272 DIFF: https://github.com/llvm/llvm-project/commit/51feb1a72c5beb8f46d2f5569f3c3398f8902272.diff

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:87-90 +if (Feature == "sme") { + Features.push_back("+sve"); + Features.push_back("+sve2"); + Features.push_back("+bf16"); SME shouldn't require SVE or SV

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG533af6e5c4b3: [AIX] make integrated-as as default on AIX. (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

sivachandra added a comment. The libc specific changes are really minimal straightforward. The GPU side, the clang driver changes etc. need a review by a GPU expert. Comment at: libc/include/CMakeLists.txt:8 +if(LIBC_TARGET_ARCHITECTURE_IS_GPU) + include(GetClangResourceDir)

[clang] 533af6e - [AIX] make integrated-as as default on AIX.

Author: esmeyi Date: 2023-07-06T03:16:10-04:00 New Revision: 533af6e5c4b35b72805cdbd6229644d288e172e4 URL: https://github.com/llvm/llvm-project/commit/533af6e5c4b35b72805cdbd6229644d288e172e4 DIFF: https://github.com/llvm/llvm-project/commit/533af6e5c4b35b72805cdbd6229644d288e172e4.diff LOG: [

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff added a comment. In D143241#4475741 , @Jake-Egan wrote: > Hi, the following assertion is getting tripped on AIX: > > Assertion failed: *FpPragmaCurrentValue == > SemaObj->FpPragmaStack.DefaultValue && "Expected a default pragma > float_contr

[PATCH] D154572: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[clang] d4a5673 - [AIX][clang][tests] XFail PCH/late-parsed-instantiations.cpp

Author: Serge Pavlov Date: 2023-07-06T14:06:30+07:00 New Revision: d4a5673addd69aa2a299d9de4db8d17373be URL: https://github.com/llvm/llvm-project/commit/d4a5673addd69aa2a299d9de4db8d17373be DIFF: https://github.com/llvm/llvm-project/commit/d4a5673addd69aa2a299d9de4db8d17373be.diff

<    1   2   3