[clang] 724d689 - [Driver][test] Add --cuda-path= and ignore %clang exit code for -mcpu=native

Author: Fangrui Song Date: 2023-07-28T22:14:36-07:00 New Revision: 724d68967018deb86e56a5e269500833b54945f8 URL: https://github.com/llvm/llvm-project/commit/724d68967018deb86e56a5e269500833b54945f8 DIFF: https://github.com/llvm/llvm-project/commit/724d68967018deb86e56a5e269500833b54945f8.diff

[clang] f7f65b6 - [test] Set target triple for Driver/miamcu-opt.c

Author: Fangrui Song Date: 2023-07-28T22:06:11-07:00 New Revision: f7f65b68b0e774feee59d4860033ddccc67c134d URL: https://github.com/llvm/llvm-project/commit/f7f65b68b0e774feee59d4860033ddccc67c134d DIFF: https://github.com/llvm/llvm-project/commit/f7f65b68b0e774feee59d4860033ddccc67c134d.diff

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545332. ccotter added a comment. - Fix ReleaseNotes again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545331. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[clang] 80765ed - [Driver][test] Ignore %clang exit code for -mcpu=native tests

Author: Fangrui Song Date: 2023-07-28T21:31:44-07:00 New Revision: 80765ede5bbcca1364c2d4ae06127011eaba6389 URL: https://github.com/llvm/llvm-project/commit/80765ede5bbcca1364c2d4ae06127011eaba6389 DIFF: https://github.com/llvm/llvm-project/commit/80765ede5bbcca1364c2d4ae06127011eaba6389.diff

[clang] 9155e51 - [Driver][test] Add --cuda-path= to some tests

Author: Fangrui Song Date: 2023-07-28T21:21:42-07:00 New Revision: 9155e517e6e1cda474d0d0fa82f71696c325bc10 URL: https://github.com/llvm/llvm-project/commit/9155e517e6e1cda474d0d0fa82f71696c325bc10 DIFF: https://github.com/llvm/llvm-project/commit/9155e517e6e1cda474d0d0fa82f71696c325bc10.diff

[clang] 2ca82f3 - [Driver][test] Add --cuda-path= to some tests

Author: Fangrui Song Date: 2023-07-28T20:27:40-07:00 New Revision: 2ca82f36813d984df9730794bcf6ba558daf0161 URL: https://github.com/llvm/llvm-project/commit/2ca82f36813d984df9730794bcf6ba558daf0161 DIFF: https://github.com/llvm/llvm-project/commit/2ca82f36813d984df9730794bcf6ba558daf0161.diff

[clang] 2f79bb1 - [Driver][test] Add -nogpulib to some AMDGPU tests

Author: Fangrui Song Date: 2023-07-28T19:57:25-07:00 New Revision: 2f79bb10461d114783a1548201928549ace09755 URL: https://github.com/llvm/llvm-project/commit/2f79bb10461d114783a1548201928549ace09755 DIFF: https://github.com/llvm/llvm-project/commit/2f79bb10461d114783a1548201928549ace09755.diff

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. In D155145#4543326 , @anna wrote: > We see a crash bisected to this patch about using an illegal instruction. > Here's the CPUInfo for the machine: > > CPU info: > current cpu id: 22 > total 32(physical cores 16) (assigned

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added a comment. In D150124#4542032 , @kadircet wrote: > btw, thanks a lot Nathan for taking good care of clangd, I don't think I say > that enough I'm happy to help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:150 +ParentDC, +unsigned(SymbolRole::NameReference)); + } ckandeler wrote: > kadircet wrote: > > nridge wrote: > > >

[PATCH] D156513: [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ddc37189032: [clang] [libIndex] Remove unused RefD parameter of IndexingContext… (authored by nridge). Repository: rG LLVM Github Monorepo

[clang] 5ddc371 - [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

Author: Nathan Ridge Date: 2023-07-28T21:36:27-04:00 New Revision: 5ddc371890324ba8aa5c54b42faeb0ed8a552fdb URL: https://github.com/llvm/llvm-project/commit/5ddc371890324ba8aa5c54b42faeb0ed8a552fdb DIFF: https://github.com/llvm/llvm-project/commit/5ddc371890324ba8aa5c54b42faeb0ed8a552fdb.diff

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson updated this revision to Diff 545318. tejohnson marked an inline comment as done. tejohnson added a comment. Address test comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155997/new/ https://reviews.llvm.org/D155997 Files:

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson marked 2 inline comments as done. tejohnson added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:83 +!4 = !{i32 1, !"wchar_size", i32 4} +!5 = !{i32 8, !"PIC Level", i32 2} +!6 = !{i32 7, !"PIE Level", i32 2}

[PATCH] D156576: Remove rdar links in clang/lib. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb08d358e8ac8: Remove private rdar links. NFC (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b08d358 - Remove private rdar links. NFC

Author: Akira Hatanaka Date: 2023-07-28T16:42:31-07:00 New Revision: b08d358e8ac83cf31c007a58c814bf2dca03d591 URL: https://github.com/llvm/llvm-project/commit/b08d358e8ac83cf31c007a58c814bf2dca03d591 DIFF:

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof added a comment. In D151373#4538604 , @aaron.ballman wrote: > I think we should drop the `annotate_type` functionality from the patch > entirely rather than add it without any test coverage knowing it doesn't seem > to work as expected.

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 545305. fridtjof retitled this revision from "[libclang] Expose arguments of clang::annotate{_type}" to "[libclang] Expose arguments of clang::annotate". fridtjof edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D156580: [FunctionImport] Reduce string duplication (NFC)

tejohnson created this revision. tejohnson added a reviewer: mtrofin. Herald added subscribers: hoy, ormris, steven_wu, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Thanks Akira. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156576/new/ https://reviews.llvm.org/D156576

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ahatanak updated this revision to Diff 545300. ahatanak added a comment. Remove git commit hash in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156576/new/ https://reviews.llvm.org/D156576 Files: clang/lib/CodeGen/CGObjCMac.cpp

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

barannikov88 added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2349 + if (isVariadicStringLiteralArgument(Args[N])) { +for (; N < sizeof(uint32_t); N++) + Bits |= (1 << N); maskTrailingZeros might also be useful

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao added inline comments. Comment at: clang/test/CodeGenCXX/packed_data_member.cpp:8-12 +template struct S2 { +T t[2]; +Ts... ts; +}; + dblaikie wrote: > Did this test case come out of any particular bug discovered during > implementation? No.

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao added a comment. In D156546#4543697 , @dblaikie wrote: > (just a side note about the title of this patch: I got "packed data members" > confused and thought this was referring to struct packing > `__attribute__((packed))` - so perhaps

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 545297. SlaterLatiao added a comment. Address comments. - Added test case of duplicate types in template arguments. - Added ending new line to test case file. - Renamed "packed data members" -> "data member packs" Repository: rG LLVM Github Monorepo

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver updated this revision to Diff 545294. jmciver edited the summary of this revision. jmciver added a comment. Herald added subscribers: foad, kerbowa, jvesely, arsenm. Refactor AMDGPUPromoteAlloca to use getInitialValueOfAllocation. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc1b6668c571: [Clang] Fix member lookup so that we dont ignore ambiguous lookups in some… (authored by shafik). Herald added a project: clang.

[clang] cc1b666 - [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

Author: Shafik Yaghmour Date: 2023-07-28T15:21:57-07:00 New Revision: cc1b6668c57170cd440d321037ced89d6a61a9cb URL: https://github.com/llvm/llvm-project/commit/cc1b6668c57170cd440d321037ced89d6a61a9cb DIFF:

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 545291. SlaterLatiao marked 2 inline comments as done. SlaterLatiao added a comment. Revert last commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files:

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ahatanak created this revision. ahatanak added a reviewer: ravikandhadai. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156576 Files:

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 545286. SlaterLatiao added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files: clang/lib/AST/DeclPrinter.cpp

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

jyknight added a comment. As I posted on the RFC thread, I think we have a viable alternative solution to address the original motiving use-case. One might potentially still make a case for implementing the `-fno-coroutines` flag for GCC compatibility, but given the concerns raised -- and that

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik updated this revision to Diff 545283. shafik added a comment. Add release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155387/new/ https://reviews.llvm.org/D155387 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Lookup.h clang/lib/Sema/SemaOverload.cpp

[PATCH] D156546: [Clang][WIP]Experimental implementation of packed data members declarations

dblaikie added a comment. (just a side note about the title of this patch: I got "packed data members" confused and thought this was referring to struct packing `__attribute__((packed))` - so perhaps something more like "data member packs" would be a more clear term here?)

[PATCH] D105759: Implement P2361 Unevaluated string literals

hubert.reinterpretcast added a comment. In D105759#4543246 , @aaron.ballman wrote: > I'd recommend we change the diagnostic to be a warning that defaults to an > error so that users who are caught by the changes can still disable the > diagnostic

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

benlangmuir added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:663 +} else { + llvm::sys::path::remove_dots(AbsPathBuf, /*remove_dot_dot=*/true); + CanonicalName = AbsPathBuf.str().copy(CanonicalNameStorage); MrTrillian wrote: >

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This looks good to me. I think we can further refine the handling of duplicate diagnostics but I don't think that needs to be done as part of this bugfix. Comment at:

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

probinson added a comment. See https://reviews.llvm.org/D156571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155991/new/ https://reviews.llvm.org/D155991 ___ cfe-commits mailing list

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson created this revision. probinson added reviewers: dblaikie, nikic. probinson added a project: debug-info. Herald added a subscriber: StephenFan. Herald added a project: All. probinson requested review of this revision. Should have lower memory and time cost than D155991

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman added a comment. In D156565#4543414 , @jrtc27 wrote: > Given GCC defines GNU C++ and regards this as a feature (unless you use > things like -pedantic to ask for ISO C++), does it make sense to enable this > for GNU C++? I think GCC

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian marked an inline comment as done. MrTrillian added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:663 +} else { + llvm::sys::path::remove_dots(AbsPathBuf, /*remove_dot_dot=*/true); + CanonicalName =

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian updated this revision to Diff 545250. MrTrillian marked an inline comment as done. MrTrillian added a comment. @benlangmuir I made the root-preserving canonicalization logic Windows-only now that I found how to test for that. It changes the code shape a little but I think it's an

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:634 the most negative integer remains the most negative integer - T __builtin_elementwise_fma(T x, T y, T z) fused multiply add, (x * y) + z.

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 545251. bob80905 added a comment. - add float4 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 Files: clang/docs/LanguageExtensions.rst

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

aaron.ballman added a comment. In D156247#4542769 , @ilya-biryukov wrote: > In D156247#4542155 , @aaron.ballman > wrote: > >> Given the views expressed on this thread, I think this requires a wider >>

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 545247. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.py

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2964-2965 if (FormatTok->is(tok::l_brace)) { +FormatToken *LBrace = FormatTok; +

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2090 + assert(Initializing); + if (!isa(E)) { +if (!this->emitDupPtr(E)) aaron.ballman wrote: > And if it is a member

[PATCH] D156565: Diagnose use of VLAs in C++ by default

jrtc27 added a comment. Given GCC defines GNU C++ and regards this as a feature (unless you use things like -pedantic to ask for ISO C++), does it make sense to enable this for GNU C++? Every deviation from GCC is a point of friction for adopting Clang over GCC. Repository: rG LLVM Github

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman added subscribers: ABataev, clang-vendors. aaron.ballman added a comment. The patch seems large and scary, but that's because of how often we've had to test VLA behavior in C++ code. The OpenMP test cases are mostly opting out of VLA warnings mechanically (I verified with @ABataev

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, clang-language-wg, hubert.reinterpretcast, shafik, jyknight. Herald added subscribers: mattd, pmatos, asb, asavonic, jdoerfert, sbc100, dschuff. Herald added a project: All. aaron.ballman requested review of

[PATCH] D156563: [clang][deps] Remove `ModuleDeps::ImportedByMainFile`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc75b331fc231: [clang][deps] Remove `ModuleDeps::ImportedByMainFile` (authored by jansvoboda11). Changed prior to commit:

[clang] c75b331 - [clang][deps] Remove `ModuleDeps::ImportedByMainFile`

Author: Jan Svoboda Date: 2023-07-28T12:04:35-07:00 New Revision: c75b331fc23192a8249dc5e95e053258f5fb5194 URL: https://github.com/llvm/llvm-project/commit/c75b331fc23192a8249dc5e95e053258f5fb5194 DIFF: https://github.com/llvm/llvm-project/commit/c75b331fc23192a8249dc5e95e053258f5fb5194.diff

[PATCH] D156492: [clang][deps] Make the C++ API more type-safe

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a077cfe23e3: [clang][deps] Make the C++ API more type-safe (authored by jansvoboda11). Changed prior to commit:

[clang] 8a077cf - [clang][deps] Make the C++ API more type-safe

Author: Jan Svoboda Date: 2023-07-28T12:03:54-07:00 New Revision: 8a077cfe23e3856d406bd3633e1a3026609f3537 URL: https://github.com/llvm/llvm-project/commit/8a077cfe23e3856d406bd3633e1a3026609f3537 DIFF: https://github.com/llvm/llvm-project/commit/8a077cfe23e3856d406bd3633e1a3026609f3537.diff

[PATCH] D156563: [clang][deps] Remove `ModuleDeps::ImportedByMainFile`

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. This flag was always weird to me, thanks for cleaning it up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156563/new/

[clang] 9016514 - Revert "[clang][Interp] Implement __builtin_isnan()"

Author: Timm Bäder Date: 2023-07-28T20:59:38+02:00 New Revision: 9016514c6bc34330b89dadfcd00e803a44b3cbc8 URL: https://github.com/llvm/llvm-project/commit/9016514c6bc34330b89dadfcd00e803a44b3cbc8 DIFF: https://github.com/llvm/llvm-project/commit/9016514c6bc34330b89dadfcd00e803a44b3cbc8.diff

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. We see a crash bisected to this patch about using an illegal instruction. Here's the CPUInfo for the machine: CPU info: current cpu id: 22 total 32(physical cores 16) (assigned logical cores 32) (assigned physical cores 16) (assigned_sockets:2 of 2) (8 cores per

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ad9dcb38693: [clang][Interp] Implement __builtin_isnan() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8ad9dcb - [clang][Interp] Implement __builtin_isnan()

Author: Timm Bäder Date: 2023-07-28T20:49:45+02:00 New Revision: 8ad9dcb3869394e3a4ecb01631646237074723fe URL: https://github.com/llvm/llvm-project/commit/8ad9dcb3869394e3a4ecb01631646237074723fe DIFF: https://github.com/llvm/llvm-project/commit/8ad9dcb3869394e3a4ecb01631646237074723fe.diff

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added subscribers: nlopes, StephenFan. Herald added a project: All. Should be obsoleted by D147732 Repository: rG LLVM Github Monorepo

[PATCH] D156563: [clang][deps] Remove `ModuleDeps::ImportedByMainFile`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This information is already

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

steven_wu added a comment. Reverted in 4098e13a7146 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156533/new/ https://reviews.llvm.org/D156533

[clang] 4098e13 - Revert "[clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body"

Author: Steven Wu Date: 2023-07-28T11:39:46-07:00 New Revision: 4098e13a71464cc4747528edd8a41e5a4eaa1b23 URL: https://github.com/llvm/llvm-project/commit/4098e13a71464cc4747528edd8a41e5a4eaa1b23 DIFF: https://github.com/llvm/llvm-project/commit/4098e13a71464cc4747528edd8a41e5a4eaa1b23.diff

Re: [PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

Sry for breaking builds. Can someone please revert it, I am currently not at work. Am 28.07.2023 20:27 schrieb Nico Weber via Phabricator : thakis added a comment. This breaks tests on Mac: http://45.33.8.238/macm1/65934/step_7.txt Please take a look and revert for now if it takes a while to

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

thakis added a comment. This breaks tests on Mac: http://45.33.8.238/macm1/65934/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156533/new/

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a comment. In D105759#4543184 , @hubert.reinterpretcast wrote: > In D105759#4541813 , @cor3ntin > wrote: > >> In D105759#4540716 , >>

[PATCH] D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. Clean, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156515/new/ https://reviews.llvm.org/D156515

[PATCH] D156492: [clang][deps] Make the C++ API more type-safe

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:175 std::vector PrebuiltModuleDeps; - llvm::MapVector> +

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc14c34de4571: [clang][Interp] Implement __builtin_fmin (authored by tbaeder). Changed prior to commit:

[clang] c14c34d - [clang][Interp] Implement __builtin_fmin

Author: Timm Bäder Date: 2023-07-28T20:18:57+02:00 New Revision: c14c34de4571cf3268e3599f5d1fc7318c42aac7 URL: https://github.com/llvm/llvm-project/commit/c14c34de4571cf3268e3599f5d1fc7318c42aac7 DIFF: https://github.com/llvm/llvm-project/commit/c14c34de4571cf3268e3599f5d1fc7318c42aac7.diff

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson added a comment. In D155997#4543156 , @nikic wrote: > I'm not a fan of the PGO conditional behavior here. I'd prefer to disable > speculation unconditionally if that is feasible. This is basically what > D153392

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

steven_wu added a comment. error: aliases are not supported on darwin Maybe create a different testcase that is not supported on Darwin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156533/new/ https://reviews.llvm.org/D156533

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

steven_wu added a comment. This breaks Darwin bots: https://green.lab.llvm.org/green/job/clang-stage1-RA/35102/testReport/junit/Clang/AST/ast_print_method_decl_cpp/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156533/new/

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

rjmccall added inline comments. Comment at: clang/docs/ReleaseNotes.rst:125 + out early in case next top-level block occurs as if the previous one is + properly finished. + `Issue 64065 `_ "Fixed a crash when

[PATCH] D105759: Implement P2361 Unevaluated string literals

hubert.reinterpretcast added a comment. In D105759#4541813 , @cor3ntin wrote: > In D105759#4540716 , > @hubert.reinterpretcast wrote: > >>> I hope this patch may allow to gather some data on that. >> >>

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jroelofs added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5391 if (FPtr->hasFnAttribute(llvm::Attribute::NoUnwind)) CannotThrow = true; + Is there coverage for a nounwind callee + an unwindabort call? Repository: rG LLVM Github

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

nikic added a comment. I'm not a fan of the PGO conditional behavior here. I'd prefer to disable speculation unconditionally if that is feasible. This is basically what D153392 did. While the specific test case there was addressed in a different way, if we

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM other than my suggestion to add a comment. @tahonermann are all your comments addressed at this point? Comment at: clang/lib/Basic/FileManager.cpp:663 +}

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

aeubanks added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:1 +;; Check that SimplifyCFG does not attempt speculation until after PGO is +;; annotated in the IR, and then does not perform it when unprofitable.

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian marked an inline comment as done. MrTrillian added inline comments. Comment at: llvm/utils/lit/lit/LitConfig.py:192 f = f.f_back.f_back -file = os.path.abspath(inspect.getsourcefile(f)) +file =

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:663 +} else { + llvm::sys::path::remove_dots(AbsPathBuf, /*remove_dot_dot=*/true); + CanonicalName = AbsPathBuf.str().copy(CanonicalNameStorage); benlangmuir wrote: >

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian updated this revision to Diff 545218. MrTrillian marked 4 inline comments as done. MrTrillian added a comment. Reverted some `os.path.abspath` that had been converted to `abs_path_preserve_drive` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

probinson added a comment. > Any memory usage measurements to check this doesn't have a significant > adverse impact by copying all the strings? Not actual measurements, no; but intuitively the size should not be much greater than the size of the filename entries in the .debug_line section for

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet updated this revision to Diff 545216. hazohelet added a comment. Added missing tests for method function templates before landing this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 Files: clang/docs/ReleaseNotes.rst

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

hazohelet marked 2 inline comments as done. hazohelet added a comment. Thanks for the review Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9743-9748 +def warn_tautological_negation_and_compare: Warning< + "'&&' against a variable and its negation always

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

hazohelet updated this revision to Diff 545213. hazohelet added a comment. Address comments from Aaron - Reworded diagnostic message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152093/new/ https://reviews.llvm.org/D152093 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156368: [OpenMP] Do not always emit unused extern variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG141c4e7a9403: [OpenMP] Do not always emit unused extern variables (authored by jhuber6). Herald added a project: OpenMP. Herald added a subscriber:

[clang] 141c4e7 - [OpenMP] Do not always emit unused extern variables

Author: Joseph Huber Date: 2023-07-28T11:52:05-05:00 New Revision: 141c4e7a9403fed46d84c7f0429295bd28c89368 URL: https://github.com/llvm/llvm-project/commit/141c4e7a9403fed46d84c7f0429295bd28c89368 DIFF: https://github.com/llvm/llvm-project/commit/141c4e7a9403fed46d84c7f0429295bd28c89368.diff

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:550-554 + if (isa(D)) { +S.FFDiag(E, diag::note_constexpr_function_param_value_unknown) << D; +S.Note(D->getLocation(), diag::note_declared_at) <<

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

tbaeder updated this revision to Diff 545193. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156509/new/ https://reviews.llvm.org/D156509 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3540 + return RValue::get(Builder.CreateAddrSpaceCast(AI, CGM.Int8PtrTy)); +else + return RValue::get(AI); No return after else Comment at:

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

arsenm added a comment. In D156539#4542836 , @rjmccall wrote: > We should probably write this code to work properly in case we add a target > that makes `__builtin_alloca` return a pointer in the private address space. > Could you recover the target

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

rjmccall added a comment. We should probably write this code to work properly in case we add a target that makes `__builtin_alloca` return a pointer in the private address space. Could you recover the target AS from the type of the expression instead of assuming `LangAS::Default`?

[PATCH] D153693: [clang][Interp] Handle InitListExprs of composite type

tbaeder abandoned this revision. tbaeder added a comment. Abandoning in favor of https://reviews.llvm.org/D156027 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153693/new/ https://reviews.llvm.org/D153693

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov added a comment. In D156247#4542155 , @aaron.ballman wrote: > Given the views expressed on this thread, I think this requires a wider > community discussion to determine whether we want to support this idea or > not, regardless of -cc1

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Mordante added a comment. In D156247#4541756 , @ilya-biryukov wrote: > In D156247#4540228 , @Mordante > wrote: > >> 2. My biggest concern is the timing of this patch. The date of the branching >> is know

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

aaron.ballman added a comment. In D155568#4525488 , @tbaeder wrote: > This patch is missing the `Ret` part in `InterpBuiltin()` in the > same file. That needs to change to the correct type as well. > > I can do that in a follow-up commit. @aaron.ballman

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits. Comment at: clang/lib/AST/Interp/Source.h:63-64 /// Pointer into the code owned by a function. +public: const std::byte

  1   2   3   >