[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: llvm/lib/Support/UnicodeNameToCodepoint.cpp:350 bool DoesStartWith = startsWith(Name, Item.Prefix, Strict, Consummed, -NameStart, NeedleStart, /*isPrefix*/ true); +

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

2023-07-28 Thread Kiran Chandramohan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf04ccadf3544: [Flang] Add support for fsave-optimization-record (authored by Victor Kingi , committed by kiranchandramohan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] f04ccad - [Flang] Add support for fsave-optimization-record

2023-07-28 Thread Kiran Chandramohan via cfe-commits
Author: Victor Kingi Date: 2023-07-28T09:26:40Z New Revision: f04ccadf35441b2e13b3ab30edeef251818fa9c7 URL: https://github.com/llvm/llvm-project/commit/f04ccadf35441b2e13b3ab30edeef251818fa9c7 DIFF: https://github.com/llvm/llvm-project/commit/f04ccadf35441b2e13b3ab30edeef251818fa9c7.diff LOG:

[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

2023-07-28 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added subscribers: mstorsjo, hiraditya, dschuff. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In a Unicode name was stored in a way that cause

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

2023-07-28 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2964-2965 if (FormatTok->is(tok::l_brace)) { +FormatToken *LBrace = FormatTok; +LBrace->setFinalizedType(TT_NamespaceLBrace); + Nit. C

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-28 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 545074. serge-sans-paille added a comment. (rebased on `main`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[clang] 1478d4d - [clang][Interp] Disable a float128/long double test

2023-07-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-28T11:19:35+02:00 New Revision: 1478d4dc8dc44c109bff1bbe0486cc40674a0ee2 URL: https://github.com/llvm/llvm-project/commit/1478d4dc8dc44c109bff1bbe0486cc40674a0ee2 DIFF: https://github.com/llvm/llvm-project/commit/1478d4dc8dc44c109bff1bbe0486cc40674a0ee2.diff LO

[PATCH] D155410: [clang][Interp] Fix comparing nan/inf floating point values

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a0164a0c66c: [clang][Interp] Fix comparing nan/inf floating point values (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org

[clang] 9a0164a - [clang][Interp] Fix comparing nan/inf floating point values

2023-07-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-28T11:12:25+02:00 New Revision: 9a0164a0c66c28363fbc9410edd5656b28811427 URL: https://github.com/llvm/llvm-project/commit/9a0164a0c66c28363fbc9410edd5656b28811427 DIFF: https://github.com/llvm/llvm-project/commit/9a0164a0c66c28363fbc9410edd5656b28811427.diff LO

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

2023-07-28 Thread Ding Fei via Phabricator via cfe-commits
danix800 added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; rjmccall wrote: > danix800 wrote: > > rjmccall wrote: > > > aaron.ballman wrote: > > > > rjmccall wrote: > > > > > a

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

2023-07-28 Thread Ding Fei via Phabricator via cfe-commits
danix800 updated this revision to Diff 545069. danix800 added a comment. Update `clang/docs/ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156277/new/ https://reviews.llvm.org/D156277 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D155368: [clang][Interp] __builtin_copysign

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57ca62d5d35a: [clang][Interp] Implement __builtin_copysign (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155368?vs=541

[clang] 57ca62d - [clang][Interp] Implement __builtin_copysign

2023-07-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-28T10:55:34+02:00 New Revision: 57ca62d5d35a424722059f42da4a6c75fbba2eb0 URL: https://github.com/llvm/llvm-project/commit/57ca62d5d35a424722059f42da4a6c75fbba2eb0 DIFF: https://github.com/llvm/llvm-project/commit/57ca62d5d35a424722059f42da4a6c75fbba2eb0.diff LO

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb395e91f2ef4: [clang][Interp] Implement __builtin_inf() etc. (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b395e91 - [clang][Interp] Implement __builtin_inf() etc.

2023-07-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-28T10:50:13+02:00 New Revision: b395e91f2ef41e44c99857b5dd4e241a57d12b76 URL: https://github.com/llvm/llvm-project/commit/b395e91f2ef41e44c99857b5dd4e241a57d12b76 DIFF: https://github.com/llvm/llvm-project/commit/b395e91f2ef41e44c99857b5dd4e241a57d12b76.diff LO

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-28 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 545060. serge-sans-paille added a comment. Take reviewers comment into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

2023-07-28 Thread Ding Fei via Phabricator via cfe-commits
danix800 updated this revision to Diff 545056. danix800 retitled this revision from "[Parser][ObjC] Stop parsing on eof" to "[Parser][ObjC] Fix parser crash on nested top-level block with better recovery path". danix800 edited the summary of this revision. danix800 added a comment. Delay consumi

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

2023-07-28 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + benshi001 wrote: > This file is pure test, has nothing to do with `llvm.cttz`, just to avoid > another pat

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2273e33bd13: [clang][Interp] Implement __builtin_nan family (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155356?vs=5

[clang] c2273e3 - [clang][Interp] Implement __builtin_nan family

2023-07-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-28T10:28:55+02:00 New Revision: c2273e33bd13a227271a53cde5868546e41dc3bf URL: https://github.com/llvm/llvm-project/commit/c2273e33bd13a227271a53cde5868546e41dc3bf DIFF: https://github.com/llvm/llvm-project/commit/c2273e33bd13a227271a53cde5868546e41dc3bf.diff LO

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-07-28 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 545054. ckandeler added a comment. Addressed review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: clang-tools-extra/clangd/unittests/XRefsTests.

[PATCH] D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff

2023-07-28 Thread Zain Jaffal via Phabricator via cfe-commits
zjaffal created this revision. zjaffal added reviewers: fhahn, thegameg, paquette, anemet. Herald added subscribers: StephenFan, arphaman. Herald added a project: All. zjaffal requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D152768: [Clang][BFloat16] Upgrade __bf16 by supporting increment/decrement operations

2023-07-28 Thread Jun Sha via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG62a251f824f6: [Clang][BFloat16] Upgrade __bf16 by supporting increment/decrement operations (authored by joshua-arch1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior

[clang] 62a251f - [Clang][BFloat16] Upgrade __bf16 by supporting increment/decrement operations

2023-07-28 Thread Jun Sha via cfe-commits
Author: Jun Sha (Joshua) Date: 2023-07-28T16:21:24+08:00 New Revision: 62a251f824f63a56563b246035b9bd24078aa98b URL: https://github.com/llvm/llvm-project/commit/62a251f824f63a56563b246035b9bd24078aa98b DIFF: https://github.com/llvm/llvm-project/commit/62a251f824f63a56563b246035b9bd24078aa98b.di

[clang] 1195bd4 - [clang][Interp][NFC] Rename a test file to be more correct

2023-07-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-28T10:12:36+02:00 New Revision: 1195bd48e017bb0f8237dec017e88d23d13ac2a9 URL: https://github.com/llvm/llvm-project/commit/1195bd48e017bb0f8237dec017e88d23d13ac2a9 DIFF: https://github.com/llvm/llvm-project/commit/1195bd48e017bb0f8237dec017e88d23d13ac2a9.diff LO

[PATCH] D156513: [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

2023-07-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Noticed this while reviewing D150124 . No caller was providing a value for this parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156513/new/ https://reviews.llvm.org/D156513 __

[PATCH] D156513: [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

2023-07-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.l

[clang] 8c0acbf - [clang][dataflow] Avoid -Wunused-variable.

2023-07-28 Thread Martin Braenne via cfe-commits
Author: Martin Braenne Date: 2023-07-28T07:57:50Z New Revision: 8c0acbf8370f29943798cd434cd0b91bbd554cdf URL: https://github.com/llvm/llvm-project/commit/8c0acbf8370f29943798cd434cd0b91bbd554cdf DIFF: https://github.com/llvm/llvm-project/commit/8c0acbf8370f29943798cd434cd0b91bbd554cdf.diff LOG

[PATCH] D155916: [RISCV] Remove some instructions from Zvfbfwma by implying Zfbfmin according to the latest spec

2023-07-28 Thread Jun Sha via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe56bf133170c: [RISCV] Remove some instructions from Zvfbfwma by implying Zfbfmin according to… (authored by joshua-arch1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed pr

[clang] e56bf13 - [RISCV] Remove some instructions from Zvfbfwma by implying Zfbfmin according to the latest spec

2023-07-28 Thread Jun Sha via cfe-commits
Author: Jun Sha (Joshua) Date: 2023-07-28T15:52:03+08:00 New Revision: e56bf133170c9fd49c91fe943ded26a3f2b30a04 URL: https://github.com/llvm/llvm-project/commit/e56bf133170c9fd49c91fe943ded26a3f2b30a04 DIFF: https://github.com/llvm/llvm-project/commit/e56bf133170c9fd49c91fe943ded26a3f2b30a04.di

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

2023-07-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a reviewer: sammccall. nridge added a comment. Adding Sam as well in case he has any thoughts on the discussion (another user ran into this recently and filed https://github.com/clangd/clangd/issues/1694) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-07-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D150124#4329163 , @ilya-biryukov wrote: > In `clangd` we also have `findExplicitReferences` and `targetDecl` functions > that seem to handle the `GoToStmt`. > In fact, I believe they are used in `findDocumentHighlights`, so I'

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

2023-07-28 Thread James Henderson via Phabricator via cfe-commits
jhenderson added a comment. In D142660#4538936 , @DiggerLin wrote: >> As an alternative (but I think adds unnecessary complexity, due to needing >> an extra variable), you could have both tools read the environment variable >> into a string variable, th

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. In D155572#4539457 , @aaron.ballman wrote: > Is this intended to not handle all the binary operators in this patch? Yes, just a subset for now. > And also, is this intended to only impact initializers? Yes, due to problems wit

[PATCH] D156511: [clang][Interp] Diagnose more unkonwn DeclRefExprs

2023-07-28 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Diagnose used non-const and/or extern globals. Rep

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

2023-07-28 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/inc-dec-in-conditions.rst:62 +means that if ``i`` were initially ``5``, the first operand ``i < 5`` would +evaluate to ``false`` and the second operand ``i > 2`` would not be evaluated.

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

2023-07-28 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9d92e66387b: [X86] Support -march=arrowlake,arrowlake-s,lunarlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c9d92e6 - [X86] Support -march=arrowlake, arrowlake-s, lunarlake

2023-07-28 Thread Freddy Ye via cfe-commits
Author: Freddy Ye Date: 2023-07-28T15:05:54+08:00 New Revision: c9d92e66387baab18ceec1533503cc5f19048d91 URL: https://github.com/llvm/llvm-project/commit/c9d92e66387baab18ceec1533503cc5f19048d91 DIFF: https://github.com/llvm/llvm-project/commit/c9d92e66387baab18ceec1533503cc5f19048d91.diff LOG

<    1   2   3