[clang] c4ada13 - [NFC][Clang] Fix static analyzer concern about null value dereference

Author: Elizabeth Andrews Date: 2023-08-14T12:19:45-07:00 New Revision: c4ada13e4b3e72543e454a12a6db085812114c0c URL: https://github.com/llvm/llvm-project/commit/c4ada13e4b3e72543e454a12a6db085812114c0c DIFF:

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

steakhal added a comment. If `getStmtForDiagnostics()` in general, never returns null, then shouldn't we mark the API with an appropriate attribute? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157888/new/ https://reviews.llvm.org/D157888

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

steakhal added a comment. Hmm. I guess the assertion is to silence some tool. And I think actually that function might very well also return null in some cases. Why do you think it cannot or at least should not return null in your context? I couldn't infer this from the context, neither from

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

MaskRay added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

[clang] cf2cf19 - [Profile] Allow online merging with debug info correlation.

Author: Zequan Wu Date: 2023-08-14T15:15:01-04:00 New Revision: cf2cf195d5fb0a07c122c5c274bd6deb0790e015 URL: https://github.com/llvm/llvm-project/commit/cf2cf195d5fb0a07c122c5c274bd6deb0790e015 DIFF: https://github.com/llvm/llvm-project/commit/cf2cf195d5fb0a07c122c5c274bd6deb0790e015.diff

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2cf195d5fb: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

dblaikie added inline comments. Comment at: clang/lib/AST/Decl.cpp:4510-4512 +for (const FieldDecl *Field : CXXRD->fields()) + if (Field->getType()->getAsCXXRecordDecl()) +return false; maybe `llvm::any_of`? Not especially shorter, but maybe

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. In D157280#4586078 , @MaskRay wrote: > Please add a link to https://reviews.llvm.org/D87737 in the summary/commit > message. Will do! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski updated this revision to Diff 550047. awarzynski added a comment. Add missing `TargetSpecific` flag to the definition of `mcpu_EQ`, remove redundant `TODO` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski marked 2 inline comments as done. awarzynski added a comment. Thank you all for reviewing! In D157837#4584387 , @bogner wrote: > I can't speak to which flags should be present in flang-new or not That's determined by what's tested/used in

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

arsenm added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 +else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } shenhan wrote: > arsenm wrote: > > You cannot spam warnings

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

MaskRay added a comment. Please add a link to https://reviews.llvm.org/D87737 in the summary/commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

bob80905 added a comment. Release note for addition of exp10 builtin? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. I think the best place to test `RISCVISAInfo.cpp` is `llvm/unittests/Support/RISCVISAInfoTest.cpp`. `clang/test/Driver/print-supported-extensions.c` can test just a few lines, so that changes to RISC-V extensions will generally not require updates to

[PATCH] D150262: Disable sanitizer's on ifunc resolvers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ef3de6b09f6: Disable sanitizers on ifunc resolvers. (authored by danielkiss). Herald added a project: clang. Herald added a subscriber:

[clang] 1ef3de6 - Disable sanitizer's on ifunc resolvers.

Author: Daniel Kiss Date: 2023-08-14T20:56:55+02:00 New Revision: 1ef3de6b09f6b21a383fc7cf1ce1283df738015a URL: https://github.com/llvm/llvm-project/commit/1ef3de6b09f6b21a383fc7cf1ce1283df738015a DIFF: https://github.com/llvm/llvm-project/commit/1ef3de6b09f6b21a383fc7cf1ce1283df738015a.diff

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

arsenm created this revision. arsenm added reviewers: jcranmer-intel, kpn, sepavloff, andrew.w.kaylor, foad, bob80905. Herald added a subscriber: StephenFan. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D157911

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true,

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 550039. zequanwu marked 3 inline comments as done. zequanwu added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files:

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4522 RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); + + Keep just one blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

nhaehnle abandoned this revision. nhaehnle added a comment. Indeed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86154/new/ https://reviews.llvm.org/D86154 ___ cfe-commits mailing list

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5831 +FoundTemplate->getFriendObjectKind() != Decl::FOK_None && +!D->specializations().empty(); +if (IsStructuralMatch(D, FoundTemplate, true, IgnoreDepth)) {

[PATCH] D157207: [clangd] Fix typo in comment

This revision was automatically updated to reflect the committed changes. Closed by commit rG09a622baa2d8: [clangd] Fix typo in comment (authored by Eymay, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157207/new/

[clang-tools-extra] 09a622b - [clangd] Fix typo in comment

Author: Eymen Ünay Date: 2023-08-14T20:07:58+02:00 New Revision: 09a622baa2d80ccc38eb42b6b58b39519704399f URL: https://github.com/llvm/llvm-project/commit/09a622baa2d80ccc38eb42b6b58b39519704399f DIFF: https://github.com/llvm/llvm-project/commit/09a622baa2d80ccc38eb42b6b58b39519704399f.diff

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. So, as I understand the discussion, after this patch, it will still be possible to get dwarf and codeview in the same compile, but users will have to resort to cc1 flags. I think that's a good end

[PATCH] D156205: [clang][WebAssembly] Link crt1 even in case of -shared

sbc100 added a comment. (update change title to use the `[clang][WebAssembly]`convention) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 ___ cfe-commits

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5496 + // execution of the await_suspend. To achieve this, we need to prevent the + // await_suspend get inlined before CoroSplit pass. + // Suggestion: > The `await_suspend` call

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky updated this revision to Diff 550030. jcsxky added a comment. fixed according to the review and add testcase to StructuralEquivalenceTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:665 +let Predicates = [HasStdExtZicfilp] in { +def : InstAlias<"lpad $imm20", (AUIPC X0, uimm20:$imm20)>; There is a designated spot in this file for InstAliases.

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c:24 + +// RUN: rm -rf %t.profdir && mkdir %t.profdir + Let's move this line down since we don't use it until line 31. Comment at:

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7261 +/// Matches macro qualified types. +/// How about: Matches qualified types when the qualifier is applied via a macro. and then a second example like: ``` int

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Despite being true positives, these results just confuse users. So

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman added a comment. In D157793#4585685 , @iana wrote: > In D157793#4585268 , @aaron.ballman > wrote: > >> In D157793#4583698 , @iana wrote: >> >>> In

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

smeenai added a subscriber: mstorsjo. smeenai added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments

[PATCH] D157904: Improve reliability of CompilationDatabaseTest

ellis created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. ellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157904 Files:

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added a comment. > If no suitable integer type is found in the target, no debug information is > emitted anymore in order to prevent wrong debug output. Why is emitting a bitfield type not an option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-structured-binding-bitfield.cpp:525 +// CHECK: !202 = !DILocation(line: 279, column: 8, scope: !194) +// CHECK: !203 = !DILocation(line: 279, column: 17, scope: !194) +// CHECK: !204 = !DILocation(line:

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 550013. artem marked 5 inline comments as done. artem edited the summary of this revision. artem added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files:

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

kadircet added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:122 llvm::DenseSet SeenSymbols; + std::string ResourceDir = HS->getHeaderSearchOpts().ResourceDir; // FIXME: Find a way to have less code duplication between

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added a comment. In D157793#4585268 , @aaron.ballman wrote: > In D157793#4583698 , @iana wrote: > >> In D157793#4583663 , @MaskRay >> wrote: >> Apple needs a

[clang] 700ca0e - [NFC] Red Hat is two words

Author: Josh Stone Date: 2023-08-14T10:10:10-07:00 New Revision: 700ca0e7432d4ef485900f16d9f051e2bbc8523c URL: https://github.com/llvm/llvm-project/commit/700ca0e7432d4ef485900f16d9f051e2bbc8523c DIFF: https://github.com/llvm/llvm-project/commit/700ca0e7432d4ef485900f16d9f051e2bbc8523c.diff

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti marked an inline comment as done. 5chmidti added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:91 + +// Local variables declared inside of the selected lambda cannot go out of +// scope. The DeclRefExprs that are

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

smeenai added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong

[PATCH] D156784: [AArch64][PAC] Declare FPAC subtarget feature

atrosinenko planned changes to this revision. atrosinenko added a comment. Looks like adding FeatureFPAC may require changes in more places - need to investigate whether I have to add something like AEK_FPAC constant, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. In D155290#4582825 , @MaskRay wrote: > Using `%p` should not magically change the behavior and I am unsure the > result is better for PGO. > If we decide to provide such a mode, it needs to be opt-in by adding a new >

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

reames added inline comments. Comment at: llvm/docs/RISCVUsage.rst:120 ``Zicboz`` Assembly Support + ``Zicfilp`` Assembly Support ``Zicntr`` (`See Note <#riscv-i2p1-note>`__) This in the wrong place; this is not a ratified

[PATCH] D155081: Specify the developer policy around links to external resources

tonic added a comment. @lattner Please review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added a comment. In D86993#4584619 , @nikic wrote: > @aaron.ballman I wanted to check back whether the linked document is what you > had in mind, or whether some more/else would be needed. Sorry about the delayed review; this fell off my

[PATCH] D156205: wasm: link crt1 even in case of -shared

This revision was automatically updated to reflect the committed changes. Closed by commit rG989ce069a463: [clang][WebAssembly] Link crt1 even in case of -shared (authored by yamt, committed by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 989ce06 - [clang][WebAssembly] Link crt1 even in case of -shared

Author: YAMAMOTO Takashi Date: 2023-08-14T09:36:44-07:00 New Revision: 989ce069a4638fd561bebc95f478ca9e45154fec URL: https://github.com/llvm/llvm-project/commit/989ce069a4638fd561bebc95f478ca9e45154fec DIFF:

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

nridge added a comment. I understood https://github.com/clangd/clangd/issues/1344 as being about `workspace/symbol` rather than `textDocument/documentSymbol`, though I see now that both are affected. The analysis is a bit different for the two, though: unlike `DocumentSymbol`, the result

[clang] 0c3a02b - Function multi-versioning: disable ifunc for ELF targets other than glibc/Android/FreeBSD

Author: Fangrui Song Date: 2023-08-14T08:59:59-07:00 New Revision: 0c3a02b8c09bb408a74a638a263e51d67c92ca74 URL: https://github.com/llvm/llvm-project/commit/0c3a02b8c09bb408a74a638a263e51d67c92ca74 DIFF: https://github.com/llvm/llvm-project/commit/0c3a02b8c09bb408a74a638a263e51d67c92ca74.diff

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549979. aaron.ballman added a comment. Tweaked wording to link to the policy about adding links to github issues in commit messages instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files:

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 549978. donat.nagy marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 Files: clang/docs/analyzer/checkers.rst

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked 13 inline comments as done. donat.nagy added a comment. I handled the inline comments, I'll check the example code and edit the release notes tomorrow. Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:272 + if (const auto ConcreteRight

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

balazske added a comment. It is better to add a test to ASTImporterTests.cpp with the same code, and check the properties of DeclContext and LexicalDeclContext in the From and To AST (should be the same in "From" and "To" side). Comment at: clang/lib/AST/ASTImporter.cpp:6451

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157888/new/ https://reviews.llvm.org/D157888 ___ cfe-commits

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 ___ cfe-commits

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks fine to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157885/new/ https://reviews.llvm.org/D157885 ___ cfe-commits

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: steakhal, abrachet, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews

[PATCH] D157855: [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

tbaeder added a comment. Generally LGTM, but I feel like the changes aren't c++2a specific (except for uninitialized variables in constexpr functions). Comment at: clang/lib/AST/ExprConstant.cpp:4447 + Info.FFDiag(E, diag::note_constexpr_access_uninit) + <<

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman added a comment. In D157793#4583698 , @iana wrote: > In D157793#4583663 , @MaskRay wrote: > >>> Apple needs a __need_ macro for va_list. Add one, and also ones for >>> va_start/va_arg/va_end,

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews updated this revision to Diff 549960. eandrews added a comment. Applied review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 Files: clang/lib/Sema/SemaExprCXX.cpp Index: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4581219 , @ellis wrote: > In D157632#4580576 , @zequanwu > wrote: > >> BTW, I noticed something strange with `-pgo-function-entry-coverage` when >> merging via

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

ealcdan added a comment. Thanks for the review. How should I procceed? Should I remove the "Fixes:" entry from the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157869/new/ https://reviews.llvm.org/D157869

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman added a subscriber: ldionne. aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:16 +defined(__need_wint_t) || \ +(defined(__STDC_WANT_LIB_EXT1__) && __STDC_WANT_LIB_EXT1__ >= 1)

[clang] d7fcb5b - clang: Don't use grep in a test

Author: Matt Arsenault Date: 2023-08-14T11:28:41-04:00 New Revision: d7fcb5b6b5280dc61d5afe0920bb78a82cfe2f27 URL: https://github.com/llvm/llvm-project/commit/d7fcb5b6b5280dc61d5afe0920bb78a82cfe2f27 DIFF:

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc0f99f3bc9: [Driver] Default riscv*- triples to -fdebug-default-version=4 (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D157663?vs=549233=549956#toc Repository: rG LLVM

[clang] bbc0f99 - [Driver] Default riscv*- triples to -fdebug-default-version=4

Author: Fangrui Song Date: 2023-08-14T08:26:52-07:00 New Revision: bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6 URL: https://github.com/llvm/llvm-project/commit/bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6 DIFF: https://github.com/llvm/llvm-project/commit/bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6.diff

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157808/new/ https://reviews.llvm.org/D157808 ___ cfe-commits mailing

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay added a comment. Thanks for the update. Regarding testing, it seems that unittests will be more convenience than creating so many placeholder files in `Inputs/`. `clang/unittests/Driver/ToolChainTest.cpp` `TEST(ToolChainTest, VFSGCCInstallation)` has an example for Linux. You can add

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. eandrews requested review of this revision.

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783 ___ cfe-commits mailing

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added inline comments. Comment at: clang/test/lit.cfg.py:391 if "system-aix" in config.available_features: -config.substitutions.append(("llvm-nm", "env OBJECT_MODE=any llvm-nm")) -config.substitutions.append(("llvm-ar", "env OBJECT_MODE=any llvm-ar")) +

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

kadircet added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3026 + void ActOnParamDefaultArgumentError(Decl *param, SourceLocation EqualLoc, + ExprResult DefaultArg); ExprResult ConvertParamDefaultArgument(ParmVarDecl

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

kadircet updated this revision to Diff 549939. kadircet marked 2 inline comments as done. kadircet added a comment. - Use Expr* instead of ExprResult - Add dump test to demonstrate new RecoveryExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 549938. DiggerLin marked 4 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

PiotrZSL added a comment. I agree that this change is an improvement that is welcome, but that's not a fix for a #60217. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157869/new/ https://reviews.llvm.org/D157869

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

PiotrZSL added a comment. This wont fix issue, simply because problem happen during reading -1, not during dumping, and per documentation -1 was a valid value. Same issue happen in other checks that use -1. Most probably best way would be to change those variables into std::int64_t, in C++

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this change clang didn't emit missing-field-initializers warning for designated initializers. The comments say

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Review taken into account. Thanks for handling this batch of patches o/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille updated this revision to Diff 549929. serge-sans-paille added a comment. Only output extra fields if they are not empty CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783 Files: clang/include/clang/AST/JSONNodeDumper.h

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); Anastasia wrote: > pmatos wrote: > > Keenuts wrote: > > > pmatos wrote: > > > > I am not well-versed in SPIRV

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 549925. ro added a comment. Herald added a subscriber: mgrang. Updated based on discussions in Issue #53709: - Sort Solaris GCC prefixes in reverse version order so the latest version is picked. - Update testcase to match. Tested on `amd64-pc-solaris2.11` and

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. In D153701#4563919 , @yronglin wrote: > Sorry for the late reply. I tried to investigate the memory impact of > creating these additional materializations by build the whole llvm-project > and compare the number of

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG421c9bbf65b7: [NFC][Clang] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 421c9bb - [NFC][Clang] Fix static analyzer concern

Author: Elizabeth Andrews Date: 2023-08-14T07:14:32-07:00 New Revision: 421c9bbf65b78e3410415cac2edf4e00bd4d38ca URL: https://github.com/llvm/llvm-project/commit/421c9bbf65b78e3410415cac2edf4e00bd4d38ca DIFF:

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added a comment. Pre-merge check fails are unrelated - fatal error C1060: compiler is out of heap space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157454/new/ https://reviews.llvm.org/D157454 ___ cfe-commits mailing list

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, recoveryexpr is a better fit here. These changes tend to cause occasional new error-handling crashes on under-tested paths, but I guess it's a good time in the release cycle for

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

asb accepted this revision. asb added a comment. LGTM, this seems like a good workaround. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157663/new/ https://reviews.llvm.org/D157663 ___ cfe-commits

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

ealcdan created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ealcdan requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Some options

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

kadircet created this revision. kadircet added reviewers: sammccall, aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This makes

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

florianhumblot abandoned this revision. florianhumblot added a comment. @sammccall I guess you're right, I'll look into getting a fix into vscode instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157080/new/ https://reviews.llvm.org/D157080

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157781/new/ https://reviews.llvm.org/D157781

[PATCH] D157775: [clang] Add aliasee field to AliasAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157775/new/ https://reviews.llvm.org/D157775

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman added a comment. In D112921#4581641 , @rnk wrote: > What are the next steps here? Have concerns been addressed? The CI failures > seem unrelated (libcxx tests is an AIX bot out of disk, clang CI is an > interpreter test that seems

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

aaron.ballman added inline comments. Comment at: clang/lib/AST/JSONNodeDumper.cpp:541-548 +void JSONNodeDumper::VisitDeprecatedAttr(const DeprecatedAttr *DA) { + JOS.attribute("message", DA->getMessage()); + JOS.attribute("replacement", DA->getReplacement()); +} + +void

<    1   2   3   >