[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei added a comment. Ping~ It looks to me there's no concern about this solution in the RFC . I think we can move forward to land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei added a subscriber: aaron.ballman. pengfei added a comment. BTW, maybe @aaron.ballman knows why we don't support such syntax in C++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 ___

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 ___ cfe-commits mailing list

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550607. Amir added a comment. perf2prof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake

[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC

This revision was automatically updated to reflect the committed changes. Closed by commit rGe17667b33f1f: [Driver][DXC] Remove a bunch of options from DXC (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158037/new/

[clang] e17667b - [Driver][DXC] Remove a bunch of options from DXC

Author: Justin Bogner Date: 2023-08-15T21:38:20-07:00 New Revision: e17667b33f1f37354a19be6b09d6812a61a66e2a URL: https://github.com/llvm/llvm-project/commit/e17667b33f1f37354a19be6b09d6812a61a66e2a DIFF: https://github.com/llvm/llvm-project/commit/e17667b33f1f37354a19be6b09d6812a61a66e2a.diff

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16867-16868 +/// Convert character's code unit value to a string. +/// The code point needs to be zero-extended to 32-bits. +static void WriteCharValueForDiagnostic(uint32_t Value, const

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 marked 3 inline comments as done. kaz7 added inline comments. Comment at: clang/include/clang/Driver/Options.td:5166 +// VE feature flags +let Flags = [TargetSpecific, CC1Option] in { +def mvevpu : Flag<["-"], "mvevpu">, Group, MaskRay wrote: > Other

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 updated this revision to Diff 550588. kaz7 added a comment. Update to follow suggestions. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 Files: clang/include/clang/Driver/Options.td

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate updated this revision to Diff 550587. lygstate added a comment. Revert to version 1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 Files: clang/lib/Headers/bmiintrin.h Index: clang/lib/Headers/bmiintrin.h

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei added a comment. In D157297#4590692 , @lygstate wrote: > In D157297#4590580 , @pengfei wrote: > >> > > > >> I'd prefer macro to duplicated definitions. We have such precedents, e.g., >>

[PATCH] D158047: [clang][ASTImporter] Add import of 'BitIntType'

strimo378 added a comment. I think the ASTImporter class has in general a completion problem. What do you think about rewriting it that any missing Visit* function for Type, Decl and Stmt produces an compiler error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158047: [clang][ASTImporter] Add import of 'BitIntType'

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate added a comment. In D157297#4590580 , @pengfei wrote: > > I'd prefer macro to duplicated definitions. We have such precedents, e.g., > https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/xmmintrin.h#L2994 Do you means revert

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. gracemont has some

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550578. fakepaper56 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan created this revision. jacquesguan added reviewers: DavidTruby, efriedma, peterwaller-arm, paulwalker-arm, bsmith, c-rhodes, sdesmalen, rsandifo-arm, ctetreau, cameron.mcinally, aaron.ballman. Herald added a subscriber: psnobl. Herald added a project: All. jacquesguan requested

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:417 + continue; +} else if (Feature.startswith("no-")) + Ret.Features.push_back("-" + Feature.split("-").second.str()); Is this tested? I don't see any "no-" in the

[PATCH] D152423: [RISCV] Add function that check extension name with version

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152423/new/ https://reviews.llvm.org/D152423

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei added a comment. I'd prefer macro to duplicated definitions. We have such precedents, e.g., https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/xmmintrin.h#L2994 Besides, you should update the summary as well. CHANGES SINCE LAST ACTION

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:88 + +let Predicates = [HasStdExtZicfiss, HasStdExtC] in { +let Uses = [SSP], Defs = [SSP], hasSideEffects = 0, mayLoad = 0, mayStore = 1 in craig.topper wrote: > Is

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

This revision was automatically updated to reflect the committed changes. Closed by commit rG818e76d6f2dd: [RISCV] Add MC layer support for Zicfilp. (authored by fakepaper56). Changed prior to commit: https://reviews.llvm.org/D157362?vs=550089=550562#toc Repository: rG LLVM Github Monorepo

[clang] 818e76d - [RISCV] Add MC layer support for Zicfilp.

Author: Yeting Kuo Date: 2023-08-16T08:52:51+08:00 New Revision: 818e76d6f2dd90362e71e84f492c167958ef3257 URL: https://github.com/llvm/llvm-project/commit/818e76d6f2dd90362e71e84f492c167958ef3257 DIFF: https://github.com/llvm/llvm-project/commit/818e76d6f2dd90362e71e84f492c167958ef3257.diff

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 added a comment. HI @PiotrZSL, I do not have the rights to commit to the LLVM repository. Could you please commit those changes for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 updated this revision to Diff 550559. felix642 added a comment. Updated format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829 Files:

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

denik added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:528-529 +if (Field->getDeclName() == NameInfo.getName()) { + if (const PackExpansionType *PET = + dyn_cast(Field->getType())) { +isMemberPack = true;

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa2c701b5dc0: [Driver] move Haiku header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo CHANGES

[clang] aa2c701 - [Driver] move Haiku header search path management to the driver

Author: Brad Smith Date: 2023-08-15T19:58:40-04:00 New Revision: aa2c701b5dc04330b8ec4084a94d7cbe9cc938eb URL: https://github.com/llvm/llvm-project/commit/aa2c701b5dc04330b8ec4084a94d7cbe9cc938eb DIFF: https://github.com/llvm/llvm-project/commit/aa2c701b5dc04330b8ec4084a94d7cbe9cc938eb.diff

[clang] 1e4d612 - [CMake] Add a few more missing dependencies on ClangDriverOptions

Author: Jon Roelofs Date: 2023-08-15T16:56:31-07:00 New Revision: 1e4d6122cda6529781ecf467c2ae84e5dd41acdf URL: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf DIFF: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf.diff

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

dexonsmith added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:32 + +class RVC_SSInst rs1, RegisterClass reg_class, string opcodestr> : + RVInst16<(outs), (ins reg_class:$rs1), opcodestr, "$rs1", [], InstFormatOther> { Can you

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:88 + +let Predicates = [HasStdExtZicfiss, HasStdExtC] in { +let Uses = [SSP], Defs = [SSP], hasSideEffects = 0, mayLoad = 0, mayStore = 1 in Is it compatible with

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 550547. ZijunZhao added a comment. 1. rename to .c file 2. create clang/test/C/C2x/n2683.c and add codegen tests and semantic tests 3. update clang/docs/ReleseNotes.rst 4. update clang/www/c_status.html 5. reformat PPDirectives.cpp 6. set __STDC_VERSION__

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362

[PATCH] D157582: [Driver][DXC] Handle -Fo and -Fc flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb6fe61be3de: [Driver][DXC] Handle -Fo and -Fc flags (authored by bogner). Changed prior to commit: https://reviews.llvm.org/D157582?vs=548879=550545#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] cb6fe61 - [Driver][DXC] Handle -Fo and -Fc flags

Author: Justin Bogner Date: 2023-08-15T16:37:17-07:00 New Revision: cb6fe61be3dee67bb8b080c73dd2c48f2d0ce2c7 URL: https://github.com/llvm/llvm-project/commit/cb6fe61be3dee67bb8b080c73dd2c48f2d0ce2c7 DIFF: https://github.com/llvm/llvm-project/commit/cb6fe61be3dee67bb8b080c73dd2c48f2d0ce2c7.diff

[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550532. Amir added a comment. Append to PGO_OPT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake

[PATCH] D150262: Disable sanitizer's on ifunc resolvers.

farzon added a comment. I feel like this change will break our use case and do so in a nontransparent way. We want to be able to use sanitizers even if IFUNC indirection is defined. So if the compiler toolchain is now going to disable santizer instrumentation overriding the preferences of the

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman updated this revision to Diff 550529. aidengrossman added a comment. Hoist _MSC_EXTENSIONS macro logic even further and add release note on chages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157334/new/

[PATCH] D155647: [RISCV] Add C intrinsics for scalar bitmanip and crypto

VincentWu added a comment. LGTM, But waiting for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 ___ cfe-commits mailing list

[clang] 95ab1cd - [Driver][DXC] Use the existing help and macro definition options. NFC

Author: Justin Bogner Date: 2023-08-15T16:04:50-07:00 New Revision: 95ab1cd712c27fc0c56f7b88a53e95e6e714ff36 URL: https://github.com/llvm/llvm-project/commit/95ab1cd712c27fc0c56f7b88a53e95e6e714ff36 DIFF: https://github.com/llvm/llvm-project/commit/95ab1cd712c27fc0c56f7b88a53e95e6e714ff36.diff

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay updated this revision to Diff 550521. mdfazlay added a comment. Updated nesting of regions checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933 Files: clang/include/clang-c/Index.h

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx updated this revision to Diff 550516. AlexVlx added a comment. Remove unneeded cast, the dynamic case already emitted a generic pointer to `typeinfo` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157452/new/ https://reviews.llvm.org/D157452 Files:

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor visitation for C++ record children by following

[PATCH] D157018: [-Wunsafe-buffer-usage] Replace assert that declarations are always found

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1c64b94d94: [-Wunsafe-buffer-usage] Replace assert that declarations are always found (authored by t-rasmud). Herald added a project: clang.

[clang] cf1c64b - [-Wunsafe-buffer-usage] Replace assert that declarations are always found

Author: Rashmi Mudduluru Date: 2023-08-15T15:41:56-07:00 New Revision: cf1c64b94d94105f61e308e57eb963b722d22d77 URL: https://github.com/llvm/llvm-project/commit/cf1c64b94d94105f61e308e57eb963b722d22d77 DIFF:

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Visit and serialize C++ fields by checking if a var

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 updated this revision to Diff 550500. evelez7 added a comment. Fix arbitrary include changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158027/new/ https://reviews.llvm.org/D158027 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/CodeGen/ubsan-function-attributed.c:3 + +// CHECK: .long248076293 +void __attribute__((ms_abi)) f(void) {} It's useful to add `// CHECK-LABEL: f:` interleaving with

[clang] 95ae517 - [Driver] Remove CLDXCFlag by allowing CLFlag to specify visibility. NFC

Author: Justin Bogner Date: 2023-08-15T15:00:19-07:00 New Revision: 95ae517bb4c332149b3c45cd7d1e6edf8b40077e URL: https://github.com/llvm/llvm-project/commit/95ae517bb4c332149b3c45cd7d1e6edf8b40077e DIFF: https://github.com/llvm/llvm-project/commit/95ae517bb4c332149b3c45cd7d1e6edf8b40077e.diff

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Visit and serialize method templates and template

[clang] 44e6c11 - [Driver] Remove -coverage-notes-file and -coverage-data-file in favor of their Joined = form

Author: Fangrui Song Date: 2023-08-15T14:58:55-07:00 New Revision: 44e6c114d974c80e4a88c1b93bfe646ac9b6d08d URL: https://github.com/llvm/llvm-project/commit/44e6c114d974c80e4a88c1b93bfe646ac9b6d08d DIFF: https://github.com/llvm/llvm-project/commit/44e6c114d974c80e4a88c1b93bfe646ac9b6d08d.diff

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf added a comment. @sammccall Thank you very much for your valuable input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 ___ cfe-commits mailing list

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf added inline comments. Comment at: clang/include/clang/Frontend/ASTUnit.h:901 +SmallVectorImpl , +std::function AfterBeginSourceFile = [](CompilerInstance& CI) -> void {}); sammccall wrote: > capfredf wrote: >

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 550489. capfredf marked 7 inline comments as done. capfredf added a comment. address @sammccall 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files:

[clang] 64473f1 - [gcov] Use Joined = form for -coverage-notes-file and -coverage-data-file

Author: Fangrui Song Date: 2023-08-15T14:49:02-07:00 New Revision: 64473f1221fbc16af140407d5ea64d808f5853a7 URL: https://github.com/llvm/llvm-project/commit/64473f1221fbc16af140407d5ea64d808f5853a7 DIFF: https://github.com/llvm/llvm-project/commit/64473f1221fbc16af140407d5ea64d808f5853a7.diff

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 updated this revision to Diff 550485. evelez7 added a comment. Get rid of unnecessary function for checking if global var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 Files:

[PATCH] D157917: clang/HIP: Use abs builtins instead of implementing them

arsenm closed this revision. arsenm added a comment. 43f314f5e6cebe02ff63d5197c8e5c25204b20d2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157917/new/ https://reviews.llvm.org/D157917

[clang] 43f314f - clang/HIP: Use abs builtins instead of implementing them

Author: Matt Arsenault Date: 2023-08-15T17:40:19-04:00 New Revision: 43f314f5e6cebe02ff63d5197c8e5c25204b20d2 URL: https://github.com/llvm/llvm-project/commit/43f314f5e6cebe02ff63d5197c8e5c25204b20d2 DIFF:

[clang] c49142e - Fix truncated __OPENMP_NVPTX__ preprocessor condition

Author: Ryan Burns Date: 2023-08-15T14:12:34-07:00 New Revision: c49142e4f5c8645a4d741d233f0cb55ef1ef87a2 URL: https://github.com/llvm/llvm-project/commit/c49142e4f5c8645a4d741d233f0cb55ef1ef87a2 DIFF: https://github.com/llvm/llvm-project/commit/c49142e4f5c8645a4d741d233f0cb55ef1ef87a2.diff

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

rapidsna accepted this revision. rapidsna added a comment. This revision is now accepted and ready to land. The changes look good to me. Ideally, we could add tests with multiple attributes and possibly with other sugar types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

usama54321 updated this revision to Diff 550477. usama54321 added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157445/new/ https://reviews.llvm.org/D157445 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

benlangmuir updated this revision to Diff 550474. benlangmuir added a reviewer: vsapsai. benlangmuir added a comment. Add missing test updates: tests using the `Inputs/System/usr/include` should be using `-internal-isystem` to get the correct search path order with respect to the resource dir.

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

usama54321 updated this revision to Diff 550475. usama54321 retitled this revision from "[CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash." to "[CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.". usama54321

[PATCH] D95299: Fix truncated __OPENMP_NVPTX__ preprocessor condition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc49142e4f5c8: Fix truncated __OPENMP_NVPTX__ preprocessor condition (authored by r-burns, committed by mehdi_amini). Repository: rG LLVM Github

[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

iana added a subscriber: vsapsai. iana added a comment. Herald added a subscriber: ormris. Can you add @vsapsai to the reviewers please? He was looking at this one a year or two ago. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158021/new/

[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

benlangmuir created this revision. benlangmuir added reviewers: iana, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like the other enumerated builtin headers, inttypes.h can be

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added a comment. Thanks for the feedback. Comment at: clang/test/SemaCXX/warn-constant-evaluated-constexpr.cpp:38 constexpr int fn5() { - if constexpr (__builtin_is_constant_evaluated()) // expected-warning {{'__builtin_is_constant_evaluated' will always evaluate

[clang] cda3198 - [clang] Add missing field to TLSModelAttr json AST dump

Author: serge-sans-paille Date: 2023-08-15T22:24:42+02:00 New Revision: cda319851fe7facf603c3930d5587e127d46b3b7 URL: https://github.com/llvm/llvm-project/commit/cda319851fe7facf603c3930d5587e127d46b3b7 DIFF:

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

cjdb added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3292 + std::string NewFieldName = + PackedField->getName().str() + "@" + std::to_string(Arg); + PackedField->setDeclName((NewFieldName)); Does LLVM

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet updated this revision to Diff 550443. hazohelet added a comment. Removed warning fixes that are now in D158016 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 Files: clang/docs/ReleaseNotes.rst

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0db9dfb19329: [Driver] Update BoolOption to handle Visibility. NFC (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158016: [NFC] Remove unused variables declared in conditions

hazohelet created this revision. hazohelet added reviewers: nikic, aaron.ballman, MaskRay, tbaeder. Herald added subscribers: hoy, wlei, steakhal, abrachet, ormris, StephenFan, martong, hiraditya. Herald added a reviewer: NoQ. Herald added projects: lld-macho, All. Herald added a reviewer:

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but do not remove the Attribute from our set, add it to the tests. The functions are nounwind. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:532

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

rjmccall accepted this revision. rjmccall added a comment. Thank you, this seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157379/new/ https://reviews.llvm.org/D157379 ___ cfe-commits

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

rjmccall added a comment. If we're avoiding the expense here when we're not emitting incremental extensions, this seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

nikic added a comment. Please split the warning fixes off into a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added a comment. New test LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/ https://reviews.llvm.org/D157479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet updated this revision to Diff 550433. hazohelet added a comment. Herald added subscribers: llvm-commits, wangpc, hoy, wlei, steakhal, abrachet, ormris, martong, MaskRay, hiraditya. Herald added a reviewer: NoQ. Herald added projects: LLVM, lld-macho. Herald added a reviewer: lld-macho.

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev added a comment. In D156537#4587874 , @aaron.ballman wrote: > In D156537#4587832 , @v.g.vassilev > wrote: > >> @Hahnfeld, let's move forward and rely on a post-commit review here if >> necessary.

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ https://reviews.llvm.org/D156897

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan marked 3 inline comments as done. shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass());

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550423. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

lei added a comment. @nickdesaulniers I have verified this patch on top of `40ee8abee77a2e8fb0089d4c7f5723b71f27d416` passes our multistage bot http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage Thank-you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks for the patch, but there are two issues that should be fixed: (1) stat => fstat (2) change the subject to mean that this is not AIX specific (`[LLVM][Support] Report EISDIR

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate updated this revision to Diff 550413. lygstate added a comment. creating proper function definitions instead of macro define CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 Files: clang/lib/Headers/bmiintrin.h Index:

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added inline comments. Comment at: flang/lib/Decimal/CMakeLists.txt:52 -add_flang_library(FortranDecimal INSTALL_WITH_TOOLCHAIN - binary-to-decimal.cpp - decimal-to-binary.cpp -) +add_compile_options(-fPIC) + efriedma wrote: > This

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

tahonermann added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +// mismatch relies on resolving the real path and checking that casing differs. +// If we use %t and we

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty created this revision. overmighty added reviewers: dmgreen, john.brawn, SjoerdMeijer. Herald added subscribers: arphaman, hiraditya, kristof.beyls. Herald added a project: All. overmighty requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

efriedma added a comment. The test changes look good to me. Comment at: flang/lib/Decimal/CMakeLists.txt:52 -add_flang_library(FortranDecimal INSTALL_WITH_TOOLCHAIN - binary-to-decimal.cpp - decimal-to-binary.cpp -) +add_compile_options(-fPIC) + This

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

steakhal accepted this revision. steakhal added a comment. In D156312#4588406 , @donat.nagy wrote: > After investigating this issue, I added the testcases > `signed_aritmetic_{good,bad}` which document the current sub-optimal state. > The root cause

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet updated this revision to Diff 550403. hazohelet marked 16 inline comments as done. hazohelet added a comment. Address some review comments - Renamed `ConvertCharToString` to `WriteCharValueForDiagnostic` - Made the function static - Fixed the printing for unicode 0x80 ~ 0xFF - Added

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 550402. azhan92 added a comment. Address TOCTOU condition (will add updated test later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files:

[PATCH] D158006: Member pack access in dependent context.

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158006 Files:

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added a comment. In order to keep the scope of this patch manageable, and because further discussion is warranted first, no source files have been moved from flang into flang-rt. Although I would imagine that this may be something we would want to do in the future in order to continue

[clang] cad3130 - [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier)

Author: Timo Stripf Date: 2023-08-15T17:36:33Z New Revision: cad3130a23daa023d5bbf42b8ec8c06aa0532abf URL: https://github.com/llvm/llvm-project/commit/cad3130a23daa023d5bbf42b8ec8c06aa0532abf DIFF: https://github.com/llvm/llvm-project/commit/cad3130a23daa023d5bbf42b8ec8c06aa0532abf.diff LOG:

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver added a comment. @nikic Thanks for responding. I will get a "work in progress" patch up in the next three days. In the API adaptation, instruction insertion is still being handled in the caller as some passes are only allowed removal and not insertion. Repository: rG LLVM Github

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added a comment. Some of the testcases have been reformatted by clang-format when I updated the patch with arcanist. If the community is against introducing extra changes like these I would be happy to re-update my patch without clang-formatting these files. Repository: rG LLVM

  1   2   3   >