[PATCH] D151834: Include math-errno with fast-math

uabelho added a comment. In D151834#4644692 , @zahiraam wrote: > [...] >> I think the issue comes from here: >> https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGBuiltin.cpp#L2365 > > This looks like it's happening only for -Oi

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515 + QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U, UnaryTransformType::RemoveCVRef, {}), {}); + return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr,

[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

iana requested changes to this revision. iana added a comment. This revision now requires changes to proceed. I was talking to Ben about this one a little today since I ended up needing to make the same `-isystem`/`-I` -> `-internal-isystem` switch in some of the unit tests in D159064

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

This revision was automatically updated to reflect the committed changes. Closed by commit rGca8d2533c79c: [clang-repl][Orc] Export executable symbols in… (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/

[clang] ca8d253 - [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

Author: Kai Luo Date: 2023-09-13T05:24:20Z New Revision: ca8d2533c79ccfbcb2de4090f0d48914a60b0a3d URL: https://github.com/llvm/llvm-project/commit/ca8d2533c79ccfbcb2de4090f0d48914a60b0a3d DIFF: https://github.com/llvm/llvm-project/commit/ca8d2533c79ccfbcb2de4090f0d48914a60b0a3d.diff LOG:

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes emplace_back cannot construct an aggregate with arguments used to initialize the aggregate. Closes #62387 Test plan: Added test test from #62387 which contains code that should not be replaced by the check. -- Full diff:

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/ccotter updated https://github.com/llvm/llvm-project/pull/66169: >From d8c40ccc6744d350b8bc530917accd1d8d87118e Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Mon, 11 Sep 2023 00:05:54 -0400 Subject: [PATCH] [clang-tidy] Fix bug in modernize-use-emplace emplace_back

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/ccotter review_requested https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/ccotter review_requested https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/ccotter review_requested https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/ccotter review_requested https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/ccotter created https://github.com/llvm/llvm-project/pull/66169: emplace_back cannot construct an aggregate with arguments used to initialize the aggregate. Closes #62387 Test plan: Added test test from #62387 which contains code that should not be replaced by the check.

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

manosanag added a comment. Moved to https://github.com/llvm/llvm-project/pull/66098. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159480/new/ https://reviews.llvm.org/D159480 ___ cfe-commits mailing

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

sstwcw wrote: Who should I add for JS-related stuff? @mprobst seems to have stopped working on this project. @frigus02 can you have a look at this? https://github.com/llvm/llvm-project/pull/66168 ___ cfe-commits mailing list

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Dictionary literal keys and strings in TypeScript type declarations can not be broken. The problem was pointed out by @alexfh and @e-kud here: https://reviews.llvm.org/D154093#4644512 -- Full diff:

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In D154093#4644727 , @alexfh wrote: > This patch makes clang-format produce invalid JS/TS code > > In D154093#4644512 , @eaeltsin > wrote: > >> This introduces an invalid TS

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

https://github.com/sstwcw created https://github.com/llvm/llvm-project/pull/66168: Dictionary literal keys and strings in TypeScript type declarations can not be broken. The problem was pointed out by @alexfh and @e-kud here: https://reviews.llvm.org/D154093#4644512 >From

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

https://github.com/sstwcw review_requested https://github.com/llvm/llvm-project/pull/66168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66055: >From ed5150a69925dc3b6557796026a2820ac5c2e2f5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 12 Sep 2023 14:41:57 +0800 Subject: [PATCH 1/7] add --- .../bugprone/BugproneTidyModule.cpp

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -303,6 +303,10 @@ bool Module::directlyUses(const Module *Requested) { if (!Requested->Parent && Requested->Name == "_Builtin_stddef_max_align_t") return true; + // Anyone is allowed to use our builtin ptrauth.h and its accompanying module. + if

[clang] [ASTImport]improve ast comparation (PR #66110)

@@ -1295,6 +1306,21 @@ static bool IsStructurallyEquivalent(StructuralEquivalenceContext , return true; } +static bool IsStructurallyEquivalent(StructuralEquivalenceContext , jcsxky wrote: Thanks for your remind. Storage checking is added and other

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -303,6 +303,10 @@ bool Module::directlyUses(const Module *Requested) { if (!Requested->Parent && Requested->Name == "_Builtin_stddef_max_align_t") return true; + // Anyone is allowed to use our builtin ptrauth.h and its accompanying module. + if

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

https://github.com/MaskRay review_requested https://github.com/llvm/llvm-project/pull/66165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes For `c-header` and `c++-header` inputs, Clang driver selects the `-emit-pch` frontend action and defaults the output suffix name to `.gch` (except clang-cl, which uses `.pch`) to follow GCC. ``` clang -c a.h

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

MaskRay wrote: @madscientist https://github.com/llvm/llvm-project/pull/66165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTImport]improve ast comparation (PR #66110)

https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/66110: >From 999017a007b77efc6c4b2e643e82379c7c46ca2b Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 13 Sep 2023 00:03:27 +0800 Subject: [PATCH] improve ast comparation 1.VarDecl should not be ignored.

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

https://github.com/MaskRay review_requested https://github.com/llvm/llvm-project/pull/66165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

https://github.com/MaskRay review_requested https://github.com/llvm/llvm-project/pull/66165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/66165: For `c-header` and `c++-header` inputs, Clang driver selects the `-emit-pch` frontend action and defaults the output suffix name to `.gch` (except clang-cl, which uses `.pch`) to follow GCC. ``` clang -c a.h

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66162: >From afe74583e6f9a5bd785427204866367f3eac8620 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 19:22:30 -0500 Subject: [PATCH] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66162: >From a78d2d9459563cb2582502a4afefb74bbed1afa4 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 19:22:30 -0500 Subject: [PATCH] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -303,6 +303,10 @@ bool Module::directlyUses(const Module *Requested) { if (!Requested->Parent && Requested->Name == "_Builtin_stddef_max_align_t") return true; + // Anyone is allowed to use our builtin ptrauth.h and its accompanying module. + if

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/HerrCai0907 requested changes to this pull request. This check has some issue in my opinion, the semantic of `std::move(*p)` are not same as `*std::move(p)` ```c++ #include #include #include using std::unique_ptr; void f1() { unique_ptr p{new std::string("demo")};

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/HerrCai0907 requested changes to this pull request. This check has some issue in my opinion, the semantic of `std::move(*p)` are not same as `*std::move(p)` ```c++ #include #include #include using std::unique_ptr; void f1() { unique_ptr p{new std::string("demo")};

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

@@ -851,6 +851,50 @@ class ScanfDiagnosticFormatHandler } }; +/// `I` points to the next character of `%p` format. +/// This functon checks if the subsequent character can be linux kernel's +/// extnded format specifier +static inline constexpr bool

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid requested changes to this pull request. This looks like the wrong approach to me. I really think you should be splitting the warning into two parts, so that only the kernel developers see a change in diagnostic output. That would seem to make this patch simpler as

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,23 @@ +.. title:: clang-tidy - performance-move-smart-pointer-contents + +performance-move-smart-pointer-contents +=== + +Given a smart pointer containing a movable type, such as a +`std::unique_ptr`, it's possible to move the

[clang] [ASTImport]improve ast comparation (PR #66110)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTImport]improve ast comparation (PR #66110)

@@ -1295,6 +1306,21 @@ static bool IsStructurallyEquivalent(StructuralEquivalenceContext , return true; } +static bool IsStructurallyEquivalent(StructuralEquivalenceContext , shafik wrote: Should we also be checking the storage class and the various bits

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

keryell accepted this revision. keryell added a comment. Thanks for the clarifications. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes Summary: We use the 1llvm.amgcn.abi.version` varaible to control code generation. This is emitted in every module now to indicate what should be used when compiling. Previously, the logic caused us to emit an external

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/66162: Summary: We use the 1llvm.amgcn.abi.version` varaible to control code generation. This is emitted in every module now to indicate what should be used when compiling. Previously, the logic caused us to emit an

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 556619. void added a comment. This is ready for review. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/65996: >From fccf0643bd7812301819f5c7fce30d81c6e86a80 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Wed, 16 Aug 2023 09:17:12 -0700 Subject: [PATCH] [AArch64][PAC] Support and document ptrauth builtins and

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404742 , @mcgrathr wrote: > In D152405#4404616 , @leonardchan > wrote: > >> Oh this is completely independent from relative vtables. I'll update the >> wording. > >

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -303,6 +303,10 @@ bool Module::directlyUses(const Module *Requested) { if (!Requested->Parent && Requested->Name == "_Builtin_stddef_max_align_t") return true; + // Anyone is allowed to use our builtin ptrauth.h and its accompanying module. + if

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx marked an inline comment as done. AlexVlx added inline comments. Comment at: clang/docs/HIPSupport.rst:216 + +Given the following C++ code, which assumes the ``std`` namespace is included: + keryell wrote: > Since this does not sounds like an official

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 556618. AlexVlx added a comment. Address review feedback around explicit use of `std::`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 Files: clang/docs/HIPSupport.rst clang/docs/ReleaseNotes.rst

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

@@ -215,44 +225,57 @@ DependencyScanningWorkerFilesystem::findEntryByFilenameWithWriteThrough( } llvm::ErrorOr -DependencyScanningWorkerFilesystem::computeAndStoreResult(StringRef Filename) { - llvm::ErrorOr Stat = getUnderlyingFS().status(Filename);

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

ajarmusch wrote: @gulfemsavrun I reverted the commit and am currently trying to fix the issue. https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675: >From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]] This attribute should

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

@@ -215,44 +225,57 @@ DependencyScanningWorkerFilesystem::findEntryByFilenameWithWriteThrough( } llvm::ErrorOr -DependencyScanningWorkerFilesystem::computeAndStoreResult(StringRef Filename) { - llvm::ErrorOr Stat = getUnderlyingFS().status(Filename);

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

gulfemsavrun wrote: We also started seeing a test failure after this commit: ``` FAIL: Clang :: OpenMP/test_target_uses_allocators_large_cap_codegen.cpp (13374 of 19273) -- /b/s/w/ir/x/w/llvm-llvm-project/clang/test/OpenMP/test_target_uses_allocators_large_cap_codegen.cpp:167:18: error:

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

pizzud wrote: > I don't see problem described by this check as an performance issue. For > example: > > ``` > std::unique_ptr> ptr; > std::vector local = std::move(*ptr); > ``` > > No performance issue here, simply value may need to be moved, do not expect > that someone have to always keep

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

pizzud wrote: > I don't see problem described by this check as an performance issue. For > example: > > ``` > std::unique_ptr> ptr; > std::vector local = std::move(*ptr); > ``` > > No performance issue here, simply value may need to be moved, do not expect > that someone have to always keep

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675: >From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]] This attribute should

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675: >From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]] This attribute should

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139: >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/3] [clang-tidy] Add performance-move-smart-pointer-contents

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139: >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/3] [clang-tidy] Add performance-move-smart-pointer-contents

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -4505,6 +4505,14 @@ bool FieldDecl::isZeroSize(const ASTContext ) const { if (!CXXRD->isEmpty()) return false; + // MS ABI: nonzero if class type with class type fields amykhuang wrote: As far as I can tell the cases above still apply to MSVC so I

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,80 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,80 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139: >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/2] [clang-tidy] Add performance-move-smart-pointer-contents

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,80 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,80 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139: >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/2] [clang-tidy] Add performance-move-smart-pointer-contents

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,39 @@ +//===--- MoveSmartPointerContentsCheck.h - clang-tidy ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

  1   2   3   4   5   6   >