[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-19 Thread via cfe-commits
kasuga-fj wrote: @llvm/pr-subscribers-libcxx Could you please check this comment? https://github.com/llvm/llvm-project/pull/65246#issuecomment-1706219059 https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread via cfe-commits
WenleiHe wrote: Haven't looked at the changes, but from the conversations above this looks like a useful change. Though I think the big picture context/motivation can go into the change summary to help others understand better. Maybe even a small RFC would be helpful to explain the complete

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I updated the PR description with an example. https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai edited https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-19 Thread Ian Anderson via Phabricator via cfe-commits
iana marked 2 inline comments as done. iana added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:176 COMPATIBLE_LANGOPT(CPlusPlusModules, 1, 0, "C++ modules syntax") +LANGOPT(BuiltinHeadersInSystemModules, 1, 0, "builtin headers belong to system

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-19 Thread Fangrui Song via cfe-commits
@@ -9,20 +9,145 @@ #include "Haiku.h" #include "CommonArgs.h" #include "clang/Config/config.h" +#include "clang/Driver/Compilation.h" #include "llvm/Support/Path.h" using namespace clang::driver; +using namespace clang::driver::tools; using namespace

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-19 Thread Fangrui Song via cfe-commits
@@ -9,20 +9,145 @@ #include "Haiku.h" #include "CommonArgs.h" #include "clang/Config/config.h" +#include "clang/Driver/Compilation.h" #include "llvm/Support/Path.h" using namespace clang::driver; +using namespace clang::driver::tools; using namespace

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-19 Thread Fangrui Song via cfe-commits
@@ -9,20 +9,145 @@ #include "Haiku.h" #include "CommonArgs.h" #include "clang/Config/config.h" +#include "clang/Driver/Compilation.h" #include "llvm/Support/Path.h" using namespace clang::driver; +using namespace clang::driver::tools; using namespace

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-19 Thread Fangrui Song via cfe-commits
@@ -15,30 +15,58 @@ namespace clang { namespace driver { +namespace tools { + +/// haiku -- Directly call GNU Binutils assembler and linker MaskRay wrote: Do not recommend repeating the identifier name `name -- ` in new code.

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-19 Thread Fangrui Song via cfe-commits
@@ -128,8 +253,14 @@ void Haiku::addLibCxxIncludePaths(const llvm::opt::ArgList , concat(getDriver().SysRoot, "/boot/system/develop/headers/c++/v1")); } -void Haiku::addLibStdCxxIncludePaths(const llvm::opt::ArgList , -

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

2023-09-19 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVCallingConv.td:52 // Same as CSR_Interrupt, but including all 64-bit FP registers. def CSR_XLEN_F64_Interrupt: CalleeSavedRegs<(add CSR_Interrupt, (sequence

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-19 Thread Fangrui Song via cfe-commits
@@ -2426,6 +2432,31 @@ void Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes( using std::begin; using std::end; + if (TargetTriple.isOSHaiku()) { +static const char *const HaikuLibDirs[] = {"/lib"}; +static const char *const HaikuAArch64Triples[] =

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-09-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Reorder checks to protect against a null pointer dereference. (PR #66764)

2023-09-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/66764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a93e76d - [clang][dataflow] Reorder checks to protect against a null pointer dereference. (#66764)

2023-09-19 Thread via cfe-commits
Author: martinboehme Date: 2023-09-19T21:28:21-07:00 New Revision: a93e76dd8778a5793c408eb503a46502bcf9b49c URL: https://github.com/llvm/llvm-project/commit/a93e76dd8778a5793c408eb503a46502bcf9b49c DIFF: https://github.com/llvm/llvm-project/commit/a93e76dd8778a5793c408eb503a46502bcf9b49c.diff

[clang] [clang][dataflow] Reorder checks to protect against a null pointer dereference. (PR #66764)

2023-09-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. Thanks. It'll be nice to have a test, but I think it is fine to land this now... and will address an internal crash. https://github.com/llvm/llvm-project/pull/66764 ___ cfe-commits mailing list

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
cbalint13 wrote: @DavidSpickett , The new output: [console-output.txt.gz](https://github.com/llvm/llvm-project/files/12668489/console-output.txt.gz) ``` $ zcat console-output.txt.gz | grep 'print' $ ./bin/clang --target=arm-unknown-linux-gnu --print-supported-extensions $ ./bin/clang

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Since this is a diagnostic improvement, can you post the before and after output of an example? https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 13527e78686e18d020cefe1a88e0f9c37887b7c5 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 06:54:14 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From ccd3e5f62af208af38f02f76ca018724712f1d5a Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 06:51:33 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 468f86f2c856f163d4d1b9abdb2ef7d98934fd5f Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 06:39:19 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 371b465939f86990edbe16f19e7d5a4b2db09a00 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 06:26:11 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 2e51ca182adac1dca22d390a6494dd8b9ffba7cd Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 06:15:04 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 4ef7b54508b7ff3f17f29d1763b90b963a8f390e Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 06:12:52 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 3e744b6e80f5074613a01d17ad9125ac79fdf83f Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 06:07:43 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-19 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From d3072f481595d1840551a9f8ed322fa64d336a10 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 05:59:32 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes `Lexer::getLocForEndOfToken` is documented as returning an invalid source location when the end of the token is inside a macro expansion. We don't want that for this particular application, so just calculate the end location directly

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/66853 `Lexer::getLocForEndOfToken` is documented as returning an invalid source location when the end of the token is inside a macro expansion. We don't want that for this particular application, so just calculate the

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes [Ref](https://discourse.llvm.org/t/fixing-crt-allocator-support-on-windows/73525) # Notes - ``ChooseMSVCCRT.cmake`` is the automatic translation layer that's been completely removed - The old implementation seems to support

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

2023-09-19 Thread via cfe-commits
https://github.com/Naville created https://github.com/llvm/llvm-project/pull/66850 [Ref](https://discourse.llvm.org/t/fixing-crt-allocator-support-on-windows/73525) # Notes - ``ChooseMSVCCRT.cmake`` is the automatic translation layer that's been completely removed - The old implementation

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-19 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-19 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/66310 >From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Thu, 14 Sep 2023 09:17:39 +0800 Subject: [PATCH 1/3] [X86] Align 128/256 variants to use void * as 512 variants.

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Can you point me to such defect? I had no luck searching for it. It should be https://github.com/llvm/llvm-project/issues/49843. I didn't expect that it was not marked as coroutines. Besides fixing that bug, it is also a minor optimization to not include GRO in coroutine

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: > > > The work sounds interesting. Can you provide a bit more context about it? > > > Will it be used to improve ICP when it's sufficient to just compare the > > > vtable address instead of the vfunc address? > > > > > > yes -- it can not only eliminate vtable load, but

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

2023-09-19 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,139 @@ +; RUN: opt < %s -passes=pgo-instr-gen -S | FileCheck %s --check-prefix=GEN +; RUN: opt < %s -passes=pgo-instr-gen,instrprof -S | FileCheck %s --check-prefix=LOWER + +target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

2023-09-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66846 >From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 19 Sep 2023 16:15:20 +0800 Subject: [PATCH] [clang-analysis]Fix false positive in mutation check when

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

2023-09-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/66846 Fixes: #66204 >From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 19 Sep 2023 16:15:20 +0800 Subject: [PATCH] [clang-analysis]Fix false positive in mutation

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This patch starts the support for OpenMP kernel language, basically to write OpenMP target region in SIMT style, similar to kernel languages such as CUDA. What included in this first patch is the `ompx_bare` clause for `target teams`

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

2023-09-19 Thread Argyrios Kyrtzidis via cfe-commits
https://github.com/akyrtzi closed https://github.com/llvm/llvm-project/pull/66122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 36b37c7 - [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (#66122)

2023-09-19 Thread via cfe-commits
Author: Argyrios Kyrtzidis Date: 2023-09-19T18:18:23-07:00 New Revision: 36b37c775c285bbff9b57630e7ea9d00b918cc91 URL: https://github.com/llvm/llvm-project/commit/36b37c775c285bbff9b57630e7ea9d00b918cc91 DIFF:

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-19 Thread via cfe-commits
vabridgers wrote: I've updated the review per recent comments, please review at your convenience. Thanks! https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-19 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:176 COMPATIBLE_LANGOPT(CPlusPlusModules, 1, 0, "C++ modules syntax") +LANGOPT(BuiltinHeadersInSystemModules, 1, 0, "builtin headers belong to system modules, and _Builtin_ modules are ignored

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-19 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: Updated the patch to account for failing libcxx tests, and to not change current codegen when GRO allocas are not involved. https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-19 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes updated https://github.com/llvm/llvm-project/pull/66706 >From f9d54b81d4c3c10c3dd26193d9bef52785826f21 Mon Sep 17 00:00:00 2001 From: Bruno Cardoso Lopes Date: Fri, 15 Sep 2023 15:40:20 -0700 Subject: [PATCH 1/3] [Clang][Coroutines] Improve GRO handling to

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-19 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes updated https://github.com/llvm/llvm-project/pull/66706 >From f9d54b81d4c3c10c3dd26193d9bef52785826f21 Mon Sep 17 00:00:00 2001 From: Bruno Cardoso Lopes Date: Fri, 15 Sep 2023 15:40:20 -0700 Subject: [PATCH 1/2] [Clang][Coroutines] Improve GRO handling to

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

2023-09-19 Thread Fangrui Song via cfe-commits
MaskRay wrote: > This seems fine to me, but it's hard to understand if this is redundant with > some other "ParseFunction" scope from the tests. WDYT @MaskRay ? I share similar concern but I am not familiar with the parser... @AaronBallman https://github.com/llvm/llvm-project/pull/65268

[clang] c2e92cb - [Docs] Fix table after previous document update

2023-09-19 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-09-19T19:33:29-05:00 New Revision: c2e92cb490b1d9a7ecf0c97d3c2d2dc6d2d4fc70 URL: https://github.com/llvm/llvm-project/commit/c2e92cb490b1d9a7ecf0c97d3c2d2dc6d2d4fc70 DIFF: https://github.com/llvm/llvm-project/commit/c2e92cb490b1d9a7ecf0c97d3c2d2dc6d2d4fc70.diff

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread Hongtao Yu via cfe-commits
htyu wrote: > > The work sounds interesting. Can you provide a bit more context about it? > > Will it be used to improve ICP when it's sufficient to just compare the > > vtable address instead of the vfunc address? > > yes -- it can not only eliminate vtable load, but also enable target check

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Changes As described in issue [#64999](https://github.com/llvm/llvm-project/issues/64999), commit [e018cbf7208](https://github.com/llvm/llvm-project/commit/e018cbf7208b3d34f18997ddee84c66cee32fb1b) caused the symbol __stack_chk_guard to not

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-19 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 updated https://github.com/llvm/llvm-project/pull/65512 >From 2e5abcec65c189fbb7f789816373969ee81ecfa5 Mon Sep 17 00:00:00 2001 From: wpieb Date: Tue, 5 Sep 2023 10:43:23 -0700 Subject: [PATCH 1/2] [LTO] A static relocation model can override the PIC level wrt

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/66554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
@@ -270,6 +269,20 @@ TARGET_HEADER_BUILTIN(__readx18word, "UsUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, TARGET_HEADER_BUILTIN(__readx18dword, "UNiUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(__readx18qword, "ULLiUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "")

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread David Li via cfe-commits
david-xl wrote: > The work sounds interesting. Can you provide a bit more context about it? > Will it be used to improve ICP when it's sufficient to just compare the > vtable address instead of the vfunc address? yes -- it can not only eliminate vtable load, but also enable target check

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/66554 >From de9c8618210103074e580105ce894e66dba782a9 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Thu, 7 Sep 2023 11:32:17 -0700 Subject: [PATCH 1/3] [MSVC, ARM64] Add _Copy* and _Count* intrinsics ---

[clang] [clang] Add -mlarge-data-threshold for x86_64 medium code model (PR #66839)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Error if not used with x86_64. Warn if not used with the medium code model (can update if other code models end up using this). Set TargetMachine option and add module flag. --- Full diff:

[clang] [clang] Add -mlarge-data-threshold for x86_64 medium code model (PR #66839)

2023-09-19 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/66839 Error if not used with x86_64. Warn if not used with the medium code model (can update if other code models end up using this). Set TargetMachine option and add module flag. >From

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
@@ -10779,6 +10779,70 @@ Value *CodeGenFunction::EmitAArch64BuiltinExpr(unsigned BuiltinID, return Load; } + if (BuiltinID == AArch64::BI_CopyDoubleFromInt64 || + BuiltinID == AArch64::BI_CopyFloatFromInt32 || + BuiltinID == AArch64::BI_CopyInt32FromFloat ||

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
amykhuang wrote: Are there any other comments here? I think I've addressed all the existing ones. https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675 >From 481337fde54dc4d7f68a604952a963c99913675d Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/6] Implement [[msvc::no_unique_address]] This attribute should

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

2023-09-19 Thread via cfe-commits
goldsteinn wrote: > > ``` > > define noundef nonnull ptr @foo() { > >%b = call ptr @bar() > >call void @use(ptr %p) willreturn nounwind > >ret ptr %b > > } > > ``` > > > > > > > > > > > > > > > > > > > > > > > > If we add `nonnull` to `@bar`

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread Hongtao Yu via cfe-commits
htyu wrote: The work sounds interesting. Can you provide a bit more context about it? Will it be used to improve ICP when it's sufficient to just compare the vtable address instead of the vfunc address? https://github.com/llvm/llvm-project/pull/66825

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread David Li via cfe-commits
@@ -276,6 +286,12 @@ uint64_t __llvm_profile_get_num_counters(const char *Begin, const char *End); /*! \brief Get the size of the profile counters section in bytes. */ uint64_t __llvm_profile_get_counters_size(const char *Begin, const char *End); +uint64_t

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread David Li via cfe-commits
@@ -276,6 +286,12 @@ uint64_t __llvm_profile_get_num_counters(const char *Begin, const char *End); /*! \brief Get the size of the profile counters section in bytes. */ uint64_t __llvm_profile_get_counters_size(const char *Begin, const char *End); +uint64_t

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-19 Thread David Li via cfe-commits
@@ -0,0 +1,139 @@ +; RUN: opt < %s -passes=pgo-instr-gen -S | FileCheck %s --check-prefix=GEN +; RUN: opt < %s -passes=pgo-instr-gen,instrprof -S | FileCheck %s --check-prefix=LOWER + +target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -22589,9 +22591,23 @@ TEST_F(FormatTest, FormatsLambdas) { verifyFormat("Namespace::Foo::Foo(LongClassName bar,\n" "AnotherLongClassName baz)\n" ": baz{baz}, func{[&] {\n" - " auto qux = bar;\n" -

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -1955,7 +1955,8 @@ void ContinuationIndenter::moveStatePastScopeCloser(LineState ) { void ContinuationIndenter::moveStateToNewBlock(LineState ) { if (Style.LambdaBodyIndentation == FormatStyle::LBI_OuterScope && - State.NextToken->is(TT_LambdaLBrace)) { +

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. Can you add test cases with `BreakConstructorInitializer` set to `AfterColon`? https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto , const auto ) {\n" - " return foo.baz <

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/13] Introduce PagedVector

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread via cfe-commits
https://github.com/michaelrj-google closed https://github.com/llvm/llvm-project/pull/66834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread via cfe-commits
https://github.com/michaelrj-google closed https://github.com/llvm/llvm-project/pull/66834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
ktf wrote: @zygoloid @kuhar thank you for the detailed comments. I am still reviewing some of them, in particular the one of @zygoloid about the equality operator does not seem to work out of the box, so I need a bit more time thinking about it. I pushed a new version with the current state

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/12] Introduce PagedVector

[clang-tools-extra] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/66834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/66834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/11] Introduce PagedVector

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libc Changes The list of printf copts available in config.json wasn't working because the printf_core subdirectory was included before the printf_copts variable was defined, making it effectively nothing for the printf internals. Additionally, the tests

  1   2   3   4   5   >