[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes closed https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 34415fd - [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (#66706)

2023-09-21 Thread via cfe-commits
Author: Bruno Cardoso Lopes Date: 2023-09-21T22:52:05-07:00 New Revision: 34415fd611e2d92da570bc4adf931a6410fb406e URL: https://github.com/llvm/llvm-project/commit/34415fd611e2d92da570bc4adf931a6410fb406e DIFF:

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-21 Thread Felix via cfe-commits
orcguru wrote: > The primary advantage of the local-dynamic access method is that you only > make a single function call to __tls_get_mod() and use the returned pointer > to get at all TLS variables. This implementation makes a function call for > every variable. The only thing you've gained

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-21 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/66358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f90e063 - [analyzer] Fix taint sink rules for exec-like functions (#66358)

2023-09-21 Thread via cfe-commits
Author: Balazs Benics Date: 2023-09-22T07:14:32+02:00 New Revision: f90e063308226fae26589fdc97b6eca78edbc463 URL: https://github.com/llvm/llvm-project/commit/f90e063308226fae26589fdc97b6eca78edbc463 DIFF: https://github.com/llvm/llvm-project/commit/f90e063308226fae26589fdc97b6eca78edbc463.diff

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: > > One of the remaining tests fails because `PP->getIdentifierInfo()` ends up > > doing external lookup via `ASTReader`, which ends up emitting a

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Brad Smith via cfe-commits
brad0 wrote: > Can a Haiku developer confirm that these changes work on Haiku? I built a few random Haiku apps. Look to be all C++ code. They worked fine. Same results for both GCC and Clang. https://github.com/llvm/llvm-project/pull/66038 ___

[clang] 1d0b7b6 - [clang] Use a range-based for loop (NFC)

2023-09-21 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-21T21:15:57-07:00 New Revision: 1d0b7b6c8aed0b769f6cb41e09c4e62b618a7037 URL: https://github.com/llvm/llvm-project/commit/1d0b7b6c8aed0b769f6cb41e09c4e62b618a7037 DIFF: https://github.com/llvm/llvm-project/commit/1d0b7b6c8aed0b769f6cb41e09c4e62b618a7037.diff

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-21 Thread Felix via cfe-commits
orcguru wrote: > > I tried to parallelize the review effort, but github didn't show the delta > > for me: #66972 > > Let's include FE change in this PR. Thanks! Added clang change. https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-21 Thread Felix via cfe-commits
https://github.com/orcguru edited https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-09-21 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @sam-mccall gentle ping https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Brad Smith via cfe-commits
https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66038 >From 55445ca9ac5e301a6088bdeb3dcd286cc7cdcdc7 Mon Sep 17 00:00:00 2001 From: X512 Date: Mon, 11 Sep 2023 20:56:02 -0400 Subject: [PATCH] [Driver] Implement ToolChain on Haiku Co-authored-by: David Karoly

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Fangrui Song via cfe-commits
@@ -15,30 +15,53 @@ namespace clang { namespace driver { +namespace tools { + +/// Directly call GNU Binutils assembler and linker +namespace haiku { +class LLVM_LIBRARY_VISIBILITY Linker : public Tool { MaskRay wrote: `class LLVM_LIBRARY_VISIBILITY Linker

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-21 Thread Brandon Wu via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-21 Thread Fangrui Song via cfe-commits
MaskRay wrote: @madscientist https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-21 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-21 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes `-include a.h` probes `a.h.pch` and `a.h.gch`, if not found, falls back to `a.h`. `.pch` is the preferred extension name. Probing .gch is supposed to provide compatibility with build systems that do ``` clang -x c-header a.h -o

[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-21 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/67084 `-include a.h` probes `a.h.pch` and `a.h.gch`, if not found, falls back to `a.h`. `.pch` is the preferred extension name. Probing .gch is supposed to provide compatibility with build systems that do ``` clang -x

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557214. Prabhuk added a comment. Handle UEFI64 in X86RegisterInfo for all Win64 equivalent cases except for Swift and OCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

2023-09-21 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Hi @rsmith, we have an internal test where your change seems to have changed the mangling in C++17 mode and wanted to check if that was intentional. Consider the following code: // Literals in templates #include template T returnit() {return I;}; enum colour {

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Brad Smith via cfe-commits
@@ -15,30 +15,53 @@ namespace clang { namespace driver { +namespace tools { + +/// Directly call GNU Binutils assembler and linker +namespace haiku { +class LLVM_LIBRARY_VISIBILITY Linker : public Tool { brad0 wrote: I am not sure what you meant by this.

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Brad Smith via cfe-commits
https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66038 >From d40ff6ebfd283701a5bb07695c2aa5a58d3ed703 Mon Sep 17 00:00:00 2001 From: X512 Date: Mon, 11 Sep 2023 20:56:02 -0400 Subject: [PATCH] [Driver] Implement ToolChain on Haiku Co-authored-by: David Karoly

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-21 Thread Brad Smith via cfe-commits
https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Richard Smith via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: zygoloid wrote: > One of the remaining tests fails because `PP->getIdentifierInfo()` ends up > doing external lookup via `ASTReader`, which ends up emitting a diagnostic

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-21 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From d26f9487dedf53ac419cbd9dfb8c29214ba0e09f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/2] [clang][modules] Move `SLocEntry` search into `ASTReader`

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

2023-09-21 Thread Harald van Dijk via Phabricator via cfe-commits
hvdijk added a comment. I do not think there is a sensible way to keep [`upgrade-datalayout2.ll`](https://github.com/llvm/llvm-project/blob/main/llvm/test/Bitcode/upgrade-datalayout2.ll) working, with the way the upgrade logic is structured, and we should rethink that test. The change here

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-21 Thread Roland McGrath via cfe-commits
@@ -52,6 +52,7 @@ set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "") set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "") set(CMAKE_BUILD_TYPE Release CACHE STRING "") +set(CMAKE_CXX_VISIBILITY_PRESET default CACHE STRING "") frobtech wrote: It merits a comment here

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-21 Thread Roland McGrath via cfe-commits
https://github.com/frobtech edited https://github.com/llvm/llvm-project/pull/67067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-21 Thread Roland McGrath via cfe-commits
https://github.com/frobtech approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/67067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-21 Thread David Li via cfe-commits
@@ -686,9 +708,11 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure, than WIN32 */ #define INSTR_PROF_DATA_COMMON __llvm_prf_data #define INSTR_PROF_NAME_COMMON __llvm_prf_names +#define INSTR_PROF_VNAME_COMMON __llvm_prf_vnames david-xl wrote:

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-21 Thread David Li via cfe-commits
@@ -305,13 +320,24 @@ lprofWriteDataImpl(ProfDataWriter *Writer, const __llvm_profile_data *DataBegin, /* Write the profile header. */ ProfDataIOVec IOVec[] = {{, sizeof(__llvm_profile_header), 1, 0}}; + // printf("Size of profile header is %d\n", + //

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-21 Thread David Li via cfe-commits
@@ -92,6 +92,19 @@ INSTR_PROF_DATA(const uint16_t, Int16ArrayTy, NumValueSites[IPVK_Last+1], \ /* INSTR_PROF_DATA end. */ +#ifndef INSTR_PROF_VTABLE_DATA +#define INSTR_PROF_VTABLE_DATA(Type, LLVMType, Name, Initializer) +#else +#define INSTR_PROF_VTABLE_DATA_DEFINED

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-21 Thread David Li via cfe-commits
@@ -272,18 +279,26 @@ lprofWriteDataImpl(ProfDataWriter *Writer, const __llvm_profile_data *DataBegin, const uint64_t NumCounters = __llvm_profile_get_num_counters(CountersBegin, CountersEnd); const uint64_t NamesSize = DebugInfoCorrelate ? 0 : NamesEnd -

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-21 Thread David Li via cfe-commits
@@ -124,9 +124,27 @@ int __llvm_profile_merge_from_buffer(const char *ProfileData, SrcCountersEnd = SrcCountersStart + Header->NumCounters * __llvm_profile_counter_entry_size(); SrcNameStart = SrcCountersEnd; - SrcValueProfDataStart = + // This is to

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Wei Wang via cfe-commits
apolloww wrote: Thanks for the fix! I think originally the deferred conversion is placed after `coro.end` so that it won't be counted as "use across suspend point", but it doesn't stop optimizer from breaking that assumption. https://github.com/llvm/llvm-project/pull/66706

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-21 Thread Louis Dionne via cfe-commits
ldionne wrote: Ok so after scratching my head a bit, I'm actually not certain of how to proceed with this. I can't find a way to implement `__libcpp_datasizeof` in libc++ that doesn't involve `offsetof`, so our only option would be to silence the warning. We could do it like (if we end up

[clang] 700baeb - [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

2023-09-21 Thread Ziqing Luo via cfe-commits
Author: Ziqing Luo Date: 2023-09-21T15:06:22-07:00 New Revision: 700baeb765cfe8628eb68bc24319b3db0209dd84 URL: https://github.com/llvm/llvm-project/commit/700baeb765cfe8628eb68bc24319b3db0209dd84 DIFF: https://github.com/llvm/llvm-project/commit/700baeb765cfe8628eb68bc24319b3db0209dd84.diff

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

2023-09-21 Thread Ziqing Luo via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rG700baeb765cf: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes There was an issue with relative vtables when two TU's which define the same vtable object are built with different default visibilities. Some TU's are built with -fvisibility=hidden in the code base, grep for CMAKE_CXX_VISIBILITY_PRESET

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-21 Thread Alex Brachet via cfe-commits
https://github.com/abrachet updated https://github.com/llvm/llvm-project/pull/67067 >From 3aa0af93dfe73edd2b6cba62c55e7797320665da Mon Sep 17 00:00:00 2001 From: Alex Brachet Date: Wed, 20 Sep 2023 17:55:44 -0400 Subject: [PATCH] [Fuchsia] Build with -fvisibility=default There was an issue

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-21 Thread Alex Brachet via cfe-commits
https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/67067 There was an issue with relative vtables when two TU's which define the same vtable object are built with different default visibilities. Some TU's are built with -fvisibility=hidden in the code base, grep for

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

2023-09-21 Thread Ziqing Luo via Phabricator via cfe-commits
ziqingluo-90 marked an inline comment as done. ziqingluo-90 added a comment. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2586 #endif it = FixablesForAllVars.byVar.erase(it); } else if (Tracker.hasUnclaimedUses(it->first)) { NoQ

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-21 Thread Louis Dionne via cfe-commits
ldionne wrote: Note that you should probably rebase your patch onto `main` and force-push to update the PR. The CI for Clang now runs on Windows from GH PRs as well (it used not to when you submitted the patch, I think). https://github.com/llvm/llvm-project/pull/65246

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-21 Thread Louis Dionne via cfe-commits
ldionne wrote: I think when the @llvm/pr-subscribers-libcxx group was pinged 2 weeks ago, most of us didn't have the right GH notifications set up yet and we didn't see it. Looking now. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-21 Thread William Junda Huang via cfe-commits
huangjd wrote: Full profile load is further reduced to 24s after optimizing lazy loading of name table, which was a bottleneck https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-21 Thread William Junda Huang via cfe-commits
huangjd wrote: I will hold on renaming variables to a different patch because this will change files everywhere, may cause confusion to review in this patch. https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

2023-09-21 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-21 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/66554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 03c698a - [MSVC, ARM64] Add _Copy* and _Count* intrinsics (#66554)

2023-09-21 Thread via cfe-commits
Author: Amy Huang Date: 2023-09-21T14:34:59-07:00 New Revision: 03c698a431b4dc23c2b9de3e9befd1860fef6e80 URL: https://github.com/llvm/llvm-project/commit/03c698a431b4dc23c2b9de3e9befd1860fef6e80 DIFF: https://github.com/llvm/llvm-project/commit/03c698a431b4dc23c2b9de3e9befd1860fef6e80.diff

[clang] Improve sort mangled (PR #67066)

2023-09-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes This is stacked on top of https://github.com/llvm/llvm-project/pull/66816 Disregard first commit. --- Full diff: https://github.com/llvm/llvm-project/pull/67066.diff 12 Files Affected: - (modified)

[clang] Improve sort mangled (PR #67066)

2023-09-21 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/67066 This is stacked on top of https://github.com/llvm/llvm-project/pull/66816 Disregard first commit. >From 47bd926491f28f722c429f3ab4a993aa5d85d1b7 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Tue, 19 Sep

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
@@ -463,3 +463,38 @@ static_assert(bit_cast(ld539) == fivehundredandthirtynine, ""); static_assert(round_trip<__int128_t>(34.0L)); #endif } + +namespace test_vector { + +typedef unsigned uint2 __attribute__((vector_size(2 * sizeof(unsigned; +typedef char byte8

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-21 Thread via cfe-commits
https://github.com/ZijunZhaoCCK ready_for_review https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-21 Thread via cfe-commits
https://github.com/ZijunZhaoCCK ready_for_review https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Daniel Thornburgh via Phabricator via cfe-commits
mysterymath added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:522 // Mingw64 and native Win64 use Win64 CC CCIfSubtarget<"isTargetWin64()", CCDelegateTo>, You'll need to add switching for Win64 here too; this appears to be the

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557203. Prabhuk added a comment. Uploading the backend changes correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ https://reviews.llvm.org/D159540 Files:

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk marked an inline comment as done. Prabhuk added a comment. Clang Driver Changes - https://reviews.llvm.org/D159541 Current - https://reviews.llvm.org/D152206 X86 Backend changes - https://reviews.llvm.org/D159540 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue , QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) { +

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557202. Prabhuk added a comment. Splitting commit into 3 commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files:

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue , QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) { +

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock , bwendling wrote: I added more context to the commit

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock , bwendling wrote: I added more context to the commit

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk created this revision. Prabhuk added a reviewer: phosek. Herald added a subscriber: pengfei. Herald added a project: All. Prabhuk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Introduce changes necessary for UEFI X86_64

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock , nickdesaulniers wrote: Ah! Ok, they *why* for this PR

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock , nickdesaulniers wrote: Ah! Ok, they *why* for this PR

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg,

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg,

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557199. Prabhuk added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Clang Driver changes for UEFI X86_64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg,

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg,

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread via cfe-commits
@@ -7095,6 +7096,45 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue , QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) { +

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock , bwendling wrote: Yes, in particular I want to call it

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock , bwendling wrote: Yes, in particular I want to call it

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

2023-09-21 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Yeah, we should get this over the line. I'm still not quite sure where to put the check. Reading @rsmith's comment again, SemaInit might perhaps be acceptable for now, except that I should add the additional tests (in case we don't have them already). I think we

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread via cfe-commits
https://github.com/DaMatrix updated https://github.com/llvm/llvm-project/pull/66894 >From 61f1f5f7325e7cfea8c04ad5c0dea0fdd8c96ab5 Mon Sep 17 00:00:00 2001 From: DaPorkchop_ Date: Sun, 13 Aug 2023 22:39:12 +0200 Subject: [PATCH] [clang] Implement constexpr bit_cast for vectors ---

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
bwendling wrote: > I'm assuming there are other targets that would benefit from being converted > as well? Not asking you to do it, just wondering what the best way to get it > done is. Yeah, the other platforms can implement this when / if they need it. It's really just a convenience

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
bwendling wrote: > I'm assuming there are other targets that would benefit from being converted > as well? Not asking you to do it, just wondering what the best way to get it > done is. Yeah, the other platforms can implement this when / if they need it. It's really just a convenience

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg,

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock , nickdesaulniers wrote: Why make it a method on

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg,

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >