[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @ktf, congrats for your first patch to llvm. Well done! https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4ae5157 - Introduce paged vector (#66430)

2023-09-29 Thread via cfe-commits
Author: Giulio Eulisse Date: 2023-09-30T08:26:19+03:00 New Revision: 4ae51570806ba5c5fcabe6d6dcbe52e3a5d5453b URL: https://github.com/llvm/llvm-project/commit/4ae51570806ba5c5fcabe6d6dcbe52e3a5d5453b DIFF:

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-29 Thread Yuanfang Chen via cfe-commits
https://github.com/yuanfang-chen approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-29 Thread Yuanfang Chen via cfe-commits
https://github.com/yuanfang-chen approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Have -rdynamic be a no-op on Haiku (PR #67872)

2023-09-29 Thread Brad Smith via cfe-commits
brad0 wrote: @davidkaroly https://github.com/llvm/llvm-project/pull/67872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Have -rdynamic be a no-op on Haiku (PR #67872)

2023-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Do the same as the Haiku GCC patches. https://github.com/haikuports/haikuports/commit/46afdec05771d126eb6cb6c3b3deb957604617c4 --- Full diff: https://github.com/llvm/llvm-project/pull/67872.diff 2 Files Affected: - (modified)

[clang] [Driver] Have -rdynamic be a no-op on Haiku (PR #67872)

2023-09-29 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/67872 Do the same as the Haiku GCC patches. https://github.com/haikuports/haikuports/commit/46afdec05771d126eb6cb6c3b3deb957604617c4 >From 457174b938681c23bb652cf58aabaa1d25587d13 Mon Sep 17 00:00:00 2001 From: Brad

[clang] 2048836 - [NFC] Replace uses of Type::getPointerTo

2023-09-29 Thread via cfe-commits
Author: JOE1994 Date: 2023-09-29T21:38:53-04:00 New Revision: 204883623ebd194669fc54435222e5bfb245b011 URL: https://github.com/llvm/llvm-project/commit/204883623ebd194669fc54435222e5bfb245b011 DIFF: https://github.com/llvm/llvm-project/commit/204883623ebd194669fc54435222e5bfb245b011.diff LOG:

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
@@ -31,6 +31,33 @@ static_assert(b, ""); constexpr int one = true; static_assert(one == 1, ""); +constexpr bool b2 = bool(); +static_assert(!b2, ""); + +namespace ScalarTypes { + constexpr int ScalarInitInt = int(); + static_assert(ScalarInitInt == 0, ""); + constexpr

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
@@ -209,7 +209,7 @@ bool Ret(InterpState , CodePtr , APValue ) { // FIXME: We could be calling isLive() here, but the emitted diagnostics // seem a little weird, at least if the returned expression is of // pointer type. shafik wrote: Can we add

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

2023-09-29 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D145262#4651483 , @owenpan wrote: > This looks OK to me. Please rebase after > https://github.com/llvm/llvm-project/pull/67518 is merged. I have merged the PR. Commits cef9f40cd4fe

[clang] [libc] Attempt to enable missing string functions for offloading (PR #67869)

2023-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Summary: We previously had to disable these string functions because they were not compatible with the definitions coming from the GNU / host environment. The GPU, when exporting its declarations, has a very difficult requirement that it be

[clang] [libc] Attempt to enable missing string functions for offloading (PR #67869)

2023-09-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67869 Summary: We previously had to disable these string functions because they were not compatible with the definitions coming from the GNU / host environment. The GPU, when exporting its declarations, has a very

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
https://github.com/vvereschaka approved this pull request. https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

2023-09-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159541/new/ https://reviews.llvm.org/D159541

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
arichardson wrote: > @arichardson , works fine on the builders locally. Thank you. Would yo merge > these changes if they are ready? Thanks for testing! I'll merge these changes as soon as @ldionne is happy with the new macros. Once that happens I'll push the first commit manually and then

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
arichardson wrote: > @arichardson , works fine on the builders locally. Thank you. Would yo merge > these changes if they are ready? Thanks for testing! I'll merge these changes as soon as @ldionne is happy with the new macros. Once that happens I'll push the first commit manually and then

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-29 Thread via cfe-commits
@@ -10977,6 +10987,9 @@ bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) { return false; Success = false; } + +// Make sure we run the destructors too. +Scope.destroy(); isuckatcs wrote: The result of the

[clang] [clang] Default x86-64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

2023-09-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang]Add vscale argument parsing (PR #67676)

2023-09-29 Thread Mats Petersson via cfe-commits
https://github.com/Leporacanthicus updated https://github.com/llvm/llvm-project/pull/67676 >From 17e128e808ecb170b71a4713692cff3dee8d50aa Mon Sep 17 00:00:00 2001 From: Mats Petersson Date: Fri, 15 Sep 2023 18:52:11 +0100 Subject: [PATCH 1/4] [flang]Add vscale argument parsing Support for

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson , works fine on the builders locally. Thank you. Would yo merge these changes if they are ready? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson , works fine on the builders locally. Thank you. Would yo merge these changes if they are ready? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver] Hook up Haiku ARM support (PR #67222)

2023-09-29 Thread Brad Smith via cfe-commits
brad0 wrote: @davidkaroly https://github.com/llvm/llvm-project/pull/67222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

2023-09-29 Thread Arjun P via cfe-commits
Superty wrote: By the way, what happens if the inverse doesn't exist? https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

2023-09-29 Thread Arjun P via cfe-commits
Superty wrote: By the way, what happens if the inverse doesn't exist? https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

2023-09-29 Thread Arjun P via cfe-commits
Superty wrote: By the way, what happens if the inverse doesn't exist? https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix `nanosleep` definition in the posix spec (PR #67855)

2023-09-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e0b702f - [libc] Fix `nanosleep` definition in the posix spec (#67855)

2023-09-29 Thread via cfe-commits
Author: Joseph Huber Date: 2023-09-29T17:35:10-05:00 New Revision: e0b702ffc24b15b2ffb91cf4e7199f8fba80088c URL: https://github.com/llvm/llvm-project/commit/e0b702ffc24b15b2ffb91cf4e7199f8fba80088c DIFF: https://github.com/llvm/llvm-project/commit/e0b702ffc24b15b2ffb91cf4e7199f8fba80088c.diff

[clang] 832b3b2 - Modify BoundsSan to improve debuggability (#65972)

2023-09-29 Thread via cfe-commits
Author: Oskar Wirga Date: 2023-09-29T15:34:31-07:00 New Revision: 832b3b2462c1bb8e2b41ef96fe0ffd3791df0e12 URL: https://github.com/llvm/llvm-project/commit/832b3b2462c1bb8e2b41ef96fe0ffd3791df0e12 DIFF: https://github.com/llvm/llvm-project/commit/832b3b2462c1bb8e2b41ef96fe0ffd3791df0e12.diff

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-29 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a3c1172 - [Clang][test][VE] Correct bad test in 1e00423

2023-09-29 Thread Kazushi Marukawa via cfe-commits
Author: Kazushi (Jam) Marukawa Date: 2023-09-30T07:27:00+09:00 New Revision: a3c11723d508efd59dbadcc078fec7513f99fdfd URL: https://github.com/llvm/llvm-project/commit/a3c11723d508efd59dbadcc078fec7513f99fdfd DIFF:

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
https://github.com/vvereschaka resolved https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
https://github.com/vvereschaka resolved https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AIX]Fix -flto-jobs for AIX. (PR #67853)

2023-09-29 Thread via cfe-commits
https://github.com/Dhanrajbir-Hira edited https://github.com/llvm/llvm-project/pull/67853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson, thank you. I'm going to test it during the next 15-20 minutes. https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson, thank you. I'm going to test it during the next 15-20 minutes. https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson unresolved https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
@@ -151,6 +151,10 @@ set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS find_package(Python3 COMPONENTS Interpreter) +set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_LIBUNWIND_TEST_PARAMS "${RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_TEST_PARAMS}" CACHE INTERNAL

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson unresolved https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
@@ -151,6 +151,10 @@ set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS find_package(Python3 COMPONENTS Interpreter) +set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_LIBUNWIND_TEST_PARAMS "${RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_TEST_PARAMS}" CACHE INTERNAL

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
arichardson wrote: > @arichardson, any progress?! Sorry thought I'd pushed the latest version earlier, turns out there was an error during the push. Updated now. https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
arichardson wrote: > @arichardson, any progress?! Sorry thought I'd pushed the latest version earlier, turns out there was an error during the push. Updated now. https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson resolved https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson resolved https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67691 >From 70cfa2f35c152528e6c6e05690ce079c71169fc7 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Fri, 29 Sep 2023 09:03:01 -0700 Subject: [PATCH 1/2] [runtimes] Factor out serialize_lit_param to a

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67691 >From 70cfa2f35c152528e6c6e05690ce079c71169fc7 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Fri, 29 Sep 2023 09:03:01 -0700 Subject: [PATCH 1/2] [runtimes] Factor out serialize_lit_param to a

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson, any progress?! https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-09-29 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson, any progress?! https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][test] Avoid calling back into libunwind on sanitizer errors (PR #67861)

2023-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Changes The libunwind tests currently trigger MSan diagnostics, but while printing those diagnostics MSan calls back into libunwind to print a stack trace. And then this stack trace triggers another nested MSan fault which ends up recursing

[libunwind] [libunwind][test] Avoid calling back into libunwind on sanitizer errors (PR #67861)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/67861 The libunwind tests currently trigger MSan diagnostics, but while printing those diagnostics MSan calls back into libunwind to print a stack trace. And then this stack trace triggers another nested MSan

[libunwind] [libunwind] Fix running tests with MSan (PR #67860)

2023-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Changes In order to run tests with MSan we have silence two false-positives: First, we have to tell the runtime that __unw_getcontext actually populates the buffer with initialized data. Ideally we would call __msan_unpoison directly from

[libunwind] e83eb23 - [libunwind] Fix a -Wextra-semi warning

2023-09-29 Thread Alex Richardson via cfe-commits
Author: Alex Richardson Date: 2023-09-29T15:10:05-07:00 New Revision: e83eb23a2cff061adba41aae5d7304674c87c306 URL: https://github.com/llvm/llvm-project/commit/e83eb23a2cff061adba41aae5d7304674c87c306 DIFF:

[libunwind] [libunwind] Fix running tests with MSan (PR #67860)

2023-09-29 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/67860 In order to run tests with MSan we have silence two false-positives: First, we have to tell the runtime that __unw_getcontext actually populates the buffer with initialized data. Ideally we would call

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-29 Thread Luca Di sera via cfe-commits
diseraluca wrote: > > I gave it a quick try, and we would still end up with the same result in > > our codebase. But, generally, this would not probably be feasible for us as > > a solution. > > do you have an idea why? Can you show the diff of the changes you made? Is > the void

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: > > > The work sounds interesting. Can you provide a bit more context about it? > > > Will it be used to improve ICP when it's sufficient to just compare the > > > vtable address instead of the vfunc address? > > > > > > yes -- it can not only eliminate vtable load, but

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
@@ -19,20 +19,38 @@ namespace llvm { // Visitor class that finds all indirect call. struct PGOIndirectCallVisitor : public InstVisitor { std::vector IndirectCalls; + std::vector VTableAddrs; PGOIndirectCallVisitor() = default; void visitCallBase(CallBase ) { if

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
@@ -92,6 +92,19 @@ INSTR_PROF_DATA(const uint16_t, Int16ArrayTy, NumValueSites[IPVK_Last+1], \ /* INSTR_PROF_DATA end. */ +#ifndef INSTR_PROF_VTABLE_DATA +#define INSTR_PROF_VTABLE_DATA(Type, LLVMType, Name, Initializer) +#else +#define INSTR_PROF_VTABLE_DATA_DEFINED

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 resolved https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-29 Thread Alexander Smarus via cfe-commits
lxbndr wrote: @tru I apologize for any inconvenience, but should I rebase this to the latest master, or something else to unblock landing? I am not sure if I see any suitable rule in the contribution guide. Just in case it occasionally turns out that the blocker is me.

[clang] d89d3a6 - [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (#65918)

2023-09-29 Thread via cfe-commits
Author: Congcong Cai Date: 2023-09-30T05:50:38+08:00 New Revision: d89d3a6a0eb3e5f9ad35cd8b64a7237ed227f10b URL: https://github.com/llvm/llvm-project/commit/d89d3a6a0eb3e5f9ad35cd8b64a7237ed227f10b DIFF: https://github.com/llvm/llvm-project/commit/d89d3a6a0eb3e5f9ad35cd8b64a7237ed227f10b.diff

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. https://github.com/llvm/llvm-project/pull/66862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix -flto-jobs for AIX. (PR #67853)

2023-09-29 Thread via cfe-commits
https://github.com/Dhanrajbir-Hira reopened https://github.com/llvm/llvm-project/pull/67853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix -flto-jobs for AIX. (PR #67853)

2023-09-29 Thread via cfe-commits
https://github.com/Dhanrajbir-Hira edited https://github.com/llvm/llvm-project/pull/67853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Apologies for the post commit review, just have one question. https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
@@ -10977,6 +10987,9 @@ bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) { return false; Success = false; } + +// Make sure we run the destructors too. +Scope.destroy(); shafik wrote: So we don't have to

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix `nanosleep` definition in the posix spec (PR #67855)

2023-09-29 Thread via cfe-commits
https://github.com/michaelrj-google approved this pull request. LGTM from the libc side. https://github.com/llvm/llvm-project/pull/67855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix -flto-jobs for AIX. (PR #67853)

2023-09-29 Thread via cfe-commits
https://github.com/Dhanrajbir-Hira closed https://github.com/llvm/llvm-project/pull/67853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix `nanosleep` definition in the posix spec (PR #67855)

2023-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Changes Summary: The POSIX standard expects the first argument to this function to be constant, e.g. https://man7.org/linux/man-pages/man2/nanosleep.2.html. This fixes that problem and also corrects an obvious problem with enabling this for

[clang] [libc] Fix `nanosleep` definition in the posix spec (PR #67855)

2023-09-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67855 Summary: The POSIX standard expects the first argument to this function to be constant, e.g. https://man7.org/linux/man-pages/man2/nanosleep.2.html. This fixes that problem and also corrects an obvious problem

[clang] Fix -flto-jobs for AIX. (PR #67853)

2023-09-29 Thread via cfe-commits
https://github.com/Dhanrajbir-Hira created https://github.com/llvm/llvm-project/pull/67853 None >From c975a0f711cccd41a4602d97dab2864bde809144 Mon Sep 17 00:00:00 2001 From: Dhanrajbir Singh Hira Date: Fri, 29 Sep 2023 17:10:36 -0400 Subject: [PATCH] Fix -flto-jobs for AIX. ---

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-29 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > I gave it a quick try, and we would still end up with the same result in our > codebase. But, generally, this would not probably be feasible for us as a > solution. do you have an idea why? Can you show the diff of the changes you made? Is the void specialization not

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

2023-09-29 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/67613 >From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 27 Sep 2023 14:54:13 -0700 Subject: [PATCH 1/4] Make -frewrite-includes put an endif at the end of the

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
shafik wrote: ping https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-29 Thread Shafik Yaghmour via cfe-commits
shafik wrote: ping https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-29 Thread Luca Di sera via cfe-commits
diseraluca wrote: > @diseraluca, thanks for the thorough description. The point of these routines > is to produce code that compiles. I am not sure if we change `Foo::Bar` > with `Foo::Bar` it will compile. > > > Due to the way the current codebase is set up, the chosen specialization is > >

[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: I believe we have beaten this PR to death and would propose to merge it when the builds succeed. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][OpenMP][OMPIRBuilder] Move Clang's OpenMP Member/MemberOf flag helpers into the OMPIRBuilder (PR #67844)

2023-09-29 Thread Raghu Maddhipatla via cfe-commits
https://github.com/raghavendhra approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=alignment: check memcpy/memmove arguments (PR #67766)

2023-09-29 Thread Richard Smith via cfe-commits
zygoloid wrote: > Uh, why are we allowed to assume that memcpy pointer arguments are aligned? > This looks like a miscompile to me. This is definitely a bit weird, but... > A plain `int *` pointer is not required to be aligned, and memcpy works on > `void *` pointers, so I'm not sure where

[clang] [clang] Support fixed point types in C++ (PR #67750)

2023-09-29 Thread via cfe-commits
https://github.com/PiJoules closed https://github.com/llvm/llvm-project/pull/67750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a3a7d63 - [clang] Support fixed point types in C++ (#67750)

2023-09-29 Thread via cfe-commits
Author: PiJoules Date: 2023-09-29T13:56:55-07:00 New Revision: a3a7d6318027bb86e6614c022e77e0bd81aef6dc URL: https://github.com/llvm/llvm-project/commit/a3a7d6318027bb86e6614c022e77e0bd81aef6dc DIFF: https://github.com/llvm/llvm-project/commit/a3a7d6318027bb86e6614c022e77e0bd81aef6dc.diff

[clang] [clang] Support fixed point types in C++ (PR #67750)

2023-09-29 Thread via cfe-commits
https://github.com/PiJoules edited https://github.com/llvm/llvm-project/pull/67750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support fixed point types in C++ (PR #67750)

2023-09-29 Thread via cfe-commits
https://github.com/PiJoules edited https://github.com/llvm/llvm-project/pull/67750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-09-29 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Also added a release note. https://github.com/llvm/llvm-project/pull/67684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-09-29 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/67684 >From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 27 Sep 2023 15:30:52 -0700 Subject: [PATCH 1/4] [NFC] Change a reference member to pointer This will allow

[clang] 27770a7 - Revert "[NFC][Clang][OpenMP] Fix the test issue of incompatible pointer size"

2023-09-29 Thread JP Lehr via cfe-commits
Author: JP Lehr Date: 2023-09-29T15:21:32-05:00 New Revision: 27770a7de1e2a98e1c8a590e53d02a6c3d7fa660 URL: https://github.com/llvm/llvm-project/commit/27770a7de1e2a98e1c8a590e53d02a6c3d7fa660 DIFF: https://github.com/llvm/llvm-project/commit/27770a7de1e2a98e1c8a590e53d02a6c3d7fa660.diff LOG:

  1   2   3   4   5   >