[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-10-02 Thread Ian Anderson via Phabricator via cfe-commits
iana marked 5 inline comments as done. iana added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. dexonsmith wrote: > Bigcheese

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-10-02 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 557549. iana added a comment. Minimize the testing stdint.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

2023-10-02 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Pointer.h:81-88 + /// Equality operators are just for tests. + bool operator==(const Pointer ) const { +return Pointee == P.Pointee && Base == P.Base && Offset == P.Offset; + } + + bool operator!=(const

[clang] [clang][Interp] Diagnose uninitialized bases (PR #67131)

2023-10-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f58d54a - [clang][Interp] Diagnose uninitialized bases (#67131)

2023-10-02 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-03T06:46:31+02:00 New Revision: f58d54ab969b2f342a882dfb03334f18f4ec1dcc URL: https://github.com/llvm/llvm-project/commit/f58d54ab969b2f342a882dfb03334f18f4ec1dcc DIFF: https://github.com/llvm/llvm-project/commit/f58d54ab969b2f342a882dfb03334f18f4ec1dcc.diff

[clang] [clang][Interp] Diagnose uninitialized bases (PR #67131)

2023-10-02 Thread Timm Baeder via cfe-commits
tbaederr wrote: > Maybe we should change the existing evaluator to be consistent? Otherwise LGTM I'm not 100% sure what output is better, but we can change that later. This change is more about correctness. https://github.com/llvm/llvm-project/pull/67131

[clang] fb0a7c8 - [clang][Interp][NFC] Make IntegralAP::V private

2023-10-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-03T06:31:03+02:00 New Revision: fb0a7c8589e1320de1bf48161a4995a0e5dc8b77 URL: https://github.com/llvm/llvm-project/commit/fb0a7c8589e1320de1bf48161a4995a0e5dc8b77 DIFF: https://github.com/llvm/llvm-project/commit/fb0a7c8589e1320de1bf48161a4995a0e5dc8b77.diff

[clang] [RISCV][AArch64] Don't allow -mvscale-min/max options to be passed to the clang driver. (PR #68065)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Changes The driver doesn't have code to pass these down to cc1. It just prints an unused option warning. Remove them from the driver. --- Full diff: https://github.com/llvm/llvm-project/pull/68065.diff 1 Files Affected: - (modified)

[clang] [RISCV][AArch64] Don't allow -mvscale-min/max options to be passed to the clang driver. (PR #68065)

2023-10-02 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/68065 The driver doesn't have code to pass these down to cc1. It just prints an unused option warning. Remove them from the driver. >From b6be263a9b07425471f17e66b506bb805f29b8a0 Mon Sep 17 00:00:00 2001 From: Craig

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-02 Thread Timm Baeder via cfe-commits
@@ -4122,6 +4122,9 @@ def RestrictDocs : Documentation { The ``malloc`` attribute indicates that the function acts like a system memory allocation function, returning a pointer to allocated storage disjoint from the storage for any other object accessible to the caller. + +The

[clang] [analyzer] Fix false negative when accessing a nonnull property from … (PR #67563)

2023-10-02 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/67563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

2023-10-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ef9666a - [clang][Interp] Fix value truncation when casting int128 to smaller size (#67961)

2023-10-02 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-03T06:05:39+02:00 New Revision: ef9666aa81abdbcff54448446ba1f6fffe5fa45c URL: https://github.com/llvm/llvm-project/commit/ef9666aa81abdbcff54448446ba1f6fffe5fa45c DIFF: https://github.com/llvm/llvm-project/commit/ef9666aa81abdbcff54448446ba1f6fffe5fa45c.diff

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

2023-10-02 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1338-1341 PreviousNonComment->isOneOf( -TT_AttributeRParen, TT_AttributeSquare, TT_FunctionAnnotationRParen, -TT_JavaAnnotation, TT_LeadingJavaAnnotation))) ||

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-02 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67162 >From c2d5f809ab0f1be50cee4baaffdf3994807e5ef2 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 21 Sep 2023 13:52:16 -0400 Subject: [PATCH] [HIP] Support compressing device binary Add option

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-02 Thread Yaxun Liu via cfe-commits
@@ -1183,6 +1183,10 @@ def fgpu_inline_threshold_EQ : Joined<["-"], "fgpu-inline-threshold=">, def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, Group, HelpText<"Enable sanitizer for supported offloading devices">; def fno_gpu_sanitize : Flag<["-"], "fno-gpu-sanitize">,

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-10-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. Bigcheese wrote: > iana wrote: > > dexonsmith wrote: > > >

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-10-02 Thread Jocelyn Castellano via cfe-commits
https://github.com/pandaninjas updated https://github.com/llvm/llvm-project/pull/66315 >From ead65bfcb70be46788bc9e88c891e7ae7f91b8d7 Mon Sep 17 00:00:00 2001 From: PandaNinjas Date: Wed, 13 Sep 2023 17:38:17 -0700 Subject: [PATCH 01/22] [libc++] Prevent calling the projection more than three

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-10-02 Thread Jocelyn Castellano via cfe-commits
https://github.com/pandaninjas updated https://github.com/llvm/llvm-project/pull/66315 >From ead65bfcb70be46788bc9e88c891e7ae7f91b8d7 Mon Sep 17 00:00:00 2001 From: PandaNinjas Date: Wed, 13 Sep 2023 17:38:17 -0700 Subject: [PATCH 01/22] [libc++] Prevent calling the projection more than three

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

2023-10-02 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov deleted https://github.com/llvm/llvm-project/pull/68015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-10-02 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added a comment. This change looks good with the stdint.h comments resolved. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. iana

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

2023-10-02 Thread Félix-Antoine Constantin via Phabricator via cfe-commits
felix642 updated this revision to Diff 557546. felix642 added a comment. Wrong check name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

2023-10-02 Thread Félix-Antoine Constantin via Phabricator via cfe-commits
felix642 updated this revision to Diff 557545. felix642 marked 3 inline comments as done. felix642 added a comment. Updated documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files:

[clang] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68042 >From c7c9e907d897ae667331761d8097ccb7852c5d93 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Mon, 2 Oct 2023 16:43:13 -0500 Subject: [PATCH 1/2] [mlir][OpenMP] Added translation for `omp.teams` to LLVM

[clang] Add a release note for https://github.com/llvm/llvm-project/pull/68001 (PR #68061)

2023-10-02 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/68061 None >From bc5093e4942b3ac3d538eb1253515e4b7c562a4a Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Mon, 2 Oct 2023 18:43:26 -0700 Subject: [PATCH] Add a release note for

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

2023-10-02 Thread Matheus Izvekov via cfe-commits
@@ -923,6 +923,8 @@ void EmitAssemblyHelper::RunOptimizationPipeline( PB.crossRegisterProxies(LAM, FAM, CGAM, MAM); ModulePassManager MPM; + // Add a verifier pass, before any other passes, to catch CodeGen issues. + MPM.addPass(VerifierPass());

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

2023-10-02 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68015 >From be5fab19a147c979c7e8afb421d157b194f4a125 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 2 Oct 2023 13:52:35 +0200 Subject: [PATCH] [clang][codegen] Add a verifier IR pass before any further

[clang] e897014 - [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (#67066)

2023-10-02 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2023-10-03T03:23:34+02:00 New Revision: e8970141ec4326acb139789db01fb7c51538a4be URL: https://github.com/llvm/llvm-project/commit/e8970141ec4326acb139789db01fb7c51538a4be DIFF:

[clang] Mark an ObjCIvarDecl as invalid if its type contains errors (PR #68001)

2023-10-02 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: The commit fixed an assertion that was failing in SemaInit.cpp. Assertion failed: (Kind.getKind() == InitializationKind::IK_Copy || Kind.isExplicitCast() || Kind.getKind() == InitializationKind::IK_DirectList), function Perform, file SemaInit.cpp, line 8607. The assertion in

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The C23 standard supports enums with fixed underlying types (N3030 [1]), so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no longer a Clang extension at that point). [1]

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-02 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/68060 The C23 standard supports enums with fixed underlying types (N3030 [1]), so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no longer a Clang extension at that point). [1]

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-02 Thread Johannes Doerfert via cfe-commits
@@ -1183,6 +1183,10 @@ def fgpu_inline_threshold_EQ : Joined<["-"], "fgpu-inline-threshold=">, def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, Group, HelpText<"Enable sanitizer for supported offloading devices">; def fno_gpu_sanitize : Flag<["-"], "fno-gpu-sanitize">,

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-02 Thread Yaxun Liu via cfe-commits
@@ -881,6 +900,184 @@ CreateFileHandler(MemoryBuffer , "'" + FilesType + "': invalid file type specified"); } +OffloadBundlerConfig::OffloadBundlerConfig() { + auto IgnoreEnvVarOpt = +

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-02 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67162 >From b4b44809dcbc487239b4430751a232563c5ac590 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 21 Sep 2023 13:52:16 -0400 Subject: [PATCH] [HIP] Support compressing device binary Add option

[clang] [Clang][OpenMP][OMPIRBuilder] Move Clang's OpenMP Member/MemberOf flag helpers into the OMPIRBuilder (PR #67844)

2023-10-02 Thread via cfe-commits
shraiysh wrote: > I'll see what I can do about adding an OpenMPIRBuilderTest.cpp to the patch. I think it’s okay if it’s tested by clang tests (as Johannes mentioned). In case you decide to add tests for this, there is already an OpenMPIRBuilderTest.cpp in

[clang] [lld][ELF] Warn instead of error when linker script fails to find section (PR #68058)

2023-10-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 149346286801a5f32d254676760a7f4211801667 4dc3e74efa5dae42c2ffa408ef5d4a83c4b4754c --

[clang] [analyzer] Fix false negative when accessing a nonnull property from … (PR #67563)

2023-10-02 Thread via cfe-commits
tripleCC wrote: > Looks good, thanks! I think a comment about how the types in the AST already > has the nullability propagated correctly might be helpful for the future > readers, otherwise it looks good to me! Thanks for reviewing, I added a comment for nullability propagated now.

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-02 Thread Alois Klink via cfe-commits
https://github.com/aloisklink created https://github.com/llvm/llvm-project/pull/68059 Ignore the `[[malloc(x)]]` or `[[malloc(x, 1)]]` function attribute syntax added in [GCC 11][1]. Unlike `[[malloc]]` with no arguments (which is supported by Clang), GCC uses the one or two argument form to

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

2023-10-02 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: @kstoimenov I believe you are supposed to notify the MR in case of reverts, otherwise I could have missed this if I wasn't awake. I believe in this case the bot is misconfigured, it's using `-Werror,-Wmissing-field-initializers`, the 'error' is just a missing initializer,

[clang] [lld][ELF] Warn instead of error when linker script fails to find section (PR #68058)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld Changes It can be hard to predict whether a section exist when using the `INSERT AFTER/BEFORE section` directive, this makes it difficult to apply a global linker script that's applicable to the entire build system. We should warn instead of hard

[clang] [lld][ELF] Warn instead of error when linker script fails to find section (PR #68058)

2023-10-02 Thread via cfe-commits
https://github.com/christycylee created https://github.com/llvm/llvm-project/pull/68058 It can be hard to predict whether a section exist when using the `INSERT AFTER/BEFORE ` directive, this makes it difficult to apply a global linker script that's applicable to the entire build system. We

[clang] [analyzer] Fix false negative when accessing a nonnull property from … (PR #67563)

2023-10-02 Thread via cfe-commits
https://github.com/tripleCC updated https://github.com/llvm/llvm-project/pull/67563 >From 0783db5bcaed863cd0cd5c5a2e0d8cc3355e7f51 Mon Sep 17 00:00:00 2001 From: tripleCC Date: Wed, 27 Sep 2023 22:05:19 +0800 Subject: [PATCH] [analyzer] Fix false negative when accessing a nonnull property

[clang] 1493462 - Revert "[NFC][Clang][CodeGen] Improve performance for vtable metadata generation (#67066)"

2023-10-02 Thread Kirill Stoimenov via cfe-commits
Author: Kirill Stoimenov Date: 2023-10-03T00:09:46Z New Revision: 149346286801a5f32d254676760a7f4211801667 URL: https://github.com/llvm/llvm-project/commit/149346286801a5f32d254676760a7f4211801667 DIFF: https://github.com/llvm/llvm-project/commit/149346286801a5f32d254676760a7f4211801667.diff

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-10-02 Thread Mingming Liu via cfe-commits
@@ -90,9 +90,33 @@ public: } }; +/// VirtualTableValueProfilingPlugin +class VTableProfilingPlugin { + Function + +public: + static constexpr InstrProfValueKind Kind = IPVK_VTableTarget; + +

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

2023-10-02 Thread Daniel Paoliello via Phabricator via cfe-commits
dpaoliello added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:248-257 + // The first 4 FP/Vector arguments are passed in XMM registers. + CCIfType<[f16], + CCAssignToRegWithShadow<[H0, H1, H2, H3], +

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-02 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/7] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-02 Thread Jan Svoboda via cfe-commits
@@ -50,6 +50,7 @@ int y = a2; // CHECK: In module 'a': // CHECK-NEXT: a.h:1:45: error: +int z = b; // MISSING-B: could not find file '{{.*}}b.h' // MISSING-B-NOT: please delete the module cache jansvoboda11 wrote: I'm not sure. To me, this seems like an

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-02 Thread Jan Svoboda via cfe-commits
@@ -288,10 +288,12 @@ class ModuleFile { /// for the entry is SLocEntryOffsetsBase + SLocEntryOffsets[i]. uint64_t SLocEntryOffsetsBase = 0; - /// Offsets for all of the source location entries in the - /// AST file. + /// Stream bit offsets for all of the source

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

2023-10-02 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Weird, the commit in the MR has a description, but it lost the description when merging through the github interface. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -180,6 +180,20 @@ TEST(PagedVectorTest, FillNonTrivialConstructor) { EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 10LL); } +// Test that isMaterialized returns true for all the elements +// of the page, not only the one that was accessed.

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

2023-10-02 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Please next time before you commit add a more detailed description of the change so that readers of git log can get a better understanding of the change w/o having to view it in detail. https://github.com/llvm/llvm-project/pull/67066

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

2023-10-02 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 22d8f1d - [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (#67066)

2023-10-02 Thread via cfe-commits
Author: Matheus Izvekov Date: 2023-10-03T00:45:00+02:00 New Revision: 22d8f1dd533e3e56512237811b8d8db83d85edce URL: https://github.com/llvm/llvm-project/commit/22d8f1dd533e3e56512237811b8d8db83d85edce DIFF:

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

2023-10-02 Thread Jared Grubb via Phabricator via cfe-commits
jaredgrubb updated this revision to Diff 557542. jaredgrubb added a comment. Address review comments, and adjusting the patch to address other merges since this patch was started. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://reviews.llvm.org/D145262 Files:

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-02 Thread Jan Svoboda via cfe-commits
@@ -864,74 +864,7 @@ FileID SourceManager::getFileIDLocal(SourceLocation::UIntTy SLocOffset) const { /// This function knows that the SourceLocation is in a loaded buffer, not a /// local one. FileID SourceManager::getFileIDLoaded(SourceLocation::UIntTy SLocOffset) const { -

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[libunwind] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. Looks like it fixes some bugs in the tests too! https://github.com/llvm/llvm-project/pull/67955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-02 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 61e8961cde95e9e8ce8cea3efd6aa52273f430e9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/3] [clang][modules] Remove preloaded SLocEntries from PCM

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-02 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I don't understand why the tie-breaking code calls the previously visited `FileID` a parent. We're walking **up** the include/expansion tree, so I think it should be called child instead. LMK if I'm misunderstanding. https://github.com/llvm/llvm-project/pull/66962

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-02 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Turns out some clients are calling `isBeforeInTranslationUnit()` before checking if both `SourceLocations` are indeed in the same TU. I left behind a FIXME to call `llvm_unreachable()`, but for now, I just compare the `FileIDs` to keep things working.

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-02 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Since I moved up the special-casing of built-ins buffer up in my last commit, it was happening before we got chance to walk up from `FileID(3)` to `FileID(2)`, meaning it wasn't kicking in. I think we need to sink the special-casing into `isInTheSameTranslationUnit()` and

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-02 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I got around investigating "SemaCXX/warn-unsafe-buffer-usage-fixits-parm-span.cpp" and found out it uses this pattern: ``` %clang_cc1 ... -include %s %s ``` This means `FileID(1)` is the main input file `%s` and `FileID(2)` is the built-ins buffer that includes `%s` as

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-02 Thread Owen Pan via cfe-commits
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) { " a_longer_name_for_wrap}};", Alignment); - Alignment.ColumnLimit = 60; + Alignment = getLLVMStyleWithColumns(60); +

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-02 Thread Owen Pan via cfe-commits
owenca wrote: Can you add an issue to show the incorrect format before this patch? https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 457f582ffe23e951380bc345c4c96ec053c09681 dc0304897ba3f8731bb6062f357fe885ca7e584b --

[libunwind] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 457f582ffe23e951380bc345c4c96ec053c09681 dc0304897ba3f8731bb6062f357fe885ca7e584b --

[clang] [clang][AIX]Fix -flto-jobs for AIX. (PR #67853)

2023-10-02 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu approved this pull request. LGTM! Thanks! https://github.com/llvm/llvm-project/pull/67853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-openmp Changes This patch adds translation from `omp.teams` operation to LLVM IR using OpenMPIRBuilder. The clauses are not handled in this patch. --- Full diff: https://github.com/llvm/llvm-project/pull/68042.diff 2 Files Affected: -

[clang] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-openmp Changes This patch adds translation from `omp.teams` operation to LLVM IR using OpenMPIRBuilder. The clauses are not handled in this patch. --- Full diff: https://github.com/llvm/llvm-project/pull/68042.diff 2 Files Affected: -

[clang] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68042 This patch adds translation from `omp.teams` operation to LLVM IR using OpenMPIRBuilder. The clauses are not handled in this patch. >From c7c9e907d897ae667331761d8097ccb7852c5d93 Mon Sep 17 00:00:00 2001 From:

[libunwind] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-02 Thread Johannes Doerfert via cfe-commits
@@ -79,15 +79,15 @@ struct TimeTraceProfilerEntry { // Calculate timings for FlameGraph. Cast time points to microsecond precision jdoerfert wrote: Can you split the changes to this file into a separate PR? Also check the file, the comment still states

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const unassigned https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const unassigned https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[libunwind] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,61 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[libunwind] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[libunwind] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const unassigned https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const requested changes to this pull request. Thanks for addressing most of the feedback! Did another round. https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// var-const wrote: Can you please go through various `robust` test files and add tests for `contains` where it makes sense? Let me know if you need any help with

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[libunwind] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,61 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

2023-10-02 Thread via cfe-commits
goldsteinn wrote: > Apart from that, the functional changes themselves look good to me. Fixed. Okay to push? https://github.com/llvm/llvm-project/pull/67756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

2023-10-02 Thread Richard Howell via cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From a44aa3a04dd6391cf4660cefe451ac1d53aa429d Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] use absolute path for builtin headers during module

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 55d8f0cd31311ed3ebc85bef2c9b5cfca1579076 3724f695e7699840998d8af16a60f02f90f64b95 --

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-02 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/68039 >From baf0fc082f2cfa86346a93b22c39b92e9e7e261b Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Mon, 2 Oct 2023 22:29:14 +0200 Subject: [PATCH 1/4] impl ---

[PATCH] D145214: [TSAN] add support for riscv64

2023-10-02 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SANITIZER_LIMIT_FRAME_SIZE

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-10-02 Thread Pranav Kant via cfe-commits
https://github.com/pranavk closed https://github.com/llvm/llvm-project/pull/67196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 457f582 - [clang] Predefined macros for float128 support (#67196)

2023-10-02 Thread via cfe-commits
Author: Pranav Kant Date: 2023-10-02T14:14:52-07:00 New Revision: 457f582ffe23e951380bc345c4c96ec053c09681 URL: https://github.com/llvm/llvm-project/commit/457f582ffe23e951380bc345c4c96ec053c09681 DIFF: https://github.com/llvm/llvm-project/commit/457f582ffe23e951380bc345c4c96ec053c09681.diff

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes At the moment in `Interp` the source array initialization (`getCommonExpr()`) of an `ArrayInitLoopExpr` is evaluated during every iteration, when it should only be evaluated once. The initializer is always wrapped inside an

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-02 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/68039 >From baf0fc082f2cfa86346a93b22c39b92e9e7e261b Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Mon, 2 Oct 2023 22:29:14 +0200 Subject: [PATCH 1/3] impl ---

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-02 Thread via cfe-commits
https://github.com/isuckatcs created https://github.com/llvm/llvm-project/pull/68039 At the moment in `Interp` the source array initialization (`getCommonExpr()`) of an `ArrayInitLoopExpr` is evaluated during every iteration, when it should only be evaluated once. The initializer is always

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

2023-10-02 Thread Ben Langmuir via cfe-commits
@@ -348,6 +348,10 @@ bool ModuleMap::resolveAsBuiltinHeader( if (!File) return false; + // Ensure the path to the module directory is absolute, otherwise + // builtin headers will fail to resolve when using relative resource + // directory paths without a -I. +

  1   2   3   4   5   >