[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

2023-10-03 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Windows: http://45.33.8.238/win/84498/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 ___ cfe-commits mailing list

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

2023-10-03 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This seems to break tests on Mac and windows, see eg http://45.33.8.238/macm1/70415/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/

[libclc] [SystemZ][z/OS] Implement executePostLayoutBinding for GOFFObjectWriter (PR #67868)

2023-10-03 Thread Neumann Hon via cfe-commits
https://github.com/Everybody0523 updated https://github.com/llvm/llvm-project/pull/67868 >From 80073957d9adf8d107515d49a741df2b2130f82d Mon Sep 17 00:00:00 2001 From: Neumann Hon Date: Fri, 29 Sep 2023 19:52:27 -0400 Subject: [PATCH] [SystemZ][z/OS] Implement executePostLayoutBinding for

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Erich Keane via cfe-commits
@@ -216,6 +216,9 @@ Improvements to Clang's diagnostics - The fix-it emitted by ``-Wformat`` for scoped enumerations now take the enumeration's underlying type into account instead of suggesting a type just based on the format string specifier being used. +-

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/3] [diag] Silence `-Wfixed-enum-extension` in C23 The C23

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

2023-10-03 Thread via cfe-commits
@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result =

[libunwind] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

2023-10-03 Thread Joe Nash via cfe-commits
Sisyph wrote: > I've just tested this on 1 graphics shaders and it seems to make no > difference at all. I tried gfx900 and gfx1100. Can anyone else from the > graphics team confirm this? I can confirm no difference on gfx1102 https://github.com/llvm/llvm-project/pull/67878

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

2023-10-03 Thread Richard Howell via cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From 3617539eecb4bfcb9f2a20a1ae1cff71b298 Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] use absolute path for builtin headers during module

[clang] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

2023-10-03 Thread Joe Nash via cfe-commits
Sisyph wrote: > I've just tested this on 1 graphics shaders and it seems to make no > difference at all. I tried gfx900 and gfx1100. Can anyone else from the > graphics team confirm this? I can confirm no difference on gfx1102 https://github.com/llvm/llvm-project/pull/67878

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

2023-10-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 06a05f334698c10a60459d30b4074fabedf72c48 83e868a92647efb783e43db48705b0db63188d84 --

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I believe this needs a release note as well (see docs/ReleaseNotes.rst), else this LGTM. https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec , else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/2] [diag] Silence `-Wfixed-enum-extension` in C23 The C23

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

2023-10-03 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/68090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

2023-10-03 Thread Shafik Yaghmour via cfe-commits
@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result =

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

2023-10-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes Following the version bump in #67964 and the bug fix in #68026 I believe we're ready to mark Zfa as non-experimental. I'll note the GCC torture suite passes now with Zfa enabled (though it's more of a litmus test than anything

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

2023-10-03 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/68113 Following the version bump in #67964 and the bug fix in #68026 I believe we're ready to mark Zfa as non-experimental. I'll note the GCC torture suite passes now with Zfa enabled (though it's more of a litmus test

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

2023-10-03 Thread Alex Bradbury via cfe-commits
asb wrote: > ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️ This is a whitespace change > 20 lines away from the edit made in the test file, so I don't believe it's appropriate to reformat in this PR. https://github.com/llvm/llvm-project/pull/67964

[clang] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

2023-10-03 Thread Jay Foad via cfe-commits
jayfoad wrote: I've just tested this on 1 graphics shaders and it seems to make no difference at all. I tried gfx900 and gfx1100. Can anyone else from the graphics team confirm this? https://github.com/llvm/llvm-project/pull/67878 ___

[libunwind] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

2023-10-03 Thread Jay Foad via cfe-commits
jayfoad wrote: I've just tested this on 1 graphics shaders and it seems to make no difference at all. I tried gfx900 and gfx1100. Can anyone else from the graphics team confirm this? https://github.com/llvm/llvm-project/pull/67878 ___

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

2023-10-03 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can you write a more detailed description explaining what the problem is what the fix is. This is what usually ends up in the git log and we want that to be as descriptive as possible for folks who use it to understand changes quickly without digging into details.

[clang] remove duplicate ModuleId alias (PR #67899)

2023-10-03 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/67899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 06a05f3 - [NFC] remove duplicate ModuleId alias (#67899)

2023-10-03 Thread via cfe-commits
Author: David Stone Date: 2023-10-03T22:43:51+08:00 New Revision: 06a05f334698c10a60459d30b4074fabedf72c48 URL: https://github.com/llvm/llvm-project/commit/06a05f334698c10a60459d30b4074fabedf72c48 DIFF: https://github.com/llvm/llvm-project/commit/06a05f334698c10a60459d30b4074fabedf72c48.diff

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-03 Thread Erich Keane via cfe-commits
erichkeane wrote: > The paper where this came from is: https://wg21.link/P0620R0. most of this > paper was already implemented. Where is the paper tracking doc I need to > update? https://clang.llvm.org/cxx_status.html claims this paper is > implemented. Sorry if the following questions are

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-03 Thread Erich Keane via cfe-commits
erichkeane wrote: > The paper where this came from is: https://wg21.link/P0620R0. most of this > paper was already implemented. Where is the paper tracking doc I need to > update? https://clang.llvm.org/cxx_status.html claims this paper is > implemented. Sorry if the following questions are

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-03 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960 >From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Fri, 29 Sep 2023 08:37:57 +0200 Subject: [PATCH 1/9] Avoid need for

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-03 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960 >From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Fri, 29 Sep 2023 08:37:57 +0200 Subject: [PATCH 1/8] Avoid need for

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-03 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:147-149 +def ext_vla_cxx_static_assert : ExtWarn< + "variable length arrays in C++ are a Clang extension; did you mean to use " + "'static_assert'?">, InGroup;

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-03 Thread Vassil Vassilev via cfe-commits
@@ -489,6 +490,8 @@ class SLocEntry { bool isExpansion() const { return IsExpansion; } bool isFile() const { return !isExpansion(); } + bool isLoaded() const { return Loaded; } + void setLoaded(bool Value) { Loaded = Value; } vgvassilev wrote:

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-03 Thread Vassil Vassilev via cfe-commits
@@ -474,9 +474,10 @@ static_assert(sizeof(FileInfo) <= sizeof(ExpansionInfo), /// SourceManager keeps an array of these objects, and they are uniquely /// identified by the FileID datatype. class SLocEntry { - static constexpr int OffsetBits = 8 *

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

2023-10-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b1295dd5c923c6828775406b4063de1531fd4782 f21c479811de5cb476ef8d2abe0265b1bf8ea24f --

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Erich Keane via cfe-commits
@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec , else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-03 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 nits on the CFE, else LGTM! Obviously you still need an LLVM reviewer for the backend changes. Comment at: clang/lib/CodeGen/CGExpr.cpp:3701 + QualType

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-03 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: The ADT change looks good to me, I'm not familiar with the clang code though. https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [RISCV][AArch64] Don't allow -mvscale-min/max options to be passed to the clang driver. (PR #68065)

2023-10-03 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/68065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8092933 - [RISCV][AArch64] Don't allow -mvscale-min/max options to be passed to the clang driver. (#68065)

2023-10-03 Thread via cfe-commits
Author: Craig Topper Date: 2023-10-03T07:26:08-07:00 New Revision: 8092933246507a7b6c4385afbf0b9750a6d00de9 URL: https://github.com/llvm/llvm-project/commit/8092933246507a7b6c4385afbf0b9750a6d00de9 DIFF: https://github.com/llvm/llvm-project/commit/8092933246507a7b6c4385afbf0b9750a6d00de9.diff

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

2023-10-03 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/67964 >From 79ab61e07a01e503f22e717c4b0e64b7741c59a0 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 2 Oct 2023 11:06:44 +0100 Subject: [PATCH 1/3] [RISCV] Update Zfa extension version to 1.0 The Zfa specification

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

2023-10-03 Thread Björn Pettersson via cfe-commits
https://github.com/bjope edited https://github.com/llvm/llvm-project/pull/68091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

2023-10-03 Thread Björn Pettersson via cfe-commits
@@ -331,6 +340,56 @@ static void SetInstallDir(SmallVectorImpl , // path being a symlink. SmallString<128> InstalledPath(argv[0]); +#if defined(__linux__) bjope wrote: I was kind of thinking the same. And then started to wonder about why SetInstallDir

[clang] Extension: allow recursive macros (PR #65851)

2023-10-03 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851 >From d10ce5dd9e49fe85eac2e1f93a65cb27b511a71f Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 01/18] add define2 pp directive ---

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-03 Thread via cfe-commits
https://github.com/DaMatrix updated https://github.com/llvm/llvm-project/pull/66894 >From f24c57fdd4e9cd3208c661d2f716c0251cff1c5e Mon Sep 17 00:00:00 2001 From: DaPorkchop_ Date: Sun, 13 Aug 2023 22:39:12 +0200 Subject: [PATCH] [clang] Implement constexpr bit_cast for vectors ---

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

2023-10-03 Thread Nikita Popov via cfe-commits
nikic wrote: It looks like x86-bswap.c still has the C++ guarded code in it. Any thoughts on > Though I think we might be better off passing `-no-enable-noundef-analysis` > to these tests, as noundef is really not what they want to test. to avoid the test duplication?

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/68106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:147-149 +def ext_vla_cxx_static_assert : ExtWarn< + "variable length arrays in C++ are a Clang extension; did you mean to use " +

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/5] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/4] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/3] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/68106 None >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/2] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-10-03 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: Thanks @DavidTruby. For this particular patch, the main concern is how the compiler flags are mapped to the corresponding linker flags on Windows. All of that work is done by clang, and I haven't touched any of it so I am not worried about correctness. The two main

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. CarlosAlbertoEnciso wrote: Moving

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. CarlosAlbertoEnciso wrote: Moving

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/66745 >From b24943f63025822a5c5ba90c4a7b47f7123ec4db Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Mon, 18 Sep 2023 12:29:17 +0100 Subject: [PATCH] [IPSCCP] Variable not visible at Og:

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

2023-10-03 Thread Carlos Alberto Enciso via cfe-commits
https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/66745 >From b24943f63025822a5c5ba90c4a7b47f7123ec4db Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Mon, 18 Sep 2023 12:29:17 +0100 Subject: [PATCH] [IPSCCP] Variable not visible at Og:

[clang] [AArch64][FMV] Add rcpc3 support, introduce bits for features extensi… (PR #68104)

2023-10-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes …on and initialization. The patch implements FEAT_LRCPC3 support (Load-Acquire RCpc instructions version 3) in Function Multi Versioning. To maintain compatibility while features list grows extension bit FEAT_EXT and initialization bit

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

2023-10-03 Thread Aaron Ballman via cfe-commits
@@ -331,6 +340,56 @@ static void SetInstallDir(SmallVectorImpl , // path being a symlink. SmallString<128> InstalledPath(argv[0]); +#if defined(__linux__) AaronBallman wrote: Can we use

[clang] [AArch64][FMV] Add rcpc3 support, introduce bits for features extensi… (PR #68104)

2023-10-03 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv created https://github.com/llvm/llvm-project/pull/68104 …on and initialization. The patch implements FEAT_LRCPC3 support (Load-Acquire RCpc instructions version 3) in Function Multi Versioning. To maintain compatibility while features list grows extension bit

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-03 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1f01269 - [clang-format] Fix alignment in presence of template functions (#68029)

2023-10-03 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-10-03T15:35:30+02:00 New Revision: 1f0126902876cb42a7502047e62bdf512fd96b02 URL: https://github.com/llvm/llvm-project/commit/1f0126902876cb42a7502047e62bdf512fd96b02 DIFF:

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-03 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: > Can you add an issue to show the incorrect format before this patch? Done. https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-03 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-10-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8420-8428 +if (Result.getResultKind() == LookupResult::Found) { + SourceRange SR = CBA->getCountedByFieldLoc(); + Diag(SR.getBegin(), +

[clang] [Clang] Do not try to classify dependant call expression (PR #68078)

2023-10-03 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/68078 >From a14d189cfd513d4b2c8353fbab1a53927d2feaf5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 3 Oct 2023 09:55:08 +0200 Subject: [PATCH 1/2] [Clang] Do not try to classify dependant call expression

[clang] [Clang][OpenMP][OMPIRBuilder] Move Clang's OpenMP Member/MemberOf flag helpers into the OMPIRBuilder (PR #67844)

2023-10-03 Thread via cfe-commits
https://github.com/agozillon closed https://github.com/llvm/llvm-project/pull/67844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bc0c178 - [Clang][OpenMP][OMPIRBuilder] Move Clang's OpenMP Member/MemberOf flag helpers into the OMPIRBuilder (#67844)

2023-10-03 Thread via cfe-commits
Author: agozillon Date: 2023-10-03T15:20:44+02:00 New Revision: bc0c1783fd5a4b0a2202ee9613cefd2c67d7 URL: https://github.com/llvm/llvm-project/commit/bc0c1783fd5a4b0a2202ee9613cefd2c67d7 DIFF: https://github.com/llvm/llvm-project/commit/bc0c1783fd5a4b0a2202ee9613cefd2c67d7.diff

[clang] [clang][AIX]Fix -flto-jobs for AIX. (PR #67853)

2023-10-03 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu closed https://github.com/llvm/llvm-project/pull/67853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0bb4b24 - [clang][AIX]Fix -flto-jobs for AIX. (#67853)

2023-10-03 Thread via cfe-commits
Author: Dhanrajbir-Hira Date: 2023-10-03T09:18:21-04:00 New Revision: 0bb4b24ca35e1e67efc8ea2152085f981207210c URL: https://github.com/llvm/llvm-project/commit/0bb4b24ca35e1e67efc8ea2152085f981207210c DIFF:

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-10-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:211-212 with terminals with dark background colors. This is also more consistent with GCC. +- Clang now displays an improved diagnostic and a note when defaulted special + member is a contexpr in

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

2023-10-03 Thread Krishna Narayanan via cfe-commits
https://github.com/Krishna-13-cyber updated https://github.com/llvm/llvm-project/pull/65650 >From 145ff3877b588aebd811f26b6d596257ea889957 Mon Sep 17 00:00:00 2001 From: Krishna-13-cyber Date: Thu, 7 Sep 2023 22:35:53 +0530 Subject: [PATCH 1/2] Add Documentation for Execution Results Handling

[clang] 3e3cf77 - [HIP][Clang][Driver] Fix build failure introduced by https://reviews.llvm.org/rG9a408588d1b8b7899eff593c537de539a4a12651

2023-10-03 Thread Alex Voicu via cfe-commits
Author: Alex Voicu Date: 2023-10-03T13:45:32+01:00 New Revision: 3e3cf77cbebab237b3f9379fc07d4b1af391f874 URL: https://github.com/llvm/llvm-project/commit/3e3cf77cbebab237b3f9379fc07d4b1af391f874 DIFF: https://github.com/llvm/llvm-project/commit/3e3cf77cbebab237b3f9379fc07d4b1af391f874.diff

[clang] [clang-repl] Emit const variables only once (PR #65257)

2023-10-03 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: Note that this currently doesn't seem to work on Windows: https://github.com/llvm/llvm-project/issues/68092 https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

2023-10-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: You have failed tests on Linux CI: ``` Failed Tests (4): Clang :: Driver/mingw-sysroot.cpp Clang :: Driver/no-canonical-prefixes.c Clang :: Driver/program-path-priority.c Clang :: Driver/rocm-detect.hip ``` Windows CI has another test in Clang interpreter failing, but that

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-03 Thread Botond István Hprváth via cfe-commits
https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/2] Choose the correct deduction guide If there are two guides, one of

[PATCH] D155833: [HIP][Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

2023-10-03 Thread Alex Voicu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d680f56475c: [HIP][Clang][Sema] Add Sema support for `hipstdpar` (authored by AlexVlx). Changed prior to commit:

[clang] 4d680f5 - [HIP][Clang][Sema] Add Sema support for `hipstdpar`

2023-10-03 Thread Alex Voicu via cfe-commits
Author: Alex Voicu Date: 2023-10-03T13:29:12+01:00 New Revision: 4d680f56475ce17d8fb793655eb3d77ac8aee1b9 URL: https://github.com/llvm/llvm-project/commit/4d680f56475ce17d8fb793655eb3d77ac8aee1b9 DIFF: https://github.com/llvm/llvm-project/commit/4d680f56475ce17d8fb793655eb3d77ac8aee1b9.diff

[libclc] 5ec9faf - [LIBCLC] Teach prepare-builtins how to handle text based IR (#66993)

2023-10-03 Thread via cfe-commits
Author: Jakub Chlanda Date: 2023-10-03T14:28:01+02:00 New Revision: 5ec9faf007cc2589682cd28a10aa5a351f6aebda URL: https://github.com/llvm/llvm-project/commit/5ec9faf007cc2589682cd28a10aa5a351f6aebda DIFF: https://github.com/llvm/llvm-project/commit/5ec9faf007cc2589682cd28a10aa5a351f6aebda.diff

[libclc] [LIBCLC] Teach prepare-builtins how to handle text based IR (PR #66993)

2023-10-03 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda closed https://github.com/llvm/llvm-project/pull/66993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-03 Thread Botond István Hprváth via cfe-commits
https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH] Choose the correct deduction guide If there are two guides, one of them

[clang-tools-extra] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-03 Thread via cfe-commits
@@ -79,15 +79,15 @@ struct TimeTraceProfilerEntry { // Calculate timings for FlameGraph. Cast time points to microsecond precision fel-cab wrote: Removed this file from this PR https://github.com/llvm/llvm-project/pull/68016

[libunwind] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-03 Thread via cfe-commits
@@ -79,15 +79,15 @@ struct TimeTraceProfilerEntry { // Calculate timings for FlameGraph. Cast time points to microsecond precision fel-cab wrote: Removed this file from this PR https://github.com/llvm/llvm-project/pull/68016

[clang] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-03 Thread via cfe-commits
@@ -79,15 +79,15 @@ struct TimeTraceProfilerEntry { // Calculate timings for FlameGraph. Cast time points to microsecond precision fel-cab wrote: Removed this file from this PR https://github.com/llvm/llvm-project/pull/68016

[clang] Extension: allow recursive macros (PR #65851)

2023-10-03 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851 >From d10ce5dd9e49fe85eac2e1f93a65cb27b511a71f Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 01/17] add define2 pp directive ---

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

2023-10-03 Thread via cfe-commits
@@ -8366,8 +8366,14 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { return false; if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { + auto *MD = cast(Info.CurrentCall->Callee); // Start with 'Result'

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

2023-10-03 Thread Alex Voicu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0f8748d448b: [HIP][Clang][Preprocessor] Add Preprocessor support for `hipstdpar` (authored by AlexVlx). Changed prior to commit:

[clang] c0f8748 - [HIP][Clang][Preprocessor] Add Preprocessor support for `hipstdpar`

2023-10-03 Thread Alex Voicu via cfe-commits
Author: Alex Voicu Date: 2023-10-03T13:18:31+01:00 New Revision: c0f8748d448be69748fee73014a60ada22b41b0d URL: https://github.com/llvm/llvm-project/commit/c0f8748d448be69748fee73014a60ada22b41b0d DIFF: https://github.com/llvm/llvm-project/commit/c0f8748d448be69748fee73014a60ada22b41b0d.diff

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

2023-10-03 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/68090 >From d3c5351c0bddd0bf9cd743471beafbf18bbab77c Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 3 Oct 2023 13:19:50 +0200 Subject: [PATCH 1/2] [Clang] Fix constant evaluating a captured variable in a

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-10-03 Thread Nouman Amir via Phabricator via cfe-commits
NoumanAmir657 updated this revision to Diff 557557. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

<    1   2   3   4   5   >