[clang] ece5dd1 - [clang] Stop including llvm/ADT/StringMap.h (NFC)

2023-10-13 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-10-13T21:34:23-07:00 New Revision: ece5dd101c7e4dc2fd23428abd312f75fd3d3eaf URL: https://github.com/llvm/llvm-project/commit/ece5dd101c7e4dc2fd23428abd312f75fd3d3eaf DIFF: https://github.com/llvm/llvm-project/commit/ece5dd101c7e4dc2fd23428abd312f75fd3d3eaf.diff

[clang] 18d1991 - Stop including llvm/ADT/STLFunctionalExtras.h (NFC)

2023-10-13 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-10-13T20:50:58-07:00 New Revision: 18d199116fe2150549110da68ac0ca8cfd80f9c8 URL: https://github.com/llvm/llvm-project/commit/18d199116fe2150549110da68ac0ca8cfd80f9c8 DIFF: https://github.com/llvm/llvm-project/commit/18d199116fe2150549110da68ac0ca8cfd80f9c8.diff

[clang] [clang] Additional FP classification functions (PR #69041)

2023-10-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Serge Pavlov (spavloff) Changes C language standard defined library functions `iszero`, `issignaling` and `issubnormal`, which did not have counterparts among clang builtin functions. This change adds new functions:

[clang] [clang] Additional FP classification functions (PR #69041)

2023-10-13 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff created https://github.com/llvm/llvm-project/pull/69041 C language standard defined library functions `iszero`, `issignaling` and `issubnormal`, which did not have counterparts among clang builtin functions. This change adds new functions: __builtin_iszero

[clang] 3743c53 - [clang] Remove unused using decls (NFC)

2023-10-13 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-10-13T20:09:32-07:00 New Revision: 3743c53dd19fd2f935dfd4dec17ca1b1f7911ddb URL: https://github.com/llvm/llvm-project/commit/3743c53dd19fd2f935dfd4dec17ca1b1f7911ddb DIFF: https://github.com/llvm/llvm-project/commit/3743c53dd19fd2f935dfd4dec17ca1b1f7911ddb.diff

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const requested changes to this pull request. Thank you for the patch! https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const edited https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -214,6 +214,19 @@ namespace ranges { constexpr ranges::minmax_element_result> minmax_element(R&& r, Comp comp = {}, Proj proj = {}); // since C++20 + template S1, forward_iterator I2, +sentinel_for S2, class Pred

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const edited https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const requested changes to this pull request. Thank you for the patch! https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] f3cfd38 - [AST] Stop including llvm/ADT/StringMap.h (NFC)

2023-10-13 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-10-13T18:22:42-07:00 New Revision: f3cfd3812b4a721fcf1be0e242a31d547c908459 URL: https://github.com/llvm/llvm-project/commit/f3cfd3812b4a721fcf1be0e242a31d547c908459 DIFF: https://github.com/llvm/llvm-project/commit/f3cfd3812b4a721fcf1be0e242a31d547c908459.diff

[clang] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-13 Thread Louis Dionne via cfe-commits
@@ -41,13 +42,12 @@ _LIBCPP_NODISCARD inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 boo return true; } -template < -class _Tp, -class _Up, -class _BinaryPredicate, -__enable_if_t<__is_trivial_equality_predicate<_BinaryPredicate, _Tp,

[clang] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2023-10-13 Thread via cfe-commits
https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626 >From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001 From: jathu Date: Wed, 27 Sep 2023 18:01:19 -0700 Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy ---

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-13 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,33 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-13 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,33 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang][modules] Use file name as requested (PR #68957)

2023-10-13 Thread Jan Svoboda via cfe-commits
@@ -1384,10 +1384,10 @@ void ASTWriter::WriteControlBlock(Preprocessor , ASTContext , SmallVector ModMaps(AdditionalModMaps->begin(), AdditionalModMaps->end()); llvm::sort(ModMaps, [](FileEntryRef A, FileEntryRef B) { -

[clang] [clang][modules] Use file name as requested (PR #68957)

2023-10-13 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/68957 >From 4f60df88e1623733a64896ef332fd9a31e5b0e47 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 12 Oct 2023 21:46:47 -0700 Subject: [PATCH 1/3] [clang][modules] Use file name as requested This

[clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2023-10-13 Thread Sami Tolvanen via cfe-commits
@@ -106,9 +111,14 @@ static void emitSCSEpilogue(MachineFunction , MachineBasicBlock , CSI, [&](CalleeSavedInfo ) { return CSR.getReg() == RAReg; })) return; + const RISCVInstrInfo *TII = STI.getInstrInfo(); + if (STI.hasFeature(RISCV::FeatureStdExtZicfiss))

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

2023-10-13 Thread via cfe-commits
@@ -1224,6 +1225,9 @@ Parser::DeclGroupPtrTy Parser::ParseDeclOrFunctionDefInternal( Parser::DeclGroupPtrTy Parser::ParseDeclarationOrFunctionDefinition( ParsedAttributes , ParsedAttributes , ParsingDeclSpec *DS, AccessSpecifier AS) { + // Add an enclosing time trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

2023-10-13 Thread via cfe-commits
https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From cc5cf9500cbdbb2fdd332c7de26c0516e49594bf Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH 1/3] Add a new time trace scope variable named

[clang] [clang][modules] Use file name as requested (PR #68957)

2023-10-13 Thread Jan Svoboda via cfe-commits
@@ -1384,10 +1384,10 @@ void ASTWriter::WriteControlBlock(Preprocessor , ASTContext , SmallVector ModMaps(AdditionalModMaps->begin(), AdditionalModMaps->end()); llvm::sort(ModMaps, [](FileEntryRef A, FileEntryRef B) { -

[clang-tools-extra] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const edited https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const edited https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-10-13 Thread Konstantin Varlamov via cfe-commits
var-const wrote: > > Please make sure you add a description to your PR. This is what usually > > goes into the git log and we want those entries to be as descriptive and > > helpful for folks who read the git logs, thank you. > > Do you have any specific suggestions what should be in the

[clang-tools-extra] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-13 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 1/3] Merged __is_trivial_equality_predicate and

[clang] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-13 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 1/3] Merged __is_trivial_equality_predicate and

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread David Li via cfe-commits
@@ -202,6 +202,18 @@ static cl::opt cl::desc("Path to the profile remapping file."), cl::Hidden); +static cl::opt PGOColdFuncAttr( +"pgo-cold-func-attr", cl::init(PGOOptions::ColdFuncAttr::None), cl::Hidden,

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread David Li via cfe-commits
@@ -0,0 +1,65 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread David Li via cfe-commits
@@ -27,10 +27,12 @@ class FileSystem; struct PGOOptions { enum PGOAction { NoAction, IRInstr, IRUse, SampleUse }; enum CSPGOAction { NoCSAction, CSIRInstr, CSIRUse }; + enum class ColdFuncAttr { None, OptSize, MinSize, OptNone }; david-xl wrote: None -->

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread David Li via cfe-commits
@@ -44,6 +46,7 @@ struct PGOOptions { std::string MemoryProfile; PGOAction Action; CSPGOAction CSAction; + ColdFuncAttr ColdType; david-xl wrote: ColdType --> ColdOptType https://github.com/llvm/llvm-project/pull/69030

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread David Li via cfe-commits
@@ -27,10 +27,12 @@ class FileSystem; struct PGOOptions { enum PGOAction { NoAction, IRInstr, IRUse, SampleUse }; enum CSPGOAction { NoCSAction, CSIRInstr, CSIRUse }; + enum class ColdFuncAttr { None, OptSize, MinSize, OptNone }; david-xl wrote: Even

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-13 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,33 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-13 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,33 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

2023-10-13 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks abandoned this revision. aeubanks added a comment. reworked into https://github.com/llvm/llvm-project/pull/69030 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149800/new/ https://reviews.llvm.org/D149800

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lto Author: Arthur Eubanks (aeubanks) Changes The performance of cold functions shouldn't matter too much, so if we care about binary sizes, add an option to mark cold functions as optsize/minsize for binary size, or optnone for compile times [1].

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: still need to do measurements with this new approach, but lmk if this makes sense https://github.com/llvm/llvm-project/pull/69030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-13 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/69030 The performance of cold functions shouldn't matter too much, so if we care about binary sizes, add an option to mark cold functions as optsize/minsize for binary size, or optnone for compile times [1]. Clang

[clang-tools-extra] [bolt] Add cmake c, cxx, asm, linker flags (PR #68358)

2023-10-13 Thread via cfe-commits
https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/68358 >From 1e90114dd6ca671671d66460378de9ebf5b4dda0 Mon Sep 17 00:00:00 2001 From: AdityaK <1894981+hiradi...@users.noreply.github.com> Date: Thu, 5 Oct 2023 11:41:21 -0700 Subject: [PATCH] Add cmake

[PATCH] D151479: [clang] Use IgnoreParensSingleStep in more places

2023-10-13 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151479/new/ https://reviews.llvm.org/D151479 ___

[clang] e220398 - [MSVC, ARM64] Add __prefetch intrinsic (#67174)

2023-10-13 Thread via cfe-commits
Author: Amy Huang Date: 2023-10-13T13:34:15-07:00 New Revision: e220398cc3aea0c23752594aa3d8437c13bf4c71 URL: https://github.com/llvm/llvm-project/commit/e220398cc3aea0c23752594aa3d8437c13bf4c71 DIFF: https://github.com/llvm/llvm-project/commit/e220398cc3aea0c23752594aa3d8437c13bf4c71.diff

[clang] [MSVC, ARM64] Add __prefetch intrinsic (PR #67174)

2023-10-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Use file name as requested (PR #68957)

2023-10-13 Thread Ben Langmuir via cfe-commits
@@ -1384,10 +1384,10 @@ void ASTWriter::WriteControlBlock(Preprocessor , ASTContext , SmallVector ModMaps(AdditionalModMaps->begin(), AdditionalModMaps->end()); llvm::sort(ModMaps, [](FileEntryRef A, FileEntryRef B) { -

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -289,13 +306,38 @@ TargetPointerResultTy DeviceTy::getTargetPointer( // In addition to the mapping rules above, the close map modifier forces the // mapping of the variable to the device. if (Size) { - DP("Return HstPtrBegin " DPxMOD " Size=%" PRId64 " for

[clang-tools-extra] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -289,13 +306,38 @@ TargetPointerResultTy DeviceTy::getTargetPointer( // In addition to the mapping rules above, the close map modifier forces the // mapping of the variable to the device. if (Size) { - DP("Return HstPtrBegin " DPxMOD " Size=%" PRId64 " for

[libunwind] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -289,13 +306,38 @@ TargetPointerResultTy DeviceTy::getTargetPointer( // In addition to the mapping rules above, the close map modifier forces the // mapping of the variable to the device. if (Size) { - DP("Return HstPtrBegin " DPxMOD " Size=%" PRId64 " for

[libunwind] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -268,6 +268,23 @@ TargetPointerResultTy DeviceTy::getTargetPointer( LR.TPR.getEntry()->holdRefCountToStr().c_str(), HoldRefCountAction, (HstPtrName) ? getNameFromMapping(HstPtrName).c_str() : "unknown"); LR.TPR.TargetPointer = (void *)Ptr; + +if

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -0,0 +1,158 @@ +// RUN: %libomptarget-compilexx-generic && env HSA_XNACK=1 LIBOMPTARGET_INFO=-1 +// %libomptarget-run-generic 2>&1 | %fcheck-generic + +// UNSUPPORTED: clang-6, clang-7, clang-8, clang-9 + +// REQUIRES: amdgcn-amd-amdhsa + +#include +#include + +#pragma omp

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -268,6 +268,23 @@ TargetPointerResultTy DeviceTy::getTargetPointer( LR.TPR.getEntry()->holdRefCountToStr().c_str(), HoldRefCountAction, (HstPtrName) ? getNameFromMapping(HstPtrName).c_str() : "unknown"); LR.TPR.TargetPointer = (void *)Ptr; + +if

[libunwind] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -444,6 +486,29 @@ DeviceTy::getTgtPtrBegin(void *HstPtrBegin, int64_t Size, bool UpdateRefCount, LR.TPR.getEntry()->dynRefCountToStr().c_str(), DynRefCountAction, LR.TPR.getEntry()->holdRefCountToStr().c_str(), HoldRefCountAction);

[clang-tools-extra] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -444,6 +486,29 @@ DeviceTy::getTgtPtrBegin(void *HstPtrBegin, int64_t Size, bool UpdateRefCount, LR.TPR.getEntry()->dynRefCountToStr().c_str(), DynRefCountAction, LR.TPR.getEntry()->holdRefCountToStr().c_str(), HoldRefCountAction);

[clang-tools-extra] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread via cfe-commits
@@ -268,6 +268,23 @@ TargetPointerResultTy DeviceTy::getTargetPointer( LR.TPR.getEntry()->holdRefCountToStr().c_str(), HoldRefCountAction, (HstPtrName) ? getNameFromMapping(HstPtrName).c_str() : "unknown"); LR.TPR.TargetPointer = (void *)Ptr; + +if

[clang-tools-extra] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-13 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 1/2] Merged __is_trivial_equality_predicate and

[clang] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-13 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 1/2] Merged __is_trivial_equality_predicate and

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-13 Thread Richard Smith via cfe-commits
zygoloid wrote: > > Does this work for function-scope operator declarations? > > @zygoloid I am not sure I follow. Could you please give an example. Sure: ```c++ struct X { operator int(); }; bool f(X x) { bool operator==(X, int); return x == x; } bool g(X x) { bool operator==(X,

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread via cfe-commits
@@ -236,6 +236,7 @@ FEATURE(shadow_call_stack, FEATURE(tls, PP.getTargetInfo().isTLSSupported()) FEATURE(underlying_type, LangOpts.CPlusPlus) FEATURE(experimental_library, LangOpts.ExperimentalLibrary) +FEATURE(datasizeof, LangOpts.CPlusPlus) philnik777 wrote:

[clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2023-10-13 Thread Kito Cheng via cfe-commits
@@ -106,9 +111,14 @@ static void emitSCSEpilogue(MachineFunction , MachineBasicBlock , CSI, [&](CalleeSavedInfo ) { return CSR.getReg() == RAReg; })) return; + const RISCVInstrInfo *TII = STI.getInstrInfo(); + if (STI.hasFeature(RISCV::FeatureStdExtZicfiss))

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-13 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/68379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2023-10-13 Thread Kito Cheng via cfe-commits
@@ -106,9 +111,14 @@ static void emitSCSEpilogue(MachineFunction , MachineBasicBlock , CSI, [&](CalleeSavedInfo ) { return CSR.getReg() == RAReg; })) return; + const RISCVInstrInfo *TII = STI.getInstrInfo(); + if (STI.hasFeature(RISCV::FeatureStdExtZicfiss))

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading (PR #68986)

2023-10-13 Thread David Blaikie via cfe-commits
dwblaikie wrote: FWIW, I think we also saw, internally at Google, some significant and surprising (growth in sections, like .debug_loclists and .debug_gnu_pubnames/types) that were a bit surprising/not what I'd have expected of the original committed/reverted patch. Could you run a clang

[clang] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread Han-Chung Wang via cfe-commits
https://github.com/hanhanW closed https://github.com/llvm/llvm-project/pull/68941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-13 Thread via cfe-commits
antangelo wrote: Friendly ping https://github.com/llvm/llvm-project/pull/68379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a8896e5 - [clang-format][NFC] Annotate control statement r_braces (#68621)

2023-10-13 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-10-13T21:07:33+02:00 New Revision: a8896e57f150abf57b4e70ba1f6bfbd4c2d24ff6 URL: https://github.com/llvm/llvm-project/commit/a8896e57f150abf57b4e70ba1f6bfbd4c2d24ff6 DIFF:

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

2023-10-13 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/68621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-13 Thread Bill Wendling via cfe-commits
bwendling wrote: @nickdesaulniers and @alexfh Any comments? :-) https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -236,6 +236,7 @@ FEATURE(shadow_call_stack, FEATURE(tls, PP.getTargetInfo().isTLSSupported()) FEATURE(underlying_type, LangOpts.CPlusPlus) FEATURE(experimental_library, LangOpts.ExperimentalLibrary) +FEATURE(datasizeof, LangOpts.CPlusPlus) AaronBallman

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-13 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 updated https://github.com/llvm/llvm-project/pull/69005 >From cb4121c466a0fc357d6ca129bfdd4e7c5e2d11ee Mon Sep 17 00:00:00 2001 From: Doru Bercea Date: Wed, 16 Nov 2022 17:23:48 -0600 Subject: [PATCH 1/2] Fix declare target implementation to support enter. ---

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread via cfe-commits
@@ -1016,4 +1016,7 @@ def warn_unpacked_field def warn_unaligned_access : Warning< "field %1 within %0 is less aligned than %2 and is usually due to %0 being " "packed, which can lead to unaligned accesses">, InGroup, DefaultIgnore; + +def err_cannot_mangle_expression :

[libunwind] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

2023-10-13 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -1016,4 +1016,7 @@ def warn_unpacked_field def warn_unaligned_access : Warning< "field %1 within %0 is less aligned than %2 and is usually due to %0 being " "packed, which can lead to unaligned accesses">, InGroup, DefaultIgnore; + +def err_cannot_mangle_expression :

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread via cfe-commits
@@ -236,6 +236,7 @@ FEATURE(shadow_call_stack, FEATURE(tls, PP.getTargetInfo().isTLSSupported()) FEATURE(underlying_type, LangOpts.CPlusPlus) FEATURE(experimental_library, LangOpts.ExperimentalLibrary) +FEATURE(datasizeof, LangOpts.CPlusPlus) philnik777 wrote:

[libunwind] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread Martin Storsjö via cfe-commits
@@ -642,18 +642,8 @@ get_sanitizer_flags(SANITIZER_FLAGS "${LLVM_USE_SANITIZER}") # Link system libraries === function(cxx_link_system_libraries target) - -# In order to remove just libc++ from the link step -# we need to

[clang] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread Martin Storsjö via cfe-commits
@@ -642,18 +642,8 @@ get_sanitizer_flags(SANITIZER_FLAGS "${LLVM_USE_SANITIZER}") # Link system libraries === function(cxx_link_system_libraries target) - -# In order to remove just libc++ from the link step -# we need to

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -236,6 +236,7 @@ FEATURE(shadow_call_stack, FEATURE(tls, PP.getTargetInfo().isTLSSupported()) FEATURE(underlying_type, LangOpts.CPlusPlus) FEATURE(experimental_library, LangOpts.ExperimentalLibrary) +FEATURE(datasizeof, LangOpts.CPlusPlus) AaronBallman

[clang] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread Han-Chung Wang via cfe-commits
hanhanW wrote: thanks for the review! https://github.com/llvm/llvm-project/pull/68941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread Markus Böck via cfe-commits
https://github.com/zero9178 approved this pull request. https://github.com/llvm/llvm-project/pull/68941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread via cfe-commits
@@ -1016,4 +1016,7 @@ def warn_unpacked_field def warn_unaligned_access : Warning< "field %1 within %0 is less aligned than %2 and is usually due to %0 being " "packed, which can lead to unaligned accesses">, InGroup, DefaultIgnore; + +def err_cannot_mangle_expression :

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread via cfe-commits
@@ -236,6 +236,7 @@ FEATURE(shadow_call_stack, FEATURE(tls, PP.getTargetInfo().isTLSSupported()) FEATURE(underlying_type, LangOpts.CPlusPlus) FEATURE(experimental_library, LangOpts.ExperimentalLibrary) +FEATURE(datasizeof, LangOpts.CPlusPlus) philnik777 wrote:

[clang] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread via cfe-commits
https://github.com/peterbell10 approved this pull request. https://github.com/llvm/llvm-project/pull/68941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -415,9 +443,55 @@ class ASTNodeTraverser if (!T->isSugared()) Visit(T->getPattern()); } + void VisitAutoType(const AutoType *T) { +for (const auto : T->getTypeConstraintArguments()) + Visit(Arg); + } // FIXME: ElaboratedType, DependentNameType,

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-10-13 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, but please add a release note so users know about the improvement. https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-10-13 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2023-10-13 Thread Paul Kirth via cfe-commits
@@ -106,9 +111,14 @@ static void emitSCSEpilogue(MachineFunction , MachineBasicBlock , CSI, [&](CalleeSavedInfo ) { return CSR.getReg() == RAReg; })) return; + const RISCVInstrInfo *TII = STI.getInstrInfo(); + if (STI.hasFeature(RISCV::FeatureStdExtZicfiss))

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -1016,4 +1016,7 @@ def warn_unpacked_field def warn_unaligned_access : Warning< "field %1 within %0 is less aligned than %2 and is usually due to %0 being " "packed, which can lead to unaligned accesses">, InGroup, DefaultIgnore; + +def err_cannot_mangle_expression :

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -fsyntax-only -triple x86_64-linux-gnu -verify %s AaronBallman wrote: We should also show it's strange behavior with VLAs in C++: ``` int n = 12; __datasizeof(int[n++]); // Surprise, n is incremented, you're welcome ``` and

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I think this is a reasonable minor extension, but it should come with documentation in `clang/docs/LanguageExtensions.rst` and release note in `clang/docs/ReleaseNotes.rst` before we're done. https://github.com/llvm/llvm-project/pull/67805

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -5038,19 +5039,19 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity, Out << 'a'; MangleAlignofSizeofArg(); break; +case UETT_DataSizeOf: { + Context.getDiags().Report(diag::err_cannot_mangle_expression) + <<

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/67805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-13 Thread Aaron Ballman via cfe-commits
@@ -236,6 +236,7 @@ FEATURE(shadow_call_stack, FEATURE(tls, PP.getTargetInfo().isTLSSupported()) FEATURE(underlying_type, LangOpts.CPlusPlus) FEATURE(experimental_library, LangOpts.ExperimentalLibrary) +FEATURE(datasizeof, LangOpts.CPlusPlus) AaronBallman

[libunwind] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread via cfe-commits
@@ -108,22 +97,18 @@ if(WIN32 AND NOT MINGW) # TODO(compnerd) do we want to support an emulation layer that allows for the # use of pthread-win32 or similar libraries to emulate pthreads on Windows? set(LIBCXX_HAS_PTHREAD_LIB NO) - set(LIBCXX_HAS_M_LIB NO)

[libunwind] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread via cfe-commits
https://github.com/EricWF edited https://github.com/llvm/llvm-project/pull/68832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread via cfe-commits
@@ -108,22 +97,18 @@ if(WIN32 AND NOT MINGW) # TODO(compnerd) do we want to support an emulation layer that allows for the # use of pthread-win32 or similar libraries to emulate pthreads on Windows? set(LIBCXX_HAS_PTHREAD_LIB NO) - set(LIBCXX_HAS_M_LIB NO)

  1   2   3   4   >