[clang] [AMDGPU] Add an option to disable unsafe uses of atomic xor (PR #69229)

https://github.com/arsenm requested changes to this pull request. I am opposed to adding any additional attributes for this. I very much want to remove the current unsafe-fp-atomics attribute. It's broken in the presence of inlining as it is, and at some point acquired too many meanings.

[clang] 368a398 - Revert "[clang][Interp] Call destructors of local variables"

Author: Timm Bäder Date: 2023-10-24T06:48:29+02:00 New Revision: 368a39882d286c31975792f27e52e891e5a58ab9 URL: https://github.com/llvm/llvm-project/commit/368a39882d286c31975792f27e52e891e5a58ab9 DIFF: https://github.com/llvm/llvm-project/commit/368a39882d286c31975792f27e52e891e5a58ab9.diff

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaaece65a80f: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc. (authored by tbaeder). Changed prior to commit:

[clang] aaaece6 - [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

Author: Timm Bäder Date: 2023-10-24T06:48:09+02:00 New Revision: aaaece65a80fb6e57cdd9a439a7ff8f1e41e14fe URL: https://github.com/llvm/llvm-project/commit/aaaece65a80fb6e57cdd9a439a7ff8f1e41e14fe DIFF: https://github.com/llvm/llvm-project/commit/aaaece65a80fb6e57cdd9a439a7ff8f1e41e14fe.diff

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3671a69470f3: [clang][Interp] Call destructors of local variables (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3671a69 - [clang][Interp] Call destructors of local variables

Author: Timm Bäder Date: 2023-10-24T06:27:10+02:00 New Revision: 3671a69470f3fa708926a9e5ce579751c6b51dac URL: https://github.com/llvm/llvm-project/commit/3671a69470f3fa708926a9e5ce579751c6b51dac DIFF: https://github.com/llvm/llvm-project/commit/3671a69470f3fa708926a9e5ce579751c6b51dac.diff

[clang] [clang][Diagnostics] Provide source range to constexpr function diags (PR #69721)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/69721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bb7c515 - [clang][Diagnostics] Provide source range to constexpr function diags (#69721)

Author: Timm Baeder Date: 2023-10-24T06:14:27+02:00 New Revision: bb7c515ba1a791e5ec7c83bc0dc4d6359736065a URL: https://github.com/llvm/llvm-project/commit/bb7c515ba1a791e5ec7c83bc0dc4d6359736065a DIFF: https://github.com/llvm/llvm-project/commit/bb7c515ba1a791e5ec7c83bc0dc4d6359736065a.diff

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

zeux wrote: Ping https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

@@ -7997,14 +7997,26 @@ enum SpecialRegisterAccessKind { static Value *EmitAMDGCNBallotForExec(CodeGenFunction , const CallExpr *E, llvm::Type *RegisterType, - llvm::Type *ValueType) { +

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

@@ -7997,14 +7997,26 @@ enum SpecialRegisterAccessKind { static Value *EmitAMDGCNBallotForExec(CodeGenFunction , const CallExpr *E, llvm::Type *RegisterType, - llvm::Type *ValueType) { +

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

@@ -526,7 +526,9 @@ void test_read_exec_lo(global uint* out) { // CHECK: declare i32 @llvm.amdgcn.ballot.i32(i1) #[[$NOUNWIND_READONLY:[0-9]+]] // CHECK-LABEL: @test_read_exec_hi( -// CHECK: call i32 @llvm.amdgcn.ballot.i32(i1 true) +// CHECK: call i64

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

https://github.com/arsenm requested changes to this pull request. https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

@@ -203,6 +214,7 @@ template <> struct DenseMapInfo { Val.Driver, Val.StandardIncludes, Val.StandardCXXIncludes, +Val.Stdlib, cjc25 wrote: Done, and resorted these to match the order in `DriverArgs` definition so it'll be

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

https://github.com/cjc25 updated https://github.com/llvm/llvm-project/pull/69283 >From f9986bfc0a1202ade8e641e7a1b1e73576070a73 Mon Sep 17 00:00:00 2001 From: Chris Carlon Date: Sat, 14 Oct 2023 15:17:44 -0400 Subject: [PATCH 1/2] `clangd`: support `-stdlib=` flags from

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[PATCH] D108905: [ItaniumCXXABI] Add -fassume-nothrow-exception-dtor to assume that an exception object' destructor is nothrow

MaskRay added a comment. In D108905#4654561 , @smeenai wrote: > This looks great to me, thanks. @rjmccall should sign off on it though. @rjmccall Are you happy with this opt-in option? In D108905#4654626 ,

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

ChuanqiXu9 wrote: @zygoloid @vgvassilev ping~ Personally I feel like the change itself should be safe. (The test for modules is really sensitive about the changes in Serializer) https://github.com/llvm/llvm-project/pull/69287 ___ cfe-commits mailing

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

https://github.com/ChuanqiXu9 commented: Besides deps scanning, have you tried to enable these option to compile with clang modules? I mean, if it is safe to enable such options at compilation times, it looks a valid optimization for C++20 modules too. If it is not safe to do so, I think we

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/69224 >From 07749e92c55cb4dfd01e81c9c8413b77c915aa42 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 16 Oct 2023 22:50:08 +0800 Subject: [PATCH 1/2] [clang][Sema] Avoid non-empty unexpanded pack assertion for

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

ChuanqiXu9 wrote: Yeah, this is the reason why I put the change in `C++ Specific Potentially Breaking Changes` section. I think specify `-fdelayed-template-parsing` explicitly may be a good solution/workaroud. https://github.com/llvm/llvm-project/pull/69431

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/68177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4a540ce - [clangd] Adapt Inlay Hint support for Deducing This (#68177)

Author: Younan Zhang Date: 2023-10-24T09:51:43+08:00 New Revision: 4a540ceed454f9ef364838469ebc94252dba152e URL: https://github.com/llvm/llvm-project/commit/4a540ceed454f9ef364838469ebc94252dba152e DIFF: https://github.com/llvm/llvm-project/commit/4a540ceed454f9ef364838469ebc94252dba152e.diff

[clang] -fstack-usage: fix filename for functions in an included file (PR #69896)

https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/69896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d5b0ad6 - -fstack-usage: fix filename for functions in an included file (#69896)

Author: Fangrui Song Date: 2023-10-23T18:26:08-07:00 New Revision: d5b0ad632657a598f99bdab64a178015c6ea4b11 URL: https://github.com/llvm/llvm-project/commit/d5b0ad632657a598f99bdab64a178015c6ea4b11 DIFF: https://github.com/llvm/llvm-project/commit/d5b0ad632657a598f99bdab64a178015c6ea4b11.diff

[clang] -fstack-usage: fix filename for functions in an included file (PR #69896)

MaskRay wrote: > Thanks for the MR, @MaskRay! The patch LGTM. Can you confirm that the failing > checks are not related to this patch? Thanks for review. I confirm it is an unrelated `clang-format` issue (`grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs`) caused by another patch

[clang] [Driver] Ignore non-clang pch files when -include a.h probes a.h.gch (PR #69204)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/69204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4c8f2b0 - [clang][NFC] Remove trailing whitespace in release note

Author: Louis Dionne Date: 2023-10-23T17:40:20-07:00 New Revision: 4c8f2b01470d38f0757f2404dbb0f0335ac331db URL: https://github.com/llvm/llvm-project/commit/4c8f2b01470d38f0757f2404dbb0f0335ac331db DIFF: https://github.com/llvm/llvm-project/commit/4c8f2b01470d38f0757f2404dbb0f0335ac331db.diff

[clang-tools-extra] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/68502 >From 5b3b1bbb5b263bc5711adde031d85b1461ccbab6 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Sat, 7 Oct 2023 13:48:32 +0800 Subject: [PATCH 1/5] [InstCombine] Refactor matchFunnelShift to allow more pattern

[clang] Fix WebKit static analyzers to support ref and deref methods to be defined on different classes. (PR #69985)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/69985 >From 1832737f3e198386d1ebdeccd7d0ca55ef6094c0 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 23 Oct 2023 16:38:10 -0700 Subject: [PATCH] Fix WebKit static analyzers to support ref and deref methods to be

[clang] Fix WebKit static analyzers to support ref and deref methods to be defined on different classes. (PR #69985)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e45356910f826194003e9bd62a2406971b2fe3f3 d8236358e137967dbbd63606b7d43983709597e8 --

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

rymiel wrote: I didn't expect you to not want to be credited, but I'll respect your opinion! GitHub adds co-ownership automatically if using the web ui to commit a suggestion (which is what happened in that other PR you pinged me in), but in this case I did add it manually :)

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

rniwa wrote: I couldn't take over this PR so I made a new PR at https://github.com/llvm/llvm-project/pull/69985. https://github.com/llvm/llvm-project/pull/68170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix WebKit static analyzers to support ref and deref methods to be defined on different classes. (PR #69985)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/69985 None >From d8236358e137967dbbd63606b7d43983709597e8 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 23 Oct 2023 16:38:10 -0700 Subject: [PATCH] Fix WebKit static analyzers to support ref and deref methods

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

owenca wrote: @rymiel, thanks for the co-authorship, but I really didn't deserve it here! https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

owenpan added a comment. @jaredgrubb, a few quick comments: - Please undo the (unrelated) changes to `clang-formatted-files.txt`. - Add a warning to the option in `Format.h`. See here for an example. - Rerun

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

@@ -2944,6 +2944,10 @@ def fno_modules_validate_textual_header_includes : MarshallingInfoNegativeFlag>, HelpText<"Do not enforce -fmodules-decluse and private header restrictions for textual headers. " "This flag will be removed in a future Clang release.">;

[clang] 278d557 - Fix test clang/test/Driver/cl-offload.cu

Author: Yaxun (Sam) Liu Date: 2023-10-23T18:21:36-04:00 New Revision: 278d5575643f27427175e647dab98de816953943 URL: https://github.com/llvm/llvm-project/commit/278d5575643f27427175e647dab98de816953943 DIFF:

[clang] Let clang-cl support CUDA/HIP (PR #68921)

yxsamliu wrote: [AMD Official Use Only - General] Sorry I missed this failure. Will fix it now. Sam From: Rainer Orth ***@***.***> Sent: Monday, October 23, 2023 5:45 PM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***> Subject: Re:

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

@@ -2944,6 +2944,10 @@ def fno_modules_validate_textual_header_includes : MarshallingInfoNegativeFlag>, HelpText<"Do not enforce -fmodules-decluse and private header restrictions for textual headers. " "This flag will be removed in a future Clang release.">;

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

owenca wrote: @rymiel, please remove me from the authorship. I suggested code in numerous reviews and never expected to get co-authorship just because the authors took my suggestions.  https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

@@ -1212,9 +1212,12 @@ void ASTWriter::writeUnhashedControlBlock(Preprocessor , Record.clear(); } + const auto = PP.getHeaderSearchInfo().getHeaderSearchOpts(); + // Diagnostic options. const auto = Context.getDiagnostics(); const DiagnosticOptions =

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

@@ -2944,6 +2944,10 @@ def fno_modules_validate_textual_header_includes : MarshallingInfoNegativeFlag>, HelpText<"Do not enforce -fmodules-decluse and private header restrictions for textual headers. " "This flag will be removed in a future Clang release.">;

[clang-tools-extra] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

aeubanks wrote: my worry about baking in the resource dir for the bazel build is that it'll be tied to the bazel build directory structure implementation details, so it's likely that you can't copy the binaries around and create a toolchain out of it. if bazel users don't care about this,

[clang] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

aeubanks wrote: my worry about baking in the resource dir for the bazel build is that it'll be tied to the bazel build directory structure implementation details, so it's likely that you can't copy the binaries around and create a toolchain out of it. if bazel users don't care about this,

[clang] Revert [clang] Handle templated operators with reversed arguments and [STLExtras] Undo C++20 hack (PR #69937)

usx95 wrote: Apologies. I have reverted the missed tests in a87638596a78ea42a39e9c4ac13687160c0d726d The build bots should be fine now. https://github.com/llvm/llvm-project/pull/69937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Revert tests missed in b997ff4 (PR #69974)

https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/69974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a876385 - Revert tests missed in b997ff41c11cc69cfcb6c8a3ed39ed47229cf891

Author: Utkarsh Saxena Date: 2023-10-23T23:53:35+02:00 New Revision: a87638596a78ea42a39e9c4ac13687160c0d726d URL: https://github.com/llvm/llvm-project/commit/a87638596a78ea42a39e9c4ac13687160c0d726d DIFF:

[clang] Revert tests missed in b997ff4 (PR #69974)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69974 >From b100ca6f219fda1fed5b92aba8471aa9a6ef8906 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 23 Oct 2023 18:02:35 +0200 Subject: [PATCH 1/4] Revert "[STLExtras] Undo C++20 hack" This reverts commit

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/69975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

rnk wrote: I think option 1 isn't really a permanent solution. We have lots of clang tools that need to find the resource directory, and it should happen automatically. For option 2, we'd have to reimplement that for every other clang tool that needs to find resources, like LLD as well.

[clang] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

rnk wrote: I think option 1 isn't really a permanent solution. We have lots of clang tools that need to find the resource directory, and it should happen automatically. For option 2, we'd have to reimplement that for every other clang tool that needs to find resources, like LLD as well.

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes Deserialization of the `DIAGNOSTIC_OPTIONS` and `HEADER_SEARCH_PATHS` records is slow and done for every transitively loaded PCM. Deserialization of these records cannot be skipped, because the words

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/69975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/69975 Deserialization of the `DIAGNOSTIC_OPTIONS` and `HEADER_SEARCH_PATHS` records is slow and done for every transitively loaded PCM. These records cannot be skipped, because the words are VBR6-encoded and we

[clang] Revert tests missed in b997ff4 (PR #69974)

https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/69974 None >From b100ca6f219fda1fed5b92aba8471aa9a6ef8906 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 23 Oct 2023 18:02:35 +0200 Subject: [PATCH 1/3] Revert "[STLExtras] Undo C++20 hack" This reverts

[clang-tools-extra] [clang-format] Don't break between string literal operands of << (PR #69871)

owenca wrote: > I think adding the possibility of breaking '<<' is a good idea if it's > optional, what do u think? +1, but see also https://github.com/llvm/llvm-project/pull/69859#issuecomment-1776064714. https://github.com/llvm/llvm-project/pull/69871

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

owenca wrote: > I think adding the possibility of breaking '<<' is a good idea if it's > optional, what do u think? +1, but see also https://github.com/llvm/llvm-project/pull/69859#issuecomment-1776064714. https://github.com/llvm/llvm-project/pull/69871

[clang] Let clang-cl support CUDA/HIP (PR #68921)

rorth wrote: This patch also broke the [Solaris/amd64 buildbot](https://lab.llvm.org/staging/#/builders/8/builds/484). I suspect this happens because that one is configured with `-DLLVM_TARGETS_TO_BUILD=X86`, thus lacking cuda support. In fact, when manually building with support for all

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

owenca wrote: > 2th solution is: Add new option that allowing specific behaviour, such as > "BreakAfterStreamOperator" or "BreakAfterLessLessOperator" with options [ > Leave | NoFitLine | All ]. We need a comprehensive solution to cover the following: - when to break - before or after the

[clang-tools-extra] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

AntonRydahl wrote: @ldionne do you think it looks right at this point?  https://github.com/llvm/llvm-project/pull/68642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

AntonRydahl wrote: @ldionne do you think it looks right at this point?  https://github.com/llvm/llvm-project/pull/68642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

aeubanks wrote: I think there are two approaches to this problem 1) point `-resource-dir` to the directory where the headers are, e.g. `clang-tidy --extra-arg=-resource-dir=path/to/include` 2) mirror the CMake binary/include layout (this patch) issues with 1: extra argument to pass, have to

[clang] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

aeubanks wrote: I think there are two approaches to this problem 1) point `-resource-dir` to the directory where the headers are, e.g. `clang-tidy --extra-arg=-resource-dir=path/to/include` 2) mirror the CMake binary/include layout (this patch) issues with 1: extra argument to pass, have to

[clang] [clang][AST] Fix printing `TagDecl`s. (PR #69971)

zygoloid wrote: It looks like this regressed in https://github.com/llvm/llvm-project/commit/9359b8fe5d944c8355ea49ba949d481fe080cec9 -- prior to that, we did check whether the tag declaration in the group was a definition before deciding whether to include it as part of the group.

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

@@ -12,27 +12,96 @@ #ifndef LLVM_ANALYSIS_INDIRECTCALLVISITOR_H #define LLVM_ANALYSIS_INDIRECTCALLVISITOR_H +#include "llvm/ADT/SetVector.h" #include "llvm/IR/InstVisitor.h" #include namespace llvm { -// Visitor class that finds all indirect call. +// Visitor class that

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

@@ -12,27 +12,96 @@ #ifndef LLVM_ANALYSIS_INDIRECTCALLVISITOR_H #define LLVM_ANALYSIS_INDIRECTCALLVISITOR_H +#include "llvm/ADT/SetVector.h" #include "llvm/IR/InstVisitor.h" #include namespace llvm { -// Visitor class that finds all indirect call. +// Visitor class that

[clang] [MLIR][scf.parallel] Don't allow a tile size of 0 (PR #68762)

https://github.com/justinfargnoli closed https://github.com/llvm/llvm-project/pull/68762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix printing `TagDecl`s. (PR #69971)

zygoloid wrote: I think this might be working around the issue rather than fixing it. It looks to me like the bug is in `Decl::printGroup`: https://github.com/llvm/llvm-project/blob/f4023d4d5d6a6f35ef2315f1b1ce7dd35f24e901/clang/lib/AST/DeclPrinter.cpp#L223 We are printing the tag

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

owenca wrote: Please add unit tests in `clang/unittests/Format/`. https://github.com/llvm/llvm-project/pull/69859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang] Support fixed point types in C++ (#67750)" (PR #69963)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/69963 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 1/2] Revert "[clang] Support fixed point types in C++ (#67750)"

[clang] [clang][AST] Fix printing `TagDecl`s. (PR #69971)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (isuckatcs) Changes https://github.com/llvm/llvm-project/commit/ae7c9443559ac420a6f401b7a24eb2fcea8ba3e8 `[AST] Fix printing tag decl groups in decl contexts` introduced a change that made sure, that implicitly created `TagDecl`s

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/67700 >From 2fa183da3991c0bc4da6163609331d198f4a37af Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Tue, 26 Sep 2023 19:48:18 -0500 Subject: [PATCH 1/2] [HLSL] Support vector swizzles on scalars HLSL supports

[clang] [clang][AST] Fix printing `TagDecl`s. (PR #69971)

https://github.com/isuckatcs created https://github.com/llvm/llvm-project/pull/69971 https://github.com/llvm/llvm-project/commit/ae7c9443559ac420a6f401b7a24eb2fcea8ba3e8 `[AST] Fix printing tag decl groups in decl contexts` introduced a change that made sure, that implicitly created

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

@@ -0,0 +1,78 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library -x hlsl \ +// RUN: -finclude-default-header -ast-dump %s | FileCheck %s + + +// CHECK: ExtVectorElementExpr {{.*}} 'int __attribute__((ext_vector_type(2)))' xx +// CHECK-NEXT: ImplicitCastExpr {{.*}}

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

@@ -2267,6 +2268,14 @@ void Clang::AddSystemZTargetArgs(const ArgList , CmdArgs.push_back("-mfloat-abi"); CmdArgs.push_back("soft"); } + + if (Triple.isOSzOS()) { +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back( +

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/68926 >From 5ea8bea2bdf345e2baee07e0a94ac40bd0f109c4 Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Thu, 12 Oct 2023 16:56:27 -0400 Subject: [PATCH 1/8] This change adds support for the PPA2 section in zOS ---

[clang] [clang] Support fixed point types in C++ (PR #67750)

PiJoules wrote: > This is introducing an extension from C into C++ -- was there an RFC or > something discussed about whether we wish to support this in C++? The original request for this I believe was on one of my earlier patches in 2018 for adding fixed point support in clang, but limiting

[clang] SwiftCallingConv: Fix the splitVectorEntry function (PR #69953)

aschwaighofer wrote: The failures are not related to this PR / pre-existing. `clang/docs/ReleaseNotes.rst:` is not touched by this PR. ``` + echo '*** Checking for trailing whitespace left in Clang source files ***' --   | *** Checking for trailing whitespace left in Clang source files ***   |

[clang] [Profile] Refactor profile correlation. (PR #69656)

@@ -24,15 +24,37 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt +DebugInfoCorrelate("profile-correlate=debug-info",

[clang] Revert "[clang] Support fixed point types in C++ (#67750)" (PR #69963)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 853fb0a8ac053a31fef3405d1d4dd545ad9a6167 340e3777509f70b5b300adcb181261e84247cf1a --

[clang] [flang][driver] support -dumpversion and -dumpmachine (PR #68896)

https://github.com/banach-space approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/68896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][DebugInfo] Clang generates an extra spurious unnamed 'dbg.declare' (PR #69681)

https://github.com/adrian-prantl approved this pull request. Aside from other open comments the spirit of the change LGTM. https://github.com/llvm/llvm-project/pull/69681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Revert "[clang] Support fixed point types in C++ (#67750)" (PR #69963)

https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/69963 This reverts commit a3a7d6318027bb86e6614c022e77e0bd81aef6dc. When compiling with MSVC2022 in C++32 mode this is giving an error. Compiling this simple test case: t1.cpp: with -std=c++23 will give the

[clang] [clang-format] Don't alter SpacesRequiredBefore of finalized tokens (PR #69897)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/69897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 853fb0a - [clang-format] Don't alter SpacesRequiredBefore of finalized tokens (#69897)

Author: Owen Pan Date: 2023-10-23T13:12:51-07:00 New Revision: 853fb0a8ac053a31fef3405d1d4dd545ad9a6167 URL: https://github.com/llvm/llvm-project/commit/853fb0a8ac053a31fef3405d1d4dd545ad9a6167 DIFF: https://github.com/llvm/llvm-project/commit/853fb0a8ac053a31fef3405d1d4dd545ad9a6167.diff

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang] Revert [clang] Handle templated operators with reversed arguments and [STLExtras] Undo C++20 hack (PR #69937)

dyung wrote: This revert seems to have broken quite a few build bots with the test failure @nico mentioned. Can you please look into this so we can get the bots green again? - https://lab.llvm.org/buildbot/#/builders/164/builds/45362 - https://lab.llvm.org/buildbot/#/builders/188/builds/36986

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

ZequanWu wrote: > > > > This should works with PGO when value profiling is disabled > > > > > > > > > Is this not compatible with value profiling? or just not implemented yet? > > > > > > Not compatible, but this feature is mainly for coverage testing. > > Ok, not a big deal as it's

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

@@ -60,10 +60,7 @@ using namespace llvm; #define DEBUG_TYPE "instrprof" namespace llvm { -cl::opt -DebugInfoCorrelate("debug-info-correlate", - cl::desc("Use debug info to correlate profiles."), - cl::init(false));

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

teresajohnson wrote: @MaskRay @nickdesaulniers since they authored and reviewed [e018cbf7208](https://github.com/llvm/llvm-project/commit/e018cbf7208b3d34f18997ddee84c66cee32fb1b), respectively https://github.com/llvm/llvm-project/pull/65512 ___

  1   2   3   4   >