[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Ellis Hoag via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang-tools-extra] 20d2102 - [clang-tidy] Ignore deleted functions in cppcoreguidelines-rvalue-reference-param-not-moved (#69514)

2023-10-25 Thread via cfe-commits
Author: Piotr Zegar Date: 2023-10-25T20:41:19+02:00 New Revision: 20d210285b2ab461bbd87a9022503a58592e8fe8 URL: https://github.com/llvm/llvm-project/commit/20d210285b2ab461bbd87a9022503a58592e8fe8 DIFF: https://github.com/llvm/llvm-project/commit/20d210285b2ab461bbd87a9022503a58592e8fe8.diff

[clang-tools-extra] [clang-tidy] Ignore deleted functions in cppcoreguidelines-rvalue-reference-param-not-moved (PR #69514)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/69514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/69501 >From ada6ee07f310ce482ef0cb0339b25db6e31d8c13 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Wed, 18 Oct 2023 19:10:32 + Subject: [PATCH 1/3] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast

[clang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/70234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Jessica Clarke (jrtc27) Changes These are an artifact of how types are structured but serve little purpose, merely showing that the type is sugared in some way. For example, ElaboratedType's existence means struct S gets printed as 'struct

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Connor Sughrue via cfe-commits
@@ -0,0 +1,211 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8b322895207c34b434698954dc67404e0bbf8d8e f2526f9f4dca9d0cd8e8b91d29b0ac9d177a8dc8 --

[clang] [AArch64] Stack probing for function prologues (PR #66524)

2023-10-25 Thread Eli Friedman via cfe-commits
@@ -1076,6 +1076,16 @@ void CodeGenModule::Release() { "sign-return-address-with-bkey", 1); } + if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::aarch64_be) { +auto *InlineAsm = llvm::MDString::get(TheModule.getContext(),

[clang] [AArch64] Stack probing for function prologues (PR #66524)

2023-10-25 Thread Eli Friedman via cfe-commits
@@ -1757,46 +1826,55 @@ void AArch64FrameLowering::emitPrologue(MachineFunction , } } - StackOffset AllocateBefore = SVEStackSize, AllocateAfter = {}; + StackOffset SVECalleeSavedSize = {}, SVELocalsSize = SVEStackSize; MachineBasicBlock::iterator CalleeSavesBegin

[clang] [AArch64] Stack probing for function prologues (PR #66524)

2023-10-25 Thread Eli Friedman via cfe-commits
@@ -1757,46 +1826,55 @@ void AArch64FrameLowering::emitPrologue(MachineFunction , } } - StackOffset AllocateBefore = SVEStackSize, AllocateAfter = {}; + StackOffset SVECalleeSavedSize = {}, SVELocalsSize = SVEStackSize; MachineBasicBlock::iterator CalleeSavesBegin

[clang] [AArch64] Stack probing for function prologues (PR #66524)

2023-10-25 Thread Eli Friedman via cfe-commits
@@ -97,14 +97,45 @@ AArch64FunctionInfo::AArch64FunctionInfo(const Function , if (const auto *BTE = mdconst::extract_or_null( F.getParent()->getModuleFlag("branch-target-enforcement"))) BranchTargetEnforcement = BTE->getZExtValue(); -return; + } else

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-10-25 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: Rebased to verify CI still passes before merging (thanks Aaron for the reverse ping) https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libclang/python] Add missing concept declaration CursorKind (PR #69125)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nick Renieris (VelocityRa) Changes Maps to [`CXCursor_ConceptDecl`](https://github.com/llvm/llvm-project/blob/ee8524087c78a673fcf5486ded69ee597a85e0f1/clang/include/clang-c/Index.h#L2716), added in

[clang] [libclang/python] Add missing concept declaration CursorKind (PR #69125)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/69125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8b32289 - [libclang/python] Add missing concept declaration CursorKind (#69125)

2023-10-25 Thread via cfe-commits
Author: Nick Renieris Date: 2023-10-25T14:25:08-04:00 New Revision: 8b322895207c34b434698954dc67404e0bbf8d8e URL: https://github.com/llvm/llvm-project/commit/8b322895207c34b434698954dc67404e0bbf8d8e DIFF: https://github.com/llvm/llvm-project/commit/8b322895207c34b434698954dc67404e0bbf8d8e.diff

[clang] [libclang/python] Add missing concept declaration CursorKind (PR #69125)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Sorry about the delay on review, but the changes here LGTM! https://github.com/llvm/llvm-project/pull/69125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

2023-10-25 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: > yes, issue with breaking after << is gone. I want to get your point about > functionality clang-format and implementing new option such as > "BreakAfterStreamOperator". As i can see, @HazardyKnusperkeks you agree with > "owenca" point? > > May be i can do

[clang] [clang][Interp] Handle unknown-size arrays better (PR #68868)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/68868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/69656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
@@ -7688,7 +7688,7 @@ bool Sema::CheckNonDependentConversions( QualType ParamType = ParamTypes[I + Offset]; if (!ParamType->isDependentType()) { unsigned ConvIdx = PO == OverloadCandidateParamOrder::Reversed - ? 0 +

[clang-tools-extra] [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (PR #70230)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/70230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (PR #70230)

2023-10-25 Thread Piotr Zegar via cfe-commits
@@ -71,6 +72,10 @@ void UnusedUsingDeclsCheck::registerMatchers(MatchFinder *Finder) { templateArgument().bind("used", this); Finder->addMatcher(userDefinedLiteral().bind("used"), this); + Finder->addMatcher( +

[clang] Bfi precision (PR #66285)

2023-10-25 Thread David Li via cfe-commits
david-xl wrote: Yes -- the revert can wait until more data is available. I agree that it should help performance in theory. https://github.com/llvm/llvm-project/pull/66285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK closed https://github.com/llvm/llvm-project/pull/69649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Bfi precision (PR #66285)

2023-10-25 Thread David Li via cfe-commits
david-xl wrote: Yes -- the revert can wait until more data is available. I agree that it should help performance in theory. https://github.com/llvm/llvm-project/pull/66285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK closed https://github.com/llvm/llvm-project/pull/69649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7e34ee5 - Update stdckdint.h and make it available in pre-C23 modes. (#69649)

2023-10-25 Thread via cfe-commits
Author: ZijunZhaoCCK Date: 2023-10-25T11:04:31-07:00 New Revision: 7e34ee5291b935a1e37cd1b132552187d5c784d0 URL: https://github.com/llvm/llvm-project/commit/7e34ee5291b935a1e37cd1b132552187d5c784d0 DIFF: https://github.com/llvm/llvm-project/commit/7e34ee5291b935a1e37cd1b132552187d5c784d0.diff

[clang-tools-extra] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/69649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/69649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bfi precision (PR #66285)

2023-10-25 Thread via cfe-commits
WenleiHe wrote: > This is concerning. Can this be reverted for now and we can help with some > internal performance testing. @xur-llvm Internally, with this change, on a few large workloads, we saw ~0.2-0.5% performance improvements, all with 2-3% .text size reduction at the same time. Our

[clang-tools-extra] Bfi precision (PR #66285)

2023-10-25 Thread via cfe-commits
WenleiHe wrote: > This is concerning. Can this be reverted for now and we can help with some > internal performance testing. @xur-llvm Internally, with this change, on a few large workloads, we saw ~0.2-0.5% performance improvements, all with 2-3% .text size reduction at the same time. Our

[clang] Bfi precision (PR #66285)

2023-10-25 Thread Matthias Braun via cfe-commits
MatzeB wrote: Oh so this isn't even a PGO enabled build, interesting... https://github.com/llvm/llvm-project/pull/66285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Bfi precision (PR #66285)

2023-10-25 Thread Matthias Braun via cfe-commits
MatzeB wrote: Oh so this isn't even a PGO enabled build, interesting... https://github.com/llvm/llvm-project/pull/66285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/68820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/68820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bfi precision (PR #66285)

2023-10-25 Thread Nikita Popov via cfe-commits
nikic wrote: This is a standard release build. The exact cmake config is https://gist.github.com/nikic/1bf97b5b6aade298b87f41cd13bf37d5 where the stage1 build has the same configuration but is built with gcc. I'm testing CTMark, but the impact is quite consistent across the board, so anything

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68820 >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH 1/5] Add support for -fcx-limited-range and #pragma

[clang] [OpenACC] (PR #70234)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes Initial commits to support OpenACC. This patchset: adds a clang-command line argument '-fopenacc', and starts to define _OPENACC, albeit to '1' instead of the standardized value (since we don't properly

[clang] [OpenACC] (PR #70234)

2023-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/70234 Initial commits to support OpenACC. This patchset: adds a clang-command line argument '-fopenacc', and starts to define _OPENACC, albeit to '1' instead of the standardized value (since we don't properly

[clang] Emit unsupported directive error (PR #70233)

2023-10-25 Thread Raymond Chang via cfe-commits
https://github.com/rkchang edited https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Emit unsupported directive error (PR #70233)

2023-10-25 Thread Raymond Chang via cfe-commits
https://github.com/rkchang edited https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Emit unsupported directive error (PR #70233)

2023-10-25 Thread Raymond Chang via cfe-commits
https://github.com/rkchang edited https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Emit unsupported directive error (PR #70233)

2023-10-25 Thread Raymond Chang via cfe-commits
https://github.com/rkchang created https://github.com/llvm/llvm-project/pull/70233 Hello! This PR addresses #63871. Clang should no longer crash and instead emits an error message. @shiltian is this what you had in mind for an error message? I think I followed everything in [1] but I did

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread Craig Topper via cfe-commits
@@ -936,7 +936,9 @@ def : ReadAdvance; def : ReadAdvance; def : ReadAdvance; def : ReadAdvance; +def : ReadAdvance; topperc wrote: Please make FMA16 consistent https://github.com/llvm/llvm-project/pull/70232 ___

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread Michael Maitland via cfe-commits
@@ -78,7 +78,7 @@ def FSD : FPStore_r<0b011, "fsd", FPR64, WriteFST64>; } // Predicates = [HasStdExtD] foreach Ext = DExts in { - let SchedRW = [WriteFMA64, ReadFMA64, ReadFMA64, ReadFMA64] in { + let SchedRW = [WriteFMA64, ReadFMA64, ReadFMA64, ReadFMA64Addend] in {

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread Michael Maitland via cfe-commits
@@ -302,7 +302,7 @@ def FSW : FPStore_r<0b010, "fsw", FPR32, WriteFST32>; } // Predicates = [HasStdExtF] foreach Ext = FExts in { - let SchedRW = [WriteFMA32, ReadFMA32, ReadFMA32, ReadFMA32] in { + let SchedRW = [WriteFMA32, ReadFMA32, ReadFMA32, ReadFMA32Addend] in {

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
Carlos =?utf-8?q?G=C3=A1lvez?= Message-ID: In-Reply-To: shafik wrote: Thank you for doing this work. https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Yingwei Zheng (dtcxzyw) Changes [XiangShan](https://github.com/OpenXiangShan/XiangShan) is an open-source high-performance RISC-V processor. This PR adds the schedule model for XiangShan-NanHu, the 2nd Gen core of the XiangShan

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/70232 [XiangShan](https://github.com/OpenXiangShan/XiangShan) is an open-source high-performance RISC-V processor. This PR adds the schedule model for XiangShan-NanHu, the 2nd Gen core of the XiangShan processor

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread David Li via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang-tools-extra] [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (PR #70230)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes `ElaboratedType` including tag keywords and any nested-name-specifiers. We should ignore nested-name-specifiers case but consider tag keywords case for `misc-unused-using-decls` check Fixes: #69714

[clang-tools-extra] [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (PR #70230)

2023-10-25 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/70230 `ElaboratedType` including tag keywords and any nested-name-specifiers. We should ignore nested-name-specifiers case but consider tag keywords case for `misc-unused-using-decls` check Fixes: #69714 >From

[clang] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/70150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/70150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b8e0693 - [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (#70150)

2023-10-25 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2023-10-25T10:18:40-07:00 New Revision: b8e06933a2f4a647046f122a8e4a636c0e9267b7 URL: https://github.com/llvm/llvm-project/commit/b8e06933a2f4a647046f122a8e4a636c0e9267b7 DIFF:

[clang] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
shafik wrote: The clang-format error is a false positive. https://github.com/llvm/llvm-project/pull/70150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
shafik wrote: The clang-format error is a false positive. https://github.com/llvm/llvm-project/pull/70150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Bfi precision (PR #66285)

2023-10-25 Thread Matthias Braun via cfe-commits
MatzeB wrote: The internal services I tried here tended to slightly improve or stay neutral. We can revert, but could you please share some details on how your clang built / tested so I have a chance to address things and bring these changes back?

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-25 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. Thanks for confirming, Ben! I don't have other concerns, this should be good to land. https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread via cfe-commits
@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, elizabethandrews wrote: Yes I did.

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-25 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: Thanks for your patience, I should have looked at this sooner. The change to our downstream test looks expected; the `` buffer changed ```diff -#import "/^tc/lib/clang/18/include/stdbool.h" +#import "stdbool.h" ``` But the actual resolution of which header is used is

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang-tools-extra] Bfi precision (PR #66285)

2023-10-25 Thread David Li via cfe-commits
david-xl wrote: This is concerning. Can this be reverted for now and we can help with some internal performance testing. @xur-llvm https://github.com/llvm/llvm-project/pull/66285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread Tom Honermann via cfe-commits
@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, tahonermann wrote: It looks like a

[clang] Bfi precision (PR #66285)

2023-10-25 Thread Nikita Popov via cfe-commits
nikic wrote: It looks like this has made clang 0.7% slower (in the sense that the clang stage2 binary is optimized worse -- there is no negative impact on stage1). The binary is also 0.7% larger. It looks like this change has significant impact on inlining heuristics. Not really sure what to

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread David Li via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang] [clang][ASTImporter] Fix import of SubstTemplateTypeParmType in return type of function. (PR #69724)

2023-10-25 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/69724 From 2bfad6f0fbb7a5757318c77ef76335986d23ab83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 19 Oct 2023 16:27:24 +0200 Subject: [PATCH 1/2] [clang][ASTImporter] Fix import of

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread via cfe-commits
https://github.com/elizabethandrews updated https://github.com/llvm/llvm-project/pull/70224 >From 21ecdfb97ff2e8152cec7b4fa3c2fd8913244889 Mon Sep 17 00:00:00 2001 From: Elizabeth Andrews Date: Wed, 25 Oct 2023 09:17:09 -0700 Subject: [PATCH 1/2] [Clang] Fix a crash when using ast-dump=json

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread via cfe-commits
https://github.com/elizabethandrews created https://github.com/llvm/llvm-project/pull/70224 CXXDeductionGuideDecl inherits from FunctionDecl. For FunctionDecls, the JSONVisitor includes a call to visit NamedDecl in order to provide mangled names in the dump. This did not correctly exclude

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/70152 >From 3cbae09c1bf66c4dc20e4e40d1051cb34497957e Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Tue, 24 Oct 2023 18:36:53 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate old syntax of linear clause The syntax

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/70152 >From aa31606a9d391682046bca3276e8c135c956f196 Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Tue, 24 Oct 2023 18:36:53 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate old syntax of linear clause The syntax

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/70152 >From c75c3729bac054b72caa502b464a24de2b63068b Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Tue, 24 Oct 2023 18:36:53 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate old syntax of linear clause The syntax

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: Can you make an example on how this is used now? Is there a way to test this? https://github.com/llvm/llvm-project/pull/70171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cd29e19 - [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (#69126)

2023-10-25 Thread via cfe-commits
Author: Arseny Kapoulkine Date: 2023-10-25T11:58:28-04:00 New Revision: cd29e19e9476e221015d895618512717d872a83b URL: https://github.com/llvm/llvm-project/commit/cd29e19e9476e221015d895618512717d872a83b DIFF:

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-25 Thread David Sherwood via cfe-commits
@@ -0,0 +1,1226 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py + +// REQUIRES: aarch64-registered-target + +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme2 -target-feature +sme-i16i64 -target-feature +sme-f64f64

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-25 Thread David Sherwood via cfe-commits
@@ -0,0 +1,418 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py + +// REQUIRES: aarch64-registered-target + +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme2 -target-feature +sme-i16i64 -target-feature +sme-f64f64

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-25 Thread David Sherwood via cfe-commits
https://github.com/david-arm commented: This looks a lot better now @kmclaughlin-arm - thanks for the changes! I just have a couple of comments about the tests that I missed previously... https://github.com/llvm/llvm-project/pull/69725 ___

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-25 Thread David Sherwood via cfe-commits
https://github.com/david-arm edited https://github.com/llvm/llvm-project/pull/69725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9bdeab1 - [LinkerWrapper][Obvious] Fix dangling stringref on Xcuda-ptxas options

2023-10-25 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-10-25T10:42:34-05:00 New Revision: 9bdeab1e7b25240d9282dbdc3617aaade195d62e URL: https://github.com/llvm/llvm-project/commit/9bdeab1e7b25240d9282dbdc3617aaade195d62e DIFF: https://github.com/llvm/llvm-project/commit/9bdeab1e7b25240d9282dbdc3617aaade195d62e.diff

[clang] 8e00d59 - [clang] Remove redundant ptr-to-ptr bitcasts (NFC)

2023-10-25 Thread Youngsuk Kim via cfe-commits
Author: Youngsuk Kim Date: 2023-10-25T10:36:52-05:00 New Revision: 8e00d59dce23f841586260092bddde8a4a26d75f URL: https://github.com/llvm/llvm-project/commit/8e00d59dce23f841586260092bddde8a4a26d75f DIFF: https://github.com/llvm/llvm-project/commit/8e00d59dce23f841586260092bddde8a4a26d75f.diff

[clang-tools-extra] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-25 Thread Arseny Kapoulkine via cfe-commits
zeux wrote: Let me know if I need to do anything else here -- I don't have commit rights so someone else will need to press the merge button :) https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Interp] Fix truncateCast() (PR #69911)

2023-10-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69911 >From 78422ff7c749a2dbfdf699d9bcc5d330c5809883 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 23 Oct 2023 11:43:32 +0200 Subject: [PATCH] [clang][Interp] Fix truncateCast() ---

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 updated https://github.com/llvm/llvm-project/pull/69567 >From ebc8ebdebf707f94723b1fe0ee1a1b6afe5dff49 Mon Sep 17 00:00:00 2001 From: ranapratap55 Date: Thu, 19 Oct 2023 12:52:13 +0530 Subject: [PATCH] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot

[clang] [analyzer] Loop should contain CXXForRangeStmt (PR #70190)

2023-10-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/70190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Fold xored one-complemented operand comparisons (PR #69882)

2023-10-25 Thread Nikita Popov via cfe-commits
nikic wrote: @elhewaty This is due to an incorrect rebase around the processUMulZExtIdiom() call. Can you please rebase another time over https://github.com/llvm/llvm-project/commit/ea99df2e84d5f1da7f04bfa9f13844c44e0f1f78, which should remove all the diffs unrelated to your change?

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/69656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -55,6 +56,7 @@ #include "llvm/Target/TargetOptions.h" #include "llvm/TargetParser/SubtargetFeature.h" #include "llvm/TargetParser/Triple.h" +#include "llvm/Transforms/HipStdPar/HipStdPar.h" ZequanWu wrote: It's not added. It's reordered by

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cc2fbc648d7babbfa612f4f5eda3160212ef6ca7 26b9570fadf428e2f55efe0f2d9433cf18305239 --

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/70217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/70217 >From 26b9570fadf428e2f55efe0f2d9433cf18305239 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 25 Oct 2023 16:55:15 +0200 Subject: [PATCH 1/3] friend operator!= --- clang/lib/Sema/SemaOverload.cpp

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM assuming the requested codegen tests don't bring up any surprises for you. https://github.com/llvm/llvm-project/pull/67805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself,

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -fsyntax-only -triple x86_64-linux-gnu -verify %s AaronBallman wrote: Yeah, a codegen test would make sense (just to show that we actually do emit code for that monstrosity). https://github.com/llvm/llvm-project/pull/67805

<    1   2   3   4   5   6   >