[clang] [clang] Implement gcc_struct attribute (PR #71148)

llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang-codegen Author: Dan Klishch (DanShaders) Changes This implements gcc_struct attribute with the behavior similar to one in GCC. In particular, when C++ ABI is not "Microsoft" (i. e. when ItaniumRecordBuilder is

[clang] [clang] Implement gcc_struct attribute (PR #71148)

https://github.com/DanShaders created https://github.com/llvm/llvm-project/pull/71148 This implements gcc_struct attribute with the behavior similar to one in GCC. In particular, when C++ ABI is not "Microsoft" (i. e. when ItaniumRecordBuilder is used), [[gcc_struct]] will locally cancel the

[clang] [llvm] [RISCV] Use BF16 in Xsfvfwmaccqqq intrinsics (PR #71140)

4vtomat wrote: Good catch！ LGTM, leave final decision to others~ https://github.com/llvm/llvm-project/pull/71140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit type metadata on vtables when IRPGO instrumentation option is on. (PR #70841)

https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/70841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit type metadata on vtables when IRPGO instrumentation option is on. (PR #70841)

https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/70841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit type metadata on vtables when IRPGO instrumentation option is on. (PR #70841)

https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/70841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit type metadata on vtables when IRPGO instrumentation option is on. (PR #70841)

@@ -0,0 +1,145 @@ +// Test that type metadata are emitted with -fprofile-generate +// +// RUN: %clang -fprofile-generate -fno-lto -target x86_64-unknown-linux -emit-llvm -S %s -o - | FileCheck %s --check-prefix=ITANIUM +// RUN: %clang -fprofile-generate -fno-lto -target

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/71134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 071f3b5 - [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (#71134)

Author: Fangrui Song Date: 2023-11-02T22:13:08-07:00 New Revision: 071f3b5b659fe26812d413a3acb7455fa11e93c8 URL: https://github.com/llvm/llvm-project/commit/071f3b5b659fe26812d413a3acb7455fa11e93c8 DIFF: https://github.com/llvm/llvm-project/commit/071f3b5b659fe26812d413a3acb7455fa11e93c8.diff

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/71134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][repl] fix `new` on Mac M1 (PR #69072)

https://github.com/makslevental closed https://github.com/llvm/llvm-project/pull/69072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

shafik wrote: Can you please add a more detailed description of the problem and what the fix actually is. The description is what ends up in the git log and it is important that we have enough details there to understand the PR and what changes it makes. I do not see a test, can this fix be

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/71134 >From 92cfc6e1306321ae8beb05775e2c7f8ac720f5e6 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 2 Nov 2023 19:42:09 -0700 Subject: [PATCH 1/2] [Modules] Fix ModuleDeclState transition when module is used

[clang] [Clang] Emit type metadata on vtables when IRPGO instrumentation option is on. (PR #70841)

https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/70841 >From 99abebc88c09346bd4a70bbf39df13b249116c09 Mon Sep 17 00:00:00 2001 From: Mingming Liu Date: Tue, 31 Oct 2023 01:17:03 -0700 Subject: [PATCH 1/5] [Clang]Emit type metadata when -fprofile-generate is on

[clang] [Clang] Emit type metadata on vtables when IRPGO instrumentation option is on. (PR #70841)

https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/70841 >From 99abebc88c09346bd4a70bbf39df13b249116c09 Mon Sep 17 00:00:00 2001 From: Mingming Liu Date: Tue, 31 Oct 2023 01:17:03 -0700 Subject: [PATCH 1/4] [Clang]Emit type metadata when -fprofile-generate is on

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 063e3fe648533004e6970ab767ece845e3c0afb1 c28e9f9fb753e41bc539fa4c45bd7896d7c5d04d --

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:370 + std::vector ) { + Features.push_back("__RISCV_TargetAttrNeedOverride"); + auto RII = llvm::RISCVISAInfo::parseArchString( Why do we need

[clang] [llvm] [RISCV] Use BF16 in Xsfvfwmaccqqq intrinsics (PR #71140)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Shao-Ce SUN (sunshaoce) Changes BF16 implementation based on @joshua-arch1's https://reviews.llvm.org/D152498 Fixed the incorrect f16 type introduced in https://github.com/llvm/llvm-project/pull/68296 - Co-authored-by: Jun Sha

[llvm] [clang] [RISCV] Use BF16 in Xsfvfwmaccqqq intrinsics (PR #71140)

https://github.com/sunshaoce created https://github.com/llvm/llvm-project/pull/71140 BF16 implementation based on @joshua-arch1's https://reviews.llvm.org/D152498 Fixed the incorrect f16 type introduced in https://github.com/llvm/llvm-project/pull/68296 - Co-authored-by: Jun Sha

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:434 +if (MarchFromCPU != "") { + Ret.Features.clear(); + handleFullArchString(MarchFromCPU, Ret.Features); craig.topper wrote: > Why does this clear Ret.Features,

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Pravin Jagtap (pravinjagtap) Changes Operands of `__builtin_amdgcn_update_dpp` need to evaluate to constant to match the intrinsic requirements. --- Full diff: https://github.com/llvm/llvm-project/pull/71139.diff 2 Files Affected: -

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

https://github.com/pravinjagtap created https://github.com/llvm/llvm-project/pull/71139 Operands of `__builtin_amdgcn_update_dpp` need to evaluate to constant to match the intrinsic requirements. >From c28e9f9fb753e41bc539fa4c45bd7896d7c5d04d Mon Sep 17 00:00:00 2001 From: Pravin Jagtap

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

@@ -966,9 +962,65 @@ static llvm::Value *getArrayIndexingBound(CodeGenFunction , return nullptr; } -FieldDecl *CodeGenFunction::FindCountedByField( -const Expr *Base, -LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel) { +const Expr *

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

@@ -966,9 +962,65 @@ static llvm::Value *getArrayIndexingBound(CodeGenFunction , return nullptr; } -FieldDecl *CodeGenFunction::FindCountedByField( -const Expr *Base, -LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel) { +const Expr *

[clang] [llvm] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

@@ -813,6 +813,14 @@ def HasVendorXSfcie : Predicate<"Subtarget->hasVendorXSfcie()">, AssemblerPredicate<(all_of FeatureVendorXSfcie), "'XSfcie' (SiFive Custom Instruction Extension SCIE.)">; +def FeatureVendorXSfvfwmaccqqq +

[llvm] [clang] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

@@ -103,3 +103,15 @@ let SupportOverloading = false in { defm sf_vc_v_fvw : RVVVCIXBuiltinSet<["si"], "UwKzUwUvFe", [-1, 0, 2, 3], UseGPR=0>; } } + +multiclass RVVVFWMACCBuiltinSet> suffixes_prototypes> { + let OverloadedName = NAME, + Name = NAME, +

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

https://github.com/ChuanqiXu9 approved this pull request. Thanks for looking into this. LGTM. https://github.com/llvm/llvm-project/pull/71134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

@@ -957,26 +957,27 @@ void Preprocessor::Lex(Token ) { ModuleDeclState.handlePeriod(); break; case tok::identifier: - if (Result.getIdentifierInfo()->isModulesImport()) { -TrackGMFState.handleImport(StdCXXImportSeqState.afterTopLevelSeq()); -

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/71134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

rymiel wrote: Thank you for reminding me, I may have forgotten this was here! https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 063e3fe - [clang-format] Skip PP directives when determining brace kind (#69473)

Author: Emilia Kond Date: 2023-11-03T05:51:20+02:00 New Revision: 063e3fe648533004e6970ab767ece845e3c0afb1 URL: https://github.com/llvm/llvm-project/commit/063e3fe648533004e6970ab767ece845e3c0afb1 DIFF: https://github.com/llvm/llvm-project/commit/063e3fe648533004e6970ab767ece845e3c0afb1.diff

[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/69867 >From 1aa7e406378adb1b7c3ba79b10d2dcb0a48c4ce6 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 22 Oct 2023 00:55:07 -0400 Subject: [PATCH] [Driver][Solaris][NFC] A little bit of clean up ---

[openmp] [clang] [OpenMP] Add support for Solaris/x86_64 (PR #70593)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/70593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b5b251a - [OpenMP] Add support for Solaris/x86_64 (#70593)

Author: Brad Smith Date: 2023-11-02T23:29:02-04:00 New Revision: b5b251aac80fbcfa224b0a83efa0a12bd747fafe URL: https://github.com/llvm/llvm-project/commit/b5b251aac80fbcfa224b0a83efa0a12bd747fafe DIFF: https://github.com/llvm/llvm-project/commit/b5b251aac80fbcfa224b0a83efa0a12bd747fafe.diff

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:147 + } + + if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs, Add in here.. ``` // Silence warnings when linking C code with a C++ '-stdlib' argument.

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

MaskRay wrote: > > FWIW, we saw failures at Google (where, to the best of my knowledge, we > > aren't using named modules at all) that look like this: > > ``` > > error: '#include ' attaches the declarations to the named module > > '.get', which is not usually intended; consider moving that

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes `ModuleDeclState` is incorrectly changed to `NamedModuleImplementation` for `struct module {}; void foo(module a);`. This is mostly benign but leads to a spurious warning after #69555. A real world example

[clang] [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (PR #71134)

https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/71134 `ModuleDeclState` is incorrectly changed to `NamedModuleImplementation` for `struct module {}; void foo(module a);`. This is mostly benign but leads to a spurious warning after #69555. A real world example is:

[clang] [llvm] [RISCV] Support Xsfvfnrclipxfqf extensions (PR #68297)

https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/68297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] [test] Make an XFAIL more precise (PR #70991)

dyung wrote: > > If you still need help reproducing or debugging the issue on our bot, > > please let me know. > > Thanks, much appreciated. Can you test if > [mstorsjo@clang-repl-xfail](https://github.com/mstorsjo/llvm-project/commit/clang-repl-xfail) > seems to run correctly in this

[llvm] [clang] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/68296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 945d2e6 - [RISCV] Support Xsfvfwmaccqqq extensions (#68296)

Author: Brandon Wu Date: 2023-11-03T10:08:26+08:00 New Revision: 945d2e6e603dd9cc5d155a3a34b67ecf17b91b68 URL: https://github.com/llvm/llvm-project/commit/945d2e6e603dd9cc5d155a3a34b67ecf17b91b68 DIFF: https://github.com/llvm/llvm-project/commit/945d2e6e603dd9cc5d155a3a34b67ecf17b91b68.diff

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

owenca wrote: @rymiel can we merge this? https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/68296 >From 625c45da9928c3da295bba28708c992a42f3cd52 Mon Sep 17 00:00:00 2001 From: Brandon Wu Date: Wed, 4 Oct 2023 10:23:52 -0700 Subject: [PATCH] [RISCV][SiFive] Support Xsfvfwmaccqqq extensions Bfloat16 Matrix

[openmp] [clang] [OpenMP] Add support for Solaris/x86_64 (PR #70593)

https://github.com/shiltian approved this pull request. LG https://github.com/llvm/llvm-project/pull/70593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

nhaehnle wrote: Though, on second thought, shouldn't there be some wave64 tests? https://github.com/llvm/llvm-project/pull/68714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

https://github.com/nhaehnle approved this pull request. https://github.com/llvm/llvm-project/pull/68714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [flang] [clang-tools-extra] [lldb] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

@@ -0,0 +1,28 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt < %s -passes=indvars -S | FileCheck %s + +declare void @foo(i16 noundef) + +; Function Attrs: mustprogress noreturn uwtable +define void @bar(i64 noundef %ptr) { +;

[clang] [clang-tools-extra] [llvm] [SimplifyCFG] Prevent merging cbranch to cbranch if the branch probability from the first to second is too low. (PR #69375)

nhaehnle wrote: I've been puzzling over the rationale for looking at `MD_unpredictable`. How can a branch that is heavily biased to one side be unpredictable? https://github.com/llvm/llvm-project/pull/69375 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8b8acedc0e6c432545744a113128cfcb4f2da7e5 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 01/20] [clang-tidy]

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

ChuanqiXu9 wrote: > FWIW, we saw failures at Google (where, to the best of my knowledge, we > aren't using named modules at all) that look like this: > > ``` > error: '#include ' attaches the declarations to the named module > '.get', which is not usually intended; consider moving that

[llvm] [clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 65dc96c - [RISCV] Fix wrong implication for zvknhb. (#66860)

Author: Brandon Wu Date: 2023-11-03T09:32:21+08:00 New Revision: 65dc96c2cfa480b070c7913ac5e313c98ca96520 URL: https://github.com/llvm/llvm-project/commit/65dc96c2cfa480b070c7913ac5e313c98ca96520 DIFF: https://github.com/llvm/llvm-project/commit/65dc96c2cfa480b070c7913ac5e313c98ca96520.diff

[llvm] [clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/66860 >From a43d20450eef2d41e88ab867de2656e2fd9631b7 Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Tue, 19 Sep 2023 23:06:01 -0700 Subject: [PATCH 1/3] [RISCV] Fix wrong implication for zvknhb. ---

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

rapidsna wrote: ``` #include #include struct flex { int c; int fam[] __attribute__((counted_by(c))); }; int main() { struct flex *p = (struct flex *)malloc(sizeof(struct flex) + sizeof(int) * 10); p->c = 100; printf("%lu\n", __builtin_dynamic_object_size(>fam[0], 0)); //

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. ping @dim @rsmith @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

https://github.com/rapidsna edited https://github.com/llvm/llvm-project/pull/70480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

https://github.com/rapidsna edited https://github.com/llvm/llvm-project/pull/70480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang-tools-extra] [clang] [llvm] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

@@ -334,6 +335,15 @@ template<> struct simplify_type { } }; +template <> struct GraphTraits { wenju-he wrote: added 3 more runs on RHEL9 today, the compile time diff is very small. https://github.com/llvm/llvm-project/pull/70611

[openmp] [clang] [OpenMP] Add support for Solaris/x86_64 (PR #70593)

brad0 wrote: I'd like to get this in. https://github.com/llvm/llvm-project/pull/70593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

https://github.com/rapidsna edited https://github.com/llvm/llvm-project/pull/70480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

@@ -0,0 +1,12 @@ +// This reports a warning to follow the default behavior of ClangAs. +// RUN: %clang -fexperimental-bounds-safety -x assembler -c %s -o /dev/null 2>&1 | FileCheck -check-prefix WARN %s rapidsna wrote: I think `-x assembler` and `-x

[clang-tools-extra] [clang] [llvm] [compiler-rt] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/70611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

rapidsna wrote: > @kees, @nickdesaulniers, @rapidsna, and @apple-fcloutier Should this feature > support a `__bdos` to an address inside the FAM? > > ``` > #include > #include > > struct flex { > double dummy; > char count; > char fam[]

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

@@ -0,0 +1,12 @@ +// This reports a warning to follow the default behavior of ClangAs. +// RUN: %clang -fexperimental-bounds-safety -x assembler -c %s -o /dev/null 2>&1 | FileCheck -check-prefix WARN %s delcypher wrote: @rapidsna Maybe there should be a version

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

https://github.com/bzEq updated https://github.com/llvm/llvm-project/pull/70480 >From 99ec6e055dd32a86bf6d589a6895658dcbe1d7bd Mon Sep 17 00:00:00 2001 From: Yeoul Na Date: Fri, 27 Oct 2023 08:34:37 -0700 Subject: [PATCH 1/6] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

https://github.com/rapidsna updated https://github.com/llvm/llvm-project/pull/70480 >From 99ec6e055dd32a86bf6d589a6895658dcbe1d7bd Mon Sep 17 00:00:00 2001 From: Yeoul Na Date: Fri, 27 Oct 2023 08:34:37 -0700 Subject: [PATCH 1/6] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag

[clang-tools-extra] [clang] [clang][AST] Fix crash in MatchChildASTVisitor::TraverseLambdaExpr (PR #70962)

https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/70962 >From 3e37e7e4afe806993acbba3d7663fdbfe80120c7 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Wed, 1 Nov 2023 17:01:25 + Subject: [PATCH 1/2] [clang][AST] Fix crash in

[clang] 14f2025 - [clang][CGExpr] Remove no-op ptr-to-ptr bitcasts (NFC)

Author: Youngsuk Kim Date: 2023-11-02T17:50:46-05:00 New Revision: 14f2025671f82192d38e1db9bc185790e1221cd3 URL: https://github.com/llvm/llvm-project/commit/14f2025671f82192d38e1db9bc185790e1221cd3 DIFF: https://github.com/llvm/llvm-project/commit/14f2025671f82192d38e1db9bc185790e1221cd3.diff

[lldb] [clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

avl-llvm wrote: > > 2. always put DW_AT_const_value in DW_TAG_member. > > My understanding is that this is not possible. Dependent initializer > expressions can't be evaluated in all cases - we're only allowed to evaluate > them in the places the language allows us to, otherwise we might

[compiler-rt] [clang-tools-extra] [llvm] [clang] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/70611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] [test] Make an XFAIL more precise (PR #70991)

mstorsjo wrote: > If you still need help reproducing or debugging the issue on our bot, please > let me know. Thanks, much appreciated. Can you test if https://github.com/mstorsjo/llvm-project/commit/clang-repl-xfail seems to run correctly in this environment? Otherwise I'll try to push it

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/71095 >From 0ca1191c2235881493a82f040c437d8da8a82862 Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Thu, 2 Nov 2023 12:23:34 -0700 Subject: [PATCH 1/3] [clang-tidy][libc] Ignore implicit function inline

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/69975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6c465a2 - [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (#69975)

Author: Jan Svoboda Date: 2023-11-02T15:07:58-07:00 New Revision: 6c465a201b02f3316efc55eef6909080866f6fb0 URL: https://github.com/llvm/llvm-project/commit/6c465a201b02f3316efc55eef6909080866f6fb0 DIFF: https://github.com/llvm/llvm-project/commit/6c465a201b02f3316efc55eef6909080866f6fb0.diff

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/69975 >From 5dd9d64726dba95f71dfb276dd1be4d386313a99 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 10 Oct 2023 14:16:13 -0700 Subject: [PATCH 1/6] [clang][modules] Make `DIAGNOSTIC_OPTIONS` skippable ---

[clang] [clang-repl] [test] Make an XFAIL more precise (PR #70991)

dyung wrote: If you still need help reproducing or debugging the issue on our bot, please let me know. https://github.com/llvm/llvm-project/pull/70991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-repl] [test] Make an XFAIL more precise (PR #70991)

mstorsjo wrote: > FTR, the "Worker" tab on that buildbot page will point you to the maintainer. Ah, there it is, I tried looking around, but overlooked that one... > But tagging me is also fine in general. Ok, thanks! > I'm unable to repro the problem locally because my local build doesn't

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

@@ -304,6 +304,10 @@ Changes in existing checks customizable namespace. This further allows for testing the libc when the system-libc is also LLVM's libc. +- Improved :doc:`llvmlibc-inline-function-decl + ` to properly ignore implicit PiotrZSL wrote:

[mlir] [lldb] [libcxxabi] [clang] [compiler-rt] [llvm] [libcxx] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

@@ -466,6 +466,114 @@ Unpoisoning may not be an option, if (for example) you are not maintaining the a * You are using allocator, which does not call destructor during deallocation. * You are aware that memory allocated with an allocator may be accessed, even when unused by

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

@@ -79,6 +79,10 @@ void InlineFunctionDeclCheck::check(const MatchFinder::MatchResult ) { if (MethodDecl->getParent()->isLambda()) return; + // Ignore functions that have been deleted. + if (FuncDecl->isDeleted()) PiotrZSL wrote: Instead of this

[clang] [clang][modules] Track included files per submodule (PR #71117)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 89d5635f0a834e53ac5446c6d6ea38d9166b2a55 9debc58d5135fbde51967dfb076d0ec5d954df38 --

[clang] [clang][modules] Track included files per submodule (PR #71117)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/71117 None >From 9debc58d5135fbde51967dfb076d0ec5d954df38 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 2 Nov 2023 14:35:30 -0700 Subject: [PATCH] [clang][modules] Track included files per submodule ---

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

@@ -3,6 +3,7 @@ llvmlibc-inline-function-decl = -Checks that all implicit and explicit inline functions in header files are -tagged with the ``LIBC_INLINE`` macro. See the `libc style guide -`_ for more

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/71095 >From 0ca1191c2235881493a82f040c437d8da8a82862 Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Thu, 2 Nov 2023 12:23:34 -0700 Subject: [PATCH 1/2] [clang-tidy][libc] Ignore implicit function inline

[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG89d5635f0a83: [lld][WebAssembly] Add --keep-section flag (authored by sbc100). Changed prior to commit: https://reviews.llvm.org/D149917?vs=557960=557993#toc Repository: rG LLVM Github Monorepo

[clang] 89d5635 - [lld][WebAssembly] Add --keep-section flag

Author: Sam Clegg Date: 2023-11-02T14:23:45-07:00 New Revision: 89d5635f0a834e53ac5446c6d6ea38d9166b2a55 URL: https://github.com/llvm/llvm-project/commit/89d5635f0a834e53ac5446c6d6ea38d9166b2a55 DIFF: https://github.com/llvm/llvm-project/commit/89d5635f0a834e53ac5446c6d6ea38d9166b2a55.diff

[clang] [clang-format] Treat empty for/while loops as short loops (PR #70768)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/70768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2c2fb8e - [clang-format] Treat empty for/while loops as short loops (#70768)

Author: Owen Pan Date: 2023-11-02T14:09:00-07:00 New Revision: 2c2fb8e10a12774bae86a5ff60fd67c5dc5e220f URL: https://github.com/llvm/llvm-project/commit/2c2fb8e10a12774bae86a5ff60fd67c5dc5e220f DIFF: https://github.com/llvm/llvm-project/commit/2c2fb8e10a12774bae86a5ff60fd67c5dc5e220f.diff

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

@@ -79,6 +79,10 @@ void InlineFunctionDeclCheck::check(const MatchFinder::MatchResult ) { if (MethodDecl->getParent()->isLambda()) return; + // Ignore implicit functions (e.g. implicit constructors or destructors) + if (FuncDecl->isImplicit())

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

dwblaikie wrote: FWIW, we saw failures at Google (where, to the best of my knowledge, we aren't using named modules at all) that look like this: ``` error: '#include ' attaches the declarations to the named module '.get', which is not usually intended; consider moving that directive before

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

@@ -3,6 +3,7 @@ llvmlibc-inline-function-decl = -Checks that all implicit and explicit inline functions in header files are -tagged with the ``LIBC_INLINE`` macro. See the `libc style guide -`_ for more

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:229 +resolveTargetAttrOverride(const std::vector ) { + if (!llvm::is_contained(FeaturesVec, "__RISCV_TargetAttrNeedOverride")) +return FeaturesVec; Can we use something like

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

https://github.com/PiotrZSL approved this pull request. LGTM, Consider also adding tests for default and deleted constructors or assign operators, I think that they also could generate false-positive. https://github.com/llvm/llvm-project/pull/71095

[clang-tools-extra] [clang-tidy][libc] Ignore implicit function inline (PR #71095)

@@ -79,6 +79,10 @@ void InlineFunctionDeclCheck::check(const MatchFinder::MatchResult ) { if (MethodDecl->getParent()->isLambda()) return; + // Ignore implicit functions (e.g. implicit constructors or destructors) + if (FuncDecl->isImplicit())

[compiler-rt] [llvm] [clang] [Profile] Refactor profile correlation. (PR #70856)

ZequanWu wrote: > I'm a bit concerned about the use of hasCorrelation. We require the runtime > to check the flag and omit the data and names section if set which introduces > a potential issue: since we emit the version in every TU and u se COMDAT to > deduplicate them, but that means that

[llvm] [clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

@@ -421,13 +421,102 @@ void AIX::AddCXXStdlibLibArgs(const llvm::opt::ArgList , llvm_unreachable("Unexpected C++ library type; only libc++ is supported."); } +// This function processes all the mtocdata options to build the final +// simplified toc data options to pass to

[clang] [HLSL] Vector vector standard conversions (PR #71098)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0e6c679c1a5c0d3f101335c904583b5d62cb51d3 73c0b9f0bdf44710a290a17c8d87bc0e3db393ef --

[clang] [analyzer] Add std::variant checker (PR #66481)

@@ -0,0 +1,327 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

  1   2   3   4   5   >