[clang] Templated equals take 2 (PR #72213)

2023-11-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][LoongArch] Don't imply -fdirect-access-external-data for non-PIC (PR #71887)

2023-11-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thanks for the patch, but I think we can keep the default only in the default so that Frontend does not need to handle target-specific differences. See https://github.com/llvm/llvm-project/pull/72221 and I've added only few tests that make sense (`-fpic

[clang] Templated equals take 2 (PR #72213)

2023-11-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Default LoongArch to -fno-direct-access-external-data for non-PIC (PR #72221)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes For -fno-pic, if an extern variable is defined in a DSO, a copy relocation will be needed. However, loongarch*-linux does not and will not support copy relocations. Change

[clang] [Driver] Default LoongArch to -fno-direct-access-external-data for non-PIC (PR #72221)

2023-11-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/72221 For -fno-pic, if an extern variable is defined in a DSO, a copy relocation will be needed. However, loongarch*-linux does not and will not support copy relocations. Change Driver to default to

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-13 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: I see; it's a bit unfortunate that such an "invented" call expression gets an ordinary `SourceLocation`. I would have hoped it gets a source location in some sort of virtual buffer like the [rewritten form of

[clang] e96edde - Reland "[X86][AVX10] Fix a bug when using -march with no-evex512 attribute (#72126)"

2023-11-13 Thread Phoebe Wang via cfe-commits
Author: Phoebe Wang Date: 2023-11-14T15:39:30+08:00 New Revision: e96eddec5e8ecc0fdab377571aabe85a2ee7617e URL: https://github.com/llvm/llvm-project/commit/e96eddec5e8ecc0fdab377571aabe85a2ee7617e DIFF: https://github.com/llvm/llvm-project/commit/e96eddec5e8ecc0fdab377571aabe85a2ee7617e.diff

[clang] 17dd0c7 - Revert "[X86][AVX10] Fix a bug when using -march with no-evex512 attribute (#72126)"

2023-11-13 Thread Phoebe Wang via cfe-commits
Author: Phoebe Wang Date: 2023-11-14T15:34:38+08:00 New Revision: 17dd0c70c8c3183c62d184de2e91a859c36880e9 URL: https://github.com/llvm/llvm-project/commit/17dd0c70c8c3183c62d184de2e91a859c36880e9 DIFF: https://github.com/llvm/llvm-project/commit/17dd0c70c8c3183c62d184de2e91a859c36880e9.diff

[clang] [Clang][RISCV] Introduce tuple types for RVV bfloat16 (PR #72216)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yueh-Ting (eop) Chen (eopXD) Changes The first commit extends the capacity from the compiler infrastructure, and the second commit continues the effort in #71140 to introduce tuple types for bfloat16. --- Full diff:

[clang] [Clang][RISCV] Introduce tuple types for RVV bfloat16 (PR #72216)

2023-11-13 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD created https://github.com/llvm/llvm-project/pull/72216 The first commit extends the capacity from the compiler infrastructure, and the second commit continues the effort in #71140 to introduce tuple types for bfloat16. >From e34bbbf5ebd1444aab843f3919faf68ae8d1cda9

[clang-tools-extra] [mlir] [llvm] [clang] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-13 Thread Christian Ulmann via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: mlir-opt %s -pass-pipeline='builtin.module(spirv-attach-target{ver=v1.0

[clang] [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (PR #72126)

2023-11-13 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/72126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 451c594 - [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (#72126)

2023-11-13 Thread via cfe-commits
Author: Phoebe Wang Date: 2023-11-14T15:15:34+08:00 New Revision: 451c594bcbe528a44312cb698d78145c3ef18fa1 URL: https://github.com/llvm/llvm-project/commit/451c594bcbe528a44312cb698d78145c3ef18fa1 DIFF: https://github.com/llvm/llvm-project/commit/451c594bcbe528a44312cb698d78145c3ef18fa1.diff

[clang] Supports viewing class member variables in lambda when using the vs debugger (PR #71564)

2023-11-13 Thread via cfe-commits
@@ -2605,6 +2605,9 @@ CodeViewDebug::lowerRecordFieldList(const DICompositeType *Ty) { MemberBaseType = TypeTable.writeLeafType(BFR); } uint64_t MemberOffsetInBytes = MemberOffsetInBits / 8; +if (Ty->getName().find("`, # overloads = 2, overload list =

[clang] Templated equals take 2 (PR #72213)

2023-11-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Templated equals take 2 (PR #72213)

2023-11-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Templated equals take 2 (PR #72213)

2023-11-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c14602b318f2d439af254710095684c1f5a8a386 79181efd0d7aef1b8396d44cdf40c0dfa4054984 --

[clang] Templated equals take 2 (PR #72213)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/72213.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+21) - (modified) clang/lib/Sema/SemaOverload.cpp (+22-10) - (modified)

[clang] Templated equals take 2 (PR #72213)

2023-11-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/72213 None >From bc9e06ea87dca046227faf2996eb8de521863d57 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 20 Oct 2023 14:40:25 +0200 Subject: [PATCH 1/2] [clang] Handle templated operators with reversed

[clang] Ignore template parameter visibility (PR #72092)

2023-11-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > After the change, does it seem more feasible to ignore template parameters? > > Hmm. You're right that considering the type of a non-type template argument > would be enough to give the right visibility to my example. It would not be > enough if the template was used as a

[clang] Supports viewing class member variables in lambda when using the vs debugger (PR #71564)

2023-11-13 Thread via cfe-commits
https://github.com/GkvJwa updated https://github.com/llvm/llvm-project/pull/71564 >From 6698e36f62b5171ee33a756d4c649a76803137aa Mon Sep 17 00:00:00 2001 From: GkvJwa Date: Wed, 8 Nov 2023 01:37:19 +0800 Subject: [PATCH] Supports viewing class member in lambda when using the vs debugger Use

[clang] [flang] [llvm] [clang-tools-extra] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-13 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 01/17] [clang] Add support for new loop attribute

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-13 Thread Shoaib Meenai via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) smeenai wrote: I agree with Chris in general. This

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-11-13 Thread Petr Hosek via cfe-commits
petrhosek wrote: I'm fine with the feature, my only concern is to make sure we don't unintentionally make it harder to integrate potential future extensions such as the mutually dependent groups. The only alternative I could come up with is representing groups as first class concept with

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-13 Thread Timm Baeder via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) tbaederr wrote: Well yes, but I'm not introducing

[clang] [flang] [compiler-rt] [clang-tools-extra] [llvm] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-13 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 01/16] [clang] Add support for new loop attribute

[clang-tools-extra] [clang] [llvm] [CodeGen] Revamp counted_by calculations (PR #70606)

2023-11-13 Thread Bill Wendling via cfe-commits
bwendling wrote: @nathanchance Could you try the patch in https://github.com/bwendling/llvm-project/tree/counted-by-offsets to see if it helps? I'll take a look, but it's going to compile slowly on my machine... https://github.com/llvm/llvm-project/pull/70606

[clang] [clang] Add `::_placement_new` expression for built-in global placement new (PR #72209)

2023-11-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1609f1c2a5ecc0e0e28f433ec9205122478ddaa3 75cf305fe732d00be910a6aa0afe79953c5b7186 --

[lld] [llvm] [mlir] [clang] [flang] [ELF] Merge exportDynamic into versionId (PR #71272)

2023-11-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: I'm nervous of making `--version-script` export a symbol when creating an executable. I have implemented https://github.com/llvm/llvm-project/pull/72208 instead to give us more free bits! https://github.com/llvm/llvm-project/pull/71272

[clang] [clang] Add `::_placement_new` expression for built-in global placement new (PR #72209)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: None (MaxEW707) Changes https://godbolt.org/z/7Khh33fxo for reference Background I work on a large software project where debug performance and

[clang] [clang] Add `::_placement_new` expression for built-in global placement new (PR #72209)

2023-11-13 Thread via cfe-commits
https://github.com/MaxEW707 created https://github.com/llvm/llvm-project/pull/72209 https://godbolt.org/z/7Khh33fxo for reference Background I work on a large software project where debug performance and compile-time performance are considered high priority. Clang has already done a lot

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2023-11-13 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/70772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_bitreverse (PR #71687)

2023-11-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/71687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_parity (PR #71662)

2023-11-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/71662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix stack peek offset for This ptr (PR #70663)

2023-11-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/70663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use new interpreter in EvaluateAsConstantExpr if requested (PR #70763)

2023-11-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/70763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add an EvaluationResult class (PR #71315)

2023-11-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/71315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] IndirectMember initializers (PR #69900)

2023-11-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/69900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix variables refering to their own address (PR #70587)

2023-11-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/70587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-11-13 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] Ignore template parameter visibility (PR #72092)

2023-11-13 Thread John McCall via cfe-commits
rjmccall wrote: > I cannot figure out a test case for `TemplateArgument::Expression`. I wonder > whether it applies to `X<> x5;` (address of static member), which Clang > doesn't support. It's primarily used as a dependent template argument. I'm not sure off-hand that it's *never*

[clang] [clang] Sema::isSimpleTypeSpecifier return true for _Bool in c99 (PR #72204)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Carl Peto (carlos4242) Changes Currently returns false for _Bool, regardless of C dialect. Fixes #72203. I'm unsure how to add a unit test for this? I am open to suggestions! @AaronBallman --- Full diff:

[clang] [clang] Sema::isSimpleTypeSpecifier return true for _Bool in c99 (PR #72204)

2023-11-13 Thread Carl Peto via cfe-commits
https://github.com/carlos4242 created https://github.com/llvm/llvm-project/pull/72204 Currently returns false for _Bool, regardless of C dialect. Fixes #72203. I'm unsure how to add a unit test for this? I am open to suggestions! @AaronBallman >From 26d40ec42af065fdeda6bdf679cc87928c81c97a

[compiler-rt] [llvm] [flang] [clang-tools-extra] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-13 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [flang] [clang-tools-extra] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-13 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [flang] [clang-tools-extra] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-13 Thread via cfe-commits
@@ -322,6 +322,66 @@ static Attr *handleUnlikely(Sema , Stmt *St, const ParsedAttr , return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo , +Expr *E) { + if

[compiler-rt] [llvm] [flang] [clang-tools-extra] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-13 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 01/15] [clang] Add support for new loop attribute

[clang] [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (PR #72126)

2023-11-13 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/72126 >From a7642c3216cac9901f2e8b2290732ad526406b06 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 13 Nov 2023 23:21:35 +0800 Subject: [PATCH 1/8] [X86][AVX10] Fix a bug when using -march with no-evex512

[clang] [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (PR #72126)

2023-11-13 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/72126 >From a7642c3216cac9901f2e8b2290732ad526406b06 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 13 Nov 2023 23:21:35 +0800 Subject: [PATCH 1/7] [X86][AVX10] Fix a bug when using -march with no-evex512

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

2023-11-13 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa852869398af: [clang-format] Fix a bug in parsing function/variable names (authored by gedare, committed by owenpan). Changed prior to commit: https://reviews.llvm.org/D156370?vs=558061=558088#toc

[clang] a852869 - [clang-format] Fix a bug in parsing function/variable names

2023-11-13 Thread Owen Pan via cfe-commits
Author: Gedare Bloom Date: 2023-11-13T19:35:28-08:00 New Revision: a852869398af71141d9422ab3e53a11433a3791f URL: https://github.com/llvm/llvm-project/commit/a852869398af71141d9422ab3e53a11433a3791f DIFF: https://github.com/llvm/llvm-project/commit/a852869398af71141d9422ab3e53a11433a3791f.diff

[clang] [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (PR #72126)

2023-11-13 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud approved this pull request. Interesting. LGTM https://github.com/llvm/llvm-project/pull/72126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-11-13 Thread via cfe-commits
@@ -3369,6 +3369,23 @@ static void handleSectionAttr(Sema , Decl *D, const ParsedAttr ) { } } +static void handleCodeModelAttr(Sema , Decl *D, const ParsedAttr ) { + StringRef Model; + SourceLocation LiteralLoc; + // Check that it is a string. + if

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

2023-11-13 Thread via cfe-commits
hstk30-hw wrote: @AaronBallman @erichkeane Check it plz. https://github.com/llvm/llvm-project/pull/72197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARC][Documentation] Explicitly state that messaging weak objects keeps a strong reference during call lifetime (PR #72169)

2023-11-13 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/72169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5079b27 - [ARC][Documentation] Explicitly state that messaging weak objects keeps a strong reference during call lifetime (#72169)

2023-11-13 Thread via cfe-commits
Author: Akira Hatanaka Date: 2023-11-13T18:53:15-08:00 New Revision: 5079b27c55137d58ca5f8048248c852d088be55c URL: https://github.com/llvm/llvm-project/commit/5079b27c55137d58ca5f8048248c852d088be55c DIFF:

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (hstk30-hw) Changes About https://github.com/llvm/llvm-project/issues/69872 , just for compatible C++ empty record with align UB with gcc https://godbolt.org/z/qsze8fqra --- Full diff:

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

2023-11-13 Thread via cfe-commits
https://github.com/hstk30-hw created https://github.com/llvm/llvm-project/pull/72197 About https://github.com/llvm/llvm-project/issues/69872 , just for compatible C++ empty record with align UB with gcc https://godbolt.org/z/qsze8fqra >From 84472eea164fe78e061e6c85a4f3a7874c5957a3 Mon Sep

[clang] [Driver] Make use of AddFilePathLibArgs() on NetBSD. (PR #71371)

2023-11-13 Thread Brad Smith via cfe-commits
brad0 wrote: Ping. https://github.com/llvm/llvm-project/pull/71371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][BoundsSafety] Add -fexperimental-bounds-safety flag (PR #70480)

2023-11-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. > -fbounds-safety-experimental is an experimental flag for -fbounds-safety, -fexperimental-bounds-safety https://github.com/llvm/llvm-project/pull/70480 ___ cfe-commits mailing list

[clang] [Driver][BoundsSafety] Add -fexperimental-bounds-safety flag (PR #70480)

2023-11-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: > @MaskRay To be clear, the check is now in Driver as you suggested. It's just > that the frontend also has some extra checks too. So, you want me to remove > the extra checks in the frontend? Yes, otherwise it's duplicated check. In addition, I think our convention is to add

[clang] [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (PR #72126)

2023-11-13 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/72126 >From a7642c3216cac9901f2e8b2290732ad526406b06 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 13 Nov 2023 23:21:35 +0800 Subject: [PATCH 1/6] [X86][AVX10] Fix a bug when using -march with no-evex512

[clang-tools-extra] [clang-tidy] Improved readability-bool-conversion to be more consistent when using parentheses (PR #72068)

2023-11-13 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/72068 From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 12 Nov 2023 16:07:13 -0500 Subject: [PATCH 1/3] [clang-tidy] Improved

[clang-tools-extra] [clang-tidy] Improved readability-bool-conversion to be more consistent when using parentheses (PR #72068)

2023-11-13 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/72068 From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 12 Nov 2023 16:07:13 -0500 Subject: [PATCH 1/2] [clang-tidy] Improved

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

2023-11-13 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. ping @dim @rsmith @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Improved readability-bool-conversion to be more consistent when using parentheses (PR #72068)

2023-11-13 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/72068 From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 12 Nov 2023 16:07:13 -0500 Subject: [PATCH 1/2] [clang-tidy] Improved

[clang] [clang] Stub out gcc_struct attribute (PR #71148)

2023-11-13 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders updated https://github.com/llvm/llvm-project/pull/71148 >From 5fb6768149bf2b4e7d74c4874e17dbf4e0e656b7 Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Fri, 3 Nov 2023 21:18:06 -0400 Subject: [PATCH 1/2] [clang] Stub out gcc_struct attribute This commit

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

2023-11-13 Thread David Truby via cfe-commits
https://github.com/DavidTruby edited https://github.com/llvm/llvm-project/pull/72121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

2023-11-13 Thread David Truby via cfe-commits
@@ -303,6 +323,9 @@ bool CodeGenAction::beginSourceFileAction() { Fortran::parser::Program {*ci.getParsing().parseTree()}; lb.lower(parseTree, ci.getInvocation().getSemanticsContext()); + // Add dependent libraries + addDepdendentLibs(*mlirModule, ci);

[clang] [Driver] Handle Flang in same manner between Gnu and *BSD/Solaris ToolChain (PR #70429)

2023-11-13 Thread Brad Smith via cfe-commits
brad0 wrote: > Seems fine to me once a test is added:) I cannot test as is as the frontend does not support these flags yet. I am just keeping things in sync between the C++ bit above that.. ``` if (D.CCCIsCXX() && !Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs,

[clang] [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (PR #72126)

2023-11-13 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/72126 >From a7642c3216cac9901f2e8b2290732ad526406b06 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 13 Nov 2023 23:21:35 +0800 Subject: [PATCH 1/4] [X86][AVX10] Fix a bug when using -march with no-evex512

[clang] Ignore template parameter visibility (PR #72092)

2023-11-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thanks for the comment. Frankly, I am at a loss in deriving a criterion (for shouldConsiderTemplateVisibility) to select one of the following rules. (1) factor in both template arguments and template parameters (2) factor in only template arguments (3) factor in nothing. Could

[clang] [X86][AVX10] Fix a bug when using -march with no-evex512 attribute (PR #72126)

2023-11-13 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/72126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Ignore template parameter visibility (PR #72092)

2023-11-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/72092 >From 401af7b4eabe92c8264c722a3f1181875da18438 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 12 Nov 2023 23:22:50 -0800 Subject: [PATCH 1/2] Ignore template parameter visibility When computing the

[flang] [mlir] [clang] [clang-tools-extra] [llvm] [lldb] [compiler-rt] [CodeGen][DebugInfo] Add missing debug info for jump table BB (PR #71021)

2023-11-13 Thread via cfe-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/71021 >From 1be56cf6541d34e4e2ead3f4b3d3ce482d69f68f Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Thu, 2 Nov 2023 12:14:15 +0800 Subject: [PATCH 1/4] [DebugInfo] Add debug info test for jump table Test whether

[llvm] [clang] [clang][llvm][fatlto] Avoid cloning modules in FatLTO (PR #72180)

2023-11-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/72180 >From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 13 Nov 2023 23:54:51 + Subject: [PATCH] [clang][llvm][fatlto] Avoid cloning modules in FatLTO

[clang] [llvm] [clang][llvm][fatlto] Avoid cloning modules in FatLTO (PR #72180)

2023-11-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 731152e18fa757aac213da0b3f10629ef05a7311 061650962e36a9826de55770a51815ebd5a42fc9 --

[clang] [llvm] [flang] [DebugInfo] Move jump table test to X86 directory (PR #72118)

2023-11-13 Thread via cfe-commits
https://github.com/HaohaiWen closed https://github.com/llvm/llvm-project/pull/72118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm][fatlto] Avoid cloning modules in FatLTO (PR #72180)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lto @llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) Changes https://github.com/llvm/llvm-project/issues/70703 pointed out that cloning LLVM modules could lead to miscompiles when using FatLTO. This is due to an existing issue when cloning

[clang] [llvm] [clang][llvm][fatlto] Avoid cloning modules in FatLTO (PR #72180)

2023-11-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/72180 https://github.com/llvm/llvm-project/issues/70703 pointed out that cloning LLVM modules could lead to miscompiles when using FatLTO. This is due to an existing issue when cloning modules with labels (see #55991

[llvm] [clang] [mlir] [clang-tools-extra] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-13 Thread Fabian Mora via cfe-commits
@@ -4,6 +4,7 @@ module attributes {gpu.container_module} { // CHECK: [[ARGS_TY:%.*]] = type { i32, i32 } // CHECK: @kernel_module_bin_cst = internal constant [4 x i8] c"BLOB", align 8 + // CHECK: @kernel_module_bin_size_cst = internal constant i64 4, align 8

[clang] [llvm] [clang-tools-extra] [mlir] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-13 Thread Fabian Mora via cfe-commits
@@ -377,10 +379,17 @@ llvm::LaunchKernel::createKernelLaunch(mlir::gpu::LaunchFuncOp op, if (!binary) return op.emitError() << "Couldn't find the binary: " << binaryIdentifier; + auto binaryVar = dyn_cast(binary); + llvm::Constant *binaryInit =

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-13 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/71612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 731152e - [clang][DependencyScanner] Remove all warning flags when suppressing warnings (#71612)

2023-11-13 Thread via cfe-commits
Author: Michael Spencer Date: 2023-11-13T16:45:38-08:00 New Revision: 731152e18fa757aac213da0b3f10629ef05a7311 URL: https://github.com/llvm/llvm-project/commit/731152e18fa757aac213da0b3f10629ef05a7311 DIFF:

[clang] [flang] [clang-tools-extra] [llvm] [libc] Fix clang to recognize new C23 modifiers %w and %wf when printing (PR #71771)

2023-11-13 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/71771 >From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 9 Nov 2023 02:21:46 + Subject: [PATCH 1/2] Fix clang to recognize new C23 modifiers %w and %wf when

[clang] [llvm] [clang-tools-extra] Fix clang to recognize new C23 modifiers %w and %wf when printing (PR #71771)

2023-11-13 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/71771 >From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 9 Nov 2023 02:21:46 + Subject: [PATCH 1/2] Fix clang to recognize new C23 modifiers %w and %wf when

[clang] [flang] [llvm] [libc] [mlir] [flang] Fold MATMUL() (PR #72176)

2023-11-13 Thread Peter Klausler via cfe-commits
https://github.com/klausler updated https://github.com/llvm/llvm-project/pull/72176 >From e2e0e60c5cf01b5e99cb2494e2444b91d1f6605d Mon Sep 17 00:00:00 2001 From: Peter Klausler Date: Fri, 3 Nov 2023 13:04:01 -0700 Subject: [PATCH] [flang] Fold MATMUL() Implements constant folding for matrix

[clang] [llvm] [clang-tools-extra] Fix clang to recognize new C23 modifiers %w and %wf when printing (PR #71771)

2023-11-13 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/71771 >From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 9 Nov 2023 02:21:46 + Subject: [PATCH] Fix clang to recognize new C23 modifiers %w and %wf when

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-11-13 Thread via cfe-commits
DonatNagyE wrote: I ran an analysis that compares this commit with its parent on many open source projects. The results revealed that this commit "converts" many alpha.security.ArrayBound (V1) results into alpha.security.ArrayBoundV2 results because (if I understand it correctly) the new

[mlir] [lldb] [llvm] [clang] [compiler-rt] Enable Custom Lowering for fabs.v8f16 on AVX (PR #71730)

2023-11-13 Thread David Li via cfe-commits
https://github.com/david-xl updated https://github.com/llvm/llvm-project/pull/71730 >From 6032b965f85482b39e841bd95842f4e17c92fefd Mon Sep 17 00:00:00 2001 From: David Li Date: Tue, 7 Nov 2023 23:29:44 -0800 Subject: [PATCH 1/6] Enable Custom Lowering for fabs.v8f16 on AVX ---

[llvm] [clang] [RFC] Introducing `__builtin_consistent` to generate AArch64 BC.cond … (PR #72175)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-msp430 @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-backend-amdgpu Author: Pavel Iliin (ilinpv) Changes …instructions The patch adds new `__builtin_consistent` which when used with control flow

[llvm] [clang] [RFC] Introducing `__builtin_consistent` to generate AArch64 BC.cond … (PR #72175)

2023-11-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-spir-v Author: Pavel Iliin (ilinpv) Changes …instructions The patch adds new `__builtin_consistent` which when used with control flow conditions provides a hint to compiler that branch or switch is very unlikely to change direction. The hint

[llvm] [clang] [clang-tools-extra] [nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata (PR #71328)

2023-11-13 Thread Mingming Liu via cfe-commits
@@ -1362,28 +1413,55 @@ static int merge_main(int argc, const char *argv[]) { exitWithError( "-supplement-instr-with-sample can only work with -instr. "); -supplementInstrProfile(WeightedInputs, SupplInstrWithSample, OutputFilename, -

[clang-tools-extra] [llvm] [clang] [nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata (PR #71328)

2023-11-13 Thread Mingming Liu via cfe-commits
@@ -435,13 +450,195 @@ static void writeInstrProfile(StringRef OutputFilename, } } -static void -mergeInstrProfile(const WeightedFileVector , StringRef DebugInfoFilename, - SymbolRemapper *Remapper, StringRef OutputFilename, -

[clang] [clang-tools-extra] [llvm] [nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata (PR #71328)

2023-11-13 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 commented: thanks for the reviews! https://github.com/llvm/llvm-project/pull/71328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata (PR #71328)

2023-11-13 Thread Mingming Liu via cfe-commits
@@ -47,6 +47,21 @@ using namespace llvm; +// https://llvm.org/docs/CommandGuide/llvm-profdata.html has documentations +// on each subcommand. +cl::SubCommand +ShowSubcommand("show", + "Takes a profile data file and displays the profiles");

[llvm] [clang] [clang-tools-extra] [nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata (PR #71328)

2023-11-13 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/71328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [mlir] [clang] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-13 Thread Sang Ik Lee via cfe-commits
@@ -0,0 +1,31 @@ +//===- SPIRVToLLVMIRTranslation.h - SPIRV to LLVM IR *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm] [clang-tools-extra] [mlir] [clang] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-13 Thread Sang Ik Lee via cfe-commits
@@ -0,0 +1,54 @@ +// RUN: mlir-opt %s -pass-pipeline='builtin.module(spirv-attach-target{ver=v1.0

[llvm] [clang-tools-extra] [mlir] [clang] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-13 Thread Sang Ik Lee via cfe-commits
@@ -0,0 +1,31 @@ +//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

  1   2   3   4   5   >