https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/72654
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/3] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 44af5924b1cbbb395e7e71250a5445053c4ec4a3
7662d4f177d32c3159c1c48b11ce3884e4ea78c8 --
llvmbot wrote:
@llvm/pr-subscribers-llvm-analysis
Author: Shahid Iqbal (shahidiqbal13)
Changes
This issue is raised by @DrTodd13
The code in include/llvm/Analysis/DOTGraphTraitsPass.h will exceed most normal
file system's maximum filename length of 255 if, e.g., the function's name is
https://github.com/shahidiqbal13 created
https://github.com/llvm/llvm-project/pull/72654
This issue is raised by @DrTodd13
The code in include/llvm/Analysis/DOTGraphTraitsPass.h will exceed most normal
file system's maximum filename length of 255 if, e.g., the function's name is
that length.
usx95 wrote:
Thank you everyone for the review.
https://github.com/llvm/llvm-project/pull/71945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/71945
>From 89a2d60fc012742a74a008fb77213bcd47734503 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 10 Nov 2023 15:10:44 +0100
Subject: [PATCH 01/13] [coroutines] Introduce [[clang::coro_return_type]] and
@@ -300,6 +300,11 @@ Attribute Changes in Clang
to reduce the size of the destroy functions for coroutines which are known to
be destroyed after having reached the final suspend point.
+- Clang now introduced ``[[clang::coro_return_type]]`` and
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/70234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Erich Keane
Date: 2023-11-17T06:29:02-08:00
New Revision: ff219ea9ca80f46ff85dbdb94622ffb319a0d237
URL:
https://github.com/llvm/llvm-project/commit/ff219ea9ca80f46ff85dbdb94622ffb319a0d237
DIFF:
https://github.com/llvm/llvm-project/commit/ff219ea9ca80f46ff85dbdb94622ffb319a0d237.diff
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s
erichkeane wrote:
Typically we find a similar test file and put it there, just wrapped in a
namespace for the github issue.
https://github.com/llvm/llvm-project/pull/72346
https://github.com/erichkeane commented:
I don't have a great feel if this is the right fix, but if it doesn't break
anything in the tests, and does fix something, this is likely acceptable for
now.
This DOES need a release note, and as Shafik says: this should likely be placed
in an
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/72544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Joseph Huber
Date: 2023-11-17T08:26:20-06:00
New Revision: 9c0e64999b23046d0b8987a48ddc41a4c6129f9d
URL:
https://github.com/llvm/llvm-project/commit/9c0e64999b23046d0b8987a48ddc41a4c6129f9d
DIFF:
https://github.com/llvm/llvm-project/commit/9c0e64999b23046d0b8987a48ddc41a4c6129f9d.diff
https://github.com/OutOfCache closed
https://github.com/llvm/llvm-project/pull/72381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) {
<< FixItHint::CreateInsertion(P.first, "self->");
}
+void Sema::CheckCoroutineWrapper(FunctionDecl *FD) {
+ if (!FD || getCurFunction()->isCoroutine())
usx95 wrote:
Moved
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/71945
>From 89a2d60fc012742a74a008fb77213bcd47734503 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 10 Nov 2023 15:10:44 +0100
Subject: [PATCH 01/12] [coroutines] Introduce [[clang::coro_return_type]] and
https://github.com/JonChesterfield approved this pull request.
Test change is suspect for a patch claiming NFC but it looks like the change is
harmless. Thanks for separating refactor from functional change
https://github.com/llvm/llvm-project/pull/72544
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/71945
>From 89a2d60fc012742a74a008fb77213bcd47734503 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 10 Nov 2023 15:10:44 +0100
Subject: [PATCH 01/11] [coroutines] Introduce [[clang::coro_return_type]] and
@@ -0,0 +1,117 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only
-verify -Wall -Wextra
+#include "Inputs/std-coroutine.h"
+
+using std::suspend_always;
+using std::suspend_never;
+
+
+template struct [[clang::coro_return_type]] Gen {
+ struct
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/71945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov approved this pull request.
LGTM assuming the `getCurFunction()` comment is addressed in some form (moving
it to callers or adding an assertion)
Thanks for the change!
https://github.com/llvm/llvm-project/pull/71945
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) {
<< FixItHint::CreateInsertion(P.first, "self->");
}
+void Sema::CheckCoroutineWrapper(FunctionDecl *FD) {
+ if (!FD || getCurFunction()->isCoroutine())
ilya-biryukov
https://github.com/budimirarandjelovicsyrmia updated
https://github.com/llvm/llvm-project/pull/70307
From c9b85c8e435790d8b4a42340f3963d852e7d65ae Mon Sep 17 00:00:00 2001
From: budimirarandjelovicsyrmia
Date: Thu, 26 Oct 2023 10:39:52 +0200
Subject: [PATCH] [clang] Emit bad shift warnings
https://github.com/jsjodin requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/72638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp ,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp ,
+
https://github.com/jsjodin edited
https://github.com/llvm/llvm-project/pull/72638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) {
<< FixItHint::CreateInsertion(P.first, "self->");
}
+void Sema::CheckCoroutineWrapper(FunctionDecl *FD) {
+ if (!FD || getCurFunction()->isCoroutine())
usx95 wrote:
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/72389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Egor Zhdan
Date: 2023-11-17T13:28:51Z
New Revision: f049395fc8d6d8bbbc711c7a2ce293210c580240
URL:
https://github.com/llvm/llvm-project/commit/f049395fc8d6d8bbbc711c7a2ce293210c580240
DIFF:
https://github.com/llvm/llvm-project/commit/f049395fc8d6d8bbbc711c7a2ce293210c580240.diff
LOG:
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/72644
>From d3be2f228ce9d395e539a8827192da3f9b1be676 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Tue, 13 Sep 2022 18:29:34 +0200
Subject: [PATCH] [Clang][C++26] Implement Pack Indexing (P2662R3).
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/71945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -300,6 +300,11 @@ Attribute Changes in Clang
to reduce the size of the destroy functions for coroutines which are known to
be destroyed after having reached the final suspend point.
+- Clang now introduced ``[[clang::coro_return_type]]`` and
@@ -0,0 +1,117 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only
-verify -Wall -Wextra
+#include "Inputs/std-coroutine.h"
+
+using std::suspend_always;
+using std::suspend_never;
+
+
+template struct [[clang::coro_return_type]] Gen {
+ struct
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) {
<< FixItHint::CreateInsertion(P.first, "self->");
}
+void Sema::CheckCoroutineWrapper(FunctionDecl *FD) {
+ if (!FD || getCurFunction()->isCoroutine())
ilya-biryukov
@@ -0,0 +1,117 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only
-verify -Wall -Wextra
+#include "Inputs/std-coroutine.h"
+
+using std::suspend_always;
+using std::suspend_never;
+
+
+template struct [[clang::coro_return_type]] Gen {
+ struct
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) {
<< FixItHint::CreateInsertion(P.first, "self->");
}
+void Sema::CheckCoroutineWrapper(FunctionDecl *FD) {
+ if (!FD || getCurFunction()->isCoroutine())
+return;
+ RecordDecl *RD =
https://github.com/ilya-biryukov commented:
Thanks, I have a few small NIT (but feel free to ignore any number of them).
I do have a major question about the use of `getCurFunction()->isCoroutine()`,
see the corresponding comment.
https://github.com/llvm/llvm-project/pull/71945
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/71945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlos4242 wrote:
@efriedma-quic Cool. So it sounds like it's worth parking this for now, until
Kuba's work #71986 is merged?
@rjmccall I'm not 100% sure I understand? The existing code in AVR.cpp handles
the standard AVR ABI, which has a few simple rules based on GCC behaviour. Here
we are
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp ,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp ,
+
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp ,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp ,
+
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/72638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/skatrak commented:
Thanks for this work, Dominik. It LGTM, but please wait for another review
before merging. I have a couple of suggestions for small improvements, but let
me know if they would take significant effort to address, as I'm not completely
familiar with that
kadircet wrote:
Yes, the current logic that finds insertion point wont work in presence of anon
namespaces.
We normally do some pseudo parsing to find a location to insert the definiton,
but because these are happening inside the main-file now, you can directly make
use of sourcelocations
tru wrote:
> Thanks for trying it on 17.x. We can't backport it then.
Any idea if there is another workaround or fix that we could do to target 17.x?
18 is still pretty far off and clang-format for 17 will soon be included in a
lot of downstream tools. Happy to help out fixing it if you have
@@ -11591,6 +11591,10 @@ def err_conflicting_aligned_options : Error <
def err_coro_invalid_addr_of_label : Error<
"the GNU address of label extension is not allowed in coroutines."
>;
+def err_coroutine_return_type : Error<
ilya-biryukov wrote:
This makes
ckandeler wrote:
> Would you mind evolving the patch (and the infra) to work for
> method-definitions inside anon namespaces?
Of course not; I didn't even now it wasn't working.
I suppose the main point is to determine the insertion location such that it is
still within the original
@@ -0,0 +1,109 @@
+//===--- UseStartsEndsWithCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,109 @@
+//===--- UseStartsEndsWithCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/PiotrZSL commented:
Looks good. Minor cleanup and could land.
https://github.com/llvm/llvm-project/pull/72385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,37 @@
+//===--- UseStartsEndsWithCheck.h - clang-tidy --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,37 @@
+//===--- UseStartsEndsWithCheck.h - clang-tidy --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,151 @@
+// RUN: %check_clang_tidy -std=c++20 %s performance-use-starts-ends-with %t --
\
+// RUN: -- -isystem %clang_tidy_headers
+
+#include
+
+std::string foo(std::string);
+std::string bar();
+
+#define A_MACRO(x, y) ((x) == (y))
+#define STR(x) std::string(x)
+
@@ -0,0 +1,109 @@
+//===--- UseStartsEndsWithCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ec42d547eba5c0ad0bddbecc8902d35383968e78
ac0f8313637763fe0ffcaf7f45cf803babe1b65b --
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: cor3ntin (cor3ntin)
Changes
https://isocpp.org/files/papers/P2662R3.pdf
Because there is a slight chance the syntax might change slightly (see
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2994r0.html), the
feature is
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang-modules
Author: cor3ntin (cor3ntin)
Changes
https://isocpp.org/files/papers/P2662R3.pdf
Because there is a slight chance the syntax might change slightly (see
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/72644
https://isocpp.org/files/papers/P2662R3.pdf
Because there is a slight chance the syntax might change slightly (see
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2994r0.html), the
feature is not
kadircet wrote:
Thanks! I believe the idea is great, but I am not really sure if this is useful
enough without handling anon namespaces properly. It's very rare that someone
has a class/struct in a cc file, that isn't in an anon-namespace.
Would you mind evolving the patch (and the infra) to
Hi
Please add me to a collaborator list , since I cannot assign an issue to
myself. I just want to ensure that no one works that particular issue.
My github handle is : * shahidiqbal13*
Regards
Shahid Iqbal
___
cfe-commits mailing list
@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry )
{
registerLLVMDialectTranslation(registry);
registerNVVMDialectTranslation(registry);
registerROCDLDialectTranslation(registry);
+ registerSPIRVDialectTranslation(registry);
https://github.com/momchil-velikov updated
https://github.com/llvm/llvm-project/pull/68993
>From b42de31d5584cddb90c22c94e9d971feaaf0b624 Mon Sep 17 00:00:00 2001
From: Momchil Velikov
Date: Wed, 11 Oct 2023 17:22:51 +0100
Subject: [PATCH] [clang][AArch64] Pass down stack clash protection
owenca wrote:
> @owenca I picked da1b1fba5cfd41521a840202d8cf4c3796c5e10b on top of the 17.x
> branch and my test case was not fixed, it still crashes in the same way as
> described in #72628
Thanks for trying it on 17.x. We can't backport it then.
https://github.com/DominikAdamski updated
https://github.com/llvm/llvm-project/pull/72638
>From e5d339c24193e4e37013b3b25460009418d6ce6d Mon Sep 17 00:00:00 2001
From: Dominik Adamski
Date: Fri, 17 Nov 2023 03:02:49 -0600
Subject: [PATCH] [Flang] Add code-object-version option
Information
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/72385
>From 7a9703f27897af0846d272ca7393bc72eff11e55 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Wed, 15 Nov 2023 01:13:10 -0800
Subject: [PATCH] [clang-tidy] Add new performance-use-starts-ends-with
https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/72567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2023-11-16T15:00:09-08:00
New Revision: f0ad9ea36ad65cec8c5e5d1d59c00192b87f287d
URL:
https://github.com/llvm/llvm-project/commit/f0ad9ea36ad65cec8c5e5d1d59c00192b87f287d
DIFF:
https://github.com/llvm/llvm-project/commit/f0ad9ea36ad65cec8c5e5d1d59c00192b87f287d.diff
Author: Jonathan Thackray
Date: 2023-11-16T22:08:58Z
New Revision: 066c4524bc1d91b49048e7f05dc6e045bb3c9eef
URL:
https://github.com/llvm/llvm-project/commit/066c4524bc1d91b49048e7f05dc6e045bb3c9eef
DIFF:
https://github.com/llvm/llvm-project/commit/066c4524bc1d91b49048e7f05dc6e045bb3c9eef.diff
Author: Fangrui Song
Date: 2023-11-16T13:48:04-08:00
New Revision: ae623d16d50c9f12de7ae7ac1aa11c9d6857e081
URL:
https://github.com/llvm/llvm-project/commit/ae623d16d50c9f12de7ae7ac1aa11c9d6857e081
DIFF:
https://github.com/llvm/llvm-project/commit/ae623d16d50c9f12de7ae7ac1aa11c9d6857e081.diff
Author: PiJoules
Date: 2023-11-16T13:11:15-08:00
New Revision: b2d62c9a58433e2a2ca8d2c9cd6b0b612dca2e76
URL:
https://github.com/llvm/llvm-project/commit/b2d62c9a58433e2a2ca8d2c9cd6b0b612dca2e76
DIFF:
https://github.com/llvm/llvm-project/commit/b2d62c9a58433e2a2ca8d2c9cd6b0b612dca2e76.diff
@@ -0,0 +1,109 @@
+//===--- UseStartsEndsWithCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -12,4 +12,4 @@
typedef __PTRDIFF_TYPE__ ptrdiff_t;
typedef __SIZE_TYPE__ size_t;
-#endif _STDDEF_H_
+#endif // _STDDEF_H_
nicovank wrote:
This was just issuing a warning in some tests.
https://github.com/llvm/llvm-project/pull/72385
nicovank wrote:
Major changes:
- Now matching on any class that has a `starts_with`, `startsWith`, or
`startswith` function. This is done in order (prioritising functions in
subclasses, but this could be changed). Experimenting on making this an option,
not sure it's worth it without
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/72385
>From ddac6dc91c443bf81d4b6cc3f75686ea56801094 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Wed, 15 Nov 2023 01:13:10 -0800
Subject: [PATCH] [clang-tidy] Add new performance-use-starts-ends-with
https://github.com/OutOfCache updated
https://github.com/llvm/llvm-project/pull/72381
>From 00d0f99207242befc8022031ccd8faf573cbf014 Mon Sep 17 00:00:00 2001
From: Jessica Del
Date: Tue, 14 Nov 2023 22:17:26 +0100
Subject: [PATCH 1/5] [AMDGPU] - Add constant folding for s_quadmask
If the
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123235/new/
https://reviews.llvm.org/D123235
___
cfe-commits mailing list
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a67b85ef63c7ec29c2076294e3f7c7f923144a53
eb2710b0f736860dac62cc2ff8907fcefc64a8d6 --
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-flang-driver
Author: Dominik Adamski (DominikAdamski)
Changes
Information about code object version can be configured by the user for AMD GPU
target and it needs to be placed in LLVM IR generated by Flang.
Information
https://github.com/DominikAdamski created
https://github.com/llvm/llvm-project/pull/72638
Information about code object version can be configured by the user for AMD GPU
target and it needs to be placed in LLVM IR generated by Flang.
Information about code object version in MLIR generated by
zufuliu wrote:
Duplicate of #72538.
https://github.com/llvm/llvm-project/pull/71170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OutOfCache updated
https://github.com/llvm/llvm-project/pull/72381
>From 00d0f99207242befc8022031ccd8faf573cbf014 Mon Sep 17 00:00:00 2001
From: Jessica Del
Date: Tue, 14 Nov 2023 22:17:26 +0100
Subject: [PATCH 1/4] [AMDGPU] - Add constant folding for s_quadmask
If the
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
hnrklssn wrote:
LGTM, but someone else should approve also.
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tru wrote:
@owenca I picked da1b1fba5cfd41521a840202d8cf4c3796c5e10b on top of the 17.x
branch and my test case was not fixed, it still crashes in the same way as
described in #72628
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits
hnrklssn wrote:
> > What differentiates the DecompositionDecl such that we need to mark the
> > decl invalid when there's an error in the RHS, while for other decls we
> > don't? It seems inconsistent.
>
>
>
> DecompositionDecl (aka structure binding) is special here, a legal
>
tru wrote:
> We probably should backport it to 17.0.6. What do you all think? @tru
Yep - seems like a good and small fix to have in 17.x
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: SR_team (sr-tream)
Changes
Currently, impossible to remove irrelevant files from CDB via LSP notification
`workspace/didChangeConfiguration`. This PR change clangd behavior to remove
file from CDB, when LSP pass empty parameters for
https://github.com/sr-tream created
https://github.com/llvm/llvm-project/pull/72635
Currently, impossible to remove irrelevant files from CDB via LSP notification
`workspace/didChangeConfiguration`. This PR change clangd behavior to remove
file from CDB, when LSP pass empty parameters for
Author: Kadir Cetinkaya
Date: 2023-11-17T11:32:51+01:00
New Revision: 7aaa86b28ddc3deded6e357b27f2bbebb97a3864
URL:
https://github.com/llvm/llvm-project/commit/7aaa86b28ddc3deded6e357b27f2bbebb97a3864
DIFF:
https://github.com/pmatos updated
https://github.com/llvm/llvm-project/pull/71540
>From 31adeded0d1767e1ce43fbfcba5fe72c4e34121d Mon Sep 17 00:00:00 2001
From: Paulo Matos
Date: Tue, 7 Nov 2023 08:28:36 +0100
Subject: [PATCH 1/4] [WebAssembly] Refactor Wasm Reference Types as
TargetExtType
@@ -492,11 +492,13 @@ void check_required_cast() {
void check_cast_behavior(OSObject *obj) {
OSArray *arr1 = OSDynamicCast(OSArray, obj);
- clang_analyzer_eval(arr1 == obj); // expected-warning{{TRUE}}
-// expected-note@-1{{TRUE}}
-
hokein wrote:
> What differentiates the DecompositionDecl such that we need to mark the decl
> invalid when there's an error in the RHS, while for other decls we don't? It
> seems inconsistent.
DecompositionDecl (aka structure binding) is special here, a legal
DecompositionDecl must be
owenca wrote:
We probably should backport it to 17.0.6. What do you all think? @tru
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
Aaron suggested to me offline that `IsInterestingIdentifier` that I recently
changed could be implemented in a simpler way retaining the intent. That's what
the latest update about.
https://github.com/llvm/llvm-project/pull/71709
___
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/72520
>From efdf321e9447e8b3f1c27ccdf6da842107deb6dd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 16 Nov 2023 06:36:41 -0800
Subject: [PATCH 1/3] [clang-format] Fix crashes in AlignArrayOfStructures
Fixed
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/71709
>From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 8 Nov 2023 20:30:37 +0300
Subject: [PATCH 1/3] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID`
This
@@ -13540,6 +13540,15 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr
*Init, bool DirectInit) {
CreateRecoveryExpr(Init->getBeginLoc(), Init->getEndLoc(), Args);
if (RecoveryExpr.get())
VDecl->setInit(RecoveryExpr.get());
+ // In general,
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/72428
>From ac06843b97cb93d476f0bf8e0474fa270d80631f Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Wed, 15 Nov 2023 20:31:12 +0100
Subject: [PATCH 1/2] [clang][AST] Invalidate DecompositionDecl if it has
invalid
https://github.com/santhoshe447 edited
https://github.com/llvm/llvm-project/pull/72631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bj=C3=B6rn?= Svensson
Message-ID:
In-Reply-To:
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/72553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 300 of 327 matches
Mail list logo
