https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/68597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/huixie90 updated
https://github.com/llvm/llvm-project/pull/68597
>From 617d6d23b2f861cd6dceb82f54a2685059b6 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 14 Sep 2023 09:09:29 +
Subject: [PATCH] [flang] Enable alias tags pass by default
Enable by default when o
owenpan accepted this revision.
owenpan added a comment.
This revision is now accepted and ready to land.
LGTM except the final nits.
Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:48
+const FormatToken *BeginTok, const FormatToken *EndTok) const {
+ // I
https://github.com/JonPsson1 updated
https://github.com/llvm/llvm-project/pull/72977
>From 000dcadc0fd118df643e3f2ecbe5fcbb2f8eaab0 Mon Sep 17 00:00:00 2001
From: Jonas Paulsson
Date: Tue, 21 Nov 2023 12:10:03 +0100
Subject: [PATCH 1/4] Refactor ASTContext::getDeclAlign() (NFC)
---
clang/lib/
dmgreen added a comment.
I hadn't realized this came from someone at Arm. The performance results I had
were overall roughly flat, with some improvements and regressions. I think
there were still some people working through some fixes for some of the
knock-on effects but with those nothing larg
@@ -85,6 +85,19 @@ class CodeGenOptions : public CodeGenOptionsBase {
RK_WithPattern, // Remark pattern specified via '-Rgroup=regexp'.
};
+ /// \brief Enumeration value for AMDGPU code object version, which is the
+ /// code object version times 100.
+ enum class Cod
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
philnik777 wrote:
> > @PiotrZSL could you use the "Start review" button to avoid spamming people
> > with dozens of E-Mails for a single review?
>
> @philnik777 If you prefer not to receive notifications, simply unsubscribe.
> Spe
@@ -1708,6 +1710,19 @@ bool
SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction &MF,
}
++Iter;
+if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) {
+ auto Builder =
+ BuildMI(Block, Iter, DebugLoc(), TII->get(AMDGPU::S_WAITCNT))
+
@@ -1708,6 +1710,19 @@ bool
SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction &MF,
}
++Iter;
+if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) {
+ auto Builder =
+ BuildMI(Block, Iter, DebugLoc(), TII->get(AMDGPU::S_WAITCNT))
+
@@ -1847,6 +1862,7 @@ bool
SIInsertWaitcnts::runOnMachineFunction(MachineFunction &MF) {
TrackedWaitcntSet.clear();
BlockInfos.clear();
+
jayfoad wrote:
Remove this
https://github.com/llvm/llvm-project/pull/68932
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
… Enumerations
https://isocpp.org/files/papers/P2864R2.pdf
---
Full diff: https://github.com/llvm/llvm-project/pull/73105.diff
5 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+3)
- (modified) cl
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/73105
… Enumerations
https://isocpp.org/files/papers/P2864R2.pdf
>From f548a8e11c75b3157a9337892688f5414234bff8 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Wed, 22 Nov 2023 12:25:20 +0100
Subject: [PATCH] [C
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp &mlirModule,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp &mlirModule,
+
@@ -85,6 +85,19 @@ class CodeGenOptions : public CodeGenOptionsBase {
RK_WithPattern, // Remark pattern specified via '-Rgroup=regexp'.
};
+ /// \brief Enumeration value for AMDGPU code object version, which is the
+ /// code object version times 100.
+ enum class Cod
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp &mlirModule,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp &mlirModule,
+
saiislam wrote:
> (patches like this should probably be broken up - test changes to the
> defaults in lld and llvm for instance don't depend on the change to the clang
> driver which is the only real semantic change in this patch, right? So
> probably only change the semantics of clang, and th
https://github.com/Endilll approved this pull request.
DR test side looks good, except for a small nit.
https://github.com/llvm/llvm-project/pull/73103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/73103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s -verify
-fexceptions -fcxx-exceptions -pedantic-errors \
Endilll wrote:
Is triple necessary for the test?
https://github.com/llvm/llvm-project/pull/73103
_
DominikAdamski wrote:
Done
https://github.com/llvm/llvm-project/pull/72638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp &mlirModule,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp &mlirModule,
+
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp &mlirModule,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp &mlirModule,
+
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
PiotrZSL wrote:
> @PiotrZSL could you use the "Start review" button to avoid spamming people
> with dozens of E-Mails for a single review?
@philnik777 If you prefer not to receive notifications, simply unsubscribe.
Specially if yo
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp &mlirModule,
}
}
+// Add to MLIR code target specific items which are dependent on target
+// configuration specified by the user
+static void addTargetSpecificMLIRItems(mlir::ModuleOp &mlirModule,
+
@@ -0,0 +1,32 @@
+// RUN: %clang --target=s390x-linux -S -emit-llvm -o - %s | FileCheck %s
JonPsson1 wrote:
I found some other align tests there, like arm-alignment.c, so I thought this
should work..?
https://github.com/llvm/llvm-project/pull/72886
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
https://wiki.edg.com/pub/Wg21kona2023/StrawPolls/p2308r1.html
This implements P2308R1 as a DR and resolves CWG2459, CWG2450 and CWG2049.
---
Full diff: https://github.com/llvm/llvm-project/pull/73103.diff
11
https://github.com/DominikAdamski updated
https://github.com/llvm/llvm-project/pull/72638
>From e5d339c24193e4e37013b3b25460009418d6ce6d Mon Sep 17 00:00:00 2001
From: Dominik Adamski
Date: Fri, 17 Nov 2023 03:02:49 -0600
Subject: [PATCH 1/2] [Flang] Add code-object-version option
Information
@@ -1627,28 +1627,20 @@ const llvm::fltSemantics
&ASTContext::getFloatTypeSemantics(QualType T) const {
CharUnits ASTContext::getDeclAlign(const Decl *D, bool ForAlignof) const {
unsigned Align = Target->getCharWidth();
- bool UseAlignAttrOnly = false;
- if (unsigned Alig
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/73103
https://wiki.edg.com/pub/Wg21kona2023/StrawPolls/p2308r1.html
This implements P2308R1 as a DR and resolves CWG2459, CWG2450 and CWG2049.
>From 90a9c92ce532af7c6346a381499780f158cd26ca Mon Sep 17 00:00:00 2001
F
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
philnik777 wrote:
@PiotrZSL could you use the "Start review" button to avoid spamming people with
dozens of E-Mails for a single review?
https://github.com/llvm/llvm-project/pull/73069
__
https://github.com/JonPsson1 updated
https://github.com/llvm/llvm-project/pull/72977
>From 000dcadc0fd118df643e3f2ecbe5fcbb2f8eaab0 Mon Sep 17 00:00:00 2001
From: Jonas Paulsson
Date: Tue, 21 Nov 2023 12:10:03 +0100
Subject: [PATCH 1/3] Refactor ASTContext::getDeclAlign() (NFC)
---
clang/lib/
=?utf-8?q?F=C3=A9lix-Antoine?= Constantin
Message-ID:
In-Reply-To:
https://github.com/PiotrZSL requested changes to this pull request.
Not bad, just few nits.
https://github.com/llvm/llvm-project/pull/73069
___
cfe-commits mailing list
cfe-commits@li
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
@@ -7889,7 +7889,7 @@ AST_POLYMORPHIC_MATCHER(isInline,
AST_POLYMORPHIC_SUPPORTED_TYPES(NamespaceDecl,
if (const auto *NSD = dyn_cast(&Node))
return NSD->isInline();
if (const auto *VD = dyn_cast(&Node))
-
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/
@@ -0,0 +1,32 @@
+// RUN: %clang --target=s390x-linux -S -emit-llvm -o - %s | FileCheck %s
nikic wrote:
Why is this a Driver test rather than a CodeGen test using clang_cc1?
https://github.com/llvm/llvm-project/pull/72886
martinboehme wrote:
Update: I've run some tests on an internal codebase, and with this PR, Crubit's
nullability check sees a reduction in SAT solver timeouts of over 40% and a
reduction in "reached maximum iterations" errors of over 60% -- similar to the
previous more complicated approach in #
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/
@@ -2231,6 +2231,13 @@ static bool CheckLValueConstantExpression(EvalInfo
&Info, SourceLocation Loc,
return false;
}
+ if (Info.getLangOpts().C23) {
+auto *VarD = dyn_cast_or_null(BaseVD);
+if (VarD && VarD->isConstexpr() && !LVal.isNullPointer()) {
+ Info
@@ -8605,6 +8620,27 @@ static bool checkForConflictWithNonVisibleExternC(Sema
&S, const T *ND,
return false;
}
+static bool CheckC23ConstexprVarTypeQualifiers(Sema &SemaRef,
+SourceLocation VarLoc, QualType T)
{
+ if (const auto
@@ -4110,6 +4117,10 @@ static CompleteObject findCompleteObject(EvalInfo &Info,
const Expr *E,
}
bool IsConstant = BaseType.isConstant(Info.Ctx);
+bool ConstexprVar = false;
+if (const auto *VD = dyn_cast_or_null(
tbaederr wrote:
```suggestio
https://github.com/JonPsson1 closed
https://github.com/llvm/llvm-project/pull/72886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jonas Paulsson
Date: 2023-11-22T11:24:45+01:00
New Revision: 2e09ea65c4f9e458ffb31fe63d84a4991704f9e6
URL:
https://github.com/llvm/llvm-project/commit/2e09ea65c4f9e458ffb31fe63d84a4991704f9e6
DIFF:
https://github.com/llvm/llvm-project/commit/2e09ea65c4f9e458ffb31fe63d84a4991704f9e6.diff
to268 wrote:
That's probably because I have still not commit access, but I'll take a look.
https://github.com/llvm/llvm-project/pull/73099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 74cdb8e6f8c88b97204f540601a553b412d1cd56
1d70b7726e7d1f11622a6d5c8246b0737e024c8d --
Fznamznon wrote:
cc @to268 , GitHub doesn't let me add you to the reviewers list.
https://github.com/llvm/llvm-project/pull/73099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
The implementation mostly reuses C++ code paths where possible, including
narrowing check in order to provide diagnostic messages in case initializer for
constexpr variable is not exactly represen
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/73099
The implementation mostly reuses C++ code paths where possible, including
narrowing check in order to provide diagnostic messages in case initializer for
constexpr variable is not exactly representable in targ
@@ -1009,11 +1002,20 @@ let ParentPackage = ENV in {
"standard), which can lead to false positives depending on "
"implementation.",
"false",
- InAlpha>,
+ Released>,
]>,
Documentation
https://github.com/simpal01 closed
https://github.com/llvm/llvm-project/pull/71545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/gamesh411 updated
https://github.com/llvm/llvm-project/pull/71912
From 977e421008c1247d54f4cb67967ed2a353935c03 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?=
Date: Fri, 10 Nov 2023 10:08:58 +0100
Subject: [PATCH 1/2] [analyzer] Move security.cert.env.Inva
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qizhi Hu (jcsxky)
Changes
This patch aims to fix [error in ast-merge to new ast
file](https://github.com/llvm/llvm-project/issues/72783).
`ASTUnit` is put in `for` body and AST nodes would be deallocated by allocator.
Using these nodes la
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/73096
This patch aims to fix [error in ast-merge to new ast
file](https://github.com/llvm/llvm-project/issues/72783).
`ASTUnit` is put in `for` body and AST nodes would be deallocated by allocator.
Using these nodes la
Author: Sander de Smalen
Date: 2023-11-22T08:52:53Z
New Revision: 81b7f115fb272ef6fd6967f4121b64814b4bcf10
URL:
https://github.com/llvm/llvm-project/commit/81b7f115fb272ef6fd6967f4121b64814b4bcf10
DIFF:
https://github.com/llvm/llvm-project/commit/81b7f115fb272ef6fd6967f4121b64814b4bcf10.diff
L
https://github.com/sdesmalen-arm closed
https://github.com/llvm/llvm-project/pull/72979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martinboehme wrote:
> +1 for the simpler approach. I have a high-level question about the stability
> of the locations, its effect on convergence.
Answered in the inline comment.
> But I am happy with the `ExprToVal` part of the simple patch.
SG! Then let's continue the discussion on #72985?
https://github.com/martinboehme edited
https://github.com/llvm/llvm-project/pull/72850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -311,7 +318,10 @@ computeBlockInputState(const CFGBlock &Block,
AnalysisContext &AC) {
}
}
- JoinedStateBuilder Builder(AC);
+ // When performing the join, only retain state for those expressions that are
+ // consumed by this block. This avoids performing joins a
301 - 361 of 361 matches
Mail list logo
