[clang-tools-extra] [libc] [clang] [libcxx] [compiler-rt] [llvm] [flang] [NFC][asan] Inline ENSURE_ASAN_INITED macro (PR #74174)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/74174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] [clang] [libcxx] [compiler-rt] [llvm] [flang] [NFC][asan] Replace a few `#if SANITIZER_APPLE` with `if (SANITIZER_APPLE` (PR #74173)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/74173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [compiler-rt] [flang] [clang] [libcxx] [clang-tools-extra] [libc] [NFC][asan] Replace a few `#if SANITIZER_APPLE` with `if (SANITIZER_APPLE` (PR #74173)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/74173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [compiler-rt] [flang] [clang] [libcxx] [clang-tools-extra] [libc] [NFC][asan] Replace AsanInited/ENSURE_ASAN_INITED with TryAsanInitFromRtl (PR #74172)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/74172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Thread safety analysis: Fix a bug in handling temporary constructors (PR #74020)

2023-12-04 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/74020 >From 00083bb1573561361ff0782f425ebec2a5218f34 Mon Sep 17 00:00:00 2001 From: ziqingluo-90 Date: Mon, 4 Dec 2023 14:37:10 -0800 Subject: [PATCH] Thread safety analysis: Fix a bug in handling temporary

[clang] [llvm] [clang] NFC: Deprecate `FileEntry::getName()` (PR #68157)

2023-12-04 Thread Ben Barham via cfe-commits
bnbarham wrote:  thanks @jansvoboda11 for slogging through all these! https://github.com/llvm/llvm-project/pull/68157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1157bee - Revert "[clang][modules] Reset codegen options. (#74006)"

2023-12-04 Thread Juergen Ributzka via cfe-commits
Author: Juergen Ributzka Date: 2023-12-04T14:28:22-08:00 New Revision: 1157bee5ce2c7acb803cda5003b2ea9d0ed962e2 URL: https://github.com/llvm/llvm-project/commit/1157bee5ce2c7acb803cda5003b2ea9d0ed962e2 DIFF:

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-12-04 Thread Artem Belevich via cfe-commits
@@ -70,6 +70,9 @@ __DEVICE__ double floor(double); __DEVICE__ float floor(float); __DEVICE__ double fma(double, double, double); __DEVICE__ float fma(float, float, float); +#ifdef _MSC_VER +__DEVICE__ long double fma(long double, long double, long double);

[clang] [flang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-04 Thread Thorsten Schütt via cfe-commits
tschuett wrote: Are you going to add an entry to the [Release Nodes](https://github.com/llvm/llvm-project/blob/main/flang/docs/ReleaseNotes.md)? https://github.com/llvm/llvm-project/pull/74377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Andrzej Warzyński (banach-space) Changes This patch renames `flang-new` as `flang`. Similarly to Clang, Flang's driver executable will be called: * `flang-MAJOR_VERSION` A symlink called `flang`

[flang] [clang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-04 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space created https://github.com/llvm/llvm-project/pull/74377 This patch renames `flang-new` as `flang`. Similarly to Clang, Flang's driver executable will be called: * `flang-` A symlink called `flang` pointing at `flang-` will be created at build time. This is

[clang] [libclang/python] Fix some minor typos (PR #74292)

2023-12-04 Thread Craig Hesling via cfe-commits
https://github.com/linux4life798 edited https://github.com/llvm/llvm-project/pull/74292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Reset codegen options. (PR #74006)

2023-12-04 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka closed https://github.com/llvm/llvm-project/pull/74006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fef1854 - [clang][modules] Reset codegen options. (#74006)

2023-12-04 Thread via cfe-commits
Author: Juergen Ributzka Date: 2023-12-04T13:54:57-08:00 New Revision: fef1854318bd797c1f8a141d4b45b113b04860d1 URL: https://github.com/llvm/llvm-project/commit/fef1854318bd797c1f8a141d4b45b113b04860d1 DIFF:

[clang] [libclang/python] Fix some minor typos (PR #74292)

2023-12-04 Thread Craig Hesling via cfe-commits
https://github.com/linux4life798 edited https://github.com/llvm/llvm-project/pull/74292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Reset codegen options. (PR #74006)

2023-12-04 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/74006 >From 416c233bf334fd96ec6e5b54971f3ae5c6b99843 Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 6 Nov 2023 14:22:02 -0800 Subject: [PATCH] [clang][modules] Reset codegen options. CodeGen options do

[clang] [clang][modules] Reset codegen options. (PR #74006)

2023-12-04 Thread Juergen Ributzka via cfe-commits
ributzka wrote: Thanks for the reviews https://github.com/llvm/llvm-project/pull/74006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Reset codegen options. (PR #74006)

2023-12-04 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM, nice! https://github.com/llvm/llvm-project/pull/74006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in `git-clang-format --binary` (PR #74293)

2023-12-04 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/74293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 78940a4 - [clang-format] Fix a bug in `git-clang-format --binary` (#74293)

2023-12-04 Thread via cfe-commits
Author: Owen Pan Date: 2023-12-04T13:49:23-08:00 New Revision: 78940a4e1f7f484d8a2dd0c646e288d6a5bf2f81 URL: https://github.com/llvm/llvm-project/commit/78940a4e1f7f484d8a2dd0c646e288d6a5bf2f81 DIFF: https://github.com/llvm/llvm-project/commit/78940a4e1f7f484d8a2dd0c646e288d6a5bf2f81.diff

[clang] [clang][NFC] Refactor expected directives in C++ DRs 500-599 (PR #74373)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch continues the work started with ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding PR for details. --- Patch is 47.59 KiB, truncated to 20.00 KiB below, full

[clang] [clang][NFC] Refactor expected directives in C++ DRs 500-599 (PR #74373)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: This PR is created to check the patch against CI. https://github.com/llvm/llvm-project/pull/74373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Refactor expected directives in C++ DRs 500-599 (PR #74373)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/74373 This patch continues the work started with ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding PR for details. >From 1e5ede1925b8cfdae93415abfddb930aaaf3241e Mon Sep 17 00:00:00

[clang] e77bfaa - [clang][NFC] Fill in historical data on when C++ DRs 500-599 were fixed

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-12-05T00:42:13+03:00 New Revision: e77bfaaf9d66748fc2dc3a710a0c9b4665dd3034 URL: https://github.com/llvm/llvm-project/commit/e77bfaaf9d66748fc2dc3a710a0c9b4665dd3034 DIFF:

[clang] [clang][modules] Reset codegen options. (PR #74006)

2023-12-04 Thread Juergen Ributzka via cfe-commits
@@ -4770,9 +4770,20 @@ std::string CompilerInvocation::getModuleHash() const { // When compiling with -gmodules, also hash -fdebug-prefix-map as it // affects the debug info in the PCM. - if (getCodeGenOpts().DebugTypeExtRefs) + if (getHeaderSearchOpts().ModuleFormat ==

[clang] [clang][modules] Reset codegen options. (PR #74006)

2023-12-04 Thread Juergen Ributzka via cfe-commits
@@ -515,6 +430,8 @@ ENUM_CODEGENOPT(ZeroCallUsedRegs, llvm::ZeroCallUsedRegs::ZeroCallUsedRegsKind, /// non-deleting destructors. (No effect on Microsoft ABI.) CODEGENOPT(CtorDtorReturnThis, 1, 0) +#include "DebugOptions.def" ributzka wrote: I added the

[clang] [clang][modules] Reset codegen options. (PR #74006)

2023-12-04 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/74006 >From a6ea5e2da353ba006083082976065c9a8a988cbc Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 6 Nov 2023 14:22:02 -0800 Subject: [PATCH 1/2] [clang][modules] Reset codegen options. CodeGen options

[clang] [Driver] Mark -arch as TargetSpecific (PR #74365)

2023-12-04 Thread James Y Knight via cfe-commits
https://github.com/jyknight approved this pull request. https://github.com/llvm/llvm-project/pull/74365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve bit-field in ref NTTP diagnostic (PR #71077)

2023-12-04 Thread Andrey Ali Khan Bolshakov via cfe-commits
https://github.com/bolshakov-a updated https://github.com/llvm/llvm-project/pull/71077 >From e5ad8f5b00a297ef745e1b9341df32b80a7c6b77 Mon Sep 17 00:00:00 2001 From: Bolshakov Date: Thu, 2 Nov 2023 19:20:27 +0300 Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic Prior to this,

[clang] [clang] Enhance handling of Apple-specific '-arch'/'-target' option values (PR #72821)

2023-12-04 Thread James Y Knight via cfe-commits
jyknight wrote: I don't think this is a good idea. Not only is that weird to magically switch to an apple build from a non-apple platform, this is also not even a particularly useful behavior for an Apple platform, where "darwin" is basically deprecated, and you're supposed to use a target

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-12-04 Thread Julian Schmidt via cfe-commits
5chmidti wrote: I fetched from the wrong remote. Conflicts are resolved. The options docs were added in 284fa1b94ef72c29f13a2ec50ca76b429c842b0c https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-12-04 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Force push to resolve conflicts https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-12-04 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,58 @@ +.. title:: clang-tidy - modernize-use-std-numbers + +modernize-use-std-numbers += + +Finds constants and function calls to math functions that can be replaced +with c++20's mathematical constants from the ``numbers`` header and offers

[clang] [clang] Enhance handling of Apple-specific '-arch'/'-target' option values (PR #72821)

2023-12-04 Thread Fangrui Song via cfe-commits
MaskRay wrote: `-arch ` is also related to universal binary that many other targets don't support (and they likely don't endorse such an approach). For ELF we should definitely encourage `--target=` for cross compilation. (`-target ` has been deprecated since Clang 3.2). Picking a default

[clang] [Driver] Mark -arch as TargetSpecific (PR #74365)

2023-12-04 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/74365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Mark -arch as TargetSpecific (PR #74365)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes `-arch` is a Darwin-specific option that is ignored for other targets and not known by GCC. ``` % clang -arch arm64 -c a.c clang: warning: argument unused during compilation:

[clang] [Driver] Mark -arch as TargetSpecific (PR #74365)

2023-12-04 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/74365 `-arch` is a Darwin-specific option that is ignored for other targets and not known by GCC. ``` % clang -arch arm64 -c a.c clang: warning: argument unused during compilation: '-arch arm64'

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-12-04 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/72107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-12-04 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. I wish we could clean up `checkLocation` to work as expected for all cases. It is more future proof in the sense that if C++ introduces new kinds of statements or expressions that could index into something (like multi-dimensional

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-12-04 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,58 @@ +.. title:: clang-tidy - modernize-use-std-numbers + +modernize-use-std-numbers += + +Finds constants and function calls to math functions that can be replaced +with c++20's mathematical constants from the ``numbers`` header and offers

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-12-04 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM, this should be merged so other llvm users could test it. As check is complicated I expect that there can be some false-positives or issues reported when llvm 18 would release. https://github.com/llvm/llvm-project/pull/66583

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-12-04 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-12-04 Thread Evgeny Mankov via cfe-commits
@@ -70,6 +70,9 @@ __DEVICE__ double floor(double); __DEVICE__ float floor(float); __DEVICE__ double fma(double, double, double); __DEVICE__ float fma(float, float, float); +#ifdef _MSC_VER +__DEVICE__ long double fma(long double, long double, long double);

[clang] [llvm] [clang] NFC: Deprecate `FileEntry::getName()` (PR #68157)

2023-12-04 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/68157 >From e3a96bef47d029e1109dcad51840bab672c7351c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 3 Oct 2023 13:40:07 -0700 Subject: [PATCH 1/2] [clang] NFC: Deprecate `FileEntry::getName()` ---

[clang] [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses. (PR #68618)

2023-12-04 Thread Yonggang Luo via cfe-commits
lygstate wrote: ping for merge https://github.com/llvm/llvm-project/pull/68618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][tidy] Ensure rewriter has the correct CWD (PR #67839)

2023-12-04 Thread Piotr Zegar via cfe-commits
@@ -227,6 +227,14 @@ class ErrorReporter { llvm::errs() << "Can't apply replacements for file " << File << "\n"; } } + + auto BuildDir = Context.getCurrentBuildDirectory(); PiotrZSL wrote: I think you may need to do what is done

[clang] [clang-format] Fix a bug in `git-clang-format --binary` (PR #74293)

2023-12-04 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/74293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve bit-field in ref NTTP diagnostic (PR #71077)

2023-12-04 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: I want just note that it is probably not an improvement from the user's point of view, just a change of wording. https://github.com/llvm/llvm-project/pull/71077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [llvm] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

2023-12-04 Thread Jon Roelofs via cfe-commits
@@ -4178,8 +4184,22 @@ void CodeGenModule::emitMultiVersionFunctions() { } llvm::Constant *ResolverConstant = GetOrCreateMultiVersionResolver(GD); -if (auto *IFunc = dyn_cast(ResolverConstant)) +if (auto *IFunc = dyn_cast(ResolverConstant)) {

[llvm] [clang] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Nikita Popov via cfe-commits
nikic wrote: > We don't have a `isGuaranteedNotToBeUndef` only function, so that's the only > way. I would leave a fixme, since this call can be removed if we ever manage > to kill undef. I actually added this function earlier today. > @nikic is something like this the right fix? I'd move

[clang] [libc] [flang] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [NFC][asan] Replace AsanInited/ENSURE_ASAN_INITED with TryAsanInitFromRtl (PR #74172)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/74172 >From 0d25d8cfc9de89a538a7ae3ae97ddc8a664a70d5 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Fri, 1 Dec 2023 19:20:28 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=

[clang] [llvm] [clang-tools-extra] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Dani (DanielKristofKiss) Changes AArch64 part of https://github.com/llvm/llvm-project/pull/71706. Default version is now mangled with .default. Resolver for the TargetVersion need to be emitted from the

[libc] [flang] [clang-tools-extra] [llvm] [compiler-rt] [libcxx] [clang] [NFC][asan] Replace AsanInited/ENSURE_ASAN_INITED with TryAsanInitFromRtl (PR #74172)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/74172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

2023-12-04 Thread via cfe-commits
https://github.com/DanielKristofKiss created https://github.com/llvm/llvm-project/pull/74358 AArch64 part of https://github.com/llvm/llvm-project/pull/71706. Default version is now mangled with .default. Resolver for the TargetVersion need to be emitted from the

[llvm] [clang] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: We don't have a `isGuaranteedNotToBeUndef` only function, so that's the only way. I would leave a fixme, since this call can be removed if we ever manage to kill undef. Thanks for your help!  https://github.com/llvm/llvm-project/pull/72912

[clang] [libc] [flang] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [NFC][ASAN] Replace AsanInitIsRunning with TryAsanInitFromRtl (PR #74171)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/74171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-04 Thread Mingming Liu via cfe-commits
@@ -300,12 +316,8 @@ getIRPGONameForGlobalObject(const GlobalObject , GlobalValue::LinkageTypes Linkage, StringRef FileName) { SmallString<64> Name; - if (llvm::GlobalValue::isLocalLinkage(Linkage)) { -

[clang] [llvm] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Craig Topper via cfe-commits
topperc wrote: @nikic is something like this the right fix ``` diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp index 8c29c242215d..b03a56c922de 100644 --- a/llvm/lib/Analysis/ValueTracking.cpp +++ b/llvm/lib/Analysis/ValueTracking.cpp @@ -235,8 +235,11 @@

[clang] b6d0ee0 - Revert HWASAN failure (#74163)

2023-12-04 Thread Kirill Stoimenov via cfe-commits
Author: Kirill Stoimenov Date: 2023-12-02T04:39:14Z New Revision: b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b URL: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b DIFF: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b.diff

[clang] b6d0ee0 - Revert HWASAN failure (#74163)

2023-12-04 Thread Kirill Stoimenov via cfe-commits
Author: Kirill Stoimenov Date: 2023-12-02T04:39:14Z New Revision: b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b URL: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b DIFF: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b.diff

[clang] b6d0ee0 - Revert HWASAN failure (#74163)

2023-12-04 Thread Kirill Stoimenov via cfe-commits
Author: Kirill Stoimenov Date: 2023-12-02T04:39:14Z New Revision: b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b URL: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b DIFF: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b.diff

[llvm] [libcxx] [compiler-rt] [flang] [clang] [libc] [clang-tools-extra] [NFC][ASAN] Replace AsanInitIsRunning with TryAsanInitFromRtl (PR #74171)

2023-12-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/74171 >From c630b3d042729fa2053866c959e8e05b8ce11267 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Fri, 1 Dec 2023 19:20:23 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=

[llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-04 Thread Mingming Liu via cfe-commits
@@ -246,11 +246,27 @@ std::string InstrProfError::message() const { char InstrProfError::ID = 0; -std::string getPGOFuncName(StringRef RawFuncName, - GlobalValue::LinkageTypes Linkage, +std::string getPGOFuncName(StringRef Name,

[clang] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-04 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/74008 >From 4cb5b087485124a7f2375fdc018b42a0401e6409 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 30 Nov 2023 15:41:37 -0800 Subject: [PATCH 1/3] [PGO][GlobalValue][LTO]In

[clang] [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses. (PR #68618)

2023-12-04 Thread Yonggang Luo via cfe-commits
https://github.com/lygstate updated https://github.com/llvm/llvm-project/pull/68618 >From d1886bab8356262b1305093465658acffb4cafff Mon Sep 17 00:00:00 2001 From: Yonggang Luo Date: Tue, 10 Oct 2023 02:23:34 +0800 Subject: [PATCH] [clang] Fixes compile error that double colon operator cannot

[clang] [llvm] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Craig Topper via cfe-commits
topperc wrote: > Here's a simple-ish example: > > ```llvm > ; Transforms/InstCombine/add.ll > > define i5 @zext_sext_not(i4 %x) { > %zx = zext i4 %x to i5 > %notx = xor i4 %x, 15 > %snotx = sext i4 %notx to i5 > %r = add i5 %zx, %snotx > ret i5 %r > } > => > define i5

[clang] [flang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-04 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm updated https://github.com/llvm/llvm-project/pull/74139 >From 2e41335a7de3d2efa88eacee659172a3b9525e45 Mon Sep 17 00:00:00 2001 From: Michael Klemm Date: Fri, 1 Dec 2023 21:41:44 +0100 Subject: [PATCH 1/6] Add -fno-fortran-main driver option ---

[clang] [clang][Sema] Add -Wswitch-default warning option (PR #73077)

2023-12-04 Thread Aaron Puchert via cfe-commits
aaronpuchert wrote: > Aaron is the real decision maker here Specifically @AaronBallman, not me. https://github.com/llvm/llvm-project/pull/73077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-12-04 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/73756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-12-04 Thread Artem Belevich via cfe-commits
@@ -70,6 +70,9 @@ __DEVICE__ double floor(double); __DEVICE__ float floor(float); __DEVICE__ double fma(double, double, double); __DEVICE__ float fma(float, float, float); +#ifdef _MSC_VER +__DEVICE__ long double fma(long double, long double, long double);

[libc] [compiler-rt] [clang-tools-extra] [clang] [libunwind] [mlir] [lld] [flang] [libcxx] [llvm] [lldb] Fix clang to recognize new C23 modifiers %w and %wf when printing and scanning (PR #71771)

2023-12-04 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/71771 >From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 9 Nov 2023 02:21:46 + Subject: [PATCH 1/4] Fix clang to recognize new C23 modifiers %w and %wf when

[clang] Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg. (PR #74349)

2023-12-04 Thread James Y Knight via cfe-commits
https://github.com/jyknight closed https://github.com/llvm/llvm-project/pull/74349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4d4c30a - Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg. (#74349)

2023-12-04 Thread via cfe-commits
Author: James Y Knight Date: 2023-12-04T13:37:04-05:00 New Revision: 4d4c30a37c75a4c41bcc70be1431651704624b6a URL: https://github.com/llvm/llvm-project/commit/4d4c30a37c75a4c41bcc70be1431651704624b6a DIFF:

[clang] Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg. (PR #74349)

2023-12-04 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/74349 >From 7fd7ebbf60beacb63ddfff16a7c4405e80cb62b4 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Mon, 4 Dec 2023 12:11:58 -0500 Subject: [PATCH 1/2] Use Address for CGBuilder's CreateAtomicRMW and

[libc] [compiler-rt] [mlir] [llvm] [libcxx] [clang] [flang] [clang-tools-extra] [sanitizer_symbolizer] RenderContextual elements for symbolizer markup. (PR #73194)

2023-12-04 Thread Andres Villegas via cfe-commits
=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: https://github.com/avillega closed https://github.com/llvm/llvm-project/pull/73194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg. (PR #74349)

2023-12-04 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix: C++ empty record with align lead to va_list out of sync (PR #72197)

2023-12-04 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM In terms of va_list etc., we first need to make sure calls are correct (compare against gcc etc.), then we need to make sure va_list is consistent with that. https://github.com/llvm/llvm-project/pull/72197

[llvm] [clang] [AMDGPU] Add an option to disable unsafe uses of atomic xor (PR #69229)

2023-12-04 Thread Pierre-Andre Saulais via cfe-commits
https://github.com/pasaulais updated https://github.com/llvm/llvm-project/pull/69229 >From cd33e8471ab5e768c1b579f1bec1308c0b322e05 Mon Sep 17 00:00:00 2001 From: Pierre-Andre Saulais Date: Thu, 23 Nov 2023 17:33:18 + Subject: [PATCH] [AMDGPU] Add an option to disable unsafe uses of atomic

[llvm] [clang] [AMDGPU] Add an option to disable unsafe uses of atomic xor (PR #69229)

2023-12-04 Thread Pierre-Andre Saulais via cfe-commits
https://github.com/pasaulais updated https://github.com/llvm/llvm-project/pull/69229 >From 24b0e5204f9eac6efaf502b5aa254f5ff7e11e69 Mon Sep 17 00:00:00 2001 From: Pierre-Andre Saulais Date: Thu, 23 Nov 2023 17:33:18 + Subject: [PATCH] [AMDGPU] Add an option to disable unsafe uses of atomic

[llvm] [clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-12-04 Thread Anton Korobeynikov via cfe-commits
asl wrote: Looks like the review stalled. Where we are here? @ahmedbougacha @ChuanqiXu9 ? https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[flang] [clang] [flang] remove -f[no-]alias-analysis (PR #74343)

2023-12-04 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. Thanks, LGTM! https://github.com/llvm/llvm-project/pull/74343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [lld] [libcxxabi] [flang] [clang] [lldb] [libcxx] [libc] [flang] Pass Argv0 to getIntriniscDir and getOpenMPHeadersDir (PR #73254)

2023-12-04 Thread via cfe-commits
https://github.com/madanial0 updated https://github.com/llvm/llvm-project/pull/73254 >From 81d1e05dd084dd5bb88dab88d2f23008b8dc6cfb Mon Sep 17 00:00:00 2001 From: Mark Danial Date: Tue, 21 Nov 2023 12:18:40 -0500 Subject: [PATCH 1/2] Pass the correct path to getIntriniscDir and

[llvm] [clang] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: Here's a simple-ish example: ```llvm ; Transforms/InstCombine/add.ll define i5 @zext_sext_not(i4 %x) { %zx = zext i4 %x to i5 %notx = xor i4 %x, 15 %snotx = sext i4 %notx to i5 %r = add i5 %zx, %snotx ret i5 %r } => define i5 @zext_sext_not(i4 %x) { %zx = zext i4

[clang-tools-extra] [clang] [clang][tidy] Ensure rewriter has the correct CWD (PR #67839)

2023-12-04 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Ping @PiotrZSL. https://github.com/llvm/llvm-project/pull/67839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg. (PR #74349)

2023-12-04 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f368e6424fbfb7fdea4b9d9a2e44f2f7e188c133 7fd7ebbf60beacb63ddfff16a7c4405e80cb62b4 --

[clang] Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg. (PR #74349)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: James Y Knight (jyknight) Changes Update all callers to pass through the Address. For the older builtins such as `__sync_*` and MSVC `_Interlocked*`, natural alignment of the atomic access is _assumed_. This change preserves that

[clang] Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg. (PR #74349)

2023-12-04 Thread James Y Knight via cfe-commits
https://github.com/jyknight created https://github.com/llvm/llvm-project/pull/74349 Update all callers to pass through the Address. For the older builtins such as `__sync_*` and MSVC `_Interlocked*`, natural alignment of the atomic access is _assumed_. This change preserves that behavior. It

[llvm] [clang] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Craig Topper via cfe-commits
topperc wrote: > FWIW, Alive2 is complaining about this commit. These patches are not safe > w.r.t. undef. Why not? https://github.com/llvm/llvm-project/pull/72912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-12-04 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f368e6424fbfb7fdea4b9d9a2e44f2f7e188c133 3575ad5701a852dd8b79d144ea17a729cfb4d94c --

[clang] [analyzer] Fix "sprintf" parameter modeling in CStringChecker (PR #74345)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes Review the commits one by one. I plan to merge them manually by pushing both of these at once. This PR intends to fix #74269. --- Patch is 40.76 KiB,

[clang] [llvm] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-12-04 Thread Nikita Popov via cfe-commits
nikic wrote: I went ahead and pushed a clean up version of that change to this PR, so you can just re-test this PR. I've found that dropping the icmp case also removes most of the second-order compile-time regressions, and also drops the (very minor) regression in the BPF test, so those are

[clang] [analyzer] Fix "sprintf" parameter modeling in CStringChecker (PR #74345)

2023-12-04 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/74345 Review the commits one by one. I plan to merge them manually by pushing both of these at once. This PR intends to fix #74269. >From 1359a7ef528358cc7e10a751aa885c6bd8ac8d1c Mon Sep 17 00:00:00 2001 From:

[clang] [flang] [flang] remove -f[no-]alias-analysis (PR #74343)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Eccles (tblah) Changes Now that tbaa tags pass is enabled by default, I would like to remove these flags. `-fno-alias-analysis` was originally intended to be useful for debugging, but as it also disables tbaa tag generation in

[flang] [clang] [flang] remove -f[no-]alias-analysis (PR #74343)

2023-12-04 Thread Tom Eccles via cfe-commits
https://github.com/tblah created https://github.com/llvm/llvm-project/pull/74343 Now that tbaa tags pass is enabled by default, I would like to remove these flags. `-fno-alias-analysis` was originally intended to be useful for debugging, but as it also disables tbaa tag generation in codegen,

[clang] [analyzer] Let the checkers query upper and lower bounds on symbols (PR #74141)

2023-12-04 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Does this work with Z3 as the solver? Since Z3 is not officially supported, I think it is not a blocker, but I'd love to see some FIXMEs/tickets opened in that case. https://github.com/llvm/llvm-project/pull/74141 ___ cfe-commits

[clang] [llvm] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-12-04 Thread Nikita Popov via cfe-commits
nikic wrote: @dtcxzyw Could you please run another test with this branch? https://github.com/nikic/llvm-project/tree/perf/dom-cond-3 I believe the issue with DILATE is that we have some icmps that get canonicalized from signed to unsigned predicate, and IndVars is not able to perform some

[clang] [flang] [flang] (Re-)Enable alias tags pass by default (PR #74250)

2023-12-04 Thread Slava Zakharin via cfe-commits
https://github.com/vzakhari commented: Thank you, Tom! https://github.com/llvm/llvm-project/pull/74250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Substitute alias templates from correct context (PR #74335)

2023-12-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/74335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Substitute alias templates from correct context (PR #74335)

2023-12-04 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/74335 >From 6d7fe6fe8c62373fdaab597c3c31c7132e475e32 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Mon, 4 Dec 2023 07:47:04 -0800 Subject: [PATCH 1/2] [clang] Substitute alias templates from correct

[clang] [clang][dataflow] Re-land: Retrieve members from accessors called usi… (PR #74336)

2023-12-04 Thread Samira Bazuzi via cfe-commits
bazuzi wrote: @martinboehme or @ymand Could you take a look and merge? The only modification from https://github.com/llvm/llvm-project/pull/73978 is the `Env.initialize()` in the test. https://github.com/llvm/llvm-project/pull/74336 ___ cfe-commits

<    1   2   3   4   >