https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/76818
>From cc7ff8b7ecb93165172dbb481c7d5fcb64289a96 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Wed, 3 Jan 2024 14:44:58 +0100
Subject: [PATCH 1/4] [coroutines] Introduce [[clang::coro_not_lifetimebound]]
---
Author: James Y Knight
Date: 2024-01-03T09:34:07-05:00
New Revision: b3d26426b06ee74bf79f766375a37c384aa0132b
URL:
https://github.com/llvm/llvm-project/commit/b3d26426b06ee74bf79f766375a37c384aa0132b
DIFF:
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/75612
From 041a3396cd62773bac985a6ca0b453b2f14635b3 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Fri, 15 Dec 2023 15:14:05 +0100
Subject: [PATCH 1/2] [clangd] Track IWYU pragmas for non-preamble includes
---
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/76818
>From cc7ff8b7ecb93165172dbb481c7d5fcb64289a96 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Wed, 3 Jan 2024 14:44:58 +0100
Subject: [PATCH 1/3] [coroutines] Introduce [[clang::coro_not_lifetimebound]]
---
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76580
From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 29 Dec 2023 17:54:34 +0100
Subject: [PATCH 01/12] [analyzer] Add std::any checker
---
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76580
From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 29 Dec 2023 17:54:34 +0100
Subject: [PATCH 01/11] [analyzer] Add std::any checker
---
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76580
From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 29 Dec 2023 17:54:34 +0100
Subject: [PATCH 01/10] [analyzer] Add std::any checker
---
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76580
From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 29 Dec 2023 17:54:34 +0100
Subject: [PATCH 1/9] [analyzer] Add std::any checker
---
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76580
From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 29 Dec 2023 17:54:34 +0100
Subject: [PATCH 1/8] [analyzer] Add std::any checker
---
@@ -7671,9 +7671,12 @@ The ``[[clang::coro_lifetimebound]]`` is a class
attribute which can be applied
to a coroutine return type (`CRT`_) (i.e.
it should also be annotated with ``[[clang::coro_return_type]]``).
-All parameters of a function are considered to be lifetime
@@ -115,3 +115,18 @@ CoNoCRT bar(int a) {
co_return 1;
}
} // namespace not_a_crt
+
+//
=
+// Not lifetime bound coroutine wrappers: [[clang::coro_not_lifetimebound]].
+//
@@ -1121,6 +1121,14 @@ def CoroLifetimeBound : InheritableAttr {
let SimpleHandler = 1;
}
+def CoroNotLifetimeBound : InheritableAttr {
ilya-biryukov wrote:
Any alternatives to this name? Maybe `coro_disable_lifetime_bound`?
The current name confused me a
cor3ntin wrote:
Can you add a release note?
Otherwise, I think the changes are reasonable. I'd like a second pair of eyes
though @erichkeane
https://github.com/llvm/llvm-project/pull/76677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -6,20 +6,20 @@ struct A {
};
static_assert(A{1, 2, 3, 4, 5} == A{1, 2, 3, 4, 5});
-static_assert(A{1, 2, 3, 4, 5} == A{0, 2, 3, 4, 5}); // expected-error
{{failed}}
-static_assert(A{1, 2, 3, 4, 5} == A{1, 0, 3, 4, 5}); // expected-error
{{failed}}
-static_assert(A{1, 2,
https://github.com/erichkeane commented:
I too would like to see some more complicated dumps for 'complicated' structs
(inheritance, multiple inheritance, etc), and vectors/arrays of complicated
structs.
I am really concerned with the 'depth' that this will show and be unwieldy as a
result.
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/74852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2644,6 +2644,49 @@ bool QualType::isTriviallyCopyableType(const ASTContext
) const {
return false;
}
+bool QualType::isTriviallyCopyConstructibleType(
11happy wrote:
Yes I think that would be good, so should I do that?
@@ -2644,6 +2644,49 @@ bool QualType::isTriviallyCopyableType(const ASTContext
) const {
return false;
}
+bool QualType::isTriviallyCopyConstructibleType(
cor3ntin wrote:
Given that this function is exactly the same as the previous one, maybe we could
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/76818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Utkarsh Saxena (usx95)
Changes
Lifetime-bound analysis of reference parameters of coroutines and coroutine
wrappers is helpful in surfacing memory bugs associated with using temporaries
and stack variables in call expressions in plain
https://github.com/usx95 ready_for_review
https://github.com/llvm/llvm-project/pull/76818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/76818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/76818
>From cc7ff8b7ecb93165172dbb481c7d5fcb64289a96 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Wed, 3 Jan 2024 14:44:58 +0100
Subject: [PATCH 1/2] [coroutines] Introduce [[clang::coro_not_lifetimebound]]
---
qiongsiwu wrote:
I realized one problem during testing IRPGO (thanks again for the suggestion
@minglotus-6 !).
A functions control flow may change between `-fprofile-generate` and
`-fprofile-use` when we make use of definitions in the new header. For example,
one may have the following
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/76818
Lifetime-bound analysis of reference parameters of coroutines and coroutine
wrappers is helpful in surfacing memory bugs associated with using temporaries
and stack variables in call expressions in plain return
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 01/13] Initial commit
---
jhuber6 wrote:
>
> How about using `--offload=` which can take a target triple? E.g.
>
> * `--offload=spirv64-amd` or something like that: pick HIPAMD tool chain.
>
> * `--offload=spirv64`: pick HIPSPV tool chain.
>
>
> And also remove this
>
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/75904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haojian Wu
Date: 2024-01-03T14:33:20+01:00
New Revision: 923ff5574826767af8145aae361ca5d710c16e65
URL:
https://github.com/llvm/llvm-project/commit/923ff5574826767af8145aae361ca5d710c16e65
DIFF:
https://github.com/llvm/llvm-project/commit/923ff5574826767af8145aae361ca5d710c16e65.diff
https://github.com/kadircet approved this pull request.
thanks, lgtm!
https://github.com/llvm/llvm-project/pull/75904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
https://github.com/Keenuts commented:
LGTM for the logic, and choices. Just some small nits
https://github.com/llvm/llvm-project/pull/76749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -3,29 +3,39 @@
// Supported targets
//
// RUN: %clang -target dxil-unknown-shadermodel6.2-compute %s -S -o /dev/null
2>&1 | FileCheck --allow-empty --check-prefix=CHECK-VALID %s
-// RUN: %clang -target spirv-unknown-shadermodel6.2-compute %s -S -o /dev/null
2>&1 |
@@ -4236,20 +4236,35 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
// TODO: Revisit restricting SPIR-V to logical once we've figured out how
to
// handle PhysicalStorageBuffer64 memory model
if (T.isDXIL() || T.isSPIRVLogical()) {
- enum
@@ -1328,6 +1331,31 @@ VersionTuple Triple::getDriverKitVersion() const {
}
}
+VersionTuple Triple::getVulkanVersion() const {
+ if (getArch() != spirv || getOS() != Vulkan)
+llvm_unreachable("invalid Vulkan SPIR-V triple");
+
+ VersionTuple VulkanVersion =
https://github.com/Keenuts edited
https://github.com/llvm/llvm-project/pull/76749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phoebewang wrote:
> Making avx512f the only case where avx512vl can be disabled doesn't seem like
> too much of a stretch to me - we'd be merely making all avx512 extension
> features depend on avx512vl.
Agreed.
https://github.com/llvm/llvm-project/pull/75580
rikhuijzer wrote:
@joker-eph, thanks again for the review!
https://github.com/llvm/llvm-project/pull/76292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rikhuijzer closed
https://github.com/llvm/llvm-project/pull/76292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benshi001 closed
https://github.com/llvm/llvm-project/pull/76805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ben Shi
Date: 2024-01-03T20:38:15+08:00
New Revision: 0408a8578383539e9197cb27f59c876e474875f5
URL:
https://github.com/llvm/llvm-project/commit/0408a8578383539e9197cb27f59c876e474875f5
DIFF:
https://github.com/llvm/llvm-project/commit/0408a8578383539e9197cb27f59c876e474875f5.diff
LOG:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
This fixes the bug introduced by
https://github.com/llvm/llvm-project/commit/6db007a0654ed7a6ed5c3aa3b61a937c19a6bc6b.
We construct placeholder template arguments for template-template parameters to
avoid
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/76811
This fixes the bug introduced by
https://github.com/llvm/llvm-project/commit/6db007a0654ed7a6ed5c3aa3b61a937c19a6bc6b.
We construct placeholder template arguments for template-template parameters to
avoid
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/76292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RKSimon wrote:
Making avx512f the only case where avx512vl can be disabled doesn't seem like
too much of a stretch to me - we'd be merely making all avx512 extension
features depend on avx512vl.
https://github.com/llvm/llvm-project/pull/75580
___
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/76729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Utkarsh Saxena
Date: 2024-01-03T12:41:10+01:00
New Revision: aba40fb34a27f1d36b4b541bf04d414dca7d1c4c
URL:
https://github.com/llvm/llvm-project/commit/aba40fb34a27f1d36b4b541bf04d414dca7d1c4c
DIFF:
iains wrote:
@ChuanqiXu9 very sorry for the slow review. It would help me if the design was
described in the commit message instead of trying to deduce it from the patch
(maybe it's in a thread somewhere - so a cross-reference would help).
two immediate questions and one observation:
- I
https://github.com/ilya-biryukov approved this pull request.
https://github.com/llvm/llvm-project/pull/76729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15845,7 +15845,7 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) {
}
void Sema::CheckCoroutineWrapper(FunctionDecl *FD) {
- if (!FD)
+ if (!FD || FD->hasSkippedBody())
ilya-biryukov wrote:
Nice! Thanks, this definitely looks much better now!
linehill wrote:
> > Perhaps we should consider prefixing it in some way (e.g. `hip-spirv` or
> > `amd-spirv`) that leaves the door open for some special handling (enable a
> > particular set of extensions only for amdgpu targeting SPIRV, try to deal
> > with missing builtins etc.) /
s1Sharp wrote:
It seems your changes remain compatible with the old clang-format behavior.
Сode looks quite correct
https://github.com/llvm/llvm-project/pull/76795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/76805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benshi001 wrote:
> No release notes?
I have created another PR to add the miss release note.
https://github.com/llvm/llvm-project/pull/76805
https://github.com/llvm/llvm-project/pull/76671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ben Shi (benshi001)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/76805.diff
1 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+2-1)
``diff
diff --git a/clang/docs/ReleaseNotes.rst
https://github.com/benshi001 created
https://github.com/llvm/llvm-project/pull/76805
None
>From c037cab9ef925d902a34a173244826e5cf797800 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Wed, 3 Jan 2024 18:50:16 +0800
Subject: [PATCH] [clang][analyzer][NFC] Improve release note
---
https://github.com/hokein approved this pull request.
thanks, looks good.
https://github.com/llvm/llvm-project/pull/75612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benshi001 wrote:
> No release notes?
Sorry, I forget to pull your modification to my local repo, I will fix this
soon.
https://github.com/llvm/llvm-project/pull/76671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
athei wrote:
> What was the last bit of discussion on the phabricator review? I can no
> longer access it.
It was basically just waiting for final approval. The agreement was that it is
good enough to be merged in as experimental even with unfinalized ABI.
I really hope we can get this in
steakhal wrote:
No release notes?
https://github.com/llvm/llvm-project/pull/76671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yi-wu-arm wrote:
Hi @klausler , any thought of this patch? Thank in advance!
https://github.com/llvm/llvm-project/pull/71222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
can you also add a test to clang/unittests/Format/TokenAnnotatorTest.cpp that
ensures trailing attribute-like macros receive `StartOfName` annotation to make
sure we don't regress the signal in the future?
@@ -15845,7 +15845,7 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) {
}
void Sema::CheckCoroutineWrapper(FunctionDecl *FD) {
- if (!FD)
+ if (!FD || FD->hasSkippedBody())
usx95 wrote:
Moved the check to calling code. `CheckCompletedCoroutineBody`
https://github.com/balazske approved this pull request.
https://github.com/llvm/llvm-project/pull/76776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/76729
>From c0baa45c2541bc688f377a6bd2c9281532b4d541 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Tue, 2 Jan 2024 16:49:28 +0100
Subject: [PATCH 1/2] [coroutines] Do not check coroutine wrappers for skipped
Author: Ben Shi
Date: 2024-01-03T18:23:45+08:00
New Revision: 3db749afcb5079dac332942a3e0b258cdb629a02
URL:
https://github.com/llvm/llvm-project/commit/3db749afcb5079dac332942a3e0b258cdb629a02
DIFF:
https://github.com/llvm/llvm-project/commit/3db749afcb5079dac332942a3e0b258cdb629a02.diff
LOG:
https://github.com/benshi001 closed
https://github.com/llvm/llvm-project/pull/76671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov updated
https://github.com/llvm/llvm-project/pull/76804
>From d8598a382fb1496a96d6ff8317c06cf73606ad84 Mon Sep 17 00:00:00 2001
From: Ilya Biryukov
Date: Wed, 3 Jan 2024 11:07:17 +0100
Subject: [PATCH 1/2] [Format] Fix isStartOfName to recognize attributes
ilya-biryukov wrote:
I have played around with specializing new behavior to macro directives and it
seems work well, I have sent #76804 for review.
https://github.com/llvm/llvm-project/pull/72336
___
cfe-commits mailing list
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Ilya Biryukov (ilya-biryukov)
Changes
This addresses a problem with formatting attributes. Some context:
- 199fc973ced20016b04ba540cf63a1d4914fa513 changed `isStartOfName` to fix
problems inside macro directives (judging by the
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/76632
>From 1165b11477ab59122a4db35221fcefe3c9505387 Mon Sep 17 00:00:00 2001
From: Zingam
Date: Sat, 30 Dec 2023 17:34:56 +0200
Subject: [PATCH 01/18] [libc++][streams] P1759R6: Native handles and file
streams
https://github.com/ilya-biryukov created
https://github.com/llvm/llvm-project/pull/76804
This addresses a problem with formatting attributes. Some context:
- 199fc973ced20016b04ba540cf63a1d4914fa513 changed `isStartOfName` to fix
problems inside macro directives (judging by the added tests),
https://github.com/madanial0 updated
https://github.com/llvm/llvm-project/pull/73903
>From 272167eb482838cd432f33bffc01d43562adb873 Mon Sep 17 00:00:00 2001
From: Mark Danial
Date: Thu, 30 Nov 2023 02:14:20 -0500
Subject: [PATCH] [Flang] make ppc unsupported for x86_64 testcase (NFC)
---
https://github.com/madanial0 updated
https://github.com/llvm/llvm-project/pull/73903
>From 272167eb482838cd432f33bffc01d43562adb873 Mon Sep 17 00:00:00 2001
From: Mark Danial
Date: Thu, 30 Nov 2023 02:14:20 -0500
Subject: [PATCH] [Flang] make ppc unsupported for x86_64 testcase (NFC)
---
@@ -1491,6 +1492,12 @@ static bool
IsRecordContextStructurallyEquivalent(RecordDecl *D1,
return false;
}
+if (auto *D1Spec = dyn_cast(DC1)) {
+ auto *D2Spec = dyn_cast(DC2);
jcsxky wrote:
revert
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From 77976022454865df8bee1e4a09682a16658ed035 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
s1Sharp wrote:
> @s1Sharp are there any conclusions here? our code also incidentally relied on
> having new lines between string literals, mostly for the sake of having a
> line break after string literals that end with `\n`.
>
> what do people think about restoring the functionality to break
Fznamznon wrote:
Thanks @erichkeane for review!
@zygoloid , I would really appreciate if you took a look as well. Otherwise
I'll try to merge in a couple of days.
https://github.com/llvm/llvm-project/pull/75456
___
cfe-commits mailing list
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/76632
>From 1165b11477ab59122a4db35221fcefe3c9505387 Mon Sep 17 00:00:00 2001
From: Zingam
Date: Sat, 30 Dec 2023 17:34:56 +0200
Subject: [PATCH 01/17] [libc++][streams] P1759R6: Native handles and file
streams
https://github.com/balazske approved this pull request.
LGTM (if the tests pass)
https://github.com/llvm/llvm-project/pull/76671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
sent out https://github.com/llvm/llvm-project/pull/76795 for implementation
https://github.com/llvm/llvm-project/pull/69859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: kadir çetinkaya (kadircet)
Changes
This restores a subset of functionality that was forego in
d68826dfbd987377ef6771d40c1d984f09ee3b9e.
Streaming multiple string literals is rare enough in practice, hence
that change makes sense in
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/76795
This restores a subset of functionality that was forego in
d68826dfbd987377ef6771d40c1d984f09ee3b9e.
Streaming multiple string literals is rare enough in practice, hence
that change makes sense in general. But
@@ -2511,10 +2511,12 @@ void StdLibraryFunctionsChecker::initFunctionSummaries(
.ArgConstraint(NotNull(ArgNo(0;
// char *mkdtemp(char *template);
-// FIXME: Improve for errno modeling.
addToFunctionSummaryMap(
"mkdtemp",
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/76671
>From 0c586914ac977920140472d172ee357dea43f2c5 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Mon, 1 Jan 2024 18:48:27 +0800
Subject: [PATCH 1/2] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp'
---
@@ -1491,6 +1492,12 @@ static bool
IsRecordContextStructurallyEquivalent(RecordDecl *D1,
return false;
}
+if (auto *D1Spec = dyn_cast(DC1)) {
+ auto *D2Spec = dyn_cast(DC2);
balazske wrote:
I see now that the old code was better, there
@@ -54,3 +51,25 @@ int errno_lseek(int fildes, off_t offset) {
}
return 0;
}
+
+void errno_mkstemp(char *template) {
+ int FD = mkstemp(template);
+ if (FD >= 0) {
+if (errno) {}// expected-warning{{An undefined value
may be read from 'errno'}}
+
@@ -2511,10 +2511,12 @@ void StdLibraryFunctionsChecker::initFunctionSummaries(
.ArgConstraint(NotNull(ArgNo(0;
// char *mkdtemp(char *template);
-// FIXME: Improve for errno modeling.
addToFunctionSummaryMap(
"mkdtemp",
@@ -703,8 +713,37 @@ void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII,
setRegScore(RegNo, T, CurrScore);
}
}
-if (Inst.mayStore() && (TII->isDS(Inst) || mayWriteLDSThroughDMA(Inst))) {
- setRegScore(SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS, T,
@@ -703,8 +713,37 @@ void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII,
setRegScore(RegNo, T, CurrScore);
}
}
-if (Inst.mayStore() && (TII->isDS(Inst) || mayWriteLDSThroughDMA(Inst))) {
- setRegScore(SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS, T,
@@ -703,8 +713,37 @@ void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII,
setRegScore(RegNo, T, CurrScore);
}
}
-if (Inst.mayStore() && (TII->isDS(Inst) || mayWriteLDSThroughDMA(Inst))) {
- setRegScore(SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS, T,
@@ -9342,6 +9342,38 @@ TEST_P(ASTImporterOptionSpecificTestBase,
ImportConflictTypeAliasTemplate) {
EXPECT_FALSE(ImportedCallable);
}
+AST_MATCHER(ClassTemplateSpecializationDecl, hasInstantiatedFromMember) {
+ if (auto Instantiate = Node.getInstantiatedFrom()) {
+if
@@ -9342,6 +9342,38 @@ TEST_P(ASTImporterOptionSpecificTestBase,
ImportConflictTypeAliasTemplate) {
EXPECT_FALSE(ImportedCallable);
}
+AST_MATCHER(ClassTemplateSpecializationDecl, hasInstantiatedFromMember) {
+ if (auto Instantiate = Node.getInstantiatedFrom()) {
+if
@@ -9342,6 +9342,38 @@ TEST_P(ASTImporterOptionSpecificTestBase,
ImportConflictTypeAliasTemplate) {
EXPECT_FALSE(ImportedCallable);
}
+AST_MATCHER(ClassTemplateSpecializationDecl, hasInstantiatedFromMember) {
+ if (auto Instantiate = Node.getInstantiatedFrom()) {
+if
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
@@ -8938,6 +8957,11 @@ static void processTypeAttrs(TypeProcessingState ,
QualType ,
attr.setUsedAsTypeAttr();
@@ -527,6 +527,10 @@ class ASTWriter : public ASTDeserializationListener,
bool isLookupResultExternal(StoredDeclsList , DeclContext *DC);
bool isLookupResultEntirelyExternal(StoredDeclsList , DeclContext
*DC);
+ uint64_t
+ WriteSpecsLookupTable(NamedDecl *D,
@@ -150,6 +150,11 @@ class ExternalASTSource : public
RefCountedBase {
virtual bool
FindExternalVisibleDeclsByName(const DeclContext *DC, DeclarationName Name);
+ /// Load all the external specialzations for the Decl and the corresponding
+ /// template arguments.
+
@@ -2431,10 +2434,14 @@ void
ASTDeclReader::VisitClassTemplateDecl(ClassTemplateDecl *D) {
mergeRedeclarableTemplate(D, Redecl);
if (ThisDeclID == Redecl.getFirstID()) {
-// This ClassTemplateDecl owns a CommonPtr; read it to keep track of all of
-// the
@@ -1249,3 +1249,5 @@ void ODRHash::AddQualType(QualType T) {
void ODRHash::AddBoolean(bool Value) {
Bools.push_back(Value);
}
+
+void ODRHash::AddInteger(unsigned Value) { ID.AddInteger(Value); }
vgvassilev wrote:
I remember @hahnjo and @zygoloid
https://github.com/vgvassilev commented:
This is a great way to start a new year ;)
The phab link is https://reviews.llvm.org/D41416.
In general I was wondering could we simplify the implementation by loading the
specialization hash table upon module load. That should be relatively cheap as
301 - 400 of 401 matches
Mail list logo
