[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Pol M via cfe-commits
https://github.com/Destroyerrrocket updated https://github.com/llvm/llvm-project/pull/76825 >From 2afecb35d80df788641c1b45cb74077037ff075f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pol=20Marcet=20Sard=C3=A0?= Date: Wed, 3 Jan 2024 16:00:42 +0100 Subject: [PATCH] [clang] Optimize

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Pol M via cfe-commits
Destroyerrrocket wrote: Squashed, rebased, and updated the commit message to give more information. You can go ahead and merge! https://github.com/llvm/llvm-project/pull/76825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-04 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e9af57dfea1637a3872052b317c9fe6c71b8d290 6cc7141f1f182763ccec8a4801d3b866cc839324 --

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Pol M via cfe-commits
https://github.com/Destroyerrrocket updated https://github.com/llvm/llvm-project/pull/76825 >From bea08b9dd4c9b3663035656de3ee8899538bbfd6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pol=20Marcet=20Sard=C3=A0?= Date: Wed, 3 Jan 2024 16:00:42 +0100 Subject: [PATCH] [clang] Optimize

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-04 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/76960 We have a previous fix https://github.com/llvm/llvm-project/commit/be861b64d94198230d8f9889b17280e3cd215a0a, which snapshots all processing files. It works most of times, the snapshot (InMemoryFileSystem) is

[clang] [Documentation] Fix typoed integer (PR #65688)

2024-01-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Alcaro) Changes (Yes, this commit is two years old, I never felt like investigating Phabricator) --- Full diff: https://github.com/llvm/llvm-project/pull/65688.diff 1 Files Affected: - (modified) clang/docs/Block-ABI-Apple.rst

[clang] [clang] Correctly implement CWG 2672 (PR #75001)

2024-01-04 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/75001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Correctly implement CWG 2672 (PR #75001)

2024-01-04 Thread via cfe-commits
cor3ntin wrote: @zyn0217 I think the existing release note could mention #71684. LGTM otherwise https://github.com/llvm/llvm-project/pull/75001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][SME] Add IsStreamingOrSVE2p1 (PR #75958)

2024-01-04 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. https://github.com/llvm/llvm-project/pull/75958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [flang] [llvm] [clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2024-01-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam reopened https://github.com/llvm/llvm-project/pull/67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [flang] [llvm] [AMDGPU] Introduce Code Object V6 (PR #76954)

2024-01-04 Thread Pierre van Houtryve via cfe-commits
@@ -2585,7 +2585,7 @@ getAMDGPUCodeObjectArgument(const Driver , const llvm::opt::ArgList ) { void tools::checkAMDGPUCodeObjectVersion(const Driver , const llvm::opt::ArgList ) { const unsigned MinCodeObjVer = 4; - const unsigned

[lld] [clang] [flang] [llvm] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

2024-01-04 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: Note: testing is a bit light for now, I'd like to add more tests, but I'm not sure what kind of tests are worth adding. I could just add a generic target run line wherever gfx9/10/11 run lines are present, but that seems a bit overkill? I'd need to change half the tests we

[llvm] [flang] [lld] [clang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

2024-01-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld @llvm/pr-subscribers-clang Author: Pierre van Houtryve (Pierre-vh) Changes NOTE: This PR is part of a stack, please check #76954 to review the first commit! These generic targets include multiple GPUs and will, in the future, provide a way to

[clang] [clang][Interp] Fix nullptr array dereferencing (PR #75798)

2024-01-04 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/75798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [lld] [flang] [clang] [AMDGPU] Introduce Code Object V6 (PR #76954)

2024-01-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang Author: Pierre van Houtryve (Pierre-vh) Changes Introduce Code Object V6 in Clang, LLD, Flang and LLVM. This is the same as V5 except a new "generic version" flag can be present in EFLAGS. This is related to

[lld] [clang] [flang] [llvm] [AMDGPU] Introduce Code Object V6 (PR #76954)

2024-01-04 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh created https://github.com/llvm/llvm-project/pull/76954 Introduce Code Object V6 in Clang, LLD, Flang and LLVM. This is the same as V5 except a new "generic version" flag can be present in EFLAGS. This is related to new generic targets that'll be added in a

[clang] [clang] [MinGW] Don't look for a GCC in path if the install base has a proper mingw sysroot (PR #76949)

2024-01-04 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/76949 From c67187043168b79e57c0e4f3261293d799852e90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 19 Dec 2023 15:53:21 +0200 Subject: [PATCH] [clang] [MinGW] Don't look for a GCC in path

[clang] [Coverage] Map regions from system headers (PR #76950)

2024-01-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (ManuelvOK) Changes In 2155195, the "system-headers-coverage" option has been added but not used in all necessary places. --- Full diff: https://github.com/llvm/llvm-project/pull/76950.diff 2 Files Affected: - (modified)

[clang] [Coverage] Map regions from system headers (PR #76950)

2024-01-04 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Coverage] Map regions from system headers (PR #76950)

2024-01-04 Thread via cfe-commits
https://github.com/ManuelvOK created https://github.com/llvm/llvm-project/pull/76950 In 2155195, the "system-headers-coverage" option has been added but not used in all necessary places. >From 593b9db7dcbb814ddac3c77b462d04400cfa77a8 Mon Sep 17 00:00:00 2001 From: Manuel Kalettka Date: Wed,

[llvm] [clang] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-04 Thread Kito Cheng via cfe-commits
kito-cheng wrote: @wangpc-pp did you have interested on helping psABI side? it would be great if you can help since I suspect I don't have enough bandwidth to deal with that soon. https://github.com/llvm/llvm-project/pull/76777 ___ cfe-commits

[clang] [clang] [MinGW] Don't look for a GCC in path if the install base has a proper mingw sysroot (PR #76949)

2024-01-04 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 71b3ead870107e39e998f6480e545eb01d9d28be 355e2530e855249adf9657c58d4e1a6727d969bd --

[llvm] [clang] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-04 Thread Kito Cheng via cfe-commits
kito-cheng wrote: Hmmm, RISC-V ISA is growth after https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/257 again, I mean...we have zfinx and zdinx, which is also valid combination with rv32e/rv64e, so we may need to revise ilp32e ABI again on the psABI side, but my intention is not to

[clang] [clang] [MinGW] Don't look for a GCC in path if the install base has a proper mingw sysroot (PR #76949)

2024-01-04 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: CC @mati865 @jeremyd2019 @huangqinjin https://github.com/llvm/llvm-project/pull/76949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [MinGW] Don't look for a GCC in path if the install base has a proper mingw sysroot (PR #76949)

2024-01-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Martin Storsjö (mstorsjo) Changes This fixes uses of the MSYS2 clang64 environment compilers, if another set of GCC based compilers are available further back in PATH (which may be explicitly added, or inherited unintentionally

[clang] [clang] [MinGW] Don't look for a GCC in path if the install base has a proper mingw sysroot (PR #76949)

2024-01-04 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/76949 This fixes uses of the MSYS2 clang64 environment compilers, if another set of GCC based compilers are available further back in PATH (which may be explicitly added, or inherited unintentionally from other

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Vlad Serebrennikov via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= ,Pol M Message-ID: In-Reply-To: Endilll wrote: @Destroyerrrocket We'll merge as soon as you deem it ready and provide commit description. PR description doesn't seem a good fit for a commit description to me.

[clang] [clang][ASTImporter] import InstantiatedFromMember of ClassTemplateSpecializationDecl (PR #76493)

2024-01-04 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/76493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4de971c - [clang][ASTImporter] import InstantiatedFromMember of ClassTemplateSpecializationDecl (#76493)

2024-01-04 Thread via cfe-commits
Author: Qizhi Hu Date: 2024-01-04T21:21:53+08:00 New Revision: 4de971c230e8202cfd54d4d6c36719db628d35ce URL: https://github.com/llvm/llvm-project/commit/4de971c230e8202cfd54d4d6c36719db628d35ce DIFF: https://github.com/llvm/llvm-project/commit/4de971c230e8202cfd54d4d6c36719db628d35ce.diff

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Pol M via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= ,Pol M Message-ID: In-Reply-To: https://github.com/Destroyerrrocket updated https://github.com/llvm/llvm-project/pull/76825 >From 1ab4538e194f9a77c500e4a93b1875eb7e76dcf5 Mon Sep 17 00:00:00 2001 From:

[clang] [llvm] [HLSL][SPIR-V] Add Vulkan to target triple (PR #76749)

2024-01-04 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts approved this pull request. https://github.com/llvm/llvm-project/pull/76749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-04 Thread Alex Bradbury via cfe-commits
asb wrote: The conclusion from the previous review was this was OK to merge. I think I held it up by not responding to a ping (apologies). I've had another scan through and don't see a problem with merging this and considering it experimental once Craig's review comments are addressed. For

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-04 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: > > @RKSimon @phoebewang Thanks comments! knm has AVX512_VPOPCNTDQ, I guess we > > also require it work without avx512vl? And we are going to keep > > -march/mtune/mcpu support for knl/knm, but removing some specific ISA's > > intrinsic and lowering supports? Did I get your

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-04 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/75580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Emit Warnings for frontend options to enable knl/knm. (PR #75580)

2024-01-04 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/75580 >From e16afbdc9f0c04bad0e8f80f90c0eb26c13d3326 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 15 Dec 2023 16:50:23 +0800 Subject: [PATCH 1/6] [X86] Emit Warnings for frontend options to enable knl/knm.

[clang] 71b3ead - [clang][dataflow] Remove a redundant trailing semicolon. NFC.

2024-01-04 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2024-01-04T15:01:17+02:00 New Revision: 71b3ead870107e39e998f6480e545eb01d9d28be URL: https://github.com/llvm/llvm-project/commit/71b3ead870107e39e998f6480e545eb01d9d28be DIFF:

[clang] [Clang] Correctly construct template arguments for file-scope template template parameters (PR #76811)

2024-01-04 Thread Younan Zhang via cfe-commits
zyn0217 wrote: It is interesting to note that, if we exchange the position of two template parameters, i.e. ```cpp template concept C = false; template struct S {}; template typename T, unsigned N> // The template-template parameter now precedes the NTTP int wow(T ts); int main() {

[clang] [Cygwin] Cygwin basic support (PR #76943)

2024-01-04 Thread via cfe-commits
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang Author: 徐持恒 Xu Chiheng (xu-chiheng) Changes Enable TLS, and set VaListKind to CharPtrBuiltinVaList. This fix bootstrap failure on Cygwin. --- Full

[clang] [Cygwin] Cygwin basic support (PR #76943)

2024-01-04 Thread via cfe-commits
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng Message-ID: In-Reply-To: github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can

[clang] [Cygwin] Cygwin basic support (PR #76943)

2024-01-04 Thread 徐持恒 Xu Chiheng via cfe-commits
https://github.com/xu-chiheng created https://github.com/llvm/llvm-project/pull/76943 Enable TLS, and set VaListKind to CharPtrBuiltinVaList. This fix bootstrap failure on Cygwin. From 35cb22083fc0f842e873c99518a58d673bbcb1ec Mon Sep 17 00:00:00 2001 From:

[lldb] [libc] [clang] [llvm] [mlir] [NFC][ObjectSizeOffset] Use classes instead of std::pair (PR #76882)

2024-01-04 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/76882 >From ca7a96a40952fe94b916dacc52f07aa90bbdb1e7 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 3 Jan 2024 13:22:37 -0800 Subject: [PATCH 1/6] [builtin_object_size] Use classes instead of std::pair

[clang] [X86] Emit Warnings for frontend options to enable knl/knm. (PR #75580)

2024-01-04 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: > @RKSimon @phoebewang Thanks comments! knm has AVX512_VPOPCNTDQ, I guess we > also require it work without avx512vl? And we are going to keep > -march/mtune/mcpu support for knl/knm, but removing some specific ISA's > intrinsic and lowering supports? Did I get your point

[clang] [OpenMP] Patch for Support to loop bind clause : Checking Parent Region (PR #76938)

2024-01-04 Thread Alexey Bataev via cfe-commits
@@ -6213,26 +6226,35 @@ StmtResult Sema::ActOnOpenMPExecutableDirective( OpenMPDirectiveKind PrevMappedDirective) { StmtResult Res = StmtError(); OpenMPBindClauseKind BindKind = OMPC_BIND_unknown; + llvm::SmallVector ClausesWithoutBind; + bool UseClausesWithoutBind =

[clang] [OpenMP] Patch for Support to loop bind clause : Checking Parent Region (PR #76938)

2024-01-04 Thread Alexey Bataev via cfe-commits
@@ -11335,6 +11335,7 @@ class Sema final { /// on the parameter of the bind clause. In the methods for the /// mapped directives, check the parameters of the lastprivate clause. bool checkLastPrivateForMappedDirectives(ArrayRef Clauses); + alexey-bataev

[clang] [OpenMP] Patch for Support to loop bind clause : Checking Parent Region (PR #76938)

2024-01-04 Thread Alexey Bataev via cfe-commits
@@ -5072,6 +5072,18 @@ static bool checkNestingOfRegions(Sema , const DSAStackTy *Stack, CurrentRegion != OMPD_cancellation_point && CurrentRegion != OMPD_cancel && CurrentRegion != OMPD_scan) return false; +// Checks needed for mapping "loop"

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

2024-01-04 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/76826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 2336f79 - [clangd] Dont require confirmation for include-cleaner batch-fixes (#76826)

2024-01-04 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-01-04T12:57:42+01:00 New Revision: 2336f792bc5a1d9195c1bd995b6040c13e73d4e7 URL: https://github.com/llvm/llvm-project/commit/2336f792bc5a1d9195c1bd995b6040c13e73d4e7 DIFF:

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

2024-01-04 Thread kadir çetinkaya via cfe-commits
kadircet wrote: oh sorry, this should ofc work with include-cleaner fixes, as we actually provide these as edits, instead of commands, as we do with our usual tweaks. https://github.com/llvm/llvm-project/pull/76826 ___ cfe-commits mailing list

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

2024-01-04 Thread kadir çetinkaya via cfe-commits
kadircet wrote: > This change makes sense for removing all unused includes (as all these unused > includes are visible in the editor). For missing includes, they are less > obvious, but it is probably fine. The rationale for missing includes was the same, when things go wrong it's usually

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Pol M via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: https://github.com/Destroyerrrocket updated https://github.com/llvm/llvm-project/pull/76825 >From 1ab4538e194f9a77c500e4a93b1875eb7e76dcf5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pol=20Marcet=20Sard=C3=A0?=

[llvm] [clang] [libcxx] "Reapply "[Sema] Fix crash on invalid code with parenthesized aggrega… (PR #76833)

2024-01-04 Thread Mark de Wever via cfe-commits
mordante wrote: > > @ilya-biryukov this is the new attempt to land this patch, the version you > > committed breaks the libc++ CI. I'll try to fix it this week. > > Wow, I didn't expect that. Is libc++ ok with disabling this test until the > nightly build catches up? (The PR is in the Draft

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Pol M via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: Destroyerrrocket wrote: Thank you! I truly appreciate the congrats! :D @Endilll I don't have write access (I think? I'm new here :) ), I think one of you will have to make the merge (not used to github, at work I use bitbucket, I might

[llvm] [clang] [RISCV] Deduplicate RISCVISAInfo::toFeatures/toFeatureVector. NFC (PR #76942)

2024-01-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Luke Lau (lukel97) Changes toFeatures and toFeatureVector both output a list of target feature flags, just with a slightly different interface. toFeatures keeps any unsupported extensions, and also provides a way to append negative

[llvm] [clang] [RISCV] Deduplicate RISCVISAInfo::toFeatures/toFeatureVector. NFC (PR #76942)

2024-01-04 Thread Luke Lau via cfe-commits
https://github.com/lukel97 created https://github.com/llvm/llvm-project/pull/76942 toFeatures and toFeatureVector both output a list of target feature flags, just with a slightly different interface. toFeatures keeps any unsupported extensions, and also provides a way to append negative

[flang] [llvm] [compiler-rt] [clang-tools-extra] [libc] [lldb] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-04 Thread Matt Arsenault via cfe-commits
Thorsten =?utf-8?q?Sch=C3=BCtt?= , Thorsten =?utf-8?q?Sch=C3=BCtt?= , Thorsten =?utf-8?q?Sch=C3=BCtt?= Message-ID: In-Reply-To: https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits

[flang] [llvm] [compiler-rt] [clang-tools-extra] [libc] [lldb] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-04 Thread Matt Arsenault via cfe-commits
Thorsten =?utf-8?q?Schütt?= , Thorsten =?utf-8?q?Schütt?= , Thorsten =?utf-8?q?Schütt?= Message-ID: In-Reply-To: @@ -6548,6 +6534,54 @@ bool CombinerHelper::tryFoldBoolSelectToLogic(GSelect *Select, return false; } +bool CombinerHelper::tryFoldSelectOfBinOps(GSelect

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

2024-01-04 Thread kadir çetinkaya via cfe-commits
@@ -237,18 +236,6 @@ removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes) { Diag.Fixes.front().Edits.begin(), Diag.Fixes.front().Edits.end()); } - - // TODO(hokein): emit a suitable text for the label. -

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

2024-01-04 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/76826 From 5e9a851584dcfd730fda7d85b54101ebea89f8a3 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Wed, 3 Jan 2024 16:06:13 +0100 Subject: [PATCH 1/2] [clangd] Dont require confirmation for include-cleaner

[llvm] [clang] [clang-tools-extra] [X86] Use plain load/store instead of cmpxchg16b for atomics with AVX (PR #74275)

2024-01-04 Thread Matt Arsenault via cfe-commits
@@ -30113,32 +30120,40 @@ TargetLoweringBase::AtomicExpansionKind X86TargetLowering::shouldExpandAtomicStoreInIR(StoreInst *SI) const { Type *MemType = SI->getValueOperand()->getType(); - bool NoImplicitFloatOps = -

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-04 Thread Pol M via cfe-commits
Pol Marcet =?utf-8?q?Sard=C3=A0?= , Pol Marcet =?utf-8?q?Sard=C3=A0?= Message-ID: In-Reply-To: Destroyerrrocket wrote: (sorry about the typo!) https://github.com/llvm/llvm-project/pull/76615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-04 Thread Pol M via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: https://github.com/Destroyerrrocket updated https://github.com/llvm/llvm-project/pull/76615 >From cba67a73ea1e59eb8eeb4e702d77f329028f4c22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pol=20Marcet=20Sard=C3=A0?=

[clang] [NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test case under `asan` and `ubsan` configs (PR #75254)

2024-01-04 Thread via cfe-commits
@@ -1,18 +1,12 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -ftemplate-backtrace-limit=2 %s -// -// FIXME: Disable this test when Clang was built with ASan, because ASan -// increases our per-frame stack usage enough that this test no longer fits -// within our normal stack space

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-04 Thread Simon Pilgrim via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: RKSimon wrote: Please can you rename constat_builtins_vector.cpp -> constant_builtins_vector.cpp https://github.com/llvm/llvm-project/pull/76615 ___ cfe-commits mailing list

[clang] [OpenMP] Patch for Support to loop bind clause : Checking Parent Region (PR #76938)

2024-01-04 Thread via cfe-commits
https://github.com/SunilKuravinakop edited https://github.com/llvm/llvm-project/pull/76938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-01-04 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: I'm Sam's colleague and wanted to mention that Sam won't be available until January 15. It probably does not make much sense for someone else to take over at this point as the change is large and waiting for Sam is more efficient than ramping up someone else at this

[clang] loop bind : patch correction for bug in checking Parent region (PR #76938)

2024-01-04 Thread via cfe-commits
https://github.com/SunilKuravinakop edited https://github.com/llvm/llvm-project/pull/76938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] loop bind : correction for bug in checking Parent region (PR #76938)

2024-01-04 Thread via cfe-commits
https://github.com/SunilKuravinakop edited https://github.com/llvm/llvm-project/pull/76938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [Sema] When checking for constraint equivalence, do not calculate satisfaction (PR #74490)

2024-01-04 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov closed https://github.com/llvm/llvm-project/pull/74490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f5efa74 - [Sema] When checking for constraint equivalence, do not calculate satisfaction (#74490)

2024-01-04 Thread via cfe-commits
Author: Ilya Biryukov Date: 2024-01-04T11:57:53+01:00 New Revision: f5efa74961560070a1e6f127214bcf6b570fef98 URL: https://github.com/llvm/llvm-project/commit/f5efa74961560070a1e6f127214bcf6b570fef98 DIFF: https://github.com/llvm/llvm-project/commit/f5efa74961560070a1e6f127214bcf6b570fef98.diff

[clang-tools-extra] [clang] Reapply "[Clang][Sema] Diagnose unexpanded packs in the template argument lists of function template specializations" (#76876) (PR #76915)

2024-01-04 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/76915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-04 Thread kleines Filmröllchen via cfe-commits
https://github.com/kleinesfilmroellchen updated https://github.com/llvm/llvm-project/pull/67749 From 8a2b22e69f82e3f4caa271b57b998d1c03b21d39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?kleines=20Filmr=C3=B6llchen?= Date: Thu, 4 Jan 2024 11:53:23 +0100 Subject: [PATCH] [clangd] Allow specifying

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-04 Thread kleines Filmröllchen via cfe-commits
kleinesfilmroellchen wrote: > > What is the relationship between this patch, and clangd 17's ["missing > > include" > > warning](https://clangd.llvm.org/guides/include-cleaner#missing-include-warning)? > > Does the quick-fix for the "missing include" warning also respect these > > config

[clang-tools-extra] [clang] [llvm] Add out-of-line-atomics support to GlobalISel (PR #74588)

2024-01-04 Thread Thomas Preud'homme via cfe-commits
RoboTux wrote: Thanks for fixing the unused variable @DamonFool , I was about to revert and push a new patch. https://github.com/llvm/llvm-project/pull/74588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread via cfe-commits
Pol Marcet =?utf-8?q?Sard=C3=A0?= Message-ID: In-Reply-To: @@ -196,8 +217,20 @@ void ClangASTNodesEmitter::run(raw_ostream ) { } void clang::EmitClangASTNodes(RecordKeeper , raw_ostream , - const std::string , const std::string ) { -

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread via cfe-commits
Pol Marcet =?utf-8?q?Sard=C3=A0?= Message-ID: In-Reply-To: https://github.com/cor3ntin approved this pull request. LGTM. 1% is a very consequential improvement, congrats! https://github.com/llvm/llvm-project/pull/76825 ___ cfe-commits mailing list

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/76825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [libcxx] "Reapply "[Sema] Fix crash on invalid code with parenthesized aggrega… (PR #76833)

2024-01-04 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > @ilya-biryukov this is the new attempt to land this patch, the version you > committed breaks the libc++ CI. I'll try to fix it this week. Wow, I didn't expect that. Is libc++ ok with disabling this test until the nightly build catches up? (The PR is in the Draft state,

[clang] [clang] Add per-global code model attribute (PR #72078)

2024-01-04 Thread via cfe-commits
heiher wrote: @erichkeane gentle ping https://github.com/llvm/llvm-project/pull/72078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Fix SME2 mla/mls tests (PR #76711)

2024-01-04 Thread Kerry McLaughlin via cfe-commits
@@ -246,7 +246,7 @@ void test_svmls_single2_f64(uint32_t slice_base, svfloat64x2_t zn, svfloat64_t z // CPP-CHECK-NEXT:ret void // void test_svmls_single4_f64(uint32_t slice_base, svfloat64x4_t zn, svfloat64_t zm) __arm_streaming __arm_shared_za { -

[clang] [AArch64][SME2] Fix SME2 mla/mls tests (PR #76711)

2024-01-04 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm edited https://github.com/llvm/llvm-project/pull/76711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Fix SME2 mla/mls tests (PR #76711)

2024-01-04 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm commented: Thanks for fixing these tests @MDevereau! There are also some tests in acle_sme2_mlal.c, acle_sme2_mlall.c & acle_sme2_mlsl.c which have a similar issue, could you please update them in this patch too?

[clang] loop bind : bug in checking Parent region (PR #76938)

2024-01-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (SunilKuravinakop) Changes Changes uploaded to the phabricator on Dec 16th are lost because the phabricator is down. Hence re-uploading it to the github.com. Changes to be committed: modified:

[clang] loop bind : bug in checking Parent region (PR #76938)

2024-01-04 Thread via cfe-commits
https://github.com/SunilKuravinakop created https://github.com/llvm/llvm-project/pull/76938 Changes uploaded to the phabricator on Dec 16th are lost because the phabricator is down. Hence re-uploading it to the github.com. Changes to be committed: modified:

[clang-tools-extra] [llvm] [clang] [clang] Accept recursive non-dependent calls to functions with deduced return type (PR #75456)

2024-01-04 Thread Mariya Podchishchaeva via cfe-commits
@@ -640,3 +640,36 @@ namespace PR46637 { template struct Y { T x; }; Y auto> y; // expected-error {{'auto' not allowed in template argument}} } + +namespace GH71015 { + +// Check that there is no error in case a templated function is recursive and +// has a placeholder

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-04 Thread Pol M via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: https://github.com/Destroyerrrocket updated https://github.com/llvm/llvm-project/pull/76615 >From cba67a73ea1e59eb8eeb4e702d77f329028f4c22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pol=20Marcet=20Sard=C3=A0?= Date: Sat, 30 Dec 2023

[clang-tools-extra] [llvm] [clang] [clang] Accept recursive non-dependent calls to functions with deduced return type (PR #75456)

2024-01-04 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/75456 >From 0e190f131862dd8f4b07891c3ee712a0a163f936 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Thu, 14 Dec 2023 01:33:17 -0800 Subject: [PATCH 1/2] [clang] Accept recursive non-dependent calls to

[llvm] [clang-tools-extra] [clang] Add out-of-line-atomics support to GlobalISel (PR #74588)

2024-01-04 Thread Thomas Preud'homme via cfe-commits
https://github.com/RoboTux closed https://github.com/llvm/llvm-project/pull/74588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Introduce reduced BMI (PR #75894)

2024-01-04 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > Like I said in the commit message, this patch itself doesn't involve > > anything relevant to user interfaces. I left it to the latter patches. > > Are you in a position to post the next patch (at least as a draft)? That > would help me see the direction. I post it here

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Vlad Serebrennikov via cfe-commits
Pol Marcet =?utf-8?q?Sard=C3=A0?= Message-ID: In-Reply-To: @@ -70,8 +71,15 @@ class ClangASTNodesEmitter { std::pair EmitNode(raw_ostream& OS, ASTNode Base); public: explicit ClangASTNodesEmitter(RecordKeeper , const std::string , -const

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Vlad Serebrennikov via cfe-commits
Pol Marcet =?utf-8?q?Sard=C3=A0?= Message-ID: In-Reply-To: https://github.com/Endilll approved this pull request. LGTM, but you should wait for more approvals before merging. https://github.com/llvm/llvm-project/pull/76825 ___ cfe-commits mailing

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Vlad Serebrennikov via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: @@ -95,8 +103,23 @@ std::pair ClangASTNodesEmitter::EmitNode(raw_ostream , if (!Base.isAbstract()) First = Last = Base; + auto comp = [this](ASTNode LHS, ASTNode RHS) { +auto LHSPriorized =

[clang] [clang] Optimize castToDeclContext for 2% improvement in build times (PR #76825)

2024-01-04 Thread Vlad Serebrennikov via cfe-commits
Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/76825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sema] Warning for _Float16 passed to format specifier '%f' (PR #74439)

2024-01-04 Thread Haocong Lu via cfe-commits
Luhaocong wrote: Thanks for everyone's review. Do you have any other suggestions for this change, and can this pull request be accepted ? https://github.com/llvm/llvm-project/pull/74439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Format] Fix isStartOfName to recognize attributes (PR #76804)

2024-01-04 Thread Ilya Biryukov via cfe-commits
@@ -1698,8 +1698,6 @@ FormatStyle getGoogleStyle(FormatStyle::LanguageKind Language) { /*BasedOnStyle=*/"google", }, }; - GoogleStyle.AttributeMacros.push_back("GUARDED_BY"); ilya-biryukov wrote: They are attribute macros indeed, the

[clang] 26993f6 - Revert "[clang-format] Optimize processing .clang-format-ignore files (#76733)"

2024-01-04 Thread Mitch Phillips via cfe-commits
Author: Mitch Phillips Date: 2024-01-04T10:47:51+01:00 New Revision: 26993f61673e3d9b29785f9baa5bac50c09f8bcf URL: https://github.com/llvm/llvm-project/commit/26993f61673e3d9b29785f9baa5bac50c09f8bcf DIFF:

[llvm] [clang-tools-extra] [clang] Add out-of-line-atomics support to GlobalISel (PR #74588)

2024-01-04 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/74588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME] Add IsStreamingOrSVE2p1 (PR #75958)

2024-01-04 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 edited https://github.com/llvm/llvm-project/pull/75958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME] Add IsStreamingOrSVE2p1 (PR #75958)

2024-01-04 Thread Sam Tebbs via cfe-commits
@@ -1109,10 +1109,10 @@ def SVPFALSE : SInst<"svpfalse[_b]", "Pv", "", MergeNone, "", [IsOverloadNone, I def SVPTRUE_PAT : SInst<"svptrue_pat_{d}", "PI", "PcPsPiPl", MergeNone, "aarch64_sve_ptrue", [IsStreamingCompatible]>; def SVPTRUE : SInst<"svptrue_{d}", "Pv",

[clang] [Format] Fix isStartOfName to recognize attributes (PR #76804)

2024-01-04 Thread Ilya Biryukov via cfe-commits
@@ -10093,11 +10090,11 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { getGoogleStyleWithColumns(40)); verifyFormat("Tttt ppp\n" "ABSL_GUARDED_BY(mutex1)\n" - "ABSL_GUARDED_BY(mutex2);", +

[clang] [clang-format] Add .clang-format-ignore for ignoring files (PR #76327)

2024-01-04 Thread Owen Pan via cfe-commits
owenca wrote: Actually, it's commit 42ec976184ac. Please see [here](https://github.com/llvm/llvm-project/pull/76733#issuecomment-1876707005). https://github.com/llvm/llvm-project/pull/76327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2   3   4   5   6   >