[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-09 Thread Alan Zhao via cfe-commits
@@ -5495,14 +5495,12 @@ static void TryOrBuildParenListInitialization( return; } // ...and value-initialized for each k < i <= n; -if (ArrayLength > Args.size()) { alanzhao1 wrote: > What is this change supposed to do?

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-09 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 updated https://github.com/llvm/llvm-project/pull/76976 >From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001 From: Alan Zhao Date: Wed, 3 Jan 2024 12:29:21 -0800 Subject: [PATCH 1/6] [clang] Fix parenthesized list initialization of arrays not

[libunwind] [libc] [flang] [libcxx] [compiler-rt] [clang-tools-extra] [lldb] [lld] [clang] [llvm] [libc++][test] try to directly create socket file in /tmp when filepath is too long (PR #77058)

2024-01-09 Thread Wu Yingcong via cfe-commits
yingcong-wu wrote: Thank you very much. https://github.com/llvm/llvm-project/pull/77058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-09 Thread Bill Wendling via cfe-commits
bwendling wrote: Like I said, I can fix the `mi->ints` issue. It's when we're trying to ask for the size of the whole struct with more than one `__counted_by` attribute that we don't be able to handle. https://github.com/llvm/llvm-project/pull/76348

[llvm] [compiler-rt] [clang] [mlir] [lld] [sanitizer] Select non-internal frames in ReportErrorSummary (PR #77406)

2024-01-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: Nice filtering! https://github.com/llvm/llvm-project/pull/77406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-09 Thread Kees Cook via cfe-commits
kees wrote: Accessing `mi->ints` is unambiguous (it would use the declared `count_ints`) but I'm fine to wait and fix that later. The flex array union is gloriously rare in the kernel. As for whole object, I say pick smallest from all available under bdos(x, 1) and largest for bdos(x, 0), or

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-09 Thread Bill Wendling via cfe-commits
bwendling wrote: > > @kees, the issue should be fixed with the newest push. > > Nice! This is so extremely close. It fixed all but 1 instance in the torture > testing. The remaining seems to be union order sensitive. O_o This > arrangement still reports non-zero for the `int count_bytes` one,

[clang] [RISCV][clang] Optimize memory usage of intrinsic lookup table (PR #77487)

2024-01-09 Thread Craig Topper via cfe-commits
@@ -416,8 +416,10 @@ class RVVIntrinsic { RVVTypePtr getOutputType() const { return OutputType; } const RVVTypes () const { return InputTypes; } llvm::StringRef getBuiltinName() const { return BuiltinName; } - llvm::StringRef getName() const { return Name; } -

[clang] [RISCV][clang] Optimize memory usage of intrinsic lookup table (PR #77487)

2024-01-09 Thread Craig Topper via cfe-commits
@@ -463,7 +464,7 @@ void RISCVIntrinsicManagerImpl::CreateRVVIntrinsicDecl(LookupResult , bool RISCVIntrinsicManagerImpl::CreateIntrinsicIfFound(LookupResult , IdentifierInfo *II,

[clang] [RISCV][clang] Optimize memory usage of intrinsic lookup table (PR #77487)

2024-01-09 Thread Craig Topper via cfe-commits
@@ -463,7 +464,7 @@ void RISCVIntrinsicManagerImpl::CreateRVVIntrinsicDecl(LookupResult , bool RISCVIntrinsicManagerImpl::CreateIntrinsicIfFound(LookupResult , IdentifierInfo *II,

[clang] [RISCV][clang] Optimize memory usage of intrinsic lookup table (PR #77487)

2024-01-09 Thread Craig Topper via cfe-commits
@@ -380,14 +380,14 @@ void RISCVIntrinsicManagerImpl::InitRVVIntrinsic( OverloadedName += "_" + OverloadedSuffixStr.str(); // clang built-in function name, e.g. __builtin_rvv_vadd. - std::string BuiltinName = "__builtin_rvv_" + std::string(Record.Name); + std::string

[clang] [clang][Parser] Pop scope prior VarDecl invalidating by invalid init (PR #77434)

2024-01-09 Thread Ding Fei via cfe-commits
https://github.com/danix800 closed https://github.com/llvm/llvm-project/pull/77434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4694421 - [clang][Parser] Pop scope prior VarDecl invalidating by invalid init (#77434)

2024-01-09 Thread via cfe-commits
Author: Ding Fei Date: 2024-01-10T08:49:36+08:00 New Revision: 46944210ebd93765b068eeba22bd3e337099af3e URL: https://github.com/llvm/llvm-project/commit/46944210ebd93765b068eeba22bd3e337099af3e DIFF: https://github.com/llvm/llvm-project/commit/46944210ebd93765b068eeba22bd3e337099af3e.diff

[llvm] [clang] [Clang][RISCV] Move getVScaleRange logic into libLLVMFrontendDriver. NFC (PR #77327)

2024-01-09 Thread Craig Topper via cfe-commits
@@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS Support TargetParser FrontendOpenMP + FrontendDriver topperc wrote: Ignore the earlier comment I wrote here I misread CodeGenOptions.cpp. This is currently important into the clang Driver library which makes

[llvm] [clang] [Clang][RISCV] Move getVScaleRange logic into libLLVMFrontendDriver. NFC (PR #77327)

2024-01-09 Thread Craig Topper via cfe-commits
https://github.com/topperc deleted https://github.com/llvm/llvm-project/pull/77327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Clang][RISCV] Move getVScaleRange logic into libLLVMFrontendDriver. NFC (PR #77327)

2024-01-09 Thread Craig Topper via cfe-commits
@@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS Support TargetParser FrontendOpenMP + FrontendDriver topperc wrote: I've very confused by naming of the library. It's called FrontendDriver but is currently important by clang's CodeGen library rather than the

[clang-tools-extra] [clangd] Fix typo (PR #77504)

2024-01-09 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/77504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] feb49bb - [clangd] Fix typo in function name in AST.cpp (#77504)

2024-01-09 Thread via cfe-commits
Author: Nour1248 Date: 2024-01-09T18:58:38-05:00 New Revision: feb49bb42433c55a206489d4c8dafd940c019e30 URL: https://github.com/llvm/llvm-project/commit/feb49bb42433c55a206489d4c8dafd940c019e30 DIFF: https://github.com/llvm/llvm-project/commit/feb49bb42433c55a206489d4c8dafd940c019e30.diff

[clang-tools-extra] [clangd] Fix typo (PR #77504)

2024-01-09 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/77504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [lld] [compiler-rt] [openmp] [flang] [lldb] [libclc] [libcxx] [libc] [mlir] [llvm] [clang] [clang-tools-extra] [libunwind] [polly] [WebAssembly] Correctly consider signext/zext arg flags a

2024-01-09 Thread Juneyoung Lee via cfe-commits
aqjune wrote: I updated it to use the paramHasAttr which passed my test as it supposed to do so. :) Thanks for suggestion. https://github.com/llvm/llvm-project/pull/77281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] [lld] [compiler-rt] [openmp] [flang] [lldb] [libclc] [libcxx] [libc] [mlir] [llvm] [clang] [clang-tools-extra] [libunwind] [polly] [WebAssembly] Correctly consider signext/zext arg flags a

2024-01-09 Thread Juneyoung Lee via cfe-commits
https://github.com/aqjune updated https://github.com/llvm/llvm-project/pull/77281 >From 1bbfe05bc50e1fbdb207f21a178b6fc7ab24e8cf Mon Sep 17 00:00:00 2001 From: Juneyoung Lee Date: Mon, 8 Jan 2024 02:01:41 -0600 Subject: [PATCH 1/3] [WebAssembly] Correctly consider signext/zext arg flags at

[lld] [compiler-rt] [openmp] [flang] [lldb] [libcxx] [libc] [mlir] [llvm] [clang] [polly] [WebAssembly] Correctly consider signext/zext arg flags at function declaration (PR #77281)

2024-01-09 Thread Juneyoung Lee via cfe-commits
https://github.com/aqjune updated https://github.com/llvm/llvm-project/pull/77281 >From 1bbfe05bc50e1fbdb207f21a178b6fc7ab24e8cf Mon Sep 17 00:00:00 2001 From: Juneyoung Lee Date: Mon, 8 Jan 2024 02:01:41 -0600 Subject: [PATCH 1/3] [WebAssembly] Correctly consider signext/zext arg flags at

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-09 Thread Kees Cook via cfe-commits
kees wrote: > @kees, the issue should be fixed with the newest push. Nice! This is so extremely close. It fixed all but 1 instance in the torture testing. The remaining seems to be union order sensitive. O_o This arrangement still reports non-zero for the `int count_bytes` one, unless I move

[llvm] [clang] [LLVM][DWARF] Fix accelerator table switching between CU and TU (PR #77511)

2024-01-09 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo updated https://github.com/llvm/llvm-project/pull/77511 >From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Tue, 9 Jan 2024 10:51:55 -0800 Subject: [PATCH 1/4] [LLVM][DWARF] Fix accelerator swtiching with TU

[llvm] [clang] [LLVM][DWARF] Fix accelerator table switching between CU and TU (PR #77511)

2024-01-09 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo edited https://github.com/llvm/llvm-project/pull/77511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [LLVM][DWARF] Fix accelerator table switching between CU and TU (PR #77511)

2024-01-09 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo edited https://github.com/llvm/llvm-project/pull/77511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [LLVM][DWARF] Fix accelerator swtiching with TU re-use (PR #77511)

2024-01-09 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo updated https://github.com/llvm/llvm-project/pull/77511 >From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Tue, 9 Jan 2024 10:51:55 -0800 Subject: [PATCH 1/3] [LLVM][DWARF] Fix accelerator swtiching with TU

[llvm] [clang] [LLVM][DWARF] Fix accelerator swtiching with TU re-use (PR #77511)

2024-01-09 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo updated https://github.com/llvm/llvm-project/pull/77511 >From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Tue, 9 Jan 2024 10:51:55 -0800 Subject: [PATCH 1/2] [LLVM][DWARF] Fix accelerator swtiching with TU

[lld] [compiler-rt] [openmp] [flang] [lldb] [libcxx] [libc] [mlir] [llvm] [clang] [polly] [WebAssembly] Correctly consider signext/zext arg flags at function declaration (PR #77281)

2024-01-09 Thread Derek Schuff via cfe-commits
dschuff wrote: Yeah, sorry I missed Alex's suggestion there. There's no hurry. https://github.com/llvm/llvm-project/pull/77281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2024-01-09 Thread Shafik Yaghmour via cfe-commits
shafik wrote: > ping @shafik @cor3ntin @ChuanqiXu9, how can we make progress here? Please add a release note and address my previous comment: https://github.com/llvm/llvm-project/pull/69076#issuecomment-1780327252 CC @cor3ntin https://github.com/llvm/llvm-project/pull/69076

[clang] [clang] [Driver] Treat MuslEABIHF as a hardfloat environment wrt multiarch directories (PR #77536)

2024-01-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: `bool isEABIHF` from clang/lib/CodeGen/Targets/ARM.cpp can probably be factored. https://github.com/llvm/llvm-project/pull/77536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CMake] Deprecate GCC_INSTALL_PREFIX (PR #77537)

2024-01-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. I'm in favor of removing this. It doesn't make a lot of sense now that we have better config file support. https://github.com/llvm/llvm-project/pull/77537 ___ cfe-commits mailing list

[clang] [Clang][Parser] pop explicitly to keep context stack balance (PR #77312)

2024-01-09 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/77312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake] Deprecate GCC_INSTALL_PREFIX (PR #77537)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes Part of https://reviews.llvm.org/D158218 GCC_INSTALL_PREFIX is a rarely-used legacy option inherited from pre-CMake build system and has configuration file replacement nowadays. Many `clang/test/Driver`

[clang] [CMake] Deprecate GCC_INSTALL_PREFIX (PR #77537)

2024-01-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/77537 Part of https://reviews.llvm.org/D158218 GCC_INSTALL_PREFIX is a rarely-used legacy option inherited from pre-CMake build system and has configuration file replacement nowadays. Many `clang/test/Driver` tests

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-09 Thread Eli Friedman via cfe-commits
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer( return true; }; + const InitListExpr *ILE = dyn_cast(Init); + const CXXParenListInitExpr *CPLIE = dyn_cast(Init); + const StringLiteral *SL = dyn_cast(Init); // If the initializer is an

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-09 Thread Eli Friedman via cfe-commits
@@ -5495,14 +5495,12 @@ static void TryOrBuildParenListInitialization( return; } // ...and value-initialized for each k < i <= n; -if (ArrayLength > Args.size()) { efriedma-quic wrote: What is this change supposed to do? The existing

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-09 Thread Bill Wendling via cfe-commits
bwendling wrote: @kees, the issue should be fixed with the newest push. https://github.com/llvm/llvm-project/pull/76348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] [clang] [llvm] [emacs] Fix Emacs library formatting (PR #76110)

2024-01-09 Thread via cfe-commits
darkfeline wrote: @d0k @r4nt @kirillbobyrev @jpienaar tagging people based on git blame on the files, apologies in advance if you aren't the right persons for this. https://github.com/llvm/llvm-project/pull/76110 ___ cfe-commits mailing list

[clang] [clang] [Driver] Treat MuslEABIHF as a hardfloat environment wrt multiarch directories (PR #77536)

2024-01-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/77536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Convert a few options from CACHE PATH to CACHE STRING (PR #77534)

2024-01-09 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson approved this pull request. https://github.com/llvm/llvm-project/pull/77534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Convert a few options from CACHE PATH to CACHE STRING (PR #77534)

2024-01-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/77534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [compiler-rt] [clang] [mlir] [lldb] [libcxxabi] [libunwind] [lld] [libclc] [libc] [flang] [clang-tools-extra] [openmp] [libcxx] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2024-01-09 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 01/15] [libc++] Implement ranges::contains_subrange ---

[llvm] [compiler-rt] [clang] [mlir] [lldb] [libcxxabi] [libunwind] [lld] [libclc] [libc] [flang] [clang-tools-extra] [openmp] [libcxx] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2024-01-09 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 01/14] [libc++] Implement ranges::contains_subrange ---

[clang] [clang] [Driver] Treat MuslEABIHF as a hardfloat environment wrt multiarch directories (PR #77536)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Martin Storsjö (mstorsjo) Changes If using multiarch directories with musl, the multiarch directory still uses *-linux-gnu triples - which may or may not be intentional, while it is somewhat consistent at least. However, for musl armhf

[clang] [clang] [Driver] Treat MuslEABIHF as a hardfloat environment wrt multiarch directories (PR #77536)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Martin Storsjö (mstorsjo) Changes If using multiarch directories with musl, the multiarch directory still uses *-linux-gnu triples - which may or may not be intentional, while it is somewhat consistent at least. However, for musl

[clang] [clang] [Driver] Treat MuslEABIHF as a hardfloat environment wrt multiarch directories (PR #77536)

2024-01-09 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/77536 If using multiarch directories with musl, the multiarch directory still uses *-linux-gnu triples - which may or may not be intentional, while it is somewhat consistent at least. However, for musl armhf

[libunwind] [libunwind] Convert a few options from CACHE PATH to CACHE STRING (PR #77534)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Martin Storsjö (mstorsjo) Changes This applies the same change as in 760261a3daf98882ccbd177e3133fb4a058f47ad (where they were applied to libcxxabi and libcxx) to libunwind as well. These options can reasonably be set either as an

[libunwind] [libunwind] Convert a few options from CACHE PATH to CACHE STRING (PR #77534)

2024-01-09 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/77534 This applies the same change as in 760261a3daf98882ccbd177e3133fb4a058f47ad (where they were applied to libcxxabi and libcxx) to libunwind as well. These options can reasonably be set either as an absolute or

[llvm] [clang] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-09 Thread Jonas Paulsson via cfe-commits
@@ -11,6 +11,7 @@ //===--===// #include "SystemZ.h" +#include "clang/AST/Decl.h" JonPsson1 wrote: What is the motivation for this? I mean, is there any general consensus that this really

[lldb] [llvm] [libcxxabi] [clang] [clang-tools-extra] [lld] [libcxx] [compiler-rt] [libc] [flang] [RISCV] Support Global Dynamic TLSDESC in the RISC-V backend (PR #66915)

2024-01-09 Thread Paul Kirth via cfe-commits
ilovepi wrote: As @MaskRay pointed out in #66916, there's a bit too much context in this review, so please just ignore my earlier question about moving to a stacked PR. https://github.com/llvm/llvm-project/pull/66915 ___ cfe-commits mailing list

[lldb] [llvm] [libcxxabi] [clang] [clang-tools-extra] [lld] [libcxx] [compiler-rt] [libc] [flang] [RISC-V][LLD] Add Support for RISC-V TLSDESC Relocations (PR #66916)

2024-01-09 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/66916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [libc] [compiler-rt] [lld] [llvm] [libcxxabi] [lldb] [clang] [libcxx] [clang-tools-extra] [RISC-V][LLD] Add Support for RISC-V TLSDESC Relocations (PR #66916)

2024-01-09 Thread Paul Kirth via cfe-commits
ilovepi wrote: sounds good. I'll go ahead and close this in favor of https://github.com/llvm/llvm-project/pull/77516 then, and leave the LLVM PR alone. https://github.com/llvm/llvm-project/pull/66916 ___ cfe-commits mailing list

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

2024-01-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 80d04b253933496d6e6c016f09f0bb987f29b2d4 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 1/4] Add SpaceInParensOption for __attribute__ keyword The

[polly] [flang] [mlir] [openmp] [libc] [compiler-rt] [lld] [llvm] [lldb] [clang] [libcxx] [WebAssembly] Correctly consider signext/zext arg flags at function declaration (PR #77281)

2024-01-09 Thread Juneyoung Lee via cfe-commits
aqjune wrote: I will be back from office in a few hours and check whether I can use CallBase::paramHasAttr. Could you wait a bit until then? https://github.com/llvm/llvm-project/pull/77281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[lldb] [llvm] [clang] [lld] [libcxx] [libc] [mlir] [compiler-rt] [openmp] [polly] [flang] [WebAssembly] Correctly consider signext/zext arg flags at function declaration (PR #77281)

2024-01-09 Thread Derek Schuff via cfe-commits
@@ -839,9 +839,11 @@ bool WebAssemblyFastISel::selectCall(const Instruction *I) { unsigned Reg; -if (Attrs.hasParamAttr(I, Attribute::SExt)) +if (Attrs.hasParamAttr(I, Attribute::SExt) || +(IsDirect && Func->hasParamAttribute(I, Attribute::SExt)))

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

2024-01-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare edited https://github.com/llvm/llvm-project/pull/77522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

2024-01-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 80d04b253933496d6e6c016f09f0bb987f29b2d4 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 1/2] Add SpaceInParensOption for __attribute__ keyword The

[polly] [flang] [mlir] [openmp] [libc] [compiler-rt] [lld] [llvm] [lldb] [clang] [libcxx] [WebAssembly] Correctly consider signext/zext arg flags at function declaration (PR #77281)

2024-01-09 Thread Derek Schuff via cfe-commits
https://github.com/dschuff approved this pull request. Thanks for the fix! https://github.com/llvm/llvm-project/pull/77281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72235)

2024-01-09 Thread David Blaikie via cfe-commits
dwblaikie wrote: looking good from what I've tested - thanks again! https://github.com/llvm/llvm-project/pull/72235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

2024-01-09 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: Love this cleanup! https://github.com/llvm/llvm-project/pull/77365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

2024-01-09 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: This is great, thanks! I do wonder though - why limit it to Darwin? 樂 https://github.com/llvm/llvm-project/pull/77365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[flang] [clang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

2024-01-09 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. LGTM, this is very thoroughly tested and documented now, thank you  Feel free to ignore my final suggestion. https://github.com/llvm/llvm-project/pull/77365 ___ cfe-commits mailing list

[clang] [flang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

2024-01-09 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/77365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir] [lld] [llvm] [compiler-rt] [sanitizer] Select non-internal frames in ReportErrorSummary (PR #77406)

2024-01-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/77406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-09 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 updated https://github.com/llvm/llvm-project/pull/76976 >From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001 From: Alan Zhao Date: Wed, 3 Jan 2024 12:29:21 -0800 Subject: [PATCH 1/5] [clang] Fix parenthesized list initialization of arrays not

[llvm] [clang-tools-extra] [lld] [libc] [lldb] [compiler-rt] [clang] [libcxx] [libcxxabi] [flang] [RISC-V][LLD] Add Support for RISC-V TLSDESC Relocations (PR #66916)

2024-01-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: > @MaskRay , do you think this is worth abandoning in favor of #77516? If so, I > guess I'd also need to abandon #66915, which is unfortunate. You may abandon this in favor of #77516. For the LLVM patch, just use #66915 as it contains a lot of discussions. It's fine to make the

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread Paul T Robinson via cfe-commits
pogo59 wrote: I'm going to be adding some new function descriptions to this file shortly, and figured I should get the formatting thing out of the way first. https://github.com/llvm/llvm-project/pull/77525 ___ cfe-commits mailing list

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/77525 >From cd91a7f0e5cacb682cb6280655a8d1112cecaf6a Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Tue, 9 Jan 2024 13:22:36 -0800 Subject: [PATCH 1/2] [Headers][X86] Reformat ia32intrin.h doc to match the other

[llvm] [clang] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-09 Thread NAKAMURA Takumi via cfe-commits
@@ -11,6 +11,7 @@ //===--===// #include "SystemZ.h" +#include "clang/AST/Decl.h" chapuni wrote: I think we should not depend on `clangAST` here.

[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-09 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni edited https://github.com/llvm/llvm-project/pull/73511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-09 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni requested changes to this pull request. @JonPsson1 I don't have better suggestions right now but I guess you need redesigning. https://github.com/llvm/llvm-project/pull/73511 ___ cfe-commits mailing list

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 47605ffec8864e989905027b2f56277e2dc8b8fa cd91a7f0e5cacb682cb6280655a8d1112cecaf6a --

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: Paul T Robinson (pogo59) Changes Doxygen comment style for every other intrinsic-function header uses /// comments, so change ia32intrin.h from the /** style to /// style. While I was in there, change `c

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/77525 Doxygen comment style for every other intrinsic-function header uses /// comments, so change ia32intrin.h from the /** style to /// style. While I was in there, change ` INSTR ` to `\c INSTR` and toss in a few

[clang] [llvm] [mlir] [compiler-rt] [lld] [sanitizer] Select non-internal frames in ReportErrorSummary (PR #77406)

2024-01-09 Thread Kirill Stoimenov via cfe-commits
https://github.com/kstoimenov approved this pull request. https://github.com/llvm/llvm-project/pull/77406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

2024-01-09 Thread Gedare Bloom via cfe-commits
gedare wrote: > This is migrated from Phabricator, see more discussion there. I will next > provide an option for SpacesInParensOptions.Doubled to control (and override) > injection of spaces within doubled parens `(( ))`. Actually, spaces in double parens might not work out well. It will not

[clang] [clang] Add size filter for stack auto init (PR #74777)

2024-01-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: @jfbastien @fhahn @efriedma-quic I'd like to merge if no other feedback https://github.com/llvm/llvm-project/pull/74777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Gedare Bloom (gedare) Changes The __attribute((specifier-list)) currently is formatted based on the SpacesInParensOptions.Other (previously, SpacesInParentheses). This change allows finer control over addition of spaces between the

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

2024-01-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare created https://github.com/llvm/llvm-project/pull/77522 The __attribute((specifier-list)) currently is formatted based on the SpacesInParensOptions.Other (previously, SpacesInParentheses). This change allows finer control over addition of spaces between the

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread via cfe-commits
https://github.com/XDeme updated https://github.com/llvm/llvm-project/pull/77045 >From d9cbbe48b96d27bff3fc926b60d039ed05f00489 Mon Sep 17 00:00:00 2001 From: XDeme Date: Fri, 5 Jan 2024 01:23:16 -0300 Subject: [PATCH 1/7] [clang-format] Fix crash involving array designators and dangling comma

[clang] [clang] Add tests for CWG1800-1804 (PR #77509)

2024-01-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/77509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for CWG1800-1804 (PR #77509)

2024-01-09 Thread Erich Keane via cfe-commits
@@ -1,16 +1,169 @@ -// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s -verify=expected,cxx98 -fexceptions -Wno-deprecated-builtins -fcxx-exceptions -pedantic-errors -// RUN: %clang_cc1 -std=c++11 -triple x86_64-unknown-unknown %s

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-09 Thread Kees Cook via cfe-commits
kees wrote: > > but the value is nonsense, so we must return 0 so that anything checking > > lengths will not write anything to the array. > > @kees Oh, I see. I did not know such the convention but it makes sense. Is it > documented somewhere? This is new territory (having a multiplier for

[compiler-rt] [lldb] [llvm] [openmp] [lld] [mlir] [clang-tools-extra] [libcxx] [clang] [flang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #75711)

2024-01-09 Thread Reid Kleckner via cfe-commits
rnk wrote: > > I would like some measurements so we can compare build times on Windows. > > I took some benchmarks with `-ftime-trace` on the parse times with and > without this change. > ... > clang-cl built with this PR frontend took ~1368ms to parse. `intrin.h` took > ~969ms to parse.

[libclc] [compiler-rt] [lldb] [llvm] [libunwind] [openmp] [lld] [mlir] [clang-tools-extra] [libcxx] [clang] [flang] [ocaml] Fixed typo error about set_module_identifier in llvm ocaml binding (PR #7747

2024-01-09 Thread via cfe-commits
https://github.com/Yujinmon updated https://github.com/llvm/llvm-project/pull/77479 >From b5586e9935d30a587323699aac2213bae5d14174 Mon Sep 17 00:00:00 2001 From: Yujin <78896558+yujin...@users.noreply.github.com> Date: Tue, 9 Jan 2024 23:14:52 +0900 Subject: [PATCH 1/2] fixed typo error about

[clang] [clang] Add tests for CWG1800-1804 (PR #77509)

2024-01-09 Thread Vlad Serebrennikov via cfe-commits
@@ -1,16 +1,169 @@ -// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s -verify=expected,cxx98 -fexceptions -Wno-deprecated-builtins -fcxx-exceptions -pedantic-errors -// RUN: %clang_cc1 -std=c++11 -triple x86_64-unknown-unknown %s

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

2024-01-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] baa8c2a - [Clang] Wide delimiters ('{{{') for expect strings (#77326)

2024-01-09 Thread via cfe-commits
Author: sethp Date: 2024-01-09T12:45:57-08:00 New Revision: baa8c2abcd8da31549996458c9df4871454b0673 URL: https://github.com/llvm/llvm-project/commit/baa8c2abcd8da31549996458c9df4871454b0673 DIFF: https://github.com/llvm/llvm-project/commit/baa8c2abcd8da31549996458c9df4871454b0673.diff LOG:

[llvm] [clang] [lld] [clang-tools-extra] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-09 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: - Addressed the review comments except https://github.com/llvm/llvm-project/pull/72714/#discussion_r1423345089 (I'll submit a subsequent commit addressing that shortly). - Fixed merge conflict appeared after #77300, see a021f15540300e032446825de805143f0f6214c4.

[llvm] [clang] [lld] [clang-tools-extra] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-09 Thread Daniil Kovalev via cfe-commits
@@ -566,6 +570,7 @@ constexpr const char *knownZFlags[] = { "origin", "pac-plt", "pack-relative-relocs", +"pack-relative-auth-relocs", kovdan01 wrote: Update on my previous comment: changing `getPackDynRelocs` as I suggested above is probably

[clang] [lld] [clang-tools-extra] [llvm] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-09 Thread Daniil Kovalev via cfe-commits
@@ -1444,6 +1444,32 @@ template void RelocationScanner::scanOne(RelTy *) { } } + if (config->emachine == EM_AARCH64 && type == R_AARCH64_AUTH_ABS64) { +// Assume relocations from relocatable objects are RELA. +assert(RelTy::IsRela); +std::lock_guard

[clang] [lld] [clang-tools-extra] [llvm] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-09 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,156 @@ +// REQUIRES: aarch64 kovdan01 wrote: Renamed aarch64-ptrauth.s to aarch64-reloc-pauth.s to make naming consistent with existing tests, aarch64-feature-pauth.s checks the `.note.AARCH64-PAUTH-ABI-tag` stuff. See

[clang] [lld] [clang-tools-extra] [llvm] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-09 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,156 @@ +// REQUIRES: aarch64 + +// RUN: llvm-mc -filetype=obj -triple=aarch64 %p/Inputs/shared2.s -o %t.so.o +// RUN: ld.lld -shared %t.so.o -soname=so -o %t.so +// RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t.o +// RUN: ld.lld -pie -z

[flang] [clang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

2024-01-09 Thread Leandro Lupori via cfe-commits
https://github.com/luporl updated https://github.com/llvm/llvm-project/pull/77365 >From 01a2a8d315af2edb9fe3f0c9b57b5c74935521f1 Mon Sep 17 00:00:00 2001 From: Leandro Lupori Date: Mon, 8 Jan 2024 16:37:54 -0300 Subject: [PATCH 1/6] [flang][driver] Add support for -isysroot in the frontend If

[libcxx] [libc] [lldb] [lld] [llvm] [libcxxabi] [clang-tools-extra] [compiler-rt] [flang] [clang] [RISCV] Support Global Dynamic TLSDESC in the RISC-V backend (PR #66915)

2024-01-09 Thread Paul Kirth via cfe-commits
ilovepi wrote: @topperc @MaskRay , do either of you have strong feelings about abandoning this in favor of https://github.com/llvm/llvm-project/pull/77515? That PR was made w/ `spr` and should be a bit easier to understand/review (since it won't have merge or fixup commits) and will make the

[clang] [lld] [clang-tools-extra] [llvm] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-09 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/72714 >From c493d78e6c482bb530189de05b79e7082a224fab Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Thu, 28 Sep 2023 03:14:35 +0300 Subject: [PATCH 1/5] [lld][AArch64][ELF][PAC] Support AUTH relocations and

[flang] [clang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

2024-01-09 Thread Leandro Lupori via cfe-commits
@@ -0,0 +1,12 @@ +! Verify that the -isysroot flag is known to the frontend and, on Darwin, +! is passed on to the linker. + +! RUN: %flang -### --target=aarch64-apple-darwin -isysroot /path/to/sysroot \ +! RUN:%s 2>&1 | FileCheck %s --check-prefix=CHECK-DARWIN +! RUN:

[libcxx] [libc] [clang] [lldb] [llvm] [libcxxabi] [clang-tools-extra] [compiler-rt] [flang] [lld] [RISC-V][LLD] Add Support for RISC-V TLSDESC Relocations (PR #66916)

2024-01-09 Thread Paul Kirth via cfe-commits
ilovepi wrote: @MaskRay , do you think this is worth abandoning in favor of https://github.com/llvm/llvm-project/pull/77516? If so, I guess I'd also need to abandon https://github.com/llvm/llvm-project/pull/66915, which is unfortunate. https://github.com/llvm/llvm-project/pull/66916

[clang] [clang] Add tests for CWG1800-1804 (PR #77509)

2024-01-09 Thread Vlad Serebrennikov via cfe-commits
@@ -1,16 +1,169 @@ -// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s -verify=expected,cxx98 -fexceptions -Wno-deprecated-builtins -fcxx-exceptions -pedantic-errors -// RUN: %clang_cc1 -std=c++11 -triple x86_64-unknown-unknown %s

<    1   2   3   4   5   6   >