https://github.com/HazardyKnusperkeks closed
https://github.com/llvm/llvm-project/pull/77477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Hirofumi Nakamura
Date: 2024-01-11T20:07:49+01:00
New Revision: 0cc31579e0b690e974163da4077a40b49bfc1ebc
URL:
https://github.com/llvm/llvm-project/commit/0cc31579e0b690e974163da4077a40b49bfc1ebc
DIFF:
HazardyKnusperkeks wrote:
You can of course always ask for commit access:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
https://github.com/llvm/llvm-project/pull/77477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,88 @@
+//===--- ConditionaltostdminmaxCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,88 @@
+//===--- ConditionaltostdminmaxCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,32 @@
+//===--- ConditionaltostdminmaxCheck.h - clang-tidy -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,27 @@
+// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t
+
+void foo() {
+ int value1,value2;
+
+ // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of <
[readability-ConditionalToStdMinMax]
+ if (value1 < value2)
+value1 =
@@ -0,0 +1,27 @@
+// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t
+
+void foo() {
+ int value1,value2;
+
+ // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of <
[readability-ConditionalToStdMinMax]
+ if (value1 < value2)
+value1 =
@@ -0,0 +1,29 @@
+.. title:: clang-tidy - readability-ConditionalToStdMinMax
+
+readability-ConditionalToStdMinMax
+==
+
+Replaces certain conditional statements with equivalent std::min or std::max
expressions,
PiotrZSL wrote:
@@ -0,0 +1,88 @@
+//===--- ConditionaltostdminmaxCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,29 @@
+.. title:: clang-tidy - readability-ConditionalToStdMinMax
+
+readability-ConditionalToStdMinMax
+==
+
+Replaces certain conditional statements with equivalent std::min or std::max
expressions,
+improving readability and
@@ -0,0 +1,27 @@
+// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t
+
+void foo() {
+ int value1,value2;
+
+ // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of <
[readability-ConditionalToStdMinMax]
+ if (value1 < value2)
+value1 =
@@ -0,0 +1,88 @@
+//===--- ConditionaltostdminmaxCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,32 @@
+//===--- ConditionaltostdminmaxCheck.h - clang-tidy -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,27 @@
+// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t
+
+void foo() {
+ int value1,value2;
+
+ // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of <
[readability-ConditionalToStdMinMax]
+ if (value1 < value2)
+value1 =
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -62,6 +63,8 @@ namespace readability {
class ReadabilityModule : public ClangTidyModule {
public:
void addCheckFactories(ClangTidyCheckFactories ) override {
+CheckFactories.registerCheck(
+"readability-ConditionalToStdMinMax");
PiotrZSL
https://github.com/PiotrZSL commented:
Some tweaks needed. Note that there is also issue for:
```
std::max(a, std::max(b, c)) -> std::max({a, b, c})
```
and this check would be nice thing for that also, but not under this PR.
Overall you got something that works, but is very strict, now I would
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -768,15 +768,25 @@ void
ContinuationIndenter::addTokenOnCurrentLine(LineState , bool DryRun,
// parenthesis by disallowing any further line breaks if there is no line
// break after the opening parenthesis. Don't break if it doesn't conserve
// columns.
+ auto
https://github.com/rampitec approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/2
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
The changes LGTM but we should probably add a release note to
https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/docs/ReleaseNotes.rst?plain=1
so users know about the fix.
https://github.com/llvm/llvm-project/pull/70801
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/77704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,27 @@
+// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t
+
+void foo() {
+ int value1,value2;
+
+ // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of <
[readability-ConditionalToStdMinMax]
+ if (value1 < value2)
+value1 =
@@ -0,0 +1,29 @@
+.. title:: clang-tidy - readability-ConditionalToStdMinMax
+
+readability-ConditionalToStdMinMax
+==
+
+Replaces certain conditional statements with equivalent std::min or std::max
expressions,
+improving readability and
@@ -224,6 +224,12 @@ New checks
Recommends the smallest possible underlying type for an ``enum`` or ``enum``
class based on the range of its enumerators.
+- New :doc:`readability-ConditionalToStdMinMax
+ ` check.
+
+ Replaces certain conditional statements with
@@ -0,0 +1,32 @@
+//===--- ConditionaltostdminmaxCheck.h - clang-tidy -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/EugeneZelenko commented:
Check should also add #include if it's not included already.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -62,6 +63,8 @@ namespace readability {
class ReadabilityModule : public ClangTidyModule {
public:
void addCheckFactories(ClangTidyCheckFactories ) override {
+CheckFactories.registerCheck(
+"readability-ConditionalToStdMinMax");
EugeneZelenko
@@ -0,0 +1,32 @@
+//===--- ConditionaltostdminmaxCheck.h - clang-tidy -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -8,6 +8,7 @@ add_clang_library(clangTidyReadabilityModule
AvoidReturnWithVoidValueCheck.cpp
AvoidUnconditionalPreprocessorIfCheck.cpp
BracesAroundStatementsCheck.cpp
+ ConditionaltostdminmaxCheck.cpp
EugeneZelenko wrote:
I think
@@ -0,0 +1,29 @@
+.. title:: clang-tidy - readability-ConditionalToStdMinMax
+
+readability-ConditionalToStdMinMax
+==
+
+Replaces certain conditional statements with equivalent std::min or std::max
expressions,
EugeneZelenko
@@ -0,0 +1,88 @@
+//===--- ConditionaltostdminmaxCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/EugeneZelenko edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request.
But Owen's proposal isn't bad either.
https://github.com/llvm/llvm-project/pull/77522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/rafaelauler approved this pull request.
https://github.com/llvm/llvm-project/pull/76897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tarunprabhu wrote:
> IIUC, this means that on older system compilation will indeed fail without
> `-pthread`, but shouldn't be needed on newer systems. @tarunprabhu - perhaps
> add a link to that article in your test and add a note that on many systems
> compilation will succeed even without
https://github.com/11happy updated
https://github.com/llvm/llvm-project/pull/77816
>From 1883d987b2f83adaef05fdb47ae25c7b06582a64 Mon Sep 17 00:00:00 2001
From: 11happy
Date: Fri, 12 Jan 2024 00:02:46 +0530
Subject: [PATCH 1/3] Add readability check to suggest replacement of
conditional
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Bhuminjay Soni (11happy)
Changes
**Overview:**
This pull request fixes #64914 where author suggests adding a
readability check to propose the replacement of conditional statements with
std::min/std::max for improved code
https://github.com/11happy created
https://github.com/llvm/llvm-project/pull/77816
**Overview:**
This pull request fixes #64914 where author suggests adding a readability check
to propose the replacement of conditional statements with std::min/std::max for
improved code readability.
edymtt wrote:
macOS testing triggered on https://github.com/apple/llvm-project/pull/7962
https://github.com/llvm/llvm-project/pull/77806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,321 @@
+===
+HLSL Function Calls
+===
+
+.. contents::
+ :local:
+
+Introduction
+
+
+This document describes the design and implementation of HLSL's function call
+semantics in Clang. This includes details related to
Author: Chris Bieneman
Date: 2024-01-11T12:34:51-06:00
New Revision: c2fd5b738e9700a515f1730c714897eeec064157
URL:
https://github.com/llvm/llvm-project/commit/c2fd5b738e9700a515f1730c714897eeec064157
DIFF:
@@ -189,11 +189,15 @@ typedef long double tf_float;
#define CRT_LDBL_IEEE_F128
#endif
#define TF_C(x) x##L
-#elif __LDBL_MANT_DIG__ == 113
-// Use long double instead of __float128 if it matches the IEEE 128-bit format.
+#elif __LDBL_MANT_DIG__ == 113 ||
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
#endif
}
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
// The generic implementation only works for ieee754 floating point. For other
// floating
@@ -105,13 +105,34 @@ static bool isValidBaseType(QualType QTy) {
if (RD->hasFlexibleArrayMember())
return false;
// RD can be struct, union, class, interface or enum.
-// For now, we only handle struct and class.
-if (RD->isStruct() || RD->isClass())
+
https://github.com/edymtt edited https://github.com/llvm/llvm-project/pull/77806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/edymtt updated
https://github.com/llvm/llvm-project/pull/77806
>From 7a7f803cfb986f80e00a2615da6d861acbc1bab8 Mon Sep 17 00:00:00 2001
From: Eric Miotto <1094986+edy...@users.noreply.github.com>
Date: Thu, 11 Jan 2024 08:27:21 -0800
Subject: [PATCH] [CMake] Detect properly
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eric Miotto (edymtt)
Changes
[This
linker](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking)
is functionally equivalent to the classic one (`ld64`) for build system
purposes -- in particular
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/edymtt created
https://github.com/llvm/llvm-project/pull/77806
[This
linker](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking)
is functionally equivalent to the classic one (`ld64`) for build system
purposes -- in particular to
@@ -5,6 +5,8 @@
; RUN: %ld64 -lto_library %llvmshlibdir/libLTO.dylib -dylib -arch x86_64
-macos_version_min 10.10.0 -o %t.dylib %t.o -save-temps -undefined
dynamic_lookup -exported_symbol _bar -lSystem -mllvm
-lto-discard-value-names=false
; RUN: llvm-dis
Fznamznon wrote:
> It looks like Clang even has a warning for this specific case and GCC
> considers it shadowing too: https://godbolt.org/z/Y16njoPxh, which makes me
> think that people want this - at least as a separate flag.
I already came across `-Wshadow-uncaptured-local` flag earlier -
@@ -0,0 +1,35 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S
-O2 -Werror -Wall -emit-llvm -o - %s | opt -S -passes=mem2reg,tailcallelim |
https://github.com/SamTebbs33 updated
https://github.com/llvm/llvm-project/pull/77338
>From 091048a63e9c4ac21fd38b8e7483953c602c714f Mon Sep 17 00:00:00 2001
From: Sam Tebbs
Date: Fri, 5 Jan 2024 10:47:01 +
Subject: [PATCH 1/3] [Clang] Rename and enable boolean get, set, create and
undef
ZequanWu wrote:
Heads up! This causes clang crash:
cmd:
```
clang++ "-cc1" "-triple" "x86_64-apple-macosx10.15.0"
"-Wundef-prefix=TARGET_OS_" "-Werror=undef-prefix"
"-Wdeprecated-objc-isa-usage" "-Werror=deprecated-objc-isa-usage" "-emit-obj"
"-femit-dwarf-unwind=no-compact-unwind"
https://github.com/SuperSodaSea updated
https://github.com/llvm/llvm-project/pull/68485
>From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001
From: SuperSodaSea
Date: Sat, 7 Oct 2023 21:05:17 +0800
Subject: [PATCH 01/15] [clang] static operators should evaluate object
Author: erichkeane
Date: 2024-01-11T09:34:08-08:00
New Revision: dd5ce4572fb90323799f1bdf585c01d08613e277
URL:
https://github.com/llvm/llvm-project/commit/dd5ce4572fb90323799f1bdf585c01d08613e277
DIFF:
https://github.com/llvm/llvm-project/commit/dd5ce4572fb90323799f1bdf585c01d08613e277.diff
@@ -1,7 +1,7 @@
-// RUN: %clang_cc1 -triple x86_64-linux -std=c++98 %s -O3 -disable-llvm-passes
-pedantic-errors -emit-llvm -o - | FileCheck %s
-// RUN: %clang_cc1 -triple x86_64-linux -std=c++11 %s -O3 -disable-llvm-passes
-pedantic-errors -emit-llvm -o - | FileCheck %s
-//
dybv-sc wrote:
> Thanks for working on this! I think it would be good to split this up into
> multiple distinct parts for the different improvements.
>
> I put up a patch to support distinct metadata for distinct pointers a while
> ago, which I just moved to GH: #76261.
>
> The discussion on
@@ -1,5 +1,14 @@
// RUN: %clang_cc1 -triple x86_64-apple-darwin -emit-llvm -o %t %s
-// RUN: FileCheck < %t %s
+// RUN: FileCheck -check-prefix CHECK-DWARF < %t %s
+
+// RUN: %clang_cc1 -triple x86_64-w64-windows-gnu -emit-llvm
-fobjc-runtime=gnustep-2.0 -o %t %s
+// RUN:
banach-space wrote:
> Caveat: I am new to the driver and toolchain code so please let me know if I
> missed something!
There's very few who aren't :) There's a lot of history for pretty much every
driver flag - I just end up browsing documentation a lot
Here some relevant content
@@ -5680,8 +5680,13 @@ static ImplicitConversionSequence
TryObjectArgumentInitialization(
QualType ClassType = S.Context.getTypeDeclType(ActingContext);
// [class.dtor]p2: A destructor can be invoked for a const, volatile or
// const volatile object.
+
https://github.com/SuperSodaSea updated
https://github.com/llvm/llvm-project/pull/68485
>From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001
From: SuperSodaSea
Date: Sat, 7 Oct 2023 21:05:17 +0800
Subject: [PATCH 01/14] [clang] static operators should evaluate object
@@ -1,7 +1,7 @@
-// RUN: %clang_cc1 -triple x86_64-linux -std=c++98 %s -O3 -disable-llvm-passes
-pedantic-errors -emit-llvm -o - | FileCheck %s
-// RUN: %clang_cc1 -triple x86_64-linux -std=c++11 %s -O3 -disable-llvm-passes
-pedantic-errors -emit-llvm -o - | FileCheck %s
-//
erichkeane wrote:
> LGTM @erichkeane you want to look at that?
I'd looked at it a while back, and just did another scroll, happy as-is.
https://github.com/llvm/llvm-project/pull/68485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin approved this pull request.
LGTM
@erichkeane you want to look at that?
https://github.com/llvm/llvm-project/pull/68485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/qmfrederik updated
https://github.com/llvm/llvm-project/pull/77797
>From e71dd4b65f08e4a552c86a457d4a9aca2b5c Mon Sep 17 00:00:00 2001
From: Frederik Carlier
Date: Wed, 10 Jan 2024 16:51:18 +
Subject: [PATCH] [ObjC]: Make type encoding safe in symbol names
Type
@@ -1056,6 +1056,23 @@ def CC_Intel_OCL_BI : CallingConv<[
CCDelegateTo
]>;
+def CC_X86_64_Preserve_None : CallingConv<[
+ // We don't preserve general registers, so all of them can be used to pass
+ // arguments except
+ // - RBPframe pointer
+ // - R10
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6a075a9d5dda8f6ce37b176c6d4a7f87a770ec31
5511454cae83ed61062c49a19c56edaf6b9ee1dd --
@@ -184,13 +205,59 @@ llvm::MDNode *CodeGenTBAA::getTypeInfoHelper(const Type
*Ty) {
return getChar();
// Handle pointers and references.
- // TODO: Implement C++'s type "similarity" and consider dis-"similar"
- // pointers distinct.
- if (Ty->isPointerType() ||
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Frederik Carlier (qmfrederik)
Changes
Type encodings are part of symbol names in the Objective C ABI. Replace
characters which are reseved in symbol names:
- ELF: avoid including '@' characters in type encodings
- Windows: avoid
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Frederik Carlier (qmfrederik)
Changes
Type encodings are part of symbol names in the Objective C ABI. Replace
characters which are reseved in symbol names:
- ELF: avoid including '@' characters in type encodings
- Windows: avoid
qmfrederik wrote:
/cc @davidchisnall
https://github.com/llvm/llvm-project/pull/77797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qmfrederik created
https://github.com/llvm/llvm-project/pull/77797
Type encodings are part of symbol names in the Objective C ABI. Replace
characters which are reseved in symbol names:
- ELF: avoid including '@' characters in type encodings
- Windows: avoid including '='
https://github.com/SuperSodaSea updated
https://github.com/llvm/llvm-project/pull/68485
>From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001
From: SuperSodaSea
Date: Sat, 7 Oct 2023 21:05:17 +0800
Subject: [PATCH 01/13] [clang] static operators should evaluate object
Author: erichkeane
Date: 2024-01-11T08:58:07-08:00
New Revision: 923f0392bf050e2e17caa93778e90cf429905694
URL:
https://github.com/llvm/llvm-project/commit/923f0392bf050e2e17caa93778e90cf429905694
DIFF:
https://github.com/llvm/llvm-project/commit/923f0392bf050e2e17caa93778e90cf429905694.diff
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
https://github.com/SuperSodaSea updated
https://github.com/llvm/llvm-project/pull/68485
>From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001
From: SuperSodaSea
Date: Sat, 7 Oct 2023 21:05:17 +0800
Subject: [PATCH 01/12] [clang] static operators should evaluate object
https://github.com/sdesmalen-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/77656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ostannard updated
https://github.com/llvm/llvm-project/pull/74460
>From 890f12e20ebfb7b4ab188f9fa8a46fe262a20783 Mon Sep 17 00:00:00 2001
From: Oliver Stannard
Date: Fri, 1 Dec 2023 10:06:57 +
Subject: [PATCH 1/8] [AArch64] Split feature tests for FP and SIMD
philnik777 wrote:
> @philnik777 I agree strongly with @Fznamznon. If `this` is not captured there
> is no actual shadowing in that they do not occupy encompassing scope, and so
> removing one declaration would not give you access to the other variable.
I don't disagree that this is
@@ -1,60 +1,60 @@
// RUN: %clang_cc1 -fsyntax-only -triple aarch64-none-linux-gnu
-target-feature +sme -verify=expected,notc2x -Wno-strict-prototypes %s
// RUN: %clang_cc1 -fsyntax-only -triple aarch64-none-linux-gnu
-target-feature +sme -verify=expected,c2x %s
-enum
@@ -8806,26 +8806,90 @@ static bool MustDelayAttributeArguments(const
ParsedAttr ) {
return false;
}
+static bool checkArmNewAttrMutualExclusion(Sema , const ParsedAttr ,
+ const FunctionProtoType *FPT,
+
@@ -66,7 +66,7 @@ void test_svzero_mask_za_2(void) __arm_shared_za {
// CHECK-CXX-NEXT:tail call void @llvm.aarch64.sme.zero(i32 255)
// CHECK-CXX-NEXT:ret void
//
-void test_svzero_za(void) __arm_shared_za {
+void test_svzero_za(void) __arm_inout("za") {
@@ -6898,13 +6941,18 @@ at the end of the function.
}];
}
-def ArmSmeNewZADocs : Documentation {
+def ArmNewDocs : Documentation {
let Category = DocCatArmSmeAttributes;
let Content = [{
-The ``__arm_new_za`` keyword applies to function declarations and specifies
@@ -255,6 +255,22 @@ class AttributeCommonInfo {
return SpellingIndex != SpellingNotCalculated;
}
};
+
+enum class KeywordAttributeParseArgumentsKind { None, Optional, Required };
rsandifo-arm wrote:
I think this must fundamentally be a boolean
@@ -30,7 +30,7 @@
// CPP-CHECK-NEXT:tail call void
@llvm.aarch64.sme.write.ver.vg2.nxv16i8(i32 0, i32 [[BASE:%.*]], [[TMP0]], [[TMP1]])
// CPP-CHECK-NEXT:ret void
//
-void test_svwrite_ver_za8_u8_vg2(uint32_t base, svuint8x2_t val)
__arm_streaming __arm_shared_za {
https://github.com/rsandifo-arm edited
https://github.com/llvm/llvm-project/pull/76971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rsandifo-arm commented:
Thanks for the update, looks great to me. The only substantive comment I have
is that I think a given keyword attribute must always take `(` and `)` or never
take them. It shouldn't be optional, because that risks creating parsing
ambiguities, or
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Mirko Brkušanin (mbrkusanin)
Changes
---
Patch is 1002.09 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/77795.diff
62 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
@llvm/pr-subscribers-backend-amdgpu
@llvm/pr-subscribers-clang-codegen
Author: Mirko Brkušanin (mbrkusanin)
Changes
---
Patch is 1002.09 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/77795.diff
mbrkusanin wrote:
Note that the first commit in this PR is:
https://github.com/llvm/llvm-project/pull/77785
https://github.com/llvm/llvm-project/pull/77795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,80 @@
+; RUN: llc -mtriple=x86_64-pc-windows-msvc %s
dyung wrote:
Thanks, that worked, although I did need to manually delete the .s file on the
buildbot because the file was generated in the source tree which is not
normally cleaned between runs.
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/77768
>From 696d4f964805d1af04d4f94dbc8f47adfbc02428 Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sat, 22 Jul 2023 20:07:00 +0100
Subject: [PATCH 1/2] [SemaCXX] Implement CWG2137 (list-initialization from
cor3ntin wrote:
@philnik777 I agree strongly with @Fznamznon.
If `this` is not captured there is no actual shadowing in that they do not
occupy encompassing scope, and so removing one declaration would not give you
access to the other variable.
> Should we still emit shadowing warning in
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/77750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/77750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -489,6 +482,31 @@ transferCFGBlock(const CFGBlock , AnalysisContext
,
}
AC.Log.recordState(State);
}
+
+ // If we have a terminator, evaluate its condition.
+ // This `Expr` may not appear as a `CFGElement` anywhere else, and it's
+ // important that we
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
201 - 300 of 530 matches
Mail list logo