https://github.com/rampitec updated
https://github.com/llvm/llvm-project/pull/74537
>From 7e382620cdc5999c645ed0746f242595f0294c58 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Mon, 4 Dec 2023 16:11:53 -0800
Subject: [PATCH 01/10] [AMDGPU] Use alias info to relax waitcounts for
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/77958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/77958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/changpeng deleted
https://github.com/llvm/llvm-project/pull/2
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1304,6 +1304,18 @@ TEST_F(FormatTestCSharp, CSharpGenericTypeConstraints) {
"}",
Style);
+ // When the where line is not to be formatted, following lines should not
take
+ // on its indentation.
+ verifyFormat("class ItemFactory\n"
@@ -1304,6 +1304,18 @@ TEST_F(FormatTestCSharp, CSharpGenericTypeConstraints) {
"}",
Style);
+ // When the where line is not to be formatted, following lines should not
take
HazardyKnusperkeks wrote:
```suggestion
// When
HazardyKnusperkeks wrote:
> Can someone review this please? Did you see it when I opened the pull request
> 2 weeks ago or only when I added the reviewers just now? I thought reviewers
> would be added automatically.
Every member of @pr-subscribers-clang-format will be informed, and I look
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/76804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -586,7 +586,8 @@ template <>
struct ScalarEnumerationTraits {
static void enumeration(IO , FormatStyle::SeparateDefinitionStyle )
{
IO.enumCase(Value, "Leave", FormatStyle::SDS_Leave);
-IO.enumCase(Value, "Always", FormatStyle::SDS_Always);
+
@@ -17,80 +17,97 @@
namespace clang {
namespace format {
namespace {
+std::string
+separateDefinitionBlocks(llvm::StringRef Code,
+ const std::vector ,
+ const FormatStyle = getLLVMStyle()) {
+ LLVM_DEBUG(llvm::errs() <<
@@ -65,18 +81,18 @@ void DefinitionBlockSeparator::separateBlocks(
}
return false;
};
- unsigned NewlineCount =
- (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Always ? 1 : 0) + 1;
+ unsigned NewlineCount =
@@ -65,18 +81,18 @@ void DefinitionBlockSeparator::separateBlocks(
}
return false;
};
- unsigned NewlineCount =
- (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Always ? 1 : 0) + 1;
+ unsigned NewlineCount =
@@ -586,7 +586,8 @@ template <>
struct ScalarEnumerationTraits {
static void enumeration(IO , FormatStyle::SeparateDefinitionStyle )
{
IO.enumCase(Value, "Leave", FormatStyle::SDS_Leave);
-IO.enumCase(Value, "Always", FormatStyle::SDS_Always);
+
@@ -171,6 +187,31 @@ void DefinitionBlockSeparator::separateBlocks(
return false;
};
+// Separate License text.
+const bool isComment = Lines[I]->isComment();
HazardyKnusperkeks wrote:
```suggestion
const bool IsComment =
https://github.com/HazardyKnusperkeks edited
https://github.com/llvm/llvm-project/pull/77918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks requested changes to this pull request.
I think you want too much in one change.
Maybe first only handle #42112 for what I will be really grateful. And then the
stuff with the _license_, because I see discussion there. As far as I can tell
you just
vitalybuka wrote:
@petrhosek @ldionne
would it be better detect libunwind in LLVM_ENABLE_RUNTIMES?
We have similar thing for lld in compiler-rt.
There are trade offs:
1. checking LLVM_ENABLE_RUNTIMES simplify out of the end user experience,
1. forcing default ON simplifies cmake files and
https://github.com/diggerlin edited
https://github.com/llvm/llvm-project/pull/68919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/diggerlin edited
https://github.com/llvm/llvm-project/pull/68919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2496,6 +2496,26 @@ def int_amdgcn_flat_atomic_fmax_num :
AMDGPUAtomicRtn;
def int_amdgcn_global_atomic_fmin_num : AMDGPUAtomicRtn;
def int_amdgcn_global_atomic_fmax_num : AMDGPUAtomicRtn;
+class AMDGPUGlobalLoadTr :
+ Intrinsic<
+[data_ty],
+[global_ptr_ty],
+
@@ -17016,6 +17056,158 @@ TEST_F(FormatTest, ConfigurableSpacesInParens) {
verifyFormat("size_t idx = (a->foo)(a - 1);", Spaces);
verifyFormat("size_t idx = (*foo)(a - 1);", Spaces);
verifyFormat("size_t idx = (*(foo))(a - 1);", Spaces);
+
+ // Check NonConsecutive
@@ -17001,6 +17056,158 @@ TEST_F(FormatTest, ConfigurableSpacesInParens) {
verifyFormat("size_t idx = (a->foo)(a - 1);", Spaces);
verifyFormat("size_t idx = (*foo)(a - 1);", Spaces);
verifyFormat("size_t idx = (*(foo))(a - 1);", Spaces);
+
+ // Check NonConsecutive
@@ -17016,6 +17056,158 @@ TEST_F(FormatTest, ConfigurableSpacesInParens) {
verifyFormat("size_t idx = (a->foo)(a - 1);", Spaces);
verifyFormat("size_t idx = (*foo)(a - 1);", Spaces);
verifyFormat("size_t idx = (*(foo))(a - 1);", Spaces);
+
+ // Check NonConsecutive
@@ -4007,26 +3992,45 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine ,
return true;
}
- // TODO: check consecutive parens
if (Left.is(tok::l_paren) || Right.is(tok::r_paren)) {
-if (Right.is(TT_CastRParen) ||
-(Left.MatchingParen &&
https://github.com/weiguozhi updated
https://github.com/llvm/llvm-project/pull/76868
>From 90e14918a0eb13e2187f8548416ac72491d966c1 Mon Sep 17 00:00:00 2001
From: Guozhi Wei
Date: Thu, 21 Dec 2023 19:04:44 +
Subject: [PATCH 1/3] New calling convention preserve_none
The new calling
jhuber6 wrote:
> > > An AMDGPU library function is not internalized and can be used to
> > > fullfill calls generated by LLVM passes or instruction selection.
> >
> >
> > I am confused by the description of "internalized". Do you refer to LTO
> > internalization? You can leverage `llvm.used`
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/77013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -210,6 +210,15 @@ let TargetPrefix = "ppc" in { // All intrinsics start
with "llvm.ppc.".
[llvm_float_ty],
[llvm_float_ty, llvm_float_ty, llvm_float_ty, llvm_vararg_ty],
[IntrNoMem]>;
+ // Load of a value provided by the system library
https://github.com/amy-kwan commented:
I think I primarily have minor nit comments. Thank you for the update, Nemanja.
https://github.com/llvm/llvm-project/pull/68919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -1,11 +1,16 @@
-// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-llvm < %s| FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-llvm < %s | FileCheck %s \
+// RUN: --check-prefix=CHECK-X86
+// RUN: %clang_cc1 -triple ppc64le-linux-gnu -emit-llvm < %s |
https://github.com/amy-kwan edited
https://github.com/llvm/llvm-project/pull/68919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/UsmanNadeem closed
https://github.com/llvm/llvm-project/pull/77555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayermolo wrote:
> Could this be caused by the patch
> https://lab.llvm.org/buildbot/#/builders/236/builds/8673 ?
Passes for me locally. Also patch impacts .debug_names for DWARF. So highly
unlikely it would cause this test to fail.
https://github.com/llvm/llvm-project/pull/77511
yxsamliu wrote:
> > An AMDGPU library function is not internalized and can be used to fullfill
> > calls generated by LLVM passes or instruction selection.
>
> I am confused by the description of "internalized". Do you refer to LTO
> internalization? You can leverage `llvm.used` to disable
@@ -26,9 +30,23 @@ if(LLVM_BUILD_INSTRUMENTED)
message(STATUS "To enable merging PGO data LLVM_PROFDATA has to point to
llvm-profdata")
else()
add_custom_target(generate-profdata
- COMMAND "${Python3_EXECUTABLE}"
${CMAKE_CURRENT_SOURCE_DIR}/perf-helper.py
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/77958
>From 3a54757173faffe07da55223c52621691afad54d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Fri, 12 Jan 2024 18:13:06 +
Subject: [PATCH 1/2] [clang] Adjust -mlarge-data-threshold handling
Make it
jyknight wrote:
My suggestion on #69994 had been to stop implying
`_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS` from
`_LIBCPP_ENABLE_CXX20_REMOVED_FEATURES` in LLVM 18 at the same time as
deprecating it. Did you intend to _not_ do that, or was it just missed?
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/77768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -132,6 +142,36 @@ namespace dr2126 { // dr2126: 12
#endif
}
+namespace dr2137 { // dr2137: 18
+#if __cplusplus >= 201103L
+ struct Q {
+Q();
+Q(Q&&);
+Q(std::initializer_list) = delete; // since-cxx11-note 2 {{has been
explicitly marked deleted here}}
+ };
+
@@ -3767,6 +3767,57 @@ void
DependentDecltypeType::Profile(llvm::FoldingSetNodeID ,
E->Profile(ID, Context, true);
}
+PackIndexingType::PackIndexingType(const ASTContext ,
+ QualType Canonical, QualType Pattern,
+
@@ -1665,6 +1665,43 @@ NonTypeTemplateParmDecl
*SubstNonTypeTemplateParmExpr::getParameter() const {
getReplacedTemplateParameterList(getAssociatedDecl())->asArray()[Index]);
}
+PackIndexingExpr *PackIndexingExpr::Create(ASTContext ,
+
@@ -4344,6 +4344,108 @@ class SizeOfPackExpr final
}
};
+class PackIndexingExpr final
+: public Expr,
+ private llvm::TrailingObjects {
+ friend class ASTStmtReader;
+ friend class ASTStmtWriter;
+ friend TrailingObjects;
+
+ SourceLocation EllipsisLoc;
+
+ //
@@ -4344,6 +4344,108 @@ class SizeOfPackExpr final
}
};
+class PackIndexingExpr final
+: public Expr,
+ private llvm::TrailingObjects {
+ friend class ASTStmtReader;
+ friend class ASTStmtWriter;
+ friend TrailingObjects;
+
+ SourceLocation EllipsisLoc;
+
+ //
erichkeane wrote:
> LG with a nit
Thanks for the super quick reviews!
https://github.com/llvm/llvm-project/pull/77957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/77957
>From 12f5f321bc47bffb2d1694e605288c59976022e6 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Fri, 12 Jan 2024 09:30:54 -0800
Subject: [PATCH 1/4] [OpenACC} Improve diagnostics for 'tag's on
@@ -164,6 +164,48 @@ bool isOpenACCSpecialToken(OpenACCSpecialTokenKind Kind,
Token Tok) {
llvm_unreachable("Unknown 'Kind' Passed");
}
+// Used for cases where we have a token we want to check against an
+// 'identifier-like' token, but don't want to give awkward error
https://github.com/alexey-bataev approved this pull request.
LG with a nit
https://github.com/llvm/llvm-project/pull/77957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexey-bataev edited
https://github.com/llvm/llvm-project/pull/77957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Could this be caused by the patch
https://lab.llvm.org/buildbot/#/builders/236/builds/8673 ?
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/77957
>From 12f5f321bc47bffb2d1694e605288c59976022e6 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Fri, 12 Jan 2024 09:30:54 -0800
Subject: [PATCH 1/3] [OpenACC} Improve diagnostics for 'tag's on
@@ -2669,6 +2669,8 @@ bool QualType::isTriviallyRelocatableType(const
ASTContext ) const {
return false;
} else if (const auto *RD = BaseElementType->getAsRecordDecl()) {
return RD->canPassInRegisters();
+ } else if
@@ -18178,6 +18178,51 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned
BuiltinID,
llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy});
return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1});
}
+ case
https://github.com/jdoerfert approved this pull request.
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -164,6 +164,49 @@ bool isOpenACCSpecialToken(OpenACCSpecialTokenKind Kind,
Token Tok) {
llvm_unreachable("Unknown 'Kind' Passed");
}
+// Used for cases where we have a token we want to check against an
+// 'identifier-like' token, but don't want to give awkward error
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/77958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5752,20 +5752,29 @@ void Clang::ConstructJob(Compilation , const
JobAction ,
}
}
- if (Arg *A = Args.getLastArg(options::OPT_mlarge_data_threshold_EQ)) {
-if (!Triple.isX86()) {
- D.Diag(diag::err_drv_unsupported_opt_for_target)
- <<
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/77723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: XDeme
Date: 2024-01-12T10:20:44-08:00
New Revision: 97a9dbb64919fe71379cda5f043633cbeb6438e5
URL:
https://github.com/llvm/llvm-project/commit/97a9dbb64919fe71379cda5f043633cbeb6438e5
DIFF:
https://github.com/llvm/llvm-project/commit/97a9dbb64919fe71379cda5f043633cbeb6438e5.diff
LOG:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/77920
>From 4de3716b55a22dc8b7dda621889089f390026739 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 12 Jan 2024 12:34:16 +
Subject: [PATCH 1/2] [lldb][test] Add tests for
@@ -7519,6 +7519,26 @@ static bool
HandleWebAssemblyFuncrefAttr(TypeProcessingState ,
return false;
}
+/// Rebuild an attributed type without the nullability attribute on it.
+static QualType rebuildAttributedTypeWithoutNullability(ASTContext ,
+
@@ -7539,74 +7559,65 @@ static NullabilityKind
mapNullabilityAttrKind(ParsedAttr::Kind kind) {
}
}
-/// Applies a nullability type specifier to the given type, if possible.
-///
-/// \param state The type processing state.
-///
-/// \param type The type to which the
@@ -7519,6 +7519,26 @@ static bool
HandleWebAssemblyFuncrefAttr(TypeProcessingState ,
return false;
}
+/// Rebuild an attributed type without the nullability attribute on it.
+static QualType rebuildAttributedTypeWithoutNullability(ASTContext ,
+
@@ -15139,6 +15139,37 @@ void Sema::DiagnoseSizeOfParametersAndReturnValue(
}
}
+QualType Sema::AdjustParameterTypeForObjCAutoRefCount(QualType T,
+ SourceLocation NameLoc,
+
@@ -7539,74 +7559,65 @@ static NullabilityKind
mapNullabilityAttrKind(ParsedAttr::Kind kind) {
}
}
-/// Applies a nullability type specifier to the given type, if possible.
-///
-/// \param state The type processing state.
-///
-/// \param type The type to which the
@@ -15139,6 +15139,37 @@ void Sema::DiagnoseSizeOfParametersAndReturnValue(
}
}
+QualType Sema::AdjustParameterTypeForObjCAutoRefCount(QualType T,
+ SourceLocation NameLoc,
+
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e4d01bb2273804355cf84a8a560e578735590ac2
12f5f321bc47bffb2d1694e605288c59976022e6 --
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Arthur Eubanks (aeubanks)
Changes
Make it apply to x86-64 medium and large code models since that's what the
backend does.
Warn if it's used for x86-32.
Default to 0, let the driver set it to 65536 for
rapidsna wrote:
Rebased
https://github.com/llvm/llvm-project/pull/70749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks created
https://github.com/llvm/llvm-project/pull/77958
Make it apply to x86-64 medium and large code models since that's what the
backend does.
Warn if it's used for x86-32.
Default to 0, let the driver set it to 65536 for the medium code model
if one is not
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
The 'cache' directive and various clauses have a 'tag' name that is optional.
This patch cleans up the use of the 'cache' version so that we get a nicer
diagnostic, and enables us to do the same with
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/77957
The 'cache' directive and various clauses have a 'tag' name that is optional.
This patch cleans up the use of the 'cache' version so that we get a nicer
diagnostic, and enables us to do the same with
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/76804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -56966,6 +56965,17 @@ void
X86TargetLowering::LowerAsmOperandForConstraint(SDValue Op,
}
return;
}
+ case 'W': {
+assert(Constraint[1] == 's');
+if (const auto *GA = dyn_cast(Op)) {
+ Ops.push_back(DAG.getTargetGlobalAddress(GA->getGlobal(),
@@ -0,0 +1,34 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=i686 < %s | FileCheck %s
+; RUN: llc -mtriple=x86_64 < %s | FileCheck %s
+
+@var = external dso_local global i32, align 4
+
+define dso_local void @test() {
+;
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/77886
>From f5a33f9e6893250e3584a77630b771ee76693c20 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Thu, 11 Jan 2024 23:42:38 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
Author: Fangrui Song
Date: 2024-01-12T10:09:53-08:00
New Revision: 3bbc912d37f03d9ad3be330b81d91c2eaf6c37f2
URL:
https://github.com/llvm/llvm-project/commit/3bbc912d37f03d9ad3be330b81d91c2eaf6c37f2
DIFF:
https://github.com/llvm/llvm-project/commit/3bbc912d37f03d9ad3be330b81d91c2eaf6c37f2.diff
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/77936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -812,6 +819,23 @@ Address AArch64ABIInfo::EmitMSVAArg(CodeGenFunction ,
Address VAListAddr,
/*allowHigherAlign*/ false);
}
+void AArch64TargetCodeGenInfo::checkFunctionCallABI(
+CodeGenModule , SourceLocation CallLoc, const FunctionDecl
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
#endif
}
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
arichardson wrote:
Looks like this was actually required. Probably needs to be
@@ -5336,6 +5336,7 @@ X86:
operand in a SSE register. If AVX is also enabled, can also be a 256-bit
vector operand in an AVX register. If AVX-512 is also enabled, can also be a
512-bit vector operand in an AVX512 register. Otherwise, an error.
+- ``Ws``: A symbolic
https://github.com/justincady approved this pull request.
[Context](https://github.com/llvm/llvm-project/pull/77203#pullrequestreview-1818501835).
LGTM.
https://github.com/llvm/llvm-project/pull/74140
___
cfe-commits mailing list
rapidsna wrote:
> Thank you for the updates; the changes LGTM!
@AaronBallman Thanks for your review and insightful feedback!
https://github.com/llvm/llvm-project/pull/70749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -405,12 +421,20 @@ void UseAutoCheck::replaceExpr(
auto Diag = diag(Range.getBegin(), Message);
+ bool ShouldReplenishVariableName = isMutliLevelPointerToTypeLocClasses(
+ FirstDecl->getTypeSourceInfo()->getTypeLoc(),
+ {TypeLoc::FunctionProto,
@@ -333,6 +335,26 @@ void UseAutoCheck::replaceIterators(const DeclStmt *D,
ASTContext *Context) {
<< FixItHint::CreateReplacement(Range, "auto");
}
+namespace {
+
+void ignoreTypeLocClasses(
+TypeLoc , llvm::SmallVector const ) {
PiotrZSL wrote:
@@ -333,6 +335,26 @@ void UseAutoCheck::replaceIterators(const DeclStmt *D,
ASTContext *Context) {
<< FixItHint::CreateReplacement(Range, "auto");
}
+namespace {
+
+void ignoreTypeLocClasses(
+TypeLoc , llvm::SmallVector const ) {
+ while
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/77943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -405,12 +421,20 @@ void UseAutoCheck::replaceExpr(
auto Diag = diag(Range.getBegin(), Message);
+ bool ShouldReplenishVariableName = isMutliLevelPointerToTypeLocClasses(
+ FirstDecl->getTypeSourceInfo()->getTypeLoc(),
PiotrZSL wrote:
Would be
@@ -333,6 +335,26 @@ void UseAutoCheck::replaceIterators(const DeclStmt *D,
ASTContext *Context) {
<< FixItHint::CreateReplacement(Range, "auto");
}
+namespace {
+
+void ignoreTypeLocClasses(
+TypeLoc , llvm::SmallVector const ) {
+ while
@@ -333,6 +335,26 @@ void UseAutoCheck::replaceIterators(const DeclStmt *D,
ASTContext *Context) {
<< FixItHint::CreateReplacement(Range, "auto");
}
+namespace {
+
+void ignoreTypeLocClasses(
PiotrZSL wrote:
use static instead of anonymous namespace
https://github.com/PiotrZSL requested changes to this pull request.
Missing tests for arrays and function pointers to confirm that fix work.
+ some nits or possible improvments
https://github.com/llvm/llvm-project/pull/77943
___
cfe-commits mailing
erichkeane wrote:
> > This brings me to conclusion that hand-written style of codegen tests
> > presented above is a better fit for purposes of C++ defect report codegen
> > tests.
>
> I share that conclusion. I think the hand-written IR is easier for people to
> reason because it strips out
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/77637
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan 2024 20:27:53 +0300
Subject: [PATCH 1/7] [clang] Add test for CWG1807
The test checks that
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/77203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Piotr Zegar
Date: 2024-01-12T18:33:49+01:00
New Revision: 3af6ae0fbea40097e159c11893ee7ab57d00480c
URL:
https://github.com/llvm/llvm-project/commit/3af6ae0fbea40097e159c11893ee7ab57d00480c
DIFF:
https://github.com/llvm/llvm-project/commit/3af6ae0fbea40097e159c11893ee7ab57d00480c.diff
@@ -0,0 +1,31 @@
+.. title:: clang-tidy - readability-use-std-min-max
+
+readability-use-std-min-max
+===
+
+Replaces certain conditional statements with equivalent ``std::min`` or
``std::max`` expressions,
+improving readability and promoting the use of
https://github.com/mordante approved this pull request.
Thanks @cor3ntin. The patch still looks fine from libc++'s PoV.
https://github.com/llvm/llvm-project/pull/77768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -2622,6 +2641,31 @@ def SwiftPrivate : InheritableAttr {
let SimpleHandler = 1;
}
+def SwiftVersioned : Attr {
compnerd wrote:
I think that we should name this `SwiftVersionedAddition` to match the
`SwiftVersionedRemoval`.
@@ -2601,6 +2604,22 @@ def SwiftError : InheritableAttr {
let Documentation = [SwiftErrorDocs];
}
+def SwiftImportAsNonGeneric : InheritableAttr {
compnerd wrote:
Wasn't this attribute dropped? I thought that the last usage of this was
removed from the
@@ -301,6 +301,9 @@ class VariadicEnumArgument values,
bit IsExternalType = isExternalType;
}
+// Represents an attribute wrapped by another attribute.
+class AttrArgument : Argument;
compnerd wrote:
Does it make sense to name this `WrappedAttribute`
101 - 200 of 419 matches
Mail list logo
