[clang] b6f922f - Revert "[CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (#75385)"

2024-01-16 Thread Davide Italiano via cfe-commits
Author: Davide Italiano Date: 2024-01-16T17:01:01-08:00 New Revision: b6f922fbf5e983122271aa12acb33f6172046d4d URL: https://github.com/llvm/llvm-project/commit/b6f922fbf5e983122271aa12acb33f6172046d4d DIFF:

[flang] [clang] [llvm] [clang-tools-extra] [compiler-rt] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/69523 >From 6a7f298f403e0e454644f3d945242120f8b2b321 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 18 Oct 2023 04:56:28 -0700 Subject: [PATCH 1/6] workflows: Refactor release-tasks.yml * Split out the lit

[flang] [clang] [llvm] [clang-tools-extra] [compiler-rt] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/69523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [llvm] [clang-tools-extra] [compiler-rt] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Aiden Grossman via cfe-commits
@@ -26,21 +35,26 @@ jobs: prepare: name: Prepare to build binaries runs-on: ubuntu-22.04 -if: github.repository == 'llvm/llvm-project' outputs: - release-version: ${{ steps.validate-tag.outputs.release-version }} - flags: ${{

[libunwind] [libunwind][WebAssembly] Fix libunwind.cpp guard (PR #78230)

2024-01-16 Thread Fangrui Song via cfe-commits
MaskRay wrote: > This should have been &&, meaning neither SjLj nor Wasm uses this file. Thanks for the description. In the future, it'd be better to reference what PR this PR fixes. https://github.com/llvm/llvm-project/pull/78230 ___ cfe-commits

[llvm] [compiler-rt] [flang] [clang] [clang-tools-extra] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/69523 >From 6a7f298f403e0e454644f3d945242120f8b2b321 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 18 Oct 2023 04:56:28 -0700 Subject: [PATCH 1/5] workflows: Refactor release-tasks.yml * Split out the lit

[clang] [clang-cl] document correct defaults for `-fms-compatibility-version` / `-fmsc-version` (PR #76418)

2024-01-16 Thread via cfe-commits
h-vetinari wrote: Cool, thank you! In case you're not simply leaving time for additional reviews, I need to mention that I don't have a commit bit here, so someone will need to push the button for me.  https://github.com/llvm/llvm-project/pull/76418

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w closed https://github.com/llvm/llvm-project/pull/78353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c3f96ac - Revert "[Fix] Disable fdefine-target-os-macros for now" (#78353)

2024-01-16 Thread via cfe-commits
Author: Zixu Wang Date: 2024-01-16T16:48:20-08:00 New Revision: c3f96acb41ef20a1f84715b1b6fb39e916f9aac8 URL: https://github.com/llvm/llvm-project/commit/c3f96acb41ef20a1f84715b1b6fb39e916f9aac8 DIFF: https://github.com/llvm/llvm-project/commit/c3f96acb41ef20a1f84715b1b6fb39e916f9aac8.diff

[llvm] [clang] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

2024-01-16 Thread Davide Italiano via cfe-commits
dcci wrote: Hitting the same problem on a bunch of services. I am going to revert this to unblock people, our repro is similar enough to the one Jeremy shared. ``` $ ./exe clang -cc1 version 18.0.0git based upon LLVM 18.0.0git default target x86_64-redhat-linux-gnu clang++:

[clang] [llvm] [clang-tools-extra] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Tom Stellard via cfe-commits
@@ -26,21 +35,26 @@ jobs: prepare: name: Prepare to build binaries runs-on: ubuntu-22.04 -if: github.repository == 'llvm/llvm-project' outputs: - release-version: ${{ steps.validate-tag.outputs.release-version }} - flags: ${{

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka approved this pull request. https://github.com/llvm/llvm-project/pull/78353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -1098,7 +1098,10 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { -

[llvm] [clang] [clang-tools-extra] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -1404,7 +1404,7 @@ void ASTContext::InitBuiltinTypes(const TargetInfo , getTranslationUnitDecl()->addDecl(MSGuidTagDecl); } } - +// maybe change here also. asl wrote: Ditto https://github.com/llvm/llvm-project/pull/78338

[llvm] [clang] [clang-tools-extra] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -635,16 +635,16 @@ def execute_command(self) -> bool: """ This function reads lines from STDIN and executes the first command that it finds. The 2 supported commands are: -/cherry-pick commit0 <...> asl wrote: Do not

[clang] [clang-tools-extra] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl requested changes to this pull request. Ensure that PR does not contain unrelated things. See https://llvm.org/docs/Contributing.html#how-to-submit-a-patch for more information https://github.com/llvm/llvm-project/pull/78338

[clang-tools-extra] [llvm] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -9,7 +9,9 @@ /// \file /// Defines the Diagnostic-related interfaces. // -//===--===// +//===--===//] + +// look into this file as well

[llvm] [clang] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-16 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/77711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 894c224 - [clang][Driver] Don't ignore -gmodules .gch files (#77711)

2024-01-16 Thread via cfe-commits
Author: Michael Spencer Date: 2024-01-16T15:32:43-08:00 New Revision: 894c22406f68af6574a62a40ec49e058344c324b URL: https://github.com/llvm/llvm-project/commit/894c22406f68af6574a62a40ec49e058344c324b DIFF:

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-16 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 edited https://github.com/llvm/llvm-project/pull/76976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][WebAssembly] Fix libunwind.cpp guard (PR #78230)

2024-01-16 Thread Kazushi Marukawa via cfe-commits
https://github.com/kaz7 approved this pull request. It's compilable on VE now. Thank you! https://github.com/llvm/llvm-project/pull/78230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-16 Thread Alan Zhao via cfe-commits
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer( return true; }; + const InitListExpr *ILE = dyn_cast(Init); + const CXXParenListInitExpr *CPLIE = dyn_cast(Init); + const StringLiteral *SL = dyn_cast(Init); // If the initializer is an

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Sami Tolvanen via cfe-commits
@@ -57,11 +57,16 @@ compiled application or the operating system. Integrating the runtime into the operating system should be preferred since otherwise all thread creation and destruction would need to be intercepted by the application. -The instrumentation makes use of the

[clang] [libc] [libunwind] [clang-tools-extra] [llvm] [lld] [libcxxabi] [lldb] [libcxx] [compiler-rt] [flang] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/78330 >From 8f8917528e30d2ba67f669cfd1a893bc85c21121 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 16 Jan 2024 11:24:03 -0800 Subject: [PATCH] Fixed a bug in Smith's algorithm and made sure last option in

[clang] [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (PR #77686)

2024-01-16 Thread Craig Topper via cfe-commits
@@ -173,25 +183,59 @@ __popcntq(unsigned long long __A) #endif /* __x86_64__ */ #ifdef __x86_64__ +/// Returns the program status and control \c RFLAGS register with the \c VM +///and \c RF flags cleared. +/// +/// \headerfile +/// +/// This intrinsic corresponds to the

[clang] [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (PR #77686)

2024-01-16 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (PR #77686)

2024-01-16 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/77686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

2024-01-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: This is a redo of what was originally in https://github.com/llvm/llvm-project/pull/72442 https://github.com/llvm/llvm-project/pull/78359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Joseph Huber (jhuber6) Changes Summary: The linker wrapper's job is to sort various embedded inputs into a list of files that participate in a single link job. So far, this has been completely 1-to-1, that is, each input file

[clang] [llvm] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: Joseph Huber (jhuber6) Changes Summary: The linker wrapper's job is to sort various embedded inputs into a list of files that participate in a single link job. So far, this has been completely 1-to-1, that is, each input

[clang] [llvm] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: The linker wrapper's job is to sort various embedded inputs into a list of files that participate in a single link job. So far, this has been completely 1-to-1, that is, each input file

[clang] [llvm] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The linker wrapper's job is to sort various embedded inputs into a list of files that participate in a single link job. So far, this has been completely 1-to-1, that is, each input file participates

[clang] [llvm] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

2024-01-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/78359 Summary: The linker wrapper's job is to sort various embedded inputs into a list of files that participate in a single link job. So far, this has been completely 1-to-1, that is, each input file participates in

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-16 Thread Eric Miotto via cfe-commits
https://github.com/edymtt edited https://github.com/llvm/llvm-project/pull/77806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-16 Thread Eric Miotto via cfe-commits
https://github.com/edymtt edited https://github.com/llvm/llvm-project/pull/77806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-16 Thread Eric Miotto via cfe-commits
@@ -211,10 +211,10 @@ if (NOT DEFINED LLVM_LINKER_DETECTED AND NOT WIN32) ) if(APPLE) -if("${stderr}" MATCHES "PROJECT:ld64") +if("${stderr}" MATCHES "PROGRAM:ld") edymtt wrote: Yes, that's the intent -- in fact we are not checking the

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Craig Topper via cfe-commits
@@ -57,11 +57,16 @@ compiled application or the operating system. Integrating the runtime into the operating system should be preferred since otherwise all thread creation and destruction would need to be intercepted by the application. -The instrumentation makes use of the

[llvm] [flang] [clang-tools-extra] [clang] [compiler-rt] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
@@ -806,6 +806,38 @@ static unsigned getOpcodeForRecipe(VPRecipeBase ) { /// Try to simplify recipe \p R. static void simplifyRecipe(VPRecipeBase , VPTypeAnalysis ) { + // Try to remove redundant blend recipes. + if (auto *Blend = dyn_cast()) { +if

[clang] [flang] [llvm] [clang-tools-extra] [compiler-rt] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
@@ -8966,10 +8930,10 @@ VPlanPtr LoopVectorizationPlanner::buildVPlan(VFRange ) { } // Adjust the recipes for reductions. For in-loop reductions the chain of -// instructions leading from the loop exit instr to the phi need to be converted -// to reductions, with one

[llvm] [compiler-rt] [clang] [flang] [clang-tools-extra] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
@@ -996,8 +1028,8 @@ void VPlanTransforms::optimize(VPlan , ScalarEvolution ) { removeRedundantCanonicalIVs(Plan); removeRedundantInductionCasts(Plan); - optimizeInductions(Plan, SE); simplifyRecipes(Plan, SE.getContext()); + optimizeInductions(Plan, SE);

[compiler-rt] [llvm] [flang] [clang] [clang-tools-extra] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
@@ -8292,13 +8271,13 @@ VPRecipeOrVPValueTy VPRecipeBuilder::tryToBlend(PHINode *Phi, for (unsigned In = 0; In < NumIncoming; In++) { VPValue *EdgeMask = createEdgeMask(Phi->getIncomingBlock(In), Phi->getParent(), *Plan); -assert((EdgeMask || NumIncoming ==

[llvm] [compiler-rt] [clang] [clang-tools-extra] [flang] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
@@ -806,6 +806,38 @@ static unsigned getOpcodeForRecipe(VPRecipeBase ) { /// Try to simplify recipe \p R. static void simplifyRecipe(VPRecipeBase , VPTypeAnalysis ) { + // Try to remove redundant blend recipes. + if (auto *Blend = dyn_cast()) { +if

[clang] [flang] [clang-tools-extra] [compiler-rt] [llvm] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
@@ -112,7 +112,6 @@ struct VPlanTransforms { /// Remove redundant EpxandSCEVRecipes in \p Plan's entry block by replacing /// them with already existing recipes expanding the same SCEV expression. static void removeRedundantExpandSCEVRecipes(VPlan ); -

[compiler-rt] [clang] [flang] [clang-tools-extra] [llvm] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
@@ -9079,6 +9043,9 @@ void LoopVectorizationPlanner::adjustRecipesForReductions( LinkVPBB->insert(FMulRecipe, CurrentLink->getIterator()); VecOp = FMulRecipe; } else { +if (PhiR->isInLoop() && isa(CurrentLink)) + continue; +

[clang-tools-extra] [flang] [clang] [llvm] [compiler-rt] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/76090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [compiler-rt] [clang] [clang-tools-extra] [flang] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
https://github.com/fhahn commented: Thanks for taking a look, comments should be addressed! > Wonder if tryTo*()'s should return more specific recipes than VPRecipeBase*, > as in tryToBlend(). That would probably be good now! Should I adjust the current patch or do as follow-up?

[llvm] [compiler-rt] [clang] [clang-tools-extra] [flang] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76090 >From 7c31c8bc2acf60bd50cb6d63944ee8d4946b9638 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 4 May 2023 21:33:24 +0100 Subject: [PATCH 1/3] [VPlan] Replace VPRecieOrVPValue with VP2VP recipe

[clang-tools-extra] [flang] [clang] [llvm] [compiler-rt] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-16 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76090 >From 7c31c8bc2acf60bd50cb6d63944ee8d4946b9638 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 4 May 2023 21:33:24 +0100 Subject: [PATCH 1/2] [VPlan] Replace VPRecieOrVPValue with VP2VP recipe

[clang] [Clang] fix static operator()/[] call not evaluating object (PR #78356)

2024-01-16 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/78356 >From c6d4aca37bf7ede785313135abdad986d9cd783a Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Tue, 16 Jan 2024 21:42:01 + Subject: [PATCH] [Clang] fix static operator()/[] call not evaluating object

[clang] [Clang] fix static operator()/[] call not evaluating object (PR #78356)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mital Ashok (MitalAshok) Changes Fixes #78355 --- Full diff: https://github.com/llvm/llvm-project/pull/78356.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaOverload.cpp (+13-7) - (modified)

[clang] [Clang] fix static operator()/[] call not evaluating object (PR #78356)

2024-01-16 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok created https://github.com/llvm/llvm-project/pull/78356 Fixes #78355 >From 08c7087d4b40a915f123ba3c448a6ca3233af6a1 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Tue, 16 Jan 2024 21:42:01 + Subject: [PATCH] [Clang] fix static operator()/[] call not

[clang] 142f270 - Recommit "[AST] Use APIntStorage to fix memory leak in EnumConstantDecl. (#78311)"

2024-01-16 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2024-01-16T13:52:17-08:00 New Revision: 142f270c279f2576e4618fc0d1121181c7531fdf URL: https://github.com/llvm/llvm-project/commit/142f270c279f2576e4618fc0d1121181c7531fdf DIFF: https://github.com/llvm/llvm-project/commit/142f270c279f2576e4618fc0d1121181c7531fdf.diff

[llvm] [clang] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Paul Kirth via cfe-commits
@@ -151,9 +157,12 @@ Usage To enable ShadowCallStack, just pass the ``-fsanitize=shadow-call-stack`` flag to both compile and link command lines. On aarch64, you also need to pass -``-ffixed-x18`` unless your target already reserves ``x18``. On RISC-V, ``x3`` -(``gp``) is

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Paul Kirth via cfe-commits
@@ -57,11 +57,16 @@ compiled application or the operating system. Integrating the runtime into the operating system should be preferred since otherwise all thread creation and destruction would need to be intercepted by the application. -The instrumentation makes use of the

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Paul Kirth via cfe-commits
@@ -27,6 +27,11 @@ // DEFAULT-NOT: "-target-feature" "-save-restore" // DEFAULT-NOT: "-target-feature" "+save-restore" +// RUN: %clang --target=riscv32-unknown-elf -### %s -mforced-sw-shadow-stack 2>&1 | FileCheck %s -check-prefix=FORCE-SW-SCS ilovepi wrote:

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Paul Kirth via cfe-commits
@@ -1044,3 +1044,8 @@ def FeatureTaggedGlobals : SubtargetFeature<"tagged-globals", "AllowTaggedGlobals", "true", "Use an instruction sequence for taking the address of a global " "that allows a memory tag in the upper address bits">; + +def

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Paul Kirth via cfe-commits
@@ -57,11 +57,16 @@ compiled application or the operating system. Integrating the runtime into the operating system should be preferred since otherwise all thread creation and destruction would need to be intercepted by the application. -The instrumentation makes use of the

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: I think this is basically good IMO once we settle on the default values. You should still get approval from one of the RISCV code owners before landing though. https://github.com/llvm/llvm-project/pull/68075 ___

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/68075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-16 Thread Louis Dionne via cfe-commits
@@ -211,10 +211,10 @@ if (NOT DEFINED LLVM_LINKER_DETECTED AND NOT WIN32) ) if(APPLE) -if("${stderr}" MATCHES "PROJECT:ld64") +if("${stderr}" MATCHES "PROGRAM:ld") ldionne wrote: I'm not certain I understand -- isn't this patch missing

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zixu Wang (zixu-w) Changes https://github.com/llvm/llvm-test-suite/pull/65 fixed the llvm-test-suite errors. Reapply the change to enable `fdefine-target-os-macros` by default for Darwin targets. This reverts commit

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w created https://github.com/llvm/llvm-project/pull/78353 https://github.com/llvm/llvm-test-suite/pull/65 fixed the llvm-test-suite errors. Reapply the change to enable `fdefine-target-os-macros` by default for Darwin targets. This reverts commit

[clang] [BoundsSafety] Initial documentation for -fbounds-safety (PR #70749)

2024-01-16 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna closed https://github.com/llvm/llvm-project/pull/70749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dda2ce8 - [BoundsSafety] Initial documentation for -fbounds-safety (#70749)

2024-01-16 Thread via cfe-commits
Author: Yeoul Na Date: 2024-01-16T13:40:45-08:00 New Revision: dda2ce82c2ec8a3b988636c6cebb76eb32b4de05 URL: https://github.com/llvm/llvm-project/commit/dda2ce82c2ec8a3b988636c6cebb76eb32b4de05 DIFF: https://github.com/llvm/llvm-project/commit/dda2ce82c2ec8a3b988636c6cebb76eb32b4de05.diff

[clang] [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (PR #77686)

2024-01-16 Thread Paul T Robinson via cfe-commits
@@ -361,42 +425,146 @@ _wbinvd(void) { __builtin_ia32_wbinvd(); } +/// Rotates an 8-bit value to the left by the specified number of bits. +///This operation is undefined if the number of bits exceeds the size of +///the value. +/// +/// \headerfile +/// +/// This

[clang] [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (PR #77686)

2024-01-16 Thread Paul T Robinson via cfe-commits
@@ -173,25 +183,59 @@ __popcntq(unsigned long long __A) #endif /* __x86_64__ */ #ifdef __x86_64__ +/// Returns the program status and control \c RFLAGS register with the \c VM +///and \c RF flags cleared. +/// +/// \headerfile +/// +/// This intrinsic corresponds to the

[clang] [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (PR #77686)

2024-01-16 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/77686 >From 39a884d27f56772a222d352665be95194716beff Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 10 Jan 2024 10:42:24 -0800 Subject: [PATCH 1/2] [Headers][X86] Add more descriptions to ia32intrin.h and

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
robincaloudis wrote: > Though please make sure to update the PR message (which will become the > commit message) before merging, as it's no longer accurate Thanks. Description is updated  https://github.com/llvm/llvm-project/pull/71313 ___

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-16 Thread Alan Zhao via cfe-commits
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer( return true; }; + const InitListExpr *ILE = dyn_cast(Init); + const CXXParenListInitExpr *CPLIE = dyn_cast(Init); + const StringLiteral *SL = dyn_cast(Init); // If the initializer is an

[clang] [clang-tools-extra] [llvm] [AMDGPU][GFX12] Add Atomic cond_sub_u32 (PR #76224)

2024-01-16 Thread Mariusz Sikora via cfe-commits
@@ -2502,10 +2500,9 @@ def int_amdgcn_flat_atomic_fmax_num : AMDGPUAtomicRtn; def int_amdgcn_global_atomic_fmin_num : AMDGPUAtomicRtn; def int_amdgcn_global_atomic_fmax_num : AMDGPUAtomicRtn; -def int_amdgcn_flat_atomic_cond_sub_u32 : AMDGPUAtomicRtn; -def

[clang] [clang-tools-extra] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Shourya Goel via cfe-commits
Sh0g0-1758 wrote: ![Screenshot from 2024-01-17 02-48-15](https://github.com/llvm/llvm-project/assets/114918019/c1dcb8a2-f19e-4b05-bf3c-a497aa8753b3) Here is a working implementation of the second issue that I aim to solve. https://github.com/llvm/llvm-project/pull/78338

[clang] [clang-tools-extra] [llvm] [AMDGPU][GFX12] Add Atomic cond_sub_u32 (PR #76224)

2024-01-16 Thread Mariusz Sikora via cfe-commits
https://github.com/mariusz-sikora-at-amd updated https://github.com/llvm/llvm-project/pull/76224 >From 89b94cc98e188142cff11d58f27fe6c25183b376 Mon Sep 17 00:00:00 2001 From: Vang Thao Date: Thu, 21 Dec 2023 11:58:47 +0100 Subject: [PATCH 1/4] [AMDGPU][GFX12] Add Atomic cond_sub_u32 ---

[clang] [clang-tools-extra] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Shourya Goel via cfe-commits
Sh0g0-1758 wrote: I have pushed code in this PR that aims to solve this [issue](https://github.com/llvm/llvm-project/pull/66540) also. https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Shourya Goel via cfe-commits
Sh0g0-1758 wrote: ![Screenshot from 2024-01-17 02-39-09](https://github.com/llvm/llvm-project/assets/114918019/2e5538d1-4541-4222-adcb-ede0f95960fc) Here you can see a working implementation of the asked feature. https://github.com/llvm/llvm-project/pull/78338

[llvm] [libcxx] [libcxxabi] [clang] [lldb] [libc] [clang-tools-extra] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2024-01-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/69498 >From 6f89b118ed56ad7a3af1996e19ccd30cc893c51e Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 14 Jun 2023 17:49:22 -0700 Subject: [PATCH 1/7] [libc++] Fix the behavior of throwing `operator new` under

[llvm] [clang-tools-extra] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Shourya Goel via cfe-commits
https://github.com/Sh0g0-1758 updated https://github.com/llvm/llvm-project/pull/78338 >From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001 From: Sh0g0-1758 Date: Wed, 17 Jan 2024 01:24:17 +0530 Subject: [PATCH 1/3] Fix : more detailed no expected directive message ---

[clang] f3d534c - Revert "[AST] Use APIntStorage to fix memory leak in EnumConstantDecl. (#78311)"

2024-01-16 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2024-01-16T12:39:47-08:00 New Revision: f3d534c4251bb08ee210a49fcf721cefff7ded11 URL: https://github.com/llvm/llvm-project/commit/f3d534c4251bb08ee210a49fcf721cefff7ded11 DIFF: https://github.com/llvm/llvm-project/commit/f3d534c4251bb08ee210a49fcf721cefff7ded11.diff

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #75647)

2024-01-16 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: Good to know that other targets have that sort of "how many work groups will be launched" information. Having that be a min/max (either per dimension or in total or both) may be the right approach here, and this could be a good excuse for the unification being talked about.

[llvm] [clang] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #75647)

2024-01-16 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: We are back to the duplication. The attribute here, num-work-groups, exist in IR as: NVPTX: minctasm -> min work groups NVPTX: maxclusterrank -> max work groups OpenMP: omp_target_num_teams -> right now exact = num work groups @bader This is not the same as the intrinsics but

[clang] [llvm] [clang][CoverageMapping] Refactor when setting MC/DC True/False (PR #78202)

2024-01-16 Thread Alan Phipps via cfe-commits
https://github.com/evodius96 updated https://github.com/llvm/llvm-project/pull/78202 >From 8751417f4889a120193a604e2ea91627f3b064e8 Mon Sep 17 00:00:00 2001 From: Alan Phipps Date: Mon, 15 Jan 2024 12:24:36 -0600 Subject: [PATCH 1/3] [clang][CoverageMapping] Refactor when setting MC/DC

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: Though please make sure to update the PR message (which will become the commit message) before merging, as it's no longer accurate https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][docs] Improve "Obtaining Clang" section (PR #71313)

2024-01-16 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 approved this pull request. Thanks, this looks better now https://github.com/llvm/llvm-project/pull/71313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CoverageMapping] Refactor when setting MC/DC True/False (PR #78202)

2024-01-16 Thread Alan Phipps via cfe-commits
evodius96 wrote: > I've found this change fails with the expression; `((a && (b || c) || (d && > e)) && f)`. Thank you for pointing this out. I think you figured out the point I was struggling to get right -- when to actually "pop" the child Decision from the stack, and also to separate the

[clang] [clang-format] TableGen multi line string support. (PR #78032)

2024-01-16 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/78032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add parse tests for SeparateDefinitionBlocks option (PR #78256)

2024-01-16 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/78256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 59a2653 - [clang-format] Add parse tests for SeparateDefinitionBlocks option (#78256)

2024-01-16 Thread via cfe-commits
Author: serbanu Date: 2024-01-16T21:22:04+01:00 New Revision: 59a265311a072437232767c228263bea0c0074b5 URL: https://github.com/llvm/llvm-project/commit/59a265311a072437232767c228263bea0c0074b5 DIFF: https://github.com/llvm/llvm-project/commit/59a265311a072437232767c228263bea0c0074b5.diff LOG:

[clang] [clang-format] Add parse tests for SeparateDefinitionBlocks option (PR #78256)

2024-01-16 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/78256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang][CoverageMapping] Refactor when setting MC/DC True/False (PR #78202)

2024-01-16 Thread Alan Phipps via cfe-commits
@@ -298,7 +298,7 @@ struct CounterMappingRegion { unsigned ExpandedFileID, unsigned LineStart, unsigned ColumnStart, unsigned LineEnd, unsigned ColumnEnd, RegionKind Kind) - : MCDCParams(MCDCParams),

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2024-01-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/75883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CoverageMapping] Refactor when setting MC/DC True/False (PR #78202)

2024-01-16 Thread Alan Phipps via cfe-commits
@@ -298,7 +298,7 @@ struct CounterMappingRegion { unsigned ExpandedFileID, unsigned LineStart, unsigned ColumnStart, unsigned LineEnd, unsigned ColumnEnd, RegionKind Kind) - : MCDCParams(MCDCParams),

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-16 Thread Eli Friedman via cfe-commits
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer( return true; }; + const InitListExpr *ILE = dyn_cast(Init); + const CXXParenListInitExpr *CPLIE = dyn_cast(Init); + const StringLiteral *SL = dyn_cast(Init); // If the initializer is an

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

2024-01-16 Thread Aaron Ballman via cfe-commits
@@ -13570,6 +13570,15 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) { CreateRecoveryExpr(Init->getBeginLoc(), Init->getEndLoc(), Args); if (RecoveryExpr.get()) VDecl->setInit(RecoveryExpr.get()); + // In general,

<    1   2   3   4   5   6   >